[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-21 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112622144 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamSortRule.scala --- @@ -0,0 +1,67 @@ +/*

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978203#comment-15978203 ] ASF GitHub Bot commented on FLINK-6075: --- Github user rtudoran commented on a diff in the pull

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-21 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112623603 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,353 @@ +/* + *

[GitHub] flink issue #3749: Typo sick -> sink

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3749 Good fix, funny typo ;-) Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3743#discussion_r112636908 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/OverWindowITCase.scala --- @@ -0,0 +1,265 @@ +/*

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978299#comment-15978299 ] ASF GitHub Bot commented on FLINK-6228: --- Github user fhueske commented on a diff in the pull

[GitHub] flink issue #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministi...

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3632 Changes look good to me. Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request #3744: [FLINK-6336] Initial commit of mesos placement con...

2017-04-21 Thread sgran
Github user sgran closed the pull request at: https://github.com/apache/flink/pull/3744 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6336) Placement Constraints for Mesos

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978311#comment-15978311 ] ASF GitHub Bot commented on FLINK-6336: --- GitHub user sgran reopened a pull request:

[GitHub] flink issue #3604: [FLINK-5998] Un-fat Hadoop from Flink fat jar

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3604 @haohui I think this goes into the right direction, but the `flink-shaded-hadoop2-1.3.jar` should be in `/lib`, not in `opt`. That way, we preserve the original behavior (Hadoop dependencies are

[jira] [Commented] (FLINK-5998) Un-fat Hadoop from Flink fat jar

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978312#comment-15978312 ] ASF GitHub Bot commented on FLINK-5998: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6336) Placement Constraints for Mesos

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978310#comment-15978310 ] ASF GitHub Bot commented on FLINK-6336: --- Github user sgran closed the pull request at:

[GitHub] flink pull request #3325: [FLINK-5786] [jobmanager] Add support GetClusterSt...

2017-04-21 Thread mylog00
Github user mylog00 closed the pull request at: https://github.com/apache/flink/pull/3325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Assigned] (FLINK-5786) Add support GetClusterStatus message for standalong flink cluster

2017-04-21 Thread Dmytro Shkvyra (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Shkvyra reassigned FLINK-5786: - Assignee: Dmytro Shkvyra (was: Dmitrii Kniazev) > Add support GetClusterStatus message

[jira] [Created] (FLINK-6353) Restoring using CheckpointedRestoring does not work from 1.2 to 1.2

2017-04-21 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-6353: --- Summary: Restoring using CheckpointedRestoring does not work from 1.2 to 1.2 Key: FLINK-6353 URL: https://issues.apache.org/jira/browse/FLINK-6353 Project:

[jira] [Commented] (FLINK-5476) Fail fast if trying to submit a job to a non-existing Flink cluster

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978399#comment-15978399 ] ASF GitHub Bot commented on FLINK-5476: --- Github user mylog00 closed the pull request at:

[jira] [Created] (FLINK-6354) Add documentation for migration away from Checkpointed interface

2017-04-21 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-6354: --- Summary: Add documentation for migration away from Checkpointed interface Key: FLINK-6354 URL: https://issues.apache.org/jira/browse/FLINK-6354 Project: Flink

[GitHub] flink issue #3623: [FLINK-6196] [table] Support dynamic schema in Table Func...

2017-04-21 Thread clarkyzl
Github user clarkyzl commented on the issue: https://github.com/apache/flink/pull/3623 Hi @fhueske . I've updated the pull request. Could you please also leave some comments on the latest commit? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #3652: [FLINK-6210] close RocksDB in ListViaMergeSpeedMiniBenchm...

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3652 Thank you for the patch! Taking this over and merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-6196) Support dynamic schema in Table Function

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978424#comment-15978424 ] ASF GitHub Bot commented on FLINK-6196: --- Github user clarkyzl commented on the issue:

[GitHub] flink issue #3416: [FLINK-5918] [runtime] port range support for config task...

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3416 @zentol Has this been merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-6176) Add JARs to CLASSPATH deterministically

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978300#comment-15978300 ] ASF GitHub Bot commented on FLINK-6176: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-04-21 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978308#comment-15978308 ] Tzu-Li (Gordon) Tai commented on FLINK-6288: Sure, please go ahead. And thanks for picking

[GitHub] flink pull request #3744: [FLINK-6336] Initial commit of mesos placement con...

2017-04-21 Thread sgran
GitHub user sgran reopened a pull request: https://github.com/apache/flink/pull/3744 [FLINK-6336] Initial commit of mesos placement constraints This adds a HostAttrValueConstraint evaluator for fenzo, allowing tasks to be placed on agents with matching attributes.

[GitHub] flink issue #3600: [FLINK-6117]Make setting of 'zookeeper.sasl.disable' work...

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3600 Thanks @zhengcanbin and @vijikarthi Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-5786) Add support GetClusterStatus message for standalong flink cluster

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978393#comment-15978393 ] ASF GitHub Bot commented on FLINK-5786: --- Github user mylog00 closed the pull request at:

[jira] [Assigned] (FLINK-5476) Fail fast if trying to submit a job to a non-existing Flink cluster

2017-04-21 Thread Dmytro Shkvyra (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Shkvyra reassigned FLINK-5476: - Assignee: Dmytro Shkvyra (was: Dmitrii Kniazev) > Fail fast if trying to submit a job

[jira] [Commented] (FLINK-6210) RocksDB instance should be closed in ListViaMergeSpeedMiniBenchmark

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978426#comment-15978426 ] ASF GitHub Bot commented on FLINK-6210: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5918) port range support for config taskmanager.rpc.port

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978290#comment-15978290 ] ASF GitHub Bot commented on FLINK-5918: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6155) Allow to specify endpoint names

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978323#comment-15978323 ] ASF GitHub Bot commented on FLINK-6155: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3712: [FLINK-6281] Create TableSink for JDBC.

2017-04-21 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3712 Hi @haohui, I think a JdbcTableSink would be a great feature! However, there is a big issue with wrapping the `JdbcOutputFormat`. OutputFormats are not integrated with Flink's checkpointing

[jira] [Commented] (FLINK-6281) Create TableSink for JDBC

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978358#comment-15978358 ] ASF GitHub Bot commented on FLINK-6281: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3416: [FLINK-5918] [runtime] port range support for config task...

2017-04-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3416 no I haven't merged it yet. I wanted to try it out once more but forgot about it :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-5918) port range support for config taskmanager.rpc.port

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978356#comment-15978356 ] ASF GitHub Bot commented on FLINK-5918: --- Github user zentol commented on the issue:

[jira] [Assigned] (FLINK-5476) Fail fast if trying to submit a job to a non-existing Flink cluster

2017-04-21 Thread Dmitrii Kniazev (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitrii Kniazev reassigned FLINK-5476: -- Assignee: (was: Dmytro Shkvyra) > Fail fast if trying to submit a job to a

[jira] [Commented] (FLINK-6351) Refactoring YarnFlinkApplicationMasterRunner by combining AbstractYarnFlinkApplicationMasterRunner in one class

2017-04-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978412#comment-15978412 ] Till Rohrmann commented on FLINK-6351: -- Looks good to me. > Refactoring

[jira] [Commented] (FLINK-6319) Add timeout when shutting SystemProcessingTimeService down

2017-04-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978427#comment-15978427 ] Till Rohrmann commented on FLINK-6319: -- The YARN tests don't cancel jobs, as far as I know. Let me

[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3743#discussion_r112633124 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/call.scala --- @@ -49,6 +57,128 @@ case class Call(functionName:

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978268#comment-15978268 ] ASF GitHub Bot commented on FLINK-6228: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5623) TempBarrier dam has been closed

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978281#comment-15978281 ] ASF GitHub Bot commented on FLINK-5623: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6217) ContaineredTaskManagerParameters sets off heap memory size incorrectly

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978276#comment-15978276 ] ASF GitHub Bot commented on FLINK-6217: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3747: [FLINK-5623] [runtime] Fix TempBarrier dam has been close...

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3747 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] flink issue #3391: [FLINK-5758] [yarn] support port range for web monitor

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3391 @barcahead Please let us know if you want to follow up on this PR... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-5758) Port-range for the web interface via YARN

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978295#comment-15978295 ] ASF GitHub Bot commented on FLINK-5758: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-04-21 Thread Fang Yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978304#comment-15978304 ] Fang Yong commented on FLINK-6288: -- Hi [~tzulitai], I'll pick this issue if nobody follows it, thanks. >

[jira] [Commented] (FLINK-6117) 'zookeeper.sasl.disable' not takes effet when starting CuratorFramework

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978315#comment-15978315 ] ASF GitHub Bot commented on FLINK-6117: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #3498: [FLINK-5476] Fail fast if trying to submit a job t...

2017-04-21 Thread mylog00
Github user mylog00 closed the pull request at: https://github.com/apache/flink/pull/3498 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Assigned] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-04-21 Thread Fang Yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong reassigned FLINK-6288: Assignee: Fang Yong > FlinkKafkaProducer's custom Partitioner is always invoked with number of >

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2017-04-21 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978405#comment-15978405 ] Anton Mushin commented on FLINK-4604: - Hi [~twalthr], Could you look my PR for this issue, please? >

[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3648 Good fix, thanks @haohui I was wondering - I am a trying to advocate fewer dependencies in Flink (there is always the problem of shading and conflicts) so if there is a way to do this

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978287#comment-15978287 ] ASF GitHub Bot commented on FLINK-6228: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3743#discussion_r112635892 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/call.scala --- @@ -49,6 +57,128 @@ case class Call(functionName:

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978298#comment-15978298 ] ASF GitHub Bot commented on FLINK-6228: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3743#discussion_r112636652 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -54,6 +54,9 @@ case class

[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3596 Good changes! I think we could actually drop the explicit endpoint name from the `TaskExecutor` and always let it use a random name (as is the default when no explicit name is given).

[jira] [Commented] (FLINK-4973) Flakey Yarn tests due to recently added latency marker

2017-04-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978430#comment-15978430 ] Till Rohrmann commented on FLINK-4973: -- Hi Andrey, could you share the logs for the failing YARN

[jira] [Created] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-04-21 Thread Fang Yong (JIRA)
Fang Yong created FLINK-6352: Summary: FlinkKafkaConsumer should support to use timestamp to set up start offset Key: FLINK-6352 URL: https://issues.apache.org/jira/browse/FLINK-6352 Project: Flink

[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978173#comment-15978173 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on the issue:

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-21 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112622475 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* +

[GitHub] flink pull request #3749: Typo sick -> sink

2017-04-21 Thread marctrem
GitHub user marctrem opened a pull request: https://github.com/apache/flink/pull/3749 Typo sick -> sink Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items

[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-21 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3743#discussion_r112620324 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/call.scala --- @@ -49,6 +57,128 @@ case class

[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-21 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3743#discussion_r112604758 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/OverWindowITCase.scala --- @@ -0,0 +1,265 @@

[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-21 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3743#discussion_r112628964 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/call.scala --- @@ -49,6 +57,128 @@ case class

[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-21 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3743#discussion_r112605911 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/windows.scala --- @@ -22,6 +22,126 @@ import

[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-21 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3743#discussion_r112628642 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -54,6 +54,9 @@ case class

[jira] [Resolved] (FLINK-6103) LocalFileSystem rename() uses File.renameTo()

2017-04-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-6103. - Resolution: Fixed Fix Version/s: 1.3.0 Fixed via a4f9a54953132fbd1a44888a403576c157649f1f

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978254#comment-15978254 ] ASF GitHub Bot commented on FLINK-6228: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978255#comment-15978255 ] ASF GitHub Bot commented on FLINK-6228: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Closed] (FLINK-6103) LocalFileSystem rename() uses File.renameTo()

2017-04-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-6103. --- > LocalFileSystem rename() uses File.renameTo() > - > >

[jira] [Commented] (FLINK-6103) LocalFileSystem rename() uses File.renameTo()

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978252#comment-15978252 ] ASF GitHub Bot commented on FLINK-6103: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978185#comment-15978185 ] ASF GitHub Bot commented on FLINK-6075: --- Github user rtudoran commented on a diff in the pull

[GitHub] flink pull request #3598: [FLINK-6103] LocalFileSystem rename() uses File.re...

2017-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978118#comment-15978118 ] ASF GitHub Bot commented on FLINK-6013: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112613661 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,97 @@ +/* + *

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978122#comment-15978122 ] ASF GitHub Bot commented on FLINK-6013: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112613595 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978121#comment-15978121 ] ASF GitHub Bot commented on FLINK-6013: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978119#comment-15978119 ] ASF GitHub Bot commented on FLINK-6013: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112613733 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,197 @@ +/* + *

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112614175 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,197 @@ +/* + *

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112613477 --- Diff: flink-dist/src/main/assemblies/opt.xml --- @@ -95,5 +95,12 @@ flink-metrics-statsd-${project.version}.jar

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112613622 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,97 @@ +/* + *

[jira] [Updated] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-04-21 Thread Fang Yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong updated FLINK-6352: - Description: Currently "auto.offset.reset" is used to initialize the start offset of

[GitHub] flink issue #2460: [FLINK-4562] table examples make an divided module in fli...

2017-04-21 Thread shijinkui
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2460 > Hi @shijinkui, yes that sounds good to me. Thanks. When will we merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-21 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112623029 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* +

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978198#comment-15978198 ] ASF GitHub Bot commented on FLINK-6075: --- Github user rtudoran commented on a diff in the pull

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-21 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112623175 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* +

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978257#comment-15978257 ] ASF GitHub Bot commented on FLINK-6228: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978256#comment-15978256 ] ASF GitHub Bot commented on FLINK-6228: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978253#comment-15978253 ] ASF GitHub Bot commented on FLINK-6228: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978117#comment-15978117 ] ASF GitHub Bot commented on FLINK-6013: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978120#comment-15978120 ] ASF GitHub Bot commented on FLINK-6013: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978195#comment-15978195 ] ASF GitHub Bot commented on FLINK-6075: --- Github user rtudoran commented on a diff in the pull

[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978262#comment-15978262 ] ASF GitHub Bot commented on FLINK-4562: --- Github user fhueske commented on the issue:

[GitHub] flink issue #2460: [FLINK-4562] table examples make an divided module in fli...

2017-04-21 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2460 Thanks, @shijinkui I think this PR is good to merge. I was waiting for you to add the examples jar file to the `./opt` folder, but we can also do this as a follow up task. I'll rename

[jira] [Commented] (FLINK-6225) Support Row Stream for CassandraSink

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978151#comment-15978151 ] ASF GitHub Bot commented on FLINK-6225: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3748: [FLINK-6225] [Cassandra Connector] add CassandraTa...

2017-04-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3748#discussion_r112615718 --- Diff: flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java --- @@

[GitHub] flink pull request #3748: [FLINK-6225] [Cassandra Connector] add CassandraTa...

2017-04-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3748#discussion_r112616773 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraTableSink.java --- @@ -0,0

[jira] [Commented] (FLINK-6225) Support Row Stream for CassandraSink

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978153#comment-15978153 ] ASF GitHub Bot commented on FLINK-6225: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6225) Support Row Stream for CassandraSink

2017-04-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978152#comment-15978152 ] ASF GitHub Bot commented on FLINK-6225: --- Github user zentol commented on a diff in the pull request:

  1   2   3   4   >