[jira] [Commented] (FLINK-7738) Create WebSocket handler (server)

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191101#comment-16191101 ] ASF GitHub Bot commented on FLINK-7738: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4767: [FLINK-7738] [flip-6] Create WebSocket handler (se...

2017-10-04 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4767#discussion_r142634775 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestEndpointITCase.java --- @@ -325,6 +406,98 @@ public TestParameters

[GitHub] flink pull request #4767: [FLINK-7738] [flip-6] Create WebSocket handler (se...

2017-10-04 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4767#discussion_r142634073 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -275,4 +301,121 @@ public HttpResponseStatus

[GitHub] flink pull request #4767: [FLINK-7738] [flip-6] Create WebSocket handler (se...

2017-10-04 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4767#discussion_r142633088 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractRestHandler.java --- @@ -157,7 +160,12 @@ protected void

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191097#comment-16191097 ] ASF GitHub Bot commented on FLINK-7068: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4358: [FLINK-7068][blob] change BlobService sub-classes ...

2017-10-04 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4358#discussion_r142635118 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobKey.java --- @@ -83,30 +113,34 @@ public boolean equals(final Object obj) {

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-04 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191095#comment-16191095 ] Xingcan Cui commented on FLINK-7730: Sure. I'll consult the Calcite community for this problem. >

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-04 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191086#comment-16191086 ] Fabian Hueske commented on FLINK-7730: -- Thanks for looking into this [~xccui]! This looks like a

[GitHub] flink pull request #4760: [hotfix][docs] Polish docs index page for consiste...

2017-10-04 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4760#discussion_r142630633 --- Diff: docs/index.md --- @@ -25,27 +25,26 @@ under the License. -This documentation is for Apache Flink version {{

[jira] [Commented] (FLINK-6988) Add Apache Kafka 0.11 connector

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191080#comment-16191080 ] ASF GitHub Bot commented on FLINK-6988: --- Github user pnowojski commented on the issue:

[GitHub] flink issue #4239: [FLINK-6988] flink-connector-kafka-0.11 with exactly-once...

2017-10-04 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4239 @aljoscha rebased on latest master and integrated your changes ---

[jira] [Created] (FLINK-7759) Fix Bug that fieldName/functionName with prefix equals "true" or "false" can't be parsed by ExpressionParser.

2017-10-04 Thread Ruidong Li (JIRA)
Ruidong Li created FLINK-7759: - Summary: Fix Bug that fieldName/functionName with prefix equals "true" or "false" can't be parsed by ExpressionParser. Key: FLINK-7759 URL:

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191067#comment-16191067 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on the issue:

[GitHub] flink issue #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/job/canc...

2017-10-04 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4742 @tillrohrmann I've addressed the majority of your comments. ---

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191065#comment-16191065 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-04 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142625774 --- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/Flip6StandaloneClusterDescriptor.java --- @@ -0,0 +1,62 @@ +/* + * Licensed

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191062#comment-16191062 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-04 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142624817 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -554,6 +557,18 @@ protected int stop(String[] args) {

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-04 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142622511 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191047#comment-16191047 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in the pull request:

[jira] [Assigned] (FLINK-7707) Port CheckpointStatsDetailsSubtasksHandler to new REST endpoint

2017-10-04 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-7707: Assignee: Till Rohrmann > Port CheckpointStatsDetailsSubtasksHandler to new REST endpoint

[GitHub] flink pull request #4770: [FLINK-7754] [rpc] Complete termination future aft...

2017-10-04 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4770 [FLINK-7754] [rpc] Complete termination future after actor has been stopped ## What is the purpose of the change This commit waits not only until the Actor has called postStop but also

[jira] [Commented] (FLINK-7754) Complete termination future after actor has been stopped.

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191024#comment-16191024 ] ASF GitHub Bot commented on FLINK-7754: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-7388) ProcessFunction.onTimer() sets processing time as timestamp

2017-10-04 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191017#comment-16191017 ] Fabian Hueske commented on FLINK-7388: -- [~xccui] is right. This issue is about the timestamp that is

[jira] [Commented] (FLINK-7735) Improve date/time handling in publically-facing Expressions

2017-10-04 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190995#comment-16190995 ] Timo Walther commented on FLINK-7735: - Thanks for starting the discussion about this [~kmurra]. I

[GitHub] flink issue #4748: [hotfix][tests] Use G1GC for tests

2017-10-04 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4748 Mostly for consistency, however using Serial GC on it's own doesn't seem like a better idea compared t G1GC (avoiding long pauses) ---

[GitHub] flink issue #4239: [FLINK-6988] flink-connector-kafka-0.11 with exactly-once...

2017-10-04 Thread ariskk
Github user ariskk commented on the issue: https://github.com/apache/flink/pull/4239 We are really looking forward to this 👍 ---

[jira] [Commented] (FLINK-6988) Add Apache Kafka 0.11 connector

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190973#comment-16190973 ] ASF GitHub Bot commented on FLINK-6988: --- Github user ariskk commented on the issue:

[jira] [Commented] (FLINK-7758) Fix bug Kafka09Fetcher add offset metrics

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190966#comment-16190966 ] ASF GitHub Bot commented on FLINK-7758: --- GitHub user yew1eb opened a pull request:

[GitHub] flink pull request #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher...

2017-10-04 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4769 [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add kafkaMetricGroup ## What is the purpose of the change *Fix bug Kafka09Fetcher no judge the useMetrics is true when add

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190962#comment-16190962 ] ASF GitHub Bot commented on FLINK-7072: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-04 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142605823 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -554,6 +557,18 @@ protected int stop(String[] args) {

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190960#comment-16190960 ] ASF GitHub Bot commented on FLINK-7072: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190959#comment-16190959 ] ASF GitHub Bot commented on FLINK-7072: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-04 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142605564 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-04 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142605663 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190957#comment-16190957 ] ASF GitHub Bot commented on FLINK-7072: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-04 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142605279 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobSubmitRequestBody.java --- @@ -0,0 +1,80 @@ +/* + *

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190952#comment-16190952 ] ASF GitHub Bot commented on FLINK-7072: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-04 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142604070 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to

[jira] [Created] (FLINK-7758) Fix bug Kafka09Fetcher add offset metrics

2017-10-04 Thread Hai Zhou UTC+8 (JIRA)
Hai Zhou UTC+8 created FLINK-7758: - Summary: Fix bug Kafka09Fetcher add offset metrics Key: FLINK-7758 URL: https://issues.apache.org/jira/browse/FLINK-7758 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190885#comment-16190885 ] ASF GitHub Bot commented on FLINK-7757: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190874#comment-16190874 ] ASF GitHub Bot commented on FLINK-7757: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #4764: [FLINK-7757] [checkpointing] Introduce resource guard for...

2017-10-04 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4764 I was commenting on the scenario described in `What is the purpose of the change`. In that case, we want to either fail s2 or remove the lock for s2 as you did. Since we are required to support

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190872#comment-16190872 ] ASF GitHub Bot commented on FLINK-7757: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-04 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142588647 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #4768: [Flink-7704][flip6] Add JobPlanHandler for new Res...

2017-10-04 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4768 [Flink-7704][flip6] Add JobPlanHandler for new RestServerEndpoint ## What is the purpose of the change Add `JobPlanHandler` for the new `RestServerEndpoint`. ## Verifying this

<    1   2   3