[jira] [Updated] (FLINK-7942) NPE when apply FilterJoinRule

2017-10-30 Thread lincoln.lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln.lee updated FLINK-7942: --- Component/s: Table API & SQL > NPE when apply FilterJoinRule > - > >

[jira] [Updated] (FLINK-7942) NPE when apply FilterJoinRule

2017-10-30 Thread lincoln.lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln.lee updated FLINK-7942: --- Description: Test case *testFilterRule1* fails due to a NPE {code} java.lang.RuntimeException: Error

[jira] [Created] (FLINK-7942) NPE when apply FilterJoinRule

2017-10-30 Thread lincoln.lee (JIRA)
lincoln.lee created FLINK-7942: -- Summary: NPE when apply FilterJoinRule Key: FLINK-7942 URL: https://issues.apache.org/jira/browse/FLINK-7942 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-7942) NPE when apply FilterJoinRule

2017-10-30 Thread lincoln.lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln.lee updated FLINK-7942: --- Description: Test case *testFilterRule1* fails due to a NPE {code} java.lang.RuntimeException: Error

[jira] [Commented] (FLINK-7765) Enable dependency convergence

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224495#comment-16224495 ] ASF GitHub Bot commented on FLINK-7765: --- Github user zentol commented on the issue:

[GitHub] flink issue #4777: [FLINK-7765] Enable dependency convergence

2017-10-30 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4777 How does this interact with the shade plugin, i.e. what happens if a relocated transitive dependency has a different version than another direct dependency? ---

[jira] [Commented] (FLINK-7933) Test instability PrometheusReporterTest

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224502#comment-16224502 ] ASF GitHub Bot commented on FLINK-7933: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4908: [FLINK-7933][metrics] Improve PrometheusReporter t...

2017-10-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4908#discussion_r147639583 --- Diff: flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTaskScopeTest.java --- @@ -72,10 +72,30

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224573#comment-16224573 ] ASF GitHub Bot commented on FLINK-7784: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseCommitSi...

2017-10-30 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4910 The changes look very good! @pnowojski could you please also have a look at this? ---

[jira] [Commented] (FLINK-7400) off-heap limits set to conservatively in cluster environments

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224575#comment-16224575 ] ASF GitHub Bot commented on FLINK-7400: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224585#comment-16224585 ] ASF GitHub Bot commented on FLINK-7781: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224588#comment-16224588 ] ASF GitHub Bot commented on FLINK-7781: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224587#comment-16224587 ] ASF GitHub Bot commented on FLINK-7781: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224592#comment-16224592 ] ASF GitHub Bot commented on FLINK-7781: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224586#comment-16224586 ] ASF GitHub Bot commented on FLINK-7781: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #4918: [FLINK-7940] Add FutureUtils.orTimeout

2017-10-30 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4918#discussion_r147658453 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java --- @@ -446,19 +449,67 @@ public void onComplete(Throwable

[GitHub] flink issue #4906: [FLINK-7908][FLINK-7824][QS] Restructure QS packages and ...

2017-10-30 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4906 Sorry for joining the party late, but I don't think that it is a good idea to duplicate code by copying code from one module into the other, as happened for the `FutureUtils` for example. The

[GitHub] flink pull request #4894: [FLINK-7548] [table] Improve rowtime support of Ta...

2017-10-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4894#discussion_r147661477 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSource.scala --- @@ -38,23 +38,26 @@ import

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224616#comment-16224616 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on a diff in the pull

[jira] [Created] (FLINK-7944) Allow configuring Hadoop Classpath

2017-10-30 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-7944: --- Summary: Allow configuring Hadoop Classpath Key: FLINK-7944 URL: https://issues.apache.org/jira/browse/FLINK-7944 Project: Flink Issue Type:

[jira] [Commented] (FLINK-7838) Kafka011ProducerExactlyOnceITCase do not finish

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224563#comment-16224563 ] ASF GitHub Bot commented on FLINK-7838: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4506: [FLINK-7400][cluster] fix off-heap limits set to c...

2017-10-30 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4506#discussion_r147656471 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredTaskManagerParameters.java --- @@ -143,7 +143,8 @@ public static

[GitHub] flink pull request #4915: [FLINK-7838] Bunch of hotfixes and fix missing syn...

2017-10-30 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4915#discussion_r147656743 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java --- @@ -226,13

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147649898 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java --- @@ -0,0 +1,223 @@

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224583#comment-16224583 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147655793 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractMetricsHandler.java --- @@ -39,12 +39,15 @@ * If the

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147657820 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/DoubleAccumulator.java --- @@ -0,0 +1,260 @@ +/* + *

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147651247 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java --- @@ -0,0 +1,223 @@

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147651957 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java --- @@ -0,0 +1,223 @@

[GitHub] flink pull request #4894: [FLINK-7548] [table] Improve rowtime support of Ta...

2017-10-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4894#discussion_r147658004 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceUtil.scala --- @@ -0,0 +1,518 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224590#comment-16224590 ] ASF GitHub Bot commented on FLINK-7781: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224591#comment-16224591 ] ASF GitHub Bot commented on FLINK-7781: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224589#comment-16224589 ] ASF GitHub Bot commented on FLINK-7781: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224593#comment-16224593 ] ASF GitHub Bot commented on FLINK-7781: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224594#comment-16224594 ] ASF GitHub Bot commented on FLINK-7781: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-7943) OptionalDataException when launching Flink jobs concurrently

2017-10-30 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224611#comment-16224611 ] Till Rohrmann commented on FLINK-7943: -- The problem has most likely to do with serializing a

[jira] [Comment Edited] (FLINK-7943) OptionalDataException when launching Flink jobs concurrently

2017-10-30 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224611#comment-16224611 ] Till Rohrmann edited comment on FLINK-7943 at 10/30/17 10:13 AM: - The

[GitHub] flink pull request #4894: [FLINK-7548] [table] Improve rowtime support of Ta...

2017-10-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4894#discussion_r147661037 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamTableSourceScan.scala --- @@ -56,33 +63,123 @@

[GitHub] flink pull request #4872: [FLINK-7876] Register TaskManagerMetricGroup under...

2017-10-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4872#discussion_r147666537 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java --- @@ -166,4 +169,12 @@ void

[jira] [Commented] (FLINK-7876) Register TaskManagerMetricGroup under ResourceID instead of InstanceID

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224645#comment-16224645 ] ASF GitHub Bot commented on FLINK-7876: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7876) Register TaskManagerMetricGroup under ResourceID instead of InstanceID

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224647#comment-16224647 ] ASF GitHub Bot commented on FLINK-7876: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4872: [FLINK-7876] Register TaskManagerMetricGroup under...

2017-10-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4872#discussion_r147665524 --- Diff: flink-mesos/src/main/scala/org/apache/flink/mesos/runtime/clusterframework/MesosJobManager.scala --- @@ -31,7 +31,8 @@ import

[jira] [Commented] (FLINK-7876) Register TaskManagerMetricGroup under ResourceID instead of InstanceID

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224642#comment-16224642 ] ASF GitHub Bot commented on FLINK-7876: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7876) Register TaskManagerMetricGroup under ResourceID instead of InstanceID

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224641#comment-16224641 ] ASF GitHub Bot commented on FLINK-7876: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4872: [FLINK-7876] Register TaskManagerMetricGroup under...

2017-10-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4872#discussion_r147655034 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherTest.java --- @@ -76,25 +74,22 @@ public void

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147668677 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java --- @@ -0,0 +1,223 @@

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224651#comment-16224651 ] ASF GitHub Bot commented on FLINK-7781: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147669457 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java --- @@ -0,0 +1,223 @@

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224654#comment-16224654 ] ASF GitHub Bot commented on FLINK-7781: --- Github user zentol commented on a diff in the pull request:

[jira] [Assigned] (FLINK-7943) OptionalDataException when launching Flink jobs concurrently

2017-10-30 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-7943: Assignee: Till Rohrmann > OptionalDataException when launching Flink jobs concurrently >

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147662205 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -362,4 +483,39 @@

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147656635 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -58,18 +61,37 @@

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147653427 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -442,13

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147659966 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -58,18 +61,37 @@

[jira] [Commented] (FLINK-7944) Allow configuring Hadoop Classpath

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224680#comment-16224680 ] ASF GitHub Bot commented on FLINK-7944: --- GitHub user aljoscha opened a pull request:

[jira] [Commented] (FLINK-7838) Kafka011ProducerExactlyOnceITCase do not finish

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224737#comment-16224737 ] ASF GitHub Bot commented on FLINK-7838: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4915: [FLINK-7838] Bunch of hotfixes and fix missing syn...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4915#discussion_r147675169 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java --- @@

[jira] [Commented] (FLINK-7938) support addAll() in ListState

2017-10-30 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224751#comment-16224751 ] Aljoscha Krettek commented on FLINK-7938: - Sounds good  > support addAll() in ListState >

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224753#comment-16224753 ] ASF GitHub Bot commented on FLINK-7784: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224756#comment-16224756 ] ASF GitHub Bot commented on FLINK-7784: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147679162 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -58,18 +61,37 @@

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147679890 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -293,26 +330,110 @@ public

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224763#comment-16224763 ] ASF GitHub Bot commented on FLINK-7784: --- Github user GJL commented on a diff in the pull request:

[jira] [Created] (FLINK-7945) kafka-connector10 use kafkaConsumer0.9 caused it lost the important metric in kafka clients10

2017-10-30 Thread aitozi (JIRA)
aitozi created FLINK-7945: - Summary: kafka-connector10 use kafkaConsumer0.9 caused it lost the important metric in kafka clients10 Key: FLINK-7945 URL: https://issues.apache.org/jira/browse/FLINK-7945

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224785#comment-16224785 ] ASF GitHub Bot commented on FLINK-7784: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147681959 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -58,18 +61,37 @@

[GitHub] flink pull request #4872: [FLINK-7876] Register TaskManagerMetricGroup under...

2017-10-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4872#discussion_r147657172 --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingCluster.scala --- @@ -42,7 +42,8 @@ import

[GitHub] flink pull request #4872: [FLINK-7876] Register TaskManagerMetricGroup under...

2017-10-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4872#discussion_r147654224 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/UnregisteredTaskMetricsGroup.java --- @@ -28,15 +28,15 @@ import

[jira] [Commented] (FLINK-7876) Register TaskManagerMetricGroup under ResourceID instead of InstanceID

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224643#comment-16224643 ] ASF GitHub Bot commented on FLINK-7876: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7876) Register TaskManagerMetricGroup under ResourceID instead of InstanceID

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224644#comment-16224644 ] ASF GitHub Bot commented on FLINK-7876: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4872: [FLINK-7876] Register TaskManagerMetricGroup under...

2017-10-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4872#discussion_r147656394 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java --- @@ -163,12 +156,14 @@ public JobLeaderService

[GitHub] flink pull request #4872: [FLINK-7876] Register TaskManagerMetricGroup under...

2017-10-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4872#discussion_r147657678 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java --- @@ -80,7 +80,6 @@ import akka.actor.ActorRef;

[jira] [Commented] (FLINK-7876) Register TaskManagerMetricGroup under ResourceID instead of InstanceID

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224646#comment-16224646 ] ASF GitHub Bot commented on FLINK-7876: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224658#comment-16224658 ] ASF GitHub Bot commented on FLINK-7781: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147670055 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/DoubleAccumulator.java --- @@ -0,0 +1,260 @@ +/* + *

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224657#comment-16224657 ] ASF GitHub Bot commented on FLINK-7781: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147663332 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -194,29 +348,4 @@

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147661454 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -293,26 +330,110 @@

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147655000 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -922,6

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147659714 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -293,26 +330,110 @@

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224672#comment-16224672 ] ASF GitHub Bot commented on FLINK-7784: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224673#comment-16224673 ] ASF GitHub Bot commented on FLINK-7784: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147658988 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -58,18 +61,37 @@

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147661097 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -293,26 +330,110 @@

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224667#comment-16224667 ] ASF GitHub Bot commented on FLINK-7784: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224676#comment-16224676 ] ASF GitHub Bot commented on FLINK-7784: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147670239 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -35,60 +42,101 @@

[GitHub] flink pull request #4920: [FLINK-7944] Allow configuring Hadoop classpath

2017-10-30 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/4920 [FLINK-7944] Allow configuring Hadoop classpath R: @StephanEwen You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147672407 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -35,60 +42,101 @@

[GitHub] flink issue #4901: [FLINK-7781][metrics][REST] Support on-demand aggregation...

2017-10-30 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4901 @kl0u I've addressed your comments. ---

[jira] [Commented] (FLINK-7781) Support simple on-demand metrics aggregation

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224713#comment-16224713 ] ASF GitHub Bot commented on FLINK-7781: --- Github user zentol commented on the issue:

[GitHub] flink pull request #4915: [FLINK-7838] Bunch of hotfixes and fix missing syn...

2017-10-30 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4915#discussion_r147674418 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java --- @@

[jira] [Commented] (FLINK-7574) flink-clients

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224731#comment-16224731 ] ASF GitHub Bot commented on FLINK-7574: --- Github user zentol commented on the issue:

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147677068 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -35,60 +42,101 @@

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224744#comment-16224744 ] ASF GitHub Bot commented on FLINK-7784: --- Github user GJL commented on a diff in the pull request:

[jira] [Updated] (FLINK-7932) Best Practices docs recommend passing parameters through open(Configuration c)

2017-10-30 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7932: Fix Version/s: 1.3.3 > Best Practices docs recommend passing parameters through

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224752#comment-16224752 ] ASF GitHub Bot commented on FLINK-7784: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #4910: [FLINK-7784] [kafka-producer] Don't fail TwoPhaseC...

2017-10-30 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147678610 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -194,29 +348,4 @@ public

[jira] [Commented] (FLINK-7784) Don't fail TwoPhaseCommitSinkFunction when failing to commit

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224760#comment-16224760 ] ASF GitHub Bot commented on FLINK-7784: --- Github user GJL commented on a diff in the pull request:

  1   2   3   4   >