[GitHub] flink pull request #5186: [FLINK-8288] [runtime] register job master rest en...

2018-01-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5186#discussion_r160368484 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/JobClusterEntrypoint.java --- @@ -132,6 +122,16 @@ protected void

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318199#comment-16318199 ] ASF GitHub Bot commented on FLINK-7511: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318198#comment-16318198 ] ASF GitHub Bot commented on FLINK-7511: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-09 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160363378 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed to

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-09 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160349688 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -150,16 +126,13 @@ */ private boolean

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318166#comment-16318166 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r160361957 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java --- @@ -88,6 +93,35 @@ public void run() {

[jira] [Created] (FLINK-8391) Improve dependency documentation for queryable state

2018-01-09 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-8391: Summary: Improve dependency documentation for queryable state Key: FLINK-8391 URL: https://issues.apache.org/jira/browse/FLINK-8391 Project: Flink Issue

[jira] [Commented] (FLINK-8350) replace "taskmanager.tmp.dirs" with "env.io.tmp.dirs" for all components

2018-01-09 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318130#comment-16318130 ] Nico Kruber commented on FLINK-8350: I'd prefer {{io.tmp.dirs}} to not pollute the configuration

[jira] [Commented] (FLINK-8279) Use Mesos/YARN temp directories as fallback for BlobServer/Cache temp directories

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318112#comment-16318112 ] ASF GitHub Bot commented on FLINK-8279: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #5176: [FLINK-8279][blob] fall back to TaskManager temp d...

2018-01-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5176#discussion_r160353839 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java --- @@ -127,21 +132,28 @@ private static BlobStoreService

[jira] [Commented] (FLINK-8352) Flink UI Reports No Error on Job Submission Failures

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318108#comment-16318108 ] ASF GitHub Bot commented on FLINK-8352: --- Github user uce commented on the issue:

[GitHub] flink issue #5264: [FLINK-8352][web-dashboard] Flink UI Reports No Error on ...

2018-01-09 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5264 Build failure is unrelated (YARN test). Merging this. Thanks! ---

[jira] [Commented] (FLINK-6094) Implement stream-stream proctime non-window inner join

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318096#comment-16318096 ] ASF GitHub Bot commented on FLINK-6094: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (FLINK-6094) Implement stream-stream proctime non-window inner join

2018-01-09 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-6094. - Resolution: Fixed Fix Version/s: 1.5.0 Fixed in 1.5:

[GitHub] flink pull request #4471: [FLINK-6094] [table] Implement stream-stream proct...

2018-01-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4471 ---

[jira] [Commented] (FLINK-8371) Buffers are not recycled in a non-spilled SpillableSubpartition upon release

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318087#comment-16318087 ] ASF GitHub Bot commented on FLINK-8371: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #5261: [FLINK-8371][network] always recycle Buffers when ...

2018-01-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5261#discussion_r160349800 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java --- @@ -52,6 +55,10 @@ /** Flag

[GitHub] flink issue #5048: [Flink-7871] [flip6] SlotPool should release unused slots...

2018-01-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5048 Hi @ifndef-SleePy, did you find time to rebase your PR onto the latest master? If you need help, then let me know. ---

[jira] [Commented] (FLINK-7578) WindowStream should support rich AggregateFunction

2018-01-09 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318021#comment-16318021 ] Hequn Cheng commented on FLINK-7578: [~sunjincheng121] Hi, thanks for your information. I will check

[jira] [Comment Edited] (FLINK-3089) State API Should Support Data Expiration (State TTL)

2018-01-09 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318013#comment-16318013 ] Bowen Li edited comment on FLINK-3089 at 1/9/18 8:27 AM: - [~sihuazhou] If we don't

[jira] [Commented] (FLINK-3089) State API Should Support Data Expiration (State TTL)

2018-01-09 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318013#comment-16318013 ] Bowen Li commented on FLINK-3089: - [~sihuazhou] If we don't enforce deletion, TtlDB won't promise to

[jira] [Commented] (FLINK-7909) Unify cluster creation for test bases

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317989#comment-16317989 ] ASF GitHub Bot commented on FLINK-7909: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-7909) Unify cluster creation for test bases

2018-01-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7909. Resolution: Fixed Fix Version/s: 1.5.0 Fixed via b90210e3712a54ad85a33dfc308a03e0c4a2a250

[GitHub] flink pull request #4889: [FLINK-7903] [tests] Add flip6 build profile

2018-01-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4889 ---

[jira] [Closed] (FLINK-7904) Enable Flip6 build profile on Travis

2018-01-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7904. Resolution: Fixed Fixed via a03cdfabe6eab48509b42a6831a21e488b9c3e80 > Enable Flip6 build profile

[jira] [Closed] (FLINK-7903) Add Flip6 build profile

2018-01-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7903. Resolution: Fixed Fixed via 2d97cc1873b71b237e827d843cd5bd6d40f86d9c > Add Flip6 build profile >

[GitHub] flink pull request #4890: [FLINK-7904] Enable Flip6 build profile on Travis

2018-01-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4890 ---

[jira] [Commented] (FLINK-7903) Add Flip6 build profile

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317992#comment-16317992 ] ASF GitHub Bot commented on FLINK-7903: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7904) Enable Flip6 build profile on Travis

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317993#comment-16317993 ] ASF GitHub Bot commented on FLINK-7904: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4896: [FLINK-7909] Unify Flink test bases

2018-01-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4896 ---

[jira] [Commented] (FLINK-7578) WindowStream should support rich AggregateFunction

2018-01-09 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317975#comment-16317975 ] sunjincheng commented on FLINK-7578: Hi [~hequn8128] May be the issue is fixed by

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317972#comment-16317972 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on a diff in the pull

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317971#comment-16317971 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-09 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r160333139 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java --- @@ -88,6 +93,35 @@ public void run() {

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-09 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r160333068 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java --- @@ -88,6 +93,35 @@ public void run() {

<    1   2   3