[jira] [Commented] (FLINK-7386) Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371097#comment-16371097 ] ASF GitHub Bot commented on FLINK-7386: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4675: [FLINK-7386] FIx Elasticsearch 5 connector is not ...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4675#discussion_r169564689 --- Diff: flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/BulkProcessorIndexer.java ---

[jira] [Commented] (FLINK-8703) Migrate tests from LocalFlinkMiniCluster to MiniClusterResource

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371093#comment-16371093 ] ASF GitHub Bot commented on FLINK-8703: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-8703) Migrate tests from LocalFlinkMiniCluster to MiniClusterResource

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371095#comment-16371095 ] ASF GitHub Bot commented on FLINK-8703: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-8560) add KeyedProcessFunction to expose the key in onTimer() and other methods

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371135#comment-16371135 ] ASF GitHub Bot commented on FLINK-8560: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8560) add KeyedProcessFunction to expose the key in onTimer() and other methods

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371132#comment-16371132 ] ASF GitHub Bot commented on FLINK-8560: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8560) add KeyedProcessFunction to expose the key in onTimer() and other methods

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371136#comment-16371136 ] ASF GitHub Bot commented on FLINK-8560: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8560) add KeyedProcessFunction to expose the key in onTimer() and other methods

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371137#comment-16371137 ] ASF GitHub Bot commented on FLINK-8560: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink issue #5528: [FLINK-6489] [FLINK-8696] [shell scripts] Remove JobManag...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5528 There's still a reference to `start-local.sh` in `common.sh`: ``` function start_cluster { if [[ "$CLUSTER_MODE" == "local" ]]; then $FLINK_DIR/bin/start-local.sh elif [[

[jira] [Commented] (FLINK-6489) Rework 'start-local.bat' to 'start-local-cluster.bat'

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371141#comment-16371141 ] ASF GitHub Bot commented on FLINK-6489: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-6489) Rework 'start-local.bat' to 'start-local-cluster.bat'

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371166#comment-16371166 ] ASF GitHub Bot commented on FLINK-6489: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5535: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-21 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5535 JobManagerHACheckpointRecoveryITCase still use ```LocalFlinkMiniCluster``` as it's default one. And we seem to be lost refactor it. And I dont think it is a very easy work since in this

[jira] [Commented] (FLINK-8717) Flink seems to deadlock due to buffer starvation when iterating

2018-02-21 Thread Romain Revol (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371087#comment-16371087 ] Romain Revol commented on FLINK-8717: - Hi, you're right, that's exactly my issue. Thanks for pointing

[jira] [Commented] (FLINK-8714) Suggest new users to use env.readTextFile method with 2 arguments (using the charset), not to rely on system charset (which varies across environments)

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371074#comment-16371074 ] ASF GitHub Bot commented on FLINK-8714: --- Github user michalklempa commented on the issue:

[GitHub] flink issue #5536: [FLINK-8714][Documentation] Added either charsetName) or ...

2018-02-21 Thread michalklempa
Github user michalklempa commented on the issue: https://github.com/apache/flink/pull/5536 Unrelated test https://travis-ci.org/apache/flink/jobs/343906340#L5636 failing. ---

[GitHub] flink pull request #5481: [FLINK-8560] Access to the current key in ProcessF...

2018-02-21 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5481#discussion_r169571436 --- Diff: flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/DataStreamTest.scala --- @@ -448,11 +447,35 @@ class DataStreamTest

[jira] [Commented] (FLINK-8560) add KeyedProcessFunction to expose the key in onTimer() and other methods

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371133#comment-16371133 ] ASF GitHub Bot commented on FLINK-8560: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5481: [FLINK-8560] Access to the current key in ProcessF...

2018-02-21 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5481#discussion_r169571208 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/DataStream.scala --- @@ -666,18 +666,18 @@ class

[GitHub] flink pull request #5481: [FLINK-8560] Access to the current key in ProcessF...

2018-02-21 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5481#discussion_r169573342 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java --- @@ -654,6 +648,63 @@ public ExecutionConfig

[GitHub] flink pull request #5481: [FLINK-8560] Access to the current key in ProcessF...

2018-02-21 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5481#discussion_r169571457 --- Diff: flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/DataStreamTest.scala --- @@ -473,6 +496,28 @@ class DataStreamTest

[GitHub] flink pull request #5481: [FLINK-8560] Access to the current key in ProcessF...

2018-02-21 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5481#discussion_r169571197 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/DataStream.scala --- @@ -686,6 +686,27 @@ class DataStream[T](stream:

[jira] [Commented] (FLINK-8560) add KeyedProcessFunction to expose the key in onTimer() and other methods

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371134#comment-16371134 ] ASF GitHub Bot commented on FLINK-8560: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5481: [FLINK-8560] Access to the current key in ProcessF...

2018-02-21 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5481#discussion_r169571398 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/KeyedStream.scala --- @@ -79,7 +78,34 @@ class KeyedStream[T,

[jira] [Commented] (FLINK-8718) Non-parallel DataStreamSource does not set max parallelism

2018-02-21 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371070#comment-16371070 ] Bowen Li commented on FLINK-8718: - Hi [~gjy] , I looked at the code. As an extend, what's the difference

[jira] [Closed] (FLINK-8717) Flink seems to deadlock due to buffer starvation when iterating

2018-02-21 Thread Romain Revol (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Revol closed FLINK-8717. --- Resolution: Not A Bug > Flink seems to deadlock due to buffer starvation when iterating >

[jira] [Updated] (FLINK-8274) Fix Java 64K method compiling limitation for CommonCalc

2018-02-21 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-8274: - Priority: Critical (was: Major) > Fix Java 64K method compiling limitation for CommonCalc >

[jira] [Updated] (FLINK-8274) Fix Java 64K method compiling limitation for CommonCalc

2018-02-21 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-8274: - Issue Type: Bug (was: Improvement) > Fix Java 64K method compiling limitation for CommonCalc >

[GitHub] flink issue #5535: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-21 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5535 Thanks @zentol. Yea. I agree with you. ---

[jira] [Commented] (FLINK-8709) Flaky test: SlotPoolRpcTest.testCancelSlotAllocationWithoutResourceManager

2018-02-21 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371146#comment-16371146 ] Stefan Richter commented on FLINK-8709: --- Also still seeing this.

[GitHub] flink issue #5532: [FLINK-8711] [yarn] Remove code which auto-magically chan...

2018-02-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5532 In FLIP-6 mode, the right thing is to not have the number of TaskManagers preconfigured, but to start them when needed. Does that work already? The Yarn session would then - Start

[GitHub] flink issue #5528: [FLINK-6489] [FLINK-8696] [shell scripts] Remove JobManag...

2018-02-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5528 Hmm, weird, I tried it out under Windows (7) two days ago and it worked quite well. Let me check into what you found there... ---

[GitHub] flink pull request #5539: [hotfix][build] Set flink-shaded-jackson to provid...

2018-02-21 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5539 [hotfix][build] Set flink-shaded-jackson to provided This PR sets `flink-shaded-jackson` to provided in `flink-table` and `flink-mesos`, just like other `flink-dist` provided dependencies in these

[jira] [Commented] (FLINK-8703) Migrate tests from LocalFlinkMiniCluster to MiniClusterResource

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371091#comment-16371091 ] ASF GitHub Bot commented on FLINK-8703: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-8703) Migrate tests from LocalFlinkMiniCluster to MiniClusterResource

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371124#comment-16371124 ] ASF GitHub Bot commented on FLINK-8703: --- Github user zentol commented on the issue:

[GitHub] flink issue #5528: [FLINK-6489] [FLINK-8696] [shell scripts] Remove JobManag...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5528 The JM/TM can connect to each other though, and the job submission through the UI is also working. Metrics appear to be broken though. ---

[jira] [Commented] (FLINK-6489) Rework 'start-local.bat' to 'start-local-cluster.bat'

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371165#comment-16371165 ] ASF GitHub Bot commented on FLINK-6489: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-8703) Migrate tests from LocalFlinkMiniCluster to MiniClusterResource

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371102#comment-16371102 ] ASF GitHub Bot commented on FLINK-8703: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-7386) Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371110#comment-16371110 ] ASF GitHub Bot commented on FLINK-7386: --- Github user cjolif commented on a diff in the pull request:

[GitHub] flink pull request #4675: [FLINK-7386] FIx Elasticsearch 5 connector is not ...

2018-02-21 Thread cjolif
Github user cjolif commented on a diff in the pull request: https://github.com/apache/flink/pull/4675#discussion_r169568752 --- Diff: flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/BulkProcessorIndexer.java ---

[GitHub] flink issue #5535: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5535 I'm removing `AccumulatorErrorITCase` from the port due to FLINK-8721. ---

[GitHub] flink issue #5528: [FLINK-6489] [FLINK-8696] [shell scripts] Remove JobManag...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5528 I've tried using the start-local.bat scripts and found 2 issues: 1) The following warning is printed in the JobManager and TaskManager windows: ``` WARNING: An illegal reflective access

[jira] [Commented] (FLINK-8719) add module description for flink-contrib to clarify its purpose

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371162#comment-16371162 ] ASF GitHub Bot commented on FLINK-8719: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6489) Rework 'start-local.bat' to 'start-local-cluster.bat'

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371163#comment-16371163 ] ASF GitHub Bot commented on FLINK-6489: --- Github user zentol commented on the issue:

[GitHub] flink issue #5537: [FLINK-8719] add module description for flink-contrib to ...

2018-02-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5537 I think it is good to add such a text, but the `description` within the POM file is a bit hidden. I don't think anyone would really look there. How about adding a README.md file to the

[GitHub] flink issue #5534: [FLINK-8713][tests] Ensure outdated mod time is smaller t...

2018-02-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5534 Looks good, +1 ---

[jira] [Commented] (FLINK-8711) Flink with YARN uses wrong SlotsPerTaskManager

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371156#comment-16371156 ] ASF GitHub Bot commented on FLINK-8711: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-8713) FileInputFormatTest.testGetStatisticsMultipleOneFileWithCachedVersion unstable on Travis

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371158#comment-16371158 ] ASF GitHub Bot commented on FLINK-8713: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5535: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-21 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5535 And we also seems lost refactor ```WebFrontendITCase``` which still use ```LocalFlinkMiniCluster```. ---

[GitHub] flink issue #5535: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5535 yes, as mentioned in PR the description this does not port all tests. There are several tests that cannot be ported in isolation as they access specific methods on the `LocalFlinkMiniCluster` or

[jira] [Updated] (FLINK-8721) Client blocks indefinitely if job archiving fails

2018-02-21 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8721: Labels: flip-6 (was: ) > Client blocks indefinitely if job archiving fails >

[jira] [Created] (FLINK-8721) Client blocks indefinitely if job archiving fails

2018-02-21 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-8721: --- Summary: Client blocks indefinitely if job archiving fails Key: FLINK-8721 URL: https://issues.apache.org/jira/browse/FLINK-8721 Project: Flink Issue

[jira] [Updated] (FLINK-8721) Client blocks indefinitely if job archiving fails

2018-02-21 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8721: Description: While porting the {{AccumulatorErrorITCase}} i noticed that, for FLIP-6, if

[jira] [Commented] (FLINK-8700) Port tests from FlinkMiniCluster to MiniClusterResource

2018-02-21 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371127#comment-16371127 ] Chesnay Schepler commented on FLINK-8700: - [~mingleizhang] is correct, we can't remove the method

[jira] [Commented] (FLINK-8709) Flaky test: SlotPoolRpcTest.testCancelSlotAllocationWithoutResourceManager

2018-02-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371149#comment-16371149 ] Till Rohrmann commented on FLINK-8709: -- Will look into it again. > Flaky test:

[jira] [Resolved] (FLINK-8709) Flaky test: SlotPoolRpcTest.testCancelSlotAllocationWithoutResourceManager

2018-02-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8709. -- Resolution: Fixed This should hopefully fix it this time:

[GitHub] flink pull request #5544: [FLINK-8645][configuration] Split classloader.pare...

2018-02-21 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5544 [FLINK-8645][configuration] Split classloader.parent-first-patterns into "base" and "append ## What is the purpose of the change This PR splits the `classloader.parent-first-patterns`

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-21 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r169649287 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[jira] [Assigned] (FLINK-8730) Make SerializedThrowable deserialized from JSON re-throwable

2018-02-21 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8730: --- Assignee: Gary Yao > Make SerializedThrowable deserialized from JSON re-throwable >

[jira] [Commented] (FLINK-8645) Support convenient extension of parent-first ClassLoader patterns

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371503#comment-16371503 ] ASF GitHub Bot commented on FLINK-8645: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-8730) Make SerializedThrowable deserialized from JSON re-throwable

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371522#comment-16371522 ] ASF GitHub Bot commented on FLINK-8730: --- GitHub user GJL opened a pull request:

[jira] [Commented] (FLINK-6489) Rework 'start-local.bat' to 'start-local-cluster.bat'

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371193#comment-16371193 ] ASF GitHub Bot commented on FLINK-6489: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5528: [FLINK-6489] [FLINK-8696] [shell scripts] Remove JobManag...

2018-02-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5528 Okay, after a quick check with @zentol - Some issues were caused by Java 9. Apparently Flink on Windows is incompatible with Java 9 - We need to change the JobManager and TaskManager

[jira] [Commented] (FLINK-6489) Rework 'start-local.bat' to 'start-local-cluster.bat'

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371203#comment-16371203 ] ASF GitHub Bot commented on FLINK-6489: --- Github user StephanEwen commented on the issue:

[jira] [Created] (FLINK-8725) Separate NFA-state from NFA in CEP library

2018-02-21 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-8725: --- Summary: Separate NFA-state from NFA in CEP library Key: FLINK-8725 URL: https://issues.apache.org/jira/browse/FLINK-8725 Project: Flink Issue Type:

[jira] [Commented] (FLINK-8668) Remove "hadoop classpath" from config.sh

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371230#comment-16371230 ] ASF GitHub Bot commented on FLINK-8668: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5541: [FLINK-8728] [flip6] Fail new worker requests imme...

2018-02-21 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5541 [FLINK-8728] [flip6] Fail new worker requests immediately in standalone mode ## What is the purpose of the change Let the StandaloneResourceManager throw a ResourceManagerException in

[jira] [Commented] (FLINK-8728) Fail new worker requests immediately in Standalone mode

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371326#comment-16371326 ] ASF GitHub Bot commented on FLINK-8728: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-8703) Migrate tests from LocalFlinkMiniCluster to MiniClusterResource

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371344#comment-16371344 ] ASF GitHub Bot commented on FLINK-8703: --- Github user zentol commented on the issue:

[GitHub] flink issue #5465: [FLINK-8639][State Backends]Fix always need to seek multi...

2018-02-21 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5465 I have addressed all the comments. One thing that I am not 100 sure: I change the size of the `cacheEntries` to the fixed value `CACHE_SIZE_LIMIT` (128). @StefanRRichter Could you please have a

[jira] [Commented] (FLINK-8639) Fix always need to seek multiple times when iterator RocksDBMapState

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371345#comment-16371345 ] ASF GitHub Bot commented on FLINK-8639: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #5534: [FLINK-8713][tests] Ensure outdated mod time is smaller t...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5534 merging. ---

[GitHub] flink issue #5518: [FLINK-8679][State Backends]Fix RocksDBKeyedBackend.getKe...

2018-02-21 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5518 I have addressed all the comments, could you please have a look again? cc @StefanRRichter @aljoscha ---

[jira] [Commented] (FLINK-8679) RocksDBKeyedBackend.getKeys(stateName, namespace) doesn't filter data with namespace

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371366#comment-16371366 ] ASF GitHub Bot commented on FLINK-8679: --- Github user sihuazhou commented on the issue:

[jira] [Commented] (FLINK-8639) Fix always need to seek multiple times when iterator RocksDBMapState

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371379#comment-16371379 ] ASF GitHub Bot commented on FLINK-8639: --- Github user StefanRRichter commented on the issue:

[GitHub] flink pull request #5465: [FLINK-8639][State Backends]Fix always need to see...

2018-02-21 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5465#discussion_r169631205 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBMapState.java --- @@ -520,7

[jira] [Commented] (FLINK-8639) Fix always need to seek multiple times when iterator RocksDBMapState

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371399#comment-16371399 ] ASF GitHub Bot commented on FLINK-8639: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #5465: [FLINK-8639][State Backends]Fix always need to seek multi...

2018-02-21 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5465 Aha, for now I would like to leave it to 128 ... Even I can't find a best value, but this value is not a bad value and is also a safety value.. If I found any another value that is better than it

[jira] [Comment Edited] (FLINK-7756) RocksDB state backend Checkpointing (Async and Incremental) is not working with CEP.

2018-02-21 Thread tarun razdan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370981#comment-16370981 ] tarun razdan edited comment on FLINK-7756 at 2/21/18 10:21 AM: --- [~aljoscha]

[jira] [Commented] (FLINK-7756) RocksDB state backend Checkpointing (Async and Incremental) is not working with CEP.

2018-02-21 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371199#comment-16371199 ] Aljoscha Krettek commented on FLINK-7756: - I think you might be running into some problems related

[GitHub] flink issue #5528: [FLINK-6489] [FLINK-8696] [shell scripts] Remove JobManag...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5528 I tried it again with java 8. The job submission through the client now also works for me, and the warning is no longer printed. ---

[GitHub] flink issue #5528: [FLINK-6489] [FLINK-8696] [shell scripts] Remove JobManag...

2018-02-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5528 Tested it locally again, works (with current flip-6 Web UI at 9065) Adjusted the test-infra scripts to remove local mode. Tose are only executed on Travis, so waiting until the CI build

[GitHub] flink pull request #5531: [FLINK-8668] Document how to set HADOOP_CLASSPATH ...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5531#discussion_r169600042 --- Diff: docs/ops/deployment/hadoop.md --- @@ -0,0 +1,47 @@ +--- +title: "Hadoop Integration" +nav-title: Hadoop Integration +nav-parent_id:

[jira] [Closed] (FLINK-8668) Remove "hadoop classpath" from config.sh

2018-02-21 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-8668. --- Resolution: Fixed Resolved by adding documentation in

[jira] [Commented] (FLINK-8723) Remove existing BroadcastState examples.

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371256#comment-16371256 ] ASF GitHub Bot commented on FLINK-8723: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-8722) Refactor BroadcastState examples.

2018-02-21 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371254#comment-16371254 ] Chesnay Schepler commented on FLINK-8722: - Please provide a description as to why they should be

[jira] [Commented] (FLINK-8639) Fix always need to seek multiple times when iterator RocksDBMapState

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371313#comment-16371313 ] ASF GitHub Bot commented on FLINK-8639: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5465: [FLINK-8639][State Backends]Fix always need to see...

2018-02-21 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5465#discussion_r169620758 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBMapState.java --- @@ -520,7 +530,7 @@

[jira] [Commented] (FLINK-8639) Fix always need to seek multiple times when iterator RocksDBMapState

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371315#comment-16371315 ] ASF GitHub Bot commented on FLINK-8639: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5465: [FLINK-8639][State Backends]Fix always need to see...

2018-02-21 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5465#discussion_r169620794 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBMapState.java --- @@ -319,6 +321,9 @@

[jira] [Commented] (FLINK-8713) FileInputFormatTest.testGetStatisticsMultipleOneFileWithCachedVersion unstable on Travis

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371346#comment-16371346 ] ASF GitHub Bot commented on FLINK-8713: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-8726) Code highlighting partially broken

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371362#comment-16371362 ] ASF GitHub Bot commented on FLINK-8726: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink issue #5497: Propose fixing some typos

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5497 It's fine, I'll merge it and add the spaces back while doing so. ---

[jira] [Commented] (FLINK-8639) Fix always need to seek multiple times when iterator RocksDBMapState

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371388#comment-16371388 ] ASF GitHub Bot commented on FLINK-8639: --- Github user sihuazhou commented on a diff in the pull

[jira] [Comment Edited] (FLINK-8543) Output Stream closed at org.apache.hadoop.fs.s3a.S3AOutputStream.checkOpen

2018-02-21 Thread chris snow (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371403#comment-16371403 ] chris snow edited comment on FLINK-8543 at 2/21/18 1:33 PM: Sorry for the

[jira] [Commented] (FLINK-8715) RocksDB does not propagate reconfiguration of serializer to the states

2018-02-21 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371427#comment-16371427 ] Aljoscha Krettek commented on FLINK-8715: - I think it is an issue but I don't see how we can

[jira] [Commented] (FLINK-8543) Output Stream closed at org.apache.hadoop.fs.s3a.S3AOutputStream.checkOpen

2018-02-21 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371445#comment-16371445 ] Aljoscha Krettek commented on FLINK-8543: - Ok, this confirms my suspicion. The problem is this

[jira] [Commented] (FLINK-8723) Remove existing BroadcastState examples.

2018-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371451#comment-16371451 ] ASF GitHub Bot commented on FLINK-8723: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5540: [FLINK-8723] Remove existing broadcast state examp...

2018-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5540 ---

[jira] [Closed] (FLINK-8723) Remove existing BroadcastState examples.

2018-02-21 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-8723. - Resolution: Fixed Merged at 2fa8a158640ab9a46c2bfb6610766e2458ebe7a2 > Remove existing

[jira] [Created] (FLINK-8730) Make SerializedThrowable deserialized from JSON re-throwable

2018-02-21 Thread Gary Yao (JIRA)
Gary Yao created FLINK-8730: --- Summary: Make SerializedThrowable deserialized from JSON re-throwable Key: FLINK-8730 URL: https://issues.apache.org/jira/browse/FLINK-8730 Project: Flink Issue

  1   2   3   4   >