[jira] [Commented] (FLINK-8543) Output Stream closed at org.apache.hadoop.fs.s3a.S3AOutputStream.checkOpen

2018-02-27 Thread chris snow (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378211#comment-16378211 ] chris snow commented on FLINK-8543: --- Thanks for fixing this [~aljoscha]! {quote}The comments are

[jira] [Resolved] (FLINK-8733) SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled bytes anymore

2018-02-27 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8733. -- Resolution: Fixed Fixed via 4bf76ae69e3f22e25c2dad3e802be094554b5d43 >

[jira] [Resolved] (FLINK-8736) Memory segment offsets for slices of slices are wrong

2018-02-27 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8736. -- Resolution: Fixed Fixed via 9fb1c23aaead71bd7e81a6a73be1b4206dac405f > Memory segment offsets

[GitHub] flink pull request #5551: [FLINK-8736][network] fix memory segment offsets f...

2018-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5551 ---

[GitHub] flink pull request #5550: [FLINK-8734][network] fix partition bytes counting...

2018-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5550 ---

[GitHub] flink pull request #5549: [FLINK-8733][network] fix SpillableSubpartition#sp...

2018-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5549 ---

[jira] [Resolved] (FLINK-8734) SpillableSubpartition does not update byte statistics when spilled by a SpillableSubpartitionView

2018-02-27 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8734. -- Resolution: Fixed Fixed via f9daf9cc4243a80b38a1f81bf2b9b37565fe2d61 > SpillableSubpartition

[jira] [Commented] (FLINK-8787) Deploying FLIP-6 YARN session with HA fails

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378224#comment-16378224 ] ASF GitHub Bot commented on FLINK-8787: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-8734) SpillableSubpartition does not update byte statistics when spilled by a SpillableSubpartitionView

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378218#comment-16378218 ] ASF GitHub Bot commented on FLINK-8734: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-8733) SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled bytes anymore

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378217#comment-16378217 ] ASF GitHub Bot commented on FLINK-8733: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-8736) Memory segment offsets for slices of slices are wrong

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378219#comment-16378219 ] ASF GitHub Bot commented on FLINK-8736: --- Github user asfgit closed the pull request at:

[GitHub] flink issue #5584: [FLINK-8787][flip6] WIP Deploying FLIP-6 YARN session wit...

2018-02-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5584 Why are the tests failing due to this @GJL? ---

[jira] [Updated] (FLINK-8801) S3's eventual consistent read-after-write may fail yarn deployment of resources to S3

2018-02-27 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-8801: --- Fix Version/s: 1.4.3 > S3's eventual consistent read-after-write may fail yarn deployment of >

[jira] [Commented] (FLINK-8777) improve resource release when recovery from failover

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1637#comment-1637 ] ASF GitHub Bot commented on FLINK-8777: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-8777) improve resource release when recovery from failover

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378890#comment-16378890 ] ASF GitHub Bot commented on FLINK-8777: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-8777) improve resource release when recovery from failover

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378891#comment-16378891 ] ASF GitHub Bot commented on FLINK-8777: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-8750) InputGate may contain data after an EndOfPartitionEvent

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378989#comment-16378989 ] ASF GitHub Bot commented on FLINK-8750: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8750) InputGate may contain data after an EndOfPartitionEvent

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378993#comment-16378993 ] ASF GitHub Bot commented on FLINK-8750: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8750) InputGate may contain data after an EndOfPartitionEvent

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378992#comment-16378992 ] ASF GitHub Bot commented on FLINK-8750: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8750) InputGate may contain data after an EndOfPartitionEvent

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378990#comment-16378990 ] ASF GitHub Bot commented on FLINK-8750: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #5588: [FLINK-8750][runtime] Improve detection of no rema...

2018-02-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5588#discussion_r171004092 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/serialization/EventSerializerTest.java --- @@ -117,49 +116,55 @@ public void

[jira] [Commented] (FLINK-8750) InputGate may contain data after an EndOfPartitionEvent

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378991#comment-16378991 ] ASF GitHub Bot commented on FLINK-8750: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8750) InputGate may contain data after an EndOfPartitionEvent

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378994#comment-16378994 ] ASF GitHub Bot commented on FLINK-8750: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #5588: [FLINK-8750][runtime] Improve detection of no rema...

2018-02-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5588#discussion_r171001301 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/EventSerializer.java --- @@ -122,38 +121,16 @@ private static

[GitHub] flink pull request #5588: [FLINK-8750][runtime] Improve detection of no rema...

2018-02-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5588#discussion_r171000868 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/EventSerializer.java --- @@ -107,10 +107,9 @@ else if (eventClass

[GitHub] flink pull request #5588: [FLINK-8750][runtime] Improve detection of no rema...

2018-02-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5588#discussion_r171001862 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/EventSerializer.java --- @@ -318,13 +295,9 @@ public static

[GitHub] flink pull request #5588: [FLINK-8750][runtime] Improve detection of no rema...

2018-02-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5588#discussion_r171002283 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/serialization/EventSerializerTest.java --- @@ -117,49 +116,55 @@ public void

[GitHub] flink pull request #5588: [FLINK-8750][runtime] Improve detection of no rema...

2018-02-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5588#discussion_r171001535 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/EventSerializer.java --- @@ -107,10 +107,9 @@ else if (eventClass

[jira] [Commented] (FLINK-8777) improve resource release when recovery from failover

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378797#comment-16378797 ] ASF GitHub Bot commented on FLINK-8777: --- Github user sihuazhou commented on a diff in the pull

[jira] [Commented] (FLINK-8777) improve resource release when recovery from failover

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378798#comment-16378798 ] ASF GitHub Bot commented on FLINK-8777: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5578: [FLINK-8777][state]Improve resource release for lo...

2018-02-27 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5578#discussion_r170965699 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -285,4 +316,9 @@ public String toString() {

[GitHub] flink pull request #5578: [FLINK-8777][state]Improve resource release for lo...

2018-02-27 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5578#discussion_r170965652 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -90,6 +92,10 @@ @GuardedBy("lock")

[GitHub] flink pull request #5578: [FLINK-8777][state]Improve resource release for lo...

2018-02-27 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5578#discussion_r170965755 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -126,30 +133,54 @@ public void storeLocalState(

[GitHub] flink pull request #5578: [FLINK-8777][state]Improve resource release for lo...

2018-02-27 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5578#discussion_r170965682 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -126,30 +133,54 @@ public void storeLocalState(

[jira] [Resolved] (FLINK-8798) Make commons-logging a parent-first pattern

2018-02-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-8798. - Resolution: Fixed Fixed in - 1.4.2 via 392cfaaed9380c5ea38b8593d23023925638cbe3 - 1.5.0 via

[jira] [Closed] (FLINK-8798) Make commons-logging a parent-first pattern

2018-02-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-8798. --- > Make commons-logging a parent-first pattern > --- > >

[GitHub] flink pull request #5578: [FLINK-8777][state]Improve resource release for lo...

2018-02-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5578#discussion_r170982734 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -300,6 +291,32 @@ private void

[GitHub] flink pull request #5578: [FLINK-8777][state]Improve resource release for lo...

2018-02-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5578#discussion_r170975985 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -90,6 +92,9 @@ @GuardedBy("lock")

[jira] [Closed] (FLINK-8360) Implement task-local state recovery

2018-02-27 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-8360. - Resolution: Fixed > Implement task-local state recovery > --- > >

[jira] [Commented] (FLINK-8667) expose key in KeyedBroadcastProcessFunction#onTimer()

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378818#comment-16378818 ] ASF GitHub Bot commented on FLINK-8667: --- Github user kl0u commented on the issue:

[GitHub] flink issue #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFunction#...

2018-02-27 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5500 If also @aljoscha is ok, I can review this PR and merge it. ---

[jira] [Commented] (FLINK-8787) Deploying FLIP-6 YARN session with HA fails

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378868#comment-16378868 ] ASF GitHub Bot commented on FLINK-8787: --- GitHub user GJL opened a pull request:

[jira] [Created] (FLINK-8800) Set Logging to TRACE for org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler

2018-02-27 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-8800: --- Summary: Set Logging to TRACE for org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler Key: FLINK-8800 URL: https://issues.apache.org/jira/browse/FLINK-8800

[GitHub] flink pull request #5591: [FLINK-8787][flip6] Deploying FLIP-6 YARN session ...

2018-02-27 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5591 [FLINK-8787][flip6] Deploying FLIP-6 YARN session with HA fails ## What is the purpose of the change *Do not copy `flinkConfiguration` in `AbstractYarnClusterDescriptor`. There is code that

[GitHub] flink pull request #5578: [FLINK-8777][state]Improve resource release for lo...

2018-02-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5578#discussion_r170975679 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -159,6 +166,11 @@ public TaskStateSnapshot

[jira] [Commented] (FLINK-8737) Creating a union of UnionGate instances will fail with UnsupportedOperationException when retrieving buffers

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378912#comment-16378912 ] ASF GitHub Bot commented on FLINK-8737: --- Github user NicoK commented on a diff in the pull request:

[jira] [Created] (FLINK-8801) S3's eventual consistent read-after-write may fail yarn deployment of resources to S3

2018-02-27 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-8801: -- Summary: S3's eventual consistent read-after-write may fail yarn deployment of resources to S3 Key: FLINK-8801 URL: https://issues.apache.org/jira/browse/FLINK-8801

[jira] [Commented] (FLINK-8737) Creating a union of UnionGate instances will fail with UnsupportedOperationException when retrieving buffers

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378907#comment-16378907 ] ASF GitHub Bot commented on FLINK-8737: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #5583: [FLINK-8737][network] disallow creating a union of...

2018-02-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5583#discussion_r170988543 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java --- @@ -61,7 +61,7 @@ *

[GitHub] flink issue #5564: [FLINK-8538] [table] Add a Kafka table source factory wit...

2018-02-27 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5564 Thank you @fhueske. Will merge... ---

[GitHub] flink pull request #5282: [FLINK-6352] [kafka] Timestamp-based offset config...

2018-02-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5282#discussion_r170966200 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java --- @@ -621,12

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378802#comment-16378802 ] ASF GitHub Bot commented on FLINK-6352: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8720) Logging exception with S3 connector and BucketingSink

2018-02-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378844#comment-16378844 ] Stephan Ewen commented on FLINK-8720: - The proper fix is coming, tracked in FLINK-8798 > Logging

[jira] [Created] (FLINK-8799) Make AbstractYarnClusterDescriptor immutable

2018-02-27 Thread Gary Yao (JIRA)
Gary Yao created FLINK-8799: --- Summary: Make AbstractYarnClusterDescriptor immutable Key: FLINK-8799 URL: https://issues.apache.org/jira/browse/FLINK-8799 Project: Flink Issue Type: Bug

[jira] [Reopened] (FLINK-8798) Make commons-logging a parent-first pattern

2018-02-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen reopened FLINK-8798: - prematurely closed > Make commons-logging a parent-first pattern >

[jira] [Resolved] (FLINK-8798) Make commons-logging a parent-first pattern

2018-02-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-8798. - Resolution: Fixed Fixed in - 1.4.2 via 392cfaaed9380c5ea38b8593d23023925638cbe3 > Make

[jira] [Assigned] (FLINK-8336) YarnFileStageTestS3ITCase.testRecursiveUploadForYarnS3 test instability

2018-02-27 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber reassigned FLINK-8336: -- Assignee: Nico Kruber > YarnFileStageTestS3ITCase.testRecursiveUploadForYarnS3 test

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379026#comment-16379026 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379044#comment-16379044 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-8777) improve resource release when recovery from failover

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378795#comment-16378795 ] ASF GitHub Bot commented on FLINK-8777: --- Github user sihuazhou commented on a diff in the pull

[jira] [Commented] (FLINK-8777) improve resource release when recovery from failover

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378799#comment-16378799 ] ASF GitHub Bot commented on FLINK-8777: --- Github user sihuazhou commented on a diff in the pull

[jira] [Commented] (FLINK-8777) improve resource release when recovery from failover

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378796#comment-16378796 ] ASF GitHub Bot commented on FLINK-8777: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5578: [FLINK-8777][state]Improve resource release for lo...

2018-02-27 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5578#discussion_r170965807 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -90,6 +92,10 @@ @GuardedBy("lock")

[GitHub] flink pull request #5583: [FLINK-8737][network] disallow creating a union of...

2018-02-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5583#discussion_r170987211 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java --- @@ -189,11 +189,11 @@ public void

[GitHub] flink pull request #5581: [FLINK-8755][FLINK-8786][network] fix two bugs in ...

2018-02-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5581#discussion_r170993496 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -222,59 +219,24 @@ public void

[jira] [Assigned] (FLINK-8408) YarnFileStageTestS3ITCase.testRecursiveUploadForYarnS3n unstable on Travis

2018-02-27 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber reassigned FLINK-8408: -- Assignee: Nico Kruber > YarnFileStageTestS3ITCase.testRecursiveUploadForYarnS3n unstable on

[jira] [Commented] (FLINK-8777) improve resource release when recovery from failover

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378889#comment-16378889 ] ASF GitHub Bot commented on FLINK-8777: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5578: [FLINK-8777][state]Improve resource release for lo...

2018-02-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5578#discussion_r170975600 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -300,6 +291,32 @@ private void

[GitHub] flink pull request #5581: [FLINK-8755][FLINK-8786][network] fix two bugs in ...

2018-02-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5581#discussion_r170990471 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java --- @@ -138,11 +145,68 @@ static void

[jira] [Commented] (FLINK-8755) SpilledSubpartitionView wrongly relys on the backlog for determining whether more data is available

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378926#comment-16378926 ] ASF GitHub Bot commented on FLINK-8755: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7756) RocksDB state backend Checkpointing (Async and Incremental) is not working with CEP.

2018-02-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378805#comment-16378805 ] Aljoscha Krettek commented on FLINK-7756: - [~shashank734] Not right now. But thanks for providing

[GitHub] flink issue #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFunction#...

2018-02-27 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/5500 If this security concern is an issue, maybe in that case `getCurrentKey()` should take `object-reuse` into account, and if `object-reuse` is set to false, make a defensive copy of the key on

[jira] [Commented] (FLINK-8667) expose key in KeyedBroadcastProcessFunction#onTimer()

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378819#comment-16378819 ] ASF GitHub Bot commented on FLINK-8667: --- Github user pnowojski commented on the issue:

[jira] [Created] (FLINK-8798) Make commons-logging a parent-first pattern

2018-02-27 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-8798: --- Summary: Make commons-logging a parent-first pattern Key: FLINK-8798 URL: https://issues.apache.org/jira/browse/FLINK-8798 Project: Flink Issue Type: Bug

[GitHub] flink issue #5582: [FLINK-8790][State] Improve performance for recovery from...

2018-02-27 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5582 Thanks for the contribution! We are currently busy with the 1.5 release. I will have a closer look at this PR and your other pending JIRAs after the release is out. ---

[jira] [Commented] (FLINK-8790) Improve performance for recovery from incremental checkpoint

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378850#comment-16378850 ] ASF GitHub Bot commented on FLINK-8790: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #5573: [FLINK-8756][Client] Support ClusterClient.getAccumulator...

2018-02-27 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5573 @yanghua I will take a look this week. ---

[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378910#comment-16378910 ] ASF GitHub Bot commented on FLINK-8756: --- Github user GJL commented on the issue:

[jira] [Commented] (FLINK-8755) SpilledSubpartitionView wrongly relys on the backlog for determining whether more data is available

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378940#comment-16378940 ] ASF GitHub Bot commented on FLINK-8755: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8755) SpilledSubpartitionView wrongly relys on the backlog for determining whether more data is available

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378965#comment-16378965 ] ASF GitHub Bot commented on FLINK-8755: --- Github user NicoK commented on the issue:

[GitHub] flink issue #5581: [FLINK-8755][FLINK-8786][network] fix two bugs in spilled...

2018-02-27 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5581 rebased (not including newest FLINK-8694 changes!) and addressed the comments ---

[GitHub] flink issue #5564: [FLINK-8538] [table] Add a Kafka table source factory wit...

2018-02-27 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5564 Thanks for the update. I think this is good to merge. ---

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379063#comment-16379063 ] ASF GitHub Bot commented on FLINK-8689: --- Github user walterddr commented on the issue:

[jira] [Commented] (FLINK-8667) expose key in KeyedBroadcastProcessFunction#onTimer()

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379074#comment-16379074 ] ASF GitHub Bot commented on FLINK-8667: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFunction#...

2018-02-27 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5500 @tillrohrmann @kl0u Thanks for reviewing, guys As @pnowojski mentioned, we three decided to expose timer keys in `ProcessFunction` in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379148#comment-16379148 ] ASF GitHub Bot commented on FLINK-8538: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5564 ---

[GitHub] flink issue #5555: [FLINK-8689][table]Add runtime support of distinct filter...

2018-02-27 Thread walterddr
Github user walterddr commented on the issue: https://github.com/apache/flink/pull/ I agree this design is much cleaner and easier to maintain later. I was hesitating to change the function signature of `generateAggregations()`. I will try to introduce some common

[jira] [Commented] (FLINK-8720) Logging exception with S3 connector and BucketingSink

2018-02-27 Thread dejan miljkovic (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379167#comment-16379167 ] dejan miljkovic commented on FLINK-8720: I see from FLINK-8798 that solution is going to be

[jira] [Resolved] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8538. - Resolution: Fixed Fix Version/s: 1.6.0 1.5.0 Fixed in 1.6.0:

[GitHub] flink issue #4529: [FLINK-7428][network] avoid buffer copies when receiving ...

2018-02-27 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4529 @zhijiangW looks like we're not upgrading the netty version in Flink 1.5 at this stage due to the timing, i.e. too quite late in the development cycle. We will do the upgrade after releasing Flink 1.5

[jira] [Commented] (FLINK-8778) Migrate queryable state ITCases to use MiniClusterResource

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378263#comment-16378263 ] ASF GitHub Bot commented on FLINK-8778: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-7428) avoid one additional buffer copy when receiving messages

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378264#comment-16378264 ] ASF GitHub Bot commented on FLINK-7428: --- Github user NicoK commented on the issue:

[GitHub] flink issue #5579: [FLINK-8778] Migrate queryable state ITCases to use MiniC...

2018-02-27 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5579 @zentol I pushed some changes, still doesn't work for FLIP-6. @GJL and/or @tillrohrmann I would appreciate if you could have a look at this. 😃 ---

[jira] [Commented] (FLINK-8778) Migrate queryable state ITCases to use MiniClusterResource

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378267#comment-16378267 ] ASF GitHub Bot commented on FLINK-8778: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-8770) CompletedCheckPoints stored on ZooKeeper is not up-to-date, when JobManager is restarted it fails to recover the job due to "checkpoint FileNotFound exception"

2018-02-27 Thread Xinyang Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378299#comment-16378299 ] Xinyang Gao commented on FLINK-8770: For more information, I have rerun the test and see the following

[jira] [Updated] (FLINK-8794) When using BucketingSink, it happens that one of the files is always in the [.in-progress] state

2018-02-27 Thread yanxiaobin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yanxiaobin updated FLINK-8794: -- Description: When using BucketingSink, it happens that one of the files is always in the [.in-progress]

[jira] [Commented] (FLINK-8770) CompletedCheckPoints stored on ZooKeeper is not up-to-date, when JobManager is restarted it fails to recover the job due to "checkpoint FileNotFound exception"

2018-02-27 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378356#comment-16378356 ] Till Rohrmann commented on FLINK-8770: -- Hard to tell without logs. The commit operation to ZooKeeper

[GitHub] flink pull request #5572: [FLINK-8694][runtime] Fix notifyDataAvailable race...

2018-02-27 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5572#discussion_r170875167 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkThroughputBenchmarkTests.java --- @@ -52,6

[jira] [Commented] (FLINK-8694) Make notifyDataAvailable call reliable

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378360#comment-16378360 ] ASF GitHub Bot commented on FLINK-8694: --- Github user pnowojski commented on a diff in the pull

  1   2   3   4   >