[jira] [Commented] (FLINK-9730) avoid access static via class reference

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533896#comment-16533896 ] ASF GitHub Bot commented on FLINK-9730: --- Github user lamber-ken commented on a diff in the pull

[GitHub] flink pull request #6247: [FLINK-9730] [code refactor] fix access static via...

2018-07-05 Thread lamber-ken
Github user lamber-ken commented on a diff in the pull request: https://github.com/apache/flink/pull/6247#discussion_r200421209 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java --- @@ -116,8 +116,8 @@

[GitHub] flink pull request #6247: [FLINK-9730] [code refactor] fix access static via...

2018-07-05 Thread lamber-ken
Github user lamber-ken commented on a diff in the pull request: https://github.com/apache/flink/pull/6247#discussion_r200421156 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java --- @@ -179,7 +179,7 @@

[jira] [Commented] (FLINK-9730) avoid access static via class reference

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533876#comment-16533876 ] ASF GitHub Bot commented on FLINK-9730: --- Github user nekrassov commented on a diff in the pull

[GitHub] flink pull request #6247: [FLINK-9730] [code refactor] fix access static via...

2018-07-05 Thread nekrassov
Github user nekrassov commented on a diff in the pull request: https://github.com/apache/flink/pull/6247#discussion_r200415625 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java --- @@ -116,8 +116,8 @@

[jira] [Commented] (FLINK-9730) avoid access static via class reference

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533869#comment-16533869 ] ASF GitHub Bot commented on FLINK-9730: --- Github user nekrassov commented on a diff in the pull

[GitHub] flink pull request #6247: [FLINK-9730] [code refactor] fix access static via...

2018-07-05 Thread nekrassov
Github user nekrassov commented on a diff in the pull request: https://github.com/apache/flink/pull/6247#discussion_r200413115 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java --- @@ -179,7 +179,7 @@

[jira] [Commented] (FLINK-9681) Make sure minRetentionTime not equal to maxRetentionTime

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533846#comment-16533846 ] ASF GitHub Bot commented on FLINK-9681: --- Github user fhueske commented on the issue:

[GitHub] flink issue #6255: [FLINK-9681] [table] Make sure difference between minRete...

2018-07-05 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6255 Thanks for the update @hequn8128. I'll merge this ---

[jira] [Commented] (FLINK-9742) Expose Expression.resultType to public

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533842#comment-16533842 ] ASF GitHub Bot commented on FLINK-9742: --- Github user fhueske commented on the issue:

[GitHub] flink issue #6252: [FLINK-9742][Table API & SQL] Expose Expression.resultTyp...

2018-07-05 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6252 Thanks for the update @HeartSaVioR. I'll merge this ---

[jira] [Commented] (FLINK-8094) Support other types for ExistingField rowtime extractor

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533841#comment-16533841 ] ASF GitHub Bot commented on FLINK-8094: --- Github user fhueske commented on the issue:

[GitHub] flink issue #6253: [FLINK-8094][Table API & SQL] Support other types for Exi...

2018-07-05 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6253 Thanks for the update @HeartSaVioR. I'll merge this ---

[jira] [Commented] (FLINK-9757) Typos found in docs after hunspell run

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533833#comment-16533833 ] ASF GitHub Bot commented on FLINK-9757: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (FLINK-9757) Typos found in docs after hunspell run

2018-07-05 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-9757. -- Resolution: Fixed Fix Version/s: 1.5.0 1.6.0 Fixed via 1.6.0:

[GitHub] flink pull request #6258: [hotfix][docs][FLINK-9757] Fix typos found after h...

2018-07-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6258 ---

[jira] [Commented] (FLINK-9757) Typos found in docs after hunspell run

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533827#comment-16533827 ] ASF GitHub Bot commented on FLINK-9757: --- Github user yanghua commented on the issue:

[GitHub] flink issue #6258: [hotfix][docs][FLINK-9757] Fix typos found after hunspell...

2018-07-05 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6258 @subhankarb +1, hope for merging into 1.5.1 cc @tillrohrmann ---

[jira] [Commented] (FLINK-9730) avoid access static via class reference

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533820#comment-16533820 ] ASF GitHub Bot commented on FLINK-9730: --- Github user lamber-ken commented on a diff in the pull

[jira] [Commented] (FLINK-9758) ContinuousFileProcessingTest failed due to not setting runtimeContext

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533821#comment-16533821 ] ASF GitHub Bot commented on FLINK-9758: --- Github user yanghua commented on the issue:

[GitHub] flink issue #6260: [FLINK-9758] Fix ContinuousFileProcessingTest failure due...

2018-07-05 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6260 looks good from my side~ ---

[GitHub] flink pull request #6247: [FLINK-9730] [code refactor] fix access static via...

2018-07-05 Thread lamber-ken
Github user lamber-ken commented on a diff in the pull request: https://github.com/apache/flink/pull/6247#discussion_r200398562 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java --- @@ -179,7 +179,7 @@

[jira] [Assigned] (FLINK-9762) CoreOptions.TMP_DIRS wrongly managed on Yarn

2018-07-05 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-9762: --- Assignee: vinoyang > CoreOptions.TMP_DIRS wrongly managed on Yarn >

[jira] [Commented] (FLINK-9730) avoid access static via class reference

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533796#comment-16533796 ] ASF GitHub Bot commented on FLINK-9730: --- Github user nekrassov commented on a diff in the pull

[GitHub] flink pull request #6247: [FLINK-9730] [code refactor] fix access static via...

2018-07-05 Thread nekrassov
Github user nekrassov commented on a diff in the pull request: https://github.com/apache/flink/pull/6247#discussion_r200393008 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java --- @@ -179,7 +179,7 @@

[jira] [Commented] (FLINK-9681) Make sure minRetentionTime not equal to maxRetentionTime

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533794#comment-16533794 ] ASF GitHub Bot commented on FLINK-9681: --- Github user hequn8128 commented on the issue:

[GitHub] flink issue #6255: [FLINK-9681] [table] Make sure difference between minRete...

2018-07-05 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6255 @fhueske Comments have been addressed. Thanks for your review. ---

[jira] [Commented] (FLINK-9576) Wrong contiguity documentation

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533771#comment-16533771 ] ASF GitHub Bot commented on FLINK-9576: --- GitHub user dawidwys opened a pull request:

[jira] [Updated] (FLINK-9576) Wrong contiguity documentation

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9576: -- Labels: pull-request-available (was: ) > Wrong contiguity documentation >

[GitHub] flink pull request #6268: [FLINK-9576] Fixed documentation for contiguity wi...

2018-07-05 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/6268 [FLINK-9576] Fixed documentation for contiguity within looping pattern. Fixed example in the documentation plus restructured it a bit to make it more straightforward. You can merge this pull

[jira] [Commented] (FLINK-9730) avoid access static via class reference

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533761#comment-16533761 ] ASF GitHub Bot commented on FLINK-9730: --- Github user lamber-ken commented on a diff in the pull

[GitHub] flink pull request #6247: [FLINK-9730] [code refactor] fix access static via...

2018-07-05 Thread lamber-ken
Github user lamber-ken commented on a diff in the pull request: https://github.com/apache/flink/pull/6247#discussion_r200379627 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java --- @@ -179,7 +179,7 @@

[jira] [Commented] (FLINK-9730) avoid access static via class reference

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533718#comment-16533718 ] ASF GitHub Bot commented on FLINK-9730: --- Github user nekrassov commented on a diff in the pull

[GitHub] flink pull request #6247: [FLINK-9730] [code refactor] fix access static via...

2018-07-05 Thread nekrassov
Github user nekrassov commented on a diff in the pull request: https://github.com/apache/flink/pull/6247#discussion_r200369787 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java --- @@ -179,7 +179,7 @@

[jira] [Updated] (FLINK-9438) Add documentation for (Registry)AvroDeserializationSchema

2018-07-05 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-9438: Priority: Critical (was: Major) > Add documentation for

[jira] [Updated] (FLINK-9438) Add documentation for (Registry)AvroDeserializationSchema

2018-07-05 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-9438: Affects Version/s: 1.6.0 > Add documentation for (Registry)AvroDeserializationSchema >

[jira] [Updated] (FLINK-9766) Incomplete/incorrect cleanup in RemoteInputChannelTest

2018-07-05 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-9766: --- Description: If an assertion in the tests fails and as a result the cleanup code wrapped into a

[jira] [Created] (FLINK-9766) Incomplete/incorrect cleanup in RemoteInputChannelTest

2018-07-05 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-9766: -- Summary: Incomplete/incorrect cleanup in RemoteInputChannelTest Key: FLINK-9766 URL: https://issues.apache.org/jira/browse/FLINK-9766 Project: Flink Issue Type:

[jira] [Resolved] (FLINK-9588) Reuse the same conditionContext with in a same computationState

2018-07-05 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-9588. - Resolution: Fixed Fix Version/s: 1.6.0 > Reuse the same conditionContext with in

[jira] [Commented] (FLINK-9593) Unify AfterMatch semantics with SQL MATCH_RECOGNIZE

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533693#comment-16533693 ] ASF GitHub Bot commented on FLINK-9593: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-6469) Configure Memory Sizes with units

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533692#comment-16533692 ] ASF GitHub Bot commented on FLINK-6469: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (FLINK-9593) Unify AfterMatch semantics with SQL MATCH_RECOGNIZE

2018-07-05 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-9593. - Resolution: Fixed Fix Version/s: 1.6.0 > Unify AfterMatch semantics with SQL

[GitHub] flink pull request #5448: [FLINK-6469] Configure Memory Sizes with units

2018-07-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5448 ---

[GitHub] flink pull request #6171: [FLINK-9593] Unified After Match semantics with SQ...

2018-07-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6171 ---

[jira] [Resolved] (FLINK-6469) Configure Memory Sizes with units

2018-07-05 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-6469. - Resolution: Fixed Fix Version/s: 1.6.0 > Configure Memory Sizes with units >

[jira] [Closed] (FLINK-8479) Implement time-bounded inner join of streams as a TwoInputStreamOperator

2018-07-05 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-8479. - Resolution: Fixed Merged on master with ce345e394dfd176fe1433a5fcb0f46ad122787ca > Implement

[jira] [Commented] (FLINK-8479) Implement time-bounded inner join of streams as a TwoInputStreamOperator

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533686#comment-16533686 ] ASF GitHub Bot commented on FLINK-8479: --- Github user asfgit closed the pull request at:

[jira] [Updated] (FLINK-8479) Implement time-bounded inner join of streams as a TwoInputStreamOperator

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-8479: -- Labels: pull-request-available (was: ) > Implement time-bounded inner join of streams as a

[GitHub] flink pull request #5342: [FLINK-8479] Timebounded stream join

2018-07-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5342 ---

[jira] [Commented] (FLINK-8479) Implement time-bounded inner join of streams as a TwoInputStreamOperator

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533681#comment-16533681 ] ASF GitHub Bot commented on FLINK-8479: --- Github user kl0u commented on the issue:

[GitHub] flink issue #5342: [FLINK-8479] Timebounded stream join

2018-07-05 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5342 Thanks for the work @florianschmidt1994 ! Merging this. ---

[jira] [Commented] (FLINK-9742) Expose Expression.resultType to public

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533659#comment-16533659 ] ASF GitHub Bot commented on FLINK-9742: --- Github user HeartSaVioR commented on the issue:

[GitHub] flink issue #6252: [FLINK-9742][Table API & SQL] Expose Expression.resultTyp...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/flink/pull/6252 Addressed. ---

[jira] [Commented] (FLINK-9742) Expose Expression.resultType to public

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533654#comment-16533654 ] ASF GitHub Bot commented on FLINK-9742: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] flink pull request #6252: [FLINK-9742][Table API & SQL] Expose Expression.re...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/flink/pull/6252#discussion_r200352236 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionUtils.scala --- @@ -22,13 +22,16 @@ import

[GitHub] flink issue #6253: [FLINK-8094][Table API & SQL] Support other types for Exi...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/flink/pull/6253 Btw, looks like it may be also possible for ExistingField to replace needs of ParsingExistingField, via adding optional dateformat parameter (not sure which is more preferred), but I feel we can

[jira] [Commented] (FLINK-8094) Support other types for ExistingField rowtime extractor

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533639#comment-16533639 ] ASF GitHub Bot commented on FLINK-8094: --- Github user HeartSaVioR commented on the issue:

[GitHub] flink pull request #6262: [hotfix][filesystem] Remove incorrect equals metho...

2018-07-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6262 ---

[jira] [Commented] (FLINK-8094) Support other types for ExistingField rowtime extractor

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533635#comment-16533635 ] ASF GitHub Bot commented on FLINK-8094: --- Github user HeartSaVioR commented on the issue:

[GitHub] flink issue #6253: [FLINK-8094][Table API & SQL] Support other types for Exi...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/flink/pull/6253 @fhueske Thanks for the nice feedback! Addressed your comment except regarding unit test. Let me try out adding unit test later, since it might bring too high barrier as of now. ---

[GitHub] flink issue #6262: [hotfix][filesystem] Remove incorrect equals methods in S...

2018-07-05 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/6262 Thanks, fixed travis failure and merged. ---

[jira] [Updated] (FLINK-5750) Incorrect parse of brackets inside VALUES subquery

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-5750: -- Labels: pull-request-available (was: ) > Incorrect parse of brackets inside VALUES subquery >

[jira] [Commented] (FLINK-5750) Incorrect parse of brackets inside VALUES subquery

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533634#comment-16533634 ] ASF GitHub Bot commented on FLINK-5750: --- GitHub user AlexanderKoltsov opened a pull request:

[GitHub] flink pull request #6267: [FLINK-5750] Incorrect parse of brackets inside VA...

2018-07-05 Thread AlexanderKoltsov
GitHub user AlexanderKoltsov opened a pull request: https://github.com/apache/flink/pull/6267 [FLINK-5750] Incorrect parse of brackets inside VALUES subquery ## What is the purpose of the change *This pull request adds supporting multiple inputs in DataSetUnionRule*

[jira] [Commented] (FLINK-9742) Expose Expression.resultType to public

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533627#comment-16533627 ] ASF GitHub Bot commented on FLINK-9742: --- Github user fhueske commented on the issue:

[GitHub] flink issue #6252: [FLINK-9742][Table API & SQL] Expose Expression.resultTyp...

2018-07-05 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6252 Looks good. Just one last comment. ---

[jira] [Commented] (FLINK-9742) Expose Expression.resultType to public

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533626#comment-16533626 ] ASF GitHub Bot commented on FLINK-9742: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #6252: [FLINK-9742][Table API & SQL] Expose Expression.re...

2018-07-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6252#discussion_r200345063 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionUtils.scala --- @@ -22,13 +22,16 @@ import

[jira] [Commented] (FLINK-9742) Expose Expression.resultType to public

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533623#comment-16533623 ] ASF GitHub Bot commented on FLINK-9742: --- Github user HeartSaVioR commented on the issue:

[GitHub] flink issue #6252: [FLINK-9742][Table API & SQL] Expose Expression.resultTyp...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/flink/pull/6252 @fhueske Addressed. Please take a look again. ---

[jira] [Updated] (FLINK-9742) Expose Expression.resultType to public

2018-07-05 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated FLINK-9742: Summary: Expose Expression.resultType to public (was: Widen scope of Expression.resultType to

[jira] [Commented] (FLINK-9681) Make sure minRetentionTime not equal to maxRetentionTime

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533618#comment-16533618 ] ASF GitHub Bot commented on FLINK-9681: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9681) Make sure minRetentionTime not equal to maxRetentionTime

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533619#comment-16533619 ] ASF GitHub Bot commented on FLINK-9681: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #6255: [FLINK-9681] [table] Make sure difference between ...

2018-07-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6255#discussion_r200333630 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/HarnessTestBase.scala --- @@ -384,4 +386,12 @@ object

[GitHub] flink pull request #6255: [FLINK-9681] [table] Make sure difference between ...

2018-07-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6255#discussion_r200330683 --- Diff: docs/dev/table/streaming.md --- @@ -591,16 +589,14 @@ qConfig.withIdleStateRetentionTime(Time.hours(12); val qConfig: StreamQueryConfig

[jira] [Commented] (FLINK-9742) Widen scope of Expression.resultType to 'public'

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533614#comment-16533614 ] ASF GitHub Bot commented on FLINK-9742: --- Github user HeartSaVioR commented on the issue:

[GitHub] flink issue #6252: [FLINK-9742][Table API & SQL] Widen scope of Expression.r...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/flink/pull/6252 @fhueske Ah I didn't notice the object is already existing. Thanks for letting me know! ---

[jira] [Closed] (FLINK-9759) give an irrelevant answer about the savepoint restore when stateless operators be added etc

2018-07-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-9759. --- Resolution: Not A Problem Fix Version/s: (was: 1.5.1) (was:

[jira] [Commented] (FLINK-9765) Improve CLI responsiveness when cluster is not reachable

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533588#comment-16533588 ] ASF GitHub Bot commented on FLINK-9765: --- Github user yanghua commented on the issue:

[GitHub] flink issue #6265: [FLINK-9765] [sql-client] Improve CLI responsiveness when...

2018-07-05 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6265 +1 ---

[jira] [Commented] (FLINK-9682) Add setDescription to execution environment and display it in the UI

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533585#comment-16533585 ] ASF GitHub Bot commented on FLINK-9682: --- GitHub user yanghua opened a pull request:

[jira] [Updated] (FLINK-9682) Add setDescription to execution environment and display it in the UI

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9682: -- Labels: pull-request-available (was: ) > Add setDescription to execution environment and

[GitHub] flink pull request #6266: [FLINK-9682] Add setDescription to execution envir...

2018-07-05 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6266 [FLINK-9682] Add setDescription to execution environment and display it in the UI ## What is the purpose of the change *This pull request add setDescription to execution environment*

[jira] [Updated] (FLINK-9765) Improve CLI responsiveness when cluster is not reachable

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9765: -- Labels: pull-request-available (was: ) > Improve CLI responsiveness when cluster is not

[jira] [Commented] (FLINK-9765) Improve CLI responsiveness when cluster is not reachable

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533581#comment-16533581 ] ASF GitHub Bot commented on FLINK-9765: --- GitHub user twalthr opened a pull request:

[GitHub] flink pull request #6265: [FLINK-9765] [sql-client] Improve CLI responsivene...

2018-07-05 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/6265 [FLINK-9765] [sql-client] Improve CLI responsiveness when cluster is not reachable ## What is the purpose of the change Moves the job cancellation into the final phase of the refresh

[jira] [Commented] (FLINK-8094) Support other types for ExistingField rowtime extractor

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533579#comment-16533579 ] ASF GitHub Bot commented on FLINK-8094: --- Github user fhueske commented on the issue:

[GitHub] flink issue #6253: [WIP][FLINK-8094][Table API & SQL] Support other types fo...

2018-07-05 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6253 It's a good question whether to add a new class or not. Right now, extending the implementation of `ExistingField` seems like a better approach to me. Once we add a `ParsingExistingField` extractor

[jira] [Created] (FLINK-9765) Improve CLI responsiveness when cluster is not reachable

2018-07-05 Thread Timo Walther (JIRA)
Timo Walther created FLINK-9765: --- Summary: Improve CLI responsiveness when cluster is not reachable Key: FLINK-9765 URL: https://issues.apache.org/jira/browse/FLINK-9765 Project: Flink Issue

[jira] [Updated] (FLINK-9765) Improve CLI responsiveness when cluster is not reachable

2018-07-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-9765: Affects Version/s: 1.5.0 > Improve CLI responsiveness when cluster is not reachable >

[jira] [Created] (FLINK-9764) Failure in LocalRecoveryRocksDBFullITCase

2018-07-05 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-9764: -- Summary: Failure in LocalRecoveryRocksDBFullITCase Key: FLINK-9764 URL: https://issues.apache.org/jira/browse/FLINK-9764 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-9764) Failure in LocalRecoveryRocksDBFullITCase

2018-07-05 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-9764: --- Labels: test-stability (was: ) > Failure in LocalRecoveryRocksDBFullITCase >

[jira] [Commented] (FLINK-9742) Widen scope of Expression.resultType to 'public'

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533558#comment-16533558 ] ASF GitHub Bot commented on FLINK-9742: --- Github user fhueske commented on the issue:

[GitHub] flink issue #6252: [FLINK-9742][Table API & SQL] Widen scope of Expression.r...

2018-07-05 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6252 I think it can also be a new public method in `org.apache.flink.table.expressions.ExpressionUtils`. Thanks, Fabian ---

[jira] [Commented] (FLINK-6239) Sharing of State Across Operators

2018-07-05 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533553#comment-16533553 ] Stephan Ewen commented on FLINK-6239: - Thanks for sharing the details. Materialized table joins are

[jira] [Updated] (FLINK-9763) Flink SQL Client bat script

2018-07-05 Thread Pavel Shvetsov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Shvetsov updated FLINK-9763: -- Component/s: (was: Client) Startup Shell Scripts > Flink SQL Client bat

[jira] [Commented] (FLINK-9742) Widen scope of Expression.resultType to 'public'

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533542#comment-16533542 ] ASF GitHub Bot commented on FLINK-9742: --- Github user HeartSaVioR commented on the issue:

[GitHub] flink issue #6252: [FLINK-9742][Table API & SQL] Widen scope of Expression.r...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/flink/pull/6252 @fhueske Yeah, that would be great. I'm happy to revert the change and introduce new class. I'm just not sure where to place and how to name it, since it will be going to have

[jira] [Created] (FLINK-9763) Flink SQL Client bat script

2018-07-05 Thread Pavel Shvetsov (JIRA)
Pavel Shvetsov created FLINK-9763: - Summary: Flink SQL Client bat script Key: FLINK-9763 URL: https://issues.apache.org/jira/browse/FLINK-9763 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-9742) Widen scope of Expression.resultType to 'public'

2018-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533519#comment-16533519 ] ASF GitHub Bot commented on FLINK-9742: --- Github user fhueske commented on the issue:

<    1   2   3   >