[GitHub] leesf opened a new pull request #7452: [hotfix] fix param typo in KeyedCoProcessOperator constructor

2019-01-10 Thread GitBox
leesf opened a new pull request #7452: [hotfix] fix param typo in KeyedCoProcessOperator constructor URL: https://github.com/apache/flink/pull/7452 ## What is the purpose of the change Fix param typo in KeyedCoProcessOperator constructor ## Brief change log Change

[GitHub] hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

2019-01-10 Thread GitBox
hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r246736573 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11

[GitHub] zentol opened a new pull request #7454: [FLINK-11270] Update profiles

2019-01-10 Thread GitBox
zentol opened a new pull request #7454: [FLINK-11270] Update profiles URL: https://github.com/apache/flink/pull/7454 Must be merged together with #7451. ## What is the purpose of the change This PR updates the hadoop profile activations, to ensure that flink-dist still

[GitHub] hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

2019-01-10 Thread GitBox
hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r246739676 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -105,8

[jira] [Commented] (FLINK-11220) Can not Select row time field in JOIN query

2019-01-10 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739352#comment-16739352 ] sunjincheng commented on FLINK-11220: - Yes,totally agree!  > Can not Select row time field in JOIN

[GitHub] hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

2019-01-10 Thread GitBox
hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r246739693 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11

[GitHub] zentol commented on issue #6715: [FLINK-8424] update cassandra and driver version to latest

2019-01-10 Thread GitBox
zentol commented on issue #6715: [FLINK-8424] update cassandra and driver version to latest URL: https://github.com/apache/flink/pull/6715#issuecomment-453084744 @aljoscha You don't have to do anything for test dependencies bar ensuring they are ASL2 compatible. Only bundled

[jira] [Created] (FLINK-11301) Travis failed: No output has been received in the last 10m0s

2019-01-10 Thread Hequn Cheng (JIRA)
Hequn Cheng created FLINK-11301: --- Summary: Travis failed: No output has been received in the last 10m0s Key: FLINK-11301 URL: https://issues.apache.org/jira/browse/FLINK-11301 Project: Flink

[GitHub] zentol commented on issue #6715: [FLINK-8424] update cassandra and driver version to latest

2019-01-10 Thread GitBox
zentol commented on issue #6715: [FLINK-8424] update cassandra and driver version to latest URL: https://github.com/apache/flink/pull/6715#issuecomment-453090173 accodring to https://datastax-oss.atlassian.net/browse/JAVA-1265?filter=-4=text%20~%20%22jnr%22%20order%20by%20created%20DESC

[GitHub] zentol commented on issue #7444: [FLINK-11289][examples] Rework examples to account for licensing

2019-01-10 Thread GitBox
zentol commented on issue #7444: [FLINK-11289][examples] Rework examples to account for licensing URL: https://github.com/apache/flink/pull/7444#issuecomment-453055489 Updated JIRA reference. This is an automated message

[GitHub] leesf closed pull request #7449: [FLINK-9924] Upgrade zookeeper to 3.4.13

2019-01-10 Thread GitBox
leesf closed pull request #7449: [FLINK-9924] Upgrade zookeeper to 3.4.13 URL: https://github.com/apache/flink/pull/7449 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] dawidwys commented on issue #7449: [FLINK-9924] Upgrade zookeeper to 3.4.13

2019-01-10 Thread GitBox
dawidwys commented on issue #7449: [FLINK-9924] Upgrade zookeeper to 3.4.13 URL: https://github.com/apache/flink/pull/7449#issuecomment-453057899 Np, Thanks a lot! This is an automated message from the Apache Git Service. To

[jira] [Updated] (FLINK-11272) Support for parsing multiple --yarnship parameters

2019-01-10 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-11272: - Fix Version/s: (was: 1.7.2) 1.8.0 > Support for parsing multiple

[GitHub] aljoscha closed pull request #7420: [FLINK-11272][flink-yarn] Support for parsing multiple --yarnship par…

2019-01-10 Thread GitBox
aljoscha closed pull request #7420: [FLINK-11272][flink-yarn] Support for parsing multiple --yarnship par… URL: https://github.com/apache/flink/pull/7420 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Closed] (FLINK-11272) Support for parsing multiple --yarnship parameters

2019-01-10 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-11272. Resolution: Fixed Merged on master in f692d372f7cb1ecd04ad82d9d546fe68c702ce05 > Support

[jira] [Closed] (FLINK-11268) Update deploy_staging_jars.sh to deploy multiple flink-shaded-hadoop2 versions

2019-01-10 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-11268. Resolution: Fixed master: 5fe918c7946d7e585bc18346751fabfc3439b046 > Update

[GitHub] zentol opened a new pull request #7453: [FLINK-10509][storm] Remove flink-storm

2019-01-10 Thread GitBox
zentol opened a new pull request #7453: [FLINK-10509][storm] Remove flink-storm URL: https://github.com/apache/flink/pull/7453 ## What is the purpose of the change Remove the remaining parts of flink-storm. ## Brief change log * remove flink-storm documentation *

[jira] [Updated] (FLINK-10509) Drop flink-storm

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10509: --- Labels: pull-request-available (was: ) > Drop flink-storm > > >

[GitHub] aljoscha commented on issue #6715: [FLINK-8424] update cassandra and driver version to latest

2019-01-10 Thread GitBox
aljoscha commented on issue #6715: [FLINK-8424] update cassandra and driver version to latest URL: https://github.com/apache/flink/pull/6715#issuecomment-453084029 I think the newly added (transitive) dependencies need to be added here:

[GitHub] aljoscha commented on issue #6715: [FLINK-8424] update cassandra and driver version to latest

2019-01-10 Thread GitBox
aljoscha commented on issue #6715: [FLINK-8424] update cassandra and driver version to latest URL: https://github.com/apache/flink/pull/6715#issuecomment-453088031 Ah ok, that was stupid of me to not look at the shading section in the POM. @bmeriaux You only need to update the

[jira] [Updated] (FLINK-11302) FlinkS3FileSystem uses an incorrect path for temporary files.

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11302: --- Labels: pull-request-available (was: ) > FlinkS3FileSystem uses an incorrect path for

[GitHub] art4ul opened a new pull request #7458: [FLINK-11302] FlinkS3FileSystem uses an incorrect path for temporary files.

2019-01-10 Thread GitBox
art4ul opened a new pull request #7458: [FLINK-11302] FlinkS3FileSystem uses an incorrect path for temporary files. URL: https://github.com/apache/flink/pull/7458 ## What is the purpose of the change This pull request fixes the bug

[GitHub] wangxlong edited a comment on issue #7180: [FLINK-11010] [TABLE] Flink SQL timestamp is inconsistent with currentProcessingTime()

2019-01-10 Thread GitBox
wangxlong edited a comment on issue #7180: [FLINK-11010] [TABLE] Flink SQL timestamp is inconsistent with currentProcessingTime() URL: https://github.com/apache/flink/pull/7180#issuecomment-453126852 Besides the 'select proctime' case, windowStart and windowEnd fields also have this

[GitHub] wangxlong edited a comment on issue #7180: [FLINK-11010] [TABLE] Flink SQL timestamp is inconsistent with currentProcessingTime()

2019-01-10 Thread GitBox
wangxlong edited a comment on issue #7180: [FLINK-11010] [TABLE] Flink SQL timestamp is inconsistent with currentProcessingTime() URL: https://github.com/apache/flink/pull/7180#issuecomment-453126852 Besides the 'select proctime' case, windowStart and windowEnd fields also have this

[jira] [Updated] (FLINK-11297) Add a doc link of jobmanager ha details

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11297: --- Labels: pull-request-available (was: ) > Add a doc link of jobmanager ha details >

[GitHub] linyiqun opened a new pull request #7457: [FLINK-11297][docs] Add a doc link of jobmanager ha details.

2019-01-10 Thread GitBox
linyiqun opened a new pull request #7457: [FLINK-11297][docs] Add a doc link of jobmanager ha details. URL: https://github.com/apache/flink/pull/7457 Add a doc link of jobmanager ha details. This is a document change so no test needed to add.

[jira] [Updated] (FLINK-11302) FlinkS3FileSystem uses an incorrect path for temporary files.

2019-01-10 Thread Artsem Semianenka (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artsem Semianenka updated FLINK-11302: -- Description: I'm running the Flink job which stores the parquet files on S3. For that

[GitHub] wangxlong commented on issue #7180: [FLINK-11010] [TABLE] Flink SQL timestamp is inconsistent with currentProcessingTime()

2019-01-10 Thread GitBox
wangxlong commented on issue #7180: [FLINK-11010] [TABLE] Flink SQL timestamp is inconsistent with currentProcessingTime() URL: https://github.com/apache/flink/pull/7180#issuecomment-453126852 Besides the 'select proctime' case, windowStart and windowEnd fields also have this problem

[GitHub] linyiqun commented on issue #7457: [FLINK-11297][docs] Add a doc link of jobmanager ha details.

2019-01-10 Thread GitBox
linyiqun commented on issue #7457: [FLINK-11297][docs] Add a doc link of jobmanager ha details. URL: https://github.com/apache/flink/pull/7457#issuecomment-453134175 Also fix a minor bug of section rendering. This is an

[GitHub] dawidwys commented on issue #7258: [FLINK-11084]Throw a hard exception to remind developers while there's no stream node between two split transformation

2019-01-10 Thread GitBox
dawidwys commented on issue #7258: [FLINK-11084]Throw a hard exception to remind developers while there's no stream node between two split transformation URL: https://github.com/apache/flink/pull/7258#issuecomment-453135673 +1, merging when my travis gives green

[GitHub] GJL commented on a change in pull request #7441: [FLINK-11156][tests, runtime] Reconcile ZooKeeperCompletedCheckpointStoreMockitoTest with JDK 9

2019-01-10 Thread GitBox
GJL commented on a change in pull request #7441: [FLINK-11156][tests, runtime] Reconcile ZooKeeperCompletedCheckpointStoreMockitoTest with JDK 9 URL: https://github.com/apache/flink/pull/7441#discussion_r246861687 ## File path:

[GitHub] GJL commented on a change in pull request #7441: [FLINK-11156][tests, runtime] Reconcile ZooKeeperCompletedCheckpointStoreMockitoTest with JDK 9

2019-01-10 Thread GitBox
GJL commented on a change in pull request #7441: [FLINK-11156][tests, runtime] Reconcile ZooKeeperCompletedCheckpointStoreMockitoTest with JDK 9 URL: https://github.com/apache/flink/pull/7441#discussion_r246861639 ## File path:

[GitHub] asfgit closed pull request #7414: [FLINK-11253] Add shutdown hook for yarn session client in attached mode

2019-01-10 Thread GitBox
asfgit closed pull request #7414: [FLINK-11253] Add shutdown hook for yarn session client in attached mode URL: https://github.com/apache/flink/pull/7414 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] tillrohrmann opened a new pull request #7459: [FLINK-11300] Make MetricFetcher update interval configurable

2019-01-10 Thread GitBox
tillrohrmann opened a new pull request #7459: [FLINK-11300] Make MetricFetcher update interval configurable URL: https://github.com/apache/flink/pull/7459 ## What is the purpose of the change Introduce WebOptions.METRIC_FETCHER_UPDATE_INTERVAL configuration option to configure

[jira] [Resolved] (FLINK-11253) Incorrect way to stop yarn session described in yarn_setup document

2019-01-10 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-11253. --- Resolution: Fixed Fix Version/s: 1.8.0 Fixed via

[GitHub] HuangZhenQiu commented on a change in pull request #7356: [FLINK-10868][flink-yarn] Enforce maximum failed TMs in YarnResourceManager

2019-01-10 Thread GitBox
HuangZhenQiu commented on a change in pull request #7356: [FLINK-10868][flink-yarn] Enforce maximum failed TMs in YarnResourceManager URL: https://github.com/apache/flink/pull/7356#discussion_r246860798 ## File path:

[GitHub] GJL commented on a change in pull request #7441: [FLINK-11156][tests, runtime] Reconcile ZooKeeperCompletedCheckpointStoreMockitoTest with JDK 9

2019-01-10 Thread GitBox
GJL commented on a change in pull request #7441: [FLINK-11156][tests, runtime] Reconcile ZooKeeperCompletedCheckpointStoreMockitoTest with JDK 9 URL: https://github.com/apache/flink/pull/7441#discussion_r246861416 ## File path:

[GitHub] addisonj opened a new pull request #7460: [FLINK-11187] [s3] Use file over stream for writes

2019-01-10 Thread GitBox
addisonj opened a new pull request #7460: [FLINK-11187] [s3] Use file over stream for writes URL: https://github.com/apache/flink/pull/7460 ## What is the purpose of the change This changes the S3AccessHelper API to take a file instead of an input stream. This allows

[jira] [Updated] (FLINK-11187) StreamingFileSink with S3 backend transient socket timeout issues

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11187: --- Labels: pull-request-available (was: ) > StreamingFileSink with S3 backend transient

[jira] [Commented] (FLINK-11187) StreamingFileSink with S3 backend transient socket timeout issues

2019-01-10 Thread Addison Higham (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739662#comment-16739662 ] Addison Higham commented on FLINK-11187: PR opened here:

[GitHub] AlphaGarden commented on issue #7312: [FLINK-11169][runtime] fix the problem of not being reloaded for jobmanager's…

2019-01-10 Thread GitBox
AlphaGarden commented on issue #7312: [FLINK-11169][runtime] fix the problem of not being reloaded for jobmanager's… URL: https://github.com/apache/flink/pull/7312#issuecomment-453243892 > I think we can add a new internal field `shouldSetCacheHeaders` (or something like this) and when

[jira] [Assigned] (FLINK-11220) Can not Select row time field in JOIN query

2019-01-10 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-11220: --- Assignee: Dian Fu > Can not Select row time field in JOIN query >

[GitHub] intsmaze opened a new pull request #7467: Update state.md

2019-01-10 Thread GitBox
intsmaze opened a new pull request #7467: Update state.md URL: https://github.com/apache/flink/pull/7467 Offset is Long type, the default value is null, and executing offset+=1 in Java 1.8.x will throw a NullPointerException ## What is the purpose of the change

[GitHub] JaryZhen commented on issue #7466: [hotfix][docs] Fix typo in time attributes doc

2019-01-10 Thread GitBox
JaryZhen commented on issue #7466: [hotfix][docs] Fix typo in time attributes doc URL: https://github.com/apache/flink/pull/7466#issuecomment-453396068 Here I talk about is **DefinedRowtimeAttribute** should be **DefinedRowtimeAttributes**

[GitHub] sunjincheng121 commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S…

2019-01-10 Thread GitBox
sunjincheng121 commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S… URL: https://github.com/apache/flink/pull/7403#discussion_r247010124 ## File path:

[GitHub] JaryZhen opened a new pull request #7466: [hotfix][docs] Fix typo in time attributes doc

2019-01-10 Thread GitBox
JaryZhen opened a new pull request #7466: [hotfix][docs] Fix typo in time attributes doc URL: https://github.com/apache/flink/pull/7466 ## What is the purpose of the change This pull request fix typo in time attributes doc ## Brief change log fix typo in

[GitHub] intsmaze closed pull request #7464: Update state.md

2019-01-10 Thread GitBox
intsmaze closed pull request #7464: Update state.md URL: https://github.com/apache/flink/pull/7464 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] intsmaze commented on issue #7464: Update state.md

2019-01-10 Thread GitBox
intsmaze commented on issue #7464: Update state.md URL: https://github.com/apache/flink/pull/7464#issuecomment-453396857 Ok, I will commit it to master branch later。 This is an automated message from the Apache Git Service.

[GitHub] intsmaze opened a new pull request #7464: Update state.md

2019-01-10 Thread GitBox
intsmaze opened a new pull request #7464: Update state.md URL: https://github.com/apache/flink/pull/7464 ## What is the purpose of the change *invoke(Object) is deprecated, Use invoke(Object, Context) instead of it in the document * ## Brief change log

[GitHub] sunhaibotb commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S…

2019-01-10 Thread GitBox
sunhaibotb commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S… URL: https://github.com/apache/flink/pull/7403#discussion_r246994962 ## File path:

[jira] [Commented] (FLINK-11304) Typo in time attributes doc

2019-01-10 Thread Jaryzhen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740004#comment-16740004 ] Jaryzhen commented on FLINK-11304: -- Hey, Anyone who can assign this to me? > Typo in time attributes

[jira] [Commented] (FLINK-11082) Increase backlog only if it is available for consumption

2019-01-10 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740056#comment-16740056 ] zhijiang commented on FLINK-11082: -- Consider another issue you mentioned, I think the higher CPU and

[jira] [Created] (FLINK-11305) Allow developer to test flink without building the whole flink project

2019-01-10 Thread Jeff Zhang (JIRA)
Jeff Zhang created FLINK-11305: -- Summary: Allow developer to test flink without building the whole flink project Key: FLINK-11305 URL: https://issues.apache.org/jira/browse/FLINK-11305 Project: Flink

[GitHub] JaryZhen commented on issue #7466: [hotfix][docs] Fix typo in time attributes doc

2019-01-10 Thread GitBox
JaryZhen commented on issue #7466: [hotfix][docs] Fix typo in time attributes doc URL: https://github.com/apache/flink/pull/7466#issuecomment-453398124 OK, I do it right now. This is an automated message from the Apache Git

[jira] [Resolved] (FLINK-10509) Drop flink-storm

2019-01-10 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-10509. --- Resolution: Fixed Fixed via 2294cddac1674fbd760f75429c9e60c571826de9 > Drop flink-storm >

[jira] [Updated] (FLINK-11305) Allow developer to test flink without building the whole flink project

2019-01-10 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang updated FLINK-11305: --- Description: As a flink developer, each time I make some changes in flink, I would like to test it

[jira] [Commented] (FLINK-11082) Increase backlog only if it is available for consumption

2019-01-10 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739998#comment-16739998 ] zhijiang commented on FLINK-11082: -- [~pnowojski], thanks for replies! It might not make sense to

[GitHub] KarmaGYZ opened a new pull request #7465: [hotfix][docs] Add note for state schema evolution in upgrading doc

2019-01-10 Thread GitBox
KarmaGYZ opened a new pull request #7465: [hotfix][docs] Add note for state schema evolution in upgrading doc URL: https://github.com/apache/flink/pull/7465 ## What is the purpose of the change This PR add note for state schema evolution in upgrading doc ## Brief change log

[jira] [Comment Edited] (FLINK-11304) Typo in time attributes doc

2019-01-10 Thread Jaryzhen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740004#comment-16740004 ] Jaryzhen edited comment on FLINK-11304 at 1/11/19 5:33 AM: --- Hey,

[jira] [Commented] (FLINK-11253) Incorrect way to stop yarn session described in yarn_setup document

2019-01-10 Thread Tao Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740081#comment-16740081 ] Tao Yang commented on FLINK-11253: -- Hi, [~till.rohrmann]. Could you kindly give me the contributor

[jira] [Comment Edited] (FLINK-11304) Typo in time attributes doc

2019-01-10 Thread Jaryzhen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740004#comment-16740004 ] Jaryzhen edited comment on FLINK-11304 at 1/11/19 7:09 AM: --- Hey, [~karmagyz]

[jira] [Commented] (FLINK-11296) Support truncate in TableAPI

2019-01-10 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740110#comment-16740110 ] Jark Wu commented on FLINK-11296: - Hi [~x1q1j1], thanks for your work. I just notice that we already

[jira] [Updated] (FLINK-11304) Typo in time attributes doc

2019-01-10 Thread Jaryzhen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaryzhen updated FLINK-11304: - Description: *DefinedRowtimeAttribute* should be *DefinedRowtimeAttributes*, both in java and scala

[jira] [Assigned] (FLINK-11305) Allow developer to test flink without building the whole flink project

2019-01-10 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang reassigned FLINK-11305: -- Assignee: Jeff Zhang > Allow developer to test flink without building the whole flink

[GitHub] KarmaGYZ commented on issue #7466: [hotfix][docs] Fix typo in time attributes doc

2019-01-10 Thread GitBox
KarmaGYZ commented on issue #7466: [hotfix][docs] Fix typo in time attributes doc URL: https://github.com/apache/flink/pull/7466#issuecomment-453397446 Sorry for the misunderstanding @JaryZhen . I think we should also change the `getRowtimeAttribute` to `getRowtimeAttributeDescriptors`

[jira] [Updated] (FLINK-11305) Allow developer to test flink without building the whole flink project

2019-01-10 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang updated FLINK-11305: --- Description: As a flink developer, each time I make some changes in flink, I would like to test it

[jira] [Created] (FLINK-11304) Typo in time attributes doc

2019-01-10 Thread Jaryzhen (JIRA)
Jaryzhen created FLINK-11304: Summary: Typo in time attributes doc Key: FLINK-11304 URL: https://issues.apache.org/jira/browse/FLINK-11304 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-11220) Can not Select row time field in JOIN query

2019-01-10 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740028#comment-16740028 ] Dian Fu commented on FLINK-11220: - Thanks a lot for the discussion. +1 to the solution of improving

[GitHub] zhijiangW commented on issue #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter

2019-01-10 Thread GitBox
zhijiangW commented on issue #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter URL: https://github.com/apache/flink/pull/7438#issuecomment-453380144 @pnowojski , I have submitted the fixup commit for addressing above comments.

[GitHub] KarmaGYZ commented on a change in pull request #7466: [FLINK-11304] Fix typo in time attributes doc

2019-01-10 Thread GitBox
KarmaGYZ commented on a change in pull request #7466: [FLINK-11304] Fix typo in time attributes doc URL: https://github.com/apache/flink/pull/7466#discussion_r247019832 ## File path: docs/dev/table/streaming/time_attributes.md ## @@ -284,9 +284,9 @@ public class

[GitHub] KarmaGYZ commented on a change in pull request #7466: [FLINK-11304] Fix typo in time attributes doc

2019-01-10 Thread GitBox
KarmaGYZ commented on a change in pull request #7466: [FLINK-11304] Fix typo in time attributes doc URL: https://github.com/apache/flink/pull/7466#discussion_r247020384 ## File path: docs/dev/table/streaming/time_attributes.md ## @@ -317,9 +317,9 @@ class UserActionSource

[GitHub] KarmaGYZ commented on a change in pull request #7466: [FLINK-11304] Fix typo in time attributes doc

2019-01-10 Thread GitBox
KarmaGYZ commented on a change in pull request #7466: [FLINK-11304] Fix typo in time attributes doc URL: https://github.com/apache/flink/pull/7466#discussion_r247020179 ## File path: docs/dev/table/streaming/time_attributes.md ## @@ -284,9 +284,9 @@ public class

[GitHub] KarmaGYZ commented on a change in pull request #7466: [FLINK-11304] Fix typo in time attributes doc

2019-01-10 Thread GitBox
KarmaGYZ commented on a change in pull request #7466: [FLINK-11304] Fix typo in time attributes doc URL: https://github.com/apache/flink/pull/7466#discussion_r247019718 ## File path: docs/dev/table/streaming/time_attributes.md ## @@ -284,9 +284,9 @@ public class

[jira] [Commented] (FLINK-11304) Typo in time attributes doc

2019-01-10 Thread Yangze Guo (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740117#comment-16740117 ] Yangze Guo commented on FLINK-11304: Sorry, you should apply for the Flink contribution permission

[jira] [Commented] (FLINK-9700) Document FlinkKafkaProducer behaviour for Kafka versions > 0.11

2019-01-10 Thread leesf (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739914#comment-16739914 ] leesf commented on FLINK-9700: -- [~pnowojski], ok, what we discussed in this ticket is documented in [kafka

[GitHub] eaglewatcherwb opened a new pull request #7461: Rename configuration options of queryable-state from query.x to queryable-state.x

2019-01-10 Thread GitBox
eaglewatcherwb opened a new pull request #7461: Rename configuration options of queryable-state from query.x to queryable-state.x URL: https://github.com/apache/flink/pull/7461 ## What is the purpose of the change Rename configuration options of queryable-state from

[GitHub] AlphaGarden edited a comment on issue #7312: [FLINK-11169][runtime] fix the problem of not being reloaded for jobmanager's…

2019-01-10 Thread GitBox
AlphaGarden edited a comment on issue #7312: [FLINK-11169][runtime] fix the problem of not being reloaded for jobmanager's… URL: https://github.com/apache/flink/pull/7312#issuecomment-453243892 > I think we can add a new internal field `shouldSetCacheHeaders` (or something like this) and

[jira] [Created] (FLINK-11303) Utilizing Kafka headers for serialization and deserialization

2019-01-10 Thread Allen Wang (JIRA)
Allen Wang created FLINK-11303: -- Summary: Utilizing Kafka headers for serialization and deserialization Key: FLINK-11303 URL: https://issues.apache.org/jira/browse/FLINK-11303 Project: Flink

[GitHub] yt526 commented on a change in pull request #7414: [FLINK-11253] Add shutdown hook for yarn session client in attached mode

2019-01-10 Thread GitBox
yt526 commented on a change in pull request #7414: [FLINK-11253] Add shutdown hook for yarn session client in attached mode URL: https://github.com/apache/flink/pull/7414#discussion_r246985655 ## File path:

[jira] [Commented] (FLINK-11253) Incorrect way to stop yarn session described in yarn_setup document

2019-01-10 Thread Tao Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739950#comment-16739950 ] Tao Yang commented on FLINK-11253: -- Thanks [~till.rohrmann] for the review and commit. > Incorrect way

[GitHub] sunhaibotb commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S…

2019-01-10 Thread GitBox
sunhaibotb commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S… URL: https://github.com/apache/flink/pull/7403#discussion_r246991737 ## File path:

[GitHub] sunjincheng121 commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S…

2019-01-10 Thread GitBox
sunjincheng121 commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S… URL: https://github.com/apache/flink/pull/7403#discussion_r246987401 ## File path:

[GitHub] sunjincheng121 commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S…

2019-01-10 Thread GitBox
sunjincheng121 commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S… URL: https://github.com/apache/flink/pull/7403#discussion_r246986459 ## File path:

<    1   2