[GitHub] [flink] StefanRRichter commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test

2019-03-06 Thread GitBox
StefanRRichter commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test URL: https://github.com/apache/flink/pull/7896#discussion_r262879669 ## File path:

[jira] [Commented] (FLINK-11825) Resolve name clash of StateTTL TimeCharacteristic class

2019-03-06 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785480#comment-16785480 ] Fabian Hueske commented on FLINK-11825: --- Hi [~klion26], sure feel free to take the issue. However,

[GitHub] [flink] zhijiangW commented on a change in pull request #7579: [FLINK-9142] Lower the minimum number of buffers for incoming channels to 1

2019-03-06 Thread GitBox
zhijiangW commented on a change in pull request #7579: [FLINK-9142] Lower the minimum number of buffers for incoming channels to 1 URL: https://github.com/apache/flink/pull/7579#discussion_r262889178 ## File path:

[jira] [Updated] (FLINK-11837) Improve blink internal data format

2019-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11837: --- Labels: pull-request-available (was: ) > Improve blink internal data format >

[GitHub] [flink] flinkbot commented on issue #7913: [FLINK-11837][table-runtime-blink] Improve blink internal data format

2019-03-06 Thread GitBox
flinkbot commented on issue #7913: [FLINK-11837][table-runtime-blink] Improve blink internal data format URL: https://github.com/apache/flink/pull/7913#issuecomment-470074411 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[jira] [Commented] (FLINK-11825) Resolve name clash of StateTTL TimeCharacteristic class

2019-03-06 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785553#comment-16785553 ] Congxian Qiu(klion26) commented on FLINK-11825: --- Thank you [~azagrebin], I'll give a patch

[GitHub] [flink] tillrohrmann commented on issue #7900: [FLINK-11826] Fix flaky Kafka ratelimiter test

2019-03-06 Thread GitBox
tillrohrmann commented on issue #7900: [FLINK-11826] Fix flaky Kafka ratelimiter test URL: https://github.com/apache/flink/pull/7900#issuecomment-470085943 The test case still needs 34 s on my machine. Per se this is not bad if this time is really required. I don't know exactly what we

[GitHub] [flink] KurtYoung commented on a change in pull request #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes

2019-03-06 Thread GitBox
KurtYoung commented on a change in pull request #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes URL: https://github.com/apache/flink/pull/7910#discussion_r262922017 ## File path:

[GitHub] [flink] aljoscha commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread GitBox
aljoscha commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0 URL: https://github.com/apache/flink/pull/7912#issuecomment-470094626 It turns out that we had both `LICENSE.slf4j` and `LICENSE.slf4j-api` before, with identical contents. I'll see

[GitHub] [flink] zentol commented on a change in pull request #7820: [FLINK-11742][Metrics]Push metrics to Pushgateway without "instance"

2019-03-06 Thread GitBox
zentol commented on a change in pull request #7820: [FLINK-11742][Metrics]Push metrics to Pushgateway without "instance" URL: https://github.com/apache/flink/pull/7820#discussion_r262928601 ## File path:

[jira] [Comment Edited] (FLINK-11378) Allow HadoopRecoverableWriter to write to Hadoop compatible Filesystems

2019-03-06 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785587#comment-16785587 ] Fokko Driesprong edited comment on FLINK-11378 at 3/6/19 12:55 PM: ---

[GitHub] [flink] godfreyhe commented on issue #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes

2019-03-06 Thread GitBox
godfreyhe commented on issue #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes URL: https://github.com/apache/flink/pull/7910#issuecomment-470099942 `FlinkLogicalTableSourceScan` is also added into this commit. The rest flink logical nodes(contains:

[jira] [Updated] (FLINK-11839) Introduce FlinkLogicalWindowAggregate

2019-03-06 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-11839: --- Description: {{FlinkLogicalWindowAggregate}} depends on {{Expression}} which hasn't been ported

[GitHub] [flink] godfreyhe commented on issue #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes

2019-03-06 Thread GitBox
godfreyhe commented on issue #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes URL: https://github.com/apache/flink/pull/7910#issuecomment-470111342 related issues: https://issues.apache.org/jira/browse/FLINK-11839

[GitHub] [flink] aljoscha commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java

2019-03-06 Thread GitBox
aljoscha commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java URL: https://github.com/apache/flink/pull/7902#issuecomment-470064582 I agree, yes. The reason only `KafkaDeserializationSchemaWrapper` is in the correct location is

[GitHub] [flink] rmetzger commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-06 Thread GitBox
rmetzger commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-470070176 Damn. You are right. For some reason, it seems that I have checked out your latest

[GitHub] [flink] pnowojski commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-06 Thread GitBox
pnowojski commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r262926200 ## File path:

[GitHub] [flink] aljoscha commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread GitBox
aljoscha commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0 URL: https://github.com/apache/flink/pull/7912#issuecomment-470102441 merged This is an automated message from the

[GitHub] [flink] zhijiangW commented on issue #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition

2019-03-06 Thread GitBox
zhijiangW commented on issue #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition URL: https://github.com/apache/flink/pull/7911#issuecomment-470055192 @pnowojski , based on previous discussion offline, I fixed the getting of backlog value by considering extra

[GitHub] [flink] flinkbot commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread GitBox
flinkbot commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0 URL: https://github.com/apache/flink/pull/7912#issuecomment-470059276 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[jira] [Updated] (FLINK-11836) Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11836: --- Labels: pull-request-available (was: ) > Update NOTICE-binary and licenses-binary for

[GitHub] [flink] lamber-ken commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java

2019-03-06 Thread GitBox
lamber-ken commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java URL: https://github.com/apache/flink/pull/7902#issuecomment-470061975 > It is a class that is specific to Kafka and that is internal, that's why it should be in the

[GitHub] [flink] zentol commented on issue #7850: [FLINK-11183][metrics] Properly measure current memory usage

2019-03-06 Thread GitBox
zentol commented on issue #7850: [FLINK-11183][metrics] Properly measure current memory usage URL: https://github.com/apache/flink/pull/7850#issuecomment-470067647 I don't think tests are worth it in this case. You have to do some funky things to test these metrics, and even then you

[GitHub] [flink] aljoscha commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java

2019-03-06 Thread GitBox
aljoscha commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java URL: https://github.com/apache/flink/pull/7902#issuecomment-470067748 @lamber-ken Do you want to move both `KeyedSerializationSchemaWrapper` and

[jira] [Created] (FLINK-11837) Improve blink internal data foramt

2019-03-06 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-11837: Summary: Improve blink internal data foramt Key: FLINK-11837 URL: https://issues.apache.org/jira/browse/FLINK-11837 Project: Flink Issue Type: New Feature

[GitHub] [flink] lamber-ken commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java

2019-03-06 Thread GitBox
lamber-ken commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java URL: https://github.com/apache/flink/pull/7902#issuecomment-470083443 @aljoscha, I pushed two commits to fix the problem, cc.

[jira] [Closed] (FLINK-11378) Allow HadoopRecoverableWriter to write to Hadoop compatible Filesystems

2019-03-06 Thread Martijn van de Grift (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van de Grift closed FLINK-11378. Resolution: Won't Fix > Allow HadoopRecoverableWriter to write to Hadoop

[GitHub] [flink] zentol commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread GitBox
zentol commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0 URL: https://github.com/apache/flink/pull/7912#issuecomment-470098669 Ha, we may want to keep `LICENSE.slf4j` actually. I don't know where the `slf4j-api` one comes from (it is not from

[GitHub] [flink] aljoscha commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread GitBox
aljoscha commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0 URL: https://github.com/apache/flink/pull/7912#issuecomment-470098877 ok, will manually keep that. But someone might forget that in the future 

[GitHub] [flink] aljoscha commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread GitBox
aljoscha commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0 URL: https://github.com/apache/flink/pull/7912#issuecomment-470098895 thanks! This is an automated message from the

[jira] [Commented] (FLINK-11378) Allow HadoopRecoverableWriter to write to Hadoop compatible Filesystems

2019-03-06 Thread Martijn van de Grift (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785606#comment-16785606 ] Martijn van de Grift commented on FLINK-11378: -- yup, created a link in the ticket. > Allow

[jira] [Commented] (FLINK-11836) Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785615#comment-16785615 ] Aljoscha Krettek commented on FLINK-11836: -- I merged the change to {{collect_license_files.sh}}

[jira] [Created] (FLINK-11842) Introduce FlinkLogicalMatch

2019-03-06 Thread godfrey he (JIRA)
godfrey he created FLINK-11842: -- Summary: Introduce FlinkLogicalMatch Key: FLINK-11842 URL: https://issues.apache.org/jira/browse/FLINK-11842 Project: Flink Issue Type: New Feature

[GitHub] [flink] StefanRRichter commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test

2019-03-06 Thread GitBox
StefanRRichter commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test URL: https://github.com/apache/flink/pull/7896#discussion_r262880130 ## File path:

[jira] [Created] (FLINK-11836) Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-11836: Summary: Update NOTICE-binary and licenses-binary for Flink 1.8.0 Key: FLINK-11836 URL: https://issues.apache.org/jira/browse/FLINK-11836 Project: Flink

[GitHub] [flink] lamber-ken commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java

2019-03-06 Thread GitBox
lamber-ken commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java URL: https://github.com/apache/flink/pull/7902#issuecomment-470068516 @aljoscha, `TypeInformationKeyValueSerializationSchema` also marked as `@Internal`, should I

[GitHub] [flink] tillrohrmann edited a comment on issue #7900: [FLINK-11826] Fix flaky Kafka ratelimiter test

2019-03-06 Thread GitBox
tillrohrmann edited a comment on issue #7900: [FLINK-11826] Fix flaky Kafka ratelimiter test URL: https://github.com/apache/flink/pull/7900#issuecomment-470085943 The test case still needs 34 s on my machine. Per se this is not bad if this time is really required. I don't know exactly

[GitHub] [flink] zentol commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread GitBox
zentol commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0 URL: https://github.com/apache/flink/pull/7912#issuecomment-470098720 Beyond that, +1. This is an automated message from

[GitHub] [flink] aljoscha commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java

2019-03-06 Thread GitBox
aljoscha commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java URL: https://github.com/apache/flink/pull/7902#issuecomment-470103065 `TypeInformationKeyValueSerializationSchema` is a strange case. I think you're right that it

[jira] [Updated] (FLINK-11839) Introduce FlinkLogicalWindowAggregate

2019-03-06 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-11839: --- Summary: Introduce FlinkLogicalWindowAggregate (was: Introduce the rest flink logical relational

[jira] [Created] (FLINK-11841) Introduce FlinkLogicalSemiJoin

2019-03-06 Thread godfrey he (JIRA)
godfrey he created FLINK-11841: -- Summary: Introduce FlinkLogicalSemiJoin Key: FLINK-11841 URL: https://issues.apache.org/jira/browse/FLINK-11841 Project: Flink Issue Type: New Feature

[GitHub] [flink] zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-06 Thread GitBox
zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r262877734 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test

2019-03-06 Thread GitBox
StefanRRichter commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test URL: https://github.com/apache/flink/pull/7896#discussion_r262880130 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test

2019-03-06 Thread GitBox
StefanRRichter commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test URL: https://github.com/apache/flink/pull/7896#discussion_r262879930 ## File path:

[GitHub] [flink] aljoscha commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java

2019-03-06 Thread GitBox
aljoscha commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java URL: https://github.com/apache/flink/pull/7902#issuecomment-470058745 It is a class that is specific to Kafka and that is internal, that's why it should be in the

[GitHub] [flink] aljoscha opened a new pull request #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread GitBox
aljoscha opened a new pull request #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0 URL: https://github.com/apache/flink/pull/7912 This is an automated message from the Apache Git Service. To

[jira] [Closed] (FLINK-11830) Introduce CodeGeneratorContext to maintain reusable statements for code generation

2019-03-06 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-11830. --- Resolution: Fixed Fixed in 1.9: ec3b36c4f0941ded4cb8768897269d9769f80532 > Introduce CodeGeneratorContext

[jira] [Commented] (FLINK-11825) Resolve name clash of StateTTL TimeCharacteristic class

2019-03-06 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785550#comment-16785550 ] Andrey Zagrebin commented on FLINK-11825: - [~fhueske], thanks for creating the issue, I agree we

[jira] [Assigned] (FLINK-11825) Resolve name clash of StateTTL TimeCharacteristic class

2019-03-06 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Zagrebin reassigned FLINK-11825: --- Assignee: Congxian Qiu(klion26) > Resolve name clash of StateTTL

[jira] [Updated] (FLINK-11839) Introduce the rest flink logical relational nodes

2019-03-06 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-11839: --- Description: the rest flink logical relational nodes contains: {{FlinkLogicalWindowAggregate}}

[jira] [Closed] (FLINK-11836) Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-11836. Resolution: Fixed Updated licenses on release-1.8 in

[jira] [Updated] (FLINK-11839) Introduce the rest flink logical relational nodes

2019-03-06 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-11839: --- Description: The rest flink logical relational nodes contains {{FlinkLogicalWindowAggregate}}

[jira] [Updated] (FLINK-11821) Fix package declaration and location of internal Kafka schema wrappers

2019-03-06 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-11821: - Summary: Fix package declaration and location of internal Kafka schema wrappers (was:

[GitHub] [flink] zentol opened a new pull request #7914: [FLINK-11786][travis] Merge cron branches into master

2019-03-06 Thread GitBox
zentol opened a new pull request #7914: [FLINK-11786][travis] Merge cron branches into master URL: https://github.com/apache/flink/pull/7914 ## What is the purpose of the change This PR merges all **daily** cron branches into the master. This significantly improves their

[jira] [Created] (FLINK-11840) Introduce FlinkLogicalSnapshot

2019-03-06 Thread godfrey he (JIRA)
godfrey he created FLINK-11840: -- Summary: Introduce FlinkLogicalSnapshot Key: FLINK-11840 URL: https://issues.apache.org/jira/browse/FLINK-11840 Project: Flink Issue Type: New Feature

[jira] [Updated] (FLINK-11786) Merge cron branches into respective release branches

2019-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11786: --- Labels: pull-request-available (was: ) > Merge cron branches into respective release

[jira] [Updated] (FLINK-11840) Introduce FlinkLogicalSnapshot

2019-03-06 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-11840: --- Description: {{Snapshot}} hasn't been introduced into Calcite yet. (was: `Snapshot` hasn't been

[GitHub] [flink] flinkbot commented on issue #7914: [FLINK-11786][travis] Merge cron branches into master

2019-03-06 Thread GitBox
flinkbot commented on issue #7914: [FLINK-11786][travis] Merge cron branches into master URL: https://github.com/apache/flink/pull/7914#issuecomment-470104744 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] zentol commented on issue #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial

2019-03-06 Thread GitBox
zentol commented on issue #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial URL: https://github.com/apache/flink/pull/7897#issuecomment-470111942 @mikeholler See https://issues.apache.org/jira/browse/FLINK-5720 for why it was deprecated.

[jira] [Updated] (FLINK-11821) Fix package declaration of KafkaDeserializationSchemaWrapper

2019-03-06 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-11821: - Summary: Fix package declaration of KafkaDeserializationSchemaWrapper (was: fix the

[GitHub] [flink] lamber-ken edited a comment on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java

2019-03-06 Thread GitBox
lamber-ken edited a comment on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java URL: https://github.com/apache/flink/pull/7902#issuecomment-470068516 @aljoscha, `TypeInformationKeyValueSerializationSchema` also marked as `@Internal`,

[GitHub] [flink] aljoscha commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread GitBox
aljoscha commented on issue #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0 URL: https://github.com/apache/flink/pull/7912#issuecomment-470097978 @zentol I'm now sorting the `NOTICE` files before concatenation. This makes the diff bigger now but should lead

[jira] [Created] (FLINK-11839) Introduce the rest flink logical relational nodes

2019-03-06 Thread godfrey he (JIRA)
godfrey he created FLINK-11839: -- Summary: Introduce the rest flink logical relational nodes Key: FLINK-11839 URL: https://issues.apache.org/jira/browse/FLINK-11839 Project: Flink Issue Type:

[GitHub] [flink] aljoscha closed pull request #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0

2019-03-06 Thread GitBox
aljoscha closed pull request #7912: [FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0 URL: https://github.com/apache/flink/pull/7912 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] zentol commented on a change in pull request #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial

2019-03-06 Thread GitBox
zentol commented on a change in pull request #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial URL: https://github.com/apache/flink/pull/7897#discussion_r262946696 ## File path: docs/tutorials/datastream_api.md ## @@ -240,13 +255,28 @@ public class

[GitHub] [flink] flinkbot edited a comment on issue #7820: [FLINK-11742][Metrics]Push metrics to Pushgateway without "instance"

2019-03-06 Thread GitBox
flinkbot edited a comment on issue #7820: [FLINK-11742][Metrics]Push metrics to Pushgateway without "instance" URL: https://github.com/apache/flink/pull/7820#issuecomment-466942158 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] Tom-Goong commented on a change in pull request #7820: [FLINK-11742][Metrics]Push metrics to Pushgateway without "instance"

2019-03-06 Thread GitBox
Tom-Goong commented on a change in pull request #7820: [FLINK-11742][Metrics]Push metrics to Pushgateway without "instance" URL: https://github.com/apache/flink/pull/7820#discussion_r262946808 ## File path:

[GitHub] [flink] aljoscha commented on issue #7876: [FLINK-11751] Extend release notes for Flink 1.8

2019-03-06 Thread GitBox
aljoscha commented on issue #7876: [FLINK-11751] Extend release notes for Flink 1.8 URL: https://github.com/apache/flink/pull/7876#issuecomment-470062954 merged This is an automated message from the Apache Git Service. To

[GitHub] [flink] aljoscha closed pull request #7876: [FLINK-11751] Extend release notes for Flink 1.8

2019-03-06 Thread GitBox
aljoscha closed pull request #7876: [FLINK-11751] Extend release notes for Flink 1.8 URL: https://github.com/apache/flink/pull/7876 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Closed] (FLINK-11751) Extend release notes for Flink 1.8

2019-03-06 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-11751. Resolution: Fixed Added on master in cf3390b901147c86446ae36e79f1136132f78bb4 Added on

[GitHub] [flink] lamber-ken edited a comment on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java

2019-03-06 Thread GitBox
lamber-ken edited a comment on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java URL: https://github.com/apache/flink/pull/7902#issuecomment-470061975 > It is a class that is specific to Kafka and that is internal, that's why it should be

[jira] [Updated] (FLINK-11837) Improve blink internal data format

2019-03-06 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-11837: - Summary: Improve blink internal data format (was: Improve blink internal data foramt) >

[GitHub] [flink] JingsongLi opened a new pull request #7913: [FLINK-11837][table-runtime-blink] Improve blink internal data format

2019-03-06 Thread GitBox
JingsongLi opened a new pull request #7913: [FLINK-11837][table-runtime-blink] Improve blink internal data format URL: https://github.com/apache/flink/pull/7913 ## What is the purpose of the change Introduce Decimal: Scale of this object is specified by the user, not

[jira] [Commented] (FLINK-11378) Allow HadoopRecoverableWriter to write to Hadoop compatible Filesystems

2019-03-06 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785587#comment-16785587 ] Fokko Driesprong commented on FLINK-11378: -- FLINK-11378 should supersede this ticket. > Allow

[jira] [Closed] (FLINK-11781) Config option yarn.per-job-cluster.include-user-jar cannot be set to DISABLED

2019-03-06 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao closed FLINK-11781. Resolution: Fixed Fixed via 1.8: 704f0a60d24ba1358656468861bd06c6ce4ddb88 1.9:

[GitHub] [flink] godfreyhe commented on a change in pull request #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes

2019-03-06 Thread GitBox
godfreyhe commented on a change in pull request #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes URL: https://github.com/apache/flink/pull/7910#discussion_r262927803 ## File path:

[jira] [Created] (FLINK-11838) Create RecoverableWriter for GCS

2019-03-06 Thread Fokko Driesprong (JIRA)
Fokko Driesprong created FLINK-11838: Summary: Create RecoverableWriter for GCS Key: FLINK-11838 URL: https://issues.apache.org/jira/browse/FLINK-11838 Project: Flink Issue Type:

[GitHub] [flink] KurtYoung commented on issue #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes

2019-03-06 Thread GitBox
KurtYoung commented on issue #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes URL: https://github.com/apache/flink/pull/7910#issuecomment-470100165 I think you can open a jira to track all unmerged logical nodes

[jira] [Updated] (FLINK-11840) Introduce FlinkLogicalSnapshot

2019-03-06 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-11840: --- Description: {{Snapshot}} hasn't been introduced into Calcite yet. It's a whole new feature.

[GitHub] [flink] aljoscha commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java

2019-03-06 Thread GitBox
aljoscha commented on issue #7902: [FLINK-11821] fix the error package location of KafkaDeserializationSchemaWrapper.java URL: https://github.com/apache/flink/pull/7902#issuecomment-470113472 Thanks a lot for working on this so quickly, @lamber-ken!  I'll merge once Travis is green and

[GitHub] [flink] zentol commented on issue #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial

2019-03-06 Thread GitBox
zentol commented on issue #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial URL: https://github.com/apache/flink/pull/7897#issuecomment-470113504 @flinkbot approve-until quality This is an automated

[GitHub] [flink] zentol commented on a change in pull request #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial

2019-03-06 Thread GitBox
zentol commented on a change in pull request #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial URL: https://github.com/apache/flink/pull/7897#discussion_r262947145 ## File path: docs/tutorials/datastream_api.md ## @@ -368,14 +398,14 @@ The output of

[GitHub] [flink] flinkbot edited a comment on issue #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial

2019-03-06 Thread GitBox
flinkbot edited a comment on issue #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial URL: https://github.com/apache/flink/pull/7897#issuecomment-469527787 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[jira] [Closed] (FLINK-11827) Introduce DataFormatConverters to convert internal data format and java format

2019-03-06 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-11827. -- fixed in e2579e39602ab7d3e906a185353dd413aca58317 > Introduce DataFormatConverters to convert internal

[GitHub] [flink] asfgit merged pull request #7883: [FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar

2019-03-06 Thread GitBox
asfgit merged pull request #7883: [FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar URL: https://github.com/apache/flink/pull/7883 This is an automated message from the Apache

[jira] [Updated] (FLINK-11082) Increase backlog only if it is available for consumption

2019-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11082: --- Labels: pull-request-available (was: ) > Increase backlog only if it is available for

[GitHub] [flink] asfgit closed pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-06 Thread GitBox
asfgit closed pull request #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906 This is an automated message from the Apache

[GitHub] [flink] flinkbot edited a comment on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-03-06 Thread GitBox
flinkbot edited a comment on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#issuecomment-469214275 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Assigned] (FLINK-11835) ZooKeeperLeaderElectionITCase#testJobExecutionOnClusterWithLeaderChange failed

2019-03-06 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TisonKun reassigned FLINK-11835: Assignee: TisonKun > ZooKeeperLeaderElectionITCase#testJobExecutionOnClusterWithLeaderChange

[GitHub] [flink] azagrebin commented on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-03-06 Thread GitBox
azagrebin commented on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#issuecomment-470043373 @flinkbot attention @tillrohrmann This is an

[jira] [Created] (FLINK-11835) ZooKeeperLeaderElectionITCase#testJobExecutionOnClusterWithLeaderChange failed

2019-03-06 Thread Gary Yao (JIRA)
Gary Yao created FLINK-11835: Summary: ZooKeeperLeaderElectionITCase#testJobExecutionOnClusterWithLeaderChange failed Key: FLINK-11835 URL: https://issues.apache.org/jira/browse/FLINK-11835 Project:

[jira] [Resolved] (FLINK-11833) Cleanup unnecessary createKeyedStateBackend methods in StateBackend

2019-03-06 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter resolved FLINK-11833. Resolution: Implemented Fix Version/s: 1.8.0 Merged in: master: f10a7d8b

[GitHub] [flink] flinkbot commented on issue #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes

2019-03-06 Thread GitBox
flinkbot commented on issue #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes URL: https://github.com/apache/flink/pull/7910#issuecomment-470020759 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Updated] (FLINK-11834) Introduce flink logical relational nodes

2019-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11834: --- Labels: pull-request-available (was: ) > Introduce flink logical relational nodes >

[GitHub] [flink] godfreyhe opened a new pull request #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes

2019-03-06 Thread GitBox
godfreyhe opened a new pull request #7910: [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes URL: https://github.com/apache/flink/pull/7910 ## What is the purpose of the change Introduce flink logical relational nodes. This commit includes most

[GitHub] [flink] carp84 commented on issue #7909: [FLINK-11833] [State Backends] Cleanup unnecessary createKeyedStateBackend methods in StateBackend

2019-03-06 Thread GitBox
carp84 commented on issue #7909: [FLINK-11833] [State Backends] Cleanup unnecessary createKeyedStateBackend methods in StateBackend URL: https://github.com/apache/flink/pull/7909#issuecomment-470034332 Thanks Stefan! This is

[GitHub] [flink] StefanRRichter merged pull request #7909: [FLINK-11833] [State Backends] Cleanup unnecessary createKeyedStateBackend methods in StateBackend

2019-03-06 Thread GitBox
StefanRRichter merged pull request #7909: [FLINK-11833] [State Backends] Cleanup unnecessary createKeyedStateBackend methods in StateBackend URL: https://github.com/apache/flink/pull/7909 This is an automated message from

[GitHub] [flink] wuchong commented on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements

2019-03-06 Thread GitBox
wuchong commented on issue #7906: [FLINK-11830][table-planner-blink] Introduce CodeGeneratorContext to maintain reusable statements URL: https://github.com/apache/flink/pull/7906#issuecomment-470041108 Merging... This is an

[GitHub] [flink] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-03-06 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r262863643 ## File path:

[GitHub] [flink] zhijiangW opened a new pull request #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition

2019-03-06 Thread GitBox
zhijiangW opened a new pull request #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition URL: https://github.com/apache/flink/pull/7911 ## What is the purpose of the change *In current implementation, the backlog would be increased by 1 once

  1   2   >