[GitHub] [flink] flinkbot commented on issue #7982: [FLINK-11788][table-planner-blink] Support Code Generation for RexNode

2019-03-14 Thread GitBox
flinkbot commented on issue #7982: [FLINK-11788][table-planner-blink] Support Code Generation for RexNode URL: https://github.com/apache/flink/pull/7982#issuecomment-472742422 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] kisimple opened a new pull request #7983: [hotfix] Fix a swallowed exception.

2019-03-14 Thread GitBox
kisimple opened a new pull request #7983: [hotfix] Fix a swallowed exception. URL: https://github.com/apache/flink/pull/7983 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] klion26 opened a new pull request #7984: [FLINK-11904][tests]Improve MemoryStateBackendTest by using JUnit's Parameterized

2019-03-14 Thread GitBox
klion26 opened a new pull request #7984: [FLINK-11904][tests]Improve MemoryStateBackendTest by using JUnit's Parameterized URL: https://github.com/apache/flink/pull/7984 ## What is the purpose of the change Improve `MemoryStateBackendTest` by using JUnit's Parameterized ##

[jira] [Updated] (FLINK-11904) Improve MemoryStateBackendTest by using JUnit's Parameterized

2019-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11904: --- Labels: pull-request-available (was: ) > Improve MemoryStateBackendTest by using JUnit's

[GitHub] [flink] flinkbot commented on issue #7984: [FLINK-11904][tests]Improve MemoryStateBackendTest by using JUnit's Parameterized

2019-03-14 Thread GitBox
flinkbot commented on issue #7984: [FLINK-11904][tests]Improve MemoryStateBackendTest by using JUnit's Parameterized URL: https://github.com/apache/flink/pull/7984#issuecomment-472754910 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] zentol merged pull request #7974: [FLINK-11902][rest] Do not wrap all exceptions in RestHandlerException

2019-03-14 Thread GitBox
zentol merged pull request #7974: [FLINK-11902][rest] Do not wrap all exceptions in RestHandlerException URL: https://github.com/apache/flink/pull/7974 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] zentol commented on a change in pull request #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial

2019-03-14 Thread GitBox
zentol commented on a change in pull request #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial URL: https://github.com/apache/flink/pull/7897#discussion_r265495257 ## File path: docs/tutorials/datastream_api.md ## @@ -198,7 +198,7 @@ DataStream>

[jira] [Updated] (FLINK-11853) Allow /jars/:jarid/plan as a POST request too

2019-03-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-11853: - Issue Type: New Feature (was: Improvement) > Allow /jars/:jarid/plan as a POST

[jira] [Updated] (FLINK-11853) Allow /jars/:jarid/plan as a POST request too

2019-03-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-11853: - Fix Version/s: 1.9.0 > Allow /jars/:jarid/plan as a POST request too >

[GitHub] [flink] twalthr commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread GitBox
twalthr commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow URL: https://github.com/apache/flink/pull/7985#issuecomment-472789736 @flinkbot approve-until quality This is an automated

[GitHub] [flink] flinkbot edited a comment on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread GitBox
flinkbot edited a comment on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow URL: https://github.com/apache/flink/pull/7985#issuecomment-472786851 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] zentol commented on a change in pull request #7968: [FLINK-11692] [Datadog Reporter] added proxy to datadog reporter

2019-03-14 Thread GitBox
zentol commented on a change in pull request #7968: [FLINK-11692] [Datadog Reporter] added proxy to datadog reporter URL: https://github.com/apache/flink/pull/7968#discussion_r265501216 ## File path: docs/monitoring/metrics.md ## @@ -760,6 +760,8 @@ Parameters: -

[GitHub] [flink] flinkbot edited a comment on issue #7976: [FLINK-11908] Port window classes into flink-api-java

2019-03-14 Thread GitBox
flinkbot edited a comment on issue #7976: [FLINK-11908] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#issuecomment-472496692 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[jira] [Commented] (FLINK-11818) Provide pipe transformation function for DataSet API

2019-03-14 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792451#comment-16792451 ] Fabian Hueske commented on FLINK-11818: --- I can see that such a function is valuable. However, I

[GitHub] [flink] flinkbot commented on issue #7983: [hotfix] Fix a swallowed exception.

2019-03-14 Thread GitBox
flinkbot commented on issue #7983: [hotfix] Fix a swallowed exception. URL: https://github.com/apache/flink/pull/7983#issuecomment-472750193 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use

[jira] [Created] (FLINK-11919) Exception in thread "main" org.apache.flink.table.api.SqlParserException: SQL parse failed. Encountered "FROM user" at line 1, column 17.

2019-03-14 Thread thinktothings (JIRA)
thinktothings created FLINK-11919: - Summary: Exception in thread "main" org.apache.flink.table.api.SqlParserException: SQL parse failed. Encountered "FROM user" at line 1, column 17. Key: FLINK-11919 URL:

[jira] [Assigned] (FLINK-11853) Allow /jars/:jarid/plan as a POST request too

2019-03-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-11853: Assignee: Stephen Connolly > Allow /jars/:jarid/plan as a POST request too >

[jira] [Updated] (FLINK-11918) Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11918: --- Labels: pull-request-available (was: ) > Deprecated Window and Rename it to GroupWindow >

[GitHub] [flink] hequn8128 opened a new pull request #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread GitBox
hequn8128 opened a new pull request #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow URL: https://github.com/apache/flink/pull/7985 ## What is the purpose of the change This pull request deprecates `Window` and Rename it to `GroupWindow`. ##

[GitHub] [flink] flinkbot edited a comment on issue #7934: [FLINK-11853] [rest] Minimal implementation of POST for /jars/:jarid/plan

2019-03-14 Thread GitBox
flinkbot edited a comment on issue #7934: [FLINK-11853] [rest] Minimal implementation of POST for /jars/:jarid/plan URL: https://github.com/apache/flink/pull/7934#issuecomment-470556565 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] flinkbot edited a comment on issue #7966: [FLINK-11887][metrics] Fixed latency metrics drift apart

2019-03-14 Thread GitBox
flinkbot edited a comment on issue #7966: [FLINK-11887][metrics] Fixed latency metrics drift apart URL: https://github.com/apache/flink/pull/7966#issuecomment-472009888 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] twalthr commented on a change in pull request #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread GitBox
twalthr commented on a change in pull request #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow URL: https://github.com/apache/flink/pull/7985#discussion_r265502166 ## File path:

[GitHub] [flink] sunjincheng121 commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread GitBox
sunjincheng121 commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow URL: https://github.com/apache/flink/pull/7985#issuecomment-472802257 > Thank you @hequn8128. > > What about `Tumble`, `Session`, `Slide`, and `Over` window? Do we also want

[GitHub] [flink] sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-03-14 Thread GitBox
sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-472744666 Um, OrcTableSource#applyPredicate will call `toOrcPredicate` method which using the plannerExpreasion, such as

[jira] [Created] (FLINK-11920) EnumValueSerializerUpgradeTest fails on Java 9

2019-03-14 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-11920: Summary: EnumValueSerializerUpgradeTest fails on Java 9 Key: FLINK-11920 URL: https://issues.apache.org/jira/browse/FLINK-11920 Project: Flink Issue

[GitHub] [flink] flinkbot edited a comment on issue #7977: [hotfix][runtime] Delete unused code from ExecutionGraph

2019-03-14 Thread GitBox
flinkbot edited a comment on issue #7977: [hotfix][runtime] Delete unused code from ExecutionGraph URL: https://github.com/apache/flink/pull/7977#issuecomment-472536271 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] zentol commented on issue #7952: [FLINK-11872][table-runtime-blink] update lz4 license file.

2019-03-14 Thread GitBox
zentol commented on issue #7952: [FLINK-11872][table-runtime-blink] update lz4 license file. URL: https://github.com/apache/flink/pull/7952#issuecomment-472795104 @flinkbot disapprove consensus This is an automated message

[GitHub] [flink] StefanRRichter merged pull request #7970: [FLINK-11874][checkpoint] Split CheckpointStorage interface to distinguish JM and TM side

2019-03-14 Thread GitBox
StefanRRichter merged pull request #7970: [FLINK-11874][checkpoint] Split CheckpointStorage interface to distinguish JM and TM side URL: https://github.com/apache/flink/pull/7970 This is an automated message from the Apache

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7976: [FLINK-11908] Port window classes into flink-api-java

2019-03-14 Thread GitBox
sunjincheng121 commented on a change in pull request #7976: [FLINK-11908] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#discussion_r265435172 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7976: [FLINK-11908] Port window classes into flink-api-java

2019-03-14 Thread GitBox
sunjincheng121 commented on a change in pull request #7976: [FLINK-11908] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#discussion_r265428159 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Over.java

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7976: [FLINK-11908] Port window classes into flink-api-java

2019-03-14 Thread GitBox
sunjincheng121 commented on a change in pull request #7976: [FLINK-11908] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#discussion_r265430557 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7976: [FLINK-11908] Port window classes into flink-api-java

2019-03-14 Thread GitBox
sunjincheng121 commented on a change in pull request #7976: [FLINK-11908] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#discussion_r265431296 ## File path:

[GitHub] [flink] Myasuka commented on issue #7970: [FLINK-11874][checkpoint] Split CheckpointStorage interface to distinguish JM and TM side

2019-03-14 Thread GitBox
Myasuka commented on issue #7970: [FLINK-11874][checkpoint] Split CheckpointStorage interface to distinguish JM and TM side URL: https://github.com/apache/flink/pull/7970#issuecomment-472733585 Travis fails due to a known instability test

[jira] [Commented] (FLINK-11835) ZooKeeperLeaderElectionITCase#testJobExecutionOnClusterWithLeaderChange failed

2019-03-14 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792421#comment-16792421 ] Yun Tang commented on FLINK-11835: -- Another instance

[jira] [Commented] (FLINK-11907) GenericTypeInfoTest fails on Java 9

2019-03-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792480#comment-16792480 ] Chesnay Schepler commented on FLINK-11907: -- The test already accounts for different

[GitHub] [flink] TisonKun commented on issue #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo…

2019-03-14 Thread GitBox
TisonKun commented on issue #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo… URL: https://github.com/apache/flink/pull/7971#issuecomment-472780872 @flinkbot attention @tillrohrmann @zentol This

[GitHub] [flink] flinkbot edited a comment on issue #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo…

2019-03-14 Thread GitBox
flinkbot edited a comment on issue #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo… URL: https://github.com/apache/flink/pull/7971#issuecomment-472349159 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Updated] (FLINK-50) HBase port from Paris Hackathon

2019-03-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-50: Component/s: Connectors / HBase > HBase port from Paris Hackathon > ---

[jira] [Commented] (FLINK-11914) Expose a REST endpoint in JobManager to kill specific TaskManager

2019-03-14 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792380#comment-16792380 ] Gary Yao commented on FLINK-11914: -- [~suez1224] I assume that you need this because you are not able to

[GitHub] [flink] sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-03-14 Thread GitBox
sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-472737451 @twalthr I find that there is also a commit here without merged [Change PlannerExpression to Expression in

[GitHub] [flink] wuchong opened a new pull request #7982: [FLINK-11788][table-planner-blink] Support Code Generation for RexNode

2019-03-14 Thread GitBox
wuchong opened a new pull request #7982: [FLINK-11788][table-planner-blink] Support Code Generation for RexNode URL: https://github.com/apache/flink/pull/7982 ## What is the purpose of the change This is the basic implementation to support code generation for RexNodes. ##

[jira] [Updated] (FLINK-11788) Support Code Generation for RexNode

2019-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11788: --- Labels: pull-request-available (was: ) > Support Code Generation for RexNode >

[GitHub] [flink] twalthr commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-03-14 Thread GitBox
twalthr commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-472747536 I think we are on the same page about the goal. The questions is how many times do we want to break SPI

[jira] [Commented] (FLINK-11818) Provide pipe transformation function for DataSet API

2019-03-14 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792455#comment-16792455 ] vinoyang commented on FLINK-11818: -- Thanks for your [~fhueske] . Sounds good to me. I will start this

[jira] [Closed] (FLINK-11902) JarRunHandler wraps all exceptions in a RestHandlerException

2019-03-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-11902. Resolution: Fixed Fix Version/s: 1.9.0 master:

[jira] [Closed] (FLINK-11183) Heap/NonHeap memory metrics broken

2019-03-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-11183. Resolution: Fixed Fix Version/s: 1.8.1 1.9.0 master:

[jira] [Updated] (FLINK-11918) Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-11918: Issue Type: Sub-task (was: Improvement) Parent: FLINK-11068 > Deprecated Window and

[jira] [Commented] (FLINK-11890) Replace Table API string-based expressions by a Java DSL

2019-03-14 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792393#comment-16792393 ] Hequn Cheng commented on FLINK-11890: - Cool, looking forward to the proposal. > Replace Table API

[GitHub] [flink] zentol merged pull request #7850: [FLINK-11183][metrics] Properly measure current memory usage

2019-03-14 Thread GitBox
zentol merged pull request #7850: [FLINK-11183][metrics] Properly measure current memory usage URL: https://github.com/apache/flink/pull/7850 This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-11845) Drop unused InfoMessage

2019-03-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-11845: - Component/s: (was: Runtime / Metrics) Runtime / REST > Drop unused

[jira] [Closed] (FLINK-11845) Drop unused InfoMessage

2019-03-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-11845. Resolution: Fixed master: d67f7dbaa096f7b2915675a1012fe31003441e7c > Drop unused

[GitHub] [flink] zentol merged pull request #7933: [FLINK-11845][metrics] Drop legacy InfoMessage

2019-03-14 Thread GitBox
zentol merged pull request #7933: [FLINK-11845][metrics] Drop legacy InfoMessage URL: https://github.com/apache/flink/pull/7933 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] zhijiangW commented on issue #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition

2019-03-14 Thread GitBox
zhijiangW commented on issue #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition URL: https://github.com/apache/flink/pull/7911#issuecomment-472789536 @pnowojski , I just refactor the commit and update the codes. Next I would verify the network benchmark and

[jira] [Updated] (FLINK-11914) Expose a REST endpoint in JobManager to kill specific TaskManager

2019-03-14 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-11914: - Summary: Expose a REST endpoint in JobManager to kill specific TaskManager (was: Expose a REST

[GitHub] [flink] sunjincheng121 commented on issue #7976: [FLINK-11908] Port window classes into flink-api-java

2019-03-14 Thread GitBox
sunjincheng121 commented on issue #7976: [FLINK-11908] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#issuecomment-472724193 @flinkbot approve description @flinkbot approve consensus

[jira] [Commented] (FLINK-11908) Port window classes into flink-api-java

2019-03-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792423#comment-16792423 ] Timo Walther commented on FLINK-11908: -- I think [~dawidwys] is facing similar issues with the

[GitHub] [flink] sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-03-14 Thread GitBox
sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-472775077 So, I'll check whether the changes are needed by port catalog. If so I'll create a new JIRA. for this change.

[GitHub] [flink] flinkbot commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread GitBox
flinkbot commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow URL: https://github.com/apache/flink/pull/7985#issuecomment-472786851 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[jira] [Resolved] (FLINK-11874) Split CheckpointStorage interface to distinguish JM and TM side

2019-03-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter resolved FLINK-11874. Resolution: Implemented Merged in: master: b6b4baf > Split CheckpointStorage interface

[GitHub] [flink] klion26 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type

2019-03-14 Thread GitBox
klion26 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type URL: https://github.com/apache/flink/pull/7978#discussion_r265436293 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java

[GitHub] [flink] klion26 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type

2019-03-14 Thread GitBox
klion26 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type URL: https://github.com/apache/flink/pull/7978#discussion_r265435977 ## File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java

[jira] [Comment Edited] (FLINK-11908) Port window classes into flink-api-java

2019-03-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792423#comment-16792423 ] Timo Walther edited comment on FLINK-11908 at 3/14/19 7:36 AM: --- I think

[GitHub] [flink] twalthr commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-03-14 Thread GitBox
twalthr commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-472739342 @sunjincheng121 good point. Maybe we should open a follow-up issue for this. I skipped this commit in order to not

[jira] [Commented] (FLINK-11143) AskTimeoutException is thrown during job submission and completion

2019-03-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792472#comment-16792472 ] Chesnay Schepler commented on FLINK-11143: -- [~alvinnik] Have you had a chance to test things

[jira] [Assigned] (FLINK-11918) Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng reassigned FLINK-11918: --- Assignee: Hequn Cheng > Deprecated Window and Rename it to GroupWindow >

[GitHub] [flink] TisonKun commented on a change in pull request #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo…

2019-03-14 Thread GitBox
TisonKun commented on a change in pull request #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo… URL: https://github.com/apache/flink/pull/7971#discussion_r265489814 ## File path:

[GitHub] [flink] TisonKun commented on a change in pull request #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo…

2019-03-14 Thread GitBox
TisonKun commented on a change in pull request #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo… URL: https://github.com/apache/flink/pull/7971#discussion_r265490610 ## File path:

[GitHub] [flink] TisonKun commented on a change in pull request #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo…

2019-03-14 Thread GitBox
TisonKun commented on a change in pull request #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo… URL: https://github.com/apache/flink/pull/7971#discussion_r265489847 ## File path:

[GitHub] [flink] zhijiangW commented on issue #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-14 Thread GitBox
zhijiangW commented on issue #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#issuecomment-472789881 @pnowojski , I updated the codes addressing above comments. :)

[GitHub] [flink] zentol commented on a change in pull request #7968: [FLINK-11692] [Datadog Reporter] added proxy to datadog reporter

2019-03-14 Thread GitBox
zentol commented on a change in pull request #7968: [FLINK-11692] [Datadog Reporter] added proxy to datadog reporter URL: https://github.com/apache/flink/pull/7968#discussion_r265500760 ## File path:

[GitHub] [flink] zentol commented on issue #7934: [FLINK-11853] [rest] Minimal implementation of POST for /jars/:jarid/plan

2019-03-14 Thread GitBox
zentol commented on issue #7934: [FLINK-11853] [rest] Minimal implementation of POST for /jars/:jarid/plan URL: https://github.com/apache/flink/pull/7934#issuecomment-472785812 @flinkbot approve-until quality This is an

[jira] [Resolved] (FLINK-11904) Improve MemoryStateBackendTest by using JUnit's Parameterized

2019-03-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter resolved FLINK-11904. Resolution: Implemented Merged in: master: 6c7ddf3 > Improve MemoryStateBackendTest by

[GitHub] [flink] StefanRRichter merged pull request #7984: [FLINK-11904][tests]Improve MemoryStateBackendTest by using JUnit's Parameterized

2019-03-14 Thread GitBox
StefanRRichter merged pull request #7984: [FLINK-11904][tests]Improve MemoryStateBackendTest by using JUnit's Parameterized URL: https://github.com/apache/flink/pull/7984 This is an automated message from the Apache Git

[jira] [Commented] (FLINK-9650) Support Protocol Buffers formats

2019-03-14 Thread Arup Malakar (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792629#comment-16792629 ] Arup Malakar commented on FLINK-9650: - Hey [~yanghua] do let me know if you are still interested in

[jira] [Updated] (FLINK-11915) DataInputViewStream skip returns wrong value

2019-03-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-11915: --- Component/s: Runtime / Operators > DataInputViewStream skip returns wrong value >

[jira] [Updated] (FLINK-7237) Remove DateTimeUtils from Flink once Calcite is upgraded to 1.14

2019-03-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-7237: Issue Type: Sub-task (was: Bug) Parent: FLINK-11921 > Remove DateTimeUtils from Flink

[jira] [Updated] (FLINK-11877) Implement the runtime handling of TwoInputSelectable

2019-03-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-11877: --- Component/s: Runtime / Operators > Implement the runtime handling of TwoInputSelectable >

[jira] [Updated] (FLINK-11915) DataInputViewStream skip returns wrong value

2019-03-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-11915: --- Component/s: Formats (JSON, Avro, Parquet, ORC, SequenceFile) > DataInputViewStream skip

[jira] [Updated] (FLINK-11900) Flink on Kubernetes sensitive about arguments placement

2019-03-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-11900: --- Component/s: Deployment / Kubernetes > Flink on Kubernetes sensitive about arguments

[jira] [Updated] (FLINK-11895) Allow FileSystem Configs to be altered at Runtime

2019-03-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-11895: --- Component/s: Connectors / FileSystem > Allow FileSystem Configs to be altered at Runtime >

[jira] [Updated] (FLINK-11876) Introduce the new interfaces TwoInputSelectable, BoundedOneInput and BoundedTwoInput

2019-03-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-11876: --- Component/s: Runtime / Operators > Introduce the new interfaces TwoInputSelectable,

[jira] [Updated] (FLINK-11878) Implement the runtime handling of BoundedOneInput and BoundedTwoInput

2019-03-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-11878: --- Component/s: Runtime / Operators > Implement the runtime handling of BoundedOneInput and

[jira] [Updated] (FLINK-7237) Remove DateTimeUtils from Flink once Calcite is upgraded to 1.14

2019-03-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-7237: Issue Type: Bug (was: Sub-task) Parent: (was: FLINK-10076) > Remove DateTimeUtils

[GitHub] [flink] sunjincheng121 commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread GitBox
sunjincheng121 commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow URL: https://github.com/apache/flink/pull/7985#issuecomment-472822443 Ah, Maybe you are right, but I think`Window` and `GroupWindow` affects the interface of the Table API. `def

[GitHub] [flink] pnowojski commented on a change in pull request #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition

2019-03-14 Thread GitBox
pnowojski commented on a change in pull request #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition URL: https://github.com/apache/flink/pull/7911#discussion_r265550623 ## File path:

[GitHub] [flink] KurtYoung commented on issue #7981: [FLINK-11905][table-runtime-blink] Fix BlockCompressionTest does not compile with Java 9

2019-03-14 Thread GitBox
KurtYoung commented on issue #7981: [FLINK-11905][table-runtime-blink] Fix BlockCompressionTest does not compile with Java 9 URL: https://github.com/apache/flink/pull/7981#issuecomment-472857887 Thanks @zentol for the reviewing, i will merge this now.

[jira] [Updated] (FLINK-261) JDBC Input and Output format for Stratosphere

2019-03-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-261: - Component/s: Connectors / JDBC > JDBC Input and Output format for Stratosphere >

[jira] [Updated] (FLINK-917) Rename netty IO Thread count parameters

2019-03-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-917: - Component/s: Runtime / Network > Rename netty IO Thread count parameters >

[jira] [Resolved] (FLINK-11903) Improve FileStateBackendTest by using JUnit's Parameterized

2019-03-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter resolved FLINK-11903. Resolution: Implemented Merged in: master: 76b9f8b > Improve FileStateBackendTest by

[jira] [Updated] (FLINK-11911) KafkaTopicPartition is not a valid POJO

2019-03-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-11911: - Fix Version/s: (was: 1.8.0) 1.9.0 > KafkaTopicPartition is not a

[GitHub] [flink] twalthr commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread GitBox
twalthr commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow URL: https://github.com/apache/flink/pull/7985#issuecomment-472821110 If we can accept a package break, we could also accept the break of `Window` to `GroupWindow` because this class is

[GitHub] [flink] pnowojski commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-14 Thread GitBox
pnowojski commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r265542571 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-14 Thread GitBox
pnowojski commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r265544159 ## File path:

[GitHub] [flink] sunjincheng121 edited a comment on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow

2019-03-14 Thread GitBox
sunjincheng121 edited a comment on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow URL: https://github.com/apache/flink/pull/7985#issuecomment-472834420 Ooh, @twalthr, I got your points! I think we are on the same page about put the deprecated APIs to 1.8

[GitHub] [flink] KurtYoung commented on issue #7952: [FLINK-11872][table-runtime-blink] update lz4 license file.

2019-03-14 Thread GitBox
KurtYoung commented on issue #7952: [FLINK-11872][table-runtime-blink] update lz4 license file. URL: https://github.com/apache/flink/pull/7952#issuecomment-472854272 Thanks @zentol for pointing this out. I was wondering how can i tell whether a dependent jar is packaged in flink's jar?

[jira] [Updated] (FLINK-11894) AbstractRowSerializer.serializeToPages return type should be void

2019-03-14 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-11894: --- Component/s: (was: API / Table SQL) Runtime / Operators >

[jira] [Closed] (FLINK-11814) Changes of FLINK-11516 causes compilation failure

2019-03-14 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-11814. --- Resolution: Cannot Reproduce > Changes of FLINK-11516 causes compilation failure >

[GitHub] [flink] StefanRRichter commented on issue #7896: [FLINK-9007] [kinesis] [e2e] Add Kinesis end-to-end test

2019-03-14 Thread GitBox
StefanRRichter commented on issue #7896: [FLINK-9007] [kinesis] [e2e] Add Kinesis end-to-end test URL: https://github.com/apache/flink/pull/7896#issuecomment-472808921 Test looks good to me, if @zentol is ok with delaying the port to the new framework I would approve and merge.

[GitHub] [flink] klion26 commented on issue #7973: [FLINK-11903][tests]Improve FileStateBackendTest by using JUnit's parameterized.

2019-03-14 Thread GitBox
klion26 commented on issue #7973: [FLINK-11903][tests]Improve FileStateBackendTest by using JUnit's parameterized. URL: https://github.com/apache/flink/pull/7973#issuecomment-472814159 Thanks for review @StefanRRichter This

[jira] [Updated] (FLINK-11820) KafkaDeserializationSchemaWrapper should handle record which value is null

2019-03-14 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken updated FLINK-11820: --- Attachment: (was: updateKafkaDeserialization.patch) > KafkaDeserializationSchemaWrapper should

  1   2   3   >