[GitHub] [flink] 1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r29711 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/

[GitHub] [flink] flinkbot commented on issue #8878: [FLINK-12971][table-planner-blink] Remove the constraint that lookup join needs a primary key or index key

2019-06-25 Thread GitBox
flinkbot commented on issue #8878: [FLINK-12971][table-planner-blink] Remove the constraint that lookup join needs a primary key or index key URL: https://github.com/apache/flink/pull/8878#issuecomment-505454290 Thanks a lot for your contribution to the Apache Flink project. I'm the @flink

[jira] [Updated] (FLINK-12981) Ignore NaN values in histogram's percentile implementation

2019-06-25 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-12981: Description: Histogram metrics use "long" values and therefore, there is no {{Double.NaN}} in {{De

[GitHub] [flink] 1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297198688 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/

[jira] [Updated] (FLINK-12971) Remove the constraint that lookup join needs a primary key or index key

2019-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12971: --- Labels: pull-request-available (was: ) > Remove the constraint that lookup join needs a pri

[GitHub] [flink] wuchong opened a new pull request #8878: [FLINK-12971][table-planner-blink] Remove the constraint that lookup join needs a primary key or index key

2019-06-25 Thread GitBox
wuchong opened a new pull request #8878: [FLINK-12971][table-planner-blink] Remove the constraint that lookup join needs a primary key or index key URL: https://github.com/apache/flink/pull/8878 ## What is the purpose of the change Remove the constraint that lookup join n

[GitHub] [flink] GJL commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
GJL commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297196281 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/

[GitHub] [flink] 1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297195803 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/

[GitHub] [flink] dawidwys commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/

2019-06-25 Thread GitBox
dawidwys commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/Executor URL: https://github.com/apache/flink/pull/8852#discussion_r297195167 ## File path: flin

[GitHub] [flink] dawidwys commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/

2019-06-25 Thread GitBox
dawidwys commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/Executor URL: https://github.com/apache/flink/pull/8852#discussion_r297194227 ## File path: flin

[GitHub] [flink] dawidwys commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/

2019-06-25 Thread GitBox
dawidwys commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/Executor URL: https://github.com/apache/flink/pull/8852#discussion_r297194109 ## File path: flin

[GitHub] [flink] flinkbot commented on issue #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible

2019-06-25 Thread GitBox
flinkbot commented on issue #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible URL: https://github.com/apache/flink/pull/8877#issuecomment-505447963 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] zentol commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-25 Thread GitBox
zentol commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r297190994 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/partition

[jira] [Updated] (FLINK-12984) Only call Histogram#getStatistics() once per set of retrieved statistics

2019-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12984: --- Labels: pull-request-available (was: ) > Only call Histogram#getStatistics() once per set o

[GitHub] [flink] 1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297190536 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/

[GitHub] [flink] NicoK opened a new pull request #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible

2019-06-25 Thread GitBox
NicoK opened a new pull request #8877: [FLINK-12984][metrics] only call Histogram#getStatistics() once where possible URL: https://github.com/apache/flink/pull/8877 ## What is the purpose of the change In some occasions, `Histogram#getStatistics()` was called multiple times to retri

[jira] [Created] (FLINK-12986) Add alternative implementations for BoundedBlockingSubpartition to address stability issues

2019-06-25 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-12986: Summary: Add alternative implementations for BoundedBlockingSubpartition to address stability issues Key: FLINK-12986 URL: https://issues.apache.org/jira/browse/FLINK-12986

[GitHub] [flink] flinkbot commented on issue #8876: [FLINK-12985][core][streaming] Rename StreamTransformation to org.apache.flink.api.dag.Transformation

2019-06-25 Thread GitBox
flinkbot commented on issue #8876: [FLINK-12985][core][streaming] Rename StreamTransformation to org.apache.flink.api.dag.Transformation URL: https://github.com/apache/flink/pull/8876#issuecomment-505446801 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot.

[GitHub] [flink] aljoscha commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/

2019-06-25 Thread GitBox
aljoscha commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/Executor URL: https://github.com/apache/flink/pull/8852#discussion_r297189136 ## File path: flin

[GitHub] [flink] aljoscha commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/

2019-06-25 Thread GitBox
aljoscha commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/Executor URL: https://github.com/apache/flink/pull/8852#discussion_r297180051 ## File path: flin

[GitHub] [flink] zentol commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-25 Thread GitBox
zentol commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r297189246 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/partition

[GitHub] [flink] aljoscha commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/

2019-06-25 Thread GitBox
aljoscha commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/Executor URL: https://github.com/apache/flink/pull/8852#discussion_r297184155 ## File path: flin

[jira] [Updated] (FLINK-12985) Move & rename StreamTransformation to org.apache.flink.api.dag.Transformation

2019-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12985: --- Labels: pull-request-available (was: ) > Move & rename StreamTransformation to org.apache.f

[GitHub] [flink] dawidwys opened a new pull request #8876: [FLINK-12985][core][streaming] Rename StreamTransformation to org.apache.flink.api.dag.Transformation

2019-06-25 Thread GitBox
dawidwys opened a new pull request #8876: [FLINK-12985][core][streaming] Rename StreamTransformation to org.apache.flink.api.dag.Transformation URL: https://github.com/apache/flink/pull/8876 ## What is the purpose of the change It makes the structure of flink-core module cleaner as w

[GitHub] [flink] azagrebin commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-25 Thread GitBox
azagrebin commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r297184717 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/partit

[GitHub] [flink] azagrebin commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-25 Thread GitBox
azagrebin commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r297174417 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/partit

[GitHub] [flink] azagrebin commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-25 Thread GitBox
azagrebin commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r297174284 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskEx

[GitHub] [flink] azagrebin commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-25 Thread GitBox
azagrebin commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r297175788 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskSu

[GitHub] [flink] azagrebin commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-25 Thread GitBox
azagrebin commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r297174230 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskEx

[GitHub] [flink] 1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297188355 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/

[GitHub] [flink] GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-25 Thread GitBox
GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297187374 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.

[GitHub] [flink] GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-25 Thread GitBox
GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297187235 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.

[jira] [Updated] (FLINK-12983) Replace descriptive histogram's storage back-end

2019-06-25 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-12983: Description: {{DescriptiveStatistics}} relies on their {{ResizableDoubleArray}} for storing doubl

[GitHub] [flink] GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-25 Thread GitBox
GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297186191 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/

[jira] [Updated] (FLINK-12985) Move & rename StreamTransformation to org.apache.flink.api.dag.Transformation

2019-06-25 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-12985: - Description: It is quite strange to have a streaming package in {{flink-core}}. Moreover

[jira] [Created] (FLINK-12985) Move & rename StreamTransformation to org.apache.flink.api.dag.Transformation

2019-06-25 Thread Dawid Wysakowicz (JIRA)
Dawid Wysakowicz created FLINK-12985: Summary: Move & rename StreamTransformation to org.apache.flink.api.dag.Transformation Key: FLINK-12985 URL: https://issues.apache.org/jira/browse/FLINK-12985

[jira] [Updated] (FLINK-12985) Move & rename StreamTransformation to org.apache.flink.api.dag.Transformation

2019-06-25 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-12985: - Description: It is quite strange to have a streaming package in {{flink-core}}. Moreover

[GitHub] [flink] GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-25 Thread GitBox
GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297184459 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/RegionPartition

[GitHub] [flink] 1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
1u0 commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297184968 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/

[GitHub] [flink] GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-25 Thread GitBox
GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297184459 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/RegionPartition

[GitHub] [flink] GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-25 Thread GitBox
GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297183313 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex

[GitHub] [flink] GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-25 Thread GitBox
GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297183313 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex

[GitHub] [flink] GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-25 Thread GitBox
GJL commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297183277 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex

[jira] [Commented] (FLINK-12070) Make blocking result partitions consumable multiple times

2019-06-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872339#comment-16872339 ] Stephan Ewen commented on FLINK-12070: -- [~kevin.cyj] You are right, the surrounding

[GitHub] [flink] GJL commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
GJL commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297174451 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/

[GitHub] [flink] pnowojski commented on issue #8826: [FLINK-12479][operators] Integrate StreamInputProcessor(s) with mailbox

2019-06-25 Thread GitBox
pnowojski commented on issue #8826: [FLINK-12479][operators] Integrate StreamInputProcessor(s) with mailbox URL: https://github.com/apache/flink/pull/8826#issuecomment-505434897 > Suggestion: you can rename old StreamInputProcessor to StreamOneInputProcessor first, in a separate commit. An

[GitHub] [flink] zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r29716 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongra

[GitHub] [flink] zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297151991 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/Ex

[GitHub] [flink] zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297156706 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongra

[GitHub] [flink] zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297155774 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongra

[GitHub] [flink] zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297174882 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongra

[GitHub] [flink] zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297154492 ## File path: flink-tests/src/test/java/org/apache/flink/test/runtime/RegionFai

[GitHub] [flink] zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297172655 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongra

[GitHub] [flink] zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zentol commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297167314 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongra

[jira] [Closed] (FLINK-12969) Remove dependencies on RelNode from TableImpl in blink planner

2019-06-25 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12969. -- Resolution: Fixed Fix Version/s: 1.9.0 merged in 1.9.0: adb7aab55feca41c4e4a2646ddc8bc272c02209

[GitHub] [flink] KurtYoung merged pull request #8866: [FLINK-12969] [table-planner-blink] Remove dependencies on RelNode from TableImpl in blink planner

2019-06-25 Thread GitBox
KurtYoung merged pull request #8866: [FLINK-12969] [table-planner-blink] Remove dependencies on RelNode from TableImpl in blink planner URL: https://github.com/apache/flink/pull/8866 This is an automated message from the Apa

[GitHub] [flink] dawidwys commented on issue #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner

2019-06-25 Thread GitBox
dawidwys commented on issue #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner URL: https://github.com/apache/flink/pull/8859#issuecomment-505432196 Hi @bowenli86 this is a good point. I will address it soon. One somewhat related question. Does the hiv

[GitHub] [flink] lirui-apache commented on issue #8875: [FLINK-12970][hive] Support writing Hive complex types

2019-06-25 Thread GitBox
lirui-apache commented on issue #8875: [FLINK-12970][hive] Support writing Hive complex types URL: https://github.com/apache/flink/pull/8875#issuecomment-505431417 cc @xuefuz @bowenli86 @zjuwangg This is an automated message

[GitHub] [flink] KurtYoung commented on a change in pull request #8868: [FLINK-12972][table-planner-blink] Ensure calling open/close in join condition of generated functions for blink

2019-06-25 Thread GitBox
KurtYoung commented on a change in pull request #8868: [FLINK-12972][table-planner-blink] Ensure calling open/close in join condition of generated functions for blink URL: https://github.com/apache/flink/pull/8868#discussion_r297171293 ## File path: flink-table/flink-table-planner

[GitHub] [flink] flinkbot commented on issue #8875: [FLINK-12970][hive] Support writing Hive complex types

2019-06-25 Thread GitBox
flinkbot commented on issue #8875: [FLINK-12970][hive] Support writing Hive complex types URL: https://github.com/apache/flink/pull/8875#issuecomment-505431226 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull req

[jira] [Updated] (FLINK-12970) Support writing Hive complex types

2019-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12970: --- Labels: pull-request-available (was: ) > Support writing Hive complex types > -

[GitHub] [flink] lirui-apache opened a new pull request #8875: [FLINK-12970][hive] Support writing Hive complex types

2019-06-25 Thread GitBox
lirui-apache opened a new pull request #8875: [FLINK-12970][hive] Support writing Hive complex types URL: https://github.com/apache/flink/pull/8875 ## What is the purpose of the change To support writing to Hive tables with complex data types. ## Brief change log

[GitHub] [flink] flinkbot commented on issue #8874: [FLINK-12968][table-common] Add a utility for logical type casts

2019-06-25 Thread GitBox
flinkbot commented on issue #8874: [FLINK-12968][table-common] Add a utility for logical type casts URL: https://github.com/apache/flink/pull/8874#issuecomment-505430201 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review you

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297169235 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiong

[jira] [Updated] (FLINK-12968) Add a casting utility

2019-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12968: --- Labels: pull-request-available (was: ) > Add a casting utility > - > >

[GitHub] [flink] twalthr opened a new pull request #8874: [FLINK-12968][table-common] Add a utility for logical type casts

2019-06-25 Thread GitBox
twalthr opened a new pull request #8874: [FLINK-12968][table-common] Add a utility for logical type casts URL: https://github.com/apache/flink/pull/8874 ## What is the purpose of the change This introduces a utility for checking logical types for casting. The goal is to be SQL stand

[jira] [Created] (FLINK-12984) Only call Histogram#getStatistics() once per set of retrieved statistics

2019-06-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-12984: --- Summary: Only call Histogram#getStatistics() once per set of retrieved statistics Key: FLINK-12984 URL: https://issues.apache.org/jira/browse/FLINK-12984 Project: Flink

[jira] [Closed] (FLINK-10236) Reduce histogram percentile/quantile retrieval overhead

2019-06-25 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber closed FLINK-10236. --- Resolution: Duplicate > Reduce histogram percentile/quantile retrieval overhead > --

[jira] [Updated] (FLINK-12982) Make DescriptiveStatisticsHistogramStatistics a true point-in-time snapshot

2019-06-25 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-12982: Description: Instead of redirecting {{DescriptiveStatisticsHistogramStatistics}} calls to {{Descr

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297166582 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiong

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297165275 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiong

[jira] [Created] (FLINK-12983) Replace descriptive histogram's storage back-end

2019-06-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-12983: --- Summary: Replace descriptive histogram's storage back-end Key: FLINK-12983 URL: https://issues.apache.org/jira/browse/FLINK-12983 Project: Flink Issue Type: Su

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297156841 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] flinkbot edited a comment on issue #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager

2019-06-25 Thread GitBox
flinkbot edited a comment on issue #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager URL: https://github.com/apache/flink/pull/8646#issuecomment-499352004 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I hel

[GitHub] [flink] azagrebin commented on issue #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager

2019-06-25 Thread GitBox
azagrebin commented on issue #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager URL: https://github.com/apache/flink/pull/8646#issuecomment-505425316 @flinkbot approve all This is

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297156841 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] azagrebin commented on a change in pull request #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager

2019-06-25 Thread GitBox
azagrebin commented on a change in pull request #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager URL: https://github.com/apache/flink/pull/8646#discussion_r297107741 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/i

[GitHub] [flink] azagrebin commented on a change in pull request #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager

2019-06-25 Thread GitBox
azagrebin commented on a change in pull request #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager URL: https://github.com/apache/flink/pull/8646#discussion_r297102100 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/i

[GitHub] [flink] azagrebin commented on a change in pull request #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager

2019-06-25 Thread GitBox
azagrebin commented on a change in pull request #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager URL: https://github.com/apache/flink/pull/8646#discussion_r296229508 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/i

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297156841 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297102381 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297146159 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297150898 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297161516 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297151246 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297104389 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297141893 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297150363 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297158095 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297160285 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297155046 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297132959 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297105992 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

2019-06-25 Thread GitBox
pnowojski commented on a change in pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread URL: https://github.com/apache/flink/pull/8858#discussion_r297146406 ## File path: flink-streaming-java/src/test/java/org/apache/flink/stre

[GitHub] [flink] flinkbot commented on issue #8873: [FLINK-12639] [docs] add "getting started" section to documentation

2019-06-25 Thread GitBox
flinkbot commented on issue #8873: [FLINK-12639] [docs] add "getting started" section to documentation URL: https://github.com/apache/flink/pull/8873#issuecomment-505414780 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] azagrebin commented on issue #8857: [FLINK-12960][coordination][shuffle] Move ResultPartitionDeploymentDescriptor#releasedOnConsumption to PartitionDescriptor#releasedOnConsumption

2019-06-25 Thread GitBox
azagrebin commented on issue #8857: [FLINK-12960][coordination][shuffle] Move ResultPartitionDeploymentDescriptor#releasedOnConsumption to PartitionDescriptor#releasedOnConsumption URL: https://github.com/apache/flink/pull/8857#issuecomment-505414639 Thanks for the review @zentol @zhijiang

[jira] [Updated] (FLINK-12639) FLIP-42: Rework Documentation

2019-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12639: --- Labels: pull-request-available (was: ) > FLIP-42: Rework Documentation > --

[GitHub] [flink] knaufk opened a new pull request #8873: [FLINK-12639] [docs] add "getting started" section to documentation

2019-06-25 Thread GitBox
knaufk opened a new pull request #8873: [FLINK-12639] [docs] add "getting started" section to documentation URL: https://github.com/apache/flink/pull/8873 ## What is the purpose of the change Add a "Getting Started" section to the documentation to expand in the course of FLIP-42. Th

[GitHub] [flink] GJL commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
GJL commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297150424 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/

[GitHub] [flink] zentol commented on a change in pull request #8711: [FLINK-12817][docs]Correct the import in Processing function example.

2019-06-25 Thread GitBox
zentol commented on a change in pull request #8711: [FLINK-12817][docs]Correct the import in Processing function example. URL: https://github.com/apache/flink/pull/8711#discussion_r297149379 ## File path: docs/dev/stream/operators/process_function.md ## @@ -97,9 +97,7 @@ i

<    1   2   3   4   5   6   >