[GitHub] [flink] asfgit closed pull request #8955: [FLINK-13066][hive] append hive-site.xml to path of Hive conf dir

2019-07-04 Thread GitBox
asfgit closed pull request #8955: [FLINK-13066][hive] append hive-site.xml to path of Hive conf dir URL: https://github.com/apache/flink/pull/8955 This is an automated message from the Apache Git Service. To respond to the

[jira] [Closed] (FLINK-13087) Add group window Aggregate operator to Table API

2019-07-04 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-13087. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master:

[GitHub] [flink] asfgit closed pull request #8979: [FLINK-13087][table] Add group window Aggregate operator to Table API

2019-07-04 Thread GitBox
asfgit closed pull request #8979: [FLINK-13087][table] Add group window Aggregate operator to Table API URL: https://github.com/apache/flink/pull/8979 This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (FLINK-13105) Add documentation for blink planner's built-in functions

2019-07-04 Thread Zhenghua Gao (JIRA)
Zhenghua Gao created FLINK-13105: Summary: Add documentation for blink planner's built-in functions Key: FLINK-13105 URL: https://issues.apache.org/jira/browse/FLINK-13105 Project: Flink

[GitHub] [flink] dianfu commented on a change in pull request #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner

2019-07-04 Thread GitBox
dianfu commented on a change in pull request #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner URL: https://github.com/apache/flink/pull/8974#discussion_r300524035 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner

2019-07-04 Thread GitBox
dianfu commented on a change in pull request #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner URL: https://github.com/apache/flink/pull/8974#discussion_r300523932 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner

2019-07-04 Thread GitBox
dianfu commented on a change in pull request #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner URL: https://github.com/apache/flink/pull/8974#discussion_r300524015 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner

2019-07-04 Thread GitBox
dianfu commented on a change in pull request #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner URL: https://github.com/apache/flink/pull/8974#discussion_r300523549 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner

2019-07-04 Thread GitBox
dianfu commented on a change in pull request #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner URL: https://github.com/apache/flink/pull/8974#discussion_r300523978 ## File path:

[jira] [Commented] (FLINK-10908) Add yarn.application.priority in YarnConfigOptions

2019-07-04 Thread xymaqingxiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878942#comment-16878942 ] xymaqingxiang commented on FLINK-10908: --- [~yanghua] I'm sorry to bother you, please check it.

[GitHub] [flink] godfreyhe commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner

2019-07-04 Thread GitBox
godfreyhe commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner URL: https://github.com/apache/flink/pull/8898#discussion_r300529061 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner

2019-07-04 Thread GitBox
godfreyhe commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner URL: https://github.com/apache/flink/pull/8898#discussion_r300528900 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner

2019-07-04 Thread GitBox
godfreyhe commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner URL: https://github.com/apache/flink/pull/8898#discussion_r300528837 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner

2019-07-04 Thread GitBox
godfreyhe commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner URL: https://github.com/apache/flink/pull/8898#discussion_r300529253 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #8992: [FLINK-12723][docs] setup IDE for Python

2019-07-04 Thread GitBox
dianfu commented on a change in pull request #8992: [FLINK-12723][docs] setup IDE for Python URL: https://github.com/apache/flink/pull/8992#discussion_r300530627 ## File path: docs/flinkDev/ide_setup.md ## @@ -125,4 +125,31 @@ due to version incompatibilities with the

[GitHub] [flink] dianfu commented on a change in pull request #8992: [FLINK-12723][docs] setup IDE for Python

2019-07-04 Thread GitBox
dianfu commented on a change in pull request #8992: [FLINK-12723][docs] setup IDE for Python URL: https://github.com/apache/flink/pull/8992#discussion_r300530041 ## File path: docs/flinkDev/ide_setup.md ## @@ -125,4 +125,31 @@ due to version incompatibilities with the

[GitHub] [flink] dianfu commented on a change in pull request #8992: [FLINK-12723][docs] setup IDE for Python

2019-07-04 Thread GitBox
dianfu commented on a change in pull request #8992: [FLINK-12723][docs] setup IDE for Python URL: https://github.com/apache/flink/pull/8992#discussion_r300529302 ## File path: docs/flinkDev/ide_setup.md ## @@ -125,4 +125,31 @@ due to version incompatibilities with the

[jira] [Created] (FLINK-13106) Translate "parallel" page into Chinese

2019-07-04 Thread yelun (JIRA)
yelun created FLINK-13106: - Summary: Translate "parallel" page into Chinese Key: FLINK-13106 URL: https://issues.apache.org/jira/browse/FLINK-13106 Project: Flink Issue Type: Sub-task

[GitHub] [flink] dianfu commented on a change in pull request #8992: [FLINK-12723][docs] setup IDE for Python

2019-07-04 Thread GitBox
dianfu commented on a change in pull request #8992: [FLINK-12723][docs] setup IDE for Python URL: https://github.com/apache/flink/pull/8992#discussion_r300529840 ## File path: docs/flinkDev/ide_setup.md ## @@ -125,4 +125,31 @@ due to version incompatibilities with the

[jira] [Closed] (FLINK-13089) Implement batch nested loop join in blink

2019-07-04 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-13089. -- Resolution: Implemented Fix Version/s: 1.9.0 merged in 1.9.0:

[GitHub] [flink] KurtYoung merged pull request #8978: [FLINK-13089][table-planner-blink] Implement batch nested loop join and add join it cases in blink

2019-07-04 Thread GitBox
KurtYoung merged pull request #8978: [FLINK-13089][table-planner-blink] Implement batch nested loop join and add join it cases in blink URL: https://github.com/apache/flink/pull/8978 This is an automated message from the

[GitHub] [flink] wuchong commented on a change in pull request #8980: [FLINK-13040] promote blink table config

2019-07-04 Thread GitBox
wuchong commented on a change in pull request #8980: [FLINK-13040] promote blink table config URL: https://github.com/apache/flink/pull/8980#discussion_r300527074 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/api/PlannerConfigOptions.java

[GitHub] [flink] wuchong commented on a change in pull request #8980: [FLINK-13040] promote blink table config

2019-07-04 Thread GitBox
wuchong commented on a change in pull request #8980: [FLINK-13040] promote blink table config URL: https://github.com/apache/flink/pull/8980#discussion_r300527126 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/api/PlannerConfigOptions.java

[GitHub] [flink] wuchong commented on issue #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner

2019-07-04 Thread GitBox
wuchong commented on issue #8974: [FLINK-13082][table-planner-blink] Support MatchRecognize in blink planner URL: https://github.com/apache/flink/pull/8974#issuecomment-508614435 Thanks @dianfu for the reviewing. Will merge this after travis pass.

[GitHub] [flink] flinkbot commented on issue #8990: [FLINK-13104][metrics] Updated request callback to log warning on failure

2019-07-04 Thread GitBox
flinkbot commented on issue #8990: [FLINK-13104][metrics] Updated request callback to log warning on failure URL: https://github.com/apache/flink/pull/8990#issuecomment-508573215 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[jira] [Commented] (FLINK-11605) Translate the "Dataflow Programming Model" page into Chinese

2019-07-04 Thread QinChao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878911#comment-16878911 ] QinChao commented on FLINK-11605: - Hi Jark Wu, would you mind re-assign this issue to me? I find this

[jira] [Updated] (FLINK-12934) add hadoop dependencies as 'flink-shaded-hadoop-2-uber' for flink-connector-hive to connect to remote hive metastore service

2019-07-04 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12934: - Description: Now, for all hadoop related dependencies, we just use the single jar of

[jira] [Updated] (FLINK-12934) add hadoop dependencies as 'flink-shaded-hadoop-2-uber' for flink-connector-hive to connect to remote hive metastore service

2019-07-04 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12934: - Summary: add hadoop dependencies as 'flink-shaded-hadoop-2-uber' for flink-connector-hive to connect to

[jira] [Closed] (FLINK-12934) add hadoop dependencies as 'flink-shaded-hadoop-2-uber' for flink-connector-hive to connect to remote hive metastore service

2019-07-04 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12934. Resolution: Fixed merged in 1.9.0: 157079bb1f93d524b5e39f81d3423339e55abd7f > add hadoop dependencies as

[jira] [Closed] (FLINK-13066) append hive-site.xml to path of Hive conf dir

2019-07-04 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-13066. Resolution: Fixed merged in 1.9.0: 761ed7728fca566ba29e59aa9313a8d5553cfdb3 > append hive-site.xml to

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300521096 ## File path:

[GitHub] [flink] beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-04 Thread GitBox
beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300521093 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300521067 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300521080 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300521060 ## File path:

[GitHub] [flink] XuPingyong commented on a change in pull request #8980: [FLINK-13040] promote blink table config

2019-07-04 Thread GitBox
XuPingyong commented on a change in pull request #8980: [FLINK-13040] promote blink table config URL: https://github.com/apache/flink/pull/8980#discussion_r300520865 ## File path:

[jira] [Commented] (FLINK-11561) Translate "Flink Architecture" page into Chinese

2019-07-04 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878939#comment-16878939 ] Jark Wu commented on FLINK-11561: - Fixed in flink-web: 5a2e8a1dae1c0567dcdef94ed32fe94b87441845 >

[jira] [Created] (FLINK-13107) Port TableApi IT and UT

2019-07-04 Thread Jing Zhang (JIRA)
Jing Zhang created FLINK-13107: -- Summary: Port TableApi IT and UT Key: FLINK-13107 URL: https://issues.apache.org/jira/browse/FLINK-13107 Project: Flink Issue Type: Task Components:

[GitHub] [flink] dawidwys commented on a change in pull request #8984: [FLINK-13088][table-api] Support lazy query transformation & execution on TableEnvironment

2019-07-04 Thread GitBox
dawidwys commented on a change in pull request #8984: [FLINK-13088][table-api] Support lazy query transformation & execution on TableEnvironment URL: https://github.com/apache/flink/pull/8984#discussion_r300406916 ## File path:

[GitHub] [flink] xintongsong commented on issue #8740: [FLINK-12763][runtime] Fail job immediately if tasks’ resource needs can not be satisfied.

2019-07-04 Thread GitBox
xintongsong commented on issue #8740: [FLINK-12763][runtime] Fail job immediately if tasks’ resource needs can not be satisfied. URL: https://github.com/apache/flink/pull/8740#issuecomment-508495382 I think you are right. I can see the problem of the current solution. Just one

[GitHub] [flink] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-07-04 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r300420875 ## File path:

[jira] [Updated] (FLINK-13083) Various improvements PubSub Connector

2019-07-04 Thread Richard Deurwaarder (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Deurwaarder updated FLINK-13083: Description: * Add retry mechanism to Acknowledgement calls * Replace

[GitHub] [flink] banmoy edited a comment on issue #8611: [FLINK-12693][state] Store state per key-group in CopyOnWriteStateTable

2019-07-04 Thread GitBox
banmoy edited a comment on issue #8611: [FLINK-12693][state] Store state per key-group in CopyOnWriteStateTable URL: https://github.com/apache/flink/pull/8611#issuecomment-508508804 @StefanRRichter Thanks for the quick reply. I agree with you that the ut is not resonable and needs to

[jira] [Comment Edited] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-04 Thread Aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878727#comment-16878727 ] Aitozi edited comment on FLINK-12852 at 7/4/19 3:03 PM: [~zjwang] I'am sorry

[GitHub] [flink] godfreyhe commented on a change in pull request #8984: [FLINK-13088][table-api] Support lazy query transformation & execution on TableEnvironment

2019-07-04 Thread GitBox
godfreyhe commented on a change in pull request #8984: [FLINK-13088][table-api] Support lazy query transformation & execution on TableEnvironment URL: https://github.com/apache/flink/pull/8984#discussion_r300518526 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #8984: [FLINK-13088][table-api] Support lazy query transformation & execution on TableEnvironment

2019-07-04 Thread GitBox
godfreyhe commented on a change in pull request #8984: [FLINK-13088][table-api] Support lazy query transformation & execution on TableEnvironment URL: https://github.com/apache/flink/pull/8984#discussion_r300521120 ## File path:

[jira] [Closed] (FLINK-12956) Add a upsert table sink for JDBC

2019-07-04 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-12956. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in 1.9.0: a64a44ee1a5b63731fc82ebbb9443e276e359821 >

[GitHub] [flink] beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-04 Thread GitBox
beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300521116 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300521091 ## File path:

[GitHub] [flink] asfgit closed pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-07-04 Thread GitBox
asfgit closed pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-04 Thread GitBox
beyond1920 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300522940 ## File path:

[GitHub] [flink] ifndef-SleePy commented on a change in pull request #8985: [FLINK-13101][datastream] Introduce blockingAfterChainingOff property of StreamGraph

2019-07-04 Thread GitBox
ifndef-SleePy commented on a change in pull request #8985: [FLINK-13101][datastream] Introduce blockingAfterChainingOff property of StreamGraph URL: https://github.com/apache/flink/pull/8985#discussion_r300527550 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8980: [FLINK-13040] promote blink table config

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8980: [FLINK-13040] promote blink table config URL: https://github.com/apache/flink/pull/8980#discussion_r300527509 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner URL: https://github.com/apache/flink/pull/8898#discussion_r300531386 ## File path:

[GitHub] [flink] ifndef-SleePy commented on a change in pull request #8985: [FLINK-13101][datastream] Introduce blockingAfterChainingOff property of StreamGraph

2019-07-04 Thread GitBox
ifndef-SleePy commented on a change in pull request #8985: [FLINK-13101][datastream] Introduce blockingAfterChainingOff property of StreamGraph URL: https://github.com/apache/flink/pull/8985#discussion_r300531246 ## File path:

[GitHub] [flink] ifndef-SleePy commented on issue #8985: [FLINK-13101][datastream] Introduce blockingAfterChainingOff property of StreamGraph

2019-07-04 Thread GitBox
ifndef-SleePy commented on issue #8985: [FLINK-13101][datastream] Introduce blockingAfterChainingOff property of StreamGraph URL: https://github.com/apache/flink/pull/8985#issuecomment-508617867 @flinkbot attention @aljoscha

[GitHub] [flink] godfreyhe commented on issue #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner

2019-07-04 Thread GitBox
godfreyhe commented on issue #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner URL: https://github.com/apache/flink/pull/8898#issuecomment-508619707 LGTM, +1 to merge This is an

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300534318 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-04 Thread GitBox
sunjincheng121 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300521543 ## File path:

[GitHub] [flink] banmoy commented on issue #8611: [FLINK-12693][state] Store state per key-group in CopyOnWriteStateTable

2019-07-04 Thread GitBox
banmoy commented on issue #8611: [FLINK-12693][state] Store state per key-group in CopyOnWriteStateTable URL: https://github.com/apache/flink/pull/8611#issuecomment-508605512 The CI failed with checkstyle errors which seems irrelevant to this PR. I'm looking for the reason.

[GitHub] [flink] wuchong commented on issue #8923: [FLINK-13026][jdbc] Introduce JDBCLookupFunction

2019-07-04 Thread GitBox
wuchong commented on issue #8923: [FLINK-13026][jdbc] Introduce JDBCLookupFunction URL: https://github.com/apache/flink/pull/8923#issuecomment-508605514 Hi @JingsongLi , #8867 is merged, you can rebase this commit on that.

[GitHub] [flink] guoweiM commented on a change in pull request #8985: [FLINK-13101][datastream] Introduce blockingAfterChainingOff property of StreamGraph

2019-07-04 Thread GitBox
guoweiM commented on a change in pull request #8985: [FLINK-13101][datastream] Introduce blockingAfterChainingOff property of StreamGraph URL: https://github.com/apache/flink/pull/8985#discussion_r300521769 ## File path:

[GitHub] [flink] guoweiM commented on a change in pull request #8985: [FLINK-13101][datastream] Introduce blockingAfterChainingOff property of StreamGraph

2019-07-04 Thread GitBox
guoweiM commented on a change in pull request #8985: [FLINK-13101][datastream] Introduce blockingAfterChainingOff property of StreamGraph URL: https://github.com/apache/flink/pull/8985#discussion_r300523166 ## File path:

[GitHub] [flink] TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-04 Thread GitBox
TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300525954 ## File path:

[GitHub] [flink] TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-04 Thread GitBox
TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300532471 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner URL: https://github.com/apache/flink/pull/8898#discussion_r300532548 ## File path:

[GitHub] [flink] TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-04 Thread GitBox
TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300528464 ## File path:

[jira] [Updated] (FLINK-13107) Port TableApi IT and UT

2019-07-04 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13107: --- Component/s: (was: Table SQL / Planner) Table SQL / API > Port TableApi IT and

[jira] [Commented] (FLINK-12619) Support TERMINATE/SUSPEND Job with Checkpoint

2019-07-04 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878957#comment-16878957 ] Congxian Qiu(klion26) commented on FLINK-12619: --- There is a discussion about this on the

[jira] [Created] (FLINK-13104) Flink Datadog metrics client callback does not check for errors on posting and fails silently

2019-07-04 Thread Mans Singh (JIRA)
Mans Singh created FLINK-13104: -- Summary: Flink Datadog metrics client callback does not check for errors on posting and fails silently Key: FLINK-13104 URL: https://issues.apache.org/jira/browse/FLINK-13104

[GitHub] [flink] KurtYoung merged pull request #8689: [FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString

2019-07-04 Thread GitBox
KurtYoung merged pull request #8689: [FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString URL: https://github.com/apache/flink/pull/8689 This is an automated message from the Apache Git Service. To respond

[jira] [Closed] (FLINK-12802) Cleanup some interfaces of BinaryString

2019-07-04 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12802. -- Resolution: Fixed Fix Version/s: 1.9.0 merged in 1.9.0:

[jira] [Updated] (FLINK-12802) Cleanup some interfaces of BinaryString

2019-07-04 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-12802: --- Summary: Cleanup some interfaces of BinaryString (was: Optimizing DataFormat Code to Blink) >

[GitHub] [flink] godfreyhe commented on a change in pull request #8980: [FLINK-13040] promote blink table config

2019-07-04 Thread GitBox
godfreyhe commented on a change in pull request #8980: [FLINK-13040] promote blink table config URL: https://github.com/apache/flink/pull/8980#discussion_r300522345 ## File path:

[GitHub] [flink] lirui-apache commented on issue #8965: [FLINK-13068][hive] HiveTableSink should implement PartitionableTable…

2019-07-04 Thread GitBox
lirui-apache commented on issue #8965: [FLINK-13068][hive] HiveTableSink should implement PartitionableTable… URL: https://github.com/apache/flink/pull/8965#issuecomment-508609323 The CI failure is due to flink-table-planner-blink failed checkstyle and thus not related to this PR.

[GitHub] [flink] godfreyhe commented on a change in pull request #8980: [FLINK-13040] promote blink table config

2019-07-04 Thread GitBox
godfreyhe commented on a change in pull request #8980: [FLINK-13040] promote blink table config URL: https://github.com/apache/flink/pull/8980#discussion_r300521651 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #8980: [FLINK-13040] promote blink table config

2019-07-04 Thread GitBox
godfreyhe commented on a change in pull request #8980: [FLINK-13040] promote blink table config URL: https://github.com/apache/flink/pull/8980#discussion_r300522590 ## File path:

[GitHub] [flink] lirui-apache commented on issue #8987: [FLINK-13090][hive] Test Hive connector with hive runner

2019-07-04 Thread GitBox
lirui-apache commented on issue #8987: [FLINK-13090][hive] Test Hive connector with hive runner URL: https://github.com/apache/flink/pull/8987#issuecomment-508609720 @xuefuz I don't think we need to worry about licenses because all the newly introduced deps are in test scope and only

[GitHub] [flink] sunjincheng121 opened a new pull request #8992: [FLINK-12723][docs] setup IDE for Python

2019-07-04 Thread GitBox
sunjincheng121 opened a new pull request #8992: [FLINK-12723][docs] setup IDE for Python URL: https://github.com/apache/flink/pull/8992 ## What is the purpose of the change *This PR only add the docs for set IDE for Python.* ## Brief change log *(for example:)* - *Add

[jira] [Updated] (FLINK-12723) Adds a wiki page about setting up a Python Table API development environment

2019-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12723: --- Labels: pull-request-available (was: ) > Adds a wiki page about setting up a Python Table

[GitHub] [flink] flinkbot commented on issue #8992: [FLINK-12723][docs] setup IDE for Python

2019-07-04 Thread GitBox
flinkbot commented on issue #8992: [FLINK-12723][docs] setup IDE for Python URL: https://github.com/apache/flink/pull/8992#issuecomment-508614947 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will

[jira] [Commented] (FLINK-11605) Translate the "Dataflow Programming Model" page into Chinese

2019-07-04 Thread xueyu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878948#comment-16878948 ] xueyu commented on FLINK-11605: --- Hi, [~jark], I was busy recently and un-asssinged, thanks ~ > Translate

[GitHub] [flink] JingsongLi commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8898: [FLINK-12936][table-planner-blink] Support intersect all / minus all to blink planner URL: https://github.com/apache/flink/pull/8898#discussion_r300531061 ## File path:

[jira] [Assigned] (FLINK-11605) Translate the "Dataflow Programming Model" page into Chinese

2019-07-04 Thread xueyu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xueyu reassigned FLINK-11605: - Assignee: (was: xueyu) > Translate the "Dataflow Programming Model" page into Chinese >

[jira] [Commented] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-04 Thread Yun Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878958#comment-16878958 ] Yun Gao commented on FLINK-12852: - Hi [~aitozi], very thanks for concerning this issue. In my opinion,

[GitHub] [flink] mans2singh opened a new pull request #8990: [FLINK-13104][metrics] Updated request callback to log warning on failure

2019-07-04 Thread GitBox
mans2singh opened a new pull request #8990: [FLINK-13104][metrics] Updated request callback to log warning on failure URL: https://github.com/apache/flink/pull/8990 ## Contribution Checklist ## What is the purpose of the change * Log warning in case posting metrics to

[jira] [Updated] (FLINK-13104) Flink Datadog metrics client callback does not check for errors on posting and fails silently

2019-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13104: --- Labels: datadog metrics pull-request-available (was: datadog metrics) > Flink Datadog

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-04 Thread GitBox
sunjincheng121 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300520608 ## File path:

[GitHub] [flink] q977734161 closed pull request #8991: Merge pull request #1 from apache/master

2019-07-04 Thread GitBox
q977734161 closed pull request #8991: Merge pull request #1 from apache/master URL: https://github.com/apache/flink/pull/8991 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations.

2019-07-04 Thread GitBox
sunjincheng121 commented on a change in pull request #8977: [FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner support add kinds of QueryOperations. URL: https://github.com/apache/flink/pull/8977#discussion_r300520544 ## File path:

[GitHub] [flink] flinkbot commented on issue #8991: Merge pull request #1 from apache/master

2019-07-04 Thread GitBox
flinkbot commented on issue #8991: Merge pull request #1 from apache/master URL: https://github.com/apache/flink/pull/8991#issuecomment-508604553 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will

[GitHub] [flink] q977734161 opened a new pull request #8991: Merge pull request #1 from apache/master

2019-07-04 Thread GitBox
q977734161 opened a new pull request #8991: Merge pull request #1 from apache/master URL: https://github.com/apache/flink/pull/8991 update ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather

[GitHub] [flink] sunjincheng121 commented on issue #8979: [FLINK-13087][table] Add group window Aggregate operator to Table API

2019-07-04 Thread GitBox
sunjincheng121 commented on issue #8979: [FLINK-13087][table] Add group window Aggregate operator to Table API URL: https://github.com/apache/flink/pull/8979#issuecomment-508606954 The CI error fixed in #8689 Thanks @JingsongLi

[GitHub] [flink] dianfu commented on issue #8956: [FLINK-12991][python] Correct the implementation of Catalog.get_table_factory

2019-07-04 Thread GitBox
dianfu commented on issue #8956: [FLINK-12991][python] Correct the implementation of Catalog.get_table_factory URL: https://github.com/apache/flink/pull/8956#issuecomment-508610372 @bowenli86 Any feedback? We need to fix this issue in 1.9 and the 1.9 release branch will be cut latter

[GitHub] [flink] lirui-apache commented on issue #8889: [FLINK-12934][hive] add hadoop dependencies as 'flink-shaded-hadoop-2-uber' for flink-connector-hive to connect to remote hive metastore service

2019-07-04 Thread GitBox
lirui-apache commented on issue #8889: [FLINK-12934][hive] add hadoop dependencies as 'flink-shaded-hadoop-2-uber' for flink-connector-hive to connect to remote hive metastore service URL: https://github.com/apache/flink/pull/8889#issuecomment-508613237 Do we know what's inside the shaded

[jira] [Commented] (FLINK-11605) Translate the "Dataflow Programming Model" page into Chinese

2019-07-04 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878938#comment-16878938 ] Jark Wu commented on FLINK-11605: - Hi [~xueyu], do you still have time to work on this ? > Translate

[GitHub] [flink] yanghua commented on issue #7122: [FLINK-10908][flink-yarn]Add yarn.application.priority in YarnConfigOptions

2019-07-04 Thread GitBox
yanghua commented on issue #7122: [FLINK-10908][flink-yarn]Add yarn.application.priority in YarnConfigOptions URL: https://github.com/apache/flink/pull/7122#issuecomment-508618600 I will have another look soon. Basically, you should add the doc for the config option you provided like

[GitHub] [flink] danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-04 Thread GitBox
danny0405 commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r300519348 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300534100 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-07-04 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300534132 ## File path:

  1   2   3   4   5   >