[GitHub] [flink] dianfu commented on issue #9874: [FLINK-14240][table] Merge table config parameters(TableConfig#getConfiguration) into global job parameters(ExecutionConfig#getGlobalJobParameters) wh

2019-10-11 Thread GitBox
dianfu commented on issue #9874: [FLINK-14240][table] Merge table config parameters(TableConfig#getConfiguration) into global job parameters(ExecutionConfig#getGlobalJobParameters) when running with the legacy planner. URL: https://github.com/apache/flink/pull/9874#issuecomment-541005754

[GitHub] [flink] flinkbot edited a comment on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect URL: https://github.com/apache/flink/pull/9866#issuecomment-539968272 ## CI report: * 372923b25d5fa8376fc40b18e2bf024

[GitHub] [flink] flinkbot edited a comment on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure URL: https://github.com/apache/flink/pull/9879#issuecomment-540569165 ## CI report: * d16648043176579cbc934051984f

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-11 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949350#comment-16949350 ] Jiayi Liao commented on FLINK-14296: [~jark] Sure. I'll update the PR very soon. >

[jira] [Commented] (FLINK-14264) Expose CheckpointBackend in checkpoint config RestAPI

2019-10-11 Thread Congxian Qiu(klion26) (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949354#comment-16949354 ] Congxian Qiu(klion26) commented on FLINK-14264: --- [~aljoscha] what do you t

[jira] [Comment Edited] (FLINK-14264) Expose CheckpointBackend in checkpoint config RestAPI

2019-10-11 Thread Congxian Qiu(klion26) (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949354#comment-16949354 ] Congxian Qiu(klion26) edited comment on FLINK-14264 at 10/11/19 10:35 AM:

[GitHub] [flink] flinkbot edited a comment on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect URL: https://github.com/apache/flink/pull/9866#issuecomment-539968272 ## CI report: * 372923b25d5fa8376fc40b18e2bf024

[GitHub] [flink] zhijiangW commented on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure

2019-10-11 Thread GitBox
zhijiangW commented on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure URL: https://github.com/apache/flink/pull/9879#issuecomment-541015897 Thanks for the updates @pnowojski . > But it is positi

[GitHub] [flink] flinkbot edited a comment on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure URL: https://github.com/apache/flink/pull/9879#issuecomment-540569165 ## CI report: * d16648043176579cbc934051984f

[GitHub] [flink] JingsongLi commented on issue #9796: [FLINK-14253][table-planner-blink] Add hash distribution and sort grouping only when dynamic partition insert

2019-10-11 Thread GitBox
JingsongLi commented on issue #9796: [FLINK-14253][table-planner-blink] Add hash distribution and sort grouping only when dynamic partition insert URL: https://github.com/apache/flink/pull/9796#issuecomment-541021987 > Before this can actually merged, I would raise another issue i have just

[GitHub] [flink] f7753 commented on a change in pull request #9805: [FLINK-11635][docs-zh] translate dev/stream/state/checkpointing into Chinese

2019-10-11 Thread GitBox
f7753 commented on a change in pull request #9805: [FLINK-11635][docs-zh] translate dev/stream/state/checkpointing into Chinese URL: https://github.com/apache/flink/pull/9805#discussion_r333872758 ## File path: docs/dev/stream/state/checkpointing.zh.md ## @@ -25,146 +25,13

[GitHub] [flink] f7753 commented on a change in pull request #9805: [FLINK-11635][docs-zh] translate dev/stream/state/checkpointing into Chinese

2019-10-11 Thread GitBox
f7753 commented on a change in pull request #9805: [FLINK-11635][docs-zh] translate dev/stream/state/checkpointing into Chinese URL: https://github.com/apache/flink/pull/9805#discussion_r333874005 ## File path: docs/dev/stream/state/checkpointing.zh.md ## @@ -25,146 +25,13

[GitHub] [flink] f7753 commented on a change in pull request #9805: [FLINK-11635][docs-zh] translate dev/stream/state/checkpointing into Chinese

2019-10-11 Thread GitBox
f7753 commented on a change in pull request #9805: [FLINK-11635][docs-zh] translate dev/stream/state/checkpointing into Chinese URL: https://github.com/apache/flink/pull/9805#discussion_r333873466 ## File path: docs/dev/stream/state/checkpointing.zh.md ## @@ -25,146 +25,13

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r333943320 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/MLEnvironmentFa

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r333943412 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/operator/AlgoOperator.

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r333943637 ## File path: flink-ml-parent/flink-ml-lib/src/test/java/org/apache/flink/ml/common/MLEnvironmentTe

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r333943568 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/operator/stream/Stream

[jira] [Commented] (FLINK-14266) Introduce RowCsvInputFormat to new CSV module

2019-10-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949378#comment-16949378 ] Jingsong Lee commented on FLINK-14266: -- Thanks [~fhueske] , I think there are two c

[GitHub] [flink] tony810430 commented on issue #9824: [FLINK-14302] FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if `newPartitionsInTransaction` is empty when enable EoS

2019-10-11 Thread GitBox
tony810430 commented on issue #9824: [FLINK-14302] FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if `newPartitionsInTransaction` is empty when enable EoS URL: https://github.com/apache/flink/pull/9824#issuecomment-541024857 hi @becketqin Thank you for your

[GitHub] [flink] tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-11 Thread GitBox
tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r333945019 ## File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java #

[GitHub] [flink] tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-11 Thread GitBox
tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r333945062 ## File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java #

[GitHub] [flink] tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-11 Thread GitBox
tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r333945440 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutor

[jira] [Commented] (FLINK-14344) Snapshot master hook state asynchronously

2019-10-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949379#comment-16949379 ] Piotr Nowojski commented on FLINK-14344: {{MasterTriggerRestoreHook}} is not mar

[GitHub] [flink] tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-11 Thread GitBox
tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r333945358 ## File path: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r333945523 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/MLEnvironment.j

[jira] [Comment Edited] (FLINK-14266) Introduce RowCsvInputFormat to new CSV module

2019-10-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949378#comment-16949378 ] Jingsong Lee edited comment on FLINK-14266 at 10/11/19 11:27 AM: -

[GitHub] [flink] flinkbot edited a comment on issue #9824: [FLINK-14302] FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if `newPartitionsInTransaction` is empty when enable

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9824: [FLINK-14302] FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if `newPartitionsInTransaction` is empty when enable EoS URL: https://github.com/apache/flink/pull/9824#issuecomment-536928428 ## CI report: * 87ae7

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333942042 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333942409 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333946541 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r333946954 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/MLEnvironmentFa

[GitHub] [flink] flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-539472188 ## CI report: * b10f5603fc55999adb8d5334a3d142d20322de5b : SUCCESS [Build](https://travis-ci.co

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333947428 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiong

[GitHub] [flink] flinkbot edited a comment on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect URL: https://github.com/apache/flink/pull/9866#issuecomment-539968272 ## CI report: * 372923b25d5fa8376fc40b18e2bf024

[GitHub] [flink] flinkbot edited a comment on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure URL: https://github.com/apache/flink/pull/9879#issuecomment-540569165 ## CI report: * d16648043176579cbc934051984f

[GitHub] [flink] wuchong commented on a change in pull request #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect

2019-10-11 Thread GitBox
wuchong commented on a change in pull request #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect URL: https://github.com/apache/flink/pull/9866#discussion_r333948238 ## File path: docs/dev/table/connect.md

[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-513425405 ## CI report: * bd7ade5e0b57dc8577d7f864afcbbb24c2513e56 : FAILURE [Build](https://travis-ci.com/flink-ci/fli

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r333949183 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/pipeline/TransformerBa

[GitHub] [flink] wuchong commented on a change in pull request #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect

2019-10-11 Thread GitBox
wuchong commented on a change in pull request #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect URL: https://github.com/apache/flink/pull/9866#discussion_r333949211 ## File path: flink-connectors/flink-hb

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r333949732 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/pipeline/EstimatorBase

[GitHub] [flink] xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-541029806 > @xuyang1706 Thanks for updating the patch. I left a few more comments. Most of them are minor. One major thing is I am not

[GitHub] [flink] flinkbot edited a comment on issue #9824: [FLINK-14302] FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if `newPartitionsInTransaction` is empty when enable

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9824: [FLINK-14302] FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if `newPartitionsInTransaction` is empty when enable EoS URL: https://github.com/apache/flink/pull/9824#issuecomment-536928428 ## CI report: * 87ae7

[GitHub] [flink] flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-539472188 ## CI report: * b10f5603fc55999adb8d5334a3d142d20322de5b : SUCCESS [Build](https://travis-ci.co

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333954563 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/sched

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333954929 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/sched

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333956291 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/sched

[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-513425405 ## CI report: * bd7ade5e0b57dc8577d7f864afcbbb24c2513e56 : FAILURE [Build](https://travis-ci.com/flink-ci/fli

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333948497 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333949189 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333960253 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/execu

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333960488 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/sched

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333961395 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/sched

[GitHub] [flink] flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-539472188 ## CI report: * b10f5603fc55999adb8d5334a3d142d20322de5b : SUCCESS [Build](https://travis-ci.co

[jira] [Created] (FLINK-14376) Introduce the Executor abstraction (FLIP-73)

2019-10-11 Thread Kostas Kloudas (Jira)
Kostas Kloudas created FLINK-14376: -- Summary: Introduce the Executor abstraction (FLIP-73) Key: FLINK-14376 URL: https://issues.apache.org/jira/browse/FLINK-14376 Project: Flink Issue Type:

[jira] [Updated] (FLINK-14376) Introduce the Executor abstraction (FLIP-73)

2019-10-11 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-14376: --- Description: This is the umbrella issue to track the progress of the implementation of  [FLI

[GitHub] [flink] aljoscha commented on issue #9820: [FLINK-14290] Decouple plan translation from job execution/ClusterClient

2019-10-11 Thread GitBox
aljoscha commented on issue #9820: [FLINK-14290] Decouple plan translation from job execution/ClusterClient URL: https://github.com/apache/flink/pull/9820#issuecomment-541044613 I took a bit longer but I think I managed to do it. Also makes the code quite a bit simpler. ☕️ --

[GitHub] [flink] pnowojski commented on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure

2019-10-11 Thread GitBox
pnowojski commented on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure URL: https://github.com/apache/flink/pull/9879#issuecomment-541046772 Thanks for the review @zhijiangW. Travis is green, merging...

[GitHub] [flink] pnowojski merged pull request #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure

2019-10-11 Thread GitBox
pnowojski merged pull request #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure URL: https://github.com/apache/flink/pull/9879 This is an autom

[jira] [Created] (FLINK-14377) Translate ProgramOptions relevant for job execution to ConfigOptions.

2019-10-11 Thread Kostas Kloudas (Jira)
Kostas Kloudas created FLINK-14377: -- Summary: Translate ProgramOptions relevant for job execution to ConfigOptions. Key: FLINK-14377 URL: https://issues.apache.org/jira/browse/FLINK-14377 Project: Fl

[jira] [Assigned] (FLINK-14377) Translate ProgramOptions relevant for job execution to ConfigOptions.

2019-10-11 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reassigned FLINK-14377: -- Assignee: Kostas Kloudas > Translate ProgramOptions relevant for job execution to Con

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333971888 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/sched

[GitHub] [flink] flinkbot edited a comment on issue #9820: [FLINK-14290] Decouple plan translation from job execution/ClusterClient

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9820: [FLINK-14290] Decouple plan translation from job execution/ClusterClient URL: https://github.com/apache/flink/pull/9820#issuecomment-536452582 ## CI report: * ff3ef7ae21616fb0295e3bdc53fa349c8f136a4b : FAILURE [Build](https://travis-ci.c

[GitHub] [flink] flinkbot edited a comment on issue #9824: [FLINK-14302] FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if `newPartitionsInTransaction` is empty when enable

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9824: [FLINK-14302] FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if `newPartitionsInTransaction` is empty when enable EoS URL: https://github.com/apache/flink/pull/9824#issuecomment-536928428 ## CI report: * 87ae7

[GitHub] [flink] flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#issuecomment-539900648 ## CI report: * 80c100513c089a9dd0930aa547383ae970c4e7f8 : FAILURE [Build](https

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333976919 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/

[jira] [Commented] (FLINK-14357) Request for the ability to move checkpoints/savepoints

2019-10-11 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949418#comment-16949418 ] Aljoscha Krettek commented on FLINK-14357: -- This is a very valid with! There al

[jira] [Closed] (FLINK-14357) Request for the ability to move checkpoints/savepoints

2019-10-11 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-14357. Resolution: Duplicate > Request for the ability to move checkpoints/savepoints > -

[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-513425405 ## CI report: * bd7ade5e0b57dc8577d7f864afcbbb24c2513e56 : FAILURE [Build](https://travis-ci.com/flink-ci/fli

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333976919 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/

[jira] [Updated] (FLINK-14354) Provide interfaces instead of abstract classes in org.apache.flink.state.api.functions

2019-10-11 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-14354: - Component/s: API / State Processor > Provide interfaces instead of abstract classes in

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333976919 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/

[jira] [Updated] (FLINK-14355) Example code in state processor API docs doesn't compile

2019-10-11 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-14355: - Component/s: API / State Processor > Example code in state processor API docs doesn't co

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333976919 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333976919 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333976919 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/

[GitHub] [flink] GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r333981786 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/

[GitHub] [flink] flinkbot edited a comment on issue #9820: [FLINK-14290] Decouple plan translation from job execution/ClusterClient

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9820: [FLINK-14290] Decouple plan translation from job execution/ClusterClient URL: https://github.com/apache/flink/pull/9820#issuecomment-536452582 ## CI report: * ff3ef7ae21616fb0295e3bdc53fa349c8f136a4b : FAILURE [Build](https://travis-ci.c

[GitHub] [flink] flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#issuecomment-539900648 ## CI report: * 80c100513c089a9dd0930aa547383ae970c4e7f8 : FAILURE [Build](https

[GitHub] [flink] GJL commented on issue #9872: [FLINK-14291][runtime, tests] Add test coverage to DefaultScheduler

2019-10-11 Thread GitBox
GJL commented on issue #9872: [FLINK-14291][runtime,tests] Add test coverage to DefaultScheduler URL: https://github.com/apache/flink/pull/9872#issuecomment-541062993 Merging as soon as build is green. This is an automated me

[GitHub] [flink] kl0u commented on issue #9881: [FLINK-14377] Parse Executor-relevant ProgramOptions to ConfigOptions

2019-10-11 Thread GitBox
kl0u commented on issue #9881: [FLINK-14377] Parse Executor-relevant ProgramOptions to ConfigOptions URL: https://github.com/apache/flink/pull/9881#issuecomment-541063272 Please review @aljoscha and @TisonKun This is an auto

[GitHub] [flink] kl0u opened a new pull request #9881: [FLINK-14377] Parse Executor-relevant ProgramOptions to ConfigOptions

2019-10-11 Thread GitBox
kl0u opened a new pull request #9881: [FLINK-14377] Parse Executor-relevant ProgramOptions to ConfigOptions URL: https://github.com/apache/flink/pull/9881 ## What is the purpose of the change This is part of the [FLIP-73](https://cwiki.apache.org/confluence/display/FLINK/FLIP-73%3A+

[jira] [Updated] (FLINK-14377) Translate ProgramOptions relevant for job execution to ConfigOptions.

2019-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14377: --- Labels: pull-request-available (was: ) > Translate ProgramOptions relevant for job executio

[jira] [Commented] (FLINK-14360) Flink on yarn should support obtain delegation tokens of multi hdfs namespaces

2019-10-11 Thread Andrey Zagrebin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949446#comment-16949446 ] Andrey Zagrebin commented on FLINK-14360: - [~shenyinjie] Could you explain a bit

[jira] [Assigned] (FLINK-14365) Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-11 Thread Gary Yao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-14365: Assignee: Zhu Zhu > Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG >

[jira] [Assigned] (FLINK-14366) Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG

2019-10-11 Thread Gary Yao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-14366: Assignee: Zhu Zhu > Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG > -

[GitHub] [flink] flinkbot commented on issue #9881: [FLINK-14377] Parse Executor-relevant ProgramOptions to ConfigOptions

2019-10-11 Thread GitBox
flinkbot commented on issue #9881: [FLINK-14377] Parse Executor-relevant ProgramOptions to ConfigOptions URL: https://github.com/apache/flink/pull/9881#issuecomment-541064418 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revie

[jira] [Assigned] (FLINK-14363) No need to cancel vertex when its version is outdated in scheduling (SchedulerNG)

2019-10-11 Thread Gary Yao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-14363: Assignee: Zhu Zhu > No need to cancel vertex when its version is outdated in scheduling > (Sched

[GitHub] [flink] flinkbot edited a comment on issue #9820: [FLINK-14290] Decouple plan translation from job execution/ClusterClient

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9820: [FLINK-14290] Decouple plan translation from job execution/ClusterClient URL: https://github.com/apache/flink/pull/9820#issuecomment-536452582 ## CI report: * ff3ef7ae21616fb0295e3bdc53fa349c8f136a4b : FAILURE [Build](https://travis-ci.c

[GitHub] [flink] flinkbot edited a comment on issue #9872: [FLINK-14291][runtime, tests] Add test coverage to DefaultScheduler

2019-10-11 Thread GitBox
flinkbot edited a comment on issue #9872: [FLINK-14291][runtime,tests] Add test coverage to DefaultScheduler URL: https://github.com/apache/flink/pull/9872#issuecomment-540007360 ## CI report: * 371827eb6bdb0d8e0cf626acb580b0b6b7eafbd3 : FAILURE [Build](https://travis-ci.com/fli

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r334000386 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/execu

[GitHub] [flink] flinkbot commented on issue #9881: [FLINK-14377] Parse Executor-relevant ProgramOptions to ConfigOptions

2019-10-11 Thread GitBox
flinkbot commented on issue #9881: [FLINK-14377] Parse Executor-relevant ProgramOptions to ConfigOptions URL: https://github.com/apache/flink/pull/9881#issuecomment-541072480 ## CI report: * 03fb6e64db35f290c9a1d5552aa34dfe5ccf9cd8 : UNKNOWN Bot commands The @flin

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r334000282 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/sched

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r334000205 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/sched

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r334000513 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/sched

[GitHub] [flink] zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-11 Thread GitBox
zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states URL: https://github.com/apache/flink/pull/9860#discussion_r334000666 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/sched

[GitHub] [flink] tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-11 Thread GitBox
tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r333995702 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutor

[GitHub] [flink] tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-11 Thread GitBox
tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r333995458 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutor

[GitHub] [flink] tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-11 Thread GitBox
tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r334001380 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/TaskExecutor

[GitHub] [flink] tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-11 Thread GitBox
tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r333995806 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutor

[GitHub] [flink] tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-11 Thread GitBox
tillrohrmann commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r334004815 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/TaskExecutor

<    1   2   3   4   5   >