[GitHub] [flink] flinkbot edited a comment on issue #9751: [FLINK-14177] bump curator from 2.12.0 to 4.2.0
flinkbot edited a comment on issue #9751: [FLINK-14177] bump curator from 2.12.0 to 4.2.0 URL: https://github.com/apache/flink/pull/9751#issuecomment-534387866 ## CI report: * 5b73b3d6319447fd2d81b48183d9f22012133a6b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128853990) * 9e0f8dbc4abc0caa82a66dd4b250d2716debb709 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128866590) * 47fc6a0206ce150cc62d5038a288e1534db0f79b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128877814) * 5ca23fc651a91a0f1e097eed533d8804c2ec9235 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128971343) * 36e98a73fd1c05a9e74e71944b96b834a1f86894 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/129028758) * 3647aded3965fffbfe9711934d5393e4937e474c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/129048588) * e60f8e7674e9b344b4727bdca36fd35114b2df13 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10235: [FLINK-14839][config] Let JobGraph#classpaths become non-null
TisonKun commented on a change in pull request #10235: [FLINK-14839][config]
Let JobGraph#classpaths become non-null
URL: https://github.com/apache/flink/pull/10235#discussion_r349414138
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java
##
@@ -352,8 +353,8 @@ public JobVertex findVertexByID(JobVertexID id) {
*
* @param paths paths of the directories/JAR files required to run the
job on a task manager
*/
- public void setClasspaths(List paths) {
- classpaths = paths;
+ public void addClasspaths(Collection paths) {
+ classpaths.addAll(paths);
}
public List getClasspaths() {
Review comment:
Make sense to return an unmodifiableList
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10235: [FLINK-14839][config] Let JobGraph#classpaths become non-null
TisonKun commented on a change in pull request #10235: [FLINK-14839][config]
Let JobGraph#classpaths become non-null
URL: https://github.com/apache/flink/pull/10235#discussion_r349414021
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java
##
@@ -352,8 +353,8 @@ public JobVertex findVertexByID(JobVertexID id) {
*
* @param paths paths of the directories/JAR files required to run the
job on a task manager
*/
- public void setClasspaths(List paths) {
- classpaths = paths;
+ public void addClasspaths(Collection paths) {
Review comment:
So for `addJars`. We don't call `addJars` multiple times for now. However,
it fits the abstraction that we firstly instance an empty collection and then
add member per call. If we still using setter and with a null checker the field
cannot be `final` while we don't gain a lot from such mutability.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner
godfreyhe commented on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner URL: https://github.com/apache/flink/pull/9433#issuecomment-557363664 thanks for all guys' help! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] hequn8128 commented on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner
hequn8128 commented on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner URL: https://github.com/apache/flink/pull/9433#issuecomment-557362941 LGTM. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10232: [FLINK-14314][runtime] Allocate shared slot resources respecting the resources of all vertices in the group
flinkbot edited a comment on issue #10232: [FLINK-14314][runtime] Allocate shared slot resources respecting the resources of all vertices in the group URL: https://github.com/apache/flink/pull/10232#issuecomment-554775330 ## CI report: * b62006e7cf875fa318b3ce57afb14b0b2679bcb5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136890375) * 9ae7a0477e0474da96b2add1edf857c13888c4a7 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136933316) * 4225953861e2cbab26bfa2f0b9eb3a1582dffbe2 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136957958) * f2ad62934200bd550b479825ff224ffc227f0984 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137401146) * 23ac452994a9d3e376a8408f97947e42291be653 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137407224) * 582081d26a06f1ce7abc04317f489cf6b1c0f21f : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137511360) * 8d05aa877150f0b4ec0d61eca1907e24c808b93c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137553786) * c7f2649002f8c290df78f45b8c83ebc2a7507ce6 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/137697834) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10251: [FLINK-14851][FLINK-14850] Implement Executors and wire them to the ContextEnvironment
TisonKun commented on a change in pull request #10251:
[FLINK-14851][FLINK-14850] Implement Executors and wire them to the
ContextEnvironment
URL: https://github.com/apache/flink/pull/10251#discussion_r349411838
##
File path:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java
##
@@ -144,17 +144,16 @@ protected ExecutionEnvironment() {
}
protected ExecutionEnvironment(final Configuration configuration) {
- this(DefaultExecutorServiceLoader.INSTANCE, configuration);
+ this(DefaultExecutorServiceLoader.INSTANCE, configuration,
null);
Review comment:
Is it possible we get the same classloader in another way?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10251: [FLINK-14851][FLINK-14850] Implement Executors and wire them to the ContextEnvironment
TisonKun commented on a change in pull request #10251:
[FLINK-14851][FLINK-14850] Implement Executors and wire them to the
ContextEnvironment
URL: https://github.com/apache/flink/pull/10251#discussion_r349411838
##
File path:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java
##
@@ -144,17 +144,16 @@ protected ExecutionEnvironment() {
}
protected ExecutionEnvironment(final Configuration configuration) {
- this(DefaultExecutorServiceLoader.INSTANCE, configuration);
+ this(DefaultExecutorServiceLoader.INSTANCE, configuration,
null);
Review comment:
Is it possibly we get the same classloader in another way?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10251: [FLINK-14851][FLINK-14850] Implement Executors and wire them to the ContextEnvironment
TisonKun commented on a change in pull request #10251:
[FLINK-14851][FLINK-14850] Implement Executors and wire them to the
ContextEnvironment
URL: https://github.com/apache/flink/pull/10251#discussion_r349411565
##
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/ExecutorUtils.java
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.client.deployment;
+
+import org.apache.flink.api.dag.Pipeline;
+import org.apache.flink.client.FlinkPipelineTranslationUtil;
+import org.apache.flink.client.cli.ExecutionConfigAccessor;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+
+import javax.annotation.Nonnull;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * Utility class with method related to job execution.
+ */
+public class ExecutorUtils {
+
+ /**
+* Creates the {@link JobGraph} corresponding to the provided {@link
Pipeline}.
+*
+* @param pipeline the pipeline whose job graph we are computing
+* @param configuration the configuration with the necessary
information such as jars and
+* classpaths to be included, the parallelism
of the job and potential
+* savepoint settings used to bootstrap its
state.
+* @return the corresponding {@link JobGraph}.
+*/
+ public static JobGraph getJobGraph(@Nonnull final Pipeline pipeline,
@Nonnull final Configuration configuration) {
Review comment:
Now I'd like to defer such changes until we possibly move JobGraph to
flink-core as some of our users ask for "stable" job representation. Anyway, it
would be another story.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10251: [FLINK-14851][FLINK-14850] Implement Executors and wire them to the ContextEnvironment
TisonKun commented on a change in pull request #10251:
[FLINK-14851][FLINK-14850] Implement Executors and wire them to the
ContextEnvironment
URL: https://github.com/apache/flink/pull/10251#discussion_r349411388
##
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/ExecutorUtils.java
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.client.deployment;
+
+import org.apache.flink.api.dag.Pipeline;
+import org.apache.flink.client.FlinkPipelineTranslationUtil;
+import org.apache.flink.client.cli.ExecutionConfigAccessor;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+
+import javax.annotation.Nonnull;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * Utility class with method related to job execution.
+ */
+public class ExecutorUtils {
+
+ /**
+* Creates the {@link JobGraph} corresponding to the provided {@link
Pipeline}.
+*
+* @param pipeline the pipeline whose job graph we are computing
+* @param configuration the configuration with the necessary
information such as jars and
+* classpaths to be included, the parallelism
of the job and potential
+* savepoint settings used to bootstrap its
state.
+* @return the corresponding {@link JobGraph}.
+*/
+ public static JobGraph getJobGraph(@Nonnull final Pipeline pipeline,
@Nonnull final Configuration configuration) {
Review comment:
Yes, I agree it requires more effort especially on dependency issue.
Currently `JobGraph` stays in `flink-runtime` while the classes to be compiled
to it stay in multiple modules may or may not depend on `flink-runtime`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zjuwangg commented on issue #10272: [FLINK-14878]Support `use catalog` through sqlUpdate() method in TableEnvironment
zjuwangg commented on issue #10272: [FLINK-14878]Support `use catalog` through sqlUpdate() method in TableEnvironment URL: https://github.com/apache/flink/pull/10272#issuecomment-557361387 > sorry for the late comment, but I happened to notice that UseCatalogOperation and UseOperation reside in package `/table/operations/ddl/`. Since they are not ddl, should they be relocated to `/table/operations/`? Make sense, addressed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
flinkbot edited a comment on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission URL: https://github.com/apache/flink/pull/10193#issuecomment-553881527 ## CI report: * e3ac83fe02a7583159184772ff4b4341fa65f827 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136517817) * eefbec6756be60a27698d275a1b94bef7cd0c1e2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136636043) * 19a83ead105c951505dbafb0280fa2d25132c9a0 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136645898) * dd2b911c850a56e3d6aa4a3c7e16b30431977bf5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136651764) * 06b368d9fbd88eabf71391fc1662b4d8a626d43c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137165694) * d4b77c8aab32cdeb11806fdd45ea88141051a157 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137317107) * 53b86608c1d008c53112b34c634ccf96419cd921 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137343147) * 2969fb4fb3afc8c331415c1ca478b05f3cb47b47 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137394777) * edccba4a6db80772f9494f5631e1bc6a340d6586 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/137697818) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14677) validate all tpc-ds query result with TPC Official reference answer set
[ https://issues.apache.org/jira/browse/FLINK-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-14677: --- Parent: (was: FLINK-11491) Issue Type: Task (was: Sub-task) > validate all tpc-ds query result with TPC Official reference answer set > --- > > Key: FLINK-14677 > URL: https://issues.apache.org/jira/browse/FLINK-14677 > Project: Flink > Issue Type: Task > Components: Tests >Affects Versions: 1.9.1 >Reporter: Leonard Xu >Priority: Major > Fix For: 1.10.0 > > > From my tpc-ds qualification test, some queries’s result are not match > Official reference answer set which need to address. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] TisonKun commented on a change in pull request #10251: [FLINK-14851][FLINK-14850] Implement Executors and wire them to the ContextEnvironment
TisonKun commented on a change in pull request #10251:
[FLINK-14851][FLINK-14850] Implement Executors and wire them to the
ContextEnvironment
URL: https://github.com/apache/flink/pull/10251#discussion_r349410858
##
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/AbstractJobClusterExecutor.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.client.deployment;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.dag.Pipeline;
+import org.apache.flink.client.cli.ExecutionConfigAccessor;
+import org.apache.flink.client.program.ClusterClient;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.execution.Executor;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nonnull;
+
+import java.util.concurrent.CompletableFuture;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * An abstract {@link Executor} used to execute {@link Pipeline pipelines} on
dedicated (per-job) clusters.
+ *
+ * @param the type of the id of the cluster.
+ * @param the type of the {@link ClusterClientFactory} used to
create/retrieve a client to the target cluster.
+ */
+@Internal
+public class AbstractJobClusterExecutor> implements Executor {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(AbstractJobClusterExecutor.class);
+
+ private final ClientFactory clusterClientFactory;
+
+ public AbstractJobClusterExecutor(@Nonnull final ClientFactory
clusterClientFactory) {
+ this.clusterClientFactory = checkNotNull(clusterClientFactory);
+ }
+
+ @Override
+ public CompletableFuture execute(@Nonnull final Pipeline
pipeline, @Nonnull final Configuration configuration) throws Exception {
+ final JobGraph jobGraph = ExecutorUtils.getJobGraph(pipeline,
configuration);
+
+ try (final ClusterDescriptor clusterDescriptor =
clusterClientFactory.createClusterDescriptor(configuration)) {
+ final ExecutionConfigAccessor configAccessor =
ExecutionConfigAccessor.fromConfiguration(configuration);
+
+ final ClusterSpecification clusterSpecification =
clusterClientFactory.getClusterSpecification(configuration);
+
+ final ClusterClient clusterClient =
clusterDescriptor.deployJobCluster(clusterSpecification, jobGraph,
configAccessor.getDetachedMode());
Review comment:
Yes. FYI [FLINK-14916](https://issues.apache.org/jira/browse/FLINK-14916).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (FLINK-14916) Asynchronously deploy cluster in AbstractJobClusterExecutor#execute
Zili Chen created FLINK-14916:
-
Summary: Asynchronously deploy cluster in
AbstractJobClusterExecutor#execute
Key: FLINK-14916
URL: https://issues.apache.org/jira/browse/FLINK-14916
Project: Flink
Issue Type: Sub-task
Reporter: Zili Chen
https://github.com/apache/flink/pull/10251#discussion_r348933298
since {{execute}} returns {{CompletableFuture}} we'd better run
deployment action asynchronously.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #5521: [FLINK-8599] Improve the failure behavior of the FileInputFormat for …
flinkbot edited a comment on issue #5521: [FLINK-8599] Improve the failure behavior of the FileInputFormat for … URL: https://github.com/apache/flink/pull/5521#issuecomment-547463841 ## CI report: * 498611c0cd8678dfd4f3e772826081f83260bb28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134018823) * 53a83524654e21eec69e97291b9b80273950617a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134782509) * ea1c93de4f52d348584df5f5d271c7d5ff547695 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134785613) * 05aa2f2f17963b14b623c60452ebc728438d70bb : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134790622) * 96d507befa69e1eca8e2deb4bce6a74567e5ce5b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134792795) * 21634daeb420124410ba7b320caf596b5d67aa21 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134958500) * 1c1e5a5dc15ecaa24853574b13472d1d218515ae : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135034111) * 4935b837a5d6caa4377f8d5aacd1e2f7bebf4b9a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135110562) * 0784f386c7613ea5e47cf295cd22cf5380ffa5aa : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135135040) * 18723cc4a20c372f5c86b9158eaa24522ba2a439 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135164000) * 46958e1921226508e62a90e0ef2e6ad19b245a37 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135337853) * 8e75ee5df82c7575623a40d6aa0c055e3b892a5e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136738787) * 2393ef6b619258fc58c58a141e2bd896042512e8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136773994) * 8ece2a4fa8560f0885af0d78e338ef5fb155040a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136788572) * 7403cf0643e2dff636ca412c1dd0c11b9678714c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136827979) * a4a40dadaa8b69187cc7186f17c69f7397268a53 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136842899) * 7e197d79650a22f897154228c3875fe482376629 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136848784) * 610a49b70465dc9a5b9b78b3b43ae54c025b52f2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136852712) * 41a22b8a32c8dd78f62d702a21b288ca27fd245c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136879085) * d774997071a56ac27c5e0b55d9b58ba5eba1f257 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136887799) * a99e3095a78791ca9df9e6b7c5e8930bc623640d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136896513) * a3ddf546e267a068773474586ccb8b6062b5557e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136910623) * 373f17447a2bf8cfd57b1b9e53417eeb2064b4d6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136916250) * a0156e51f9d318515c88fc21130e05a5ad9f0839 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136921447) * 17bb4e7e2a734ee07b60f3b5f30342832fd8e79c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137063047) * d37985a0bc7bddd888fb3d68e88e6ce4aaeff847 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137078284) * 709a84c824472f7ce1529dcaa595c0bacf3176dd : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137105535) * 77c9889138e84aaa7d8e2899ea8668dae3b424d8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137199766) * b955276d7bf0085812cbd9fd9e607454b607307b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137295623) * ae129a0b802f2490ccb7328b3882081a3a486638 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137310601) * 95cc078fa52d8fbfa95eb7e8d00062c0ab2b6a67 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137388823) * 31f2d1bb9b55b156b6d6abc41013d0e1e788930c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137472137) * 496f082d4826a65a9542aa24c24aaa06b13c4735 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137677063) * 7efd558cb74cf68f1d69da64f39e5e305ba4f950 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14426) Test and pass 103 tpcds tests
[ https://issues.apache.org/jira/browse/FLINK-14426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-14426: --- Parent: (was: FLINK-11491) Issue Type: Task (was: Sub-task) > Test and pass 103 tpcds tests > - > > Key: FLINK-14426 > URL: https://issues.apache.org/jira/browse/FLINK-14426 > Project: Flink > Issue Type: Task > Components: Table SQL / API, Table SQL / Planner >Reporter: Leonard Xu >Assignee: Leonard Xu >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14425) Add table statistics support for tpc-ds tests
[ https://issues.apache.org/jira/browse/FLINK-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-14425: --- Parent: (was: FLINK-11491) Issue Type: Task (was: Sub-task) > Add table statistics support for tpc-ds tests > - > > Key: FLINK-14425 > URL: https://issues.apache.org/jira/browse/FLINK-14425 > Project: Flink > Issue Type: Task > Components: Table SQL / API, Table SQL / Planner >Reporter: Leonard Xu >Assignee: Leonard Xu >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14423) Import teradat.tpcds as test data generator (refer to hive)
[ https://issues.apache.org/jira/browse/FLINK-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-14423: --- Parent: (was: FLINK-11491) Issue Type: Task (was: Sub-task) > Import teradat.tpcds as test data generator (refer to hive) > --- > > Key: FLINK-14423 > URL: https://issues.apache.org/jira/browse/FLINK-14423 > Project: Flink > Issue Type: Task > Components: Table SQL / API, Table SQL / Planner >Reporter: Leonard Xu >Assignee: Leonard Xu >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14424) Create tpc-ds end to end test to support all tpc-ds queries
[ https://issues.apache.org/jira/browse/FLINK-14424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-14424: --- Parent: (was: FLINK-11491) Issue Type: Task (was: Sub-task) > Create tpc-ds end to end test to support all tpc-ds queries > > > Key: FLINK-14424 > URL: https://issues.apache.org/jira/browse/FLINK-14424 > Project: Flink > Issue Type: Task > Components: Table SQL / API, Table SQL / Planner >Reporter: Leonard Xu >Assignee: Leonard Xu >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10275: [FLINK-14733][runtime] Introduce a builder for flexible ResourceProfile building
flinkbot edited a comment on issue #10275: [FLINK-14733][runtime] Introduce a builder for flexible ResourceProfile building URL: https://github.com/apache/flink/pull/10275#issuecomment-556931854 ## CI report: * f6c984aee2adafa83829762496ad13b75e8e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137511335) * a5fd8651de136478e53c55ffab2bd7fae5b82224 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14765) Remove STATE_UPDATER in Execution
[
https://issues.apache.org/jira/browse/FLINK-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979776#comment-16979776
]
vinoyang commented on FLINK-14765:
--
[~azagrebin] OK, will open a PR to see if it looks good when removed
{{STATE_UPDATER}}.
> Remove STATE_UPDATER in Execution
> -
>
> Key: FLINK-14765
> URL: https://issues.apache.org/jira/browse/FLINK-14765
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination
>Reporter: vinoyang
>Priority: Major
>
> After making access to ExecutionGraph single-threaded in FLINK-11417, we can
> simplify execution state update and get rid of STATE_UPDATER while about the
> volatile at the moment which could be further investigated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10232: [FLINK-14314][runtime] Allocate shared slot resources respecting the resources of all vertices in the group
flinkbot edited a comment on issue #10232: [FLINK-14314][runtime] Allocate shared slot resources respecting the resources of all vertices in the group URL: https://github.com/apache/flink/pull/10232#issuecomment-554775330 ## CI report: * b62006e7cf875fa318b3ce57afb14b0b2679bcb5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136890375) * 9ae7a0477e0474da96b2add1edf857c13888c4a7 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136933316) * 4225953861e2cbab26bfa2f0b9eb3a1582dffbe2 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136957958) * f2ad62934200bd550b479825ff224ffc227f0984 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137401146) * 23ac452994a9d3e376a8408f97947e42291be653 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137407224) * 582081d26a06f1ce7abc04317f489cf6b1c0f21f : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137511360) * 8d05aa877150f0b4ec0d61eca1907e24c808b93c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137553786) * c7f2649002f8c290df78f45b8c83ebc2a7507ce6 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14915) SchedulingStrategyFactory#createInstance might not need to know JobGraph
[
https://issues.apache.org/jira/browse/FLINK-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zili Chen updated FLINK-14915:
--
Description: [~zhuzh] [~GJL] I just notice that
{{SchedulingStrategyFactory#createInstance}} take a parameter {{JobGraph}} but
neither the parameter is in use nor this class/method should know {{JobGraph}}.
Could you explain why we need it or we can safely remove the parameter so that
we get rid of confusing parameter? (was: [~zhuzh] I just notice that
{{SchedulingStrategyFactory#createInstance}} take a parameter {{JobGraph}} but
neither the parameter is in use nor this class/method should know {{JobGraph}}.
Could you explain why we need it or we can safely remove the parameter so that
we get rid of confusing parameter?)
> SchedulingStrategyFactory#createInstance might not need to know JobGraph
>
>
> Key: FLINK-14915
> URL: https://issues.apache.org/jira/browse/FLINK-14915
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
>Reporter: Zili Chen
>Priority: Major
>
> [~zhuzh] [~GJL] I just notice that
> {{SchedulingStrategyFactory#createInstance}} take a parameter {{JobGraph}}
> but neither the parameter is in use nor this class/method should know
> {{JobGraph}}. Could you explain why we need it or we can safely remove the
> parameter so that we get rid of confusing parameter?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FLINK-14915) SchedulingStrategyFactory#createInstance might not need to know JobGraph
Zili Chen created FLINK-14915:
-
Summary: SchedulingStrategyFactory#createInstance might not need
to know JobGraph
Key: FLINK-14915
URL: https://issues.apache.org/jira/browse/FLINK-14915
Project: Flink
Issue Type: Bug
Components: Runtime / Coordination
Reporter: Zili Chen
[~zhuzh] I just notice that {{SchedulingStrategyFactory#createInstance}} take a
parameter {{JobGraph}} but neither the parameter is in use nor this
class/method should know {{JobGraph}}. Could you explain why we need it or we
can safely remove the parameter so that we get rid of confusing parameter?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
flinkbot edited a comment on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission URL: https://github.com/apache/flink/pull/10193#issuecomment-553881527 ## CI report: * e3ac83fe02a7583159184772ff4b4341fa65f827 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136517817) * eefbec6756be60a27698d275a1b94bef7cd0c1e2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136636043) * 19a83ead105c951505dbafb0280fa2d25132c9a0 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136645898) * dd2b911c850a56e3d6aa4a3c7e16b30431977bf5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136651764) * 06b368d9fbd88eabf71391fc1662b4d8a626d43c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137165694) * d4b77c8aab32cdeb11806fdd45ea88141051a157 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137317107) * 53b86608c1d008c53112b34c634ccf96419cd921 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137343147) * 2969fb4fb3afc8c331415c1ca478b05f3cb47b47 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137394777) * edccba4a6db80772f9494f5631e1bc6a340d6586 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14892) Add documentation for checkpoint directory layout
[
https://issues.apache.org/jira/browse/FLINK-14892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Congxian Qiu(klion26) updated FLINK-14892:
--
Summary: Add documentation for checkpoint directory layout (was: Add
description for checkpoint directory layout)
> Add documentation for checkpoint directory layout
> -
>
> Key: FLINK-14892
> URL: https://issues.apache.org/jira/browse/FLINK-14892
> Project: Flink
> Issue Type: Improvement
> Components: Documentation, Runtime / Checkpointing
>Reporter: Congxian Qiu(klion26)
>Priority: Major
> Fix For: 1.10.0
>
>
> In FLINK-8531, we change the checkpoint directory layout to
> {code:java}
> /user-defined-checkpoint-dir
> |
> + --shared/
> + --taskowned/
> + --chk-1/
> + --chk-2/
> + --chk-3/
> ...
> {code}
> But the directory layout did not describe in the doc currently, and I found
> some users confused about this, such as[1][2], so I propose to add a
> description for the checkpoint directory layout in the documentation, maybe
> in the page {{checkpoints#DirectoryStructure}}[3]
> [1]
> [http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Flink-checkpointing-behavior-td30749.html#a30751]
> [2]
> [http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Apache-Flink-Operator-name-and-uuid-best-practices-td31031.html]
> [3]
> [https://ci.apache.org/projects/flink/flink-docs-release-1.9/ops/state/checkpoints.html#directory-structure]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] zhuzhurk commented on issue #10275: [FLINK-14733][runtime] Introduce a builder for flexible ResourceProfile building
zhuzhurk commented on issue #10275: [FLINK-14733][runtime] Introduce a builder for flexible ResourceProfile building URL: https://github.com/apache/flink/pull/10275#issuecomment-557352189 Rebased. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhuzhurk commented on issue #10232: [FLINK-14314][runtime] Allocate shared slot resources respecting the resources of all vertices in the group
zhuzhurk commented on issue #10232: [FLINK-14314][runtime] Allocate shared slot resources respecting the resources of all vertices in the group URL: https://github.com/apache/flink/pull/10232#issuecomment-557351277 Rebased. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-14424) Create tpc-ds end to end test to support all tpc-ds queries
[ https://issues.apache.org/jira/browse/FLINK-14424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-14424. -- Resolution: Duplicate > Create tpc-ds end to end test to support all tpc-ds queries > > > Key: FLINK-14424 > URL: https://issues.apache.org/jira/browse/FLINK-14424 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API, Table SQL / Planner >Reporter: Leonard Xu >Assignee: Leonard Xu >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FLINK-14677) validate all tpc-ds query result with TPC Official reference answer set
[ https://issues.apache.org/jira/browse/FLINK-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-14677. -- Resolution: Duplicate > validate all tpc-ds query result with TPC Official reference answer set > --- > > Key: FLINK-14677 > URL: https://issues.apache.org/jira/browse/FLINK-14677 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.9.1 >Reporter: Leonard Xu >Priority: Major > Fix For: 1.10.0 > > > From my tpc-ds qualification test, some queries’s result are not match > Official reference answer set which need to address. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FLINK-14674) some tpc-ds query hang in scheduled stage for long time
[ https://issues.apache.org/jira/browse/FLINK-14674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-14674. -- Assignee: Leonard Xu Resolution: Fixed fixed by using less operator memory > some tpc-ds query hang in scheduled stage for long time > --- > > Key: FLINK-14674 > URL: https://issues.apache.org/jira/browse/FLINK-14674 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Runtime >Affects Versions: 1.9.1 >Reporter: Leonard Xu >Assignee: Leonard Xu >Priority: Major > Fix For: 1.10.0 > > > When run tpc-ds query in standalone mode, some query(4、11、28、31、77、88) hang > in scheduled stage for long time, > BTW，I use blink planner，bath mode shuffle. > Can reproduce this issue in > [https://github.com/leonardBang/flink/tree/FLINK-11491] > > cc [~zhuzh] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FLINK-14675) output directory settings of tpc-ds dataGenerator have length limitation
[ https://issues.apache.org/jira/browse/FLINK-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-14675. -- Assignee: Leonard Xu Resolution: Fixed fixed by using relative path in e2e test > output directory settings of tpc-ds dataGenerator have length limitation > > > Key: FLINK-14675 > URL: https://issues.apache.org/jira/browse/FLINK-14675 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.9.1 >Reporter: Leonard Xu >Assignee: Leonard Xu >Priority: Major > Fix For: 1.10.0 > > > output directory settings of tpc-ds dataGenerator have length limitation,. > if output directory is longer than the limitation, datagenerator(i.e. dsdgen) > will throw an error and stop generating progress. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (FLINK-14886) Wrong result in scalar query using blink planner
[ https://issues.apache.org/jira/browse/FLINK-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young reopened FLINK-14886: > Wrong result in scalar query using blink planner > > > Key: FLINK-14886 > URL: https://issues.apache.org/jira/browse/FLINK-14886 > Project: Flink > Issue Type: Bug > Components: Table SQL / Planner >Affects Versions: 1.9.1 >Reporter: Leonard Xu >Priority: Blocker > Attachments: Flink.png, screenshot-1.png, screenshot-2.png > > > Sorry for close this issue becasue I didn't find the precise root cause. > But I have some conclusion as following, and I’ll open a new issue if I have > positive progress. > !screenshot-2.png! > !Flink.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions
flinkbot edited a comment on issue #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions URL: https://github.com/apache/flink/pull/10286#issuecomment-557307188 ## CI report: * 2a81c8933ba20c459377b0804d77d21f7f1b16d7 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137681833) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #5521: [FLINK-8599] Improve the failure behavior of the FileInputFormat for …
flinkbot edited a comment on issue #5521: [FLINK-8599] Improve the failure behavior of the FileInputFormat for … URL: https://github.com/apache/flink/pull/5521#issuecomment-547463841 ## CI report: * 498611c0cd8678dfd4f3e772826081f83260bb28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134018823) * 53a83524654e21eec69e97291b9b80273950617a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134782509) * ea1c93de4f52d348584df5f5d271c7d5ff547695 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134785613) * 05aa2f2f17963b14b623c60452ebc728438d70bb : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134790622) * 96d507befa69e1eca8e2deb4bce6a74567e5ce5b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134792795) * 21634daeb420124410ba7b320caf596b5d67aa21 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134958500) * 1c1e5a5dc15ecaa24853574b13472d1d218515ae : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135034111) * 4935b837a5d6caa4377f8d5aacd1e2f7bebf4b9a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135110562) * 0784f386c7613ea5e47cf295cd22cf5380ffa5aa : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135135040) * 18723cc4a20c372f5c86b9158eaa24522ba2a439 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135164000) * 46958e1921226508e62a90e0ef2e6ad19b245a37 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135337853) * 8e75ee5df82c7575623a40d6aa0c055e3b892a5e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136738787) * 2393ef6b619258fc58c58a141e2bd896042512e8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136773994) * 8ece2a4fa8560f0885af0d78e338ef5fb155040a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136788572) * 7403cf0643e2dff636ca412c1dd0c11b9678714c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136827979) * a4a40dadaa8b69187cc7186f17c69f7397268a53 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136842899) * 7e197d79650a22f897154228c3875fe482376629 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136848784) * 610a49b70465dc9a5b9b78b3b43ae54c025b52f2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136852712) * 41a22b8a32c8dd78f62d702a21b288ca27fd245c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136879085) * d774997071a56ac27c5e0b55d9b58ba5eba1f257 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136887799) * a99e3095a78791ca9df9e6b7c5e8930bc623640d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136896513) * a3ddf546e267a068773474586ccb8b6062b5557e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136910623) * 373f17447a2bf8cfd57b1b9e53417eeb2064b4d6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136916250) * a0156e51f9d318515c88fc21130e05a5ad9f0839 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136921447) * 17bb4e7e2a734ee07b60f3b5f30342832fd8e79c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137063047) * d37985a0bc7bddd888fb3d68e88e6ce4aaeff847 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137078284) * 709a84c824472f7ce1529dcaa595c0bacf3176dd : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137105535) * 77c9889138e84aaa7d8e2899ea8668dae3b424d8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137199766) * b955276d7bf0085812cbd9fd9e607454b607307b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137295623) * ae129a0b802f2490ccb7328b3882081a3a486638 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137310601) * 95cc078fa52d8fbfa95eb7e8d00062c0ab2b6a67 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137388823) * 31f2d1bb9b55b156b6d6abc41013d0e1e788930c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137472137) * 496f082d4826a65a9542aa24c24aaa06b13c4735 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137677063) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions
flinkbot edited a comment on issue #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions URL: https://github.com/apache/flink/pull/10286#issuecomment-557307188 ## CI report: * 2a81c8933ba20c459377b0804d77d21f7f1b16d7 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/137681833) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #5521: [FLINK-8599] Improve the failure behavior of the FileInputFormat for …
flinkbot edited a comment on issue #5521: [FLINK-8599] Improve the failure behavior of the FileInputFormat for … URL: https://github.com/apache/flink/pull/5521#issuecomment-547463841 ## CI report: * 498611c0cd8678dfd4f3e772826081f83260bb28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134018823) * 53a83524654e21eec69e97291b9b80273950617a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134782509) * ea1c93de4f52d348584df5f5d271c7d5ff547695 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134785613) * 05aa2f2f17963b14b623c60452ebc728438d70bb : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134790622) * 96d507befa69e1eca8e2deb4bce6a74567e5ce5b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134792795) * 21634daeb420124410ba7b320caf596b5d67aa21 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134958500) * 1c1e5a5dc15ecaa24853574b13472d1d218515ae : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135034111) * 4935b837a5d6caa4377f8d5aacd1e2f7bebf4b9a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135110562) * 0784f386c7613ea5e47cf295cd22cf5380ffa5aa : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135135040) * 18723cc4a20c372f5c86b9158eaa24522ba2a439 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135164000) * 46958e1921226508e62a90e0ef2e6ad19b245a37 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135337853) * 8e75ee5df82c7575623a40d6aa0c055e3b892a5e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136738787) * 2393ef6b619258fc58c58a141e2bd896042512e8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136773994) * 8ece2a4fa8560f0885af0d78e338ef5fb155040a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136788572) * 7403cf0643e2dff636ca412c1dd0c11b9678714c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136827979) * a4a40dadaa8b69187cc7186f17c69f7397268a53 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136842899) * 7e197d79650a22f897154228c3875fe482376629 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136848784) * 610a49b70465dc9a5b9b78b3b43ae54c025b52f2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136852712) * 41a22b8a32c8dd78f62d702a21b288ca27fd245c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136879085) * d774997071a56ac27c5e0b55d9b58ba5eba1f257 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136887799) * a99e3095a78791ca9df9e6b7c5e8930bc623640d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136896513) * a3ddf546e267a068773474586ccb8b6062b5557e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136910623) * 373f17447a2bf8cfd57b1b9e53417eeb2064b4d6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136916250) * a0156e51f9d318515c88fc21130e05a5ad9f0839 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136921447) * 17bb4e7e2a734ee07b60f3b5f30342832fd8e79c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137063047) * d37985a0bc7bddd888fb3d68e88e6ce4aaeff847 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137078284) * 709a84c824472f7ce1529dcaa595c0bacf3176dd : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137105535) * 77c9889138e84aaa7d8e2899ea8668dae3b424d8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137199766) * b955276d7bf0085812cbd9fd9e607454b607307b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137295623) * ae129a0b802f2490ccb7328b3882081a3a486638 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137310601) * 95cc078fa52d8fbfa95eb7e8d00062c0ab2b6a67 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137388823) * 31f2d1bb9b55b156b6d6abc41013d0e1e788930c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137472137) * 496f082d4826a65a9542aa24c24aaa06b13c4735 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/137677063) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions
flinkbot commented on issue #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions URL: https://github.com/apache/flink/pull/10286#issuecomment-557307188 ## CI report: * 2a81c8933ba20c459377b0804d77d21f7f1b16d7 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #5521: [FLINK-8599] Improve the failure behavior of the FileInputFormat for …
flinkbot edited a comment on issue #5521: [FLINK-8599] Improve the failure behavior of the FileInputFormat for … URL: https://github.com/apache/flink/pull/5521#issuecomment-547463841 ## CI report: * 498611c0cd8678dfd4f3e772826081f83260bb28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134018823) * 53a83524654e21eec69e97291b9b80273950617a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134782509) * ea1c93de4f52d348584df5f5d271c7d5ff547695 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134785613) * 05aa2f2f17963b14b623c60452ebc728438d70bb : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134790622) * 96d507befa69e1eca8e2deb4bce6a74567e5ce5b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134792795) * 21634daeb420124410ba7b320caf596b5d67aa21 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134958500) * 1c1e5a5dc15ecaa24853574b13472d1d218515ae : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135034111) * 4935b837a5d6caa4377f8d5aacd1e2f7bebf4b9a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135110562) * 0784f386c7613ea5e47cf295cd22cf5380ffa5aa : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135135040) * 18723cc4a20c372f5c86b9158eaa24522ba2a439 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135164000) * 46958e1921226508e62a90e0ef2e6ad19b245a37 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135337853) * 8e75ee5df82c7575623a40d6aa0c055e3b892a5e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136738787) * 2393ef6b619258fc58c58a141e2bd896042512e8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136773994) * 8ece2a4fa8560f0885af0d78e338ef5fb155040a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136788572) * 7403cf0643e2dff636ca412c1dd0c11b9678714c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136827979) * a4a40dadaa8b69187cc7186f17c69f7397268a53 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136842899) * 7e197d79650a22f897154228c3875fe482376629 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136848784) * 610a49b70465dc9a5b9b78b3b43ae54c025b52f2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136852712) * 41a22b8a32c8dd78f62d702a21b288ca27fd245c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136879085) * d774997071a56ac27c5e0b55d9b58ba5eba1f257 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136887799) * a99e3095a78791ca9df9e6b7c5e8930bc623640d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136896513) * a3ddf546e267a068773474586ccb8b6062b5557e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136910623) * 373f17447a2bf8cfd57b1b9e53417eeb2064b4d6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136916250) * a0156e51f9d318515c88fc21130e05a5ad9f0839 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136921447) * 17bb4e7e2a734ee07b60f3b5f30342832fd8e79c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137063047) * d37985a0bc7bddd888fb3d68e88e6ce4aaeff847 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137078284) * 709a84c824472f7ce1529dcaa595c0bacf3176dd : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137105535) * 77c9889138e84aaa7d8e2899ea8668dae3b424d8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137199766) * b955276d7bf0085812cbd9fd9e607454b607307b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137295623) * ae129a0b802f2490ccb7328b3882081a3a486638 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137310601) * 95cc078fa52d8fbfa95eb7e8d00062c0ab2b6a67 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137388823) * 31f2d1bb9b55b156b6d6abc41013d0e1e788930c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137472137) * 496f082d4826a65a9542aa24c24aaa06b13c4735 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions
flinkbot commented on issue #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions URL: https://github.com/apache/flink/pull/10286#issuecomment-557299007 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 2a81c8933ba20c459377b0804d77d21f7f1b16d7 (Thu Nov 21 22:20:59 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14890) TestHarness for KeyedBroadcastProcessFunction
[
https://issues.apache.org/jira/browse/FLINK-14890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-14890:
---
Labels: pull-request-available (was: )
> TestHarness for KeyedBroadcastProcessFunction
> -
>
> Key: FLINK-14890
> URL: https://issues.apache.org/jira/browse/FLINK-14890
> Project: Flink
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 1.9.1
>Reporter: Jun Qin
>Assignee: Alexander Fedulov
>Priority: Minor
> Labels: pull-request-available
>
> To test {{KeyedCoProcessFunction}}, one can use {{KeyedCoProcessOperator}}
> and {{KeyedTwoInputStreamOperatorTestHarness}}, to test
> {{KeyedBroadcastProcessFunction}}, I see {{CoBroadcastWithKeyedOperator}},
> but the TestHarness class is missing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] afedulov opened a new pull request #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions
afedulov opened a new pull request #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions URL: https://github.com/apache/flink/pull/10286 ## What is the purpose of the change Adds missing test harnesses for broadcast functions ## Brief change log Two new test harnesses are added - one for keyed one for non-keyed broadcast functions. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (JavaDocs) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded
flinkbot edited a comment on issue #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded URL: https://github.com/apache/flink/pull/10285#issuecomment-557220840 ## CI report: * 148f664308ebcf488ba1b86c4e75bab1dd1c83f8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137640682) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14908) Distributing CacheFiles through DFS does not work
[
https://issues.apache.org/jira/browse/FLINK-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979572#comment-16979572
]
djordje commented on FLINK-14908:
-
I'm using flink 1.9.0 so this version is also affected. (Assuming this was not
intentional)
> Distributing CacheFiles through DFS does not work
> -
>
> Key: FLINK-14908
> URL: https://issues.apache.org/jira/browse/FLINK-14908
> Project: Flink
> Issue Type: Bug
> Components: Client / Job Submission, Runtime / REST
>Affects Versions: 1.8.2, 1.9.1
>Reporter: Dawid Wysakowicz
>Priority: Major
>
> User reported that distributing cache files through DFS does not work
> anymore:
> https://stackoverflow.com/questions/58978476/flink-1-9-wont-run-program-when-i-use-distributed-cache-why
> I think the problematic part is in {{RestClusterClient#submitJob}}:
> {code}
> for (Map.Entry artifacts :
> jobGraph.getUserArtifacts().entrySet()) {
> artifactFileNames.add(new
> JobSubmitRequestBody.DistributedCacheFile(artifacts.getKey(), new
> Path(artifacts.getValue().filePath).getName()));
> filesToUpload.add(new
> FileUpload(Paths.get(artifacts.getValue().filePath),
> RestConstants.CONTENT_TYPE_BINARY));
> }
> {code}
> The code does not check if a file is in DFS, but just assumes it is in local
> FS and tries to add it to the rest request, which fails. The code on the
> receiver side in {{JobSubmitHandler}} still can support files distributed via
> DFS, but need to get proper paths to files in DFS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10238: [FLINK-8949] Add dedicated watermarks metric retrieval endpoint
flinkbot edited a comment on issue #10238: [FLINK-8949] Add dedicated watermarks metric retrieval endpoint URL: https://github.com/apache/flink/pull/10238#issuecomment-555064294 ## CI report: * a6c3b628841cead29b7c0e3d83bbf78c3a6b9170 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137021773) * d560fda578f0d6b39d0b98f76fc29ae23bb3303c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137439459) * 01eef68c10fab42e2b9aa58e596f96ab3be24fe6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137444516) * 61261b2065da9ebba0ce65f79f3cbbbcbd1913e9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137624380) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10222: [FLINK-14788][configuration] Add configure method to CheckpointConfig
flinkbot edited a comment on issue #10222: [FLINK-14788][configuration] Add configure method to CheckpointConfig URL: https://github.com/apache/flink/pull/10222#issuecomment-554372384 ## CI report: * a7a80b60af90a66251ef5772cc55cf15bd4df55e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136706389) * 3e71e5d0d4e9e45269daf5b84d150fc834d72e88 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137165728) * 093f2c258d91fde46890095d6e387e58f16d91c9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137417426) * 3fbe9290e858af9f46f489dd4cefdb7f329b05e0 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137573303) * 350a09dbf75971a75a788fb82777ef9eac7d91e9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137617394) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14912) register, drop, and alter catalog functions from DDL via catalog
[ https://issues.apache.org/jira/browse/FLINK-14912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-14912: - Summary: register, drop, and alter catalog functions from DDL via catalog (was: register,drop, and alter catalog functions from DDL to FunctionCatalog) > register, drop, and alter catalog functions from DDL via catalog > > > Key: FLINK-14912 > URL: https://issues.apache.org/jira/browse/FLINK-14912 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Bowen Li >Assignee: Zhenqiu Huang >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-14914) refactor CatalogFunction interface and impls to add language field
Bowen Li created FLINK-14914: Summary: refactor CatalogFunction interface and impls to add language field Key: FLINK-14914 URL: https://issues.apache.org/jira/browse/FLINK-14914 Project: Flink Issue Type: Sub-task Components: Table SQL / API Reporter: Bowen Li Assignee: Zhenqiu Huang Fix For: 1.10.0 to verify: HiveCatalog may only support java functions out of shelf, may need to think about how to support scala/python functions -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14913) refactor CatalogFunction interface and impls to remove properties map
[ https://issues.apache.org/jira/browse/FLINK-14913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-14913: - Component/s: Table SQL / API > refactor CatalogFunction interface and impls to remove properties map > - > > Key: FLINK-14913 > URL: https://issues.apache.org/jira/browse/FLINK-14913 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Bowen Li >Assignee: Zhenqiu Huang >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14913) refactor CatalogFunction interface and impls to remove properties map
[ https://issues.apache.org/jira/browse/FLINK-14913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-14913: - Summary: refactor CatalogFunction interface and impls to remove properties map (was: refactor CatalogFunction interface and impls by removing properties map) > refactor CatalogFunction interface and impls to remove properties map > - > > Key: FLINK-14913 > URL: https://issues.apache.org/jira/browse/FLINK-14913 > Project: Flink > Issue Type: Sub-task >Reporter: Bowen Li >Assignee: Zhenqiu Huang >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-14913) refactor CatalogFunction interface and impls by removing properties map
Bowen Li created FLINK-14913: Summary: refactor CatalogFunction interface and impls by removing properties map Key: FLINK-14913 URL: https://issues.apache.org/jira/browse/FLINK-14913 Project: Flink Issue Type: Sub-task Reporter: Bowen Li Assignee: Zhenqiu Huang Fix For: 1.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-14912) register,drop, and alter catalog functions from DDL to FunctionCatalog
Bowen Li created FLINK-14912: Summary: register,drop, and alter catalog functions from DDL to FunctionCatalog Key: FLINK-14912 URL: https://issues.apache.org/jira/browse/FLINK-14912 Project: Flink Issue Type: Sub-task Components: Table SQL / API Reporter: Bowen Li Assignee: Zhenqiu Huang Fix For: 1.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14906) register,drop, and alter temp system functions from DDL to FunctionCatalog
[ https://issues.apache.org/jira/browse/FLINK-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-14906: - Summary: register,drop, and alter temp system functions from DDL to FunctionCatalog (was: register and drop temp system functions from DDL to FunctionCatalog) > register,drop, and alter temp system functions from DDL to FunctionCatalog > -- > > Key: FLINK-14906 > URL: https://issues.apache.org/jira/browse/FLINK-14906 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Affects Versions: 1.10.0 >Reporter: Zhenqiu Huang >Assignee: Zhenqiu Huang >Priority: Critical > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14911) register, drop, and alter temp catalog functions from DDL to FunctionCatalog
[ https://issues.apache.org/jira/browse/FLINK-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-14911: - Summary: register, drop, and alter temp catalog functions from DDL to FunctionCatalog (was: register temp catalog functions created by DDL to FunctionCatalog) > register, drop, and alter temp catalog functions from DDL to FunctionCatalog > > > Key: FLINK-14911 > URL: https://issues.apache.org/jira/browse/FLINK-14911 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Bowen Li >Assignee: Zhenqiu Huang >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14906) register and drop temp system functions from DDL to FunctionCatalog
[ https://issues.apache.org/jira/browse/FLINK-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-14906: - Summary: register and drop temp system functions from DDL to FunctionCatalog (was: register temp system functions created by DDL to FunctionCatalog) > register and drop temp system functions from DDL to FunctionCatalog > --- > > Key: FLINK-14906 > URL: https://issues.apache.org/jira/browse/FLINK-14906 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Affects Versions: 1.10.0 >Reporter: Zhenqiu Huang >Assignee: Zhenqiu Huang >Priority: Critical > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded
flinkbot edited a comment on issue #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded URL: https://github.com/apache/flink/pull/10285#issuecomment-557220840 ## CI report: * 148f664308ebcf488ba1b86c4e75bab1dd1c83f8 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/137640682) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-14911) register temp catalog functions created by DDL to FunctionCatalog
Bowen Li created FLINK-14911: Summary: register temp catalog functions created by DDL to FunctionCatalog Key: FLINK-14911 URL: https://issues.apache.org/jira/browse/FLINK-14911 Project: Flink Issue Type: Sub-task Components: Table SQL / API Reporter: Bowen Li Assignee: Zhenqiu Huang Fix For: 1.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FLINK-14906) register temp system functions created by DDL to FunctionCatalog
[ https://issues.apache.org/jira/browse/FLINK-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-14906: Assignee: Zhenqiu Huang > register temp system functions created by DDL to FunctionCatalog > > > Key: FLINK-14906 > URL: https://issues.apache.org/jira/browse/FLINK-14906 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Affects Versions: 1.10.0 >Reporter: Zhenqiu Huang >Assignee: Zhenqiu Huang >Priority: Critical > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14906) register temp system functions created by DDL to FunctionCatalog
[ https://issues.apache.org/jira/browse/FLINK-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-14906: - Summary: register temp system functions created by DDL to FunctionCatalog (was: Add function related method in CatalogManager) > register temp system functions created by DDL to FunctionCatalog > > > Key: FLINK-14906 > URL: https://issues.apache.org/jira/browse/FLINK-14906 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Affects Versions: 1.10.0 >Reporter: Zhenqiu Huang >Priority: Critical > > 1) Add a temporary function hashmap to store temporary functions > 2) Add create, drop, alter function methods in catalog manager > 3) Update CatalogFunction interface by adding getLanguage and isSystem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14906) register temp system functions created by DDL to FunctionCatalog
[ https://issues.apache.org/jira/browse/FLINK-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-14906: - Fix Version/s: 1.10.0 > register temp system functions created by DDL to FunctionCatalog > > > Key: FLINK-14906 > URL: https://issues.apache.org/jira/browse/FLINK-14906 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Affects Versions: 1.10.0 >Reporter: Zhenqiu Huang >Priority: Critical > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14906) register temp system functions created by DDL to FunctionCatalog
[ https://issues.apache.org/jira/browse/FLINK-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-14906: - Description: (was: 1) Add a temporary function hashmap to store temporary functions 2) Add create, drop, alter function methods in catalog manager 3) Update CatalogFunction interface by adding getLanguage and isSystem. ) > register temp system functions created by DDL to FunctionCatalog > > > Key: FLINK-14906 > URL: https://issues.apache.org/jira/browse/FLINK-14906 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Affects Versions: 1.10.0 >Reporter: Zhenqiu Huang >Priority: Critical > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10114: [WIP][FLINK -14651][runtime] Enable DefaultScheduler
flinkbot edited a comment on issue #10114: [WIP][FLINK -14651][runtime] Enable DefaultScheduler URL: https://github.com/apache/flink/pull/10114#issuecomment-551014940 ## CI report: * c436371614d7db5dfc8c97e01a4594c3139715db : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135418856) * d2f3a108547945633de80938684aa9c750534269 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135432444) * dcb4596a1246234038c1f327d9e858b7c654966e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135445805) * 3bf7b045474d4bf278eb416491c32c9fb3c218a9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135495382) * 90152b07e795bc931c37b4baf2092ba0ee9219f1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135649425) * 1657e4dd1f3ecbfa2956552efd401641c94a56aa : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135963847) * 31de348cd4fc6f1c41cdd94853c1e5ecb8206b4c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136101528) * 641fae6542a62c3ba329e628f69387d53b95b0b6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136421792) * 639a9c20d8bb35d7fb7fb48511fe62feac619fb9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136517722) * 8c1235c8b5a1de6a974ea40f0287680d5c1f5f46 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136568224) * 5c508e3be15e685c067cfddfd2450b60c1fcfba7 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136696854) * 72b9c027dd87b09477958fc2d077933491cb0d4d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136738729) * 44b7e4785aac200e4fc63659d2376a78f566a517 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137159954) * 2b73f20851eed3026e7881c8ae162e2e309848ee : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137238368) * 48bec2c450e8dd14313c58d206d3af0571f45972 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137361133) * e67ebd1eb36cadd4a10e5494168f19074d0640be : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137394691) * 14e06e47a8675be77c07f79fe28cc5c2122005ce : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137413258) * 99795cfb3fb946c478f4e86c4b53b508e9e42092 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137439435) * aa3aaea5dc747bfe4c06b7f41d1809280526dff6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137534672) * 93a48786992d6f8ac6f27608fcbf86cd2a2e0d5b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137590164) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded
flinkbot commented on issue #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded URL: https://github.com/apache/flink/pull/10285#issuecomment-557220840 ## CI report: * 148f664308ebcf488ba1b86c4e75bab1dd1c83f8 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler
flinkbot edited a comment on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10283#issuecomment-55716 ## CI report: * 9bc37b6f7ab760f29d28c3cc9763a19de17fb484 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137616270) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded
flinkbot commented on issue #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded URL: https://github.com/apache/flink/pull/10285#issuecomment-557217153 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 148f664308ebcf488ba1b86c4e75bab1dd1c83f8 (Thu Nov 21 18:38:34 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-14896).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14896) Kinesis connector doesn't shade jackson dependency
[
https://issues.apache.org/jira/browse/FLINK-14896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-14896:
---
Labels: pull-request-available (was: )
> Kinesis connector doesn't shade jackson dependency
> --
>
> Key: FLINK-14896
> URL: https://issues.apache.org/jira/browse/FLINK-14896
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kinesis
>Affects Versions: 1.9.0
> Environment: AWS EMR 5.28.0
>Reporter: Michel Davit
>Priority: Minor
> Labels: pull-request-available
>
> flink-kinesis-connector depends on aws java sdk which is shaded to
> {{org.apache.flink.kinesis.shaded.com.amazonaws.}}
>
> {{However, the aws sdk has a transitive dependency to jackson wich is not
> shaded in the artifact.}}
>
> {{This creates problem when running flink on YARN: }}{{The aws sdk requires
> jackson-core v2.6 but hadoop pulls in 2.3. See
> [here|https://github.com/apache/flink/blob/e7c11ed672013512e5b159e7e892b27b1ef60a1b/flink-yarn/pom.xml#L133].}}
>
> {{If YARN uses the loads wrong jackson version from classpath. Jod fails
> with}}
> {code:java}
> 2019-11-20 17:23:11,563 ERROR
> org.apache.flink.runtime.webmonitor.handlers.JarRunHandler- Unhandled
> exception.org.apache.flink.client.program.ProgramInvocationException: The
> program caused an error: at
> org.apache.flink.client.program.OptimizerPlanEnvironment.getOptimizedPlan(OptimizerPlanEnvironment.java:93)
> at
> org.apache.flink.client.program.PackagedProgramUtils.createJobGraph(PackagedProgramUtils.java:80)
> at
> org.apache.flink.runtime.webmonitor.handlers.utils.JarHandlerUtils$JarHandlerContext.toJobGraph(JarHandlerUtils.java:126)
> at
> org.apache.flink.runtime.webmonitor.handlers.JarRunHandler.lambda$getJobGraphAsync$6(JarRunHandler.java:142)
> at
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)Caused by:
> java.lang.NoSuchMethodError:
> com.fasterxml.jackson.databind.ObjectMapper.enable([Lcom/fasterxml/jackson/core/JsonParser$Feature;)Lcom/fasterxml/jackson/databind/ObjectMapper;
> at
> com.amazonaws.partitions.PartitionsLoader.(PartitionsLoader.java:54)
> at
> com.amazonaws.regions.RegionMetadataFactory.create(RegionMetadataFactory.java:30)
> at com.amazonaws.regions.RegionUtils.initialize(RegionUtils.java:65)
> at com.amazonaws.regions.RegionUtils.getRegionMetadata(RegionUtils.java:53)
> at com.amazonaws.regions.RegionUtils.getRegion(RegionUtils.java:107)at
> com.amazonaws.client.builder.AwsClientBuilder.getRegionObject(AwsClientBuilder.java:256)
> at
> com.amazonaws.client.builder.AwsClientBuilder.setRegion(AwsClientBuilder.java:460)
> at
> com.amazonaws.client.builder.AwsClientBuilder.configureMutableProperties(AwsClientBuilder.java:424)
> at
> com.amazonaws.client.builder.AwsAsyncClientBuilder.build(AwsAsyncClientBuilder.java:80)
> ...
> {code}
> The flink-kinesis-connector should do as other connectors: shade jackson or
> use the flink-shaded-jackson core dependency
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] RustedBones opened a new pull request #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded
RustedBones opened a new pull request #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded URL: https://github.com/apache/flink/pull/10285 ## What is the purpose of the change - Avoid missing / conflict librabry error due to exclusion rule - Depends on [flink-shaded](https://github.com/apache/flink-shaded) as it is intended > The purpose of these dependencies is to provide a single instance of a shaded dependency in the Flink distribution, instead of each individual module shading the dependency. ## Brief change log - Add `flink-shaded-jackson` and `flink-shaded-guava` as provided dependency - Relocate jackson and guava to flink-shaded package - Fix wrong shading naming package (TBD since this this will break user code) ## Verifying this change This change is affecting packaging. Can be tested by running flink with classpath containing old versions of jacskson/guava ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): yes - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no (except shaded imports) - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] bowenli86 edited a comment on issue #10272: [FLINK-14878]Support `use catalog` through sqlUpdate() method in TableEnvironment
bowenli86 edited a comment on issue #10272: [FLINK-14878]Support `use catalog` through sqlUpdate() method in TableEnvironment URL: https://github.com/apache/flink/pull/10272#issuecomment-557215640 sorry for the late comment, but I happened to notice that UseCatalogOperation and UseOperation reside in package `/table/operations/ddl/`. Since they are not ddl, should they be relocated to `/table/operations/`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] bowenli86 edited a comment on issue #10272: [FLINK-14878]Support `use catalog` through sqlUpdate() method in TableEnvironment
bowenli86 edited a comment on issue #10272: [FLINK-14878]Support `use catalog` through sqlUpdate() method in TableEnvironment URL: https://github.com/apache/flink/pull/10272#issuecomment-557215640 sorry for the late comment, but I happened to notice that UseCatalogOperation and UseOperation reside in package `/table/operations/ddl/`. Since it's not ddl, should it just be relocated to `/table/operations/`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] bowenli86 commented on issue #10272: [FLINK-14878]Support `use catalog` through sqlUpdate() method in TableEnvironment
bowenli86 commented on issue #10272: [FLINK-14878]Support `use catalog` through sqlUpdate() method in TableEnvironment URL: https://github.com/apache/flink/pull/10272#issuecomment-557215640 sorry for the late comment, but I happened to notice that UseCatalogOperation resides in package `/table/operations/ddl/`. Since it's not ddl, should it just be relocated to `/table/operations/`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] bowenli86 closed pull request #10273: [FLINK-14866][doc] fix a few broken doc links
bowenli86 closed pull request #10273: [FLINK-14866][doc] fix a few broken doc links URL: https://github.com/apache/flink/pull/10273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-14866) A few documentation links are broken
[ https://issues.apache.org/jira/browse/FLINK-14866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-14866. Resolution: Fixed master: e14bd50fed42e89674ba9d01a231d5c5e59f490c > A few documentation links are broken > > > Key: FLINK-14866 > URL: https://issues.apache.org/jira/browse/FLINK-14866 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.10.0 >Reporter: Dian Fu >Assignee: Bowen Li >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The links for udfs.html and functions.html doesn't work any more. > udfs.html and functions.html are referenced in a few places, i.e.: > [https://raw.githubusercontent.com/apache/flink/master/docs/dev/table/sql.md] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FLINK-14688) Add table related DDLs support in SQL Parser
[ https://issues.apache.org/jira/browse/FLINK-14688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-14688: Assignee: Terry Wang > Add table related DDLs support in SQL Parser > > > Key: FLINK-14688 > URL: https://issues.apache.org/jira/browse/FLINK-14688 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Terry Wang >Assignee: Terry Wang >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > > 1. showTablesStatement: > SHOW TABLES > 2. descTableStatement: > DESCRIBE [ EXTENDED] [[catalogName.] dataBasesName].tableName > 3. alterTableStatement: > ALTER TABLE [[catalogName.] dataBasesName].tableName > RENAME TO newTableName > 4. ALTER TABLE [[catalogName.] dataBasesName].tableName > SET ( name=value [, name=value]*) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FLINK-14688) Add table related DDLs support in SQL Parser
[ https://issues.apache.org/jira/browse/FLINK-14688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-14688. Resolution: Fixed master: 05a3132cb4520b9baaaf787e48ae727e75b91062 > Add table related DDLs support in SQL Parser > > > Key: FLINK-14688 > URL: https://issues.apache.org/jira/browse/FLINK-14688 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Terry Wang >Assignee: Terry Wang >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > > 1. showTablesStatement: > SHOW TABLES > 2. descTableStatement: > DESCRIBE [ EXTENDED] [[catalogName.] dataBasesName].tableName > 3. alterTableStatement: > ALTER TABLE [[catalogName.] dataBasesName].tableName > RENAME TO newTableName > 4. ALTER TABLE [[catalogName.] dataBasesName].tableName > SET ( name=value [, name=value]*) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14688) Add table related DDLs support in SQL Parser
[ https://issues.apache.org/jira/browse/FLINK-14688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-14688: - Fix Version/s: 1.10.0 > Add table related DDLs support in SQL Parser > > > Key: FLINK-14688 > URL: https://issues.apache.org/jira/browse/FLINK-14688 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Terry Wang >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > > 1. showTablesStatement: > SHOW TABLES > 2. descTableStatement: > DESCRIBE [ EXTENDED] [[catalogName.] dataBasesName].tableName > 3. alterTableStatement: > ALTER TABLE [[catalogName.] dataBasesName].tableName > RENAME TO newTableName > 4. ALTER TABLE [[catalogName.] dataBasesName].tableName > SET ( name=value [, name=value]*) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] bowenli86 closed pull request #10209: [FLINK-14688] Add table related DDLs support in SQL Parser
bowenli86 closed pull request #10209: [FLINK-14688] Add table related DDLs support in SQL Parser URL: https://github.com/apache/flink/pull/10209 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10284: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler
flinkbot edited a comment on issue #10284: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10284#issuecomment-557162273 ## CI report: * 55bb7f0c227441d894acdfdea48610e4ccdbf12c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137619209) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10282: [FLINK-14901] Throw Error in MemoryUtils if there is problem with using system classes over reflection
flinkbot edited a comment on issue #10282: [FLINK-14901] Throw Error in MemoryUtils if there is problem with using system classes over reflection URL: https://github.com/apache/flink/pull/10282#issuecomment-557119462 ## CI report: * 3b564b3abfdf77f6385d896fffe8eacbd135756e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137584433) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14910) disableAutoGeneratedUIDs fails on keyBy
[
https://issues.apache.org/jira/browse/FLINK-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979467#comment-16979467
]
William Cheng commented on FLINK-14910:
---
dota2ruhub userID: 100814397
Data is missing for a stream starting at 11/15/2019 17:32:47
> disableAutoGeneratedUIDs fails on keyBy
> ---
>
> Key: FLINK-14910
> URL: https://issues.apache.org/jira/browse/FLINK-14910
> Project: Flink
> Issue Type: Bug
>Reporter: William Cheng
>Priority: Major
>
> There doesn't seem to be a way to add a UID to the Partition operator created
> by KeyBy, causing `disableAutoGeneratedUIDs` to fail.
>
> Here's a simple test case that will reproduce the issue:
> {noformat}
> @Test
> public void testFailedUID() throws Exception {
> StreamExecutionEnvironment env =
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.getConfig().disableAutoGeneratedUIDs();
> DataStream data = env.fromCollection(Arrays.asList("1", "2",
> "3")).uid("source-uid");
> data.keyBy(i -> i)
> .map(i -> i).uid("map-uid");
> env.execute();
> }{noformat}
> {noformat}
> testFailedUID(twitch.creatoranalytics.sessions.StreamingJobTest) Time
> elapsed: 0.008 sec <<< ERROR!
> java.lang.IllegalStateException: Auto generated UIDs have been disabled but
> no UID or hash has been assigned to operator Partition
> {noformat}
>
> This passes if the keyBy is removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-14910) disableAutoGeneratedUIDs fails on keyBy
[
https://issues.apache.org/jira/browse/FLINK-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
William Cheng updated FLINK-14910:
--
Description:
There doesn't seem to be a way to add a UID to the Partition operator created
by KeyBy, causing `disableAutoGeneratedUIDs` to fail.
Here's a simple test case that will reproduce the issue:
{noformat}
@Test
public void testFailedUID() throws Exception {
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
env.getConfig().disableAutoGeneratedUIDs();
DataStream data = env.fromCollection(Arrays.asList("1", "2",
"3")).uid("source-uid");
data.keyBy(i -> i)
.map(i -> i).uid("map-uid");
env.execute();
}{noformat}
{noformat}
testFailedUID(twitch.creatoranalytics.sessions.StreamingJobTest) Time elapsed:
0.008 sec <<< ERROR!
java.lang.IllegalStateException: Auto generated UIDs have been disabled but no
UID or hash has been assigned to operator Partition
{noformat}
This passes if the keyBy is removed.
was:
There doesn't seem to be a way to add a UID to the Partition operator created
by KeyBy, causing `disableAutoGeneratedUIDs` to fail.
Here's a simple test case that will reproduce the issue:
{noformat}
@Test
public void testFailedUID() throws Exception {
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
env.getConfig().disableAutoGeneratedUIDs();
DataStream data = env.fromCollection(Arrays.asList("1", "2",
"3")).uid("source-uid");
data.keyBy(i -> i)
.map(i -> i).uid("map-uid");
env.execute();
}{noformat}
This passes if the keyBy is removed.
> disableAutoGeneratedUIDs fails on keyBy
> ---
>
> Key: FLINK-14910
> URL: https://issues.apache.org/jira/browse/FLINK-14910
> Project: Flink
> Issue Type: Bug
>Reporter: William Cheng
>Priority: Major
>
> There doesn't seem to be a way to add a UID to the Partition operator created
> by KeyBy, causing `disableAutoGeneratedUIDs` to fail.
>
> Here's a simple test case that will reproduce the issue:
> {noformat}
> @Test
> public void testFailedUID() throws Exception {
> StreamExecutionEnvironment env =
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.getConfig().disableAutoGeneratedUIDs();
> DataStream data = env.fromCollection(Arrays.asList("1", "2",
> "3")).uid("source-uid");
> data.keyBy(i -> i)
> .map(i -> i).uid("map-uid");
> env.execute();
> }{noformat}
> {noformat}
> testFailedUID(twitch.creatoranalytics.sessions.StreamingJobTest) Time
> elapsed: 0.008 sec <<< ERROR!
> java.lang.IllegalStateException: Auto generated UIDs have been disabled but
> no UID or hash has been assigned to operator Partition
> {noformat}
>
> This passes if the keyBy is removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FLINK-14910) disableAutoGeneratedUIDs fails on keyBy
William Cheng created FLINK-14910:
-
Summary: disableAutoGeneratedUIDs fails on keyBy
Key: FLINK-14910
URL: https://issues.apache.org/jira/browse/FLINK-14910
Project: Flink
Issue Type: Bug
Reporter: William Cheng
There doesn't seem to be a way to add a UID to the Partition operator created
by KeyBy, causing `disableAutoGeneratedUIDs` to fail.
Here's a simple test case that will reproduce the issue:
{noformat}
@Test
public void testFailedUID() throws Exception {
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
env.getConfig().disableAutoGeneratedUIDs();
DataStream data = env.fromCollection(Arrays.asList("1", "2",
"3")).uid("source-uid");
data.keyBy(i -> i)
.map(i -> i).uid("map-uid");
env.execute();
}{noformat}
This passes if the keyBy is removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-14906) Add function related method in CatalogManager
[ https://issues.apache.org/jira/browse/FLINK-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenqiu Huang updated FLINK-14906: -- Description: 1) Add a temporary function hashmap to store temporary functions 2) Add create, drop, alter function methods in catalog manager 3) Update CatalogFunction interface by adding getLanguage and isSystem. was: 1) Add a temporary function hashmap to store temporary functions 2) Add create, drop, alter function methods in catalog manager > Add function related method in CatalogManager > - > > Key: FLINK-14906 > URL: https://issues.apache.org/jira/browse/FLINK-14906 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Affects Versions: 1.10.0 >Reporter: Zhenqiu Huang >Priority: Critical > > 1) Add a temporary function hashmap to store temporary functions > 2) Add create, drop, alter function methods in catalog manager > 3) Update CatalogFunction interface by adding getLanguage and isSystem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10238: [FLINK-8949] Add dedicated watermarks metric retrieval endpoint
flinkbot edited a comment on issue #10238: [FLINK-8949] Add dedicated watermarks metric retrieval endpoint URL: https://github.com/apache/flink/pull/10238#issuecomment-555064294 ## CI report: * a6c3b628841cead29b7c0e3d83bbf78c3a6b9170 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137021773) * d560fda578f0d6b39d0b98f76fc29ae23bb3303c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137439459) * 01eef68c10fab42e2b9aa58e596f96ab3be24fe6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137444516) * 61261b2065da9ebba0ce65f79f3cbbbcbd1913e9 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/137624380) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-14909) Let tasks in a batch get scheduled in topological order and subtaskIndex ascending pattern
Zhu Zhu created FLINK-14909:
---
Summary: Let tasks in a batch get scheduled in topological order
and subtaskIndex ascending pattern
Key: FLINK-14909
URL: https://issues.apache.org/jira/browse/FLINK-14909
Project: Flink
Issue Type: Sub-task
Components: Runtime / Coordination
Affects Versions: 1.10.0
Reporter: Zhu Zhu
Fix For: 1.10.0
I'd propose to let tasks in a batch get scheduled in topological order and
subtaskIndex ascending pattern.
There can be 2 benefits:
1. there would be less chance for a task to get launched before its upstream
tasks, which reduces {{requestPartitionState}} RPCs to JobMaster.
2. logs could be more readable, e.g.
ordered:
Source: source (1/20) ... switched from CREATED to SCHEDULED.
Source: source (2/20) ... switched from CREATED to SCHEDULED.
...
Source: source (20/20) ... switched from CREATED to SCHEDULED.
Flat Map (1/20) ... switched from CREATED to SCHEDULED.
...
Flat Map (20/20) ... switched from CREATED to SCHEDULED.
disordered:
Source: source (1/20) ... switched from CREATED to SCHEDULED.
Flat Map (11/20) ... switched from CREATED to SCHEDULED.
Source: source (19/20) ... switched from CREATED to SCHEDULED.
Flat Map (2/20) ... switched from CREATED to SCHEDULED.
...
Changes should be made to both {{EagerSchedulingStrategy}} and
{{LazyFromSourcesSchedulingStrategy}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10238: [FLINK-8949] Add dedicated watermarks metric retrieval endpoint
flinkbot edited a comment on issue #10238: [FLINK-8949] Add dedicated watermarks metric retrieval endpoint URL: https://github.com/apache/flink/pull/10238#issuecomment-555064294 ## CI report: * a6c3b628841cead29b7c0e3d83bbf78c3a6b9170 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137021773) * d560fda578f0d6b39d0b98f76fc29ae23bb3303c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137439459) * 01eef68c10fab42e2b9aa58e596f96ab3be24fe6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137444516) * 61261b2065da9ebba0ce65f79f3cbbbcbd1913e9 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10222: [FLINK-14788][configuration] Add configure method to CheckpointConfig
flinkbot edited a comment on issue #10222: [FLINK-14788][configuration] Add configure method to CheckpointConfig URL: https://github.com/apache/flink/pull/10222#issuecomment-554372384 ## CI report: * a7a80b60af90a66251ef5772cc55cf15bd4df55e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136706389) * 3e71e5d0d4e9e45269daf5b84d150fc834d72e88 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137165728) * 093f2c258d91fde46890095d6e387e58f16d91c9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137417426) * 3fbe9290e858af9f46f489dd4cefdb7f329b05e0 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137573303) * 350a09dbf75971a75a788fb82777ef9eac7d91e9 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/137617394) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10284: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler
flinkbot edited a comment on issue #10284: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10284#issuecomment-557162273 ## CI report: * 55bb7f0c227441d894acdfdea48610e4ccdbf12c : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/137619209) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-14126) Elasticsearch Xpack Machine Learning doesn't support ARM
[ https://issues.apache.org/jira/browse/FLINK-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-14126. Fix Version/s: (was: 2.0.0) 1.10.0 Resolution: Fixed Merged on master in b290230662fa1aa38909aed40ac85eaf843e1d1c > Elasticsearch Xpack Machine Learning doesn't support ARM > > > Key: FLINK-14126 > URL: https://issues.apache.org/jira/browse/FLINK-14126 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.9.1 >Reporter: wangxiyuan >Assignee: wangxiyuan >Priority: Minor > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Elasticsearch Xpack Machine Learning function is enabled by default if the > version is >=6.0. But This feature doesn't support ARM arch. So that in some > e2e tests, Elasticsearch is failed to start. > We should disable ML feature in this case on ARM. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler
flinkbot edited a comment on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10283#issuecomment-55716 ## CI report: * 9bc37b6f7ab760f29d28c3cc9763a19de17fb484 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/137616270) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14126) Elasticsearch Xpack Machine Learning doesn't support ARM
[ https://issues.apache.org/jira/browse/FLINK-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14126: --- Labels: pull-request-available (was: ) > Elasticsearch Xpack Machine Learning doesn't support ARM > > > Key: FLINK-14126 > URL: https://issues.apache.org/jira/browse/FLINK-14126 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.9.1 >Reporter: wangxiyuan >Priority: Minor > Labels: pull-request-available > Fix For: 2.0.0 > > > Elasticsearch Xpack Machine Learning function is enabled by default if the > version is >=6.0. But This feature doesn't support ARM arch. So that in some > e2e tests, Elasticsearch is failed to start. > We should disable ML feature in this case on ARM. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FLINK-14126) Elasticsearch Xpack Machine Learning doesn't support ARM
[ https://issues.apache.org/jira/browse/FLINK-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-14126: Assignee: wangxiyuan > Elasticsearch Xpack Machine Learning doesn't support ARM > > > Key: FLINK-14126 > URL: https://issues.apache.org/jira/browse/FLINK-14126 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.9.1 >Reporter: wangxiyuan >Assignee: wangxiyuan >Priority: Minor > Labels: pull-request-available > Fix For: 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Elasticsearch Xpack Machine Learning function is enabled by default if the > version is >=6.0. But This feature doesn't support ARM arch. So that in some > e2e tests, Elasticsearch is failed to start. > We should disable ML feature in this case on ARM. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] aljoscha merged pull request #9765: [FLINK-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM
aljoscha merged pull request #9765: [FLINK-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM URL: https://github.com/apache/flink/pull/9765 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] aljoscha merged pull request #10012: [hotfix][typo] fix typo in ContaineredTaskManagerParameters
aljoscha merged pull request #10012: [hotfix][typo] fix typo in ContaineredTaskManagerParameters URL: https://github.com/apache/flink/pull/10012 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] aljoscha merged pull request #9989: [hotfix][docs] Delete useless annotation in NonWindowLeftRightJoinWithNonEquiPredicates
aljoscha merged pull request #9989: [hotfix][docs] Delete useless annotation in NonWindowLeftRightJoinWithNonEquiPredicates URL: https://github.com/apache/flink/pull/9989 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14908) Distributing CacheFiles through DFS does not work
[
https://issues.apache.org/jira/browse/FLINK-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979412#comment-16979412
]
Dawid Wysakowicz commented on FLINK-14908:
--
cc [~chesnay] [~trohrmann] Do you know if this is a bug or was it intentional?
> Distributing CacheFiles through DFS does not work
> -
>
> Key: FLINK-14908
> URL: https://issues.apache.org/jira/browse/FLINK-14908
> Project: Flink
> Issue Type: Bug
> Components: Client / Job Submission, Runtime / REST
>Affects Versions: 1.8.2, 1.9.1
>Reporter: Dawid Wysakowicz
>Priority: Major
>
> User reported that distributing cache files through DFS does not work
> anymore:
> https://stackoverflow.com/questions/58978476/flink-1-9-wont-run-program-when-i-use-distributed-cache-why
> I think the problematic part is in {{RestClusterClient#submitJob}}:
> {code}
> for (Map.Entry artifacts :
> jobGraph.getUserArtifacts().entrySet()) {
> artifactFileNames.add(new
> JobSubmitRequestBody.DistributedCacheFile(artifacts.getKey(), new
> Path(artifacts.getValue().filePath).getName()));
> filesToUpload.add(new
> FileUpload(Paths.get(artifacts.getValue().filePath),
> RestConstants.CONTENT_TYPE_BINARY));
> }
> {code}
> The code does not check if a file is in DFS, but just assumes it is in local
> FS and tries to add it to the rest request, which fails. The code on the
> receiver side in {{JobSubmitHandler}} still can support files distributed via
> DFS, but need to get proper paths to files in DFS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-14908) Distributing CacheFiles through DFS does not work
[
https://issues.apache.org/jira/browse/FLINK-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Wysakowicz updated FLINK-14908:
-
Description:
User reported that distributing cache files through DFS does not work anymore:
https://stackoverflow.com/questions/58978476/flink-1-9-wont-run-program-when-i-use-distributed-cache-why
I think the problematic part is in {{RestClusterClient#submitJob}}:
{code}
for (Map.Entry artifacts :
jobGraph.getUserArtifacts().entrySet()) {
artifactFileNames.add(new
JobSubmitRequestBody.DistributedCacheFile(artifacts.getKey(), new
Path(artifacts.getValue().filePath).getName()));
filesToUpload.add(new
FileUpload(Paths.get(artifacts.getValue().filePath),
RestConstants.CONTENT_TYPE_BINARY));
}
{code}
The code does not check if a file is in DFS, but just assumes it is in local FS
and tries to add it to the rest request, which fails. The code on the receiver
side in {{JobSubmitHandler}} still can support files distributed via DFS, but
need to get proper paths to files in DFS.
was:
User reported that distributing cache files through DFS does not work anymore:
https://stackoverflow.com/questions/58978476/flink-1-9-wont-run-program-when-i-use-distributed-cache-why
I think the problematic part is in {{RestClusterClient#submitJob}}:
{code}
for (Map.Entry artifacts :
jobGraph.getUserArtifacts().entrySet()) {
artifactFileNames.add(new
JobSubmitRequestBody.DistributedCacheFile(artifacts.getKey(), new
Path(artifacts.getValue().filePath).getName()));
filesToUpload.add(new
FileUpload(Paths.get(artifacts.getValue().filePath),
RestConstants.CONTENT_TYPE_BINARY));
}
{code}
The code does not check if a file is in DFS, but just assumes it is in local FS
and tries to add it to the rest request, which fails. The code on the receiver
side in {{JobSubmitHandler}} still can support files distributed via DFS, but
need to get proper paths to files in DFS.
> Distributing CacheFiles through DFS does not work
> -
>
> Key: FLINK-14908
> URL: https://issues.apache.org/jira/browse/FLINK-14908
> Project: Flink
> Issue Type: Bug
> Components: Client / Job Submission, Runtime / REST
>Affects Versions: 1.8.2, 1.9.1
>Reporter: Dawid Wysakowicz
>Priority: Major
>
> User reported that distributing cache files through DFS does not work
> anymore:
> https://stackoverflow.com/questions/58978476/flink-1-9-wont-run-program-when-i-use-distributed-cache-why
> I think the problematic part is in {{RestClusterClient#submitJob}}:
> {code}
> for (Map.Entry artifacts :
> jobGraph.getUserArtifacts().entrySet()) {
> artifactFileNames.add(new
> JobSubmitRequestBody.DistributedCacheFile(artifacts.getKey(), new
> Path(artifacts.getValue().filePath).getName()));
> filesToUpload.add(new
> FileUpload(Paths.get(artifacts.getValue().filePath),
> RestConstants.CONTENT_TYPE_BINARY));
> }
> {code}
> The code does not check if a file is in DFS, but just assumes it is in local
> FS and tries to add it to the rest request, which fails. The code on the
> receiver side in {{JobSubmitHandler}} still can support files distributed via
> DFS, but need to get proper paths to files in DFS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FLINK-14908) Distributing CacheFiles through DFS does not work
Dawid Wysakowicz created FLINK-14908:
Summary: Distributing CacheFiles through DFS does not work
Key: FLINK-14908
URL: https://issues.apache.org/jira/browse/FLINK-14908
Project: Flink
Issue Type: Bug
Components: Client / Job Submission, Runtime / REST
Affects Versions: 1.9.1, 1.8.2
Reporter: Dawid Wysakowicz
User reported that distributing cache files through DFS does not work anymore:
https://stackoverflow.com/questions/58978476/flink-1-9-wont-run-program-when-i-use-distributed-cache-why
I think the problematic part is in {{RestClusterClient#submitJob}}:
{code}
for (Map.Entry artifacts :
jobGraph.getUserArtifacts().entrySet()) {
artifactFileNames.add(new
JobSubmitRequestBody.DistributedCacheFile(artifacts.getKey(), new
Path(artifacts.getValue().filePath).getName()));
filesToUpload.add(new
FileUpload(Paths.get(artifacts.getValue().filePath),
RestConstants.CONTENT_TYPE_BINARY));
}
{code}
The code does not check if a file is in DFS, but just assumes it is in local FS
and tries to add it to the rest request, which fails. The code on the receiver
side in {{JobSubmitHandler}} still can support files distributed via DFS, but
need to get proper paths to files in DFS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] GJL commented on a change in pull request #10235: [FLINK-14839][config] Let JobGraph#classpaths become non-null
GJL commented on a change in pull request #10235: [FLINK-14839][config] Let
JobGraph#classpaths become non-null
URL: https://github.com/apache/flink/pull/10235#discussion_r349192762
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java
##
@@ -352,8 +353,8 @@ public JobVertex findVertexByID(JobVertexID id) {
*
* @param paths paths of the directories/JAR files required to run the
job on a task manager
*/
- public void setClasspaths(List paths) {
- classpaths = paths;
+ public void addClasspaths(Collection paths) {
+ classpaths.addAll(paths);
}
public List getClasspaths() {
Review comment:
Maybe we shouldn't allow modifications of this list from outside.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10235: [FLINK-14839][config] Let JobGraph#classpaths become non-null
GJL commented on a change in pull request #10235: [FLINK-14839][config] Let
JobGraph#classpaths become non-null
URL: https://github.com/apache/flink/pull/10235#discussion_r349193099
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java
##
@@ -352,8 +353,8 @@ public JobVertex findVertexByID(JobVertexID id) {
*
* @param paths paths of the directories/JAR files required to run the
job on a task manager
*/
- public void setClasspaths(List paths) {
- classpaths = paths;
+ public void addClasspaths(Collection paths) {
Review comment:
Are we actually invoking `addClasspaths` multiple times? It seems that the
changeset could be smaller by just adding a null check to the setter.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
