[GitHub] [flink] flinkbot edited a comment on pull request #12466: [FLINK-18042][build] Bump flink-shaded to 11.0

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12466: URL: https://github.com/apache/flink/pull/12466#issuecomment-638216146 ## CI report: * 4802492f361ec83ab165bb60d82ec381a678dcf6 Azure:

[GitHub] [flink] azagrebin commented on pull request #12446: [FLINK-16225] Implement user class loading exception handler

2020-06-03 Thread GitBox
azagrebin commented on pull request #12446: URL: https://github.com/apache/flink/pull/12446#issuecomment-638233219 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] dawidwys commented on a change in pull request #12410: [FLINK-13782][table-api] Implement type strategies for IF ELSE expression

2020-06-03 Thread GitBox
dawidwys commented on a change in pull request #12410: URL: https://github.com/apache/flink/pull/12410#discussion_r434619796 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/ExpressionBuilder.java ## @@ -90,9 +91,8

[GitHub] [flink] dawidwys commented on a change in pull request #12410: [FLINK-13782][table-api] Implement type strategies for IF ELSE expression

2020-06-03 Thread GitBox
dawidwys commented on a change in pull request #12410: URL: https://github.com/apache/flink/pull/12410#discussion_r434619796 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/ExpressionBuilder.java ## @@ -90,9 +91,8

[GitHub] [flink] flinkbot edited a comment on pull request #12467: [FLINK-16572] Clean up PubSub connector e2e test

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12467: URL: https://github.com/apache/flink/pull/12467#issuecomment-638229148 ## CI report: * 3fb13c034c2f456c6d77dfe0725efe2e2654c536 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12453: [FLINK-18061] [table] TableResult#collect method should return a closeable iterator to avoid resource leak

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12453: URL: https://github.com/apache/flink/pull/12453#issuecomment-637941328 ## CI report: * c2f3319900afad80a0f9fac5a8c9aa4cfdadd4ca Azure:

[GitHub] [flink] flinkbot commented on pull request #12468: [FLINK-18075] Wrap the SerializationSchema in KafkaSerializationSchema in Kafka connector

2020-06-03 Thread GitBox
flinkbot commented on pull request #12468: URL: https://github.com/apache/flink/pull/12468#issuecomment-638243685 ## CI report: * 4ae1da7c5aee0ff73e4461f0d9235dd60857f1d7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] rmetzger commented on pull request #12448: [FLINK-18051][AZP] Fail Maven setup stage on error

2020-06-03 Thread GitBox
rmetzger commented on pull request #12448: URL: https://github.com/apache/flink/pull/12448#issuecomment-638254394 Thanks for the review! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] rmetzger merged pull request #12448: [FLINK-18051][AZP] Fail Maven setup stage on error

2020-06-03 Thread GitBox
rmetzger merged pull request #12448: URL: https://github.com/apache/flink/pull/12448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] twalthr closed pull request #12411: [FLINK-18005][table] Implement type inference for CAST

2020-06-03 Thread GitBox
twalthr closed pull request #12411: URL: https://github.com/apache/flink/pull/12411 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Closed] (FLINK-13780) Introduce ExpressionConverter to legacy planner

2020-06-03 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13780. Resolution: Won't Fix Legacy planner is not maintained anymore. > Introduce ExpressionConverter

[GitHub] [flink] zhijiangW commented on pull request #12461: [FLINK-17994][checkpointing] Fix the race condition between CheckpointBarrierUnaligner#processBarrier and #notifyBarrierReceived

2020-06-03 Thread GitBox
zhijiangW commented on pull request #12461: URL: https://github.com/apache/flink/pull/12461#issuecomment-638275288 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot edited a comment on pull request #12469: [FLINK-17945][python] Improve the error message when instantiating non-existing Java class

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12469: URL: https://github.com/apache/flink/pull/12469#issuecomment-638272370 ## CI report: * de8a1c78fa5991e163b4e7e42da8bfe5294d0240 Azure:

[jira] [Comment Edited] (FLINK-17977) Check log sanity

2020-06-03 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124933#comment-17124933 ] Chesnay Schepler edited comment on FLINK-17977 at 6/3/20, 1:07 PM: ---

[GitHub] [flink] aljoscha closed pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated

2020-06-03 Thread GitBox
aljoscha closed pull request #12189: URL: https://github.com/apache/flink/pull/12189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] aljoscha commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated

2020-06-03 Thread GitBox
aljoscha commented on pull request #12189: URL: https://github.com/apache/flink/pull/12189#issuecomment-638184617 I've merged this on master and will also merge on release-1.11. Thanks @mghildiy for the initial work, and thanks @klion26 for reviewing!

[GitHub] [flink] pnowojski commented on a change in pull request #12353: [FLINK-17322][network] Fixes BroadcastRecordWriter overwriting memory segments on first finished BufferConsumer.

2020-06-03 Thread GitBox
pnowojski commented on a change in pull request #12353: URL: https://github.com/apache/flink/pull/12353#discussion_r434550118 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriter.java ## @@ -84,7 +86,7 @@ void

[GitHub] [flink] wuchong commented on pull request #12450: [FLINK-18075] Call open method of SerializationSchema in Kafka producer

2020-06-03 Thread GitBox
wuchong commented on pull request #12450: URL: https://github.com/apache/flink/pull/12450#issuecomment-638197634 Looks good to me too. I will merge this because the fix of FLINK-18073 also depends on this. This is

[jira] [Updated] (FLINK-18042) Bump flink-shaded version to 11.0

2020-06-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18042: --- Labels: pull-request-available (was: ) > Bump flink-shaded version to 11.0 >

[GitHub] [flink] azagrebin commented on pull request #12446: [FLINK-16225] Implement user class loading exception handler

2020-06-03 Thread GitBox
azagrebin commented on pull request #12446: URL: https://github.com/apache/flink/pull/12446#issuecomment-638240868 The failure, described in [FLINK-16917](https://issues.apache.org/jira/browse/FLINK-16917), may be related to thread un-safety of [inner class

[GitHub] [flink] azagrebin edited a comment on pull request #12446: [FLINK-16225] Implement user class loading exception handler

2020-06-03 Thread GitBox
azagrebin edited a comment on pull request #12446: URL: https://github.com/apache/flink/pull/12446#issuecomment-638240868 The failure, described in [FLINK-16917](https://issues.apache.org/jira/browse/FLINK-16917), may be related to thread un-safety of [inner class

[GitHub] [flink] dawidwys commented on a change in pull request #12410: [FLINK-13782][table-api] Implement type strategies for IF ELSE expression

2020-06-03 Thread GitBox
dawidwys commented on a change in pull request #12410: URL: https://github.com/apache/flink/pull/12410#discussion_r434643138 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SameArgumentsInputTypeStrategy.java ## @@

[GitHub] [flink] wanglijie95 commented on a change in pull request #12427: [FLINK-16681][jdbc] Fix the bug that jdbc lost connection after a lon…

2020-06-03 Thread GitBox
wanglijie95 commented on a change in pull request #12427: URL: https://github.com/apache/flink/pull/12427#discussion_r434643665 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/executor/InsertOrUpdateJdbcExecutor.java

[GitHub] [flink] wanglijie95 commented on a change in pull request #12427: [FLINK-16681][jdbc] Fix the bug that jdbc lost connection after a lon…

2020-06-03 Thread GitBox
wanglijie95 commented on a change in pull request #12427: URL: https://github.com/apache/flink/pull/12427#discussion_r434643665 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/executor/InsertOrUpdateJdbcExecutor.java

[GitHub] [flink] flinkbot edited a comment on pull request #12355: [FLINK-17893] [sql-client] SQL CLI should print the root cause if the statement is invalid

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12355: URL: https://github.com/apache/flink/pull/12355#issuecomment-634548726 ## CI report: * e733198f517f74de94d68622a3a039d3f888acaa Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12410: [FLINK-13782][table-api] Implement type strategies for IF ELSE expression

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12410: URL: https://github.com/apache/flink/pull/12410#issuecomment-635946149 ## CI report: * 05965a6250f3873dfccc7e226ffb64d40d3a599d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12461: [FLINK-17994][checkpointing] Fix the race condition between CheckpointBarrierUnaligner#processBarrier and #notifyBarrierReceived

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12461: URL: https://github.com/apache/flink/pull/12461#issuecomment-638102391 ## CI report: * 471535fc849c7dbf5bb9b532b5848a43ccdedafb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12462: [FLINK-18045] Fix Kerberos credentials checking

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12462: URL: https://github.com/apache/flink/pull/12462#issuecomment-638102486 ## CI report: * e5fa4096bd14b96de1cedffa35b74ac31a585f6e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12436: [FLINK-17847][table sql / planner] ArrayIndexOutOfBoundsException happens in StreamExecCalc operator

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12436: URL: https://github.com/apache/flink/pull/12436#issuecomment-637399261 ## CI report: * d553feca300e2668e3e5c16c1c524d73acde141c Azure:

[GitHub] [flink] flinkbot commented on pull request #12469: [FLINK-17945][python] Improve the error message when instantiating non-existing Java class

2020-06-03 Thread GitBox
flinkbot commented on pull request #12469: URL: https://github.com/apache/flink/pull/12469#issuecomment-638272370 ## CI report: * de8a1c78fa5991e163b4e7e42da8bfe5294d0240 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #12468: [FLINK-18075] Wrap the SerializationSchema in KafkaSerializationSchema in Kafka connector

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12468: URL: https://github.com/apache/flink/pull/12468#issuecomment-638243685 ## CI report: * 4ae1da7c5aee0ff73e4461f0d9235dd60857f1d7 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12435: [FLINK-18059] [sql-client] Fix create/drop catalog statement can not be executed in sql client

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12435: URL: https://github.com/apache/flink/pull/12435#issuecomment-637372360 ## CI report: * b5ef005c90fb95a63c97d06c488adf5e4abe2972 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12453: [FLINK-18061] [table] TableResult#collect method should return a closeable iterator to avoid resource leak

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12453: URL: https://github.com/apache/flink/pull/12453#issuecomment-637941328 ## CI report: * e56dc1fded374aadc639ec581e18bd410b77902a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12410: [FLINK-13782][table-api] Implement type strategies for IF ELSE expression

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12410: URL: https://github.com/apache/flink/pull/12410#issuecomment-635946149 ## CI report: * 05965a6250f3873dfccc7e226ffb64d40d3a599d Azure:

[GitHub] [flink] zhijiangW commented on a change in pull request #12460: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner

2020-06-03 Thread GitBox
zhijiangW commented on a change in pull request #12460: URL: https://github.com/apache/flink/pull/12460#discussion_r434676298 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java ## @@ -117,17 +117,6 @@

[GitHub] [flink] zhijiangW commented on a change in pull request #12460: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner

2020-06-03 Thread GitBox
zhijiangW commented on a change in pull request #12460: URL: https://github.com/apache/flink/pull/12460#discussion_r434686880 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java ## @@ -154,46 +154,51 @@ public

[jira] [Commented] (FLINK-17961) Create an Elasticsearch source

2020-06-03 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124918#comment-17124918 ] Aljoscha Krettek commented on FLINK-17961: -- I think that's a good idea, I see ES more as a

[GitHub] [flink] flinkbot edited a comment on pull request #12353: [FLINK-17322][network] Fixes BroadcastRecordWriter overwriting memory segments on first finished BufferConsumer.

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12353: URL: https://github.com/apache/flink/pull/12353#issuecomment-634518102 ## CI report: * a4b1247ea779353f476e4c70609094f367e7d06c Azure:

[GitHub] [flink] flinkbot commented on pull request #12467: [FLINK-16572] Clean up PubSub connector e2e test

2020-06-03 Thread GitBox
flinkbot commented on pull request #12467: URL: https://github.com/apache/flink/pull/12467#issuecomment-638210592 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] twalthr commented on a change in pull request #12411: [FLINK-18005][table] Implement type inference for CAST

2020-06-03 Thread GitBox
twalthr commented on a change in pull request #12411: URL: https://github.com/apache/flink/pull/12411#discussion_r434580727 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/CastInputTypeStrategy.java ## @@ -0,0 +1,85

[GitHub] [flink] dawidwys commented on pull request #12450: [FLINK-18075] Call open method of SerializationSchema in Kafka producer

2020-06-03 Thread GitBox
dawidwys commented on pull request #12450: URL: https://github.com/apache/flink/pull/12450#issuecomment-638210278 No worries, everything's fine. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] flinkbot commented on pull request #12467: [FLINK-16572] Clean up PubSub connector e2e test

2020-06-03 Thread GitBox
flinkbot commented on pull request #12467: URL: https://github.com/apache/flink/pull/12467#issuecomment-638229148 ## CI report: * 3fb13c034c2f456c6d77dfe0725efe2e2654c536 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #12465: [FLINK-18082][jdbc] UnsignedTypeConversionITCase stalls in ch.vorburer.mariadb4j.DB.stop

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12465: URL: https://github.com/apache/flink/pull/12465#issuecomment-638216011 ## CI report: * afb8eed935705a05bdac8e0d4c5f5036d4cdb03c Azure:

[GitHub] [flink] dawidwys closed pull request #12396: [FLINK-13782][table-api] Fix checking comparision of nested distinct/structured/raw types

2020-06-03 Thread GitBox
dawidwys closed pull request #12396: URL: https://github.com/apache/flink/pull/12396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] walterddr commented on a change in pull request #12462: [FLINK-18045] Fix Kerberos credentials checking

2020-06-03 Thread GitBox
walterddr commented on a change in pull request #12462: URL: https://github.com/apache/flink/pull/12462#discussion_r434627463 ## File path: flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/util/HadoopUtilsTest.java ## @@ -0,0 +1,49 @@ +/* + * Licensed

[jira] [Closed] (FLINK-17959) Exception: "CANCELLED: call already cancelled" is thrown when run python udf

2020-06-03 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-17959. --- Fix Version/s: 1.10.2 1.11.0 Resolution: Fixed master: 

[jira] [Comment Edited] (FLINK-17959) Exception: "CANCELLED: call already cancelled" is thrown when run python udf

2020-06-03 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125047#comment-17125047 ] Dian Fu edited comment on FLINK-17959 at 6/3/20, 3:18 PM: -- master: 

[GitHub] [flink] aljoscha closed pull request #12412: [FLINK-18011] Make WatermarkStrategy/WatermarkStrategies more ergonomic

2020-06-03 Thread GitBox
aljoscha closed pull request #12412: URL: https://github.com/apache/flink/pull/12412 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] aljoscha commented on pull request #12412: [FLINK-18011] Make WatermarkStrategy/WatermarkStrategies more ergonomic

2020-06-03 Thread GitBox
aljoscha commented on pull request #12412: URL: https://github.com/apache/flink/pull/12412#issuecomment-638275915 Thanks for the reviews! I'm merging This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] flinkbot edited a comment on pull request #12463: [FLINK-18087][yarn] Fix uploading user artifact for Yarn job cluster

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12463: URL: https://github.com/apache/flink/pull/12463#issuecomment-638148685 ## CI report: * 387c2f2cf3c3075a8aa97549cb71c9447386b4ef Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12410: [FLINK-13782][table-api] Implement type strategies for IF ELSE expression

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12410: URL: https://github.com/apache/flink/pull/12410#issuecomment-635946149 ## CI report: * ce34ce1e7b16cf8c6bf359ffadbf5d3e96613947 UNKNOWN * a08baf63b97b3773ffa41f204e2355aa9977a718 Azure:

[GitHub] [flink] krasinski commented on a change in pull request #12462: [FLINK-18045] Fix Kerberos credentials checking

2020-06-03 Thread GitBox
krasinski commented on a change in pull request #12462: URL: https://github.com/apache/flink/pull/12462#discussion_r434890904 ## File path: flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/util/HadoopUtilsTest.java ## @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] [flink] krasinski commented on a change in pull request #12462: [FLINK-18045] Fix Kerberos credentials checking

2020-06-03 Thread GitBox
krasinski commented on a change in pull request #12462: URL: https://github.com/apache/flink/pull/12462#discussion_r434890724 ## File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/util/HadoopUtils.java ## @@ -113,7 +113,8 @@ public static

[jira] [Created] (FLINK-18096) Generated avro formats should support user specified name and namespace

2020-06-03 Thread Seth Wiesman (Jira)
Seth Wiesman created FLINK-18096: Summary: Generated avro formats should support user specified name and namespace Key: FLINK-18096 URL: https://issues.apache.org/jira/browse/FLINK-18096 Project:

[GitHub] [flink] flinkbot edited a comment on pull request #12447: [FLINK-18069][CI] Test if Java/Scaladocs builds are passing in the compile stage

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12447: URL: https://github.com/apache/flink/pull/12447#issuecomment-637744551 ## CI report: * cc6305f57a1171863414ac5d61226d0875a5cdf4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12455: [FLINK-17935] Move setting yarn.log-config-file to YarnClusterClientFactory

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12455: URL: https://github.com/apache/flink/pull/12455#issuecomment-638007072 ## CI report: * bc3ca72ad94196d72570aa7a58e9aa5c411e2733 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12470: [FLINK-18074][checkpoint] Ensure task could fail when exception thrown out on notified of checkpoint completed/aborted

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12470: URL: https://github.com/apache/flink/pull/12470#issuecomment-638317405 ## CI report: * 67cbaa568c0df19f83943ed40ad98840e4584f9d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12455: [FLINK-17935] Move setting yarn.log-config-file to YarnClusterClientFactory

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12455: URL: https://github.com/apache/flink/pull/12455#issuecomment-638007072 ## CI report: * 5971c625f464a9843b57308688be8c6c8718b87c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12462: [FLINK-18045] Fix Kerberos credentials checking

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12462: URL: https://github.com/apache/flink/pull/12462#issuecomment-638102486 ## CI report: * e5fa4096bd14b96de1cedffa35b74ac31a585f6e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12455: [FLINK-17935] Move setting yarn.log-config-file to YarnClusterClientFactory

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12455: URL: https://github.com/apache/flink/pull/12455#issuecomment-638007072 ## CI report: * 7e9143f4531e9a7477a1e2848020d7c69644a3be Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12447: [FLINK-18069][CI] Test if Java/Scaladocs builds are passing in the compile stage

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12447: URL: https://github.com/apache/flink/pull/12447#issuecomment-637744551 ## CI report: * cc6305f57a1171863414ac5d61226d0875a5cdf4 Azure:

[jira] [Created] (FLINK-18097) History server doesn't clean all job json files

2020-06-03 Thread Milan Nikl (Jira)
Milan Nikl created FLINK-18097: -- Summary: History server doesn't clean all job json files Key: FLINK-18097 URL: https://issues.apache.org/jira/browse/FLINK-18097 Project: Flink Issue Type: Bug

[jira] [Comment Edited] (FLINK-10195) RabbitMQ Source With Checkpointing Doesn't Backpressure Correctly

2020-06-03 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121227#comment-17121227 ] Austin Cawley-Edwards edited comment on FLINK-10195 at 6/3/20, 10:29 PM:

[jira] [Updated] (FLINK-17969) Enhance Flink (Task) logging to include job name as context diagnostic information

2020-06-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17969: --- Labels: pull-request-available (was: ) > Enhance Flink (Task) logging to include job name

[GitHub] [flink] dasbh opened a new pull request #12472: FLINK-17969 Enhance Flink logging to include job name as MDC

2020-06-03 Thread GitBox
dasbh opened a new pull request #12472: URL: https://github.com/apache/flink/pull/12472 ## What is the purpose of the change * This pull request makes task instance to have jobName at the instance level and use the same for to populate MDC ## Problem statement: We use a

[GitHub] [flink] flinkbot edited a comment on pull request #12455: [FLINK-17935] Move setting yarn.log-config-file to YarnClusterClientFactory

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12455: URL: https://github.com/apache/flink/pull/12455#issuecomment-638007072 ## CI report: * 5971c625f464a9843b57308688be8c6c8718b87c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12455: [FLINK-17935] Move setting yarn.log-config-file to YarnClusterClientFactory

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12455: URL: https://github.com/apache/flink/pull/12455#issuecomment-638007072 ## CI report: * 5971c625f464a9843b57308688be8c6c8718b87c Azure:

[GitHub] [flink] HuangZhenQiu commented on a change in pull request #11541: [FLINK-15416][network] add task manager netty client retry mechenism

2020-06-03 Thread GitBox
HuangZhenQiu commented on a change in pull request #11541: URL: https://github.com/apache/flink/pull/11541#discussion_r434888634 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java ## @@ -130,6 +134,56 @@

[jira] [Commented] (FLINK-10195) RabbitMQ Source With Checkpointing Doesn't Backpressure Correctly

2020-06-03 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125362#comment-17125362 ] Austin Cawley-Edwards commented on FLINK-10195: --- Yes, that is correct, though I think it

[jira] [Comment Edited] (FLINK-10195) RabbitMQ Source With Checkpointing Doesn't Backpressure Correctly

2020-06-03 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125362#comment-17125362 ] Austin Cawley-Edwards edited comment on FLINK-10195 at 6/3/20, 10:27 PM:

[GitHub] [flink] krasinski commented on pull request #12462: [FLINK-18045] Fix Kerberos credentials checking

2020-06-03 Thread GitBox
krasinski commented on pull request #12462: URL: https://github.com/apache/flink/pull/12462#issuecomment-638494158 thank you for the review @walterddr, I've addressed all the comments and added some more unit tests I've also introduced a small change in `hasHDFSDelegationToken`

[GitHub] [flink] AHeise commented on a change in pull request #12457: [FLINK-18050][task][checkpointing] Fix double buffer recycling

2020-06-03 Thread GitBox
AHeise commented on a change in pull request #12457: URL: https://github.com/apache/flink/pull/12457#discussion_r434806438 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateCheckpointWriter.java ## @@ -108,32 +108,30 @@

[GitHub] [flink] flinkbot edited a comment on pull request #12447: [FLINK-18069][CI] Test if Java/Scaladocs builds are passing in the compile stage

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12447: URL: https://github.com/apache/flink/pull/12447#issuecomment-637744551 ## CI report: * a3b95a59180c019a5c34da7d5905502606f38121 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12455: [FLINK-17935] Move setting yarn.log-config-file to YarnClusterClientFactory

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12455: URL: https://github.com/apache/flink/pull/12455#issuecomment-638007072 ## CI report: * bc3ca72ad94196d72570aa7a58e9aa5c411e2733 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12462: [FLINK-18045] Fix Kerberos credentials checking

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12462: URL: https://github.com/apache/flink/pull/12462#issuecomment-638102486 ## CI report: * e5fa4096bd14b96de1cedffa35b74ac31a585f6e Azure:

[jira] [Comment Edited] (FLINK-10195) RabbitMQ Source With Checkpointing Doesn't Backpressure Correctly

2020-06-03 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125362#comment-17125362 ] Austin Cawley-Edwards edited comment on FLINK-10195 at 6/3/20, 11:15 PM:

[GitHub] [flink] flinkbot commented on pull request #12472: FLINK-17969 Enhance Flink logging to include job name as MDC

2020-06-03 Thread GitBox
flinkbot commented on pull request #12472: URL: https://github.com/apache/flink/pull/12472#issuecomment-638513120 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] zhuzhurk commented on a change in pull request #12375: [FLINK-17017][runtime] Implements bulk allocation for physical slots

2020-06-03 Thread GitBox
zhuzhurk commented on a change in pull request #12375: URL: https://github.com/apache/flink/pull/12375#discussion_r434987385 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/BulkSlotProviderImpl.java ## @@ -0,0 +1,271 @@ +/* + * Licensed

[GitHub] [flink] zhuzhurk commented on a change in pull request #12375: [FLINK-17017][runtime] Implements bulk allocation for physical slots

2020-06-03 Thread GitBox
zhuzhurk commented on a change in pull request #12375: URL: https://github.com/apache/flink/pull/12375#discussion_r434988361 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/BulkSlotProviderImpl.java ## @@ -0,0 +1,271 @@ +/* + * Licensed

[GitHub] [flink] wangyang0918 commented on pull request #12426: [FLINK-18048] Fix --host option for standalone application cluster

2020-06-03 Thread GitBox
wangyang0918 commented on pull request #12426: URL: https://github.com/apache/flink/pull/12426#issuecomment-638601537 cc @kl0u Although it is an old bug, it is related to application mode. Could you please have a look? I really hope it could be fixed in release-1.11 and backport to 1.10.

[GitHub] [flink] flinkbot edited a comment on pull request #11541: [FLINK-15416][network] add task manager netty client retry mechenism

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #11541: URL: https://github.com/apache/flink/pull/11541#issuecomment-604812212 ## CI report: * b5ef19285000d692d6b1b8b0aa7a37ce35c216f5 UNKNOWN * baf2c55f7bb0b9df7bdef94083c947693b75eae2 UNKNOWN *

[jira] [Commented] (FLINK-18069) Scaladocs not building since inner Java interfaces cannot be recognized

2020-06-03 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125544#comment-17125544 ] Tzu-Li (Gordon) Tai commented on FLINK-18069: - Merged Scaladoc fixes: master:

[GitHub] [flink] wangyang0918 commented on pull request #12455: [FLINK-17935] Move setting yarn.log-config-file to YarnClusterClientFactory

2020-06-03 Thread GitBox
wangyang0918 commented on pull request #12455: URL: https://github.com/apache/flink/pull/12455#issuecomment-638606572 @kl0u Thanks for addressing the comments. It looks really good to me. I have also verified it in a Yarn cluster. The log issue has been fixed. +1 for merging ```

[GitHub] [flink] wangyang0918 commented on a change in pull request #12444: [FLINK-18067]Change default value of yarnMinAllocationMB from zero to DEFAULT_RM_S…

2020-06-03 Thread GitBox
wangyang0918 commented on a change in pull request #12444: URL: https://github.com/apache/flink/pull/12444#discussion_r434997541 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java ## @@ -561,7 +565,6 @@ private ClusterSpecification

[jira] [Commented] (FLINK-14971) Make all the non-IO operations in CheckpointCoordinator single-threaded

2020-06-03 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125552#comment-17125552 ] Piotr Nowojski commented on FLINK-14971: Carrying the discussion over from FLINK-16770 {quote}

[GitHub] [flink] tzulitai commented on pull request #12443: [FLINK-18069] [scala, docs] Scaladocs 2.12 fails to recognize inner interfaces

2020-06-03 Thread GitBox
tzulitai commented on pull request #12443: URL: https://github.com/apache/flink/pull/12443#issuecomment-638601816 Thanks, merging ... This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (FLINK-18113) Single Task Failure Recovery API Abstraction

2020-06-03 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei updated FLINK-18113: - Description: Define API change need based on FLINK-18112 > Single Task Failure Recovery API Abstraction

[GitHub] [flink] flinkbot edited a comment on pull request #12426: [FLINK-18048] Fix --host option for standalone application cluster

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12426: URL: https://github.com/apache/flink/pull/12426#issuecomment-636791297 ## CI report: * 55800ba7a29a835c0aa956fe5469d191a0e27b5c Azure:

[GitHub] [flink] JingsongLi commented on pull request #12283: [FLINK-16975][documentation] Add docs for FileSystem connector

2020-06-03 Thread GitBox
JingsongLi commented on pull request #12283: URL: https://github.com/apache/flink/pull/12283#issuecomment-638616843 > One more suggestion is to explain how to write streaming data into non-partitioned table. Is it supported? And how to config the properties for such use cases. I'll

[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12144: URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376 ## CI report: * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN * 33b1ef0748285bc503363458a684ab237a64cd62 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #12444: [FLINK-18067]Change default value of yarnMinAllocationMB from zero to DEFAULT_RM_S…

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12444: URL: https://github.com/apache/flink/pull/12444#issuecomment-637596755 ## CI report: * 16ec8b694dc07564b09b60040d20b0da9c0e80c4 UNKNOWN * c23450c9e7735ca7bad0ff97c37480de6c420d0e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12460: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12460: URL: https://github.com/apache/flink/pull/12460#issuecomment-638102290 ## CI report: * c3f3aca669da2619d58190e684479c3fadd7026f Azure:

[GitHub] [flink] flinkbot commented on pull request #12476: [FLINK-17902][python] Support the new interfaces about temporary functions in PyFlink

2020-06-03 Thread GitBox
flinkbot commented on pull request #12476: URL: https://github.com/apache/flink/pull/12476#issuecomment-638616517 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Created] (FLINK-18114) Expose more details in logs for debugging bulk slot allocation failures

2020-06-03 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-18114: --- Summary: Expose more details in logs for debugging bulk slot allocation failures Key: FLINK-18114 URL: https://issues.apache.org/jira/browse/FLINK-18114 Project: Flink

[GitHub] [flink] wangyang0918 removed a comment on pull request #12426: [FLINK-18048] Fix --host option for standalone application cluster

2020-06-03 Thread GitBox
wangyang0918 removed a comment on pull request #12426: URL: https://github.com/apache/flink/pull/12426#issuecomment-636782809 cc @tillrohrmann since this issue is introduced via commit 9c4c138a2db7ab84733482d9ba9508b30056843d, would you please have a look?

[GitHub] [flink] tzulitai commented on pull request #12447: [FLINK-18069][CI] Test if Java/Scaladocs builds are passing in the compile stage

2020-06-03 Thread GitBox
tzulitai commented on pull request #12447: URL: https://github.com/apache/flink/pull/12447#issuecomment-638603704 +1, LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot edited a comment on pull request #12471: [FLINK-18073][FLINK-18029][avro] Fix AvroRowDataSerializationSchema is not serializable and add IT cases

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12471: URL: https://github.com/apache/flink/pull/12471#issuecomment-638362836 ## CI report: * 9b56e7e1ac798b72018a82acae78d07eddc2f860 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12475: [FLINK-18076][table sql / client] Sql client uses wrong class loader when parsing queries

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12475: URL: https://github.com/apache/flink/pull/12475#issuecomment-638593958 ## CI report: * 41240cd524255ffc7cf63d2bc2ee9ff38f3abcbd UNKNOWN * fda75fa6db31dc6cc66f5b4fa7f86db3d4e26356 UNKNOWN Bot commands The

[GitHub] [flink] flinkbot edited a comment on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState

2020-06-03 Thread GitBox
flinkbot edited a comment on pull request #12441: URL: https://github.com/apache/flink/pull/12441#issuecomment-637524540 ## CI report: * c5e43a378abf5461fb7b94ca77abe792f1fad661 Azure:

[jira] [Commented] (FLINK-18018) Bundle GPU plugin in "plugins/" directory

2020-06-03 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125550#comment-17125550 ] Yangze Guo commented on FLINK-18018: cc [~chesnay] > Bundle GPU plugin in "plugins/" directory >

<    1   2   3   4   5   6   7   8   >