[GitHub] [flink] flinkbot edited a comment on pull request #17509: [FLINK-24501][table-runtime] Stores window progress into state in order to check whether an input element is late or not for window-t

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17509: URL: https://github.com/apache/flink/pull/17509#issuecomment-945571594 ## CI report: * 3ccb32e9c58a2d5181b982c463afabe4b37193bf Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure:

[GitHub] [flink] PatrickRen commented on pull request #17401: [FLINK-24409][connectors] Fix metrics errors with topics names with periods

2021-10-19 Thread GitBox
PatrickRen commented on pull request #17401: URL: https://github.com/apache/flink/pull/17401#issuecomment-946442553 Sorry for my late response! @jherico Here's my implementation of the test case that might be helpful. Feel free to cherry-pick it or implement your own.

[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17481: URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916 ## CI report: * 9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17481: URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916 ## CI report: * 9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57 Azure:

[jira] [Commented] (FLINK-24580) Kinesis connect time out error is not handled as recoverable

2021-10-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430364#comment-17430364 ] Martijn Visser commented on FLINK-24580: [~dannycranmer] Any thoughts on this one? > Kinesis

[jira] [Created] (FLINK-24586) SQL functions should return STRING instead of VARCHAR(2000)

2021-10-19 Thread Jira
Ingo Bürk created FLINK-24586: - Summary: SQL functions should return STRING instead of VARCHAR(2000) Key: FLINK-24586 URL: https://issues.apache.org/jira/browse/FLINK-24586 Project: Flink Issue

[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure:

[GitHub] [flink] dawidwys commented on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

2021-10-19 Thread GitBox
dawidwys commented on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-946436144 Looking at the test results it seems to be working just fine (e2e failure unrelated). How do you feel about the solution @akalash ? If you see no obstacles, I'd suggest

[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.

2021-10-19 Thread GitBox
Airblader commented on a change in pull request #17481: URL: https://github.com/apache/flink/pull/17481#discussion_r731567311 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java ## @@ -1145,6

[jira] [Comment Edited] (FLINK-24489) The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache

2021-10-19 Thread Yuepeng Pan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17429565#comment-17429565 ] Yuepeng Pan edited comment on FLINK-24489 at 10/19/21, 7:23 AM: Hi,

[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure:

[jira] [Assigned] (FLINK-23647) UnalignedCheckpointStressITCase crashed on azure

2021-10-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-23647: -- Assignee: Piotr Nowojski > UnalignedCheckpointStressITCase crashed on azure >

[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure:

[jira] [Comment Edited] (FLINK-24384) Count checkpoints failed in trigger phase into numberOfFailedCheckpoints

2021-10-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430355#comment-17430355 ] Piotr Nowojski edited comment on FLINK-24384 at 10/19/21, 7:10 AM: ---

[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure:

[jira] [Commented] (FLINK-24384) Count checkpoints failed in trigger phase into numberOfFailedCheckpoints

2021-10-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430355#comment-17430355 ] Piotr Nowojski commented on FLINK-24384: Are you sure [~Feifan Wang] this is not just a

[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * e78df5a2a0572a2cfe043bf7737f1e52fe9f89af Azure:

[GitHub] [flink] slinkydeveloper commented on pull request #17513: [FLINK-24579][table-api][sql-client] Support toString for arrays as c…

2021-10-19 Thread GitBox
slinkydeveloper commented on pull request #17513: URL: https://github.com/apache/flink/pull/17513#issuecomment-946424650 Hi! Thanks for the PR but we are already extensively reworking the `PrintUtils` class to unify the code with the casting provided by the runtime, here are the details:

[GitHub] [flink] flinkbot edited a comment on pull request #17515: [FLINK-24575][table-runtime] Migrate TestRowDataCsvInputFormat to DeserializationSchemaFactory

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17515: URL: https://github.com/apache/flink/pull/17515#issuecomment-946422818 ## CI report: * e9ddaedd9e89fe2efcee26e27c54f53690bb5eb4 Azure:

[GitHub] [flink] flinkbot commented on pull request #17515: [FLINK-24575][table-runtime] Migrate TestRowDataCsvInputFormat to DeserializationSchemaFactory

2021-10-19 Thread GitBox
flinkbot commented on pull request #17515: URL: https://github.com/apache/flink/pull/17515#issuecomment-946423140 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Comment Edited] (FLINK-24401) TM cannot exit after Metaspace OOM

2021-10-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430011#comment-17430011 ] Piotr Nowojski edited comment on FLINK-24401 at 10/19/21, 7:02 AM: ---

[GitHub] [flink] flinkbot commented on pull request #17515: [FLINK-24575][table-runtime] Migrate TestRowDataCsvInputFormat to DeserializationSchemaFactory

2021-10-19 Thread GitBox
flinkbot commented on pull request #17515: URL: https://github.com/apache/flink/pull/17515#issuecomment-946422818 ## CI report: * e9ddaedd9e89fe2efcee26e27c54f53690bb5eb4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Updated] (FLINK-24575) Port TestCsvFileSystemFormatFactory to DeserializationSchema

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24575: --- Labels: pull-request-available (was: ) > Port TestCsvFileSystemFormatFactory to

[jira] [Updated] (FLINK-24351) translate "JSON Function" pages into Chinese

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24351: --- Labels: pull-request-available (was: ) > translate "JSON Function" pages into Chinese >

[GitHub] [flink] slinkydeveloper opened a new pull request #17515: [FLINK-24575][table-runtime] Migrate TestRowDataCsvInputFormat to DeserializationSchemaFactory

2021-10-19 Thread GitBox
slinkydeveloper opened a new pull request #17515: URL: https://github.com/apache/flink/pull/17515 Signed-off-by: slinkydeveloper ## What is the purpose of the change This PR ports `TestRowDataCsvInputFormat` to `DeserializationSchemaFactory`, part of the effort

[GitHub] [flink] wuchong commented on pull request #17508: [FLINK-24351][docs] Translate "JSON Function" pages into Chinese

2021-10-19 Thread GitBox
wuchong commented on pull request #17508: URL: https://github.com/apache/flink/pull/17508#issuecomment-946421367 @RocMarshal , could you help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] wuchong commented on a change in pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-19 Thread GitBox
wuchong commented on a change in pull request #17352: URL: https://github.com/apache/flink/pull/17352#discussion_r731546539 ## File path: docs/content/docs/dev/table/sql/show.md ## @@ -341,6 +354,11 @@ table_env.execute_sql("SHOW VIEWS").print() # | my_view | #

[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.

2021-10-19 Thread GitBox
Airblader commented on a change in pull request #17481: URL: https://github.com/apache/flink/pull/17481#discussion_r731548152 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java ## @@ -1145,6

[GitHub] [flink] curcur commented on a change in pull request #16606: [FLINK-21357][runtime/statebackend]Periodic materialization for generalized incremental checkpoints

2021-10-19 Thread GitBox
curcur commented on a change in pull request #16606: URL: https://github.com/apache/flink/pull/16606#discussion_r731545636 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java ## @@

[GitHub] [flink] curcur commented on a change in pull request #16606: [FLINK-21357][runtime/statebackend]Periodic materialization for generalized incremental checkpoints

2021-10-19 Thread GitBox
curcur commented on a change in pull request #16606: URL: https://github.com/apache/flink/pull/16606#discussion_r731545636 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java ## @@

[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.

2021-10-19 Thread GitBox
Airblader commented on a change in pull request #17481: URL: https://github.com/apache/flink/pull/17481#discussion_r731542432 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java ## @@ -1145,6

[jira] [Closed] (FLINK-24564) Change the default compression to snappy for parquet, avro in table

2021-10-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-24564. Resolution: Fixed master: f75cf38e28143bb36acbc2ee6a5ea9c8852916dd > Change the default

[jira] [Updated] (FLINK-24564) Change the default compression to snappy for parquet, avro in table

2021-10-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-24564: - Summary: Change the default compression to snappy for parquet, avro in table (was: Change the

[GitHub] [flink] JingsongLi merged pull request #17500: [FLINK-24564][formats] Change the default compression to snappy for parquet, orc, avro in table

2021-10-19 Thread GitBox
JingsongLi merged pull request #17500: URL: https://github.com/apache/flink/pull/17500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17500: [FLINK-24564][formats] Change the default compression to snappy for parquet, orc, avro in table

2021-10-19 Thread GitBox
flinkbot edited a comment on pull request #17500: URL: https://github.com/apache/flink/pull/17500#issuecomment-944278328 ## CI report: * 0a53a4e8ac2ded109be29135846f25a1a251631c Azure:

[GitHub] [flink-ml] gaoyunhaii commented on a change in pull request #17: [FLINK-10][iteration] Support the checkpoints for the iteration.

2021-10-19 Thread GitBox
gaoyunhaii commented on a change in pull request #17: URL: https://github.com/apache/flink-ml/pull/17#discussion_r731534576 ## File path: flink-ml-iteration/src/main/java/org/apache/flink/ml/iteration/operator/HeadOperator.java ## @@ -129,12 +168,89 @@ public void setup(

[jira] [Commented] (FLINK-24384) Count checkpoints failed in trigger phase into numberOfFailedCheckpoints

2021-10-19 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430327#comment-17430327 ] Feifan Wang commented on FLINK-24384: - Hi [~pnowojski], sorry for late reply, I just read

[jira] [Assigned] (FLINK-24585) Print the change in the size of the compacted files

2021-10-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-24585: Assignee: Yubin Li > Print the change in the size of the compacted files >

[GitHub] [flink] Myasuka commented on a change in pull request #17482: [FLINK-24546][docs]fix miss Acknowledged description on Monitoring Ch…

2021-10-19 Thread GitBox
Myasuka commented on a change in pull request #17482: URL: https://github.com/apache/flink/pull/17482#discussion_r731532608 ## File path: docs/content/docs/ops/monitoring/checkpoint_monitoring.md ## @@ -60,6 +60,7 @@ Note that for failed checkpoints, metrics are updated on a

[jira] [Commented] (FLINK-24585) Print the change in the size of the compacted files

2021-10-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430325#comment-17430325 ] Jingsong Lee commented on FLINK-24585: -- Assigned to u [~liyubin117] > Print the change in the size

[jira] [Created] (FLINK-24585) Print the change in the size of the compacted files

2021-10-19 Thread Yubin Li (Jira)
Yubin Li created FLINK-24585: Summary: Print the change in the size of the compacted files Key: FLINK-24585 URL: https://issues.apache.org/jira/browse/FLINK-24585 Project: Flink Issue Type:

<    1   2   3   4