[GitHub] [flink] flinkbot commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-04 Thread GitBox
flinkbot commented on pull request #17672: URL: https://github.com/apache/flink/pull/17672#issuecomment-960546911 ## CI report: * 68457d5d2df6b5265fd280cd0d6d81a17ca9b05c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17668: [FLINK-24401][runtime] Fix the bug of TM cannot exit after Metaspace OOM

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17668: URL: https://github.com/apache/flink/pull/17668#issuecomment-960521098 ## CI report: * daf34569f403cfe2a87b0f117a0a97d2653cdd1c Azure:

[GitHub] [flink] Tartarus0zm commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-04 Thread GitBox
Tartarus0zm commented on pull request #17672: URL: https://github.com/apache/flink/pull/17672#issuecomment-960546440 @JingsongLi @wuchong If you have time, please take a look, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] flinkbot edited a comment on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-959311032 ## CI report: * 5379526a2cdfe6087625e1bfcba913c818f3c732 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17642: [hotfix][table-common] Add `DataType#excludeFields`

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17642: URL: https://github.com/apache/flink/pull/17642#issuecomment-957339647 ## CI report: * c85a0c22da8d2e8e9e28cda3a182c5ac16a220be Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] KurtYoung commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-04 Thread GitBox
KurtYoung commented on pull request #17672: URL: https://github.com/apache/flink/pull/17672#issuecomment-960546096 could you add a test case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17525: URL: https://github.com/apache/flink/pull/17525#issuecomment-947380227 ## CI report: * 3a3ce88a936a7354d4f53add622010a4e27a89a1 Azure:

[GitHub] [flink] mayuehappy commented on a change in pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data

2021-11-04 Thread GitBox
mayuehappy commented on a change in pull request #17525: URL: https://github.com/apache/flink/pull/17525#discussion_r742619974 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java ## @@ -460,22 +461,66 @@ public void

[GitHub] [flink] zentol merged pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-04 Thread GitBox
zentol merged pull request #17606: URL: https://github.com/apache/flink/pull/17606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-24761) Fix PartitionPruner code gen compile fail

2021-11-04 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438551#comment-17438551 ] Caizhi Weng commented on FLINK-24761: - Thanks for raising this issue [~tartarus] and a nice catch!

[jira] [Updated] (FLINK-24761) Fix PartitionPruner code gen compile fail

2021-11-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24761: --- Labels: pull-request-available (was: ) > Fix PartitionPruner code gen compile fail >

[jira] [Commented] (FLINK-24758) filesystem sink: partition.time-extractor.kind support "yyyyMMdd"

2021-11-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438549#comment-17438549 ] Martijn Visser commented on FLINK-24758: Hi [~lzljs3620320] would it make sense to make this

[GitHub] [flink] Tartarus0zm opened a new pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-04 Thread GitBox
Tartarus0zm opened a new pull request #17672: URL: https://github.com/apache/flink/pull/17672 ## What is the purpose of the change Solve the problem of compile fail of PartitionPruner generated code due to classloader error. ## Brief change log Change `PartitionPruner`

[jira] [Updated] (FLINK-24749) Reuse CheckpointStatsTracker across rescaling

2021-11-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24749: --- Labels: pull-request-available (was: ) > Reuse CheckpointStatsTracker across rescaling >

[GitHub] [flink] zentol opened a new pull request #17671: [FLINK-24749][coordination] Reuse CheckpointStatsTracker

2021-11-04 Thread GitBox
zentol opened a new pull request #17671: URL: https://github.com/apache/flink/pull/17671 Based on #17659. The AdaptiveScheduler now reuses the CheckpointStatsTracker for each ExecutionGraph created during rescaling. This resolves the issue of metric collisions as they are now only

[GitHub] [flink] flinkbot edited a comment on pull request #17669: [FLINK-24762][table-runtime] Remove agg function: INCR_SUM

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17669: URL: https://github.com/apache/flink/pull/17669#issuecomment-960539323 ## CI report: * c484eb521588d5812ba1dbcd19cf10551c5a14bd Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-959311032 ## CI report: * 5379526a2cdfe6087625e1bfcba913c818f3c732 Azure:

[jira] [Updated] (FLINK-24761) Fix PartitionPruner code gen compile fail

2021-11-04 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-24761: Component/s: Table SQL / Planner > Fix PartitionPruner code gen compile fail >

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17668: [FLINK-24401][runtime] Fix the bug of TM cannot exit after Metaspace OOM

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17668: URL: https://github.com/apache/flink/pull/17668#issuecomment-960521098 ## CI report: * daf34569f403cfe2a87b0f117a0a97d2653cdd1c Azure:

[jira] [Updated] (FLINK-24761) Fix PartitionPruner code gen compile fail

2021-11-04 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-24761: Component/s: (was: Table SQL / Planner) Table SQL / Runtime > Fix

[jira] [Commented] (FLINK-24755) sun.misc doesn't exist

2021-11-04 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438544#comment-17438544 ] Chesnay Schepler commented on FLINK-24755: -- > can we support jdk11 bytecode default No. We had

[GitHub] [flink] twalthr commented on a change in pull request #17642: [hotfix][table-common] Add `DataType#excludeFields`

2021-11-04 Thread GitBox
twalthr commented on a change in pull request #17642: URL: https://github.com/apache/flink/pull/17642#discussion_r742614948 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/DataType.java ## @@ -215,6 +217,28 @@ public static DataType

[jira] [Commented] (FLINK-24761) Fix PartitionPruner code gen compile fail

2021-11-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438543#comment-17438543 ] Martijn Visser commented on FLINK-24761: [~agen-taruhan-bola] I've assigned it to you > Fix

[GitHub] [flink] flinkbot commented on pull request #17670: [FLINK-24760][docs] Update user document for batch window tvf

2021-11-04 Thread GitBox
flinkbot commented on pull request #17670: URL: https://github.com/apache/flink/pull/17670#issuecomment-960540647 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Assigned] (FLINK-24761) Fix PartitionPruner code gen compile fail

2021-11-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-24761: -- Assignee: tartarus > Fix PartitionPruner code gen compile fail >

[GitHub] [flink] tsreaper commented on a change in pull request #17634: [FLINK-24691][table-common] Fix precision for sum on decimal types

2021-11-04 Thread GitBox
tsreaper commented on a change in pull request #17634: URL: https://github.com/apache/flink/pull/17634#discussion_r742597700 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeMerging.java ## @@ -294,26 +294,42 @@

[GitHub] [flink] flinkbot commented on pull request #17670: [FLINK-24760][docs] Update user document for batch window tvf

2021-11-04 Thread GitBox
flinkbot commented on pull request #17670: URL: https://github.com/apache/flink/pull/17670#issuecomment-960539433 ## CI report: * dde91e1cf145a36e329a88159e53eac00b453d6c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #17669: [FLINK-24762][table-runtime] Remove agg function: INCR_SUM

2021-11-04 Thread GitBox
flinkbot commented on pull request #17669: URL: https://github.com/apache/flink/pull/17669#issuecomment-960539323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17668: [FLINK-24401][runtime] Fix the bug of TM cannot exit after Metaspace OOM

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17668: URL: https://github.com/apache/flink/pull/17668#issuecomment-960521098 ## CI report: * daf34569f403cfe2a87b0f117a0a97d2653cdd1c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[jira] [Commented] (FLINK-16833) Make JDBCDialect pluggable for JDBC SQL connector

2021-11-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438539#comment-17438539 ] Martijn Visser commented on FLINK-16833: [~wanglijie95] No problem! Would you be open to

[jira] [Updated] (FLINK-24760) Update user document for batch window tvf

2021-11-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24760: --- Labels: pull-request-available (was: ) > Update user document for batch window tvf >

[jira] [Comment Edited] (FLINK-16833) Make JDBCDialect pluggable for JDBC SQL connector

2021-11-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438539#comment-17438539 ] Martijn Visser edited comment on FLINK-16833 at 11/4/21, 8:12 AM: --

[GitHub] [flink] beyond1920 opened a new pull request #17670: [FLINK-24760][docs] Update user document for batch window tvf

2021-11-04 Thread GitBox
beyond1920 opened a new pull request #17670: URL: https://github.com/apache/flink/pull/17670 ## What is the purpose of the change The pr adds documentation for Window deduplication. ## Brief change log - Window-agg.md - Window-join.md - Window-topn.md -

[jira] [Updated] (FLINK-24762) Remove agg function: INCR_SUM

2021-11-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24762: --- Labels: pull-request-available (was: ) > Remove agg function: INCR_SUM >

[GitHub] [flink] cshuo opened a new pull request #17669: [FLINK-24762][table-runtime] Remove agg function: INCR_SUM

2021-11-04 Thread GitBox
cshuo opened a new pull request #17669: URL: https://github.com/apache/flink/pull/17669 ## What is the purpose of the change The removal of INCR_SUM should be completed in FLINK-13529, but that PR only removes function definition of INCR_SUM. This PR will complete the

[GitHub] [flink] flinkbot edited a comment on pull request #17668: [FLINK-24401][runtime] Fix the bug of TM cannot exit after Metaspace OOM

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17668: URL: https://github.com/apache/flink/pull/17668#issuecomment-960521098 ## CI report: * daf34569f403cfe2a87b0f117a0a97d2653cdd1c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] twalthr edited a comment on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-04 Thread GitBox
twalthr edited a comment on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-960534972 I agree with @Airblader. We should aim to not break existing connector implementations. We have received a lot negative feedback recently and should pay more attention.

[GitHub] [flink] twalthr commented on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-04 Thread GitBox
twalthr commented on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-960534972 I agree with @Airblader. We should aim to not break existing connector implementations. We have received a lot negative feedback recently and should pay more attention. --

[GitHub] [flink] flinkbot edited a comment on pull request #17668: [FLINK-24401][runtime] Fix the bug of TM cannot exit after Metaspace OOM

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17668: URL: https://github.com/apache/flink/pull/17668#issuecomment-960521098 ## CI report: * daf34569f403cfe2a87b0f117a0a97d2653cdd1c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[jira] [Created] (FLINK-24762) Remove agg function: INCR_SUM

2021-11-04 Thread Shuo Cheng (Jira)
Shuo Cheng created FLINK-24762: -- Summary: Remove agg function: INCR_SUM Key: FLINK-24762 URL: https://issues.apache.org/jira/browse/FLINK-24762 Project: Flink Issue Type: Improvement

[GitHub] [flink] slinkydeveloper commented on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-04 Thread GitBox
slinkydeveloper commented on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-960531015 @Airblader I can try, but it requires to default implement both methods, eg: ``` Index:

[jira] [Commented] (FLINK-24761) Fix PartitionPruner code gen compile fail

2021-11-04 Thread tartarus (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438532#comment-17438532 ] tartarus commented on FLINK-24761: -- [~jark] Please assign this jira to me, thanks > Fix

[jira] [Commented] (FLINK-24046) Refactor the relationship bwtween PredefinedOptions and RocksDBConfigurableOptions

2021-11-04 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438531#comment-17438531 ] Zakelly Lan commented on FLINK-24046: - I'm going to fix it this way: # Provide a default value for

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * e9e7c13e49a07f2e8a2185db90ad4d95741beb87 Azure:

[jira] [Created] (FLINK-24761) Fix PartitionPruner code gen compile fail

2021-11-04 Thread tartarus (Jira)
tartarus created FLINK-24761: Summary: Fix PartitionPruner code gen compile fail Key: FLINK-24761 URL: https://issues.apache.org/jira/browse/FLINK-24761 Project: Flink Issue Type: Bug

[GitHub] [flink] Airblader commented on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-04 Thread GitBox
Airblader commented on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-960526716 Can we not actually avoid the breaking change? If we add an overloaded method with the argument and default-implement it to just call the existing method, it wouldn't be

[GitHub] [flink] flinkbot edited a comment on pull request #17668: [FLINK-24401][runtime] Fix the bug of TM cannot exit after Metaspace OOM

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17668: URL: https://github.com/apache/flink/pull/17668#issuecomment-960521098 ## CI report: * daf34569f403cfe2a87b0f117a0a97d2653cdd1c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * e9e7c13e49a07f2e8a2185db90ad4d95741beb87 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17509: [FLINK-24501][table-runtime] Stores window progress into state in order to check whether an input element is late or not for window-t

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17509: URL: https://github.com/apache/flink/pull/17509#issuecomment-945571594 ## CI report: * 8b65b50eef16fd8d0f54ed64594d4d1fb3aaf4d2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #15229: URL: https://github.com/apache/flink/pull/15229#issuecomment-82978 ## CI report: * 0ea0f1c618e3aacebe31cbff9bfb4c74b3d5bb39 Azure:

[GitHub] [flink] slinkydeveloper edited a comment on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-04 Thread GitBox
slinkydeveloper edited a comment on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-960525112 @Airblader I'm sorry, you're right, I've updated the description -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] slinkydeveloper commented on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-04 Thread GitBox
slinkydeveloper commented on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-960525112 @Airblader I'm sorry, you're right -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] Myasuka commented on a change in pull request #16582: [FLINK-21504][checkpoint] Introduce notification of subsumed checkpoint

2021-11-04 Thread GitBox
Myasuka commented on a change in pull request #16582: URL: https://github.com/apache/flink/pull/16582#discussion_r742598674 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointSubsumeHelper.java ## @@ -46,18 +48,24 @@ class

[GitHub] [flink] zhuzhurk commented on a change in pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-11-04 Thread GitBox
zhuzhurk commented on a change in pull request #15229: URL: https://github.com/apache/flink/pull/15229#discussion_r742598599 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultSchedulerComponents.java ## @@ -124,9 +126,19 @@ private static

[GitHub] [flink] zhuzhurk commented on a change in pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-11-04 Thread GitBox
zhuzhurk commented on a change in pull request #15229: URL: https://github.com/apache/flink/pull/15229#discussion_r742598366 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionSlotAllocationContext.java ## @@ -67,4 +68,14 @@ * @return

[GitHub] [flink] Myasuka commented on a change in pull request #16582: [FLINK-21504][checkpoint] Introduce notification of subsumed checkpoint

2021-11-04 Thread GitBox
Myasuka commented on a change in pull request #16582: URL: https://github.com/apache/flink/pull/16582#discussion_r742598361 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointSubsumeHelper.java ## @@ -67,6 +75,7 @@ public static void

[GitHub] [flink] zhuzhurk commented on a change in pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-11-04 Thread GitBox
zhuzhurk commented on a change in pull request #15229: URL: https://github.com/apache/flink/pull/15229#discussion_r742598202 ## File path: flink-tests/src/test/java/org/apache/flink/test/runtime/SchedulingLocalRecoveryITCase.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the

[GitHub] [flink] flinkbot edited a comment on pull request #17668: [FLINK-24401][runtime] Fix the bug of TM cannot exit after Metaspace OOM

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17668: URL: https://github.com/apache/flink/pull/17668#issuecomment-960521098 ## CI report: * daf34569f403cfe2a87b0f117a0a97d2653cdd1c Azure:

[GitHub] [flink] zhuzhurk commented on a change in pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-11-04 Thread GitBox
zhuzhurk commented on a change in pull request #15229: URL: https://github.com/apache/flink/pull/15229#discussion_r742598039 ## File path: flink-tests/src/test/java/org/apache/flink/test/runtime/SchedulingLocalRecoveryITCase.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17509: [FLINK-24501][table-runtime] Stores window progress into state in order to check whether an input element is late or not for window-t

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17509: URL: https://github.com/apache/flink/pull/17509#issuecomment-945571594 ## CI report: * 8b65b50eef16fd8d0f54ed64594d4d1fb3aaf4d2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #15229: URL: https://github.com/apache/flink/pull/15229#issuecomment-82978 ## CI report: * 0ea0f1c618e3aacebe31cbff9bfb4c74b3d5bb39 Azure:

[GitHub] [flink] zhuzhurk commented on a change in pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-11-04 Thread GitBox
zhuzhurk commented on a change in pull request #15229: URL: https://github.com/apache/flink/pull/15229#discussion_r742597590 ## File path: flink-tests/src/test/java/org/apache/flink/test/runtime/SchedulingLocalRecoveryITCase.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the

[GitHub] [flink] zhuzhurk commented on a change in pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-11-04 Thread GitBox
zhuzhurk commented on a change in pull request #15229: URL: https://github.com/apache/flink/pull/15229#discussion_r742597499 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java ## @@ -204,6 +212,10 @@ protected void

[GitHub] [flink] zhuzhurk commented on a change in pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-11-04 Thread GitBox
zhuzhurk commented on a change in pull request #15229: URL: https://github.com/apache/flink/pull/15229#discussion_r742597419 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java ## @@ -204,6 +212,10 @@ protected void

[GitHub] [flink] akalash commented on pull request #17621: [FLINK-24551][runtime] Read BUFFER_DEBLOAT_SAMPLES from task manager …

2021-11-04 Thread GitBox
akalash commented on pull request #17621: URL: https://github.com/apache/flink/pull/17621#issuecomment-960523435 The motivation of the fix: Right now, you can read debloat configuration only from taskManagerConf the same as many other properties from TaskManagerOptions . So it is

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-04 Thread GitBox
slinkydeveloper commented on a change in pull request #17658: URL: https://github.com/apache/flink/pull/17658#discussion_r742261221 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/rules/MapToStringCastRule.java ##

[GitHub] [flink] flinkbot edited a comment on pull request #17668: [FLINK-24401][runtime] Fix the bug of TM cannot exit after Metaspace OOM

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17668: URL: https://github.com/apache/flink/pull/17668#issuecomment-960521098 ## CI report: * daf34569f403cfe2a87b0f117a0a97d2653cdd1c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] flinkbot commented on pull request #17668: [FLINK-24401][runtime] Fix the bug of TM cannot exit after Metaspace OOM

2021-11-04 Thread GitBox
flinkbot commented on pull request #17668: URL: https://github.com/apache/flink/pull/17668#issuecomment-960521098 ## CI report: * daf34569f403cfe2a87b0f117a0a97d2653cdd1c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] flinkbot commented on pull request #17668: [FLINK-24401][runtime] Fix the bug of TM cannot exit after Metaspace OOM

2021-11-04 Thread GitBox
flinkbot commented on pull request #17668: URL: https://github.com/apache/flink/pull/17668#issuecomment-960520375 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[jira] [Updated] (FLINK-24401) TM cannot exit after Metaspace OOM

2021-11-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24401: --- Labels: pull-request-available (was: ) > TM cannot exit after Metaspace OOM >

[GitHub] [flink] 1996fanrui opened a new pull request #17668: [FLINK-24401][runtime] Fix the bug of TM cannot exit after Metaspace OOM

2021-11-04 Thread GitBox
1996fanrui opened a new pull request #17668: URL: https://github.com/apache/flink/pull/17668 ## What is the purpose of the change This PR fix the bug of TM cannot exit after Metaspace OOM. You can get more details in JIRA. ## Brief change log When Metaspace OOM,

[GitHub] [flink] flinkbot edited a comment on pull request #17667: [hotfix][docs]fix kafka datastream connector mistake

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17667: URL: https://github.com/apache/flink/pull/17667#issuecomment-960516132 ## CI report: * f9a25fe92093f49350659fbda00cb069c2eefbb1 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] flinkbot commented on pull request #17667: [hotfix][docs]fix kafka datastream connector mistake

2021-11-04 Thread GitBox
flinkbot commented on pull request #17667: URL: https://github.com/apache/flink/pull/17667#issuecomment-960516132 ## CI report: * f9a25fe92093f49350659fbda00cb069c2eefbb1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17655: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17655: URL: https://github.com/apache/flink/pull/17655#issuecomment-958717470 ## CI report: * 876e0ba044ff4f274814e9f22624fc3f2900c80a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17666: URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675 ## CI report: * 52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] flinkbot commented on pull request #17667: [hotfix][docs]fix kafka datastream connector mistake

2021-11-04 Thread GitBox
flinkbot commented on pull request #17667: URL: https://github.com/apache/flink/pull/17667#issuecomment-960515816 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] beyond1920 commented on a change in pull request #17509: [FLINK-24501][table-runtime] Stores window progress into state in order to check whether an input element is late or not for w

2021-11-04 Thread GitBox
beyond1920 commented on a change in pull request #17509: URL: https://github.com/apache/flink/pull/17509#discussion_r742587958 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SlicingWindowOperator.java ## @@

[GitHub] [flink] beyond1920 commented on a change in pull request #17509: [FLINK-24501][table-runtime] Stores window progress into state in order to check whether an input element is late or not for w

2021-11-04 Thread GitBox
beyond1920 commented on a change in pull request #17509: URL: https://github.com/apache/flink/pull/17509#discussion_r742587958 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SlicingWindowOperator.java ## @@

[GitHub] [flink] Airblader commented on pull request #17662: [FLINK-24747][table-planner] Add producedDataType to SupportsProjectionPushDown.applyProjection

2021-11-04 Thread GitBox
Airblader commented on pull request #17662: URL: https://github.com/apache/flink/pull/17662#issuecomment-960514813 > The public API, i.e., is any changed class annotated with @Public(Evolving): no That doesn't seem to be correct. In fact, this is a breaking change. -- This is an

[GitHub] [flink] flinkbot commented on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode

2021-11-04 Thread GitBox
flinkbot commented on pull request #17666: URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] simenliuxing opened a new pull request #17667: [hotfix][docs]fix kafka datastream connector mistake

2021-11-04 Thread GitBox
simenliuxing opened a new pull request #17667: URL: https://github.com/apache/flink/pull/17667 ## What is the purpose of the change There is no setDeliveryGuarantee method in KafkaRecordSerializationSchemaBuilder class, but it is in KafkaSinkBuilder class and the method is

[jira] [Created] (FLINK-24760) Update user document for batch window tvf

2021-11-04 Thread JING ZHANG (Jira)
JING ZHANG created FLINK-24760: -- Summary: Update user document for batch window tvf Key: FLINK-24760 URL: https://issues.apache.org/jira/browse/FLINK-24760 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-21327) Support window TVF in batch mode

2021-11-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21327: --- Labels: pull-request-available (was: ) > Support window TVF in batch mode >

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

[GitHub] [flink] beyond1920 opened a new pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode

2021-11-04 Thread GitBox
beyond1920 opened a new pull request #17666: URL: https://github.com/apache/flink/pull/17666 ## What is the purpose of the change This pull request aims to support window tvf in batch mode. ## Brief change log *(for example:)* - Introduce

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-04 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * Unknown: [CANCELED](TBD) * 008027f8b93ee34ec258e91203cb2d46c9607462 Azure:

<    2   3   4   5   6   7   8   >