[GitHub] [flink-connector-cassandra] echauchot commented on pull request #8: [FLINK-28198] Integrate tests with CassandraTestEnvironment which manages the cassandra cluster container, session, retrial

2023-04-13 Thread via GitHub
echauchot commented on PR #8: URL: https://github.com/apache/flink-connector-cassandra/pull/8#issuecomment-1507085334 > I assume we only merge this to `main` (Since the CTestEnvironment is only there)? > Yes > Will we do anything about v3.0 / release-1.16 on the Flink

[jira] [Commented] (FLINK-28352) [Umbrella] Make Pulsar connector stable

2023-04-13 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711921#comment-17711921 ] Yufan Sheng commented on FLINK-28352: - Thanks. The FLINK-24302 will be closed in Pulsar itself 3.0.0

[jira] [Updated] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-13 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-31757: --- Component/s: Runtime / Coordination (was: Runtime / Task) > Optimize

[GitHub] [flink] pnowojski commented on a diff in pull request #22392: [FLINK-31588][checkpoint] Correct the unaligned checkpoint type after aligned barrier timeout to unaligned barrier on PipelinedSu

2023-04-13 Thread via GitHub
pnowojski commented on code in PR #22392: URL: https://github.com/apache/flink/pull/22392#discussion_r1165593019 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java: ## @@ -381,7 +383,7 @@ private void

[GitHub] [flink] dmvk commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.

2023-04-13 Thread via GitHub
dmvk commented on code in PR #22350: URL: https://github.com/apache/flink/pull/22350#discussion_r1165606301 ## flink-runtime-web/web-dashboard/src/app/app.interceptor.ts: ## @@ -62,10 +65,8 @@ export class AppInterceptor implements HttpInterceptor {

[jira] [Updated] (FLINK-31796) Support service mesh istio with Flink kubernetes (both native and operator) for secure communications

2023-04-13 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Sainz updated FLINK-31796: - Description: Currently Flink Native Kubernetes does not support istio + TLS cleanly : Flink

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711914#comment-17711914 ] Martijn Visser commented on FLINK-25509: [~syhily] I defer to [~lindong] for his input on that

[jira] [Commented] (FLINK-31761) Fix Some Typo And Improve lambda expressions.

2023-04-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711913#comment-17711913 ] Martijn Visser commented on FLINK-31761: [~fanrui] No worries, I would have closed it for you

[jira] [Assigned] (FLINK-31797) Move LeaderElectionService out of LeaderContender

2023-04-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-31797: - Assignee: Matthias Pohl > Move LeaderElectionService out of LeaderContender >

[jira] [Created] (FLINK-31797) Move LeaderElectionService out of LeaderContender

2023-04-13 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-31797: - Summary: Move LeaderElectionService out of LeaderContender Key: FLINK-31797 URL: https://issues.apache.org/jira/browse/FLINK-31797 Project: Flink Issue

[GitHub] [flink] flinkbot commented on pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

2023-04-13 Thread via GitHub
flinkbot commented on PR #22393: URL: https://github.com/apache/flink/pull/22393#issuecomment-1507043111 ## CI report: * f9d940ab5bb355f5174a6377948d4e1f7a7d00c2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31785) Move LeaderElectionService.stop() into LeaderElection.close()

2023-04-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31785: -- Summary: Move LeaderElectionService.stop() into LeaderElection.close() (was: Move

[jira] [Commented] (FLINK-31655) Adaptive Channel selection for partitioner

2023-04-13 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711909#comment-17711909 ] Piotr Nowojski commented on FLINK-31655: I think there are ways to address problems with

[GitHub] [flink] wanglijie95 commented on pull request #22367: [FLINK-27144][runtime] Provide timeout details when calling FutureUtils.orTimeout

2023-04-13 Thread via GitHub
wanglijie95 commented on PR #22367: URL: https://github.com/apache/flink/pull/22367#issuecomment-1507041121 Squash commits. Merged % CI green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-31761) Fix Some Typo And Improve lambda expressions.

2023-04-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711907#comment-17711907 ] Rui Fan commented on FLINK-31761: - Hi [~martijnvisser] , sorry for the late update. Merged master

[jira] [Created] (FLINK-31796) Support service mesh istio with Flink kubernetes (both native and operator) for secure communications

2023-04-13 Thread Sergio Sainz (Jira)
Sergio Sainz created FLINK-31796: Summary: Support service mesh istio with Flink kubernetes (both native and operator) for secure communications Key: FLINK-31796 URL:

[jira] [Closed] (FLINK-31761) Fix Some Typo And Improve lambda expressions.

2023-04-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan closed FLINK-31761. --- Fix Version/s: 1.18.0 Resolution: Fixed > Fix Some Typo And Improve lambda expressions. >

[GitHub] [flink] flinkbot commented on pull request #22392: [FLINK-31588][checkpoint] Correct the unaligned checkpoint type after aligned barrier timeout to unaligned barrier on PipelinedSubpartition

2023-04-13 Thread via GitHub
flinkbot commented on PR #22392: URL: https://github.com/apache/flink/pull/22392#issuecomment-1507031958 ## CI report: * c8d6b945ad2c8ff9e2d0c3328dba3d7f8cd59767 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] GilShmaya commented on pull request #379: [FLINK-29388] Fix to use JobSpec arguments in Standalone Application Mode

2023-04-13 Thread via GitHub
GilShmaya commented on PR #379: URL: https://github.com/apache/flink-kubernetes-operator/pull/379#issuecomment-1507030410 Hi, I notice that this bug you fixed in version 1.2.0 seems to have resurfaced in version 1.4.0. @avocadomaster @gyfora Would you mind taking a look at this

[GitHub] [flink] sigalite opened a new pull request, #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

2023-04-13 Thread via GitHub
sigalite opened a new pull request, #22393: URL: https://github.com/apache/flink/pull/22393 ## What is the purpose of the change enable the job manager and task manager communicate in a Kubernetes cluster with Istio and mTLS enabled. *(For example: This pull request makes task

[jira] [Updated] (FLINK-31795) Add Config to enable/disable savepoint cleanup

2023-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31795: --- Labels: pull-request-available (was: ) > Add Config to enable/disable savepoint cleanup >

[GitHub] [flink-kubernetes-operator] darenwkt opened a new pull request, #565: [FLINK-31795] Add config to disable savepoint cleanup

2023-04-13 Thread via GitHub
darenwkt opened a new pull request, #565: URL: https://github.com/apache/flink-kubernetes-operator/pull/565 ## What is the purpose of the change Add new operator config "savepoint.cleaner.enabled" to allow user to configure whether to enable SavepointObserver to clean up

[jira] [Updated] (FLINK-31588) The unaligned checkpoint type is wrong at subtask level

2023-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31588: --- Labels: pull-request-available (was: ) > The unaligned checkpoint type is wrong at subtask

[jira] [Commented] (FLINK-25509) FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-04-13 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711902#comment-17711902 ] Yufan Sheng commented on FLINK-25509: - [~martijnvisser] I think this breaking change should be

[GitHub] [flink] 1996fanrui opened a new pull request, #22392: [FLINK-31588][checkpoint] Correct the unaligned checkpoint type after aligned barrier timeout to unaligned barrier on PipelinedSubpartiti

2023-04-13 Thread via GitHub
1996fanrui opened a new pull request, #22392: URL: https://github.com/apache/flink/pull/22392 ## What is the purpose of the change Correct the unaligned checkpoint type after aligned barrier timeout to unaligned barrier on PipelinedSubpartition. ## Brief change log

[jira] [Commented] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-13 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711897#comment-17711897 ] RocMarshal commented on FLINK-31757: Thanks for your [~Weijie Guo] sorted concise and precise

[jira] [Commented] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-13 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711895#comment-17711895 ] RocMarshal commented on FLINK-31757: Thank you  [~fanrui] & [~huwh] very much. I'll prepare a design

[jira] [Resolved] (FLINK-31699) JDBC nightly CI failure

2023-04-13 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-31699. --- Resolution: Fixed > JDBC nightly CI failure > --- > >

[jira] [Commented] (FLINK-31699) JDBC nightly CI failure

2023-04-13 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711894#comment-17711894 ] Danny Cranmer commented on FLINK-31699: --- main branch is good

[jira] [Created] (FLINK-31795) Add Config to enable/disable savepoint cleanup

2023-04-13 Thread Daren Wong (Jira)
Daren Wong created FLINK-31795: -- Summary: Add Config to enable/disable savepoint cleanup Key: FLINK-31795 URL: https://issues.apache.org/jira/browse/FLINK-31795 Project: Flink Issue Type:

[jira] [Commented] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711892#comment-17711892 ] Weijie Guo commented on FLINK-31757: [~RocMarshal] I have updated the description of this ticket

[jira] [Commented] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711886#comment-17711886 ] Rui Fan commented on FLINK-31757: - Thanks [~RocMarshal] 's reporting and [~huwh] 's feedback. {quote}If

[GitHub] [flink] Aitozi commented on a diff in pull request #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc

2023-04-13 Thread via GitHub
Aitozi commented on code in PR #22386: URL: https://github.com/apache/flink/pull/22386#discussion_r1165532653 ## docs/data/sql_functions.yml: ## @@ -933,11 +933,13 @@ valueconstruction: - sql: | -- implicit constructor with parenthesis (value1 [, value2]*) +

[GitHub] [flink] flinkbot commented on pull request #22391: [hotfix][annotations] Fix the Flink version enum for v1.18

2023-04-13 Thread via GitHub
flinkbot commented on PR #22391: URL: https://github.com/apache/flink/pull/22391#issuecomment-1506974825 ## CI report: * 156e8ecc00c8ff9b86519b4b3139845e67274fda UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31757: --- Description: Supposed we have a Job with 21 {{JobVertex}}. The parallelism of vertex A is 100, and

[GitHub] [flink] LadyForest opened a new pull request, #22391: [hotfix][annotations] Fix the version enum for v1.18

2023-04-13 Thread via GitHub
LadyForest opened a new pull request, #22391: URL: https://github.com/apache/flink/pull/22391 ## What is the purpose of the change This is a trivial fix for the `FlinkVersion` enum, which should start with lowercase. ## Brief change log Change `V1_18` to `v1_18`.

[jira] [Updated] (FLINK-30371) JdbcOutputFormat is at risk of database connection leaks

2023-04-13 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-30371: -- Fix Version/s: jdbc-3.2.0 (was: jdbc-3.1.0) > JdbcOutputFormat is at

[jira] [Commented] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-13 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711880#comment-17711880 ] Weihua Hu commented on FLINK-31757: --- [~RocMarshal] sure, I would like to. Will you prepare a design

[jira] [Assigned] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-31757: --- Assignee: RocMarshal > Optimize Flink un-balanced tasks scheduling >

[jira] [Commented] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-13 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711875#comment-17711875 ] RocMarshal commented on FLINK-31757: Based on this problem, we has achieved balanced task

[GitHub] [flink] flinkbot commented on pull request #22390: [WIP][FLINK-31785][runtime] Moves LeaderElectionService.stop into LeaderElection.close

2023-04-13 Thread via GitHub
flinkbot commented on PR #22390: URL: https://github.com/apache/flink/pull/22390#issuecomment-1506940038 ## CI report: * 152e71f5cffd7626fed20f57387a256c2c078a53 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31794) Ignore unknown CRD fields

2023-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31794: --- Labels: pull-request-available (was: ) > Ignore unknown CRD fields >

[GitHub] [flink-kubernetes-operator] darenwkt opened a new pull request, #564: [FLINK-31794] Ignore unknown CRD fields

2023-04-13 Thread via GitHub
darenwkt opened a new pull request, #564: URL: https://github.com/apache/flink-kubernetes-operator/pull/564 ## What is the purpose of the change Ignore unknown CRD fields to prevent failure in creating CR. ## Brief change log Added class-level annotation

[jira] [Assigned] (FLINK-31750) Hash Keys are duplicate when join reorder happens in stream mode

2023-04-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31750: -- Assignee: ZhengYi Weng > Hash Keys are duplicate when join reorder happens in stream mode >

[jira] [Created] (FLINK-31794) Ignore unknown CRD fields

2023-04-13 Thread Daren Wong (Jira)
Daren Wong created FLINK-31794: -- Summary: Ignore unknown CRD fields Key: FLINK-31794 URL: https://issues.apache.org/jira/browse/FLINK-31794 Project: Flink Issue Type: Improvement

[GitHub] [flink-connector-jdbc] eskabetxe commented on pull request #31: [FLINK-31649] Fix archunit violations

2023-04-13 Thread via GitHub
eskabetxe commented on PR #31: URL: https://github.com/apache/flink-connector-jdbc/pull/31#issuecomment-1506928813 Renamed, and rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-31785) Move LeaderElectionService out of LeaderContender

2023-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31785: --- Labels: pull-request-available (was: ) > Move LeaderElectionService out of LeaderContender

[GitHub] [flink] XComp opened a new pull request, #22390: [WIP][FLINK-31785][runtime] Moves LeaderElectionService.stop into LeaderElection.close

2023-04-13 Thread via GitHub
XComp opened a new pull request, #22390: URL: https://github.com/apache/flink/pull/22390 * [FLINK-30765](https://issues.apache.org/jira/browse/FLINK-30765) (PR https://github.com/apache/flink/pull/21742) * [FLINK-31768](https://issues.apache.org/jira/browse/FLINK-31768) (PR

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-04-13 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1165481084 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SqlClientOptions.java: ## @@ -68,4 +69,12 @@ private SqlClientOptions() {}

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-04-13 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1165478544 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/parser/SqlClientSyntaxHighlighter.java: ## @@ -0,0 +1,256 @@ +/* + * Licensed to the

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-04-13 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1165477945 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/parser/SqlClientSyntaxHighlighter.java: ## @@ -0,0 +1,256 @@ +/* + * Licensed to the

[GitHub] [flink] libenchao commented on a diff in pull request #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc

2023-04-13 Thread via GitHub
libenchao commented on code in PR #22386: URL: https://github.com/apache/flink/pull/22386#discussion_r1165466847 ## docs/data/sql_functions.yml: ## @@ -933,11 +933,13 @@ valueconstruction: - sql: | -- implicit constructor with parenthesis (value1 [, value2]*) +

[jira] [Updated] (FLINK-31750) Hash Keys are duplicate when join reorder happens in stream mode

2023-04-13 Thread ZhengYi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhengYi Weng updated FLINK-31750: - Description: When I run  `JoinReorderTestBase#testAllInnerJoin` in the case that

[jira] [Updated] (FLINK-31750) Hash Keys are duplicate when join reorder happens in stream mode

2023-04-13 Thread ZhengYi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhengYi Weng updated FLINK-31750: - Affects Version/s: 1.16.1 1.17.0 > Hash Keys are duplicate when join

[GitHub] [flink] qingwei91 commented on pull request #14084: [FLINK-15867][table-planner-blink] Support time-related types for FIRST_VALUE and LAST_VALUE aggregate functions

2023-04-13 Thread via GitHub
qingwei91 commented on PR #14084: URL: https://github.com/apache/flink/pull/14084#issuecomment-1506843409 Hi, I am keen to have this feature, how can we make progress on this? Happy to help :) -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-04-13 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711854#comment-17711854 ] Feng Jin commented on FLINK-31788: -- [~jark]  This question is from a user mail.    The origin discuss

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #229: [FLINK-31255] Wraps the operator config about serializer

2023-04-13 Thread via GitHub
jiangxin369 commented on code in PR #229: URL: https://github.com/apache/flink-ml/pull/229#discussion_r1165403137 ## flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/OperatorUtils.java: ## @@ -104,6 +107,33 @@ public static StreamConfig

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #229: [FLINK-31255] Wraps the operator config about serializer

2023-04-13 Thread via GitHub
jiangxin369 commented on code in PR #229: URL: https://github.com/apache/flink-ml/pull/229#discussion_r1165403137 ## flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/OperatorUtils.java: ## @@ -104,6 +107,33 @@ public static StreamConfig

[GitHub] [flink] XComp commented on pull request #22257: [FLINK-31593][tests] Upgraded migration test data

2023-04-13 Thread via GitHub
XComp commented on PR #22257: URL: https://github.com/apache/flink/pull/22257#issuecomment-1506819296 @PatrickRen may you have a final pass over this PR. I fixed the issue now with the help of FLINK-31765 -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-04-13 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-31788: - Description: This feature was originally implemented in the old planner: 

[GitHub] [flink] XComp commented on pull request #22257: [FLINK-31593][tests] Upgraded migration test data

2023-04-13 Thread via GitHub
XComp commented on PR #22257: URL: https://github.com/apache/flink/pull/22257#issuecomment-1506818191 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-04-13 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711852#comment-17711852 ] Jark Wu commented on FLINK-31788: - Thanks for pointing out this [~hackergin]. If it's true, I think it

[GitHub] [flink] Aitozi commented on pull request #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc

2023-04-13 Thread via GitHub
Aitozi commented on PR #22386: URL: https://github.com/apache/flink/pull/22386#issuecomment-1506815970 CC @libenchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-13 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711848#comment-17711848 ] Weihua Hu commented on FLINK-31757: --- Hi [~RocMarshal] , thanks for reporting this. For now, you could

[GitHub] [flink-connector-cassandra] MartijnVisser opened a new pull request, #10: [FLINK-31698] Support both Flink 1.16 and Flink 1.17

2023-04-13 Thread via GitHub
MartijnVisser opened a new pull request, #10: URL: https://github.com/apache/flink-connector-cassandra/pull/10 Same as https://github.com/apache/flink-connector-cassandra/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-ml] zhipeng93 commented on pull request #229: [FLINK-31255] Wraps the operator config about serializer

2023-04-13 Thread via GitHub
zhipeng93 commented on PR #229: URL: https://github.com/apache/flink-ml/pull/229#issuecomment-1506787052 The update LGTM except the unresolved one. @lindong28 Would you like to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-04-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711841#comment-17711841 ] Martijn Visser commented on FLINK-31793: [~Wencong Liu] Done! > Remove dependency on

[jira] [Assigned] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-04-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-31793: -- Assignee: Wencong Liu > Remove dependency on flink-shaded for flink-connector-jdbc >

[jira] [Commented] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-04-13 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711840#comment-17711840 ] Feng Jin commented on FLINK-31788: -- [~jark]  I'm sorry, I wrote the wrong name.  It should be

[GitHub] [flink-connector-pulsar] tisonkun commented on a diff in pull request #43: [FLINK-31748] Dummy implementation to fix compilation failure

2023-04-13 Thread via GitHub
tisonkun commented on code in PR #43: URL: https://github.com/apache/flink-connector-pulsar/pull/43#discussion_r1165364566 ## .github/workflows/daily.yml: ## @@ -18,6 +18,7 @@ name: Nightly on: + pull_request: Review Comment: ```suggestion ``` Verified.

[jira] [Assigned] (FLINK-31785) Move LeaderElectionService out of LeaderContender

2023-04-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-31785: - Assignee: Matthias Pohl > Move LeaderElectionService out of LeaderContender >

[jira] [Commented] (FLINK-31610) Refactoring of LocalBufferPool

2023-04-13 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711825#comment-17711825 ] Yingjie Cao commented on FLINK-31610: - Sorry for the delayed reply. Totally agree that we should

[jira] [Reopened] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-13 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal reopened FLINK-31757: > Optimize Flink un-balanced tasks scheduling > --- > >

[GitHub] [flink-connector-jdbc] wanglijie95 commented on pull request #31: [FLINK-31649] Fix archunit violations

2023-04-13 Thread via GitHub
wanglijie95 commented on PR #31: URL: https://github.com/apache/flink-connector-jdbc/pull/31#issuecomment-1506730457 > org.apache.flink.connector.jdbc.internal.options.JdbcConnectorOptions This is also `@Internal`, which is only used by `JdbcDynamicTableSink`(users are not expected

[jira] [Commented] (FLINK-31777) Upsert Kafka use Avro Confluent, key is ok, but all values are null.

2023-04-13 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711820#comment-17711820 ] Jark Wu commented on FLINK-31777: - Hi [~ge.bugman], "upsert-kafka" doesn't support JSON or AVRO in

[jira] [Commented] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-04-13 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711816#comment-17711816 ] Wencong Liu commented on FLINK-31793: - Hello [~dannycranmer] , I think this could follow the same

[jira] [Updated] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-04-13 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-31793: -- Component/s: Connectors / JDBC (was: Connectors / Cassandra) > Remove

[GitHub] [flink-connector-jdbc] dannycranmer commented on a diff in pull request #39: [FLINK-31699][Connectors/JDBC] Fixing dependency convergence

2023-04-13 Thread via GitHub
dannycranmer commented on code in PR #39: URL: https://github.com/apache/flink-connector-jdbc/pull/39#discussion_r1165324674 ## pom.xml: ## @@ -48,7 +48,7 @@ under the License. 1.16.0 -15.0 +16.1 Review Comment:

[jira] [Updated] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-04-13 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-31793: -- Fix Version/s: (was: cassandra-4.0.0) (was: cassandra-3.0.1) >

[jira] [Updated] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-04-13 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-31793: -- Labels: (was: pull-request-available) > Remove dependency on flink-shaded for

[jira] [Assigned] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-04-13 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-31793: - Assignee: (was: Etienne Chauchot) > Remove dependency on flink-shaded for

[jira] [Updated] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-04-13 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-31793: -- Reporter: Danny Cranmer (was: Martijn Visser) > Remove dependency on flink-shaded for

[jira] [Updated] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-04-13 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-31793: -- Description: The JDBC connector relies on flink-shaded and uses Flinks' shaded Guava. With

[jira] [Created] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-04-13 Thread Danny Cranmer (Jira)
Danny Cranmer created FLINK-31793: - Summary: Remove dependency on flink-shaded for flink-connector-jdbc Key: FLINK-31793 URL: https://issues.apache.org/jira/browse/FLINK-31793 Project: Flink

[GitHub] [flink-connector-jdbc] dannycranmer merged pull request #39: [FLINK-31699][Connectors/JDBC] Fixing dependency convergence

2023-04-13 Thread via GitHub
dannycranmer merged PR #39: URL: https://github.com/apache/flink-connector-jdbc/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-pulsar] tisonkun commented on a diff in pull request #43: [FLINK-31748] Dummy implementation to fix compilation failure

2023-04-13 Thread via GitHub
tisonkun commented on code in PR #43: URL: https://github.com/apache/flink-connector-pulsar/pull/43#discussion_r1165322478 ## .github/workflows/daily.yml: ## @@ -18,6 +18,7 @@ name: Nightly on: + pull_request: Review Comment: To be reverted after verified. -- This

[GitHub] [flink-connector-pulsar] tisonkun opened a new pull request, #43: [FLINK-31748] Dummy implementation to fix compilation failure

2023-04-13 Thread via GitHub
tisonkun opened a new pull request, #43: URL: https://github.com/apache/flink-connector-pulsar/pull/43 TRIVIAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-31748) Adapt SplitFetcherManager#removeSplit for flink-connector-pulsar

2023-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31748: --- Labels: pull-request-available (was: ) > Adapt SplitFetcherManager#removeSplit for

[jira] [Updated] (FLINK-31777) Upsert Kafka use Avro Confluent, key is ok, but all values are null.

2023-04-13 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-31777: Component/s: Connectors / Kafka (was: kafka) > Upsert Kafka use Avro Confluent, key

[jira] [Commented] (FLINK-31778) Casting array of rows produces incorrect result

2023-04-13 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711809#comment-17711809 ] Jark Wu commented on FLINK-31778: - Hi [~soin08], nice catch! However, constructing BinaryRowWriter and

[GitHub] [flink-connector-pulsar] tisonkun closed pull request #35: [FLINK-31427][Table] Initial Catalog implementation with a new config model and schema conversion.

2023-04-13 Thread via GitHub
tisonkun closed pull request #35: [FLINK-31427][Table] Initial Catalog implementation with a new config model and schema conversion. URL: https://github.com/apache/flink-connector-pulsar/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #35: [FLINK-31427][Table] Initial Catalog implementation with a new config model and schema conversion.

2023-04-13 Thread via GitHub
tisonkun commented on PR #35: URL: https://github.com/apache/flink-connector-pulsar/pull/35#issuecomment-1506709597 > Hi all, my account was revoked from streamnative. I have to start a new PR for this feature. OK. Then let's close the PR as it's stale... -- This is an automated

[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #16: [BK-3.0][FLINK-30552][Connector/Pulsar] drop batch message size assertion, better set the cursor position.

2023-04-13 Thread via GitHub
tisonkun commented on PR #16: URL: https://github.com/apache/flink-connector-pulsar/pull/16#issuecomment-1506708663 I see the respond. Feel free to cc me to verify the release. I'll send a patch to suppress the compile issue but still wait a bit for @syhily to implement FLINK-31748. --

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #31: [FLINK-31649] Fix archunit violations

2023-04-13 Thread via GitHub
eskabetxe commented on code in PR #31: URL: https://github.com/apache/flink-connector-jdbc/pull/31#discussion_r1165316211 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunctionState.java: ## @@ -28,6 +30,7 @@ /** Thread-safe (assuming

[GitHub] [flink-connector-cassandra] MartijnVisser merged pull request #9: [FLINK-31698][BP] Support both Flink 1.16 and Flink 1.17 to resolve failing nightly builds

2023-04-13 Thread via GitHub
MartijnVisser merged PR #9: URL: https://github.com/apache/flink-connector-cassandra/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-16868) Table/SQL doesn't support custom trigger

2023-04-13 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711805#comment-17711805 ] Jark Wu commented on FLINK-16868: - Hi [~charles-tan], yes, the configuraitons just work on the legacy

[jira] [Commented] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-04-13 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711802#comment-17711802 ] Jark Wu commented on FLINK-31788: - Hi [~hackergin], it seems the {{emitValueWithRetract}} was never

[GitHub] [flink-connector-jdbc] wanglijie95 commented on a diff in pull request #31: [FLINK-31649] Fix archunit violations

2023-04-13 Thread via GitHub
wanglijie95 commented on code in PR #31: URL: https://github.com/apache/flink-connector-jdbc/pull/31#discussion_r1165295846 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunctionState.java: ## @@ -28,6 +30,7 @@ /** Thread-safe (assuming

[GitHub] [flink-connector-jdbc] MartijnVisser commented on a diff in pull request #39: [FLINK-31699][Connectors/JDBC] Fixing dependency convergence

2023-04-13 Thread via GitHub
MartijnVisser commented on code in PR #39: URL: https://github.com/apache/flink-connector-jdbc/pull/39#discussion_r1165293180 ## pom.xml: ## @@ -48,7 +48,7 @@ under the License. 1.16.0 -15.0 +16.1 Review Comment: We actually should create a

[jira] [Commented] (FLINK-31700) MongoDB nightly CI failure

2023-04-13 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711798#comment-17711798 ] Jiabao Sun commented on FLINK-31700: Hey [~dannycranmer]. Could you help close this issue? >

<    1   2   3   >