wanglijie95 commented on PR #31: URL: https://github.com/apache/flink-connector-jdbc/pull/31#issuecomment-1506730457
> org.apache.flink.connector.jdbc.internal.options.JdbcConnectorOptions This is also `@Internal`, which is only used by `JdbcDynamicTableSink`(users are not expected to use it directly). It breaks the rule because it ends with `ConnectorOptions` (see `TableApiRules#CONNECTOR_OPTIONS_PACKAGE` for details). I think a simple solutation is rename it(to `JdbcOptions` or `JdbcConnectorInternalOptions` or some other names, not ending with `ConnectorOptions` is fine.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
