[GitHub] [flink-kubernetes-operator] mxm commented on pull request #581: [FLINK-31936] Support setting scale up max factor

2023-05-09 Thread via GitHub
mxm commented on PR #581: URL: https://github.com/apache/flink-kubernetes-operator/pull/581#issuecomment-1540617992 No more comments. Thanks @X-czh!  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] snuyanzin opened a new pull request, #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

2023-05-09 Thread via GitHub
snuyanzin opened a new pull request, #22558: URL: https://github.com/apache/flink/pull/22558 ## What is the purpose of the change Upgrade Calcite to 1.31.0 TBD ## Verifying this change This change is already covered by existing tests, such as *(please describe

[jira] [Updated] (FLINK-28744) Upgrade Calcite version to 1.31

2023-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28744: --- Labels: pull-request-available (was: ) > Upgrade Calcite version to 1.31 >

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #586: [FLINK-32002] Adjust autoscaler defaults for release

2023-05-09 Thread via GitHub
mxm commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1188960604 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,16

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-09 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1189036465 ## flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java: ## @@ -620,4 +623,30 @@ public static YarnConfiguration getYarnConfiguration( return

[GitHub] [flink-playgrounds] alainbrown commented on pull request #42: Create flink_data volume for operations playground.

2023-05-09 Thread via GitHub
alainbrown commented on PR #42: URL: https://github.com/apache/flink-playgrounds/pull/42#issuecomment-1540825166 Actually, I think it's quite the opposite. You can more easily use checkpoints and savepoints via volumes. Data is persisted, easily backed up and shared between containers. You

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #585: [FLINK-32005] Add a per-deployment error metric to signal about potential issues

2023-05-09 Thread via GitHub
mxm commented on PR #585: URL: https://github.com/apache/flink-kubernetes-operator/pull/585#issuecomment-1540684297 I'm going to follow up with the scaling counter which also includes a refactor. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #585: [FLINK-32005] Add a per-deployment error metric to signal about potential issues

2023-05-09 Thread via GitHub
mxm commented on PR #585: URL: https://github.com/apache/flink-kubernetes-operator/pull/585#issuecomment-1540761289 The latest commit contains a refactor and adds the successful scaling metric. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #585: [FLINK-32005] Add a per-deployment error metric to signal about potential issues

2023-05-09 Thread via GitHub
mxm commented on code in PR #585: URL: https://github.com/apache/flink-kubernetes-operator/pull/585#discussion_r1188996818 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java: ## @@ -82,8 +85,11 @@ public

[GitHub] [flink-kubernetes-operator] mxm merged pull request #586: [FLINK-32002] Adjust autoscaler defaults for release

2023-05-09 Thread via GitHub
mxm merged PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] venkata91 commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-09 Thread via GitHub
venkata91 commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1189085613 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java: ## @@ -61,6 +61,9 @@ class YARNSessionFIFOITCase extends YarnTestBase {

[GitHub] [flink] flinkbot commented on pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

2023-05-09 Thread via GitHub
flinkbot commented on PR #22558: URL: https://github.com/apache/flink/pull/22558#issuecomment-1540875174 ## CI report: * 69b4b22e38f67abe10d98d7069435855fa3b0dc3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-25568) Add Elasticsearch 7 Source Connector

2023-05-09 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721136#comment-17721136 ] xingyuan cheng commented on FLINK-25568: Hi, community. It seems that this issue has not been

[jira] [Created] (FLINK-32042) Support customized exec node graph processor for planner

2023-05-09 Thread Fang Yong (Jira)
Fang Yong created FLINK-32042: - Summary: Support customized exec node graph processor for planner Key: FLINK-32042 URL: https://issues.apache.org/jira/browse/FLINK-32042 Project: Flink Issue

[jira] [Updated] (FLINK-31890) Introduce SchedulerBase per-task failure enrichment/labeling

2023-05-09 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-31890: --- Summary: Introduce SchedulerBase per-task failure enrichment/labeling

[GitHub] [flink] 1996fanrui commented on pull request #22496: [FLINK-31959][checkpoint] Correct the unaligned checkpoint type at checkpoint level

2023-05-09 Thread via GitHub
1996fanrui commented on PR #22496: URL: https://github.com/apache/flink/pull/22496#issuecomment-1541331915 Thanks a lot for your review. > Thanks for the fix! LGTM. Have you verified manually that it's working in the web ui? Could you post a screenshot that timeout didn't happen UI

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #7: [FLINK-31408] Add support for EOS delivery-guarantee in upsert-kafka

2023-05-09 Thread via GitHub
tzulitai commented on code in PR #7: URL: https://github.com/apache/flink-connector-kafka/pull/7#discussion_r1189345491 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/TwoPhaseCommittingStatefulSink.java: ## @@ -0,0 +1,34 @@ +package

[GitHub] [flink] libenchao commented on a diff in pull request #22533: [FLINK-31687][jdbc-driver] Get rid of flink-core for jdbc driver

2023-05-09 Thread via GitHub
libenchao commented on code in PR #22533: URL: https://github.com/apache/flink/pull/22533#discussion_r1189370293 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/Executor.java: ## @@ -46,7 +46,7 @@ static Executor create( * *

[jira] [Comment Edited] (FLINK-32041) flink-kubernetes-operator RoleBinding for Leases not created in correct namespace when using watchNamespaces

2023-05-09 Thread Tamir Sagi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721192#comment-17721192 ] Tamir Sagi edited comment on FLINK-32041 at 5/10/23 5:43 AM: - Hey Gyula, I

[jira] [Comment Edited] (FLINK-32041) flink-kubernetes-operator RoleBinding for Leases not created in correct namespace when using watchNamespaces

2023-05-09 Thread Tamir Sagi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721192#comment-17721192 ] Tamir Sagi edited comment on FLINK-32041 at 5/10/23 5:44 AM: - Hey Gyula, I

[GitHub] [flink] becketqin commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-09 Thread via GitHub
becketqin commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1189255125 ## docs/layouts/shortcodes/generated/yarn_config_configuration.html: ## @@ -182,5 +182,15 @@ String Specify YARN node label for the Flink

[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #589: [hotfix][docs] Fix flink version in doc and yaml

2023-05-09 Thread via GitHub
yangjf2019 commented on PR #589: URL: https://github.com/apache/flink-kubernetes-operator/pull/589#issuecomment-1541179768 > Why not upgrade to the latest version: 1.17 directly? Thanks for your review, I have wanted to update to the latest stable version 1.17.0, but considering the

[jira] [Closed] (FLINK-32027) Batch jobs could hang at shuffle phase when max parallelism is really large

2023-05-09 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-32027. -- Fix Version/s: 1.18.0 Resolution: Fixed master(1.18) via

[jira] [Closed] (FLINK-30815) BatchTestBase/BatchAbstractTestBase are using JUnit4 while some child tests are using JUnit5

2023-05-09 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He closed FLINK-30815. -- Fix Version/s: 1.18.0 Resolution: Fixed Fixed in master:

[GitHub] [flink] libenchao commented on a diff in pull request #22532: [FLINK-31548][jdbc-driver] Introduce FlinkDataSource

2023-05-09 Thread via GitHub
libenchao commented on code in PR #22532: URL: https://github.com/apache/flink/pull/22532#discussion_r1189364154 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkDataSource.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-kubernetes-operator] tamirsagi commented on pull request #589: [hotfix][docs] Fix flink version in doc and yaml

2023-05-09 Thread via GitHub
tamirsagi commented on PR #589: URL: https://github.com/apache/flink-kubernetes-operator/pull/589#issuecomment-1541389257 Hey, If you are updating the documents, there is another place to update

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #589: [hotfix][docs] Fix flink version in doc and yaml

2023-05-09 Thread via GitHub
gyfora commented on PR #589: URL: https://github.com/apache/flink-kubernetes-operator/pull/589#issuecomment-1541393752 > Why not upgrade to the latest version: 1.17 directly? @X-czh @yangjf2019 we usually update the examples, clients etc once the first patch version is released

[GitHub] [flink] clownxc commented on pull request #22555: [FLINK-31706] [runtime] The default source parallelism should be the same as ex…

2023-05-09 Thread via GitHub
clownxc commented on PR #22555: URL: https://github.com/apache/flink/pull/22555#issuecomment-1541110008 can you spare some precious time to review? Thanks very much @Myasuka -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] reswqa merged pull request #22554: [BP-1.17][FLINK-32027][runtime] Fix the potential concurrent reading bug of index file for SortMergeShuffle.

2023-05-09 Thread via GitHub
reswqa merged PR #22554: URL: https://github.com/apache/flink/pull/22554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-30815) BatchTestBase/BatchAbstractTestBase are using JUnit4 while some child tests are using JUnit5

2023-05-09 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He reassigned FLINK-30815: -- Assignee: Yuxin Tan > BatchTestBase/BatchAbstractTestBase are using JUnit4 while some child

[GitHub] [flink] libenchao merged pull request #22536: [FLINK-31546][jdbc-driver] Close all statements when connection is closed

2023-05-09 Thread via GitHub
libenchao merged PR #22536: URL: https://github.com/apache/flink/pull/22536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-16713) Support source mode of elasticsearch connector

2023-05-09 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721135#comment-17721135 ] xingyuan cheng commented on FLINK-16713: Hi, community. It seems that this issue has not been

[GitHub] [flink-kubernetes-operator] X-czh commented on pull request #589: [hotfix][docs] Fix flink version in doc and yaml

2023-05-09 Thread via GitHub
X-czh commented on PR #589: URL: https://github.com/apache/flink-kubernetes-operator/pull/589#issuecomment-1541168048 Why not upgrade to the latest version: 1.17 directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (FLINK-31963) java.lang.ArrayIndexOutOfBoundsException when scaling down with unaligned checkpoints

2023-05-09 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721179#comment-17721179 ] Hangxiang Yu commented on FLINK-31963: -- Hi, [~pnowojski]. I am a bit sure that it may not be

[jira] [Closed] (FLINK-31546) Close all statements when connection is closed

2023-05-09 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li closed FLINK-31546. -- Fix Version/s: 1.18.0 Assignee: Fang Yong Resolution: Fixed Fixed via

[jira] [Commented] (FLINK-24595) Programmatic configuration of S3 doesn't pass parameters to Hadoop FS

2023-05-09 Thread Lu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721160#comment-17721160 ] Lu commented on FLINK-24595: i have the save problem in 1.15.2, it seems   flink-s3-fs-hadoop read s3

[GitHub] [flink] godfreyhe closed pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5

2023-05-09 Thread via GitHub
godfreyhe closed pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5 URL: https://github.com/apache/flink/pull/22427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (FLINK-32042) Support calculate versions of all tables for job in planner

2023-05-09 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong updated FLINK-32042: -- Description: Set customized callback in planner for scan sources, for example, calculate snapshot id

[jira] [Updated] (FLINK-32042) Support calculate versions of all tables for job in planner

2023-05-09 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong updated FLINK-32042: -- Summary: Support calculate versions of all tables for job in planner (was: Support customized exec

[jira] [Commented] (FLINK-32041) flink-kubernetes-operator RoleBinding for Leases not created in correct namespace when using watchNamespaces

2023-05-09 Thread Tamir Sagi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721192#comment-17721192 ] Tamir Sagi commented on FLINK-32041: Hey Gyula,   I also encountered something similar  {{HA is

[GitHub] [flink] XComp commented on a diff in pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException

2023-05-09 Thread via GitHub
XComp commented on code in PR #22544: URL: https://github.com/apache/flink/pull/22544#discussion_r1188199532 ## flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/executor/TestExecutorExtension.java: ## @@ -49,6 +58,20 @@ public T

[GitHub] [flink] XComp commented on a diff in pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException

2023-05-09 Thread via GitHub
XComp commented on code in PR #22544: URL: https://github.com/apache/flink/pull/22544#discussion_r1188199816 ## flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/executor/TestExecutorResource.java: ## @@ -47,6 +55,20 @@ public T

[GitHub] [flink] XComp commented on pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException

2023-05-09 Thread via GitHub
XComp commented on PR #22544: URL: https://github.com/apache/flink/pull/22544#issuecomment-1539552187 I dropped the Executor shutdown commit (this one is moved to FLINK-32039) and rebased the branch. Thanks for your review, @pgaref -- This is an automated message from the Apache Git

[jira] [Updated] (FLINK-32039) ExecutorServiceResource and ExecutorServiceExtension's shutdown mechanism doesn't include a forced shutdown

2023-05-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-32039: -- Affects Version/s: 1.16.1 1.17.0 1.18.0 >

[jira] [Created] (FLINK-32039) ExecutorServiceResource and ExecutorServiceExtension's shutdown mechanism doesn't include a forced shutdown

2023-05-09 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32039: - Summary: ExecutorServiceResource and ExecutorServiceExtension's shutdown mechanism doesn't include a forced shutdown Key: FLINK-32039 URL:

[jira] [Updated] (FLINK-32039) ExecutorServiceResource and ExecutorServiceExtension's shutdown mechanism doesn't include a forced shutdown

2023-05-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-32039: -- Description: {{ExecutorServiceResource}} and {{ExecutorServiceExtension}}'s shutdown

[jira] [Updated] (FLINK-32039) ExecutorServiceResource and ExecutorServiceExtension's shutdown mechanism doesn't include a forced shutdown

2023-05-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-32039: -- Component/s: Runtime / Coordination > ExecutorServiceResource and ExecutorServiceExtension's

[jira] [Closed] (FLINK-31965) Fix ClassNotFoundException in benchmarks

2023-05-09 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-31965. -- Resolution: Fixed Fixed in master: c038bf3f83c56230c6e621373160d0215af0e256 > Fix

[jira] [Commented] (FLINK-32038) OffsetCommitMode.Kafka_periodic with checkpointing enabled

2023-05-09 Thread Pritam Agarwala (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720807#comment-17720807 ] Pritam Agarwala commented on FLINK-32038: - [~martijnvisser]  I have already gone through it.

[jira] [Assigned] (FLINK-31965) Fix ClassNotFoundException in benchmarks

2023-05-09 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-31965: -- Assignee: Paul Lin > Fix ClassNotFoundException in benchmarks >

[jira] [Commented] (FLINK-32009) Slot request bulk is not fulfillable! Could not allocate the required slot within slot request timeout

2023-05-09 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720799#comment-17720799 ] Weihua Hu commented on FLINK-32009: --- [~baibaiwuchang]  The "OOM" Exception was thrown by Zookeeper

[jira] [Closed] (FLINK-32038) OffsetCommitMode.Kafka_periodic with checkpointing enabled

2023-05-09 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-32038. -- Resolution: Information Provided OffsetCommitModes is an Internal implementation and

[GitHub] [flink] MartijnVisser commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0

2023-05-09 Thread via GitHub
MartijnVisser commented on PR #22546: URL: https://github.com/apache/flink/pull/22546#issuecomment-1539541455 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #587: [FLINK-31717] Fix unit tests using local kube config

2023-05-09 Thread via GitHub
gyfora commented on PR #587: URL: https://github.com/apache/flink-kubernetes-operator/pull/587#issuecomment-1539505864 @mateczagany seems like we are losing some test coverage by simply deleting the operator itcase. Why did you decide to delete it? -- This is an automated message from

[GitHub] [flink-benchmarks] MartijnVisser merged pull request #70: [FLINK-31965] Fix ClassNotFoundException in benchmarks

2023-05-09 Thread via GitHub
MartijnVisser merged PR #70: URL: https://github.com/apache/flink-benchmarks/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-32039) ExecutorServiceResource and ExecutorServiceExtension's shutdown mechanism doesn't include a forced shutdown

2023-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32039: --- Labels: pull-request-available (was: ) > ExecutorServiceResource and

[GitHub] [flink] XComp opened a new pull request, #22548: [FLINK-32039][test] Adds graceful shutdown to TestExecutorExtension and TestExecutorResource

2023-05-09 Thread via GitHub
XComp opened a new pull request, #22548: URL: https://github.com/apache/flink/pull/22548 ## What is the purpose of the change The shutdown of the `executorService` is triggered but no check for hanging threads is done. This PR adds the graceful shutdown and forces threads to be

[GitHub] [flink] qinf commented on a diff in pull request #21963: [FLINK-31114][runtime] Set parallelism of job vertices in forward group at compilation phase

2023-05-09 Thread via GitHub
qinf commented on code in PR #21963: URL: https://github.com/apache/flink/pull/21963#discussion_r1189291976 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -205,7 +216,7 @@ private StreamingJobGraphGenerator(

[GitHub] [flink] reswqa merged pull request #22553: [BP-1.16][FLINK-32027][runtime] Fix the potential concurrent reading bug of index file for SortMergeShuffle.

2023-05-09 Thread via GitHub
reswqa merged PR #22553: URL: https://github.com/apache/flink/pull/22553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-jdbc] ruanhang1993 opened a new pull request, #46: [hotfix][test] remove non-used code in tests

2023-05-09 Thread via GitHub
ruanhang1993 opened a new pull request, #46: URL: https://github.com/apache/flink-connector-jdbc/pull/46 This PR removes non-used code in tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

2023-05-09 Thread via GitHub
zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1188442180 ## README.md: ## Review Comment: The ide setup guide says that eclipse isn't supported:

[GitHub] [flink] zentol commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

2023-05-09 Thread via GitHub
zentol commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1188449141 ## flink-formats/flink-sql-parquet/pom.xml: ## @@ -42,12 +42,14 @@ under the License. org.apache.flink flink-parquet

[GitHub] [flink-connector-aws] reswqa commented on pull request #71: [hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-09 Thread via GitHub
reswqa commented on PR #71: URL: https://github.com/apache/flink-connector-aws/pull/71#issuecomment-1539944421 Hi @dannycranmer, would you mind taking a look at this? I'm not sure if the version of `4.1.0` is suitable for the `master` branch, perhaps '4.2.0' or '4.2.0-SNAPSHOT' is

[GitHub] [flink-kubernetes-operator] yangjf2019 opened a new pull request, #589: [hotfix][docs] Fix flink version in doc and yaml

2023-05-09 Thread via GitHub
yangjf2019 opened a new pull request, #589: URL: https://github.com/apache/flink-kubernetes-operator/pull/589 ## What is the purpose of the change * I changed the flink version in the doc and yaml to 1.16.* ## Brief change log *I modified some files in the

[jira] [Updated] (FLINK-31919) Skip ClosureCleaner if object can be serialized

2023-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31919: --- Labels: pull-request-available (was: ) > Skip ClosureCleaner if object can be serialized >

[GitHub] [flink] zentol opened a new pull request, #22551: [FLINK-31919][core] Only run closure cleaner if serialization fails

2023-05-09 Thread via GitHub
zentol opened a new pull request, #22551: URL: https://github.com/apache/flink/pull/22551 Avoid unnecessary reflective accesses by the closure cleaner by only running it on objects/fields for which serialization fails. In the ideal world this means it is only applied to user

[GitHub] [flink] flinkbot commented on pull request #22551: [FLINK-31919][core] Only run closure cleaner if serialization fails

2023-05-09 Thread via GitHub
flinkbot commented on PR #22551: URL: https://github.com/apache/flink/pull/22551#issuecomment-1539987387 ## CI report: * 45219fe99c9ef7b865ab6d25704a54d305efa86d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-aws] dannycranmer commented on pull request #71: [hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-09 Thread via GitHub
dannycranmer commented on PR #71: URL: https://github.com/apache/flink-connector-aws/pull/71#issuecomment-1540020969 > I'm not sure if the version of 4.1.0 is suitable for the master branch, perhaps 4.2.0 or 4.2.0-SNAPSHOT is more appropriate. I suppose 4.2.0-SNAPSHOT is the best

[GitHub] [flink] hlteoh37 commented on pull request #21538: [FLINK-24386] Guard JobMaster against exceptions from starting the Op…

2023-05-09 Thread via GitHub
hlteoh37 commented on PR #21538: URL: https://github.com/apache/flink/pull/21538#issuecomment-1540023419 Converted to draft because this change needs a lot more testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-connector-aws] reswqa commented on pull request #71: [hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-09 Thread via GitHub
reswqa commented on PR #71: URL: https://github.com/apache/flink-connector-aws/pull/71#issuecomment-1540024159 > Right now thought it says ["Only available for stable versions."](https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/kinesis/) so I think it is ok

[GitHub] [flink] snuyanzin commented on pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException

2023-05-09 Thread via GitHub
snuyanzin commented on PR #22544: URL: https://github.com/apache/flink/pull/22544#issuecomment-1539842522 LGTM Also confirm that without fix test is failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] wanglijie95 commented on a diff in pull request #21963: [FLINK-31114][runtime] Set parallelism of job vertices in forward group at compilation phase

2023-05-09 Thread via GitHub
wanglijie95 commented on code in PR #21963: URL: https://github.com/apache/flink/pull/21963#discussion_r1188448597 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -205,7 +216,7 @@ private

[GitHub] [flink-connector-rabbitmq] reswqa merged pull request #10: [hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-09 Thread via GitHub
reswqa merged PR #10: URL: https://github.com/apache/flink-connector-rabbitmq/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-rabbitmq] reswqa merged pull request #11: [BP-3.0][hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-09 Thread via GitHub
reswqa merged PR #11: URL: https://github.com/apache/flink-connector-rabbitmq/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-aws] dannycranmer commented on pull request #71: [hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-09 Thread via GitHub
dannycranmer commented on PR #71: URL: https://github.com/apache/flink-connector-aws/pull/71#issuecomment-1540021047 > I'm not sure if the version of 4.1.0 is suitable for the master branch, perhaps 4.2.0 or 4.2.0-SNAPSHOT is more appropriate. I suppose 4.2.0-SNAPSHOT is the best

[jira] [Comment Edited] (FLINK-25909) Move HBase token obtain functionality into HBaseDelegationTokenProvider

2023-05-09 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720887#comment-17720887 ] Lijie Wang edited comment on FLINK-25909 at 5/9/23 10:01 AM: - Hi

[GitHub] [flink] wanglijie95 commented on a diff in pull request #21963: [FLINK-31114][runtime] Set parallelism of job vertices in forward group at compilation phase

2023-05-09 Thread via GitHub
wanglijie95 commented on code in PR #21963: URL: https://github.com/apache/flink/pull/21963#discussion_r1188448597 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -205,7 +216,7 @@ private

[GitHub] [flink-connector-elasticsearch] reswqa merged pull request #61: [BP-3.0][hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-09 Thread via GitHub
reswqa merged PR #61: URL: https://github.com/apache/flink-connector-elasticsearch/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-elasticsearch] reswqa merged pull request #60: [hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-09 Thread via GitHub
reswqa merged PR #60: URL: https://github.com/apache/flink-connector-elasticsearch/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wsry commented on pull request #22549: [FLNK-32027] Fix the potential concurrent reading bug of index file for SortMergeShuffle.

2023-05-09 Thread via GitHub
wsry commented on PR #22549: URL: https://github.com/apache/flink/pull/22549#issuecomment-1540005169 @reswqa Thanks for the fix, change LGTM. A typo in title: FLNK -> FLINK, you can correct it when merging. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-32027) Batch jobs could hang at shuffle phase when max parallelism is really large

2023-05-09 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao updated FLINK-32027: Fix Version/s: 1.16.2 1.17.1 > Batch jobs could hang at shuffle phase when max

[jira] [Updated] (FLINK-32027) Batch jobs could hang at shuffle phase when max parallelism is really large

2023-05-09 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao updated FLINK-32027: Affects Version/s: 1.16.1 1.17.0 > Batch jobs could hang at shuffle phase

[jira] [Commented] (FLINK-32009) Slot request bulk is not fulfillable! Could not allocate the required slot within slot request timeout

2023-05-09 Thread hanjie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720822#comment-17720822 ] hanjie commented on FLINK-32009: [~huwh]  Zookeeper Cluster often trigger "OOM".  Now, tasks move to

[jira] [Reopened] (FLINK-23982) Compiling error in WindowOperatorTest

2023-05-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reopened FLINK-23982: --- > Compiling error in WindowOperatorTest > - > >

[GitHub] [flink] flinkbot commented on pull request #22549: [FLNK-32027] Fix the potential concurrent reading bug of index file for SortMergeShuffle.

2023-05-09 Thread via GitHub
flinkbot commented on PR #22549: URL: https://github.com/apache/flink/pull/22549#issuecomment-1539664472 ## CI report: * 018ef030ee00a64c146b9223d17d6504e54fb918 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-web] echauchot merged pull request #631: Add blog article: Howto migrate a real-life batch pipeline from the DataSet API to the DataStream API

2023-05-09 Thread via GitHub
echauchot merged PR #631: URL: https://github.com/apache/flink-web/pull/631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-32040) The WatermarkStrategy defined with the Function(with_idleness) report an error

2023-05-09 Thread Joekwal (Jira)
Joekwal created FLINK-32040: --- Summary: The WatermarkStrategy defined with the Function(with_idleness) report an error Key: FLINK-32040 URL: https://issues.apache.org/jira/browse/FLINK-32040 Project: Flink

[jira] [Updated] (FLINK-32040) The WatermarkStrategy defined with the Function(with_idleness) report an error

2023-05-09 Thread Joekwal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joekwal updated FLINK-32040: Description: *version:* upgrade pyflink1.15.2 to pyflink1.16.1   *Report an error:* Record has Java

[GitHub] [flink] flinkbot commented on pull request #22550: [FLINK-31609][yarn][test] Extend log whitelist for expected AMRM heartbeat interrupt

2023-05-09 Thread via GitHub
flinkbot commented on PR #22550: URL: https://github.com/apache/flink/pull/22550#issuecomment-1539778154 ## CI report: * 7042bc73e48eb5df05d27d33325dfd7cea736c04 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-aws] vahmed-hamdy opened a new pull request, #70: [FLINK-31772] Adjusting Kinesis Ratelimiting strategy to fix performance regression

2023-05-09 Thread via GitHub
vahmed-hamdy opened a new pull request, #70: URL: https://github.com/apache/flink-connector-aws/pull/70 ## Purpose of the change Addressing performance regression observed in kinesis sink in FLINK-31772. ## Verifying this change Please make sure both new and

[GitHub] [flink-connector-aws] vahmed-hamdy commented on pull request #70: [FLINK-31772] Adjusting Kinesis Ratelimiting strategy to fix performance regression

2023-05-09 Thread via GitHub
vahmed-hamdy commented on PR #70: URL: https://github.com/apache/flink-connector-aws/pull/70#issuecomment-1539815851 @dannycranmer Could we rerun the pipeline and merge if passed plz? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-connector-aws] vahmed-hamdy closed pull request #70: [FLINK-31772] Adjusting Kinesis Ratelimiting strategy to fix performance regression

2023-05-09 Thread via GitHub
vahmed-hamdy closed pull request #70: [FLINK-31772] Adjusting Kinesis Ratelimiting strategy to fix performance regression URL: https://github.com/apache/flink-connector-aws/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-connector-aws] vahmed-hamdy commented on pull request #70: [FLINK-31772] Adjusting Kinesis Ratelimiting strategy to fix performance regression

2023-05-09 Thread via GitHub
vahmed-hamdy commented on PR #70: URL: https://github.com/apache/flink-connector-aws/pull/70#issuecomment-1539815250 @dannycranmer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] XComp commented on pull request #22548: [FLINK-32039][test] Adds graceful shutdown to TestExecutorExtension and TestExecutorResource

2023-05-09 Thread via GitHub
XComp commented on PR #22548: URL: https://github.com/apache/flink/pull/22548#issuecomment-1539570363 Follow-up task that was extraced from PR #22544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink-connector-aws] vahmed-hamdy commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-05-09 Thread via GitHub
vahmed-hamdy commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1188206446 ## flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AwsClientFactory.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-05-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720810#comment-17720810 ] Matthias Pohl commented on FLINK-30629: ---

[jira] [Commented] (FLINK-23982) Compiling error in WindowOperatorTest with JDK11

2023-05-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720821#comment-17720821 ] Matthias Pohl commented on FLINK-23982: --- It's happened once again in this run:

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22352: [FLINK-31639][network] Introduce tiered store memory manager

2023-05-09 Thread via GitHub
TanYuxin-tyx commented on code in PR #22352: URL: https://github.com/apache/flink/pull/22352#discussion_r1188318141 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManager.java: ## @@ -0,0 +1,98 @@ +/* + *

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22352: [FLINK-31639][network] Introduce tiered store memory manager

2023-05-09 Thread via GitHub
TanYuxin-tyx commented on code in PR #22352: URL: https://github.com/apache/flink/pull/22352#discussion_r1188359934 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManager.java: ## @@ -0,0 +1,98 @@ +/* + *

[jira] [Updated] (FLINK-32040) The WatermarkStrategy defined with the Function(with_idleness) report an error

2023-05-09 Thread Joekwal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joekwal updated FLINK-32040: Description: *version:* upgrade pyflink1.15.2 to pyflink1.16.1   *Report an error:* Record has Java

  1   2   >