[GitHub] [flink-statefun] leijurv opened a new pull request, #329: Correct date format for startupPosition in documentation

2023-05-28 Thread via GitHub
leijurv opened a new pull request, #329: URL: https://github.com/apache/flink-statefun/pull/329 The example string provided in the documentation does not actually parse. It causes an exception: `Unable to parse date string for startup position: 2020-02-01 04:15:00.00 Z; the date should

[jira] [Updated] (FLINK-31673) Add E2E tests for flink jdbc driver

2023-05-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31673: --- Labels: pull-request-available (was: ) > Add E2E tests for flink jdbc driver >

[jira] [Closed] (FLINK-32148) Reduce info logging noise in the operator

2023-05-28 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-32148. -- Fix Version/s: kubernetes-operator-1.6.0 Resolution: Fixed merged to main

[jira] [Closed] (FLINK-32147) Deduplicate scaling report messages

2023-05-28 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-32147. -- Resolution: Fixed merged to main 57974b61590e1976785fbdd4a40dafa975fc9521 > Deduplicate scaling

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #608: [FLINK-32147] Deduplicate scaling report messages

2023-05-28 Thread via GitHub
gyfora merged PR #608: URL: https://github.com/apache/flink-kubernetes-operator/pull/608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-32147) Deduplicate scaling report messages

2023-05-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32147: --- Labels: pull-request-available (was: ) > Deduplicate scaling report messages >

[GitHub] [flink] xuzhiwen1255 commented on a diff in pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-05-28 Thread via GitHub
xuzhiwen1255 commented on code in PR #22010: URL: https://github.com/apache/flink/pull/22010#discussion_r1208764798 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -65,33 +71,46 @@ public void open(

[GitHub] [flink] WencongLiu commented on pull request #22579: [FLINK-32059] Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and batch.sql.join to JUnit5

2023-05-28 Thread via GitHub
WencongLiu commented on PR #22579: URL: https://github.com/apache/flink/pull/22579#issuecomment-1566589461 @snuyanzin Do you have any other suggestions?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Assigned] (FLINK-31673) Add E2E tests for flink jdbc driver

2023-05-28 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-31673: -- Assignee: Fang Yong > Add E2E tests for flink jdbc driver >

[GitHub] [flink] reswqa commented on a diff in pull request #22579: [FLINK-32059] Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and batch.sql.join to JUnit5

2023-05-28 Thread via GitHub
reswqa commented on code in PR #22579: URL: https://github.com/apache/flink/pull/22579#discussion_r1208865416 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/SemiJoinITCase.scala: ## @@ -470,7 +469,7 @@ class

[GitHub] [flink-statefun] leijurv commented on pull request #329: Correct date format for startupPosition in documentation

2023-05-28 Thread via GitHub
leijurv commented on PR #329: URL: https://github.com/apache/flink-statefun/pull/329#issuecomment-1566269417 Appears to have been added here

[GitHub] [flink-connector-kafka] loserwang1024 commented on a diff in pull request #28: [FLINK-32019][Connector/Kafka] EARLIEST offset strategy for partitions discoveried later based on FLIP-288

2023-05-28 Thread via GitHub
loserwang1024 commented on code in PR #28: URL: https://github.com/apache/flink-connector-kafka/pull/28#discussion_r1208763810 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/KafkaSourceEnumState.java: ## @@ -22,18 +22,69 @@ import

[GitHub] [flink] xuzhiwen1255 commented on pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-05-28 Thread via GitHub
xuzhiwen1255 commented on PR #22010: URL: https://github.com/apache/flink/pull/22010#issuecomment-1566386306 > > I think about it, the change of parallelism already exists in the existing unit test, I think we don't need to add the test, because it already includes the complete generated

[GitHub] [flink] flinkbot commented on pull request #22670: [FLINK-28386] Trigger an immediate checkpoint after all sinks finished

2023-05-28 Thread via GitHub
flinkbot commented on PR #22670: URL: https://github.com/apache/flink/pull/22670#issuecomment-1566409752 ## CI report: * f580c138ec78894c8058daf86993d63ca615647d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] libenchao commented on pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver

2023-05-28 Thread via GitHub
libenchao commented on PR #22583: URL: https://github.com/apache/flink/pull/22583#issuecomment-1566533577 @FangYongs By saying "e2e test", I mean the tests in `flink-end-to-end-tests` module. What do you think about adding it there? -- This is an automated message from the Apache Git

[GitHub] [flink] jiangxin369 opened a new pull request, #22670: [FLINK-28386] Trigger an immediate checkpoint after all sinks finished

2023-05-28 Thread via GitHub
jiangxin369 opened a new pull request, #22670: URL: https://github.com/apache/flink/pull/22670 ## What is the purpose of the change Triggers an immediate checkpoint after all sinks are finished to advance the timing of bounded jobs finished. ## Brief change log

[jira] [Updated] (FLINK-28386) Trigger an immediate checkpoint after all sources finished

2023-05-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28386: --- Labels: pull-request-available (was: ) > Trigger an immediate checkpoint after all sources

[GitHub] [flink] 1996fanrui commented on pull request #22560: [FLINK-32023][API / DataStream] Support negative Duration for special usage, such as -1ms for execution.buffer-timeout

2023-05-28 Thread via GitHub
1996fanrui commented on PR #22560: URL: https://github.com/apache/flink/pull/22560#issuecomment-1566406137 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] LadyForest commented on pull request #22539: [FLINK-31956][table] Extend the CompiledPlan to read from/write to Fl…

2023-05-28 Thread via GitHub
LadyForest commented on PR #22539: URL: https://github.com/apache/flink/pull/22539#issuecomment-1565947626 By the way, you can evaluate the param `table.resources.download-dir` by the command `SET;` to verify that the remote plan is downloaded under this dir and is cleaned up when the

[GitHub] [flink] curcur commented on a diff in pull request #22590: [FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

2023-05-28 Thread via GitHub
curcur commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1208271576 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManager.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache

[GitHub] [flink] WencongLiu commented on pull request #22579: [FLINK-32059] Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and batch.sql.join to JUnit5

2023-05-28 Thread via GitHub
WencongLiu commented on PR #22579: URL: https://github.com/apache/flink/pull/22579#issuecomment-1566142552 Thanks for the careful review from @reswqa and @TanYuxin-tyx . I've made a round of changes.  -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-28 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726933#comment-17726933 ] Feifan Wang commented on FLINK-29913: - Thanks for your information [~klion26] , I would like to add

[GitHub] [flink] WencongLiu commented on a diff in pull request #22579: [FLINK-32059] Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and batch.sql.join to JUnit5

2023-05-28 Thread via GitHub
WencongLiu commented on code in PR #22579: URL: https://github.com/apache/flink/pull/22579#discussion_r1208550805 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/SemiJoinITCase.scala: ## @@ -470,7 +469,7 @@ class