[GitHub] [flink] Baibaiwuguo commented on pull request #22805: [FLINK-32365][orc]get orc table statistics in parallel

2023-06-19 Thread via GitHub
Baibaiwuguo commented on PR #22805: URL: https://github.com/apache/flink/pull/22805#issuecomment-1596649244 @luoyuxia I also think tasks can be configured more rationally. I will refine this issue. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] Baibaiwuguo commented on pull request #22805: [FLINK-32365][orc]get orc table statistics in parallel

2023-06-19 Thread via GitHub
Baibaiwuguo commented on PR #22805: URL: https://github.com/apache/flink/pull/22805#issuecomment-1596650060 @luoyuxia I also think tasks can be configured more rationally. I will refine this issue. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink-connector-elasticsearch] snuyanzin merged pull request #69: [FLINK-32357] Elasticsearch v3.0 won't compile when testing against Flink 1.17.1

2023-06-19 Thread via GitHub
snuyanzin merged PR #69: URL: https://github.com/apache/flink-connector-elasticsearch/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-32375) Flink AWS Source AssumeRole in VPC

2023-06-19 Thread Tomas Witzany (Jira)
Tomas Witzany created FLINK-32375: - Summary: Flink AWS Source AssumeRole in VPC Key: FLINK-32375 URL: https://issues.apache.org/jira/browse/FLINK-32375 Project: Flink Issue Type: New Feature

[jira] [Assigned] (FLINK-32371) Bump snappy-java to 1.1.10.1

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-32371: - Assignee: Ryan Skraba > Bump snappy-java to 1.1.10.1 > >

[GitHub] [flink] reswqa closed pull request #22799: [FLINK-25872][state/changelog] Hotfix! Fix the description of Changel…

2023-06-19 Thread via GitHub
reswqa closed pull request #22799: [FLINK-25872][state/changelog] Hotfix! Fix the description of Changel… URL: https://github.com/apache/flink/pull/22799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (FLINK-32375) Flink AWS Source AssumeRole in VPC

2023-06-19 Thread Tomas Witzany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Witzany updated FLINK-32375: -- Environment: Flink 1.15.4 running on Amazon KDA (managed flink) runtime is running inside a

[jira] [Updated] (FLINK-32375) Flink AWS Source AssumeRole in VPC

2023-06-19 Thread Tomas Witzany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Witzany updated FLINK-32375: -- Description: Current way to configure auth against AWS supports assuming a role, but when

[GitHub] [flink] XComp merged pull request #22811: [BP-1.16][FLINK-32368][test] Fixes wrong interface implementation in KubernetesTestFixture

2023-06-19 Thread via GitHub
XComp merged PR #22811: URL: https://github.com/apache/flink/pull/22811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp commented on pull request #22812: [BP-1.17][FLINK-32368][test] Fixes wrong interface implementation in KubernetesTestFixture

2023-06-19 Thread via GitHub
XComp commented on PR #22812: URL: https://github.com/apache/flink/pull/22812#issuecomment-1596601094 Merging - the parent PR was approved, CI succeeded and there were no conflicts during backport -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] XComp merged pull request #22812: [BP-1.17][FLINK-32368][test] Fixes wrong interface implementation in KubernetesTestFixture

2023-06-19 Thread via GitHub
XComp merged PR #22812: URL: https://github.com/apache/flink/pull/22812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp commented on pull request #22811: [BP-1.16][FLINK-32368][test] Fixes wrong interface implementation in KubernetesTestFixture

2023-06-19 Thread via GitHub
XComp commented on PR #22811: URL: https://github.com/apache/flink/pull/22811#issuecomment-1596601321 Merging - the parent PR was approved, CI succeeded and there were no conflicts during backport -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (FLINK-32375) Flink AWS Source AssumeRole in VPC

2023-06-19 Thread Tomas Witzany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Witzany updated FLINK-32375: -- Description: Current way to configure auth against AWS supports assuming a role, but when

[jira] [Updated] (FLINK-32375) Flink AWS Source AssumeRole in VPC

2023-06-19 Thread Tomas Witzany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Witzany updated FLINK-32375: -- Description: Current way to configure auth against AWS supports assuming a role, but when

[jira] [Updated] (FLINK-32375) Flink AWS Source AssumeRole in VPC

2023-06-19 Thread Tomas Witzany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Witzany updated FLINK-32375: -- Description: Current way to configure auth against AWS supports assuming a role, but when

[jira] [Comment Edited] (FLINK-32368) KubernetesTestFixture doesn't implement the checkAndUpdateConfigMapFunction properly

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733565#comment-17733565 ] Matthias Pohl edited comment on FLINK-32368 at 6/19/23 6:46 AM: master:

[jira] [Resolved] (FLINK-32368) KubernetesTestFixture doesn't implement the checkAndUpdateConfigMapFunction properly

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-32368. --- Fix Version/s: 1.16.3 1.17.2 Resolution: Fixed >

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234664689 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TestingTierFactory.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed

[GitHub] [flink] zhuzhurk closed pull request #22798: [FLINK-32288][runtime] Improve the scheduling performance of AdaptiveBatchScheduler

2023-06-19 Thread via GitHub
zhuzhurk closed pull request #22798: [FLINK-32288][runtime] Improve the scheduling performance of AdaptiveBatchScheduler URL: https://github.com/apache/flink/pull/22798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] luoyuxia commented on a diff in pull request #22721: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table

2023-06-19 Thread via GitHub
luoyuxia commented on code in PR #22721: URL: https://github.com/apache/flink/pull/22721#discussion_r1234691322 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowPartitionsOperation.java: ## @@ -66,10 +66,6 @@ public CatalogPartitionSpec

[GitHub] [flink] FangYongs commented on pull request #22768: [FLINK-32309][sql-gateway] Use independent resource manager for table environment

2023-06-19 Thread via GitHub
FangYongs commented on PR #22768: URL: https://github.com/apache/flink/pull/22768#issuecomment-1598082695 Hi @fsk119 Please help to review this PR when you are free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] snuyanzin commented on pull request #17867: [FLINK-24592][Table SQL/Client] FlinkSQL Client multiline parser improvements

2023-06-19 Thread via GitHub
snuyanzin commented on PR #17867: URL: https://github.com/apache/flink/pull/17867#issuecomment-1598142720 Thanks for having a look @reswqa , @fsk119 I've rebased, tests are passed will merge soon -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234664689 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TestingTierFactory.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed

[GitHub] [flink] LoveHeat commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-19 Thread via GitHub
LoveHeat commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1234672707 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[GitHub] [flink] WencongLiu commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
WencongLiu commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234687374 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateFactory.java: ## @@ -158,9 +166,34 @@ public SingleInputGate

[jira] [Closed] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-19 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li closed FLINK-32370. -- Assignee: Fang Yong Resolution: Fixed Fixed via

[jira] [Created] (FLINK-32385) Introduce a struct SerializedShuffleDescriptorAndIndices to identify a group of ShuffleDescriptorAndIndex

2023-06-19 Thread Weihua Hu (Jira)
Weihua Hu created FLINK-32385: - Summary: Introduce a struct SerializedShuffleDescriptorAndIndices to identify a group of ShuffleDescriptorAndIndex Key: FLINK-32385 URL:

[jira] [Updated] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-19 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-32370: --- Component/s: Tests > JDBC SQl gateway e2e test is unstable > -

[GitHub] [flink] WencongLiu commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
WencongLiu commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234687042 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java: ## @@ -217,6 +222,12 @@ public class SingleInputGate

[GitHub] [flink] WencongLiu commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
WencongLiu commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234687515 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java: ## @@ -280,7 +281,8 @@ private

[jira] [Created] (FLINK-32386) Add ShuffleDescriptorsCache in TaskExecutor to cache ShuffleDescriptors

2023-06-19 Thread Weihua Hu (Jira)
Weihua Hu created FLINK-32386: - Summary: Add ShuffleDescriptorsCache in TaskExecutor to cache ShuffleDescriptors Key: FLINK-32386 URL: https://issues.apache.org/jira/browse/FLINK-32386 Project: Flink

[jira] [Commented] (FLINK-32137) Flame graph is hard to use with many task managers

2023-06-19 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735128#comment-17735128 ] Rui Fan commented on FLINK-32137: - A mistake has just occurred about assignee. Hi [~netvl] , thanks a

[jira] [Created] (FLINK-32384) Remove deprecated configuration keys which violate YAML spec

2023-06-19 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-32384: --- Summary: Remove deprecated configuration keys which violate YAML spec Key: FLINK-32384 URL: https://issues.apache.org/jira/browse/FLINK-32384 Project: Flink Issue

[GitHub] [flink] LoveHeat commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-19 Thread via GitHub
LoveHeat commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1234672707 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[jira] [Created] (FLINK-32387) InputGateDeploymentDescriptor uses cache to avoid deserializing shuffle descriptors multiple times

2023-06-19 Thread Weihua Hu (Jira)
Weihua Hu created FLINK-32387: - Summary: InputGateDeploymentDescriptor uses cache to avoid deserializing shuffle descriptors multiple times Key: FLINK-32387 URL: https://issues.apache.org/jira/browse/FLINK-32387

[GitHub] [flink] curcur commented on pull request #22590: [FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

2023-06-19 Thread via GitHub
curcur commented on PR #22590: URL: https://github.com/apache/flink/pull/22590#issuecomment-1598107276 @Zakelly Thanks for the efforts! I've gone through another pass, LGTM. A couple of things left: 1. squash the commits (address comments e.t.c) 2. run the bot again (the

[GitHub] [flink] LoveHeat commented on pull request #22808: [FLINK-32316] [SourceAlignment] Scheduling announceCombinedWatermark period task during SourceCoordinator::start not in construct function t

2023-06-19 Thread via GitHub
LoveHeat commented on PR #22808: URL: https://github.com/apache/flink/pull/22808#issuecomment-1598030633 The first path is(just simple call stack not full): [create JobMaster for each recovered job, and will init a scheduler object in jobmaster construct

[jira] [Assigned] (FLINK-32137) Flame graph is hard to use with many task managers

2023-06-19 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-32137: --- Assignee: Rui Fan (was: Vladimir Matveev) > Flame graph is hard to use with many task managers >

[jira] [Assigned] (FLINK-32137) Flame graph is hard to use with many task managers

2023-06-19 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-32137: --- Assignee: Vladimir Matveev (was: Rui Fan) > Flame graph is hard to use with many task managers >

[GitHub] [flink-connector-aws] Samrat002 commented on pull request #83: [FLINK-32372] Push PR support build and test with recently release fl…

2023-06-19 Thread via GitHub
Samrat002 commented on PR #83: URL: https://github.com/apache/flink-connector-aws/pull/83#issuecomment-1598036360 Hi @dannycranmer , @hlteoh37 ! Please validate if we want to add newly released minor version of flink (1.16.2 and 1.17.1) in the PR build pipeline. Thank you

[GitHub] [flink] WencongLiu commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
WencongLiu commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234687955 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java: ## @@ -813,6 +813,11 @@ private void

[GitHub] [flink] WencongLiu commented on pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
WencongLiu commented on PR #22733: URL: https://github.com/apache/flink/pull/22733#issuecomment-1598052498 Thanks for the review from @TanYuxin-tyx and @reswqa ! I've made a round of changes.  -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (FLINK-32310) Support enhanced show functions syntax

2023-06-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735108#comment-17735108 ] luoyuxia commented on FLINK-32310: -- [~lemonjing] Sorry to bother you. I'm wondering there's any

[jira] [Updated] (FLINK-32375) Flink AWS Source AssumeRole in VPC

2023-06-19 Thread Tomas Witzany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Witzany updated FLINK-32375: -- Description: Current way to configure auth against AWS supports assuming a role, but when

[GitHub] [flink] snuyanzin commented on pull request #22717: [FLINK-31665] [table] Add ARRAY_CONCAT function

2023-06-19 Thread via GitHub
snuyanzin commented on PR #22717: URL: https://github.com/apache/flink/pull/22717#issuecomment-1596713498 Thanks for the work @hanyuzheng7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] snuyanzin merged pull request #22717: [FLINK-31665] [table] Add ARRAY_CONCAT function

2023-06-19 Thread via GitHub
snuyanzin merged PR #22717: URL: https://github.com/apache/flink/pull/22717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-32371) Bump snappy-java to 1.1.10.1

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734063#comment-17734063 ] Matthias Pohl commented on FLINK-32371: --- master: ba47237a0a44222a275ba7a1d144822466d20f15 1.17:

[jira] [Updated] (FLINK-32371) Bump snappy-java to 1.1.10.1

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-32371: -- Fix Version/s: 1.18.0 > Bump snappy-java to 1.1.10.1 > > >

[GitHub] [flink] flinkbot commented on pull request #22822: [FLINK-32271][build] Bump snappy-java to 1.1.10.1

2023-06-19 Thread via GitHub
flinkbot commented on PR #22822: URL: https://github.com/apache/flink/pull/22822#issuecomment-1596773801 ## CI report: * 763d7627f08132791aef0351dfc551fb791dcd2f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22823: [BP-1.16][FLINK-32371][build] Bump snappy-java to 1.1.10.1

2023-06-19 Thread via GitHub
flinkbot commented on PR #22823: URL: https://github.com/apache/flink/pull/22823#issuecomment-1596793069 ## CI report: * bc32acd3331fe6faf9777a4ec0ae93b5b7d67712 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-7957) Add MetricGroup#getLogicalScope

2023-06-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7957: Parent: FLINK-32378 Issue Type: Sub-task (was: Improvement) > Add

[jira] [Updated] (FLINK-6053) Gauge should only take subclasses of Number, rather than everything

2023-06-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6053: Parent: FLINK-32378 Issue Type: Sub-task (was: Improvement) > Gauge should only

[jira] [Updated] (FLINK-14350) Introduce dedicated MetricScope

2023-06-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-14350: - Parent: FLINK-32378 Issue Type: Sub-task (was: Improvement) > Introduce

[GitHub] [flink] LadyForest opened a new pull request, #22825: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-19 Thread via GitHub
LadyForest opened a new pull request, #22825: URL: https://github.com/apache/flink/pull/22825 ## What is the purpose of the change This pull request is cherry-picked from commit f69ed3454f2ab200310edee230da292ee2408503 ## Brief change log Please see #22820

[GitHub] [flink] XComp merged pull request #22640: [FLINK-31782][runtime] Makes DefaultLeaderElectionService implement MultipleComponentLeaderElectionDriver.Listener

2023-06-19 Thread via GitHub
XComp merged PR #22640: URL: https://github.com/apache/flink/pull/22640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-32375) Flink AWS Source AssumeRole in VPC

2023-06-19 Thread Tomas Witzany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Witzany updated FLINK-32375: -- Description: Current way to configure auth against AWS supports assuming a role, but when

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22804: [FLINK-31644][network] Implement the disk tier producer for the tiered storage

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #22804: URL: https://github.com/apache/flink/pull/22804#discussion_r1233853583 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/file/PartitionFileIndexImpl.java: ## @@ -0,0 +1,159 @@ +/* + *

[GitHub] [flink-connector-aws] dannycranmer commented on pull request #81: [FLINK-31923] Run nightly builds against multiple branches and Flink versions

2023-06-19 Thread via GitHub
dannycranmer commented on PR #81: URL: https://github.com/apache/flink-connector-aws/pull/81#issuecomment-1596921636 > > I believe the failure is due to the Maven version not supporting the shading config. > > What's the plan to address this, given that Flink and other connectors

[jira] [Commented] (FLINK-32375) Flink AWS Source AssumeRole in VPC

2023-06-19 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734109#comment-17734109 ] Danny Cranmer commented on FLINK-32375: --- Hello. This is fixed in Flink 1.17 (FLINK-29496).

[jira] [Resolved] (FLINK-32375) Flink AWS Source AssumeRole in VPC

2023-06-19 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-32375. --- Resolution: Duplicate > Flink AWS Source AssumeRole in VPC >

[GitHub] [flink] XComp commented on pull request #22822: [BP-1.17][FLINK-32371][build] Bump snappy-java to 1.1.10.1

2023-06-19 Thread via GitHub
XComp commented on PR #22822: URL: https://github.com/apache/flink/pull/22822#issuecomment-1596786411 Force-push: I fixed the commit message typo ([FLINK-32271](https://issues.apache.org/jira/browse/FLINK-32271) -> [FLINK-32371](https://issues.apache.org/jira/browse/FLINK-32371)) --

[GitHub] [flink] XComp commented on pull request #22823: [BP-1.16][FLINK-32371][build] Bump snappy-java to 1.1.10.1

2023-06-19 Thread via GitHub
XComp commented on PR #22823: URL: https://github.com/apache/flink/pull/22823#issuecomment-1596784737 I fixed the commit message typo (FLINK-32271 -> FLINK-32371) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] luoyuxia merged pull request #22820: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-19 Thread via GitHub
luoyuxia merged PR #22820: URL: https://github.com/apache/flink/pull/22820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zentol commented on pull request #22656: [FLINK-32180][runtime] Moves error handling from DefaultMultipleComponentLeaderElectionService into the MultipleComponentLeaderElectionDriver

2023-06-19 Thread via GitHub
zentol commented on PR #22656: URL: https://github.com/apache/flink/pull/22656#issuecomment-1596826669 > we should do that in a separate (followup-)ticket after the migration is done. sounds good. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] luoyuxia commented on pull request #22820: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-19 Thread via GitHub
luoyuxia commented on PR #22820: URL: https://github.com/apache/flink/pull/22820#issuecomment-1596827971 @LadyForest Could you please backport to 1.17 & 1.16. Thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] LadyForest commented on pull request #22820: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-19 Thread via GitHub
LadyForest commented on PR #22820: URL: https://github.com/apache/flink/pull/22820#issuecomment-1596832437 > @LadyForest Could you please backport to 1.17 & 1.16. Thx. Sure :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (FLINK-32380) Serialization of Java records fails

2023-06-19 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32380: Summary: Serialization of Java records fails Key: FLINK-32380 URL: https://issues.apache.org/jira/browse/FLINK-32380 Project: Flink Issue Type:

[GitHub] [flink] LadyForest opened a new pull request, #22826: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-19 Thread via GitHub
LadyForest opened a new pull request, #22826: URL: https://github.com/apache/flink/pull/22826 ## What is the purpose of the change This pull request is cherry-picked from commit https://github.com/apache/flink/commit/f69ed3454f2ab200310edee230da292ee2408503 ## Brief change

[GitHub] [flink] flinkbot commented on pull request #22826: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-19 Thread via GitHub
flinkbot commented on PR #22826: URL: https://github.com/apache/flink/pull/22826#issuecomment-1596899346 ## CI report: * dbc3813eb6075a53e5823c019e39c737c1c0a04e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22804: [FLINK-31644][network] Implement the disk tier producer for the tiered storage

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #22804: URL: https://github.com/apache/flink/pull/22804#discussion_r1233843144 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/file/PartitionFileWriter.java: ## @@ -0,0 +1,41 @@ +/* + *

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22804: [FLINK-31644][network] Implement the disk tier producer for the tiered storage

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #22804: URL: https://github.com/apache/flink/pull/22804#discussion_r1233849891 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/file/PartitionFileIndex.java: ## @@ -0,0 +1,109 @@ +/* + *

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22804: [FLINK-31644][network] Implement the disk tier producer for the tiered storage

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #22804: URL: https://github.com/apache/flink/pull/22804#discussion_r1233854834 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/file/ProducerMergePartitionFileWriter.java: ## @@ -0,0 +1,182

[GitHub] [flink] TanYuxin-tyx commented on pull request #22804: [FLINK-31644][network] Implement the disk tier producer for the tiered storage

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on PR #22804: URL: https://github.com/apache/flink/pull/22804#issuecomment-1596932123 @xintongsong Thanks for reviewing. I have refactored the commits of the PR. The partition file reader API is also submitted. PTAL -- This is an automated message from the

[GitHub] [flink-connector-jdbc] xushsh163 commented on pull request #63: Update AbstractPostgresCompatibleDialect.java

2023-06-19 Thread via GitHub
xushsh163 commented on PR #63: URL: https://github.com/apache/flink-connector-jdbc/pull/63#issuecomment-1596932037 @MartijnVisser In postgresql 13.10 `CREATE TABLE TEST( "LEFT" CHAR(20) );` In Flink 1.16.0 SQL-Client `CREATE TABLE test ( `LEFT` STRING ) WITH

[jira] [Updated] (FLINK-32371) Bump snappy-java to 1.1.10.1

2023-06-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32371: --- Labels: pull-request-available (was: ) > Bump snappy-java to 1.1.10.1 >

[jira] [Updated] (FLINK-32378) 2.0 Breaking Metric system changes

2023-06-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-32378: - Fix Version/s: 2.0.0 (was: 1.18.0) > 2.0 Breaking Metric system

[jira] [Updated] (FLINK-24078) Remove brackets around variables

2023-06-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-24078: - Parent: FLINK-32378 Issue Type: Sub-task (was: Technical Debt) > Remove

[GitHub] [flink] luoyuxia opened a new pull request, #22824: Flink 32352

2023-06-19 Thread via GitHub
luoyuxia opened a new pull request, #22824: URL: https://github.com/apache/flink/pull/22824 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Updated] (FLINK-32377) 2.0 Breaking REST API changes

2023-06-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-32377: - Component/s: Runtime / REST > 2.0 Breaking REST API changes >

[jira] [Created] (FLINK-32378) 2.0 Breaking Metric system changes

2023-06-19 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32378: Summary: 2.0 Breaking Metric system changes Key: FLINK-32378 URL: https://issues.apache.org/jira/browse/FLINK-32378 Project: Flink Issue Type:

[jira] [Created] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-19 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32379: Summary: Skip archunit tests in java1X-target profiles Key: FLINK-32379 URL: https://issues.apache.org/jira/browse/FLINK-32379 Project: Flink Issue

[GitHub] [flink-connector-aws] MartijnVisser commented on pull request #81: [FLINK-31923] Run nightly builds against multiple branches and Flink versions

2023-06-19 Thread via GitHub
MartijnVisser commented on PR #81: URL: https://github.com/apache/flink-connector-aws/pull/81#issuecomment-1596838891 > I believe the failure is due to the Maven version not supporting the shading config. What's the plan to address this, given that Flink and other connectors now

[jira] [Commented] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734091#comment-17734091 ] Sergey Nuyanzin commented on FLINK-32379: - Do you happen to know how to reproduce locally?

[jira] [Closed] (FLINK-32334) Operator failed to create taskmanager deployment because it already exist

2023-06-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-32334. -- Fix Version/s: kubernetes-operator-1.6.0 Resolution: Fixed merged to main

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22804: [FLINK-31644][network] Implement the disk tier producer for the tiered storage

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #22804: URL: https://github.com/apache/flink/pull/22804#discussion_r1233845440 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/file/SegmentNettyPayload.java: ## @@ -0,0 +1,55 @@ +/* + *

[GitHub] [flink] TanYuxin-tyx commented on pull request #22804: [FLINK-31644][network] Implement the disk tier producer for the tiered storage

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on PR #22804: URL: https://github.com/apache/flink/pull/22804#issuecomment-1596938547 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-connector-elasticsearch] MartijnVisser closed pull request #47: [FLINK-28347][Test infrastructure] Update testcontainers dependency to v1.18.0

2023-06-19 Thread via GitHub
MartijnVisser closed pull request #47: [FLINK-28347][Test infrastructure] Update testcontainers dependency to v1.18.0 URL: https://github.com/apache/flink-connector-elasticsearch/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (FLINK-32376) [FLIP-287] Extend Sink#InitContext to expose TypeSerializer, ObjectReuse and JobID

2023-06-19 Thread Jira
João Boto created FLINK-32376: - Summary: [FLIP-287] Extend Sink#InitContext to expose TypeSerializer, ObjectReuse and JobID Key: FLINK-32376 URL: https://issues.apache.org/jira/browse/FLINK-32376

[jira] [Updated] (FLINK-32371) Bump snappy-java to 1.1.10.1

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-32371: -- Affects Version/s: 1.17.1 1.16.2 1.18.0 > Bump

[GitHub] [flink] LadyForest commented on a diff in pull request #22620: [FLINK-31413][hive] Change scope of flink-table-planner dependency from provided to test in Hive connector

2023-06-19 Thread via GitHub
LadyForest commented on code in PR #22620: URL: https://github.com/apache/flink/pull/22620#discussion_r1233641141 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/utils/FlinkTypeUtils.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache

[jira] [Assigned] (FLINK-20887) Non-deterministic functions return different values even if it is referred with the same column name

2023-06-19 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-20887: --- Assignee: lincoln lee > Non-deterministic functions return different values even if it is

[GitHub] [flink] flinkbot commented on pull request #22824: Flink 32352

2023-06-19 Thread via GitHub
flinkbot commented on PR #22824: URL: https://github.com/apache/flink/pull/22824#issuecomment-1596804220 ## CI report: * d05f164c1fbc368260db5313a276cababeab197f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-elasticsearch] snuyanzin commented on pull request #70: [hotfix] Allow unmatched tests

2023-06-19 Thread via GitHub
snuyanzin commented on PR #70: URL: https://github.com/apache/flink-connector-elasticsearch/pull/70#issuecomment-1596825114 also passed nightly on my fork https://github.com/snuyanzin/flink-connector-elasticsearch/actions/runs/5309751461 -- This is an automated message from the Apache

[GitHub] [flink] FangYongs commented on pull request #22819: [FLINK-32370][client] Fix warn log in result fetcher when job is finished

2023-06-19 Thread via GitHub
FangYongs commented on PR #22819: URL: https://github.com/apache/flink/pull/22819#issuecomment-1596834032 Hi @libenchao Please help to review this PR for test case in JDBC and Sql Gateway when you're free, thanks -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] luoyuxia commented on pull request #22692: [FLINK-32233][table] Introduce SupportsTruncate interface

2023-06-19 Thread via GitHub
luoyuxia commented on PR #22692: URL: https://github.com/apache/flink/pull/22692#issuecomment-1596836696 @LadyForest Thanks for reviwing. Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] luoyuxia merged pull request #22692: [FLINK-32233][table] Introduce SupportsTruncate interface

2023-06-19 Thread via GitHub
luoyuxia merged PR #22692: URL: https://github.com/apache/flink/pull/22692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-32233) Introduce SupportsTruncate interface

2023-06-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-32233. Resolution: Fixed master: 1a3151b5b9f1df8aaa221b2febfae0431a69b95d > Introduce SupportsTruncate

[jira] [Created] (FLINK-32381) Replaces error handling functionality with onError method in MultipleComponentLeaderElectionDriver.Listener interface

2023-06-19 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32381: - Summary: Replaces error handling functionality with onError method in MultipleComponentLeaderElectionDriver.Listener interface Key: FLINK-32381 URL:

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22804: [FLINK-31644][network] Implement the disk tier producer for the tiered storage

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #22804: URL: https://github.com/apache/flink/pull/22804#discussion_r1233855266 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskCacheManager.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed

[jira] [Resolved] (FLINK-31665) Add ARRAY_CONCAT supported in SQL & Table API

2023-06-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-31665. - Resolution: Fixed Merged to master as

  1   2   >