[jira] [Created] (FLINK-33077) Minimize the risk of hard back-pressure with buffer debloating enabled

2023-09-12 Thread Stefan Richter (Jira)
Stefan Richter created FLINK-33077: -- Summary: Minimize the risk of hard back-pressure with buffer debloating enabled Key: FLINK-33077 URL: https://issues.apache.org/jira/browse/FLINK-33077 Project:

[GitHub] [flink] afedulov commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient fo

2023-09-12 Thread via GitHub
afedulov commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1323172674 ## flink-clients/src/main/java/org/apache/flink/client/program/rest/UrlPrefixDecorator.java: ## @@ -100,4 +105,11 @@ public Class getRequestClass() { public M

[jira] [Comment Edited] (FLINK-32804) Release Testing: Verify FLIP-304: Pluggable failure handling for Apache Flink

2023-09-12 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764255#comment-17764255 ] Panagiotis Garefalakis edited comment on FLINK-32804 at 9/12/23 3:38 PM:

[jira] [Commented] (FLINK-31778) Casting array of rows produces incorrect result

2023-09-12 Thread Nic Townsend (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764197#comment-17764197 ] Nic Townsend commented on FLINK-31778: -- Hi, I have encountered this in an additional scenario:    

[jira] [Comment Edited] (FLINK-31778) Casting array of rows produces incorrect result

2023-09-12 Thread Nic Townsend (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764197#comment-17764197 ] Nic Townsend edited comment on FLINK-31778 at 9/12/23 1:50 PM: --- Hi, I have

[jira] [Comment Edited] (FLINK-31163) Unexpected correlate variable $cor0 in the plan error in where clause

2023-09-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764293#comment-17764293 ] Sergey Nuyanzin edited comment on FLINK-31163 at 9/12/23 4:52 PM: --

[jira] [Comment Edited] (FLINK-31163) Unexpected correlate variable $cor0 in the plan error in where clause

2023-09-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764293#comment-17764293 ] Sergey Nuyanzin edited comment on FLINK-31163 at 9/12/23 4:52 PM: --

[jira] [Commented] (FLINK-32818) Support region failover for adaptive scheduler

2023-09-12 Thread Talat Uyarer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764298#comment-17764298 ] Talat Uyarer commented on FLINK-32818: -- Thank you [~fanrui] I look forward your PR :)  > Support

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
gyfora commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323424948 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void

[GitHub] [flink] flinkbot commented on pull request #23403: [FLINK-32863][runtime-web] Improve Flink UI's time precision from sec…

2023-09-12 Thread via GitHub
flinkbot commented on PR #23403: URL: https://github.com/apache/flink/pull/23403#issuecomment-1715992250 ## CI report: * 4f3ce28635392bcaf72db7e63627c7cfe5e709c0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31163) Unexpected correlate variable $cor0 in the plan error in where clause

2023-09-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764293#comment-17764293 ] Sergey Nuyanzin commented on FLINK-31163: - [~rohankrao]   it seems after upgrade to Calcite

[jira] [Assigned] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-33017: --- Assignee: Alex Sorokoumov > Nightly run for Flink Kafka connector fails >

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323380347 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323381133 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void

[jira] [Commented] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764320#comment-17764320 ] Tzu-Li (Gordon) Tai commented on FLINK-33017: - Fixed via: apache/flink-connector-kafka:main

[jira] [Updated] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-33017: Fix Version/s: kafka-3.0.1 kafka-3.1.0 > Nightly run for Flink

[jira] [Commented] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764321#comment-17764321 ] Tzu-Li (Gordon) Tai commented on FLINK-33017: - Lets only resolve this ticket once we have a

[jira] [Comment Edited] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764321#comment-17764321 ] Tzu-Li (Gordon) Tai edited comment on FLINK-33017 at 9/12/23 5:55 PM:

[jira] [Comment Edited] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764321#comment-17764321 ] Tzu-Li (Gordon) Tai edited comment on FLINK-33017 at 9/12/23 5:55 PM:

[GitHub] [flink] venkata91 commented on a diff in pull request #23164: [FLINK- 32775]Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-12 Thread via GitHub
venkata91 commented on code in PR #23164: URL: https://github.com/apache/flink/pull/23164#discussion_r1323383321 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java: ## @@ -360,11 +362,27 @@ List registerProvidedLocalResources() {

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323382871 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilderTest.java: ## @@ -478,6 +478,50 @@ public

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323381133 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private void

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
morhidi commented on PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#issuecomment-1716182195 Thanks for contributing @srpraneeth. Could you please update the PR and help understand the goal here with specific examples CR examples? -- This is an automated

[jira] [Updated] (FLINK-32885) Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyFlink remote execution

2023-09-12 Thread Elkhan Dadashov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elkhan Dadashov updated FLINK-32885: Fix Version/s: 1.19.0 Description: UrlPrefixDecorator is introduced in

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #666: [FLINK-33067] Expose rate limiter config and enable by default

2023-09-12 Thread via GitHub
gyfora merged PR #666: URL: https://github.com/apache/flink-kubernetes-operator/pull/666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #23402: [FLINK-33077][runtime] Minimize the risk of hard back-pressure with buffer debloating enabled.

2023-09-12 Thread via GitHub
flinkbot commented on PR #23402: URL: https://github.com/apache/flink/pull/23402#issuecomment-1715842874 ## CI report: * 1413bf6feca53cb20b4a036705df0f6537140fd2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-32804) Release Testing: Verify FLIP-304: Pluggable failure handling for Apache Flink

2023-09-12 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762443#comment-17762443 ] Panagiotis Garefalakis edited comment on FLINK-32804 at 9/12/23 3:32 PM:

[jira] [Closed] (FLINK-32777) Upgrade Okhttp version to support IPV6

2023-09-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-32777. -- Fix Version/s: kubernetes-operator-1.7.0 Resolution: Fixed merged to main

[GitHub] [flink] hejufang opened a new pull request, #23403: [FLINK-32863][runtime-web] Improve Flink UI's time precision from sec…

2023-09-12 Thread via GitHub
hejufang opened a new pull request, #23403: URL: https://github.com/apache/flink/pull/23403 ## What is the purpose of the change Improve Flink UI's time precision from second level to millisecond level. ## Brief change log Improve Flink UI's time precision

[jira] [Updated] (FLINK-32863) Improve Flink UI's time precision from second level to millisecond level

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32863: --- Labels: pull-request-available (was: ) > Improve Flink UI's time precision from second

[jira] [Updated] (FLINK-31871) Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31871: --- Labels: pull-request-available (was: ) > Interpret Flink MemoryUnits according to the

[GitHub] [flink] afedulov commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient fo

2023-09-12 Thread via GitHub
afedulov commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1323172674 ## flink-clients/src/main/java/org/apache/flink/client/program/rest/UrlPrefixDecorator.java: ## @@ -100,4 +105,11 @@ public Class getRequestClass() { public M

[jira] [Resolved] (FLINK-32804) Release Testing: Verify FLIP-304: Pluggable failure handling for Apache Flink

2023-09-12 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis resolved FLINK-32804. Resolution: Fixed > Release Testing: Verify FLIP-304: Pluggable failure

[jira] [Commented] (FLINK-31871) Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread Praneeth Ramesh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764296#comment-17764296 ] Praneeth Ramesh commented on FLINK-31871: - [~gyfora] Can you please help review

[GitHub] [flink-connector-rabbitmq] RocMarshal opened a new pull request, #16: [FLINK-20628] Port RabbitMQ Connector using unified Source & Sink API

2023-09-12 Thread via GitHub
RocMarshal opened a new pull request, #16: URL: https://github.com/apache/flink-connector-rabbitmq/pull/16 related pr #1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-33017) Nightly run for Flink Kafka connector fails

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33017: --- Labels: pull-request-available (was: ) > Nightly run for Flink Kafka connector fails >

[GitHub] [flink] StefanRRichter opened a new pull request, #23402: [FLINK-33077][runtime] Minimize the risk of hard back-pressure with buffer debloating enabled.

2023-09-12 Thread via GitHub
StefanRRichter opened a new pull request, #23402: URL: https://github.com/apache/flink/pull/23402 ## What is the purpose of the change Problem: Buffer debloating sets buffer size to 256 bytes because of back-pressure. Such small buffers might not be enough to emit the processing

[jira] [Updated] (FLINK-33077) Minimize the risk of hard back-pressure with buffer debloating enabled

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33077: --- Labels: pull-request-available (was: ) > Minimize the risk of hard back-pressure with

[GitHub] [flink-connector-rabbitmq] RocMarshal commented on a diff in pull request #16: [FLINK-20628] Port RabbitMQ Connector using unified Source & Sink API

2023-09-12 Thread via GitHub
RocMarshal commented on code in PR #16: URL: https://github.com/apache/flink-connector-rabbitmq/pull/16#discussion_r1323168285 ## flink-connector-rabbitmq/src/main/java/org/apache/flink/connector/rabbitmq/common/ConsistencyMode.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-32804) Release Testing: Verify FLIP-304: Pluggable failure handling for Apache Flink

2023-09-12 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764255#comment-17764255 ] Panagiotis Garefalakis commented on FLINK-32804: Hey [~wangm92] closing this ticket at

[GitHub] [flink] afedulov commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient fo

2023-09-12 Thread via GitHub
afedulov commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1323172674 ## flink-clients/src/main/java/org/apache/flink/client/program/rest/UrlPrefixDecorator.java: ## @@ -100,4 +105,11 @@ public Class getRequestClass() { public M

[GitHub] [flink-kubernetes-operator] srpraneeth opened a new pull request, #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-12 Thread via GitHub
srpraneeth opened a new pull request, #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670 ## What is the purpose of the change JM and TM memory settings is only supported in bibytes format. This change will help interpreting the flink memory according to the actual

[jira] [Comment Edited] (FLINK-31778) Casting array of rows produces incorrect result

2023-09-12 Thread Nic Townsend (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764197#comment-17764197 ] Nic Townsend edited comment on FLINK-31778 at 9/12/23 1:52 PM: --- Hi, I have

[jira] [Closed] (FLINK-33067) Expose JODK rate limiter config and enable by default

2023-09-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33067. -- Resolution: Fixed merged to main 4d95de3fe29de7d8465d9240d04f878358635e3d > Expose JODK rate limiter

[GitHub] [flink-connector-rabbitmq] boring-cyborg[bot] commented on pull request #16: [FLINK-20628] Port RabbitMQ Connector using unified Source & Sink API

2023-09-12 Thread via GitHub
boring-cyborg[bot] commented on PR #16: URL: https://github.com/apache/flink-connector-rabbitmq/pull/16#issuecomment-1715873822 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This

[GitHub] [flink] snuyanzin opened a new pull request, #23400: [hotfix][docs] Misprints in security-ssl.md

2023-09-12 Thread via GitHub
snuyanzin opened a new pull request, #23400: URL: https://github.com/apache/flink/pull/23400 ## What is the purpose of the change There are a couple of misprints in `security-ssl.md` (both englich and chinese versions) `WHen` => `When` `generatedd` => `generated` ## Brief

[jira] [Updated] (FLINK-33034) Incorrect StateBackendTestBase#testGetKeysAndNamespaces

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33034: --- Labels: pull-request-available (was: ) > Incorrect

[GitHub] [flink] ldadima commented on pull request #23355: [FLINK-33034][runtime] Correct ValueState creating for StateBackendTestBase#testGetKeysAndNamespaces

2023-09-12 Thread via GitHub
ldadima commented on PR #23355: URL: https://github.com/apache/flink/pull/23355#issuecomment-1715385100 > Thanks for the update. Could you rebase your pr with newest master ? There are some conflicts due to [FLINK-32854](https://issues.apache.org/jira/browse/FLINK-32854) which migrates

[GitHub] [flink] mxm commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyF

2023-09-12 Thread via GitHub
mxm commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1322817850 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/header/util/SQLGatewayUrlPrefixDecorator.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to

[GitHub] [flink] masteryhx opened a new pull request, #22800: [FLINK-23411][checkpoint] Expose Checkpoint metrics in task level

2023-09-12 Thread via GitHub
masteryhx opened a new pull request, #22800: URL: https://github.com/apache/flink/pull/22800 ## What is the purpose of the change - Expose task level checkpoint metircs that just like what shows in Flink UI. ## Brief change log - Introduce

[GitHub] [flink] rkhachatryan closed pull request #22800: [FLINK-23411][checkpoint] Expose Checkpoint metrics in task level

2023-09-12 Thread via GitHub
rkhachatryan closed pull request #22800: [FLINK-23411][checkpoint] Expose Checkpoint metrics in task level URL: https://github.com/apache/flink/pull/22800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-12 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1322784279 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #248: [FLINK-32704] Supports spilling to disk when feedback channel memory buffer is full

2023-09-12 Thread via GitHub
jiangxin369 commented on code in PR #248: URL: https://github.com/apache/flink-ml/pull/248#discussion_r1322717816 ## flink-ml-iteration/flink-ml-iteration-common/src/main/java/org/apache/flink/iteration/operator/feedback/SpillableFeedbackQueue.java: ## @@ -0,0 +1,115 @@ +/* + *

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #248: [FLINK-32704] Supports spilling to disk when feedback channel memory buffer is full

2023-09-12 Thread via GitHub
jiangxin369 commented on code in PR #248: URL: https://github.com/apache/flink-ml/pull/248#discussion_r1322717816 ## flink-ml-iteration/flink-ml-iteration-common/src/main/java/org/apache/flink/iteration/operator/feedback/SpillableFeedbackQueue.java: ## @@ -0,0 +1,115 @@ +/* + *

[GitHub] [flink] 1996fanrui commented on a diff in pull request #23265: [FLINK-32853][runtime][JUnit5 Migration] The security, taskmanager an…

2023-09-12 Thread via GitHub
1996fanrui commented on code in PR #23265: URL: https://github.com/apache/flink/pull/23265#discussion_r1322913640 ## flink-runtime/src/test/java/org/apache/flink/runtime/security/token/DefaultDelegationTokenManagerTest.java: ## @@ -216,18 +214,18 @@ void startTokensUpdate() {

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-12 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764148#comment-17764148 ] Jing Ge edited comment on FLINK-33052 at 9/12/23 12:15 PM: --- The vm was in a

[jira] [Created] (FLINK-33074) Flink-ci-mirror stopped running for commits after 3rd of Septemper

2023-09-12 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33074: --- Summary: Flink-ci-mirror stopped running for commits after 3rd of Septemper Key: FLINK-33074 URL: https://issues.apache.org/jira/browse/FLINK-33074 Project:

[jira] [Created] (FLINK-33075) Notice files for Statefun are outdated

2023-09-12 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-33075: -- Summary: Notice files for Statefun are outdated Key: FLINK-33075 URL: https://issues.apache.org/jira/browse/FLINK-33075 Project: Flink Issue Type: Bug

[jira] [Closed] (FLINK-33075) Notice files for Statefun are outdated

2023-09-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-33075. -- Fix Version/s: statefun-3.3.0 Resolution: Fixed Fixed in:

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-12 Thread via GitHub
1996fanrui commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1323003718 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void

[jira] [Commented] (FLINK-23411) Expose Flink checkpoint details metrics

2023-09-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764113#comment-17764113 ] Piotr Nowojski commented on FLINK-23411: {quote} maybe we could still register some task level

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-12 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1322947925 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void

[jira] [Updated] (FLINK-30906) TwoInputStreamTask passes wrong configuration object when creating input processor

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30906: --- Labels: pull-request-available (was: ) > TwoInputStreamTask passes wrong configuration

[jira] [Assigned] (FLINK-33052) codespeed server is down

2023-09-12 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge reassigned FLINK-33052: --- Assignee: Yanfei Lei (was: Jing Ge) > codespeed server is down > > >

[jira] [Comment Edited] (FLINK-33030) Add python 3.11 support

2023-09-12 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764098#comment-17764098 ] Gabor Somogyi edited comment on FLINK-33030 at 9/12/23 12:21 PM: - Pemja

[jira] [Assigned] (FLINK-33030) Add python 3.11 support

2023-09-12 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-33030: - Assignee: Gabor Somogyi > Add python 3.11 support > --- > >

[GitHub] [flink-statefun] dannycranmer commented on a diff in pull request #339: [FLINK-33075 ] Update outdated NOTICE files for Statefun

2023-09-12 Thread via GitHub
dannycranmer commented on code in PR #339: URL: https://github.com/apache/flink-statefun/pull/339#discussion_r1322668433 ## statefun-flink/statefun-flink-distribution/src/main/resources/META-INF/NOTICE: ## @@ -1,47 +1,49 @@ statefun-flink-distribution -Copyright 2014-2020 The

[GitHub] [flink-statefun] MartijnVisser merged pull request #339: [FLINK-33075 ] Update outdated NOTICE files for Statefun

2023-09-12 Thread via GitHub
MartijnVisser merged PR #339: URL: https://github.com/apache/flink-statefun/pull/339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] pnowojski commented on a diff in pull request #23391: [FLINK-33071][metrics,checkpointing] Log a json dump of checkpoint statistics when checkpoint complets or fails

2023-09-12 Thread via GitHub
pnowojski commented on code in PR #23391: URL: https://github.com/apache/flink/pull/23391#discussion_r1322727310 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java: ## @@ -227,11 +257,23 @@ void

[GitHub] [flink] mxm commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyF

2023-09-12 Thread via GitHub
mxm commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1322825899 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/header/util/SQLGatewayUrlPrefixDecorator.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-12 Thread via GitHub
1996fanrui commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1322842642 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void

[GitHub] [flink] 1996fanrui merged pull request #23379: [FLINK-33065][client] Add possible root cause to the exception message when the program plan could not be fetched

2023-09-12 Thread via GitHub
1996fanrui merged PR #23379: URL: https://github.com/apache/flink/pull/23379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] StefanRRichter commented on a diff in pull request #23391: [FLINK-33071][metrics,checkpointing] Log a json dump of checkpoint statistics when checkpoint complets or fails

2023-09-12 Thread via GitHub
StefanRRichter commented on code in PR #23391: URL: https://github.com/apache/flink/pull/23391#discussion_r1322653240 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java: ## @@ -227,11 +257,23 @@ void

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-12 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1322738246 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void

[jira] [Commented] (FLINK-31966) Flink Kubernetes operator lacks TLS support

2023-09-12 Thread Tony Garrard (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764117#comment-17764117 ] Tony Garrard commented on FLINK-31966: -- Hi [~gyfora] I think I can take this on, but can I discuss

[GitHub] [flink] pnowojski commented on a diff in pull request #22800: [FLINK-23411][checkpoint] Expose Checkpoint metrics in task level

2023-09-12 Thread via GitHub
pnowojski commented on code in PR #22800: URL: https://github.com/apache/flink/pull/22800#discussion_r132299 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/AsyncCheckpointMetricsGroup.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] snuyanzin merged pull request #23400: [hotfix][docs] Misprints in security-ssl.md

2023-09-12 Thread via GitHub
snuyanzin merged PR #23400: URL: https://github.com/apache/flink/pull/23400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #23401: [FLINK-30906][task] TwoInputStreamTask and MultipleInputStreamTask passes wrong configuration when create input processor

2023-09-12 Thread via GitHub
flinkbot commented on PR #23401: URL: https://github.com/apache/flink/pull/23401#issuecomment-1715619798 ## CI report: * 79cc6444056f40a90c35bce53330b754bc9954c1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] ljz2051 commented on a diff in pull request #23376: [FLINK-14032][state]Make the cache size of RocksDBPriorityQueueSetFactory configurable

2023-09-12 Thread via GitHub
ljz2051 commented on code in PR #23376: URL: https://github.com/apache/flink/pull/23376#discussion_r1322971134 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBPriorityQueueConfig.java: ## @@ -0,0 +1,98 @@ +/* + *

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-12 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321602343 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void

[jira] [Commented] (FLINK-32802) Release Testing: Verify FLIP-291: Externalized Declarative Resource Management

2023-09-12 Thread ConradJam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764073#comment-17764073 ] ConradJam commented on FLINK-32802: --- Thanks Chesnay Report, I think my side of the test is done cc

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-12 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321602343 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-12 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321602343 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void

[GitHub] [flink] masteryhx commented on a diff in pull request #23376: [FLINK-14032][state]Make the cache size of RocksDBPriorityQueueSetFactory configurable

2023-09-12 Thread via GitHub
masteryhx commented on code in PR #23376: URL: https://github.com/apache/flink/pull/23376#discussion_r1322720731 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBPriorityQueueConfig.java: ## @@ -0,0 +1,98 @@ +/* +

[jira] [Updated] (FLINK-33011) Operator deletes HA data unexpectedly

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33011: --- Labels: pull-request-available (was: ) > Operator deletes HA data unexpectedly >

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #669: [FLINK-33011] Never accidentally delete HA metadata for last state de…

2023-09-12 Thread via GitHub
gyfora opened a new pull request, #669: URL: https://github.com/apache/flink-kubernetes-operator/pull/669 ## What is the purpose of the change Fix a bug where HA metadata may get accidentally deleted right before deployment, due to incorrectly observing the JobManager deployment in a

[jira] [Commented] (FLINK-33052) codespeed server is down

2023-09-12 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764148#comment-17764148 ] Jing Ge commented on FLINK-33052: - The vm was in a mystery account no one know anymore. After contacting

[GitHub] [flink] reswqa opened a new pull request, #23401: [FLINK-30906][task] TwoInputStreamTask and MultipleInputStreamTask passes wrong configuration when create input processor

2023-09-12 Thread via GitHub
reswqa opened a new pull request, #23401: URL: https://github.com/apache/flink/pull/23401 ## What is the purpose of the change *Correct configuration option of `TwoInputStreamTask` and `MultipleInputStreamTask` when create input processor.* ## Brief change log -

[jira] [Created] (FLINK-33076) broadcastEmit of ChannelSelectorRecordWriter should reuse the serialized record

2023-09-12 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-33076: -- Summary: broadcastEmit of ChannelSelectorRecordWriter should reuse the serialized record Key: FLINK-33076 URL: https://issues.apache.org/jira/browse/FLINK-33076 Project:

[jira] [Commented] (FLINK-33030) Add python 3.11 support

2023-09-12 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764154#comment-17764154 ] Gabor Somogyi commented on FLINK-33030: --- Pemja version 0.4.0 is going to be released soon which

[GitHub] [flink] ljz2051 commented on a diff in pull request #23376: [FLINK-14032][state]Make the cache size of RocksDBPriorityQueueSetFactory configurable

2023-09-12 Thread via GitHub
ljz2051 commented on code in PR #23376: URL: https://github.com/apache/flink/pull/23376#discussion_r1322970387 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBPriorityQueueConfig.java: ## @@ -0,0 +1,98 @@ +/* + *

[GitHub] [flink] ljz2051 commented on a diff in pull request #23376: [FLINK-14032][state]Make the cache size of RocksDBPriorityQueueSetFactory configurable

2023-09-12 Thread via GitHub
ljz2051 commented on code in PR #23376: URL: https://github.com/apache/flink/pull/23376#discussion_r1322972294 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBPriorityQueueConfig.java: ## @@ -0,0 +1,98 @@ +/* + *

[jira] [Updated] (FLINK-33075) Notice files for Statefun are outdated

2023-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33075: --- Labels: pull-request-available (was: ) > Notice files for Statefun are outdated >

[GitHub] [flink] flinkbot commented on pull request #23400: [hotfix][docs] Misprints in security-ssl.md

2023-09-12 Thread via GitHub
flinkbot commented on PR #23400: URL: https://github.com/apache/flink/pull/23400#issuecomment-1715359690 ## CI report: * 35bd688776bdeea7861022ba9ee100829e8a8e2a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-12 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1322784279 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void

[jira] [Resolved] (FLINK-33074) Flink-ci-mirror stopped running for commits after 3rd of Septemper

2023-09-12 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33074. - Resolution: Fixed > Flink-ci-mirror stopped running for commits after 3rd of Septemper >

[jira] [Commented] (FLINK-33074) Flink-ci-mirror stopped running for commits after 3rd of Septemper

2023-09-12 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764125#comment-17764125 ] Jing Ge commented on FLINK-33074: - disk full issue and fixed > Flink-ci-mirror stopped running for

[jira] [Assigned] (FLINK-33074) Flink-ci-mirror stopped running for commits after 3rd of Septemper

2023-09-12 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-33074: - Assignee: Jing Ge > Flink-ci-mirror stopped running for commits after 3rd of Septemper

[jira] [Commented] (FLINK-32802) Release Testing: Verify FLIP-291: Externalized Declarative Resource Management

2023-09-12 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764068#comment-17764068 ] Chesnay Schepler commented on FLINK-32802: -- FLINK-31608 will not land in 1.18 (because it will

[jira] [Commented] (FLINK-33030) Add python 3.11 support

2023-09-12 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764098#comment-17764098 ] Gabor Somogyi commented on FLINK-33030: --- Pemja is not supporting python 3.11: {code:java} pip

  1   2   >