Re: [PR] [FLINK-33007] Integrate autoscaler config validation into the general validator flow [flink-kubernetes-operator]

2023-10-04 Thread via GitHub
gyfora commented on code in PR #682: URL: https://github.com/apache/flink-kubernetes-operator/pull/682#discussion_r1345402764 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/validation/AutoScalerValidator.java: ## @@ -0,0

Re: [PR] [FLINK-33095] Job jar issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR. [flink]

2023-10-04 Thread via GitHub
XComp commented on code in PR #23428: URL: https://github.com/apache/flink/pull/23428#discussion_r1345443798 ## flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/utils/JarHandlerUtils.java: ## @@ -189,7 +189,11 @@ public PackagedProgram

[jira] [Resolved] (FLINK-30025) Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

2023-10-04 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-30025. - Resolution: Fixed > Unified the max display column width for SqlClient and Table APi in both >

[jira] [Commented] (FLINK-33082) Azure Pipelines 4 is not responding on AZP

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771716#comment-17771716 ] Matthias Pohl commented on FLINK-33082: --- [~Sergey Nuyanzin] That looks like a Azure CI issue. I

Re: [PR] [FLINK-32445][runtime] Refactor BlobStoreService's closeAndCleanupAllData to cleanupAllData [flink]

2023-10-04 Thread via GitHub
XComp commented on code in PR #23424: URL: https://github.com/apache/flink/pull/23424#discussion_r1345334927 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractHaServices.java: ## @@ -192,32 +192,18 @@ public void closeAndCleanupAllData() throws

[jira] [Assigned] (FLINK-32445) BlobStore.closeAndCleanupAllData doesn't do any close action

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-32445: - Assignee: Jiabao Sun > BlobStore.closeAndCleanupAllData doesn't do any close action >

[jira] [Commented] (FLINK-33116) CliClientTest.testCancelExecutionInteractiveMode fails with NPE on AZP

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771813#comment-17771813 ] Matthias Pohl commented on FLINK-33116: --- Looks like the {{CliClient}} is not thread-safe: The

[jira] [Updated] (FLINK-32582) Move TypeSerializerUpgradeTestBase from Kafka connector into flink-connector-common

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-32582: -- Description: The externalization of connectors caused problems with the Flink's test data

Re: [PR] [FLINK-32445][runtime] Refactor BlobStoreService's closeAndCleanupAllData to cleanupAllData [flink]

2023-10-04 Thread via GitHub
Jiabao-Sun commented on code in PR #23424: URL: https://github.com/apache/flink/pull/23424#discussion_r1345742478 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractHaServices.java: ## @@ -192,32 +192,18 @@ public void closeAndCleanupAllData()

Re: [PR] [FLINK-33053][zookeeper] Manually remove the leader watcher after ret… [flink]

2023-10-04 Thread via GitHub
XComp commented on code in PR #23415: URL: https://github.com/apache/flink/pull/23415#discussion_r1345486880 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalDriver.java: ## @@ -122,6 +125,19 @@ public void close() throws Exception

[jira] [Created] (FLINK-33181) Table using `kinesis` connector can not be used for both read & write operations if it's defined with unsupported sink property

2023-10-04 Thread Khanh Vu (Jira)
Khanh Vu created FLINK-33181: Summary: Table using `kinesis` connector can not be used for both read & write operations if it's defined with unsupported sink property Key: FLINK-33181 URL:

[jira] [Updated] (FLINK-33181) Table using `kinesis` connector can not be used for both read & write operations if it's defined with unsupported sink property

2023-10-04 Thread Khanh Vu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Khanh Vu updated FLINK-33181: - Description: First, I define a table which uses `kinesis` connector with an unsupported property for

Re: [PR] [hotfix][docs] Update KDA to MSF in vendor solutions docs (1.18) [flink]

2023-10-04 Thread via GitHub
dannycranmer merged PR #23484: URL: https://github.com/apache/flink/pull/23484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][docs] Update KDA to MSF in vendor solutions docs [flink]

2023-10-04 Thread via GitHub
dannycranmer merged PR #23483: URL: https://github.com/apache/flink/pull/23483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][docs] Update KDA to MSF in vendor solutions docs (1.16) [flink]

2023-10-04 Thread via GitHub
dannycranmer merged PR #23485: URL: https://github.com/apache/flink/pull/23485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33181) Table using `kinesis` connector can not be used for both read & write operations if it's defined with unsupported sink property

2023-10-04 Thread Khanh Vu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Khanh Vu updated FLINK-33181: - Description: First, I define a table which uses `kinesis` connector with an unsupported property for

[jira] [Commented] (FLINK-33000) SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771803#comment-17771803 ] Matthias Pohl commented on FLINK-33000: --- [~fsk119] are you taking care of the backports as well?

[jira] [Updated] (FLINK-33116) CliClientTest.testCancelExecutionInteractiveMode fails with NPE on AZP

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33116: -- Description: This build

Re: [PR] [FLINK-33176][Connectors/Kinesis] Handle null value in RowDataKinesisDeserializationSchema [flink-connector-aws]

2023-10-04 Thread via GitHub
dannycranmer commented on code in PR #102: URL: https://github.com/apache/flink-connector-aws/pull/102#discussion_r1345737928 ## flink-connector-aws/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/table/RowDataKinesisDeserializationSchemaTest.java:

[jira] [Updated] (FLINK-33113) YARNSessionFIFOITCase.checkForProhibitedLogContents: Interrupted waiting to send RPC request to server

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33113: -- Description: This build

Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]

2023-10-04 Thread via GitHub
dawidwys commented on code in PR #23488: URL: https://github.com/apache/flink/pull/23488#discussion_r1345519922 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java: ## @@ -104,9 +104,16 @@ private

[jira] [Commented] (FLINK-30649) Shutting down MiniCluster times out

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771793#comment-17771793 ] Matthias Pohl commented on FLINK-30649: --- Yeah, essentially, it's hard to investigate if it's not

Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]

2023-10-04 Thread via GitHub
twalthr commented on code in PR #23488: URL: https://github.com/apache/flink/pull/23488#discussion_r1345578855 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java: ## @@ -104,9 +104,16 @@ private

Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]

2023-10-04 Thread via GitHub
twalthr commented on code in PR #23488: URL: https://github.com/apache/flink/pull/23488#discussion_r1345505603 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java: ## @@ -104,9 +104,16 @@ private

[jira] [Commented] (FLINK-30883) Missing JobID caused the k8s e2e test to fail

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771796#comment-17771796 ] Matthias Pohl commented on FLINK-30883: --- Hi [~Fei Feng] , could you provide logs of your scenario?

Re: [PR] [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message [flink]

2023-10-04 Thread via GitHub
XComp commented on PR #23472: URL: https://github.com/apache/flink/pull/23472#issuecomment-1746649051 How is this different to the solution before? :thinking: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-33178) Highly parallel apps suffer from bottleneck in NativePRNG

2023-10-04 Thread Emre Kartoglu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771788#comment-17771788 ] Emre Kartoglu commented on FLINK-33178: --- [~martijnvisser] Thanks for the comment. You're right to

Re: [PR] [hotfix][docs] Update KDA to MSF in vendor solutions docs (1.15) [flink]

2023-10-04 Thread via GitHub
dannycranmer merged PR #23487: URL: https://github.com/apache/flink/pull/23487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][docs] Update KDA to MSF in vendor solutions docs (1.17) [flink]

2023-10-04 Thread via GitHub
dannycranmer merged PR #23486: URL: https://github.com/apache/flink/pull/23486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (FLINK-30883) Missing JobID caused the k8s e2e test to fail

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683432#comment-17683432 ] Matthias Pohl edited comment on FLINK-30883 at 10/4/23 10:01 AM: - I

Re: [PR] [FLINK-20625][pubsub,e2e] Add PubSubSource connector using FLIP-27 [flink-connector-gcp-pubsub]

2023-10-04 Thread via GitHub
XComp commented on PR #2: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/2#issuecomment-1746591605 @dchristle how about you? ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink [flink]

2023-10-04 Thread via GitHub
davidradl commented on PR #8: URL: https://github.com/apache/flink/pull/8#issuecomment-1746926177 @tzulitai @MartijnVisser I see https://github.com/apache/flink/pull/22797 , this pr is no longer relevant to this repository, I suggest closing this pr and porting the change to the

Re: [PR] [FLINK-26614]Upsert Kafka SQL Connector:Support startup mode of timestamp and specific offsets [flink]

2023-10-04 Thread via GitHub
davidradl commented on PR #19067: URL: https://github.com/apache/flink/pull/19067#issuecomment-1746937641 @slinkydeveloper I see https://github.com/apache/flink/pull/22797 , this pr is no longer relevant to this repository, I suggest closing this pr and porting the change to the [new

Re: [PR] [FLINK-13226] [connectors / kafka] Fix race condition between transaction commit and produc… [flink]

2023-10-04 Thread via GitHub
davidradl commented on PR #9224: URL: https://github.com/apache/flink/pull/9224#issuecomment-1746934218 @pnowojski I see https://github.com/apache/flink/pull/22797 , this pr is no longer relevant to this repository, I suggest closing this pr and porting the change to the [new Flink

[jira] [Created] (FLINK-33183) Enable metadata columns in NduAnalyzer with retract if non-virtual

2023-10-04 Thread Timo Walther (Jira)
Timo Walther created FLINK-33183: Summary: Enable metadata columns in NduAnalyzer with retract if non-virtual Key: FLINK-33183 URL: https://issues.apache.org/jira/browse/FLINK-33183 Project: Flink

[jira] [Assigned] (FLINK-32380) Support Java records

2023-10-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-32380: -- Assignee: Gyula Fora > Support Java records > > > Key:

Re: [PR] [FLINK-33176][Connectors/Kinesis] Handle null value in RowDataKinesisDeserializationSchema [flink-connector-aws]

2023-10-04 Thread via GitHub
dannycranmer merged PR #102: URL: https://github.com/apache/flink-connector-aws/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Max Retries [flink-statefun]

2023-10-04 Thread via GitHub
davidradl commented on PR #337: URL: https://github.com/apache/flink-statefun/pull/337#issuecomment-1746901840 Is there a Jira associated with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-31262][kafka] Move kafka sql connector fat jar test to SmokeKafkaITCase [flink]

2023-10-04 Thread via GitHub
davidradl commented on PR #22060: URL: https://github.com/apache/flink/pull/22060#issuecomment-1746927104 I see https://github.com/apache/flink/pull/22797 , this pr is no longer relevant to this repository, I suggest closing this pr and porting the change to the [new Flink connector kafka

Re: [PR] [FLINK-31006][connector/kafka] Fix noMoreNewPartitionSplits is not se… [flink]

2023-10-04 Thread via GitHub
davidradl commented on PR #21909: URL: https://github.com/apache/flink/pull/21909#issuecomment-1746928308 @liuyongvs I see https://github.com/apache/flink/pull/22797 , this pr is no longer relevant to this repository, I suggest closing this pr and porting the change to the [new Flink

Re: [PR] [FLINK-28185][Connector/Kafka] Handle missing timestamps when there a… [flink]

2023-10-04 Thread via GitHub
davidradl commented on PR #22416: URL: https://github.com/apache/flink/pull/22416#issuecomment-1746924764 @junjiem see https://github.com/apache/flink/pull/22797 , this pr is no longer relevant to this repository, I suggest closing this pr and porting the change to the [new Flink connector

Re: [PR] [FLINK-13226] [connectors / kafka] Fix race condition between transaction commit and produc… [flink]

2023-10-04 Thread via GitHub
flinkbot commented on PR #9224: URL: https://github.com/apache/flink/pull/9224#issuecomment-1746946522 ## CI report: * 838d369f5c230c4debd3eac7a28bd2bc75711a01 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink [flink]

2023-10-04 Thread via GitHub
AlexAxeman commented on PR #8: URL: https://github.com/apache/flink/pull/8#issuecomment-1746945765 It was implemented in the new repo in [this PR](https://github.com/apache/flink-connector-kafka/pull/18). -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink [flink]

2023-10-04 Thread via GitHub
AlexAxeman closed pull request #8: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink URL: https://github.com/apache/flink/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (FLINK-30831) Improving e2e test output in case errors/exceptions are found

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771882#comment-17771882 ] Matthias Pohl commented on FLINK-30831: --- Thanks for volunteering. i assigned the issue to you. >

Re: [PR] [FLINK-30859] Remove all Kafka connector code from main repo [flink]

2023-10-04 Thread via GitHub
davidradl commented on PR #22797: URL: https://github.com/apache/flink/pull/22797#issuecomment-1747162915 @zentol @tzulitai As the kafka connector code has now been removed from the repo in the change that has been merged in

Re: [PR] spell error : continous to continuous [flink]

2023-10-04 Thread via GitHub
XComp commented on PR #23431: URL: https://github.com/apache/flink/pull/23431#issuecomment-1747198710 Closing this PR in favor of #23422. Please collect all the typo fixes in there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] spell error : continous to continuous [flink]

2023-10-04 Thread via GitHub
XComp closed pull request #23431: spell error : continous to continuous URL: https://github.com/apache/flink/pull/23431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Update filesystem.md spell error : continously to continuously [flink]

2023-10-04 Thread via GitHub
XComp commented on PR #23422: URL: https://github.com/apache/flink/pull/23422#issuecomment-1747197573 I see that you provided another PR with similar changes (#23431). Please move all the changes into a single PR. I'm gonna close the other PR without merging it. We should do the typo

[jira] [Assigned] (FLINK-33176) Kinesis source throws NullPointerException in Table API on ignored parsing errors

2023-10-04 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-33176: - Assignee: Aleksandr Pilipenko > Kinesis source throws NullPointerException in Table

[jira] [Resolved] (FLINK-33176) Kinesis source throws NullPointerException in Table API on ignored parsing errors

2023-10-04 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-33176. --- Resolution: Fixed > Kinesis source throws NullPointerException in Table API on ignored

[jira] [Commented] (FLINK-33176) Kinesis source throws NullPointerException in Table API on ignored parsing errors

2023-10-04 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771905#comment-17771905 ] Danny Cranmer commented on FLINK-33176: --- merged commit 

[jira] [Updated] (FLINK-33176) Kinesis source throws NullPointerException in Table API on ignored parsing errors

2023-10-04 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-33176: -- Fix Version/s: aws-connector-4.2.0 > Kinesis source throws NullPointerException in Table API

Re: [PR] Update create.md , ifx spell error, change statment to statement [flink]

2023-10-04 Thread via GitHub
XComp closed pull request #23434: Update create.md , ifx spell error, change statment to statement URL: https://github.com/apache/flink/pull/23434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Update create.md , ifx spell error, change statment to statement [flink]

2023-10-04 Thread via GitHub
XComp commented on PR #23434: URL: https://github.com/apache/flink/pull/23434#issuecomment-174778 Thanks for your contribution, @yanfangli85 and for looking into this, @davidradl. David is right: We should do documentation changes in both the English and Chinese version at the same

Re: [PR] fix(sec): upgrade com.google.guava:guava to 32.0.0-jre [flink]

2023-10-04 Thread via GitHub
snuyanzin commented on PR #23150: URL: https://github.com/apache/flink/pull/23150#issuecomment-1747230400 @ChengDaqi2023 the build is failing could you have a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (FLINK-29492) Kafka exactly-once sink causes OutOfMemoryError

2023-10-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29492: --- Labels: pull-request-available (was: ) > Kafka exactly-once sink causes OutOfMemoryError >

Re: [PR] [FLINK-29492] Return Kafka producer to the pool when the Kafka sink is not the end of the chain [flink]

2023-10-04 Thread via GitHub
davidradl commented on PR #21226: URL: https://github.com/apache/flink/pull/21226#issuecomment-1746929409 @ruanhang1993 I see https://github.com/apache/flink/pull/22797 , this pr is no longer relevant to this repository, I suggest closing this pr and porting the change to the [new Flink

Re: [PR] [FLINK-32445][runtime] Refactor BlobStoreService's closeAndCleanupAllData to cleanupAllData [flink]

2023-10-04 Thread via GitHub
XComp commented on code in PR #23424: URL: https://github.com/apache/flink/pull/23424#discussion_r1345865694 ## flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java: ## @@ -498,12 +498,15 @@ protected CompletableFuture

Re: [PR] [FLINK-32445][runtime] Refactor BlobStoreService's closeAndCleanupAllData to cleanupAllData [flink]

2023-10-04 Thread via GitHub
XComp commented on code in PR #23424: URL: https://github.com/apache/flink/pull/23424#discussion_r1345868304 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/HighAvailabilityServices.java: ## @@ -212,19 +212,17 @@ default LeaderRetrievalService

Re: [PR] Update with.md defintion spell error ,fix with definition [flink]

2023-10-04 Thread via GitHub
XComp closed pull request #23432: Update with.md defintion spell error ,fix with definition URL: https://github.com/apache/flink/pull/23432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Update with.md defintion spell error ,fix with definition [flink]

2023-10-04 Thread via GitHub
XComp commented on PR #23432: URL: https://github.com/apache/flink/pull/23432#issuecomment-1747214634 Thanks for your contribution, @yanfangli85 and for looking into this, @davidradl. David is right: We should do documentation changes in both the English and Chinese version at the same

Re: [PR] Update local_installation.md [flink]

2023-10-04 Thread via GitHub
snuyanzin commented on code in PR #23240: URL: https://github.com/apache/flink/pull/23240#discussion_r1346137247 ## docs/content/docs/try-flink/local_installation.md: ## @@ -46,6 +46,8 @@ to have __Java 11__ installed. To check the Java version installed, type in your $ java

Re: [PR] [FLINK-33149] Bump snappy to 1.1.10.4 [flink-statefun]

2023-10-04 Thread via GitHub
davidradl commented on code in PR #341: URL: https://github.com/apache/flink-statefun/pull/341#discussion_r1345814020 ## statefun-kafka-io/pom.xml: ## @@ -43,9 +43,7 @@ under the License. ${kafka.version} +

Re: [PR] Bump org.xerial.snappy:snappy-java from 1.1.10.1 to 1.1.10.4 in /statefun-flink [flink-statefun]

2023-10-04 Thread via GitHub
davidradl commented on PR #340: URL: https://github.com/apache/flink-statefun/pull/340#issuecomment-1746899156 See comment in https://github.com/apache/flink-statefun/pull/341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-25538][flink-connector-kafka] JUnit5 Migration [flink]

2023-10-04 Thread via GitHub
davidradl commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1746931693 @snuyanzin I see https://github.com/apache/flink/pull/22797 , this pr is no longer relevant to this repository, I suggest closing this pr and porting the change to the [new Flink

[jira] [Commented] (FLINK-33182) Allow metadata columns in NduAnalyzer with ChangelogNormalize

2023-10-04 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771868#comment-17771868 ] Timo Walther commented on FLINK-33182: -- [~lincoln.86xy] do you agree with this assumption? > Allow

[jira] [Created] (FLINK-33182) Allow metadata columns in NduAnalyzer with ChangelogNormalize

2023-10-04 Thread Timo Walther (Jira)
Timo Walther created FLINK-33182: Summary: Allow metadata columns in NduAnalyzer with ChangelogNormalize Key: FLINK-33182 URL: https://issues.apache.org/jira/browse/FLINK-33182 Project: Flink

[jira] [Assigned] (FLINK-30831) Improving e2e test output in case errors/exceptions are found

2023-10-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-30831: - Assignee: Flaviu Cicio > Improving e2e test output in case errors/exceptions are found

Re: [PR] [FLINK-30859] Remove all Kafka connector code from main repo [flink]

2023-10-04 Thread via GitHub
davidradl commented on PR #22797: URL: https://github.com/apache/flink/pull/22797#issuecomment-1747160496 @zentol @tzulitai As the kafka connector code has now been removed from the repo in the change that has been merged in

Re: [PR] Update match_recognize.md , preterite of seek fix ,change seeked to sought [flink]

2023-10-04 Thread via GitHub
XComp closed pull request #23433: Update match_recognize.md , preterite of seek fix ,change seeked to sought URL: https://github.com/apache/flink/pull/23433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Update match_recognize.md , preterite of seek fix ,change seeked to sought [flink]

2023-10-04 Thread via GitHub
XComp commented on PR #23433: URL: https://github.com/apache/flink/pull/23433#issuecomment-1747218067 Thanks for your contribution, @yanfangli85 As pointed out in other PRs: We should do documentation changes in both the English and Chinese version at the same time to keep them on par. I'm

Re: [PR] [FLINK-32445][runtime] Refactor BlobStoreService's closeAndCleanupAllData to cleanupAllData [flink]

2023-10-04 Thread via GitHub
XComp commented on code in PR #23424: URL: https://github.com/apache/flink/pull/23424#discussion_r1346146391 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/HighAvailabilityServices.java: ## @@ -212,19 +213,53 @@ default LeaderRetrievalService

Re: [PR] [FLINK-33176][Connectors/Kinesis] Handle null value in RowDataKinesisDeserializationSchema [flink-connector-aws]

2023-10-04 Thread via GitHub
z3d1k commented on code in PR #102: URL: https://github.com/apache/flink-connector-aws/pull/102#discussion_r1345798939 ## flink-connector-aws/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/table/RowDataKinesisDeserializationSchemaTest.java:

[jira] [Commented] (FLINK-33183) Enable metadata columns in NduAnalyzer with retract if non-virtual

2023-10-04 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771876#comment-17771876 ] Timo Walther commented on FLINK-33183: -- [~lincoln.86xy] what is you opinion here? This might be

Re: [PR] [FLINK-32445][runtime] Refactor BlobStoreService's closeAndCleanupAllData to cleanupAllData [flink]

2023-10-04 Thread via GitHub
Jiabao-Sun commented on code in PR #23424: URL: https://github.com/apache/flink/pull/23424#discussion_r1346010506 ## flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java: ## @@ -498,12 +498,15 @@ protected CompletableFuture

Re: [PR] [FLINK-33020] OpensearchSinkTest.testAtLeastOnceSink timed out [flink-connector-opensearch]

2023-10-04 Thread via GitHub
snuyanzin commented on PR #32: URL: https://github.com/apache/flink-connector-opensearch/pull/32#issuecomment-1747270859 jira issue https://issues.apache.org/jira/browse/FLINK-33175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-32445][runtime] Refactor BlobStoreService's closeAndCleanupAllData to cleanupAllData [flink]

2023-10-04 Thread via GitHub
Jiabao-Sun commented on PR #23424: URL: https://github.com/apache/flink/pull/23424#issuecomment-1747284639 Thanks @XComp for the hard review. PTAL again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (FLINK-33185) HybridShuffleITCase fails with TimeoutException: Pending slot request timed out in slot pool.

2023-10-04 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33185: --- Summary: HybridShuffleITCase fails with TimeoutException: Pending slot request timed out in slot pool. Key: FLINK-33185 URL:

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771939#comment-17771939 ] Sergey Nuyanzin commented on FLINK-18356: -

[jira] [Commented] (FLINK-33186) CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished fails on AZP

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771942#comment-17771942 ] Sergey Nuyanzin commented on FLINK-33186: - [~Jiang Xin], [~lindong] since it is very similar to

[jira] [Commented] (FLINK-33000) SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-10-04 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771922#comment-17771922 ] Jiabao Sun commented on FLINK-33000: Thanks [~mapohl] and [~fsk119]. The PRs for release

[jira] [Commented] (FLINK-33184) HybridShuffleITCase fails with exception in resource cleanup of task Map

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771925#comment-17771925 ] Sergey Nuyanzin commented on FLINK-33184: -

[jira] [Commented] (FLINK-33184) HybridShuffleITCase fails with exception in resource cleanup of task Map

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771926#comment-17771926 ] Sergey Nuyanzin commented on FLINK-33184: -

[jira] [Commented] (FLINK-33184) HybridShuffleITCase fails with exception in resource cleanup of task Map

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771930#comment-17771930 ] Sergey Nuyanzin commented on FLINK-33184: -

[jira] [Commented] (FLINK-33184) HybridShuffleITCase fails with exception in resource cleanup of task Map

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771941#comment-17771941 ] Sergey Nuyanzin commented on FLINK-33184: -

[jira] [Updated] (FLINK-33184) HybridShuffleITCase fails with exception in resource cleanup of task Map on AZP

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33184: Summary: HybridShuffleITCase fails with exception in resource cleanup of task Map on AZP

[jira] [Commented] (FLINK-31339) PlannerScalaFreeITCase.testImperativeUdaf

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771943#comment-17771943 ] Sergey Nuyanzin commented on FLINK-31339: -

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771945#comment-17771945 ] Sergey Nuyanzin commented on FLINK-18356: -

[jira] [Commented] (FLINK-33184) HybridShuffleITCase fails with exception in resource cleanup of task Map on AZP

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771952#comment-17771952 ] Sergey Nuyanzin commented on FLINK-33184: -

[jira] [Created] (FLINK-33187) Don't send duplicate event to Kafka if no change

2023-10-04 Thread Clara Xiong (Jira)
Clara Xiong created FLINK-33187: --- Summary: Don't send duplicate event to Kafka if no change Key: FLINK-33187 URL: https://issues.apache.org/jira/browse/FLINK-33187 Project: Flink Issue Type:

[jira] [Created] (FLINK-33184) HybridShuffleITCase fails with exception in resource cleanup of task Map

2023-10-04 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33184: --- Summary: HybridShuffleITCase fails with exception in resource cleanup of task Map Key: FLINK-33184 URL: https://issues.apache.org/jira/browse/FLINK-33184

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771929#comment-17771929 ] Sergey Nuyanzin commented on FLINK-18356: -

[jira] [Created] (FLINK-33186) CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished fails on AZP

2023-10-04 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33186: --- Summary: CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished fails on AZP Key: FLINK-33186 URL: https://issues.apache.org/jira/browse/FLINK-33186

[jira] [Commented] (FLINK-32604) PyFlink end-to-end fails with kafka-server-stop.sh: No such file or directory

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771947#comment-17771947 ] Sergey Nuyanzin commented on FLINK-32604: -

[jira] [Updated] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-28440: Affects Version/s: 1.19.0 > EventTimeWindowCheckpointingITCase failed with restore >

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771949#comment-17771949 ] Sergey Nuyanzin commented on FLINK-28440: - Redirected to here from FLINK-30107 1.19:

[jira] [Updated] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-18476: Affects Version/s: 1.19.0 > PythonEnvUtilsTest#testStartPythonProcess fails >

[jira] [Commented] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2023-10-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771951#comment-17771951 ] Sergey Nuyanzin commented on FLINK-18476: -

[jira] [Updated] (FLINK-33020) OpensearchSinkTest.testAtLeastOnceSink timed out

2023-10-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33020: --- Labels: pull-request-available (was: ) > OpensearchSinkTest.testAtLeastOnceSink timed out

  1   2   >