twalthr commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1345578855
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -104,9 +104,16 @@ private ExecNodeContext(@Nullable Integer id, String name,
Integer version) {
@JsonCreator
public ExecNodeContext(String value) {
this.id = null;
- String[] split = value.split("_");
- this.name = split[0];
- this.version = Integer.valueOf(split[1]);
+ try {
+ String[] split = value.split("_");
+ this.name = split[0];
+ this.version = Integer.valueOf(split[1]);
+ } catch (Exception e) {
+ throw new TableException(
Review Comment:
The null_null situation was a bug in the serialization method. During JSON
deserialization so many things can go wrong if users modify the JSON plan
themselves. I vote for only implement what we need for this particular use
case. Also adding a comment there, why we need to to support plans older than
1.18.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
