[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792535#comment-17792535 ] Jim Hughes commented on FLINK-33727: As an alternative, to the existing PR and disabling the

[jira] [Updated] (FLINK-33728) do not rewatch when KubernetesResourceManagerDriver watch fail

2023-12-03 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaogang zhou updated FLINK-33728: -- Description: is it necessary to getResourceEventHandler().onError(throwable) in 

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792533#comment-17792533 ] Sergey Nuyanzin commented on FLINK-33727: - {quote} I'm pretty sure that if you removed the run

Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-03 Thread via GitHub
jnh5y commented on PR #23858: URL: https://github.com/apache/flink/pull/23858#issuecomment-1837506076 > Are there any savepoint where currently changed names were participating? Yes. > Then how to find all? Or is it just a question in general? The savepoints are living under

[jira] [Comment Edited] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792536#comment-17792536 ] Sergey Nuyanzin edited comment on FLINK-33727 at 12/3/23 2:58 PM: --

Re: [PR] [FLINK-33730][doc] update the Flink upgrade savepoint compatibility table doc [flink]

2023-12-03 Thread via GitHub
flinkbot commented on PR #23859: URL: https://github.com/apache/flink/pull/23859#issuecomment-1837554278 ## CI report: * ba1b3fd979c8011bf5989c68c5e78ebf40ce2048 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792534#comment-17792534 ] Jim Hughes commented on FLINK-33727: {quote}..., however tests are continuing passing. Is it

[jira] [Created] (FLINK-33729) Events are getting lost when an exception occurs within a processing function

2023-12-03 Thread Jira
Rafał Trójczak created FLINK-33729: -- Summary: Events are getting lost when an exception occurs within a processing function Key: FLINK-33729 URL: https://issues.apache.org/jira/browse/FLINK-33729

Re: [PR] [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support [flink-connector-elasticsearch]

2023-12-03 Thread via GitHub
mtfelisb commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1837517174 > @mtfelisb Are you still active on this PR? Hi, @MartijnVisser. Yes, I'm waiting for review. Also, I'll not implement the `DynamicTableSink` because @rinkako

[jira] [Commented] (FLINK-32986) The new createTemporaryFunction has some regression of type inference compare to the deprecated registerFunction

2023-12-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792544#comment-17792544 ] lincoln lee commented on FLINK-32986: - [~jeyhun] assigned to you. > The new createTemporaryFunction

Re: [PR] [FLINK-32986][test] Fix createTemporaryFunction type inference error [flink]

2023-12-03 Thread via GitHub
lincoln-lil commented on code in PR #23586: URL: https://github.com/apache/flink/pull/23586#discussion_r1413081174 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/UserDefinedFunctionTestUtils.scala: ## @@ -382,6 +382,13 @@ object

[PR] [FLINK-33730][doc] update the Flink upgrade savepoint compatibility table doc [flink]

2023-12-03 Thread via GitHub
JingGe opened a new pull request, #23859: URL: https://github.com/apache/flink/pull/23859 ## What is the purpose of the change update the Flink upgrade savepoint compatibility table doc to only include the current and previous releases according to the [Flink Update Policy for old

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792531#comment-17792531 ] Jim Hughes commented on FLINK-33727: > is there any reason to have same name? Yes and no.  The SQL

[jira] [Comment Edited] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792533#comment-17792533 ] Sergey Nuyanzin edited comment on FLINK-33727 at 12/3/23 2:32 PM: --

Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-03 Thread via GitHub
snuyanzin commented on code in PR #23858: URL: https://github.com/apache/flink/pull/23858#discussion_r1413116026 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java: ## @@ -142,7 +142,7 @@ public class

Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-03 Thread via GitHub
snuyanzin commented on PR #23858: URL: https://github.com/apache/flink/pull/23858#issuecomment-1837503632 Are there any savepoint where currently changed names were participating? Then how to find all? Or is it just a question in general? -- This is an automated message from the

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL [flink]

2023-12-03 Thread via GitHub
patricklucas commented on PR #23836: URL: https://github.com/apache/flink/pull/23836#issuecomment-1837516482 I considered a slightly different approach, delegating the lookup of the config option to the GCS Hadoop connector itself:

[jira] [Created] (FLINK-33730) Update the compatibility table to only include last three versions

2023-12-03 Thread Jing Ge (Jira)
Jing Ge created FLINK-33730: --- Summary: Update the compatibility table to only include last three versions Key: FLINK-33730 URL: https://issues.apache.org/jira/browse/FLINK-33730 Project: Flink

[jira] [Comment Edited] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792532#comment-17792532 ] Jim Hughes edited comment on FLINK-33727 at 12/3/23 2:26 PM: - {quote}... It

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792532#comment-17792532 ] Jim Hughes commented on FLINK-33727: {quote}... It seems it relies on some internal state... {quote}

[jira] [Created] (FLINK-33728) do not rewatch when KubernetesResourceManagerDriver watch fail

2023-12-03 Thread xiaogang zhou (Jira)
xiaogang zhou created FLINK-33728: - Summary: do not rewatch when KubernetesResourceManagerDriver watch fail Key: FLINK-33728 URL: https://issues.apache.org/jira/browse/FLINK-33728 Project: Flink

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792538#comment-17792538 ] Jim Hughes commented on FLINK-33727: {quote}if so I'm curious whether it would be more helpful for

[jira] [Updated] (FLINK-33730) Update the compatibility table to only include last three versions

2023-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33730: --- Labels: pull-request-available (was: ) > Update the compatibility table to only include

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792536#comment-17792536 ] Sergey Nuyanzin commented on FLINK-33727: - {quote} Presently, the method

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-03 Thread via GitHub
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1837569300 rebased since there were new commits in main flink master to hive-connector area also added archunit violations because of reent commit within FLINK-33637 @RyanSkraba

[jira] [Commented] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-12-03 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792505#comment-17792505 ] Junrui Li commented on FLINK-33502: --- Hello [~Wencong Liu], I've noticed an issue that was previously

[jira] [Comment Edited] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792499#comment-17792499 ] Sergey Nuyanzin edited comment on FLINK-33727 at 12/3/23 9:12 AM: --

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792499#comment-17792499 ] Sergey Nuyanzin commented on FLINK-33727: - [~jhughes]there is also a question about

[PR] Revert [FLINK-33470] Implement restore tests for Join node [flink]

2023-12-03 Thread via GitHub
snuyanzin opened a new pull request, #23861: URL: https://github.com/apache/flink/pull/23861 Since current implemenentation leads to ci failures like

[jira] [Commented] (FLINK-33731) failover.flip1 package can be rename to failover

2023-12-03 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792611#comment-17792611 ] Rui Fan commented on FLINK-33731: - Hi [~zhuzh] , what do you think? > failover.flip1 package can be

[jira] [Created] (FLINK-33732) Hive Lookup Join ProjectPushDown will encouter ArrayIndexOutOfBoundsException

2023-12-03 Thread lekelei (Jira)
lekelei created FLINK-33732: --- Summary: Hive Lookup Join ProjectPushDown will encouter ArrayIndexOutOfBoundsException Key: FLINK-33732 URL: https://issues.apache.org/jira/browse/FLINK-33732 Project: Flink

Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2023-12-03 Thread via GitHub
tweise commented on PR #23777: URL: https://github.com/apache/flink/pull/23777#issuecomment-1837588962 LGTM from my side, based on a quick review after @mxm had already covered the details. Regarding complexity: FLIP-27 sources are without doubt more complex for the source

Re: [PR] Revert [FLINK-33470] Implement restore tests for Join node [flink]

2023-12-03 Thread via GitHub
flinkbot commented on PR #23861: URL: https://github.com/apache/flink/pull/23861#issuecomment-1837630725 ## CI report: * 7be03755f669a2c83d4d67cad67cf2aaadfe2b32 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-12-03 Thread via GitHub
RocMarshal commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1837758141 The waiting mechanism is ready for the review. Would you @KarmaGYZ @1996fanrui help take a look if you were in free time? Thank you very much~ And the verification part about

[PR] [FLINK-33731][Scheduler] Remove the redundant flip1 package [flink]

2023-12-03 Thread via GitHub
1996fanrui opened a new pull request, #23862: URL: https://github.com/apache/flink/pull/23862 ## What is the purpose of the change Currently, there is a org.apache.flink.runtime.executiongraph.failover.flip1 package. I propose rename the failover.flip1 to failover, in the

Re: [PR] [FLINK-33502][network] Make DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment return null when the task is released [flink]

2023-12-03 Thread via GitHub
flinkbot commented on PR #23863: URL: https://github.com/apache/flink/pull/23863#issuecomment-1837775718 ## CI report: * 5f075724d2329b6a239d681b384ed4ac0d289144 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][sql-client] remove duplicated code in CliUtils [flink]

2023-12-03 Thread via GitHub
flinkbot commented on PR #23860: URL: https://github.com/apache/flink/pull/23860#issuecomment-1837578360 ## CI report: * 2bffbc227737e5d8ce0a130279e092d2950f4ae0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]

2023-12-03 Thread via GitHub
snuyanzin commented on code in PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25#discussion_r1413196788 ## pom.xml: ## @@ -558,6 +563,8 @@ under the License. US en

[jira] [Updated] (FLINK-33732) Hive Lookup Join ProjectPushDown will encouter ArrayIndexOutOfBoundsException

2023-12-03 Thread lekelei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lekelei updated FLINK-33732: Description: Here is my sql: ``` SET 'execution.runtime-mode' = 'streaming'; SET

Re: [PR] [FLINK-33541][table-planner] function RAND and RAND_INTEGER should return type nullable if the arguments are nullable [flink]

2023-12-03 Thread via GitHub
schnappi17 commented on PR #23779: URL: https://github.com/apache/flink/pull/23779#issuecomment-1837771000 Hi @xuyangzhong, any progress on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] [FLINK-33502][network] Make DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment return null when the task is released [flink]

2023-12-03 Thread via GitHub
WencongLiu opened a new pull request, #23863: URL: https://github.com/apache/flink/pull/23863 ## What is the purpose of the change *Make DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment return null when the task is released.* ## Does this pull request

Re: [PR] [FLINK-33731][Scheduler] Remove the redundant flip1 package [flink]

2023-12-03 Thread via GitHub
flinkbot commented on PR #23862: URL: https://github.com/apache/flink/pull/23862#issuecomment-1837775224 ## CI report: * f3b29fe0bffcd2511bfaf4f3c3284d0751120259 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][sql-client] remove duplicated code in CliUtils [flink]

2023-12-03 Thread via GitHub
JingGe opened a new pull request, #23860: URL: https://github.com/apache/flink/pull/23860 ## What is the purpose of the change remove duplicated code in the CliUtils ## Verifying this change This change is a trivial code cleanup without any test coverage. ## Does

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792599#comment-17792599 ] Jim Hughes commented on FLINK-33727: That works for me; I approved that PR. > JoinRestoreTest is

[jira] [Updated] (FLINK-33731) failover.flip1 package can be rename to failover

2023-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33731: --- Labels: pull-request-available (was: ) > failover.flip1 package can be rename to failover

Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2023-12-03 Thread via GitHub
tweise commented on code in PR #23777: URL: https://github.com/apache/flink/pull/23777#discussion_r1413186514 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/source/DoubleEmittingSourceReaderWithCheckpointsInBetween.java: ## @@ -0,0

Re: [PR] [FLINK-27529] Fix Intger Comparison For Source Index in Hybrid Source [flink]

2023-12-03 Thread via GitHub
varun1729DD commented on PR #23703: URL: https://github.com/apache/flink/pull/23703#issuecomment-1837577966 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792595#comment-17792595 ] Sergey Nuyanzin commented on FLINK-33727: - {quote} I apologize for taking out CI! The order

Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2023-12-03 Thread via GitHub
tweise commented on code in PR #23777: URL: https://github.com/apache/flink/pull/23777#discussion_r1413195035 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/source/DataGenerators.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the

Re: [PR] [FLINK-32986][test] Fix createTemporaryFunction type inference error [flink]

2023-12-03 Thread via GitHub
jeyhunkarimov commented on PR #23586: URL: https://github.com/apache/flink/pull/23586#issuecomment-1837590317 > @jeyhunkarimov thanks for fixing this! Only one comment. Thanks a lot for the review @lincoln-lil . I addressed your comment -- This is an automated message from the

[jira] [Commented] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-12-03 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792610#comment-17792610 ] Wencong Liu commented on FLINK-33502: - Thanks [~JunRuiLi] . I have investigated it and found that

[jira] [Created] (FLINK-33731) failover.flip1 package can be rename to failover

2023-12-03 Thread Rui Fan (Jira)
Rui Fan created FLINK-33731: --- Summary: failover.flip1 package can be rename to failover Key: FLINK-33731 URL: https://issues.apache.org/jira/browse/FLINK-33731 Project: Flink Issue Type: Technical

Re: [PR] [FLINK-33647] Implement restore tests for LookupJoin node [flink]

2023-12-03 Thread via GitHub
bvarghese1 commented on code in PR #23814: URL: https://github.com/apache/flink/pull/23814#discussion_r1413375404 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/LookupJoinTestPrograms.java: ## @@ -0,0 +1,287 @@ +/* + *

Re: [PR] [FLINK-33647] Implement restore tests for LookupJoin node [flink]

2023-12-03 Thread via GitHub
bvarghese1 commented on code in PR #23814: URL: https://github.com/apache/flink/pull/23814#discussion_r1413375613 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/LookupJoinTestPrograms.java: ## @@ -0,0 +1,287 @@ +/* + *

Re: [PR] [FLINK-33647] Implement restore tests for LookupJoin node [flink]

2023-12-03 Thread via GitHub
bvarghese1 commented on code in PR #23814: URL: https://github.com/apache/flink/pull/23814#discussion_r1413375281 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/LookupJoinTestPrograms.java: ## @@ -0,0 +1,287 @@ +/* + *

[jira] [Closed] (FLINK-33732) Hive Lookup Join ProjectPushDown will encouter ArrayIndexOutOfBoundsException

2023-12-03 Thread lekelei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lekelei closed FLINK-33732. --- Resolution: Fixed > Hive Lookup Join ProjectPushDown will encouter ArrayIndexOutOfBoundsException >

[jira] [Assigned] (FLINK-33733) [FLIP-321] Update the stability docs to add the migration periods.

2023-12-03 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned FLINK-33733: Assignee: Jiangjie Qin > [FLIP-321] Update the stability docs to add the migration

[jira] [Closed] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33727. --- > JoinRestoreTest is failing on AZP > - > >

[jira] [Resolved] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33727. - Fix Version/s: 1.19.0 Resolution: Fixed > JoinRestoreTest is failing on AZP >

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792651#comment-17792651 ] Sergey Nuyanzin commented on FLINK-33727: - reverted at 18b67b104e025b142a8321e5163edf7fbd439580

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-03 Thread via GitHub
becketqin commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1837910118 @mbalassi Do you have time to take a look at the doc update? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-03 Thread via GitHub
flinkbot commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1837911822 ## CI report: * aa4d7a5834e436ea8374efd610bb1e257a9ed5af UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33502][network] Make DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment return null when the task is released [flink]

2023-12-03 Thread via GitHub
WencongLiu commented on PR #23863: URL: https://github.com/apache/flink/pull/23863#issuecomment-1837973875 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-12-03 Thread via GitHub
JunRuiLee commented on code in PR #23847: URL: https://github.com/apache/flink/pull/23847#discussion_r1413344964 ## docs/content.zh/docs/deployment/filesystems/gcs.md: ## @@ -44,7 +44,10 @@ env.readTextFile("gs:///"); stream.writeAsText("gs:///"); // Use GCS as checkpoint

[jira] [Comment Edited] (FLINK-33470) Implement restore tests for Join node

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792650#comment-17792650 ] Sergey Nuyanzin edited comment on FLINK-33470 at 12/4/23 6:27 AM: -- I'm

Re: [PR] [FLINK-33502][network] Make DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment return null when the task is released [flink]

2023-12-03 Thread via GitHub
WencongLiu commented on PR #23863: URL: https://github.com/apache/flink/pull/23863#issuecomment-1837925107 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-12-03 Thread via GitHub
1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1413436882 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewDeclarativeSlotPoolBridge.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the

[PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-03 Thread via GitHub
zhengzhili333 opened a new pull request, #23866: URL: https://github.com/apache/flink/pull/23866 ## What is the purpose of the change *Currently, submitting a job starts with storing the JobGraph (in HA setups) in the JobGraphStore. This includes writing the file to S3 (or some other

[jira] [Updated] (FLINK-33500) Run storing the JobGraph an asynchronous operation

2023-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33500: --- Labels: pull-request-available (was: ) > Run storing the JobGraph an asynchronous

[jira] [Comment Edited] (FLINK-33470) Implement restore tests for Join node

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792652#comment-17792652 ] Sergey Nuyanzin edited comment on FLINK-33470 at 12/4/23 7:14 AM: -- a

Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]

2023-12-03 Thread via GitHub
JingsongLi merged PR #665: URL: https://github.com/apache/flink-web/pull/665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-12-03 Thread via GitHub
JunRuiLee commented on code in PR #23847: URL: https://github.com/apache/flink/pull/23847#discussion_r1413345096 ## docs/content.zh/docs/ops/state/task_failure_recovery.md: ## @@ -49,20 +49,18 @@ Flink 作业如果没有定义重启策略,则会遵循集群启动时加载 {{< generated/restart_strategy_configuration >}}

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-12-03 Thread via GitHub
JunRuiLee commented on code in PR #23847: URL: https://github.com/apache/flink/pull/23847#discussion_r1413345247 ## docs/content/docs/ops/state/task_failure_recovery.md: ## @@ -117,11 +116,11 @@ The fixed delay restart strategy can also be set programmatically: {{< tabs

Re: [PR] [FLINK-33647] Implement restore tests for LookupJoin node [flink]

2023-12-03 Thread via GitHub
bvarghese1 commented on code in PR #23814: URL: https://github.com/apache/flink/pull/23814#discussion_r1413356579 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/LookupJoinJsonPlanTest.java: ## @@ -1,273 +0,0 @@ -/* - *

[PR] [FLINK-33581][core] Deprecate configuration getters/setters that return/set complex Java objects in python flink. [flink]

2023-12-03 Thread via GitHub
JunRuiLee opened a new pull request, #23864: URL: https://github.com/apache/flink/pull/23864 ## What is the purpose of the change Deprecate configuration getters/setters that return/set complex Java objects in python flink. ## Brief change log - *Deprecate

[jira] [Commented] (FLINK-33732) Hive Lookup Join ProjectPushDown will encouter ArrayIndexOutOfBoundsException

2023-12-03 Thread lekelei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792646#comment-17792646 ] lekelei commented on FLINK-33732: - Duplicates the issue [FLINK-30679] Can not load the data of hive dim

[PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-03 Thread via GitHub
becketqin opened a new pull request, #23865: URL: https://github.com/apache/flink/pull/23865 ## What is the purpose of the change This PR update the ops doc to add the migration periods for deprecated APIs, which are specified in

[jira] [Reopened] (FLINK-33470) Implement restore tests for Join node

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reopened FLINK-33470: - I'm sorry however had to revert (also confirmed by [~jhughes])

[jira] [Assigned] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33727: --- Assignee: Sergey Nuyanzin > JoinRestoreTest is failing on AZP >

[jira] [Commented] (FLINK-33470) Implement restore tests for Join node

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792652#comment-17792652 ] Sergey Nuyanzin commented on FLINK-33470: - a note: how to reproduce it locally {quote} I was

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-12-03 Thread via GitHub
1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1413430330 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewPhysicalSlotProviderImpl.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-12-03 Thread via GitHub
1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1413436882 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewDeclarativeSlotPoolBridge.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the

Re: [PR] [hotfix][table] refactoring to template method to separate concerns [flink]

2023-12-03 Thread via GitHub
fsk119 commented on code in PR #23857: URL: https://github.com/apache/flink/pull/23857#discussion_r1413440533 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/print/TableauStyle.java: ## @@ -115,14 +115,26 @@ public final class TableauStyle

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-03 Thread via GitHub
JingGe commented on code in PR #23865: URL: https://github.com/apache/flink/pull/23865#discussion_r1413472466 ## docs/content/docs/ops/upgrading.md: ## @@ -60,6 +60,32 @@ Code written against a `PublicEvolving` API in 1.15.2 will continue to run in 1. That same code would

[jira] [Created] (FLINK-33734) Merge unaligned checkpoint

2023-12-03 Thread Feifan Wang (Jira)
Feifan Wang created FLINK-33734: --- Summary: Merge unaligned checkpoint Key: FLINK-33734 URL: https://issues.apache.org/jira/browse/FLINK-33734 Project: Flink Issue Type: Improvement

[jira] [Comment Edited] (FLINK-33731) failover.flip1 package can be rename to failover

2023-12-03 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792696#comment-17792696 ] Zhu Zhu edited comment on FLINK-33731 at 12/4/23 7:46 AM: -- LGTM. It is a legacy

[jira] [Comment Edited] (FLINK-33470) Implement restore tests for Join node

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792650#comment-17792650 ] Sergey Nuyanzin edited comment on FLINK-33470 at 12/4/23 7:58 AM: -- I'm

[jira] [Comment Edited] (FLINK-33470) Implement restore tests for Join node

2023-12-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792650#comment-17792650 ] Sergey Nuyanzin edited comment on FLINK-33470 at 12/4/23 7:58 AM: -- I'm

Re: [PR] [FLINK-33581][core] Deprecate configuration getters/setters that return/set complex Java objects in python flink. [flink]

2023-12-03 Thread via GitHub
JunRuiLee commented on PR #23864: URL: https://github.com/apache/flink/pull/23864#issuecomment-1837890764 Hi, @HuangXingBo , Would you be able to take a moment to review this PR? Thank you in advance! -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (FLINK-33733) [FLIP-321] Update the stability docs to add the migration periods.

2023-12-03 Thread Jiangjie Qin (Jira)
Jiangjie Qin created FLINK-33733: Summary: [FLIP-321] Update the stability docs to add the migration periods. Key: FLINK-33733 URL: https://issues.apache.org/jira/browse/FLINK-33733 Project: Flink

Re: [PR] Revert [FLINK-33470] Implement restore tests for Join node [flink]

2023-12-03 Thread via GitHub
snuyanzin merged PR #23861: URL: https://github.com/apache/flink/pull/23861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-03 Thread via GitHub
flinkbot commented on PR #23866: URL: https://github.com/apache/flink/pull/23866#issuecomment-1837954195 ## CI report: * 8c0d3fdc4aa77efe4a2736044d3715c96e3dacb8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][core][test] fix ArchUnit typo in pom [flink]

2023-12-03 Thread via GitHub
JingGe commented on PR #23826: URL: https://github.com/apache/flink/pull/23826#issuecomment-1837976261 Thanks @TanYuxin-tyx for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-12-03 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792679#comment-17792679 ] Junrui Li commented on FLINK-33502: --- [~Wencong Liu] Thank you for the clarification. I look forward to

[jira] [Commented] (FLINK-33722) MATCH_RECOGNIZE in batch mode ignores events order

2023-12-03 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-33722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792680#comment-17792680 ] Grzegorz Kołakowski commented on FLINK-33722: - Please assign me to the task. >

Re: [PR] [hotfix][core][test] fix ArchUnit typo in pom [flink]

2023-12-03 Thread via GitHub
JingGe merged PR #23826: URL: https://github.com/apache/flink/pull/23826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33731) failover.flip1 package can be rename to failover

2023-12-03 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792696#comment-17792696 ] Zhu Zhu commented on FLINK-33731: - LGTM. It is a legacy issue. When the new failover logics is

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-12-03 Thread via GitHub
1996fanrui commented on code in PR #23847: URL: https://github.com/apache/flink/pull/23847#discussion_r1413373818 ## docs/content.zh/docs/ops/state/task_failure_recovery.md: ## @@ -49,20 +49,18 @@ Flink 作业如果没有定义重启策略,则会遵循集群启动时加载 {{< generated/restart_strategy_configuration >}}

Re: [PR] [FLINK-33581][core] Deprecate configuration getters/setters that return/set complex Java objects in python flink. [flink]

2023-12-03 Thread via GitHub
flinkbot commented on PR #23864: URL: https://github.com/apache/flink/pull/23864#issuecomment-1837896315 ## CI report: * 3fcaa9a433c4c20a27fd4775b2fe0e78a83b2d81 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33724) Application mode doesn't support multiple lines argument

2023-12-03 Thread Jiaxing Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiaxing Chen updated FLINK-33724: - Description: When running a job in application mode, flink will save program arguments in

  1   2   >