Re: [PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.18) [flink]

2023-12-05 Thread via GitHub
dannycranmer merged PR #23840: URL: https://github.com/apache/flink/pull/23840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.17) [flink]

2023-12-05 Thread via GitHub
dannycranmer merged PR #23841: URL: https://github.com/apache/flink/pull/23841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.19) [flink]

2023-12-05 Thread via GitHub
dannycranmer merged PR #23839: URL: https://github.com/apache/flink/pull/23839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-05 Thread via GitHub
luoyuxia commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1842010718 @snuyanzin Hi, I also found some pages(https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/hive-compatibility/hive-dialect/overview/ ,

[jira] [Resolved] (FLINK-24819) Higher APIServer cpu load after using SharedIndexInformer replaced naked Kubernetes watch

2023-12-05 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-24819. -- Resolution: Fixed > Higher APIServer cpu load after using SharedIndexInformer replaced naked >

[jira] [Updated] (FLINK-24819) Higher APIServer cpu load after using SharedIndexInformer replaced naked Kubernetes watch

2023-12-05 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-24819: - Fix Version/s: 1.19.0 1.18.1 1.17.3 > Higher APIServer cpu load

[jira] [Commented] (FLINK-32028) Error handling for the new Elasticsearch sink

2023-12-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793492#comment-17793492 ] Weijie Guo commented on FLINK-32028: Thanks for taking this, I will take a look at this PR. > Error

[jira] [Assigned] (FLINK-32028) Error handling for the new Elasticsearch sink

2023-12-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-32028: -- Assignee: Peter Schulz > Error handling for the new Elasticsearch sink >

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1842026548 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1842032773 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-05 Thread via GitHub
zhengzhili333 opened a new pull request, #23880: URL: https://github.com/apache/flink/pull/23880 ## What is the purpose of the change *Currently, submitting a job starts with storing the JobGraph (in HA setups) in the JobGraphStore. This includes writing the file to S3 (or some other

Re: [PR] [FLINK-33502][network] Prevent DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment from throwing NPE when the task is released [flink]

2023-12-05 Thread via GitHub
WencongLiu commented on PR #23863: URL: https://github.com/apache/flink/pull/23863#issuecomment-1842037511 > Thanks for the update, I'm + 1 for this one. Could you please also align commit message with the title of this PR. Done. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33713][core] Deprecate RuntimeContext#getExecutionConfig [flink]

2023-12-05 Thread via GitHub
JunRuiLee commented on PR #23848: URL: https://github.com/apache/flink/pull/23848#issuecomment-1842040305 Hi @zhuzhurk , thanks for your feedback. I have updated the pull request based on your comments. Please take a look when you have a moment. -- This is an automated message from the

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-05 Thread via GitHub
flinkbot commented on PR #23880: URL: https://github.com/apache/flink/pull/23880#issuecomment-1842042843 ## CI report: * db9949a710f0dcf6d317053732a0e96b75568944 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Reopened] (FLINK-25857) Add committer metrics to track the status of committables

2023-12-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reopened FLINK-25857: Re-open this per discuss in mail-list. > Add committer metrics to track the status of committables >

[jira] [Commented] (FLINK-27291) Translate the "List of Data Types" section of "Data Types" in to Chinese

2023-12-05 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793496#comment-17793496 ] 韩宏旭 commented on FLINK-27291: - Hey Chengkai Yang,Cason I am experienced in flink. I have seen this issue is

[jira] (FLINK-27291) Translate the "List of Data Types" section of "Data Types" in to Chinese

2023-12-05 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27291 ] 韩宏旭 deleted comment on FLINK-27291: - was (Author: maomao): Hey Chengkai Yang,Cason I am experienced in flink. I have seen this issue is created at 18/Apr/22 19:51 and Updated at 27/Mar/23 11:34.

[jira] [Commented] (FLINK-27291) Translate the "List of Data Types" section of "Data Types" in to Chinese

2023-12-05 Thread hongxu han (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793497#comment-17793497 ] hongxu han commented on FLINK-27291: Hey Chengkai Yang,Cason I am experienced in flink. I have seen

[jira] (FLINK-27291) Translate the "List of Data Types" section of "Data Types" in to Chinese

2023-12-05 Thread hongxu han (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27291 ] hongxu han deleted comment on FLINK-27291: was (Author: maomao): Hey Chengkai Yang,Cason I am experienced in flink. I have seen this issue is created at 18/Apr/22 19:51 and Updated at

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1841618310 @cuibo01 @MartijnVisser I just run into this issue (Flink 1.17) and was happy to find this PR. Any reason this stalled? Can I help get this to the finish line? -- This is an automated

[jira] [Created] (FLINK-33757) Implement restore tests for Rank node

2023-12-05 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33757: -- Summary: Implement restore tests for Rank node Key: FLINK-33757 URL: https://issues.apache.org/jira/browse/FLINK-33757 Project: Flink Issue Type: Sub-task

[PR] [FLINK-33757] Implement restore tests for Rank node [flink]

2023-12-05 Thread via GitHub
jnh5y opened a new pull request, #23878: URL: https://github.com/apache/flink/pull/23878 ## What is the purpose of the change Implement restore tests for Rank node ## Verifying this change This change added tests and can be verified as follows: * Added restore

[jira] [Closed] (FLINK-33724) Application mode doesn't support multiple lines argument

2023-12-05 Thread Jiaxing Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiaxing Chen closed FLINK-33724. Resolution: Done > Application mode doesn't support multiple lines argument >

[jira] [Commented] (FLINK-33724) Application mode doesn't support multiple lines argument

2023-12-05 Thread Jiaxing Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793478#comment-17793478 ] Jiaxing Chen commented on FLINK-33724: -- Noticed that this issue has been mentioned in FLIP-366,and

[jira] [Updated] (FLINK-25593) A redundant scan could be skipped if it is an input of join and the other input is empty after partition prune

2023-12-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-25593: - Fix Version/s: 1.19.0 > A redundant scan could be skipped if it is an input of join and the other >

[jira] [Reopened] (FLINK-25593) A redundant scan could be skipped if it is an input of join and the other input is empty after partition prune

2023-12-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reopened FLINK-25593: -- > A redundant scan could be skipped if it is an input of join and the other > input is empty after

[jira] [Closed] (FLINK-25593) A redundant scan could be skipped if it is an input of join and the other input is empty after partition prune

2023-12-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-25593. Resolution: Fixed > A redundant scan could be skipped if it is an input of join and the other > input is

Re: [PR] [FLINK-33691] Support agg push down for 'count(*)/count(1)/count(column not null)' [flink]

2023-12-05 Thread via GitHub
swuferhong commented on code in PR #23828: URL: https://github.com/apache/flink/pull/23828#discussion_r1416555940 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/PushLocalSortAggWithSortAndCalcIntoScanRule.java: ## @@

Re: [PR] [FLINK-33691] Support agg push down for 'count(*)/count(1)/count(column not null)' [flink]

2023-12-05 Thread via GitHub
swuferhong commented on code in PR #23828: URL: https://github.com/apache/flink/pull/23828#discussion_r1416564050 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/PushLocalSortAggWithCalcIntoScanRule.java: ## @@ -74,9

Re: [PR] [FLINK-33713][core] Deprecate RuntimeContext#getExecutionConfig [flink]

2023-12-05 Thread via GitHub
zhuzhurk commented on code in PR #23848: URL: https://github.com/apache/flink/pull/23848#discussion_r1416568345 ## flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java: ## @@ -83,10 +86,27 @@ public AbstractRuntimeUDFContext( }

Re: [PR] [FLINK-33713][core] Deprecate RuntimeContext#getExecutionConfig [flink]

2023-12-05 Thread via GitHub
zhuzhurk commented on code in PR #23848: URL: https://github.com/apache/flink/pull/23848#discussion_r1416568345 ## flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java: ## @@ -83,10 +86,27 @@ public AbstractRuntimeUDFContext( }

Re: [PR] [FLINK-33726][sql-client] print time cost for streaming queries [flink]

2023-12-05 Thread via GitHub
fsk119 commented on code in PR #23868: URL: https://github.com/apache/flink/pull/23868#discussion_r1416572012 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java: ## @@ -114,6 +108,30 @@ public void displayResults() throws

Re: [PR] [FLINK-33691] Support agg push down for 'count(*)/count(1)/count(column not null)' [flink]

2023-12-05 Thread via GitHub
swuferhong commented on code in PR #23828: URL: https://github.com/apache/flink/pull/23828#discussion_r1416573713 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/PushLocalSortAggWithSortAndCalcIntoScanRule.java: ## @@

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1841996519 @cuibo01 thanks, I resolved conflicts and pushed the merge for testing - will do a rebase after we see tests pass. -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-05 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416588553 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java: ## @@ -59,4 +59,7 @@ public interface ResultProvider {

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-05 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416588553 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java: ## @@ -59,4 +59,7 @@ public interface ResultProvider {

Re: [PR] [FLINK-33710] Prevent triggering cluster upgrades for permutations of the same overrides [flink-kubernetes-operator]

2023-12-05 Thread via GitHub
1996fanrui commented on code in PR #721: URL: https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1416590912 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizerTest.java: ## @@ -30,12 +31,23

[jira] [Closed] (FLINK-31659) java.lang.ClassNotFoundException: org.apache.flink.table.planner.delegation.DialectFactory when bundled Hive connector jar is in classpath

2023-12-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-31659. Fix Version/s: 1.18.0 Resolution: Invalid Should be fixed after

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-05 Thread via GitHub
luoyuxia commented on code in PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#discussion_r1416565534 ## flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java: ## @@ -0,0 +1,1000 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-05 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793488#comment-17793488 ] Yue Ma commented on FLINK-27681: [~masteryhx] [~pnowojski] [~fanrui]  Thanks for the discussion So,

[jira] [Created] (FLINK-33758) Implement restore tests for TemporalSort node

2023-12-05 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33758: -- Summary: Implement restore tests for TemporalSort node Key: FLINK-33758 URL: https://issues.apache.org/jira/browse/FLINK-33758 Project: Flink Issue Type:

[jira] [Assigned] (FLINK-33758) Implement restore tests for TemporalSort node

2023-12-05 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Hughes reassigned FLINK-33758: -- Assignee: Jim Hughes > Implement restore tests for TemporalSort node >

[PR] [FLINK-33758] Implement restore tests for TemporalSort node [flink]

2023-12-05 Thread via GitHub
jnh5y opened a new pull request, #23879: URL: https://github.com/apache/flink/pull/23879 ## What is the purpose of the change Implement restore tests for TemporalSort node ## Verifying this change This change added tests and can be verified as follows: * Added

[jira] [Updated] (FLINK-33758) Implement restore tests for TemporalSort node

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33758: --- Labels: pull-request-available (was: ) > Implement restore tests for TemporalSort node >

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
cuibo01 commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1841927134 @tweise , Of course you can, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33758] Implement restore tests for TemporalSort node [flink]

2023-12-05 Thread via GitHub
flinkbot commented on PR #23879: URL: https://github.com/apache/flink/pull/23879#issuecomment-1841777502 ## CI report: * 3a3ae47704eb419e33eb8ffc643c83f83befcb43 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-12-05 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793457#comment-17793457 ] Mason Chen commented on FLINK-33545: The reason why you don't find any synchronization is because

[jira] [Comment Edited] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-12-05 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793457#comment-17793457 ] Mason Chen edited comment on FLINK-33545 at 12/5/23 11:40 PM: -- The reason

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-05 Thread via GitHub
zhengzhili333 closed pull request #23866: [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation URL: https://github.com/apache/flink/pull/23866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-05 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793505#comment-17793505 ] Zakelly Lan commented on FLINK-33734: - hi [~Feifan Wang] ,   I'm wondering if this proposal aims

Re: [PR] [FLINK-33752][Configuration] Change the displayed timeunit to day when the duration is an integral multiple of 1 day [flink]

2023-12-05 Thread via GitHub
1996fanrui merged PR #23873: URL: https://github.com/apache/flink/pull/23873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-33759: Description: When we use flink-parquet format wirte Map[] type (which will be read by spark job),

[jira] [Created] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
Cai Liuyang created FLINK-33759: --- Summary: flink parquet writer support write nested array or map type Key: FLINK-33759 URL: https://issues.apache.org/jira/browse/FLINK-33759 Project: Flink

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-33759: Description: When we use flink-parquet format wirte Map[] type (which will be read by spark

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-33759: Description: When we use flink-parquet format wirte Map[] type (which will be read by spark

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-33759: Description: When we use flink-parquet format wirte Map[] type (which will be read by spark

[jira] [Commented] (FLINK-33752) When Duration is greater than or equal to 1 day, the display unit is ms.

2023-12-05 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793517#comment-17793517 ] Rui Fan commented on FLINK-33752: - Merged to master<1.19> via: 9b61b137bdc7eff773847b84e5cde116e6280c1d

[jira] [Resolved] (FLINK-33752) When Duration is greater than or equal to 1 day, the display unit is ms.

2023-12-05 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33752. - Resolution: Fixed > When Duration is greater than or equal to 1 day, the display unit is ms. >

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-33759: Description: When we use flink-parquet format wirte Map[] type (which will be read by spark

Re: [PR] Draft FLINK-32898 [CI] [flink]

2023-12-05 Thread via GitHub
caodizhou commented on PR #23842: URL: https://github.com/apache/flink/pull/23842#issuecomment-1842126287 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [FLINK-33759] flink parquet writer support write nested array or map type [flink]

2023-12-05 Thread via GitHub
LoveHeat opened a new pull request, #23881: URL: https://github.com/apache/flink/pull/23881 ## What is the purpose of the change see: [FLINK-33759](https://issues.apache.org/jira/browse/FLINK-33759) ## Brief change log *(for example:)* - *The TaskInfo is

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33759: --- Labels: pull-request-available (was: ) > flink parquet writer support write nested array

Re: [PR] [FLINK-33759] flink parquet writer support write nested array or map type [flink]

2023-12-05 Thread via GitHub
flinkbot commented on PR #23881: URL: https://github.com/apache/flink/pull/23881#issuecomment-1842150254 ## CI report: * beeb17b4d54d2c2ed0ea61df6e07892bc792e2e0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-33760) Group Window agg has different result when only consuming -D records while using or not using minibatch

2023-12-05 Thread xuyang (Jira)
xuyang created FLINK-33760: -- Summary: Group Window agg has different result when only consuming -D records while using or not using minibatch Key: FLINK-33760 URL: https://issues.apache.org/jira/browse/FLINK-33760

Re: [PR] [FLINK-33666][table] Use the same constraint name in MergeTableLikeUtil and Schema [flink]

2023-12-05 Thread via GitHub
jeyhunkarimov commented on PR #23877: URL: https://github.com/apache/flink/pull/23877#issuecomment-1842153994 Hi @twalthr could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] [hotfix][test] Migrate JsonRowDeserializationSchemaTest/JsonRowSerializationSchemaTest to Junit5 and Assertj [flink]

2023-12-05 Thread via GitHub
swuferhong opened a new pull request, #23882: URL: https://github.com/apache/flink/pull/23882 ## What is the purpose of the change When reading the code about json format, I found the test classes `JsonRowDeserializationSchemaTest` and `JsonRowSerializationSchemaTest`

Re: [PR] [hotfix][test] Migrate JsonRowDeserializationSchemaTest/JsonRowSerializationSchemaTest to Junit5 and Assertj [flink]

2023-12-05 Thread via GitHub
flinkbot commented on PR #23882: URL: https://github.com/apache/flink/pull/23882#issuecomment-1842175348 ## CI report: * bf391fd5e7547df3e574138b264cb7802f150c62 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1842179446 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-05 Thread via GitHub
xiangforever2014 commented on code in PR #23253: URL: https://github.com/apache/flink/pull/23253#discussion_r1416745308 ## flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java: ## @@ -188,6 +207,21 @@ CompletableFuture triggerSavepoint( */

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-05 Thread via GitHub
xiangforever2014 commented on PR #23253: URL: https://github.com/apache/flink/pull/23253#issuecomment-1842188948 > Hi @xiangforever2014 @masteryhx sorry for jumping in... And I'm wondering if we could use the capital '-D' for short option? Or I suggest we do not leave any short option for

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-05 Thread via GitHub
zhengzhili333 commented on PR #23866: URL: https://github.com/apache/flink/pull/23866#issuecomment-1840210958 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-33663) Serialize CallExpressions into SQL

2023-12-05 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33663. Resolution: Implemented Implemented in bc6c2cec37c45f021ae22a2a7b5ab9537b8506cd >

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-05 Thread via GitHub
masteryhx commented on code in PR #23253: URL: https://github.com/apache/flink/pull/23253#discussion_r1415222035 ## docs/content.zh/docs/deployment/cli.md: ## @@ -125,6 +125,43 @@ Lastly, you can optionally provide what should be the [binary format]({{< ref "d The path to

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-05 Thread via GitHub
gaborgsomogyi commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1840452321 Thanks for the explanation! > In terms of the source / binary compatibility, the main reason we do not provide binary compatibility in minor releases for any API stability

[jira] [Updated] (FLINK-33751) use modules correctly when deserializing json plan

2023-12-05 Thread shuaiqi.guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuaiqi.guo updated FLINK-33751: Attachment: FLINK-33751.patch > use modules correctly when deserializing json plan >

[jira] [Created] (FLINK-33751) use modules correctly when deserializing json plan

2023-12-05 Thread shuaiqi.guo (Jira)
shuaiqi.guo created FLINK-33751: --- Summary: use modules correctly when deserializing json plan Key: FLINK-33751 URL: https://issues.apache.org/jira/browse/FLINK-33751 Project: Flink Issue Type:

Re: [PR] [FLINK-33502][network] Prevent DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment from throwing NPE when the task is released [flink]

2023-12-05 Thread via GitHub
WencongLiu commented on code in PR #23863: URL: https://github.com/apache/flink/pull/23863#discussion_r1415495161 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskTierProducerAgent.java: ## @@ -223,9 +228,16 @@ private

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-05 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1415242114 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java: ## @@ -59,4 +59,7 @@ public interface ResultProvider {

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-12-05 Thread via GitHub
zhuzhurk closed pull request #23847: [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. URL: https://github.com/apache/flink/pull/23847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Closed] (FLINK-33669) Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend.

2023-12-05 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-33669. --- Fix Version/s: 1.19.0 Resolution: Done master: e27f8a3a0783d551457a2f424b01267bd1c8c2c2

Re: [PR] [FLINK-33730][doc] update the Flink upgrade savepoint compatibility table doc [flink]

2023-12-05 Thread via GitHub
JingGe commented on PR #23859: URL: https://github.com/apache/flink/pull/23859#issuecomment-1840309252 @PatrickRen Thanks for the review. I have address your suggestion and add 1.16.x column back. Would you please check it again? -- This is an automated message from the Apache Git

[jira] [Commented] (FLINK-33670) Public operators cannot be reused in multi sinks

2023-12-05 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793232#comment-17793232 ] Jeyhun Karimov commented on FLINK-33670: Hi [~zicat] I tried with Flink master branch, below is

[jira] [Created] (FLINK-33753) ContinuousFileReaderOperator consume records as mini batch

2023-12-05 Thread Prabhu Joseph (Jira)
Prabhu Joseph created FLINK-33753: - Summary: ContinuousFileReaderOperator consume records as mini batch Key: FLINK-33753 URL: https://issues.apache.org/jira/browse/FLINK-33753 Project: Flink

[jira] [Created] (FLINK-33752) When Duration is greater than or equal to 1 day, the display unit is ms.

2023-12-05 Thread Rui Fan (Jira)
Rui Fan created FLINK-33752: --- Summary: When Duration is greater than or equal to 1 day, the display unit is ms. Key: FLINK-33752 URL: https://issues.apache.org/jira/browse/FLINK-33752 Project: Flink

[jira] [Updated] (FLINK-33752) When Duration is greater than or equal to 1 day, the display unit is ms.

2023-12-05 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33752: Description: When the default value of Duration is 24 hours or 1 day, the display unit is ms. (8640

Re: [PR] [FLINK-24150][k8s] Support to configure cpu resource request and limit in pod template [flink]

2023-12-05 Thread via GitHub
gyfora commented on PR #23872: URL: https://github.com/apache/flink/pull/23872#issuecomment-1840282229 I understand that this may be confusing for you but unfortunately we cannot merge this PR in this form. Let's work on the operator side to solve this properly as seen in the linked lira

Re: [PR] [FLINK-33663] Serialize CallExpressions into SQL [flink]

2023-12-05 Thread via GitHub
dawidwys merged PR #23811: URL: https://github.com/apache/flink/pull/23811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-28229) Introduce Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-12-05 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-28229. Fix Version/s: 1.19.0 Resolution: Fixed master:

Re: [PR] [FLINK-33502][network] Prevent DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment from throwing NPE when the task is released [flink]

2023-12-05 Thread via GitHub
WencongLiu commented on code in PR #23863: URL: https://github.com/apache/flink/pull/23863#discussion_r1415504026 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskTierProducerAgent.java: ## @@ -223,9 +228,16 @@ private

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-05 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793189#comment-17793189 ] Hangxiang Yu commented on FLINK-27681: -- Sorry for the late reply. {quote}However,  the job must

Re: [PR] [FLINK-24150][k8s] Support to configure cpu resource request and limit in pod template [flink]

2023-12-05 Thread via GitHub
Sucran commented on PR #23872: URL: https://github.com/apache/flink/pull/23872#issuecomment-1840275371 > -1 from my side based on previous community discussion: > > Please see the discussion in https://lists.apache.org/thread/6p5tk6obmk1qxf169so498z4vk8cg969 and the ticket:

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-05 Thread via GitHub
masteryhx commented on code in PR #23253: URL: https://github.com/apache/flink/pull/23253#discussion_r1415217180 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java: ## @@ -157,6 +157,14 @@ public class CliFrontendParser {

Re: [PR] [FLINK-28229][connectors] Introduce FLIP-27 alternative to StreamExecutionEnvironment#fromCollection() [flink]

2023-12-05 Thread via GitHub
zentol merged PR #23558: URL: https://github.com/apache/flink/pull/23558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33541][table-planner] function RAND and RAND_INTEGER should return type nullable if the arguments are nullable [flink]

2023-12-05 Thread via GitHub
libenchao commented on PR #23779: URL: https://github.com/apache/flink/pull/23779#issuecomment-1840508653 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-33752) When Duration is greater than or equal to 1 day, the display unit is ms.

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33752: --- Labels: pull-request-available (was: ) > When Duration is greater than or equal to 1 day,

[jira] [Commented] (FLINK-33338) Bump FRocksDB version

2023-12-05 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793246#comment-17793246 ] Yanfei Lei commented on FLINK-8: [~mayuehappy]/[~pnowojski]  Some updates: I first released a

Re: [PR] [FLINK-33752][Configuration] Change the displayed timeunit to day when the duration is an integral multiple of 1 day [flink]

2023-12-05 Thread via GitHub
flinkbot commented on PR #23873: URL: https://github.com/apache/flink/pull/23873#issuecomment-1840670193 ## CI report: * 3bbbddd74077c28f009567d49f99e6277223c03b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32986][test] Fix createTemporaryFunction type inference error [flink]

2023-12-05 Thread via GitHub
jeyhunkarimov commented on PR #23586: URL: https://github.com/apache/flink/pull/23586#issuecomment-1840305544 Does it make any difference? yes and no IMHO. Yes, because imagine `test1()` executes the statement `createTemporarySystemFunction("add", new TestAddWithOpen)` (also

Re: [PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2023-12-05 Thread via GitHub
Zakelly commented on code in PR #23514: URL: https://github.com/apache/flink/pull/23514#discussion_r1415294769 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FileMergingCheckpointStateOutputStream.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the

Re: [PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2023-12-05 Thread via GitHub
Zakelly commented on PR #23514: URL: https://github.com/apache/flink/pull/23514#issuecomment-1840444858 > Thanks @fredia and @Zakelly for your comments. Sorry for the late reply. I have addressed your comments. Would you please take another look? Thanks for your effort. I have no

  1   2   >