Re: [PR] [FLINK-33932][checkpointing] Add retry mechanism in RocksDBStateUploader [flink]

2024-01-04 Thread via GitHub
pnowojski commented on code in PR #23986: URL: https://github.com/apache/flink/pull/23986#discussion_r1441986930 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateUploader.java: ## @@ -107,13 +122,43 @@ private

Re: [PR] [FLINK-33979] Implement restore tests for TableSink node [flink]

2024-01-04 Thread via GitHub
jnh5y commented on PR #24024: URL: https://github.com/apache/flink/pull/24024#issuecomment-1877530126 Similar to the table source PR, I peeked at `SinkAbilitySpec`. Looks like `OverwriteSpec`, `PartitioningSpec`, and `WritingMetadataSpec` are covered. I wonder if we should

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803187#comment-17803187 ] Martijn Visser commented on FLINK-33490: Sounds good to me, thank you! > Validate the name

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
pnowojski commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1441999383 ## docs/content/docs/ops/traces.md: ## @@ -97,7 +97,7 @@ Flink reports a single span trace for the whole checkpoint once checkpoint reach -

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-04 Thread via GitHub
jnh5y commented on PR #24020: URL: https://github.com/apache/flink/pull/24020#issuecomment-1877525393 From very quick skimming... I looked at `SourceAbilitySpec`, and it looks like this test ought to help cover the `JsonSubTypes` there. I think I see the following readily: ```

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-01-04 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-1877219219 @hlteoh37 @dannycranmer please review this PR when you have the chance, so we can proceed with the other related tasks -- This is an automated message from the Apache Git

Re: [PR] [FLINK-24379][Formats] Avro Glue Schema Registry table format [flink-connector-aws]

2024-01-04 Thread via GitHub
nicusX commented on PR #122: URL: https://github.com/apache/flink-connector-aws/pull/122#issuecomment-1877217949 @dannycranmer please review this PR when you have the chance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803201#comment-17803201 ] Piotr Nowojski commented on FLINK-33856: Hi, I second that implementing this as metrics doesn't

[jira] [Comment Edited] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803201#comment-17803201 ] Piotr Nowojski edited comment on FLINK-33856 at 1/4/24 3:00 PM: Hi, I

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-04 Thread via GitHub
XComp commented on PR #22984: URL: https://github.com/apache/flink/pull/22984#issuecomment-1877310802 Thanks for picking this up. We should merge FLINK-32570 soon'ish to not miss it for 1.19. I reiterated over the PR once more with the following changes: * I rebased the branch to

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803196#comment-17803196 ] Zhongqiang Gong commented on FLINK-33970: - [~martijnvisser] I had tried to use hugo to check

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803203#comment-17803203 ] Zhongqiang Gong commented on FLINK-33970: - [~martijnvisser] And I checked my pr cannot solve the

[jira] [Updated] (FLINK-33993) Ineffective scaling detection events are misleading

2024-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33993: --- Labels: pull-request-available (was: ) > Ineffective scaling detection events are

[jira] [Commented] (FLINK-33994) Use Datadog api key from environment variables if not set in conf

2024-01-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803251#comment-17803251 ] Martijn Visser commented on FLINK-33994: That PR isn't in good shape (doesn't have a test and it

[jira] [Updated] (FLINK-33994) Use Datadog api key from environment variables if not set in conf

2024-01-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-33994: --- Component/s: (was: flink-contrib) > Use Datadog api key from environment variables if

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-04 Thread via GitHub
jnh5y commented on code in PR #24020: URL: https://github.com/apache/flink/pull/24020#discussion_r1442077875 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TableTestProgram.java: ## @@ -198,6 +198,18 @@ public SqlTestStep

[jira] [Commented] (FLINK-33994) Use Datadog api key from environment variables if not set in conf

2024-01-04 Thread Sweta Kalakuntla (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803289#comment-17803289 ] Sweta Kalakuntla commented on FLINK-33994: -- Ok, I just shared the PR that was done by someone

[jira] [Created] (FLINK-33993) Ineffective scaling detection events are misleading

2024-01-04 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-33993: -- Summary: Ineffective scaling detection events are misleading Key: FLINK-33993 URL: https://issues.apache.org/jira/browse/FLINK-33993 Project: Flink

[jira] [Updated] (FLINK-33932) Support retry mechanism for rocksdb uploader

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33932: --- Description: Rocksdb uploader will throw exception and decline the current checkpoint if

[jira] [Assigned] (FLINK-33995) Add test in test_file_sink.sh s3 StreamingFileSink for csv

2024-01-04 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh reassigned FLINK-33995: --- Assignee: Samrat Deb > Add test in test_file_sink.sh s3 StreamingFileSink for csv

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-04 Thread via GitHub
bvarghese1 commented on code in PR #24020: URL: https://github.com/apache/flink/pull/24020#discussion_r1442091512 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TableTestProgram.java: ## @@ -198,6 +198,18 @@ public SqlTestStep

[jira] [Commented] (FLINK-33932) Support retry mechanism for rocksdb uploader

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803237#comment-17803237 ] Piotr Nowojski commented on FLINK-33932: Yes, I don't think this should cause a correctness

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803181#comment-17803181 ] Martijn Visser commented on FLINK-33970: Next to this, I believe this only fixes the problem for

[jira] [Created] (FLINK-33994) Use Datadog api key from environment variables if not set in conf

2024-01-04 Thread Sweta Kalakuntla (Jira)
Sweta Kalakuntla created FLINK-33994: Summary: Use Datadog api key from environment variables if not set in conf Key: FLINK-33994 URL: https://issues.apache.org/jira/browse/FLINK-33994 Project:

Re: [PR] [FLINK-33536] Fix Flink Table API CSV streaming sink fails with IOException: Stream closed [flink]

2024-01-04 Thread via GitHub
Samrat002 commented on PR #23725: URL: https://github.com/apache/flink/pull/23725#issuecomment-1877501000 Hi @MartijnVisser , @hlteoh37 , I found that `test_file_sink.sh s3 StreamingFileSink` doesnt have test case for csv format .

[jira] [Created] (FLINK-33995) Add test in test_file_sink.sh s3 StreamingFileSink for csv

2024-01-04 Thread Samrat Deb (Jira)
Samrat Deb created FLINK-33995: -- Summary: Add test in test_file_sink.sh s3 StreamingFileSink for csv Key: FLINK-33995 URL: https://issues.apache.org/jira/browse/FLINK-33995 Project: Flink

[jira] [Created] (FLINK-33996) Support disabling project rewrite when multiple exprs in the project reference the same project.

2024-01-04 Thread Feng Jin (Jira)
Feng Jin created FLINK-33996: Summary: Support disabling project rewrite when multiple exprs in the project reference the same project. Key: FLINK-33996 URL: https://issues.apache.org/jira/browse/FLINK-33996

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803179#comment-17803179 ] Martijn Visser commented on FLINK-33970: This shouldn't be fixed per connector, but once in the

[jira] [Updated] (FLINK-33897) Allow triggering unaligned checkpoint via CLI

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33897: --- Issue Type: New Feature (was: Improvement) > Allow triggering unaligned checkpoint via CLI

[jira] [Commented] (FLINK-33897) Allow triggering unaligned checkpoint via CLI

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803185#comment-17803185 ] Piotr Nowojski commented on FLINK-33897: I have mixed feelings. Shouldn't the solution be to

[jira] [Created] (FLINK-33992) Add option to fetch the jar from private repository in FlinkSessionJob

2024-01-04 Thread Sweta Kalakuntla (Jira)
Sweta Kalakuntla created FLINK-33992: Summary: Add option to fetch the jar from private repository in FlinkSessionJob Key: FLINK-33992 URL: https://issues.apache.org/jira/browse/FLINK-33992

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
rkhachatryan commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1441837132 ## docs/content/docs/ops/traces.md: ## @@ -97,7 +97,7 @@ Flink reports a single span trace for the whole checkpoint once checkpoint reach -

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-04 Thread via GitHub
XComp commented on code in PR #22984: URL: https://github.com/apache/flink/pull/22984#discussion_r1441915244 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java: ## @@ -810,7 +811,8 @@ public

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-04 Thread via GitHub
XComp commented on code in PR #22984: URL: https://github.com/apache/flink/pull/22984#discussion_r1441914909 ## flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java: ## @@ -72,9 +72,23 @@ public static RestartStrategyConfiguration

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-04 Thread via GitHub
XComp commented on code in PR #22984: URL: https://github.com/apache/flink/pull/22984#discussion_r1441916069 ## flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java: ## @@ -53,13 +54,14 @@ public class StateTtlConfig implements Serializable {

Re: [PR] [FLINK-33958] Implement restore tests for IntervalJoin node [flink]

2024-01-04 Thread via GitHub
jnh5y commented on PR #24009: URL: https://github.com/apache/flink/pull/24009#issuecomment-1877510321 From reading the code for `StreamExecIntervalJoin`, I noticed pad/filter-left/right transformations. Seems like those can be produced when the `TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS` is

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-04 Thread via GitHub
rkhachatryan commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1442110980 ## docs/content/docs/ops/traces.md: ## @@ -97,7 +97,7 @@ Flink reports a single span trace for the whole checkpoint once checkpoint reach -

[jira] [Created] (FLINK-33997) Typo in the doc `classloader.parent-first-patterns-additional`

2024-01-04 Thread Matyas Orhidi (Jira)
Matyas Orhidi created FLINK-33997: - Summary: Typo in the doc `classloader.parent-first-patterns-additional` Key: FLINK-33997 URL: https://issues.apache.org/jira/browse/FLINK-33997 Project: Flink

[jira] [Updated] (FLINK-33998) Flink Job Manager restarted after kube-apiserver connection intermittent

2024-01-04 Thread Xiangyan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiangyan updated FLINK-33998: - Description: We are running Flink on AWS EKS and experienced Job Manager restart issue when EKS

[jira] [Updated] (FLINK-33998) Flink Job Manager restarted after kube-apiserver connection intermittent

2024-01-04 Thread Xiangyan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiangyan updated FLINK-33998: - Description: We are running Flink on AWS EKS and experienced Job Manager restart issue when EKS

[jira] [Updated] (FLINK-33998) Flink Job Manager restarted after kube-apiserver connection intermittent

2024-01-04 Thread Xiangyan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiangyan updated FLINK-33998: - Description: We are running Flink on AWS EKS and experienced Job Manager restart issue when EKS

Re: [PR] [FLINK-31896][runtime] Extend web interface to support failure labels [flink]

2024-01-04 Thread via GitHub
dmvk commented on code in PR #22646: URL: https://github.com/apache/flink/pull/22646#discussion_r1411713724 ## flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.html: ## @@ -52,6 +52,12 @@ {{ item.selected.timestamp | date:

Re: [PR] [FLINK-31896][runtime] Extend web interface to support failure labels [flink]

2024-01-04 Thread via GitHub
dmvk merged PR #22646: URL: https://github.com/apache/flink/pull/22646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2024-01-04 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803388#comment-17803388 ] Sai Sharath Dandi commented on FLINK-33611: --- @libenchao, Thanks for the suggestion to add the

[jira] [Comment Edited] (FLINK-33611) Support Large Protobuf Schemas

2024-01-04 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803388#comment-17803388 ] Sai Sharath Dandi edited comment on FLINK-33611 at 1/5/24 3:03 AM: ---

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803392#comment-17803392 ] Rui Fan commented on FLINK-33856: - Thanks [~pnowojski] for the ping.:) {quote} [~fanrui] if I remember

[jira] [Updated] (FLINK-33999) FLIP-412: Add the time-consuming span of each stage when starting the Flink job to TraceReporter

2024-01-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33999: Description: This is an umbrella Jira of  [FLIP-412| https://cwiki.apache.org/confluence/x/8435E] >

[jira] [Commented] (FLINK-33319) Add AverageTime metric to measure delta change in GC time

2024-01-04 Thread ouyangwulin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803379#comment-17803379 ] ouyangwulin commented on FLINK-33319: - [~gyfora]  Could you assign this ticket to me? > Add

[jira] [Comment Edited] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803382#comment-17803382 ] Zhongqiang Gong edited comment on FLINK-33970 at 1/5/24 2:48 AM: -

[jira] [Comment Edited] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803382#comment-17803382 ] Zhongqiang Gong edited comment on FLINK-33970 at 1/5/24 2:48 AM: -

[jira] [Comment Edited] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803382#comment-17803382 ] Zhongqiang Gong edited comment on FLINK-33970 at 1/5/24 2:48 AM: -

[jira] [Commented] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2024-01-04 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803389#comment-17803389 ] Sai Sharath Dandi commented on FLINK-33817: --- [~maosuhan] Gentle ping on this. > Allow

Re: [PR] [FLINK-33935][checkpoint] Improve the default value logic related to `execution.checkpointing.tolerable-failed-checkpoints` and `state.backend.type` [flink]

2024-01-04 Thread via GitHub
1996fanrui merged PR #23987: URL: https://github.com/apache/flink/pull/23987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33998) Flink Job Manager restarted after kube-apiserver connection intermittent

2024-01-04 Thread Xiangyan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiangyan updated FLINK-33998: - Description: We are running Flink on AWS EKS and experienced Job Manager restart issue when EKS

Re: [PR] [FLINK-33968][runtime] Advance the calculation of num of subpartitions to the time of initializing execution job vertex [flink]

2024-01-04 Thread via GitHub
zhuzhurk closed pull request #24019: [FLINK-33968][runtime] Advance the calculation of num of subpartitions to the time of initializing execution job vertex URL: https://github.com/apache/flink/pull/24019 -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Comment Edited] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803382#comment-17803382 ] Zhongqiang Gong edited comment on FLINK-33970 at 1/5/24 2:47 AM: -

[jira] [Commented] (FLINK-33935) Improve the default value doc and logic for some state backend and checkpoint related options

2024-01-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803394#comment-17803394 ] Rui Fan commented on FLINK-33935: - Merged to master(1.19) via: 4a852fee28f2d87529dc05f5ba2e79202a0e00b6

[jira] [Resolved] (FLINK-33935) Improve the default value doc and logic for some state backend and checkpoint related options

2024-01-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33935. - Resolution: Fixed > Improve the default value doc and logic for some state backend and checkpoint >

[jira] [Created] (FLINK-33998) Flink Job Manager restarted after kube-apiserver connection intermittent

2024-01-04 Thread Xiangyan (Jira)
Xiangyan created FLINK-33998: Summary: Flink Job Manager restarted after kube-apiserver connection intermittent Key: FLINK-33998 URL: https://issues.apache.org/jira/browse/FLINK-33998 Project: Flink

[jira] [Created] (FLINK-33999) FLIP-412: Add the time-consuming span of each stage when starting the Flink job to TraceReporter

2024-01-04 Thread Rui Fan (Jira)
Rui Fan created FLINK-33999: --- Summary: FLIP-412: Add the time-consuming span of each stage when starting the Flink job to TraceReporter Key: FLINK-33999 URL: https://issues.apache.org/jira/browse/FLINK-33999

[jira] [Updated] (FLINK-33740) Add a document to list the supported sql patterns

2024-01-04 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-33740: --- Summary: Add a document to list the supported sql patterns (was: Introduce a flip to list the supported

[jira] [Assigned] (FLINK-33997) Typo in the doc `classloader.parent-first-patterns-additional`

2024-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-33997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi reassigned FLINK-33997: -- Assignee: Rodrigo Meneses > Typo in the doc

[jira] [Commented] (FLINK-31896) Extend web interface to support failure labels

2024-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803310#comment-17803310 ] David Morávek commented on FLINK-31896: --- master: aba1ee85d6a3854fdb1f8a628fed0ad19460d086 >

[jira] [Resolved] (FLINK-31896) Extend web interface to support failure labels

2024-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek resolved FLINK-31896. --- Fix Version/s: 1.19.0 Resolution: Fixed > Extend web interface to support failure

[jira] [Closed] (FLINK-33968) Compute the number of subpartitions when initializing executon job vertices

2024-01-04 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-33968. --- Fix Version/s: 1.19.0 Resolution: Done master/1.19: b25dfaee80727d6662a5fd445fe51cc139a8b9eb >

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-04 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803382#comment-17803382 ] Zhongqiang Gong commented on FLINK-33970: - [~martijnvisser] [~leonard] Can you give me some

[jira] [Commented] (FLINK-33936) The aggregation of mini-batches should output the result even if the result is the same as before when TTL is configured.

2024-01-04 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803395#comment-17803395 ] xuyang commented on FLINK-33936: Thanks for your report. This bug seems to be that when optimizations

Re: [PR] [FLINK-33980][core] Reorganize job configuration [flink]

2024-01-04 Thread via GitHub
1996fanrui commented on code in PR #24025: URL: https://github.com/apache/flink/pull/24025#discussion_r1442527329 ## flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java: ## @@ -228,6 +229,21 @@ public static List> parseCachedFilesFromSt

[jira] [Updated] (FLINK-32631) FlinkSessionJob stuck in Created/Reconciling state because of No Job found error in JobManager

2024-01-04 Thread Bhupendra Yadav (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bhupendra Yadav updated FLINK-32631: Description: {*}Background{*}: We are using FlinkSessionJob for submitting jobs to a

Re: [PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]

2024-01-04 Thread via GitHub
flinkbot commented on PR #24028: URL: https://github.com/apache/flink/pull/24028#issuecomment-1878101061 ## CI report: * 44ff132411251b97117799a727005c87bc4e7a1d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33936) The aggregation of mini-batches should output the result even if the result is the same as before when TTL is configured.

2024-01-04 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803409#comment-17803409 ] Feng Jin commented on FLINK-33936: -- [~xuyangzhong]  Thank you for your reply, I would like to fix this

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-04 Thread via GitHub
1996fanrui commented on code in PR #22984: URL: https://github.com/apache/flink/pull/22984#discussion_r1442471228 ## flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java: ## @@ -72,9 +72,23 @@ public static RestartStrategyConfiguration

[jira] [Commented] (FLINK-33938) Correct implicit coercions in relational operators to adopt typescript 5.0

2024-01-04 Thread Ao Yuchen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803421#comment-17803421 ] Ao Yuchen commented on FLINK-33938: --- Hi [~Wencong Liu] , I had created a PR to solve this issue, would

[jira] [Commented] (FLINK-33996) Support disabling project rewrite when multiple exprs in the project reference the same sub project field.

2024-01-04 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803426#comment-17803426 ] xuyang commented on FLINK-33996: This is a great idea! When I saw this Jira, another idea popped into my

[jira] [Updated] (FLINK-34000) Implement restore tests for IncrementalGroupAggregate node

2024-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34000: --- Labels: pull-request-available (was: ) > Implement restore tests for

[jira] [Commented] (FLINK-33897) Allow triggering unaligned checkpoint via CLI

2024-01-04 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803407#comment-17803407 ] Zakelly Lan commented on FLINK-33897: - [~pnowojski]  Actually there is real world motivation. When a

Re: [PR] [FLINK-33980][core] Reorganize job configuration [flink]

2024-01-04 Thread via GitHub
JunRuiLee commented on PR #24025: URL: https://github.com/apache/flink/pull/24025#issuecomment-1878160985 > Thanks @JunRuiLee for the contribution! > > [FLINK-33935](https://issues.apache.org/jira/browse/FLINK-33935) improves 2 options related to statebackend and checkpoint. It is

[jira] [Updated] (FLINK-33938) Correct implicit coercions in relational operators to adopt typescript 5.0

2024-01-04 Thread Ao Yuchen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ao Yuchen updated FLINK-33938: -- Fix Version/s: 1.17.3 1.18.2 > Correct implicit coercions in relational operators

[PR] [FLINK-33634] Add Conditions to Flink CRD's Status field [flink-kubernetes-operator]

2024-01-04 Thread via GitHub
lajith2006 opened a new pull request, #749: URL: https://github.com/apache/flink-kubernetes-operator/pull/749 ## What is the purpose of the change This PR is for issue https://issues.apache.org/jira/browse/FLINK-33634 to add Conditions field in the CR status of Flink

[jira] [Updated] (FLINK-33634) Add Conditions to Flink CRD's Status field

2024-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33634: --- Labels: pull-request-available (was: ) > Add Conditions to Flink CRD's Status field >

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row type [flink]

2024-01-04 Thread via GitHub
ukby1234 commented on PR #24029: URL: https://github.com/apache/flink/pull/24029#issuecomment-1878191452 This adds the missing case for https://github.com/apache/flink/pull/23881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (FLINK-34000) Implement restore tests for IncrementalGroupAggregate node

2024-01-04 Thread Bonnie Varghese (Jira)
Bonnie Varghese created FLINK-34000: --- Summary: Implement restore tests for IncrementalGroupAggregate node Key: FLINK-34000 URL: https://issues.apache.org/jira/browse/FLINK-34000 Project: Flink

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row type [flink]

2024-01-04 Thread via GitHub
flinkbot commented on PR #24029: URL: https://github.com/apache/flink/pull/24029#issuecomment-1878195014 ## CI report: * 5e614717b3d19a566939cd2dca8ae414c37f765f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]

2024-01-04 Thread via GitHub
bvarghese1 opened a new pull request, #24028: URL: https://github.com/apache/flink/pull/24028 ## What is the purpose of the change *Add restore tests for IncrementalGroupAggregate node* ## Verifying this change This change added tests and can be verified as follows:

[jira] [Updated] (FLINK-33996) Support disabling project rewrite when multiple exprs in the project reference the same sub project field.

2024-01-04 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-33996: - Summary: Support disabling project rewrite when multiple exprs in the project reference the same sub

[PR] [FLINK-33759] [flink-parquet] Add support for nested array with row type [flink]

2024-01-04 Thread via GitHub
ukby1234 opened a new pull request, #24029: URL: https://github.com/apache/flink/pull/24029 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

Re: [PR] [hotfix][autoscaler] Fix the StandaloneAutoscalerExecutorTest.testScaling fails occasionally due to race condition [flink-kubernetes-operator]

2024-01-04 Thread via GitHub
1996fanrui merged PR #746: URL: https://github.com/apache/flink-kubernetes-operator/pull/746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33414] Fix the unstable test MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot [flink]

2024-01-04 Thread via GitHub
XComp commented on code in PR #23977: URL: https://github.com/apache/flink/pull/23977#discussion_r1441442856 ## flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterITCase.java: ## @@ -127,6 +129,11 @@ private void runHandleJobsWhenNotEnoughSlots(final

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-04 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802610#comment-17802610 ] xuyang commented on FLINK-33490: Hi, [~martijnvisser] and [~fsk119] . Thank you for your correction. As

[jira] [Updated] (FLINK-33009) tools/release/update_japicmp_configuration.sh should only enable binary compatibility checks in the release branch

2024-01-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33009: -- Description: According to [Flink's API compatibility

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441475081 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-25421] Add JdbcSink with new format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
RocMarshal commented on code in PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1441443240 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/sink/JdbcSinkBuilder.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-04 Thread via GitHub
Yang-LI-CS commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1441489844 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -216,15 +216,23 @@ private static double

[jira] [Assigned] (FLINK-33009) tools/release/update_japicmp_configuration.sh should only enable binary compatibility checks in the release branch

2024-01-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-33009: - Assignee: Wencong Liu > tools/release/update_japicmp_configuration.sh should only

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441475081 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441484531 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-33009) tools/release/update_japicmp_configuration.sh should only enable binary compatibility checks in the release branch

2024-01-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802731#comment-17802731 ] Matthias Pohl commented on FLINK-33009: --- Go ahead. I assigned the issue to you. Aside from

Re: [PR] [FLINK-25421] Port JDBC Sink to new Unified Sink API (FLIP-143) [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on code in PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1441520106 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/sink/JdbcSinkBuilder.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33009][release] Disable binary compatibility check in master branch and only enable it in the release branch [flink]

2024-01-04 Thread via GitHub
WencongLiu commented on PR #24027: URL: https://github.com/apache/flink/pull/24027#issuecomment-1876767318 I've tested the modified `update_japicmp_configuration` and it could work well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-25421] Port JDBC Sink to new Unified Sink API (FLIP-143) [flink-connector-jdbc]

2024-01-04 Thread via GitHub
eskabetxe commented on PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1876772728 @RocMarshal thanks for the review.. the 3 commits are there to allow to review each semantic separately (I thing its easy), we could squash all in one after finishing the

  1   2   >