[jira] [Updated] (FLINK-34161) Migrate RewriteMinusAllRule

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34161: --- Labels: pull-request-available (was: ) > Migrate RewriteMinusAllRule >

[PR] [FLINK-34161][table] Migration of RewriteMinusAllRule to java [flink]

2024-01-18 Thread via GitHub
snuyanzin opened a new pull request, #24143: URL: https://github.com/apache/flink/pull/24143 ## What is the purpose of the change The PR migrates `RewriteMinusAllRule` to java it doesn't touch `RewriteMinusAllRuleTest` to be sure that java version continues passing it

[jira] [Created] (FLINK-34161) Migrate RewriteMinusAllRule

2024-01-18 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-34161: --- Summary: Migrate RewriteMinusAllRule Key: FLINK-34161 URL: https://issues.apache.org/jira/browse/FLINK-34161 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-34159][table] Migrate ConstantRankNumberColumnRemoveRule to java [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24141: URL: https://github.com/apache/flink/pull/24141#issuecomment-1899356814 ## CI report: * 24999c75e697568d81bfa4cd1128cb55822c92dd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34160) Migrate FlinkCalcMergeRule

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34160: --- Labels: pull-request-available (was: ) > Migrate FlinkCalcMergeRule >

[PR] [FLINK-34160][table] Migration of FlinkCalcMergeRule to java [flink]

2024-01-18 Thread via GitHub
snuyanzin opened a new pull request, #24142: URL: https://github.com/apache/flink/pull/24142 ## What is the purpose of the change The PR migrates `FlinkCalcMergeRule` to java it doesn't touch `FlinkCalcMergeRuleTest` to be sure that java version continues passing it ##

[jira] [Created] (FLINK-34160) Migrate FlinkCalcMergeRule

2024-01-18 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-34160: --- Summary: Migrate FlinkCalcMergeRule Key: FLINK-34160 URL: https://issues.apache.org/jira/browse/FLINK-34160 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-34159) Migrate ConstantRankNumberColumnRemoveRule

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34159: --- Labels: pull-request-available (was: ) > Migrate ConstantRankNumberColumnRemoveRule >

[PR] [FLINK-34159][table] Migrate ConstantRankNumberColumnRemoveRule to java [flink]

2024-01-18 Thread via GitHub
snuyanzin opened a new pull request, #24141: URL: https://github.com/apache/flink/pull/24141 ## What is the purpose of the change The PR migrates `ConstantRankNumberColumnRemoveRule` to java it doesn't touch `ConstantRankNumberColumnRemoveRuleTest` to be sure that java version

Re: [PR] [FLINK-34158][table] Migrate WindowAggregateReduceFunctionsRule to java [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24140: URL: https://github.com/apache/flink/pull/24140#issuecomment-1899349577 ## CI report: * 43dc43ac4748dfc387fbac363d0ed17ae87adca2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-34159) Migrate ConstantRankNumberColumnRemoveRule

2024-01-18 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-34159: --- Summary: Migrate ConstantRankNumberColumnRemoveRule Key: FLINK-34159 URL: https://issues.apache.org/jira/browse/FLINK-34159 Project: Flink Issue Type:

Re: [PR] [FLINK-34157][table] Migrate FlinkLimit0RemoveRule to java [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24139: URL: https://github.com/apache/flink/pull/24139#issuecomment-1899344007 ## CI report: * 2ed242214e0c649bc28726704a5279a8c73423ad UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34158) Migrate WindowAggregateReduceFunctionsRule

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34158: --- Labels: pull-request-available (was: ) > Migrate WindowAggregateReduceFunctionsRule >

[PR] [FLINK-34158][table] Migrate WindowAggregateReduceFunctionsRule to java [flink]

2024-01-18 Thread via GitHub
snuyanzin opened a new pull request, #24140: URL: https://github.com/apache/flink/pull/24140 ## What is the purpose of the change The PR migrates `WindowAggregateReduceFunctionsRule` to java it doesn't touch `WindowAggregateReduceFunctionsRuleTest` to be sure that java version

[jira] [Created] (FLINK-34158) Migrate WindowAggregateReduceFunctionsRule

2024-01-18 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-34158: --- Summary: Migrate WindowAggregateReduceFunctionsRule Key: FLINK-34158 URL: https://issues.apache.org/jira/browse/FLINK-34158 Project: Flink Issue Type:

[jira] [Updated] (FLINK-34157) Migrate FlinkLimit0RemoveRule

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34157: --- Labels: pull-request-available (was: ) > Migrate FlinkLimit0RemoveRule >

[PR] [FLINK-34157][table] Migrate FlinkLimit0RemoveRule to java [flink]

2024-01-18 Thread via GitHub
snuyanzin opened a new pull request, #24139: URL: https://github.com/apache/flink/pull/24139 ## What is the purpose of the change The PR migrates `FlinkLimit0RemoveRule` to java it doesn't touch `FlinkLimit0RemoveRuleTest` to be sure that java version continues passing it

[jira] [Created] (FLINK-34157) Migrate FlinkLimit0RemoveRule

2024-01-18 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-34157: --- Summary: Migrate FlinkLimit0RemoveRule Key: FLINK-34157 URL: https://issues.apache.org/jira/browse/FLINK-34157 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-34156) Move Flink Calcite rules from Scala to Java

2024-01-18 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-34156: --- Summary: Move Flink Calcite rules from Scala to Java Key: FLINK-34156 URL: https://issues.apache.org/jira/browse/FLINK-34156 Project: Flink Issue

Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle  and sqlserver. [flink-connector-jdbc]

2024-01-18 Thread via GitHub
snuyanzin commented on code in PR #89: URL: https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458044896 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/oracle/dialect/OraclePreparedStatementTest.java: ## @@ -48,10 +48,10 @@

[jira] [Commented] (FLINK-34088) fix the problems with special table name characters of postgres and oracle and sqlserver.

2024-01-18 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808382#comment-17808382 ] Sergey Nuyanzin commented on FLINK-34088: - Doesn't it work if during creation of table we

Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle  and sqlserver. [flink-connector-jdbc]

2024-01-18 Thread via GitHub
snuyanzin commented on code in PR #89: URL: https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458035878 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcUtils.java: ## @@ -168,4 +168,14 @@ public static Row getPrimaryKey(Row

Re: [PR] [FLINK-34128] [bugfix] Some jdbc objects cannot be obtained properly in oracle jdbc,Specify the required type explicitly [flink-connector-jdbc]

2024-01-18 Thread via GitHub
snuyanzin commented on PR #91: URL: https://github.com/apache/flink-connector-jdbc/pull/91#issuecomment-1899307376 Thanks for the contribution could you please add a test case reproducing the original issue and confirming that the PR fixes it? -- This is an automated message from the

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-18 Thread via GitHub
snuyanzin commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1899301322 it is reproducible locally with this command (also assuming that it will be run with jdk17 or jdk21) ``` mvn clean install -Dflink.version=1.19-SNAPSHOT ``` the

[PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]

2024-01-18 Thread via GitHub
snuyanzin opened a new pull request, #93: URL: https://github.com/apache/flink-connector-jdbc/pull/93 The reason is this line

Re: [PR] [FLINK-32893][Connectors/Kafka] Allow the clientid to be fully configurable [flink-connector-kafka]

2024-01-18 Thread via GitHub
bdbene commented on PR #45: URL: https://github.com/apache/flink-connector-kafka/pull/45#issuecomment-1899259190 Oops, fixed that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-32893][Connectors/Kafka] Allow the clientid to be fully configurable [flink-connector-kafka]

2024-01-18 Thread via GitHub
MartijnVisser commented on PR #45: URL: https://github.com/apache/flink-connector-kafka/pull/45#issuecomment-1899246033 @bdbene Please rebase instead of merging, since we can't merge in merge commits -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-32893][Connectors/Kafka] Allow the clientid to be fully configurable [flink-connector-kafka]

2024-01-18 Thread via GitHub
bdbene commented on PR #45: URL: https://github.com/apache/flink-connector-kafka/pull/45#issuecomment-1899234976 Done :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [hotfix] Add test dependency to fix tests in flink-table-planner module [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24138: URL: https://github.com/apache/flink/pull/24138#issuecomment-1899208369 ## CI report: * 1eebd159cb26efee89518f5a91fe096ffbcae32c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-28915] Support fetching artifacts in native K8s and standalone application mode [flink]

2024-01-18 Thread via GitHub
ferenc-csaky commented on PR #24065: URL: https://github.com/apache/flink/pull/24065#issuecomment-1899200720 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [hotfix] Add test dependency to fix tests in flink-table-planner module [flink]

2024-01-18 Thread via GitHub
jnh5y opened a new pull request, #24138: URL: https://github.com/apache/flink/pull/24138 ## What is the purpose of the change Running tests in `flink-table/flink-table-planner` were failing with errors like: ``` at

[jira] [Updated] (FLINK-34155) Recurring SqlExecutionException

2024-01-18 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-34155: --- Priority: Blocker (was: Major) > Recurring SqlExecutionException >

[jira] [Updated] (FLINK-33694) GCS filesystem does not respect gs.storage.root.url config option

2024-01-18 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-33694: -- Release Note: This fix resolves the issue where the `gs.storage.root.url` setting in

Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2024-01-18 Thread via GitHub
afedulov commented on PR #23777: URL: https://github.com/apache/flink/pull/23777#issuecomment-1899072559 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Comment Edited] (FLINK-32940) Support projection pushdown to table source for column projections through UDTF

2024-01-18 Thread Venkata krishnan Sowrirajan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808343#comment-17808343 ] Venkata krishnan Sowrirajan edited comment on FLINK-32940 at 1/18/24 6:49 PM:

[jira] [Commented] (FLINK-32940) Support projection pushdown to table source for column projections through UDTF

2024-01-18 Thread Venkata krishnan Sowrirajan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808343#comment-17808343 ] Venkata krishnan Sowrirajan commented on FLINK-32940: - [~jeyhun] Thanks for the

[jira] [Commented] (FLINK-32514) FLIP-309: Support using larger checkpointing interval when source is processing backlog

2024-01-18 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808342#comment-17808342 ] Mason Chen commented on FLINK-32514: Agreed with Martijn. Thanks for catching this! > FLIP-309:

Re: [PR] [FLINK-34153] Set ALWAYS ChainingStrategy in TemporalSort [flink]

2024-01-18 Thread via GitHub
dawidwys commented on code in PR #24135: URL: https://github.com/apache/flink/pull/24135#discussion_r1457833920 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/BaseTemporalSortOperator.java: ## @@ -38,6 +39,7 @@ abstract class

[jira] [Commented] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-18 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808334#comment-17808334 ] Zhenqiu Huang commented on FLINK-34007: --- [~mapohl] Ack. There are no new observations from last 2

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL (backport to 1.17) [flink]

2024-01-18 Thread via GitHub
XComp merged PR #24124: URL: https://github.com/apache/flink/pull/24124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (FLINK-33694) GCS filesystem does not respect gs.storage.root.url config option

2024-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-33694. --- Fix Version/s: 1.19.0 1.17.3 1.18.2 Assignee:

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL (backport to 1.18) [flink]

2024-01-18 Thread via GitHub
XComp merged PR #24125: URL: https://github.com/apache/flink/pull/24125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL [flink]

2024-01-18 Thread via GitHub
XComp merged PR #23836: URL: https://github.com/apache/flink/pull/23836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL (backport to 1.17) [flink]

2024-01-18 Thread via GitHub
XComp commented on PR #24124: URL: https://github.com/apache/flink/pull/24124#issuecomment-1898902156 I checked the logs. We had disk space issues with runners today (FLINK-34135, FLINK-34098). I suspect that the failures where caused by this (all of it is kind of related to IO issues).

Re: [PR] [FLINK-34153] Set ALWAYS ChainingStrategy in TemporalSort [flink]

2024-01-18 Thread via GitHub
twalthr commented on code in PR #24135: URL: https://github.com/apache/flink/pull/24135#discussion_r1457755400 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sort/BaseTemporalSortOperator.java: ## @@ -38,6 +39,7 @@ abstract class

Re: [PR] [FLINK-34134] Add tracing for restored state size and locations [flink]

2024-01-18 Thread via GitHub
StefanRRichter merged PR #24119: URL: https://github.com/apache/flink/pull/24119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34117][bugfix][table] Fix CompactCoordinator data loss upon termination [flink]

2024-01-18 Thread via GitHub
afedulov commented on PR #24120: URL: https://github.com/apache/flink/pull/24120#issuecomment-1898811602 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2024-01-18 Thread via GitHub
afedulov commented on PR #23777: URL: https://github.com/apache/flink/pull/23777#issuecomment-1898812128 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-18 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1898772077 @libenchao I see there are failing tests, these work for me locally. Do you know how I get access to more details around the test failures so I can debug? -- This is an

[jira] [Created] (FLINK-34155) Recurring SqlExecutionException

2024-01-18 Thread Jeyhun Karimov (Jira)
Jeyhun Karimov created FLINK-34155: -- Summary: Recurring SqlExecutionException Key: FLINK-34155 URL: https://issues.apache.org/jira/browse/FLINK-34155 Project: Flink Issue Type: Bug

Re: [PR] [BP-1.17][FLINK-34150][ci] Enables local file sink e2e tests in general CI setups [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24137: URL: https://github.com/apache/flink/pull/24137#issuecomment-1898764912 ## CI report: * ef52f268a45bc9e0eb0cfa7413b79b29e1c42b90 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.18][FLINK-34150][ci] Enables local file sink e2e tests in general CI setups [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24136: URL: https://github.com/apache/flink/pull/24136#issuecomment-1898762969 ## CI report: * 80a05f9d7bb8d0709ec2b79d941ff2405b68e6ec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34150][ci] Enables local file sink e2e tests in general CI setups [flink]

2024-01-18 Thread via GitHub
XComp opened a new pull request, #24137: URL: https://github.com/apache/flink/pull/24137 1.17 backport PR for parent PR https://github.com/apache/flink/pull/24131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [FLINK-34150][ci] Enables local file sink e2e tests in general CI setups [flink]

2024-01-18 Thread via GitHub
XComp opened a new pull request, #24136: URL: https://github.com/apache/flink/pull/24136 1.18 backport PR for parent PR #24131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33201][Connectors/Kafka] Fix memory leak in CachingTopicSelector [flink-connector-kafka]

2024-01-18 Thread via GitHub
qbx2 commented on PR #55: URL: https://github.com/apache/flink-connector-kafka/pull/55#issuecomment-1898708779 @MartijnVisser Sure, I just rebased it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-32743][Connectors/Kafka] Parse data from kafka connect and convert it into regular JSON data [flink-connector-kafka]

2024-01-18 Thread via GitHub
MartijnVisser commented on PR #42: URL: https://github.com/apache/flink-connector-kafka/pull/42#issuecomment-1898688209 @sunxiaojian Can you please rebase your PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-32893][Connectors/Kafka] Allow the clientid to be fully configurable [flink-connector-kafka]

2024-01-18 Thread via GitHub
MartijnVisser commented on PR #45: URL: https://github.com/apache/flink-connector-kafka/pull/45#issuecomment-1898687229 @bdbene Can you please rebase your PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-30935][connector/kafka] Add kafka serializers version check when using SimpleVersionedSerializer [flink-connector-kafka]

2024-01-18 Thread via GitHub
MartijnVisser commented on PR #10: URL: https://github.com/apache/flink-connector-kafka/pull/10#issuecomment-1898688918 @chucheng92 Can you please rebase your PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-32732][Connectors/Kafka] auto offset reset should be exposed t… [flink-connector-kafka]

2024-01-18 Thread via GitHub
MartijnVisser commented on PR #43: URL: https://github.com/apache/flink-connector-kafka/pull/43#issuecomment-1898687709 @zhougit86 Can you please rebase your PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-34153] Set ALWAYS ChainingStrategy in TemporalSort [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24135: URL: https://github.com/apache/flink/pull/24135#issuecomment-1898687297 ## CI report: * 39c418b0afa579c241dcd14bba166ef146fa0ca6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33201][Connectors/Kafka] Fix memory leak in CachingTopicSelector [flink-connector-kafka]

2024-01-18 Thread via GitHub
MartijnVisser commented on PR #55: URL: https://github.com/apache/flink-connector-kafka/pull/55#issuecomment-1898686809 @qbx2 Can you please rebase your PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-25538][Connectors/Kafka] Migration flink-connector-kafka from junit4 to junit5 [flink-connector-kafka]

2024-01-18 Thread via GitHub
MartijnVisser commented on PR #66: URL: https://github.com/apache/flink-connector-kafka/pull/66#issuecomment-1898684926 @victor09091 Can you please rebase your PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-33466][Connectors/Kafka]: Bounded Kafka source never finishes after restore from savepoint [flink-connector-kafka]

2024-01-18 Thread via GitHub
MartijnVisser commented on PR #71: URL: https://github.com/apache/flink-connector-kafka/pull/71#issuecomment-1898678857 @jwtryg Can you please rebase your PR to trigger CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-34089] Verify that the subscribed topics match the assigned topics [flink-connector-kafka]

2024-01-18 Thread via GitHub
MartijnVisser commented on PR #77: URL: https://github.com/apache/flink-connector-kafka/pull/77#issuecomment-1898677487 > When we unsubscribe a topic and still restore from the old state, the job will still read data from the unsubscribed topic. Isn't this by design? If we would

[jira] [Updated] (FLINK-33692) FlinkKafkaProducer could miss super.close

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33692: --- Labels: pull-request-available (was: ) > FlinkKafkaProducer could miss super.close >

Re: [PR] [FLINK-33692[Connectors/Kafka] FlinkKafkaProducer could miss super.close [flink-connector-kafka]

2024-01-18 Thread via GitHub
MartijnVisser commented on PR #74: URL: https://github.com/apache/flink-connector-kafka/pull/74#issuecomment-1898678239 @ustctozm Please rebase your PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (FLINK-34154) Bump org.apache.zookeeper:zookeeper from 3.5.9 to 3.7.2 for Kafka connector

2024-01-18 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-34154: -- Summary: Bump org.apache.zookeeper:zookeeper from 3.5.9 to 3.7.2 for Kafka connector Key: FLINK-34154 URL: https://issues.apache.org/jira/browse/FLINK-34154

[jira] [Reopened] (FLINK-33958) Implement restore tests for IntervalJoin node

2024-01-18 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reopened FLINK-33958: - Sorry have to reopen since the test introduced within this Jira issue is failing

[PR] [FLINK-34153] Set ALWAYS ChainingStrategy in TemporalSort [flink]

2024-01-18 Thread via GitHub
dawidwys opened a new pull request, #24135: URL: https://github.com/apache/flink/pull/24135 ## What is the purpose of the change This is a minor optimization letting `TemporalSort` operator be chained. ## Verifying this change This change is a trivial rework / code

[jira] [Updated] (FLINK-34153) Set ALWAYS ChainingStrategy in TemporalSort

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34153: --- Labels: pull-request-available (was: ) > Set ALWAYS ChainingStrategy in TemporalSort >

[jira] [Updated] (FLINK-33329) Bump commons-compress to address CVEs

2024-01-18 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-33329: --- Fix Version/s: kafka-3.1.0 > Bump commons-compress to address CVEs >

[jira] [Commented] (FLINK-33329) Bump commons-compress to address CVEs

2024-01-18 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808265#comment-17808265 ] Martijn Visser commented on FLINK-33329: Also fixed for: apache/flink-connector-kafka@main

Re: [PR] [FLINK-33329] Bump org.apache.commons:commons-compress from 1.22 to 1.25.0 [flink-connector-kafka]

2024-01-18 Thread via GitHub
MartijnVisser merged PR #73: URL: https://github.com/apache/flink-connector-kafka/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-27992) cep StreamExecMatch need check the parallelism and maxParallelism of the two transformation in it

2024-01-18 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808263#comment-17808263 ] Martijn Visser commented on FLINK-27992: [~dwysakowicz] Will we also backport to 1.18? Or just

[jira] [Created] (FLINK-34153) Set ALWAYS ChainingStrategy in TemporalSort

2024-01-18 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-34153: Summary: Set ALWAYS ChainingStrategy in TemporalSort Key: FLINK-34153 URL: https://issues.apache.org/jira/browse/FLINK-34153 Project: Flink Issue

[jira] [Commented] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808257#comment-17808257 ] Matthias Pohl commented on FLINK-34007: --- Fair enough. Or we could come up with a Flink-local

Re: [PR] [hotfix] Add should output on WordCountSQLExample [flink]

2024-01-18 Thread via GitHub
caicancai closed pull request #24134: [hotfix] Add should output on WordCountSQLExample URL: https://github.com/apache/flink/pull/24134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34007: -- Priority: Blocker (was: Major) > Flink Job stuck in suspend state after losing leadership in

[jira] [Updated] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34007: -- Affects Version/s: 1.19.0 (was: 1.16.3)

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-18 Thread via GitHub
xuyangzhong commented on code in PR #24068: URL: https://github.com/apache/flink/pull/24068#discussion_r1457550115 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/groupwindow/context/WindowContext.java: ## @@ -0,0 +1,74 @@ +/* +

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-18 Thread via GitHub
xuyangzhong commented on code in PR #24068: URL: https://github.com/apache/flink/pull/24068#discussion_r1457549799 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecWindowTableFunction.java: ## @@ -96,4 +97,16 @@

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-18 Thread via GitHub
xuyangzhong commented on code in PR #24068: URL: https://github.com/apache/flink/pull/24068#discussion_r1457549471 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/groupwindow/context/WindowContext.java: ## @@ -0,0 +1,74 @@ +/* +

[PR] [hotfix] Add should output on WordCountSQLExample [flink]

2024-01-18 Thread via GitHub
caicancai opened a new pull request, #24134: URL: https://github.com/apache/flink/pull/24134 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Commented] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-18 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808252#comment-17808252 ] Gyula Fora commented on FLINK-34007: The fabric8 community is super response and agile so fixing

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-18 Thread via GitHub
Jiabao-Sun commented on PR #23411: URL: https://github.com/apache/flink/pull/23411#issuecomment-1898595368 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-27992) cep StreamExecMatch need check the parallelism and maxParallelism of the two transformation in it

2024-01-18 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-27992. Resolution: Fixed > cep StreamExecMatch need check the parallelism and maxParallelism of

[jira] [Comment Edited] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808237#comment-17808237 ] Matthias Pohl edited comment on FLINK-34007 at 1/18/24 2:30 PM: I

[jira] [Commented] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808237#comment-17808237 ] Matthias Pohl commented on FLINK-34007: --- I checked the implementation (since we're getting close

[jira] [Commented] (FLINK-27992) cep StreamExecMatch need check the parallelism and maxParallelism of the two transformation in it

2024-01-18 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808231#comment-17808231 ] Dawid Wysakowicz commented on FLINK-27992: -- Fixed in 201571b486f405358a31e077247241892d537198

[jira] [Commented] (FLINK-27992) cep StreamExecMatch need check the parallelism and maxParallelism of the two transformation in it

2024-01-18 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808230#comment-17808230 ] Dawid Wysakowicz commented on FLINK-27992: -- Both operators use the same parallelism. Match uses

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1898552816 ## CI report: * ce0c1fb08207d66bb5693b1311bb03d7ba1fda3d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-18 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1898550767 @snuyanzin @libenchao I have put up the changes with the requested unit tests on the filters. Please could you have a look? I can edit the commit message to add you are

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-18 Thread via GitHub
davidradl closed pull request #79: [FLINK-33365] include filters with Lookup joins URL: https://github.com/apache/flink-connector-jdbc/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-34134] Add tracing for restored state size and locations [flink]

2024-01-18 Thread via GitHub
StefanRRichter closed pull request #24119: [FLINK-34134] Add tracing for restored state size and locations URL: https://github.com/apache/flink/pull/24119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (FLINK-33264) Support source parallelism setting for DataGen connector

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33264: --- Labels: pull-request-available (was: ) > Support source parallelism setting for DataGen

[PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-18 Thread via GitHub
X-czh opened a new pull request, #24133: URL: https://github.com/apache/flink/pull/24133 ## What is the purpose of the change Support source parallelism setting for DataGen connector. ## Brief change log - Add SOURCE_PARALLELISM into DataGenConnectorOptions and

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24132: URL: https://github.com/apache/flink/pull/24132#issuecomment-1898519756 ## CI report: * 1193ea4f3deff5b3d7ba7510910fd77059ff46f2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-24544) Failure when using Kafka connector in Table API with Avro and Confluent schema registry

2024-01-18 Thread Anders Dahlen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808215#comment-17808215 ] Anders Dahlen commented on FLINK-24544: --- Are there any plans in play to address this issue soon?

[PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-18 Thread via GitHub
XComp opened a new pull request, #24132: URL: https://github.com/apache/flink/pull/24132 tbd ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Updated] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34007: --- Labels: pull-request-available (was: ) > Flink Job stuck in suspend state after losing

<    1   2   3   4   >