[jira] [Commented] (FLINK-33565) The concurrentExceptions doesn't work

2024-01-23 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809864#comment-17809864 ] Rui Fan commented on FLINK-33565: - Merged to master(1.19.0) via: *

Re: [PR] [FLINK-33565][Scheduler] ConcurrentExceptions works with exception merging [flink]

2024-01-23 Thread via GitHub
1996fanrui merged PR #24003: URL: https://github.com/apache/flink/pull/24003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33565][Scheduler] ConcurrentExceptions works with exception merging [flink]

2024-01-23 Thread via GitHub
1996fanrui commented on PR #24003: URL: https://github.com/apache/flink/pull/24003#issuecomment-1905713145 Thanks @XComp for the patient review and a series of great suggestions again! Merging~ A good experience~ -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-34210][Runtime/Checkpointing] Fix DefaultExecutionGraphBuilder#isCheckpointingEnabled return wrong value when checkpoint disabled [flink]

2024-01-23 Thread via GitHub
flinkbot commented on PR #24173: URL: https://github.com/apache/flink/pull/24173#issuecomment-1905709975 ## CI report: * 065618bbf74973475d26a2d88db25f00aa7b406e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34199) Add tracing for durations of rescaling/restoring RocksDB incremental checkpoints from downloaded and local state

2024-01-23 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-34199: --- Summary: Add tracing for durations of rescaling/restoring RocksDB incremental checkpoints

Re: [PR] [FLINK-34104][autoscaler] Improve the ScalingReport format of autoscaling [flink-kubernetes-operator]

2024-01-23 Thread via GitHub
1996fanrui commented on code in PR #757: URL: https://github.com/apache/flink-kubernetes-operator/pull/757#discussion_r1463020446 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoscalerEventUtils.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-23 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809858#comment-17809858 ] Yang Wang commented on FLINK-34007: --- It seems that the fabric8 K8s client community leans towards to

[jira] [Updated] (FLINK-34210) DefaultExecutionGraphBuilder#isCheckpointingEnabled may return Wrong Value when checkpoint disabled

2024-01-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34210: --- Labels: pull-request-available (was: ) >

[jira] [Commented] (FLINK-34211) Filtering on Column names with ?s fails for JDBC lookup join.

2024-01-23 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809857#comment-17809857 ] david radley commented on FLINK-34211: -- fyi JDBC lookup Filters are ignored until the fix for

[PR] [FLINK-34210][Runtime/Checkpointing] Fix DefaultExecutionGraphBuilder#isCheckpointingEnabled return wrong value when checkpoint disabled [flink]

2024-01-23 Thread via GitHub
mayuehappy opened a new pull request, #24173: URL: https://github.com/apache/flink/pull/24173 …#isCheckpointingEnabled return wrong value when checkpoint disabled ## What is the purpose of the change Fix DefaultExecutionGraphBuilder#isCheckpointingEnabled return wrong

Re: [PR] [FLINK-34199] Add tracing for durations of rescaling/restoring from local state [flink]

2024-01-23 Thread via GitHub
StefanRRichter commented on PR #24168: URL: https://github.com/apache/flink/pull/24168#issuecomment-1905684111 I wrote the docs slightly different, hope that makes it clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-34199] Add tracing for durations of rescaling/restoring from local state [flink]

2024-01-23 Thread via GitHub
rkhachatryan commented on PR #24168: URL: https://github.com/apache/flink/pull/24168#issuecomment-1905682546 Right :sweat_smile: Then I guess the only confusion for me is about "local" in names and docs: remote state that is downloaded can be called "local", but it's pure implementation

[jira] [Created] (FLINK-34211) Filtering on Column names with ?s fails for JDBC lookup join.

2024-01-23 Thread david radley (Jira)
david radley created FLINK-34211: Summary: Filtering on Column names with ?s fails for JDBC lookup join. Key: FLINK-34211 URL: https://issues.apache.org/jira/browse/FLINK-34211 Project: Flink

[jira] [Created] (FLINK-34210) DefaultExecutionGraphBuilder#isCheckpointingEnabled may return Wrong Value when checkpoint disabled

2024-01-23 Thread Yue Ma (Jira)
Yue Ma created FLINK-34210: -- Summary: DefaultExecutionGraphBuilder#isCheckpointingEnabled may return Wrong Value when checkpoint disabled Key: FLINK-34210 URL: https://issues.apache.org/jira/browse/FLINK-34210

Re: [PR] [FLINK-34055][table] Introduce a new annotation for named parameters [flink]

2024-01-23 Thread via GitHub
xuyangzhong commented on PR #24106: URL: https://github.com/apache/flink/pull/24106#issuecomment-1905675166 cc @fsk119 for the double check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-34055][table] Introduce a new annotation for named parameters [flink]

2024-01-23 Thread via GitHub
xuyangzhong commented on code in PR #24106: URL: https://github.com/apache/flink/pull/24106#discussion_r1462969824 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/extraction/TypeInferenceExtractorTest.java: ## @@ -535,7 +535,43 @@ private static

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-23 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905665607 > @davidradl > > > * I don't think we can have 0 key names for a lookup join. Have you a test case that would drive this ? > > There is no such restriction in

[jira] [Commented] (FLINK-33842) Publish the Dockerfiles for the new release

2024-01-23 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809850#comment-17809850 ] Jing Ge commented on FLINK-33842: - official-image PR:

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-23 Thread via GitHub
libenchao commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905659276 @davidradl > * I don't think we can have 0 key names for a lookup join. Have you a test case that would drive this ? There is no such restriction in semantic

[jira] [Resolved] (FLINK-34165) It seems that Apache download link has been changed

2024-01-23 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-34165. - Resolution: Fixed > It seems that Apache download link has been changed >

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-23 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905644311 > > @libenchao @snuyanzin I have updated the code in line with your feedback - please could you review again. Many thanks > > @davidradl One small suggestion, please do

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-23 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905641356 > @davidradl @snuyanzin I reviewed, and added a few cosmetic changes in

[jira] [Commented] (FLINK-26760) The new CSV source (file system source + CSV format) does not support reading files whose file encoding is not UTF-8

2024-01-23 Thread Yao Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809842#comment-17809842 ] Yao Zhang commented on FLINK-26760: --- Hi community, The encoding issue could be solved by updating

[jira] [Updated] (FLINK-33287) Using the flink shaded jackson for flink-autoscaler

2024-01-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33287: --- Labels: pull-request-available (was: ) > Using the flink shaded jackson for

[PR] [FLINK-33287] Using the flink shaded jackson for flink-autoscaler [flink-kubernetes-operator]

2024-01-23 Thread via GitHub
1996fanrui opened a new pull request, #761: URL: https://github.com/apache/flink-kubernetes-operator/pull/761 ## What is the purpose of the change [FLINK-33098](https://issues.apache.org/jira/browse/FLINK-33098) still using the jackson version of flink-kubernetes-operator instead of

Re: [PR] [FLINK-33565][Scheduler] ConcurrentExceptions works with exception merging [flink]

2024-01-23 Thread via GitHub
XComp commented on PR #24003: URL: https://github.com/apache/flink/pull/24003#issuecomment-1905623368 ok, fine with me :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34165] update the apache download url [flink-docker]

2024-01-23 Thread via GitHub
JingGe merged PR #176: URL: https://github.com/apache/flink-docker/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-34195) PythonEnvUtils creates python environment instead of python3

2024-01-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809827#comment-17809827 ] Matthias Pohl commented on FLINK-34195: --- I see - thanks for the clarification. :) Having the

[jira] [Commented] (FLINK-34195) PythonEnvUtils creates python environment instead of python3

2024-01-23 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809826#comment-17809826 ] Xingbo Huang commented on FLINK-34195: -- [~mapohl] Thanks for the great work. Since the second

[jira] [Resolved] (FLINK-33403) Bump flink version to 1.18.1 for flink-kubernetes-operator

2024-01-23 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33403. - Fix Version/s: kubernetes-operator-1.8.0 Resolution: Fixed > Bump flink version to 1.18.1 for

[jira] [Commented] (FLINK-33403) Bump flink version to 1.18.1 for flink-kubernetes-operator

2024-01-23 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809821#comment-17809821 ] Rui Fan commented on FLINK-33403: - Merged to main(1.8.0) via : 72231cf1e577b9d8d5ea2dbfdade277a368b315d

Re: [PR] [FLINK-34199] Add tracing for durations of rescaling/restoring from local state [flink]

2024-01-23 Thread via GitHub
StefanRRichter commented on PR #24168: URL: https://github.com/apache/flink/pull/24168#issuecomment-1905595304 Besides that, I already merged a PR that measures local/remote state sizes. And in our meeting we found that all of the metrics are useful :) -- This is an automated message

Re: [PR] [FLINK-34199] Add tracing for durations of rescaling/restoring from local state [flink]

2024-01-23 Thread via GitHub
StefanRRichter commented on PR #24168: URL: https://github.com/apache/flink/pull/24168#issuecomment-1905591517 I think the description is correct, depending on you point of view. Recovery today has two phases: 1. If there is any remote state it will be downloaded and becomes local

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-23 Thread via GitHub
lsyldliu commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462860096 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/unslicing/UnsliceAssigners.java: ## @@ -0,0 +1,142 @@ +/* + *

Re: [PR] [FLINK-33233][hive] Fix NPE when non-native udf is used in join condition with Hive dialect, back port to 1.18 [flink]

2024-01-23 Thread via GitHub
yunfan123 commented on PR #24149: URL: https://github.com/apache/flink/pull/24149#issuecomment-1905574397 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (FLINK-34144) Update the documentation and configuration description about dynamic source parallelism inference

2024-01-23 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-34144: --- Assignee: xingbe > Update the documentation and configuration description about dynamic source >

[jira] [Assigned] (FLINK-34059) Add documentation on how to use state TTL hint

2024-01-23 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-34059: - Assignee: Jane Chan > Add documentation on how to use state TTL hint >

[jira] [Assigned] (FLINK-34145) File source connector support dynamic source parallelism inference in batch jobs

2024-01-23 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-34145: --- Assignee: xingbe > File source connector support dynamic source parallelism inference in batch >

Re: [PR] [FLINK-23687][table-planner] Introduce partitioned lookup join to enforce input of LookupJoin to hash shuffle by lookup keys [flink]

2024-01-23 Thread via GitHub
yunfan123 commented on PR #24104: URL: https://github.com/apache/flink/pull/24104#issuecomment-1905561284 Hello @LB-Yu . I have implemented the feature as described in flip204 using query hints and have rebased onto the latest master branch. Additionally, this PR involves significant

[jira] [Created] (FLINK-34209) Migrate FileSink to the new SinkV2 API

2024-01-23 Thread Peter Vary (Jira)
Peter Vary created FLINK-34209: -- Summary: Migrate FileSink to the new SinkV2 API Key: FLINK-34209 URL: https://issues.apache.org/jira/browse/FLINK-34209 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-34208) Migrate SinkV1Adapter to the new SinkV2 API

2024-01-23 Thread Peter Vary (Jira)
Peter Vary created FLINK-34208: -- Summary: Migrate SinkV1Adapter to the new SinkV2 API Key: FLINK-34208 URL: https://issues.apache.org/jira/browse/FLINK-34208 Project: Flink Issue Type: Sub-task

[jira] [Comment Edited] (FLINK-34148) Potential regression (Jan. 13): stringWrite with Java8

2024-01-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809796#comment-17809796 ] Sergey Nuyanzin edited comment on FLINK-34148 at 1/23/24 8:28 AM: -- An

[jira] [Commented] (FLINK-32609) Kafka table source supports projection push down

2024-01-23 Thread SuDewei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809803#comment-17809803 ] SuDewei commented on FLINK-32609: - [~lsy] Hi dalong, do you have time to continue this work? If not, I’m

[jira] [Closed] (FLINK-33975) Tests for the new Sink V2 transformations

2024-01-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33975. -- Fix Version/s: 1.19.0 Resolution: Fixed merged to master

Re: [PR] [FLINK-33975] Tests for the new Sink V2 transformations [flink]

2024-01-23 Thread via GitHub
gyfora merged PR #24153: URL: https://github.com/apache/flink/pull/24153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-34148) Potential regression (Jan. 13): stringWrite with Java8

2024-01-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809796#comment-17809796 ] Sergey Nuyanzin commented on FLINK-34148: - An interesting finding: 1. jackson 2.15.x requires

<    1   2   3