[PR] [WIP][FLINK-34977][API] Reorganize classes between core and core-api modules [flink]

2024-04-25 Thread via GitHub
jeyhunkarimov opened a new pull request, #24725: URL: https://github.com/apache/flink/pull/24725 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Updated] (FLINK-34977) FLIP-433: State Access on DataStream API V2

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34977: --- Labels: pull-request-available (was: ) > FLIP-433: State Access on DataStream API V2 >

Re: [PR] [FLINK-34915][table] Complete `DESCRIBE CATALOG` syntax [flink]

2024-04-25 Thread via GitHub
liyubin117 commented on code in PR #24630: URL: https://github.com/apache/flink/pull/24630#discussion_r1580314751 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/DescribeCatalogOperation.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34915][table] Complete `DESCRIBE CATALOG` syntax [flink]

2024-04-25 Thread via GitHub
liyubin117 commented on code in PR #24630: URL: https://github.com/apache/flink/pull/24630#discussion_r1580315151 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/DescribeCatalogOperation.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the

Re: [PR] [DOC] When type is number,update doc [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1801: URL: https://github.com/apache/flink-cdc/pull/1801#issuecomment-2078495726 Thanks for your contribution! Could you please rebase it with latest `master` branch? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-35189][testing/test-filesystem]Introduce test-filesystem Catalog based on FileSystem Connector to support materialized table [flink]

2024-04-25 Thread via GitHub
lsyldliu commented on code in PR #24712: URL: https://github.com/apache/flink/pull/24712#discussion_r1580355919 ## flink-test-utils-parent/flink-table-filesystem-test-utils/src/main/java/org/apache/flink/table/file/testutils/catalog/TestFileSystemCatalog.java: ## @@ -0,0 +1,687

Re: [PR] [FLINK-35190][table] Support create materialized table syntax [flink]

2024-04-25 Thread via GitHub
lsyldliu commented on PR #24707: URL: https://github.com/apache/flink/pull/24707#issuecomment-2078505570 Sorry for forget to approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Fix a Bug] add supported for Oracle CDB mode at OracleIncrementalSource [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1836: URL: https://github.com/apache/flink-cdc/pull/1836#issuecomment-2078507662 Thanks for your contribution! Before this PR could be merged, could you please rebase it with latest `master` branch? -- This is an automated message from the Apache Git Service. To

Re: [PR] [mysql-cdc] Fix the hung up of snapshot phase when reuse binaryLogClient [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1915: URL: https://github.com/apache/flink-cdc/pull/1915#issuecomment-2078533983 Hi @lzshlzsh, thanks for your contribution! Before this PR could be merged, could you please rebase it with latest `master` branch? cc @leonardBang @PatrickRen -- This is an

Re: [PR] [FLINK-35236] [chinese-translation] Modify Translation error on the execution_mode/order-of-processing [flink]

2024-04-25 Thread via GitHub
flinkbot commented on PR #24726: URL: https://github.com/apache/flink/pull/24726#issuecomment-2078558449 ## CI report: * dd67144505817b8dab1b337b2284427812542324 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [Improve][code style]Format some idea tips [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2358: URL: https://github.com/apache/flink-cdc/pull/2358#issuecomment-2078577626 Hi @liugddx, there's been a lot of changes since your original commit. Could you please rebase this PR with latest `master` branch before it could be merged? Thanks! -- This is an

Re: [PR] Fix an exception:java.lang.NoClassDefFoundError: [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2501: URL: https://github.com/apache/flink-cdc/pull/2501#issuecomment-2078589126 Thanks for @ariesy's contribution! Could you please rebase this PR with latest `master` branch? You may want to patch the `pom.xml` file in

Re: [PR] [oracle] Support partitioned table [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2479: URL: https://github.com/apache/flink-cdc/pull/2479#issuecomment-2078631669 Hi @lvyanquan, could you please rebase this PR with `master` branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Refactoring code. [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2755: URL: https://github.com/apache/flink-cdc/pull/2755#issuecomment-2078659089 Hi @parthcri1997, could you please rebase this PR with latest `master` branch and run `mvn spotless:apply` to fix checkstyle violations? -- This is an automated message from the

Re: [PR] [db] When modifying the time zone connection parameters in the datab… [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2787: URL: https://github.com/apache/flink-cdc/pull/2787#issuecomment-2078660878 Hi @lizhongze1 Could you please rebase this PR with latest `master` branch? cc @loserwang1024 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [mysql-cdc] Add upsert changelog mode to avoid UPDATE_BEFORE records … [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on code in PR #1907: URL: https://github.com/apache/flink-cdc/pull/1907#discussion_r1580510172 ## flink-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactory.java: ## Review Comment: Is this file content

[jira] [Commented] (FLINK-35190) Support create materialized table syntax

2024-04-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841018#comment-17841018 ] dalongliu commented on FLINK-35190: --- Merged in master: 512f3fbaac8b538f7edda152af0846dc2b213557 >

[jira] [Resolved] (FLINK-35190) Support create materialized table syntax

2024-04-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu resolved FLINK-35190. --- Resolution: Fixed > Support create materialized table syntax >

Re: [PR] [FLINK-35190][table] Support create materialized table syntax [flink]

2024-04-25 Thread via GitHub
lsyldliu closed pull request #24707: [FLINK-35190][table] Support create materialized table syntax URL: https://github.com/apache/flink/pull/24707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (FLINK-35178) Checkpoint CLAIM mode does not fully control snapshot ownership

2024-04-25 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841029#comment-17841029 ] Yanfei Lei commented on FLINK-35178: [~elon]  > the result was the same?   Does it mean that

Re: [PR] [postgresql] Fix debezium-postgresql data loss [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1895: URL: https://github.com/apache/flink-cdc/pull/1895#issuecomment-2078529182 Thanks for your contribution! Before this PR could be merged, could you please rebase it with latest `master` branch? cc @leonardBang -- This is an automated message from the

Re: [PR] [mysql-cdc] Fix MySqlSplitSerializer ConcurrentModificationException [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1945: URL: https://github.com/apache/flink-cdc/pull/1945#issuecomment-2078536816 @ruanhang1993 Could you please rebase this PR with latest `master` branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [tidb]fix the tidb checkpoints to exactly once. [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2038: URL: https://github.com/apache/flink-cdc/pull/2038#issuecomment-2078546586 Thanks @ArainChen for the great work! Before this PR could be merged, could you please rebase it with latest `master` branch? -- This is an automated message from the Apache Git

Re: [PR] [hotfix] Modify the schema and table name snapshot data reading probl… [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2266: URL: https://github.com/apache/flink-cdc/pull/2266#issuecomment-2078557650 Hi @code-dm, thanks for your contribution! Could you please rebase this PR with latest `master` branch before it could be merged? -- This is an automated message from the Apache Git

Re: [PR] [Mysql] Mysql connector can't handle the case sensitive of rename/change column statement (#2144) [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2257: URL: https://github.com/apache/flink-cdc/pull/2257#issuecomment-2078556727 Hi @dua01, thanks for you contribution! Could you please rebase this PR with latest `master` branch before it could be merged? Also please describe this as a temporary workaround in

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-25 Thread Rob Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841035#comment-17841035 ] Rob Young commented on FLINK-35240: --- Hi, I've been looking into this. 1.

[jira] (FLINK-35236) Flink 1.19 Translation error on the execution_mode/order-of-processing

2024-04-25 Thread hongxu han (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35236 ] hongxu han deleted comment on FLINK-35236: was (Author: maomao): [~Weijie Guo] I would like to filing a PR to fix this. This is my first PR,If there are any non-standard formats, I am

Re: [PR] [BP-3.1][FLINK-35128][cdc-connector][cdc-base] Re-calculate the starting changelog offset after the new table added (#3230) [flink-cdc]

2024-04-25 Thread via GitHub
PatrickRen merged PR #3257: URL: https://github.com/apache/flink-cdc/pull/3257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (FLINK-35128) Re-calculate the starting change log offset after the new table added

2024-04-25 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-35128. --- Fix Version/s: cdc-3.1.0 (was: 3.1.0) Resolution: Fixed >

[jira] [Comment Edited] (FLINK-35128) Re-calculate the starting change log offset after the new table added

2024-04-25 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840657#comment-17840657 ] Qingsheng Ren edited comment on FLINK-35128 at 4/26/24 3:30 AM:

Re: [PR] [jdbc] support read snapshot only [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2338: URL: https://github.com/apache/flink-cdc/pull/2338#issuecomment-2078569056 Thanks for your contribution! Closing this since it has been addressed in #2901. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [BP-3.1][FLINK-34639][cdc][oceanbase] Support debezium deserializer in OceanBase source connector [flink-cdc]

2024-04-25 Thread via GitHub
PatrickRen merged PR #3259: URL: https://github.com/apache/flink-cdc/pull/3259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [WIP][debezium] Bump debezium version to 2.3.1.Final [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2361: URL: https://github.com/apache/flink-cdc/pull/2361#issuecomment-2078580496 Hi @liugddx, seems Debezium 2.x requires JDK 11+, however currently Flink CDC needs to support Java 8. As Flink 1.20 still keeps Java 8 compatibility, we can't drop support for legacy

Re: [PR] [WIP][mysql] Add ExternalSystemListener to notify user about the status of connector. [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2523: URL: https://github.com/apache/flink-cdc/pull/2523#issuecomment-2078636920 Is there any progress on this PR? cc @lvyanquan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-34689][MySQL][Feature] check binlog_row_value_options [flink-cdc]

2024-04-25 Thread via GitHub
SML0127 commented on code in PR #3148: URL: https://github.com/apache/flink-cdc/pull/3148#discussion_r1560428551 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/MySqlValidator.java: ## @@ -50,6 +50,7

Re: [PR] [hotfix] [base] Fix the serialization error occurring with table names containing dot [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2705: URL: https://github.com/apache/flink-cdc/pull/2705#issuecomment-2078655679 Hi @edmond-kk, could you please rebase this PR with latest `master` branch before it could be merged? Thanks for your contribution! -- This is an automated message from the Apache

Re: [PR] [cdc-composer][tests] Refactor newline handling for cross-platform compatibility [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2896: URL: https://github.com/apache/flink-cdc/pull/2896#issuecomment-2078669536 Thanks for @Cqz666's contribution, could you please rebase this PR with latest `master` branch before it could be merged? -- This is an automated message from the Apache Git

Re: [PR] [FLINK-35236] [chinese-translation] Modify Translation error on the execution_mode/order-of-processing [flink]

2024-04-25 Thread via GitHub
reswqa commented on code in PR #24720: URL: https://github.com/apache/flink/pull/24720#discussion_r1580351228 ## docs/content.zh/docs/dev/datastream/execution_mode.md: ## @@ -154,7 +154,7 @@ TaskManagers 将至少在下游任务开始消费它们前保留中间结果( - _广播输入(broadcast input)_: 从广播流输入(参见

[jira] [Updated] (FLINK-35049) Implement List/Map Async State API for ForStStateBackend

2024-04-25 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu updated FLINK-35049: - Summary: Implement List/Map Async State API for ForStStateBackend (was: Implement Async State

Re: [PR] fix bug 'mysql primary key of binary data type is compared incorrectly' [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1816: URL: https://github.com/apache/flink-cdc/pull/1816#issuecomment-2078500622 Hi @stgztsw, thanks for your contribution! Before we can merge this PR, could you please rebase it with the latest `master` branch? You may need to move `com.ververica.cdc.connectors`

Re: [PR] [cdc-base] Support `Scan Newly Added Tables` feature [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1838: URL: https://github.com/apache/flink-cdc/pull/1838#issuecomment-2078510778 Closing this PR since this feature has been implemented in #3024. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Update OracleSourceBuilder's constructor to private [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2327: URL: https://github.com/apache/flink-cdc/pull/2327#issuecomment-2078563743 Thanks @zhaomin1423 for the great work! Before this PR could be merged, could you please rebase it with latest `master` branch? -- This is an automated message from the Apache Git

Re: [PR] [Bug][Oracle] oracle 单表全量阶段根据ROWID 字段 split chunk存在BUG [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2339: URL: https://github.com/apache/flink-cdc/pull/2339#issuecomment-2078573012 Hi @zhaomin1423, could you please rebase with latest `master` branch before further actions? Thanks for your contribution! -- This is an automated message from the Apache Git

Re: [PR] [FLINK-35026][runtime][config] Introduce async execution configurations [flink]

2024-04-25 Thread via GitHub
fredia commented on PR #24667: URL: https://github.com/apache/flink/pull/24667#issuecomment-2078637067 @Zakelly Thanks for the review, I addressed the comments and rebased to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [mysql] Add custom configurations for ConnectionPool which starts with `hikari.` [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2512: URL: https://github.com/apache/flink-cdc/pull/2512#issuecomment-2078635982 Could you please rebase this PR with `master` branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [postgres] Remove unnecessary schema fresh to improve performance. [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2571: URL: https://github.com/apache/flink-cdc/pull/2571#issuecomment-2078639402 Hi @lzshlzsh, could you please rebase this PR with latest `master` branch before it could be merged? Also cc @loserwang1024 -- This is an automated message from the Apache

Re: [PR] [mysql] Error message more cautious [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2880: URL: https://github.com/apache/flink-cdc/pull/2880#issuecomment-2078667944 Hi @baxinyu, could you please rebase this PR with latest `master` branch before it could be merged? Thank you! -- This is an automated message from the Apache Git Service. To

[jira] [Resolved] (FLINK-35125) Implement ValueState for ForStStateBackend

2024-04-25 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-35125. -- Fix Version/s: 1.20.0 (was: 2.0.0) Resolution: Fixed merged

[jira] [Resolved] (FLINK-35162) Support grouping state get and put access

2024-04-25 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-35162. -- Fix Version/s: 1.20.0 Assignee: Jinzhong Li Resolution: Fixed merged 1c4eb914

Re: [PR] [FLINK-35176][Connector/JDBC] Support property authentication connection for JDBC catalog & dynamic table [flink-connector-jdbc]

2024-04-25 Thread via GitHub
caicancai commented on code in PR #116: URL: https://github.com/apache/flink-connector-jdbc/pull/116#discussion_r1580352031 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java: ## @@ -77,17 +81,42 @@ public JdbcCatalog(

Re: [PR] [cdc][base]Support dynamically table addition in flink-cdc-base [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1877: URL: https://github.com/apache/flink-cdc/pull/1877#issuecomment-2078520313 Closing this PR since this feature has been implemented by #3024. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-35189) Introduce test-filesystem Catalog based on FileSystem Connector to support materialized table

2024-04-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-35189: -- Component/s: Connectors / FileSystem > Introduce test-filesystem Catalog based on FileSystem

Re: [PR] [tidb] Add metrics for tidb connector [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1974: URL: https://github.com/apache/flink-cdc/pull/1974#issuecomment-2078542556 Thanks @xieyi888 for the great work! Before this PR could be merged, could you please rebase it with latest `master` branch? -- This is an automated message from the Apache Git

Re: [PR] [oracle-cdc]Optimized slow oracle real-time synchronization [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2009: URL: https://github.com/apache/flink-cdc/pull/2009#issuecomment-2078543458 Thanks @weAreFriendYo for the great work! Before this PR could be merged, could you please rebase it with latest `master` branch? -- This is an automated message from the Apache Git

[PR] [FLINK-35236] [chinese-translation] Modify Translation error on the e… [flink]

2024-04-25 Thread via GitHub
maomao931228 opened a new pull request, #24726: URL: https://github.com/apache/flink/pull/24726 I'm glad to be here for the first time to open a pull request 'Modify Translation error on the execution_mode/order-of-processing'.

Re: [PR] [Oracle]修复oracle数据库表主键是NUMBER类型且不指定p,s长度时报校验异常:org.apache.flink.table.api.Val… [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2304: URL: https://github.com/apache/flink-cdc/pull/2304#issuecomment-2078563215 Could you please also rebase this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [Oracle]修复oracle数据库scan.incremental.snapshot.chunk.key-column设置不生效的问题 [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2298: URL: https://github.com/apache/flink-cdc/pull/2298#issuecomment-2078562138 Hi @nidonglin, thanks for your contribution! Could you please rebase this PR with latest `master` branch? -- This is an automated message from the Apache Git Service. To respond to

[jira] [Comment Edited] (FLINK-34639) Flink CDC: Support DebeziumDeserializationSchema in OceanBase source connector

2024-04-25 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840683#comment-17840683 ] Qingsheng Ren edited comment on FLINK-34639 at 4/26/24 3:32 AM:

Re: [PR] [mongodb] Add lookup option to IncrementalSource for mongodb [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2686: URL: https://github.com/apache/flink-cdc/pull/2686#issuecomment-2078591185 Hi @vanliu-tx, thanks for your contribution! Could you please rebase this PR with latest `master` branch? You may need to rename some packages from `com.ververica.cdc` to

Re: [PR] Release 2.4 [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2597: URL: https://github.com/apache/flink-cdc/pull/2597#issuecomment-2078589995 Closing this PR since it has been outdated. Please reopen a PR for this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-35026][runtime][config] Introduce async execution configurations [flink]

2024-04-25 Thread via GitHub
Zakelly commented on code in PR #24667: URL: https://github.com/apache/flink/pull/24667#discussion_r1580464018 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -94,26 +97,38 @@ public class AsyncExecutionController {

Re: [PR] [mysql-cdc] Current binlog offset add serverId, fix incremental-snapshot scan data lose [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2808: URL: https://github.com/apache/flink-cdc/pull/2808#issuecomment-2078661660 Hi @EchoLee5, could you please rebase this PR with latest `master` branch before it could be merged? cc @ruanhang1993 -- This is an automated message from the Apache Git

Re: [PR] [FLINK-35047][state] Support ForStStateBackend and ForStKeyedStateBackend [flink]

2024-04-25 Thread via GitHub
masteryhx closed pull request #24682: [FLINK-35047][state] Support ForStStateBackend and ForStKeyedStateBackend URL: https://github.com/apache/flink/pull/24682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-34127] Upgrade to flink-connector-parent 1.1.0 to exclude runn… [flink-connector-kafka]

2024-04-25 Thread via GitHub
mas-chen commented on PR #98: URL: https://github.com/apache/flink-connector-kafka/pull/98#issuecomment-2078508305 This shaves 1-2 minutes from CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (FLINK-34127) Kafka connector repo runs a duplicate of `IntegrationTests` framework tests

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34127: --- Labels: pull-request-available (was: ) > Kafka connector repo runs a duplicate of

Re: [PR] [mysql][Improvement] Use debezium SPI way converter data types output. [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1882: URL: https://github.com/apache/flink-cdc/pull/1882#issuecomment-2078522702 Thanks for your contribution! Before this PR could be merged, could you please rebase it with latest `master` branch? -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix DynamicKafkaSourceEnumerator removed topics state cleanup [flink-connector-kafka]

2024-04-25 Thread via GitHub
mas-chen commented on PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#issuecomment-2078522854 Thanks for explaining, I missed that! Rerunning CI, the PR LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-35236] [chinese-translation] Modify Translation error on the execution_mode/order-of-processing [flink]

2024-04-25 Thread via GitHub
maomao931228 commented on PR #24720: URL: https://github.com/apache/flink/pull/24720#issuecomment-2078537546 > Thanks for the fix. I just left a minor comment, please take a look. > > BTW, could you please squash all commits to one: `[FLINK-35236][docs] Fix incorrect translation on

[jira] [Resolved] (FLINK-34639) Flink CDC: Support DebeziumDeserializationSchema in OceanBase source connector

2024-04-25 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-34639. --- Resolution: Fixed > Flink CDC: Support DebeziumDeserializationSchema in OceanBase source

Re: [PR] [base][minor] Code Cleanup, remove redundant code [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2581: URL: https://github.com/apache/flink-cdc/pull/2581#issuecomment-2078596504 Thanks @wuzhenhua01 for the contribution, would you mind open a new PR based on latest `master` branch, as the code base has changed greatly since then? cc @loserwang1024 --

Re: [PR] [FLINK-32706][table] Add built-in SPLIT_STRING function [flink]

2024-04-25 Thread via GitHub
hanyuzheng7 commented on code in PR #24365: URL: https://github.com/apache/flink/pull/24365#discussion_r1580488725 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -409,6 +409,18 @@ ANY,

Re: [PR] [pipeline-connector][doris] Extract type mapping logic [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2848: URL: https://github.com/apache/flink-cdc/pull/2848#issuecomment-2078665245 Thanks @JNSimba for the great work, could you please rebase this PR with latest `master` branch before it could be merged? -- This is an automated message from the Apache Git

[jira] [Resolved] (FLINK-35047) Introduce ForStStateBackend to manage ForSt

2024-04-25 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-35047. -- Fix Version/s: 1.20.0 Resolution: Fixed merged 629c3571...19577b0d into master. >

Re: [PR] [oceanBase] add metrics for oceanbase cdc connector [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1863: URL: https://github.com/apache/flink-cdc/pull/1863#issuecomment-2078515594 Thanks @LXin96 for the great work! Before this PR could be merged, could you please rebase it with latest `master` branch? `com.ververica.cdc.connectors` have been renamed to

Re: [PR] [build] Add maven wrapper [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1876: URL: https://github.com/apache/flink-cdc/pull/1876#issuecomment-2078518760 Thanks for your contribution! Could you please rebase this PR with latest `master` branch, and update maven wrapper properties to align with [Flink

Re: [PR] [mysql-cdc] Add upsert changelog mode to avoid UPDATE_BEFORE records … [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1907: URL: https://github.com/apache/flink-cdc/pull/1907#issuecomment-2078533192 Hi @yeezychao, thanks for your great contribution! Before this PR could be merged, could you please rebase it with latest `master` branch? -- This is an automated message from the

Re: [PR] [Bug][issues-2187] if splitTable method execute fast than getNext, job will be blocked [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2188: URL: https://github.com/apache/flink-cdc/pull/2188#issuecomment-2078554200 Hi @y0908105023, could you please rebase this PR with latest `master` branch before it could be merged? Thanks! -- This is an automated message from the Apache Git Service. To

Re: [PR] Add tables.exclude.list option [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2271: URL: https://github.com/apache/flink-cdc/pull/2271#issuecomment-2078559293 Thanks for your contribution! Closing this PR as resolved in #3186. Feel free to reopen this if you have any concerns. -- This is an automated message from the Apache Git Service.

Re: [PR] Support split snapshot asynchronously [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2329: URL: https://github.com/apache/flink-cdc/pull/2329#issuecomment-2078568254 Thanks @zhaomin1423 for the fix, could you please rebase this PR with latest `master` branch? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [postgres] PostgresSql snapshot sql [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2389: URL: https://github.com/apache/flink-cdc/pull/2389#issuecomment-2078583656 Thanks @linzhicong1996 for the great work! Before this PR could be merged, could you please rebase it with latest `master` branch? -- This is an automated message from the Apache

Re: [PR] [FLINK-35196] [Connector / Pulsar] Fix bouncycastle class not found [flink-connector-pulsar]

2024-04-25 Thread via GitHub
wenbingshen commented on PR #91: URL: https://github.com/apache/flink-connector-pulsar/pull/91#issuecomment-2078583839 > The pulsar-client-all should be upgrade to the 3.0.4 in the mean time. @syhily -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [postgres] Postgres CDC Connector support automatically identify newly added tables [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2385: URL: https://github.com/apache/flink-cdc/pull/2385#issuecomment-2078583039 Closing this PR as it has been resolved in #3024. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [docs] format shell code display for mysql-doris-pipeline doc [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #3084: URL: https://github.com/apache/flink-cdc/pull/3084#issuecomment-2078632869 Closing this PR since it's been resolved in #3217 & #3253. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-32706][table] Add built-in SPLIT_STRING function [flink]

2024-04-25 Thread via GitHub
hanyuzheng7 commented on code in PR #24365: URL: https://github.com/apache/flink/pull/24365#discussion_r1580488012 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SplitFunction.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the

Re: [PR] Reorder dependency flink-table-runtime in pom.xml to avoid dependency conflict. [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2754: URL: https://github.com/apache/flink-cdc/pull/2754#issuecomment-2078657737 Hi @HappyHacker123, could you please rebase this PR with latest `master` branch and trigger the CI? Thanks for your contribution! -- This is an automated message from the Apache Git

Re: [PR] [pipeline-connector][starrocks] Add the binary column type support [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2921: URL: https://github.com/apache/flink-cdc/pull/2921#issuecomment-2078671706 Hi @WholeWorld-Timothy, could you please rebase this PR with master branch to see if the CI passes? cc @lvyanquan -- This is an automated message from the Apache Git Service.

Re: [PR] Add a table of cdc json type [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2067: URL: https://github.com/apache/flink-cdc/pull/2067#issuecomment-2078477956 Thanks for your contribution! Flink CDC 3.0 release brought new `values` connector which allows displaying raw event records in console. I'm going to close this PR but feel free to

[jira] [Commented] (FLINK-35236) Flink 1.19 Translation error on the execution_mode/order-of-processing

2024-04-25 Thread hongxu han (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841019#comment-17841019 ] hongxu han commented on FLINK-35236: [~Weijie Guo] I would like to filing a PR to fix this. This is

[jira] [Assigned] (FLINK-34977) FLIP-433: State Access on DataStream API V2

2024-04-25 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-34977: -- Assignee: Jeyhun Karimov (was: Weijie Guo) > FLIP-433: State Access on DataStream API V2 >

[jira] [Closed] (FLINK-35238) AZP is not working since some ci agent unhealthy

2024-04-25 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35238. -- Resolution: Fixed It looks like this has recovered on its own. It should be a network issue. Close

Re: [PR] [common] Improve implementation of offset backing store [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1821: URL: https://github.com/apache/flink-cdc/pull/1821#issuecomment-2078503312 Thanks for your contribution! Before this PR could be merged, could you please rebase it with latest `master` branch? -- This is an automated message from the Apache Git Service. To

Re: [PR] Use Schema#newBuilder instead of TableSchema#fromResolvedSchema [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2061: URL: https://github.com/apache/flink-cdc/pull/2061#issuecomment-2078544616 Thanks @snuyanzin for the great work, could you please rebase it with latest `master` branch? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-35236] [chinese-translation] Modify Translation error on the execution_mode/order-of-processing [flink]

2024-04-25 Thread via GitHub
maomao931228 closed pull request #24720: [FLINK-35236] [chinese-translation] Modify Translation error on the execution_mode/order-of-processing URL: https://github.com/apache/flink/pull/24720 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-35236] [chinese-translation] Modify Translation error on the execution_mode/order-of-processing [flink]

2024-04-25 Thread via GitHub
maomao931228 commented on PR #24720: URL: https://github.com/apache/flink/pull/24720#issuecomment-2078544001 > > Thanks for the fix. I just left a minor comment, please take a look. > > BTW, could you please squash all commits to one: `[FLINK-35236][docs] Fix incorrect translation on

Re: [PR] using tikv limited scan to avoid oom [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2145: URL: https://github.com/apache/flink-cdc/pull/2145#issuecomment-2078552080 Hi @LiPL2017, thanks for your great work! We're planning a general rate-limit framework in the following Flink 3.x releases, so closing this PR for now. -- This is an automated

Re: [PR] [postgres] Add lsn as metadata [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2461: URL: https://github.com/apache/flink-cdc/pull/2461#issuecomment-2078629764 Hi @zhaomin1423, thanks for your contribution! Could you please rebase it with latest `master` branch? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Fix during the snapshot phase, projection is not being performed according to the user defined schema. [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2495: URL: https://github.com/apache/flink-cdc/pull/2495#issuecomment-2078634937 Hi @hzjhjjyy, thanks for your contribution! Could you please rebase your PR with latest `master` branch before it could be merged? You may need to rename packages like from

Re: [PR] [cdc-common] add field of defaultValue to Column. [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #2944: URL: https://github.com/apache/flink-cdc/pull/2944#issuecomment-2078672448 Hi @lvyanquan could you please rebase this with `master` again? Also cc @Jiabao-Sun -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Update mysql-postgres-tutorial-zh.md [flink-cdc]

2024-04-25 Thread via GitHub
yuxiqian commented on PR #1896: URL: https://github.com/apache/flink-cdc/pull/1896#issuecomment-2078475400 Thanks for your contribution! This problem has been resolved as release 3.0 fully refurbished docs. I'm going to close this PR but feel free to reopen it if you have any concerns.

Re: [PR] [FLINK-35162][state] Implement WriteBatchOperation and general MultiGetOperation for ForSt [flink]

2024-04-25 Thread via GitHub
masteryhx closed pull request #24681: [FLINK-35162][state] Implement WriteBatchOperation and general MultiGetOperation for ForSt URL: https://github.com/apache/flink/pull/24681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

  1   2   3   >