[jira] [Created] (FLINK-35247) Upgrade spotless apply to `2.41.1` in flink-connector-parent to work with Java 21

2024-04-26 Thread Mason Chen (Jira)
Mason Chen created FLINK-35247: -- Summary: Upgrade spotless apply to `2.41.1` in flink-connector-parent to work with Java 21 Key: FLINK-35247 URL: https://issues.apache.org/jira/browse/FLINK-35247

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-04-26 Thread via GitHub
ferenc-csaky commented on code in PR #22789: URL: https://github.com/apache/flink/pull/22789#discussion_r1581270742 ## flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/writer/GSRecoverableFsDataOutputStreamTest.java: ## @@ -133,57 +131,57 @@ public void

[PR] [FLINK-35240][Connectors][format]Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record for csv format [flink]

2024-04-26 Thread via GitHub
GOODBOY008 opened a new pull request, #24730: URL: https://github.com/apache/flink/pull/24730 Changes: - Disable `FLUSH_AFTER_WRITE_VALUE` - Use `ObjectWriter#writeValue(org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonGenerator, java.lang.Object)` instead of

[jira] [Comment Edited] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841301#comment-17841301 ] Zhongqiang Gong edited comment on FLINK-35240 at 4/26/24 5:11 PM: --

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1581326630 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecLegacyTableSourceScan.java: ## @@ -90,6 +90,7 @@

[jira] [Updated] (FLINK-35194) Support describe job syntax and execution

2024-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35194: --- Labels: pull-request-available (was: ) > Support describe job syntax and execution >

Re: [PR] [FLINK-34629] Fix non-partition topic subscribe lost. [flink-connector-pulsar]

2024-04-26 Thread via GitHub
syhily commented on PR #84: URL: https://github.com/apache/flink-connector-pulsar/pull/84#issuecomment-2079360052 Plz close this PR for it has been fixed in #85. @tisonkun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Comment Edited] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841232#comment-17841232 ] Zhongqiang Gong edited comment on FLINK-35240 at 4/26/24 1:34 PM: --

[jira] [Comment Edited] (FLINK-31223) sql-client.sh fails to start with ssl enabled

2024-04-26 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841279#comment-17841279 ] david radley edited comment on FLINK-31223 at 4/26/24 3:47 PM: --- [~Weijie

[jira] [Commented] (FLINK-31223) sql-client.sh fails to start with ssl enabled

2024-04-26 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841279#comment-17841279 ] david radley commented on FLINK-31223: -- [~Weijie Guo] I have created pr

[jira] [Commented] (FLINK-35097) Table API Filesystem connector with 'raw' format repeats last line

2024-04-26 Thread David Perkins (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841197#comment-17841197 ] David Perkins commented on FLINK-35097: --- Can the fix get applied to 1.17 also? > Table API

[jira] [Comment Edited] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841232#comment-17841232 ] Zhongqiang Gong edited comment on FLINK-35240 at 4/26/24 1:22 PM: --

Re: [PR] [FLINK-35022][Connector/DynamoDB] Add TypeInformed DDB Element Converter [flink-connector-aws]

2024-04-26 Thread via GitHub
vahmed-hamdy commented on code in PR #136: URL: https://github.com/apache/flink-connector-aws/pull/136#discussion_r1581083313 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbTypeInformedElementConverter.java: ## @@

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix DynamicKafkaSourceEnumerator removed topics state cleanup [flink-connector-kafka]

2024-04-26 Thread via GitHub
IgnasD commented on code in PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#discussion_r1581103075 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumerator.java: ## @@ -288,36 +288,39 @@

[jira] [Updated] (FLINK-35232) Support for retry settings on GCS connector

2024-04-26 Thread Oleksandr Nitavskyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Nitavskyi updated FLINK-35232: Description: https://issues.apache.org/jira/browse/FLINK-32877 is tracking

[PR] [FLINK-35194][table] Support describe job with job id [flink]

2024-04-26 Thread via GitHub
xuyangzhong opened a new pull request, #24728: URL: https://github.com/apache/flink/pull/24728 ## What is the purpose of the change Support syntax '{ DESCRIBE | DESC } JOB 'xxx'' ## Brief change log - *Support to parse syntax { DESCRIBE | DESC } JOB 'xxx'* -

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841271#comment-17841271 ] Alexander Fedulov commented on FLINK-35240: --- [~gongzhongqiang] and [~robyoung]  you are right!

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1580840112 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/event/DataChangeEventSerializer.java: ## @@ -76,28 +72,18 @@ public DataChangeEvent

[jira] [Closed] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35246. -- Resolution: Fixed > SqlClientSSLTest.testGatewayMode failed in AZP >

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841232#comment-17841232 ] Zhongqiang Gong commented on FLINK-35240: - !截图-1.png! The close methed always be invorked, in

Re: [PR] [FLINK-35246][test] Fix incorrect address construction in SqlClientSSLTest [flink]

2024-04-26 Thread via GitHub
reswqa commented on PR #24727: URL: https://github.com/apache/flink/pull/24727#issuecomment-2079379345 Thanks for the review, merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-35246][test] Fix incorrect address construction in SqlClientSSLTest [flink]

2024-04-26 Thread via GitHub
reswqa merged PR #24727: URL: https://github.com/apache/flink/pull/24727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-35232) Support for retry settings on GCS connector

2024-04-26 Thread Oleksandr Nitavskyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Nitavskyi updated FLINK-35232: Description: https://issues.apache.org/jira/browse/FLINK-32877 is tracking

[jira] [Updated] (FLINK-35232) Support for retry settings on GCS connector

2024-04-26 Thread Oleksandr Nitavskyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Nitavskyi updated FLINK-35232: Description: https://issues.apache.org/jira/browse/FLINK-32877 is tracking

[jira] [Updated] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-35240: -- Attachment: image-2024-04-26-17-16-20-647.png > Disable FLUSH_AFTER_WRITE_VALUE to

[jira] [Updated] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-35240: -- Attachment: image-2024-04-26-17-16-07-925.png > Disable FLUSH_AFTER_WRITE_VALUE to

[jira] [Updated] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-35240: -- Attachment: image-2024-04-26-17-16-30-293.png > Disable FLUSH_AFTER_WRITE_VALUE to

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to g… [flink]

2024-04-26 Thread via GitHub
davidradl commented on PR #24729: URL: https://github.com/apache/flink/pull/24729#issuecomment-2079655100 incomplete will redo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35194][table] Support describe job with job id [flink]

2024-04-26 Thread via GitHub
flinkbot commented on PR #24728: URL: https://github.com/apache/flink/pull/24728#issuecomment-2079305845 ## CI report: * 6511c8930cde9f8a3e3acef78fc3bcecb5e9cb51 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35196] [Connector / Pulsar] Fix bouncycastle class not found [flink-connector-pulsar]

2024-04-26 Thread via GitHub
syhily commented on PR #91: URL: https://github.com/apache/flink-connector-pulsar/pull/91#issuecomment-2079354340 > > The pulsar-client-all should be upgrade to the 3.0.4 in the mean time. > > @syhily After `pulsar-client-all` was updated to 3.0.4, the unit test failed. I took a

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1581715242 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java: ## @@ -123,6 +124,7 @@ public class StreamGraph implements Pipeline {

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1581321727 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/PhysicalTransformation.java: ## @@ -34,6 +35,7 @@ public abstract class

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1581716086 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java: ## @@ -133,6 +139,21 @@

[jira] [Created] (FLINK-35248) Support table/column comment to modify DDL

2024-04-26 Thread melin (Jira)
melin created FLINK-35248: - Summary: Support table/column comment to modify DDL Key: FLINK-35248 URL: https://issues.apache.org/jira/browse/FLINK-35248 Project: Flink Issue Type: New Feature

Re: [PR] support op_type metadata columns [flink-cdc]

2024-04-26 Thread via GitHub
wangqinghuan closed pull request #1071: support op_type metadata columns URL: https://github.com/apache/flink-cdc/pull/1071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix during the snapshot phase, projection is not being performed according to the user defined schema. [flink-cdc]

2024-04-26 Thread via GitHub
hzjhjjyy commented on PR #2495: URL: https://github.com/apache/flink-cdc/pull/2495#issuecomment-2080353903 > Hi @hzjhjjyy, thanks for your contribution! Could you please rebase your PR with latest `master` branch before it could be merged? You may need to rename packages like from

<    1   2