[GitHub] flink pull request: [FLINK-2467] Example WordCountStorm.jar is not...

2015-08-03 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/974#issuecomment-127283992 Failing test is unrelated. This should be ready for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-2467) Example WordCountStorm.jar is not packaged correctly

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652010#comment-14652010 ] ASF GitHub Bot commented on FLINK-2467: --- Github user mjsax commented on the pull

[GitHub] flink pull request: [FLINK-2471]FileSinkFunction invoke performanc...

2015-08-03 Thread ffbin
Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/973#issuecomment-127259881 hi, I can run successfully in local computer,but CI is failed,How can i see why CI is failed? I can not see the details content ,it is Do you have a question?. ---

[jira] [Commented] (FLINK-2471) FileSinkFunction invoke performance optimize

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651908#comment-14651908 ] ASF GitHub Bot commented on FLINK-2471: --- Github user ffbin commented on the pull

[jira] [Commented] (FLINK-2471) FileSinkFunction invoke performance optimize

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651912#comment-14651912 ] ASF GitHub Bot commented on FLINK-2471: --- Github user StephanEwen commented on the

[GitHub] flink pull request: [FLINK-2471]FileSinkFunction invoke performanc...

2015-08-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/973#issuecomment-127260841 Can you access this link here? https://travis-ci.org/apache/flink/builds/73886757 --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2105] Implement Sort-Merge Outer Join a...

2015-08-03 Thread r-pogalz
Github user r-pogalz commented on the pull request: https://github.com/apache/flink/pull/907#issuecomment-127293419 Hello @fhueske, I see you noticed that we replaced all occurrences of `Record` by `Tuple2Integer, String` in the InnerJoin- and OuterJoinITCases. The issue is that

[jira] [Commented] (FLINK-2105) Implement Sort-Merge Outer Join algorithm

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652044#comment-14652044 ] ASF GitHub Bot commented on FLINK-2105: --- Github user r-pogalz commented on the pull

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652618#comment-14652618 ] ASF GitHub Bot commented on FLINK-1819: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652624#comment-14652624 ] ASF GitHub Bot commented on FLINK-1819: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/966#discussion_r36136321 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/DiscardingOutputFormat.java --- @@ -27,7 +27,7 @@ * * @param T The type of the

[jira] [Updated] (FLINK-2095) Screenshots missing in webclient documentation

2015-08-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-2095: - Summary: Screenshots missing in webclient documentation (was: Screenshots missing in webcient

[jira] [Commented] (FLINK-2205) Confusing entries in JM Webfrontend Job Configuration section

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652714#comment-14652714 ] ASF GitHub Bot commented on FLINK-2205: --- Github user fhueske commented on the pull

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/966#discussion_r36142648 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/operators/util/NonRichGenericInputFormat.java --- @@ -0,0 +1,86 @@ +/* + *

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652763#comment-14652763 ] ASF GitHub Bot commented on FLINK-1819: --- Github user sachingoel0101 commented on a

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-127433865 @fhueske, in the life cycle of an Input format, the `open` method is called several times in each parallel instance of the `DataSource` operator. Consider for

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652794#comment-14652794 ] ASF GitHub Bot commented on FLINK-1819: --- Github user sachingoel0101 commented on the

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652626#comment-14652626 ] ASF GitHub Bot commented on FLINK-1819: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/966#discussion_r36136514 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/type/extractor/TypeExtractorInputFormatsTest.java --- @@ -130,7 +131,7 @@ public void

[GitHub] flink pull request: [FLINK-2095] Screenshots missing in webcient d...

2015-08-03 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/976#issuecomment-127421361 Thanks for the PR! I will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-2095) Screenshots missing in webcient documentation

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652672#comment-14652672 ] ASF GitHub Bot commented on FLINK-2095: --- Github user fhueske commented on the pull

[GitHub] flink pull request: [FLINK-2205] Fix confusing entries in JM UI Jo...

2015-08-03 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/927#issuecomment-127426412 This PR is fixing the older UI and still valid right? Any reason not to merge it? --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/966#discussion_r36136228 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/operators/util/NonRichGenericInputFormat.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to

[jira] [Resolved] (FLINK-2422) Web client is showing a blank page if Meta refresh is disabled in browser

2015-08-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske resolved FLINK-2422. -- Resolution: Fixed Fix Version/s: 0.10 Fixed by bb5e61d242ad272a16b487a0cf461774b73e648b

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-127430006 @fhueske , what do we settle on then? Should I keep it as abstract class or change it to an interface? Also, which classes need to be Rich? Can I assume that

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652771#comment-14652771 ] ASF GitHub Bot commented on FLINK-1819: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-127415936 Hi @sachingoel0101, thanks for opening this PR! I see your point that users would have to implement `setRuntimeContext()` and `getRuntimeContext()` if we

[jira] [Commented] (FLINK-2095) Screenshots missing in webcient documentation

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652676#comment-14652676 ] ASF GitHub Bot commented on FLINK-2095: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2095] Screenshots missing in webcient d...

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/976 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Comment Edited] (FLINK-2422) Web client is showing a blank page if Meta refresh is disabled in browser

2015-08-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652702#comment-14652702 ] Fabian Hueske edited comment on FLINK-2422 at 8/3/15 10:49 PM:

[jira] [Commented] (FLINK-2471) FileSinkFunction invoke performance optimize

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652905#comment-14652905 ] ASF GitHub Bot commented on FLINK-2471: --- Github user ffbin commented on the pull

[GitHub] flink pull request: [FLINK-2471]FileSinkFunction invoke performanc...

2015-08-03 Thread ffbin
Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/973#issuecomment-127445514 Hi , i can not access https://travis-ci.org/apache/flink/builds/73886757. Open it , i can only see Do you have a question?. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-2095] Screenshots missing in webcient d...

2015-08-03 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/976#issuecomment-127414537 This only update documentation. Failing test in unrelated. Should be ready to get merged. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-2422) Web client is showing a blank page if Meta refresh is disabled in browser

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652700#comment-14652700 ] ASF GitHub Bot commented on FLINK-2422: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2422] [web client] adding redirect link

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/946 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652770#comment-14652770 ] ASF GitHub Bot commented on FLINK-1819: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/966#discussion_r36142853 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/operators/util/NonRichGenericInputFormat.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to

[GitHub] flink pull request: FLINK-2166. Add fromCsvFile() method to TableE...

2015-08-03 Thread jamescao
Github user jamescao commented on the pull request: https://github.com/apache/flink/pull/939#issuecomment-127451006 It turns out that moving `TableEnvironment` to `org.apache.flink.api.table` may not be a clean solution to this problem. the `toDataSet()` and `toDataStream()` methods

[jira] [Commented] (FLINK-2166) Add fromCsvFile() to TableEnvironment

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652926#comment-14652926 ] ASF GitHub Bot commented on FLINK-2166: --- Github user jamescao commented on the pull

[jira] [Commented] (FLINK-2471) FileSinkFunction invoke performance optimize

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652924#comment-14652924 ] ASF GitHub Bot commented on FLINK-2471: --- Github user ffbin commented on the pull

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/966#discussion_r36136714 --- Diff: flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java --- @@ -307,7 +307,7 @@ public void flatMap(String value,

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652627#comment-14652627 ] ASF GitHub Bot commented on FLINK-1819: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652629#comment-14652629 ] ASF GitHub Bot commented on FLINK-1819: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-2471) FileSinkFunction invoke performance optimize

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652891#comment-14652891 ] ASF GitHub Bot commented on FLINK-2471: --- Github user ffbin commented on the pull

[GitHub] flink pull request: [FLINK-2471]FileSinkFunction invoke performanc...

2015-08-03 Thread ffbin
Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/973#issuecomment-127449876 hi, System.currentTimeMillis() is cost performance very much.I want to use a thread to call System.currentTimeMillis and update a static long variable millTime.All other

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652612#comment-14652612 ] ASF GitHub Bot commented on FLINK-1819: --- Github user fhueske commented on the pull

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/966#discussion_r36135989 --- Diff: flink-tests/src/test/java/org/apache/flink/test/recordJobs/util/DiscardingOutputFormat.java --- @@ -19,14 +19,14 @@ package

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/966#discussion_r36136676 --- Diff: flink-staging/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java --- @@ -80,7 +80,7 @@ public void

[jira] [Closed] (FLINK-2095) Screenshots missing in webclient documentation

2015-08-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-2095. Resolution: Fixed Fix Version/s: 0.10 Fixed by 2859f59f84aae46791b51493f8777679de496a86

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652614#comment-14652614 ] ASF GitHub Bot commented on FLINK-1819: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-2422] [web client] adding redirect link

2015-08-03 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/946#issuecomment-127424745 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-2422) Web client is showing a blank page if Meta refresh is disabled in browser

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652692#comment-14652692 ] ASF GitHub Bot commented on FLINK-2422: --- Github user fhueske commented on the pull

[jira] [Updated] (FLINK-2422) Web client is showing a blank page if Meta refresh is disabled in browser

2015-08-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-2422: - Fix Version/s: 0.9.1 Web client is showing a blank page if Meta refresh is disabled in browser

[jira] [Commented] (FLINK-2422) Web client is showing a blank page if Meta refresh is disabled in browser

2015-08-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652708#comment-14652708 ] Fabian Hueske commented on FLINK-2422: -- Fixed in 0.9.1 by

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-03 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/966#discussion_r36143535 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/operators/util/NonRichGenericInputFormat.java --- @@ -0,0 +1,86 @@ +/* + *

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652784#comment-14652784 ] ASF GitHub Bot commented on FLINK-1819: --- Github user sachingoel0101 commented on a

[jira] [Commented] (FLINK-2464) BufferSpillerTest sometimes fails

2015-08-03 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652852#comment-14652852 ] Sachin Goel commented on FLINK-2464: I observed a failure on this case.

[jira] [Commented] (FLINK-2456) The flink-hbase module dependencies hadoop-2 specifies a repository ID

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652876#comment-14652876 ] ASF GitHub Bot commented on FLINK-2456: --- Github user HuangWHWHW commented on the

[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...

2015-08-03 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/969#issuecomment-127443533 My plessure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Created] (FLINK-2477) Add test for SocketClientSink

2015-08-03 Thread Huang Wei (JIRA)
Huang Wei created FLINK-2477: Summary: Add test for SocketClientSink Key: FLINK-2477 URL: https://issues.apache.org/jira/browse/FLINK-2477 Project: Flink Issue Type: Test Components:

[GitHub] flink pull request: [FLINK-2472]Make JobClientActor poll JobManage...

2015-08-03 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/979 [FLINK-2472]Make JobClientActor poll JobManager continuously for updates on submitted job This PR adds functionality for the `JobClientActor` to poll the `JobManager` after a set interval

[jira] [Commented] (FLINK-2472) Make the JobClientActor check periodically if the submitted Job is still running and if the JobManager is still alive

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653029#comment-14653029 ] ASF GitHub Bot commented on FLINK-2472: --- GitHub user sachingoel0101 opened a pull

[jira] [Commented] (FLINK-2477) Add test for SocketClientSink

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653020#comment-14653020 ] ASF GitHub Bot commented on FLINK-2477: --- GitHub user HuangWHWHW opened a pull

[GitHub] flink pull request: [FLINK-2477][Add]Add tests for SocketClientSin...

2015-08-03 Thread HuangWHWHW
GitHub user HuangWHWHW opened a pull request: https://github.com/apache/flink/pull/977 [FLINK-2477][Add]Add tests for SocketClientSink Add tests for SocketClientSink. 1.Test SocketClientSink open function: setup a socket server -- using SocketClientSink to connect the

[jira] [Created] (FLINK-2476) Remove unwanted check null of input1 in ConnectedDataStream

2015-08-03 Thread fangfengbin (JIRA)
fangfengbin created FLINK-2476: -- Summary: Remove unwanted check null of input1 in ConnectedDataStream Key: FLINK-2476 URL: https://issues.apache.org/jira/browse/FLINK-2476 Project: Flink Issue

[GitHub] flink pull request: Remove unwanted check null of input1 in Connec...

2015-08-03 Thread ffbin
GitHub user ffbin opened a pull request: https://github.com/apache/flink/pull/978 Remove unwanted check null of input1 in ConnectedDataStream input1 is used in line 61.If input1 is null ,it will throw NullPointException in line 61.So check null of input1 after use input1 is

[GitHub] flink pull request: [FLINK-2442] [fix] FieldPositionKeys support P...

2015-08-03 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/963#issuecomment-127408557 Thanks! I will merge this into the 0.10 and 0.9 branches tomorrow if nobody else comments on the PR. @StephanEwen Regarding the follow-up issue: POJOs do

[jira] [Commented] (FLINK-2442) PojoType fields not supported by field position keys

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652533#comment-14652533 ] ASF GitHub Bot commented on FLINK-2442: --- Github user fhueske commented on the pull

[jira] [Updated] (FLINK-2475) Rename Flink Client log and out file

2015-08-03 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated FLINK-2475: --- Description: Currently, JoManager and TaskManager log/out files are names as follows: -

[GitHub] flink pull request: FLINK-2322 Unclosed stream may leak resource

2015-08-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/928#issuecomment-127177176 Looks good, merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-2409) Old JM web interface is sending cancel messages w/o leader ID

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651661#comment-14651661 ] ASF GitHub Bot commented on FLINK-2409: --- Github user StephanEwen commented on the

[jira] [Commented] (FLINK-2322) Unclosed stream may leak resource

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651664#comment-14651664 ] ASF GitHub Bot commented on FLINK-2322: --- Github user StephanEwen commented on the

[jira] [Assigned] (FLINK-2460) ReduceOnNeighborsWithExceptionITCase failure

2015-08-03 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-2460: -- Assignee: Ufuk Celebi ReduceOnNeighborsWithExceptionITCase failure

[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...

2015-08-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/969#issuecomment-127183500 The repository you add is the default Maven repository - it should be used by default anyways. Is the change there override your mirror repository for HBase

[jira] [Commented] (FLINK-2425) Give access to TaskManager config and hostname in the Runtime Environment

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651713#comment-14651713 ] ASF GitHub Bot commented on FLINK-2425: --- Github user StephanEwen commented on the

[jira] [Commented] (FLINK-2466) Travis build failure

2015-08-03 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651714#comment-14651714 ] Stephan Ewen commented on FLINK-2466: - Okay, that is a good catch... Travis build

[jira] [Commented] (FLINK-2238) Scala ExecutionEnvironment.fromCollection does not work with Sets

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651722#comment-14651722 ] ASF GitHub Bot commented on FLINK-2238: --- Github user fhueske commented on the pull

[jira] [Created] (FLINK-2468) StreamCheckpointingITCase failure

2015-08-03 Thread Sachin Goel (JIRA)
Sachin Goel created FLINK-2468: -- Summary: StreamCheckpointingITCase failure Key: FLINK-2468 URL: https://issues.apache.org/jira/browse/FLINK-2468 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-2111) Add stop signal to cleanly shutdown streaming jobs

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651499#comment-14651499 ] ASF GitHub Bot commented on FLINK-2111: --- Github user hsaputra commented on a diff in

[GitHub] flink pull request: [FLINK-2111] Add stop signal to cleanly shut...

2015-08-03 Thread hsaputra
Github user hsaputra commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r36059082 --- Diff: docs/apis/cli.md --- @@ -176,6 +180,18 @@ Action list lists running and scheduled programs. -s,--scheduledShow only

[jira] [Created] (FLINK-2465) SocketClientSink closeConnection function has memory leak

2015-08-03 Thread fangfengbin (JIRA)
fangfengbin created FLINK-2465: -- Summary: SocketClientSink closeConnection function has memory leak Key: FLINK-2465 URL: https://issues.apache.org/jira/browse/FLINK-2465 Project: Flink Issue

[GitHub] flink pull request: [FLINK-2465] Fix SocketClientSink closeConnect...

2015-08-03 Thread ffbin
GitHub user ffbin opened a pull request: https://github.com/apache/flink/pull/972 [FLINK-2465] Fix SocketClientSink closeConnection function memory leak When closeConnection, should call dataOutputStream.close() instead of dataOutputStream.flush() because close() will call flush()

[GitHub] flink pull request: [FLINK-2409] [webserver] Replaces ActorRefs wi...

2015-08-03 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/959#issuecomment-127176750 If there are no objections, then I would like to merge this PR in the evening. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-1665) Add optional annotations for POJOs to specify the order of fields

2015-08-03 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651688#comment-14651688 ] Stephan Ewen commented on FLINK-1665: - You can always specify order the following way:

[jira] [Commented] (FLINK-2456) The flink-hbase module dependencies hadoop-2 specifies a repository ID

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651707#comment-14651707 ] ASF GitHub Bot commented on FLINK-2456: --- Github user StephanEwen commented on the

[GitHub] flink pull request: [FLINK-2425]Provide access to task manager con...

2015-08-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/952#issuecomment-127184585 Looks good, modulo some styles... - No need to override all set* methods, when the internal set method is overridden. - Final modifiers should be

[GitHub] flink pull request: [FLINK-2425]Provide access to task manager con...

2015-08-03 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/952#issuecomment-127185418 Ah. Okay. You can fix the remaining things. This build also fails on the StreamCheckpointingITCase. I'll file another JIRA ticket for that. I've observed that

[jira] [Commented] (FLINK-2425) Give access to TaskManager config and hostname in the Runtime Environment

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651716#comment-14651716 ] ASF GitHub Bot commented on FLINK-2425: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-2409] [webserver] Replaces ActorRefs wi...

2015-08-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/959#issuecomment-127176955 Go ahead :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-2409) Old JM web interface is sending cancel messages w/o leader ID

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651658#comment-14651658 ] ASF GitHub Bot commented on FLINK-2409: --- Github user tillrohrmann commented on the

[jira] [Commented] (FLINK-2466) Travis build failure

2015-08-03 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651659#comment-14651659 ] Stephan Ewen commented on FLINK-2466: - Do you know which test cause the kill? A kill

[jira] [Commented] (FLINK-2466) Travis build failure

2015-08-03 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651680#comment-14651680 ] Stephan Ewen commented on FLINK-2466: - I don't think it is that test. It just happens

[jira] [Created] (FLINK-2467) Example WordCountStorm.jar in not packaged correclty

2015-08-03 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created FLINK-2467: -- Summary: Example WordCountStorm.jar in not packaged correclty Key: FLINK-2467 URL: https://issues.apache.org/jira/browse/FLINK-2467 Project: Flink Issue

[jira] [Commented] (FLINK-2466) Travis build failure

2015-08-03 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651692#comment-14651692 ] Sachin Goel commented on FLINK-2466: Yeah. I thought so. Although it is worth

[jira] [Updated] (FLINK-2467) Example WordCountStorm.jar is not packaged correctly

2015-08-03 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated FLINK-2467: --- Summary: Example WordCountStorm.jar is not packaged correctly (was: Example

[jira] [Updated] (FLINK-2467) Example WordCountStorm.jar is not packaged correctly

2015-08-03 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated FLINK-2467: --- Description: After moving storm compatibility to flink-contrib, WordCountStorm example is not

[jira] [Commented] (FLINK-2465) SocketClientSink closeConnection function has memory leak

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651701#comment-14651701 ] ASF GitHub Bot commented on FLINK-2465: --- Github user StephanEwen commented on the

[GitHub] flink pull request: [FLINK-2465] Fix SocketClientSink closeConnect...

2015-08-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/972#issuecomment-127182452 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-2465) SocketClientSink closeConnection function has memory leak

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651699#comment-14651699 ] ASF GitHub Bot commented on FLINK-2465: --- Github user StephanEwen commented on the

[GitHub] flink pull request: [FLINK-2465] Fix SocketClientSink closeConnect...

2015-08-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/972#issuecomment-127182565 BTW: All of these things are not memory leaks. Java always closes the streams when the objects are garbage collected. It is simply good practice to close

  1   2   >