[jira] [Commented] (FLINK-2621) Add support for positional arguments to ParameterTool

2015-09-04 Thread Behrouz Derakhshan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730712#comment-14730712 ] Behrouz Derakhshan commented on FLINK-2621: --- Well I had the idea of users not being concern with

[jira] [Updated] (FLINK-2621) Add support for positional arguments to ParameterTool

2015-09-04 Thread Behrouz Derakhshan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Behrouz Derakhshan updated FLINK-2621: -- Description: While working on FLINK-2021, we noticed we need to have support for

[jira] [Updated] (FLINK-2621) Add support for positional arguments to ParameterTool

2015-09-04 Thread Behrouz Derakhshan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Behrouz Derakhshan updated FLINK-2621: -- Description: While working on FLINK-2021, the need for positional argument support

[jira] [Commented] (FLINK-2030) Implement an online histogram with Merging and equalization features

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730562#comment-14730562 ] ASF GitHub Bot commented on FLINK-2030: --- Github user chiwanpark commented on the pull request:

[jira] [Commented] (FLINK-2030) Implement an online histogram with Merging and equalization features

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730560#comment-14730560 ] ASF GitHub Bot commented on FLINK-2030: --- Github user chiwanpark commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2106] [runtime] add Left-, Right- and F...

2015-09-04 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1052#issuecomment-137691399 Looks good to merge. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/861#discussion_r38736955 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java --- @@ -0,0 +1,534 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/861#discussion_r38735587 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java --- @@ -0,0 +1,534 @@ +/* + * Licensed to the

[jira] [Updated] (FLINK-2274) Add a histogram method for DataSet[Double]

2015-09-04 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel updated FLINK-2274: --- Component/s: (was: Machine Learning Library) Java API > Add a histogram method

[jira] [Comment Edited] (FLINK-2621) Add support for positional arguments to ParameterTool

2015-09-04 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730709#comment-14730709 ] Robert Metzger edited comment on FLINK-2621 at 9/4/15 12:18 PM: Looks

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730671#comment-14730671 ] ASF GitHub Bot commented on FLINK-2030: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137712869 I also like to take a look before merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread thvasilo
Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137714631 Hello, my 2c: This PR should include docs and a wrapper for the Scala API. We can also do this with a separate issue but it would be best if we merge as a more complete

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730672#comment-14730672 ] ASF GitHub Bot commented on FLINK-2030: --- Github user thvasilo commented on the pull request:

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/861#discussion_r38736695 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java --- @@ -0,0 +1,534 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/861#discussion_r38735464 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java --- @@ -0,0 +1,534 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/861#discussion_r38735611 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java --- @@ -0,0 +1,534 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730595#comment-14730595 ] ASF GitHub Bot commented on FLINK-2030: --- Github user sachingoel0101 commented on the pull request:

[jira] [Updated] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel updated FLINK-2030: --- Summary: Implement discrete and continuous histograms (was: Implement an online histogram with

[jira] [Created] (FLINK-2619) Some Scala Tests not being executed by Maven

2015-09-04 Thread Chiwan Park (JIRA)
Chiwan Park created FLINK-2619: -- Summary: Some Scala Tests not being executed by Maven Key: FLINK-2619 URL: https://issues.apache.org/jira/browse/FLINK-2619 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-2030) Implement an online histogram with Merging and equalization features

2015-09-04 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel updated FLINK-2030: --- Labels: (was: ML) > Implement an online histogram with Merging and equalization features >

[jira] [Commented] (FLINK-2030) Implement an online histogram with Merging and equalization features

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730581#comment-14730581 ] ASF GitHub Bot commented on FLINK-2030: --- Github user sachingoel0101 commented on a diff in the pull

[jira] [Updated] (FLINK-2030) Implement an online histogram with Merging and equalization features

2015-09-04 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel updated FLINK-2030: --- Component/s: (was: Machine Learning Library) Core > Implement an online

[jira] [Updated] (FLINK-2274) Add a histogram method for DataSet[Double]

2015-09-04 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel updated FLINK-2274: --- Description: We should provide descriptive statistics about DataSets containing real numbers. A

[jira] [Updated] (FLINK-2274) Add a histogram method for DataSet[Double]

2015-09-04 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel updated FLINK-2274: --- Labels: (was: ML) > Add a histogram method for DataSet[Double] >

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137690196 Looks good to merge except some minor issues. If there is no objection for this PR, I'll merge this in tomorrow. --- If your project is set up for it, you can reply

[jira] [Created] (FLINK-2621) Add support for positional arguments to ParameterTool

2015-09-04 Thread Behrouz Derakhshan (JIRA)
Behrouz Derakhshan created FLINK-2621: - Summary: Add support for positional arguments to ParameterTool Key: FLINK-2621 URL: https://issues.apache.org/jira/browse/FLINK-2621 Project: Flink

[jira] [Commented] (FLINK-2030) Implement an online histogram with Merging and equalization features

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730578#comment-14730578 ] ASF GitHub Bot commented on FLINK-2030: --- Github user sachingoel0101 commented on a diff in the pull

[jira] [Commented] (FLINK-2106) Add outer joins to Runtime

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730568#comment-14730568 ] ASF GitHub Bot commented on FLINK-2106: --- Github user chiwanpark commented on the pull request:

[jira] [Commented] (FLINK-2030) Implement an online histogram with Merging and equalization features

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730561#comment-14730561 ] ASF GitHub Bot commented on FLINK-2030: --- Github user chiwanpark commented on a diff in the pull

[jira] [Commented] (FLINK-2030) Implement an online histogram with Merging and equalization features

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730559#comment-14730559 ] ASF GitHub Bot commented on FLINK-2030: --- Github user chiwanpark commented on a diff in the pull

[jira] [Commented] (FLINK-2621) Add support for positional arguments to ParameterTool

2015-09-04 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730709#comment-14730709 ] Robert Metzger commented on FLINK-2621: --- Looks good. I think that the check for conditional

[jira] [Commented] (FLINK-2621) Add support for positional arguments to ParameterTool

2015-09-04 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730723#comment-14730723 ] Robert Metzger commented on FLINK-2621: --- I wrote on the ML again. I would prefer to have support by

[GitHub] flink pull request: Update FlinkTopology.java

2015-09-04 Thread gcpagano
GitHub user gcpagano opened a pull request: https://github.com/apache/flink/pull/1092 Update FlinkTopology.java Make FlinkTopology public You can merge this pull request into a Git repository by running: $ git pull https://github.com/gcpagano/flink patch-1 Alternatively you

[jira] [Created] (FLINK-2620) StreamPartitioner is not properly initialized for shuffle and rebalance

2015-09-04 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created FLINK-2620: -- Summary: StreamPartitioner is not properly initialized for shuffle and rebalance Key: FLINK-2620 URL: https://issues.apache.org/jira/browse/FLINK-2620 Project:

[jira] [Commented] (FLINK-2617) ConcurrentModificationException when using HCatRecordReader to access a hive table

2015-09-04 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730694#comment-14730694 ] Fabian Hueske commented on FLINK-2617: -- Yes, that could be a fix. But I think it would be good to

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-09-04 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1046#issuecomment-137748262 Concerning the changes at the core classes: - The storm config key is an application specific key and not part of the system configuration, therefore it should

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137748205 Hello @thvasilo , I was unable to access the `create...` functions from the scala API. I'm not sure how to pass a `DataSet[Double]` to a

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730867#comment-14730867 ] ASF GitHub Bot commented on FLINK-2030: --- Github user sachingoel0101 commented on the pull request:

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730868#comment-14730868 ] ASF GitHub Bot commented on FLINK-2525: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-09-04 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1046#issuecomment-137742282 I have just a quick look over it, and so far it like it. Two things are open to be discussed. I not sure it the change to `ConfigConstants` in a good choice. Would it be

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730843#comment-14730843 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on the pull request:

[jira] [Created] (FLINK-2623) Extend API completeness check to check signatures

2015-09-04 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-2623: Summary: Extend API completeness check to check signatures Key: FLINK-2623 URL: https://issues.apache.org/jira/browse/FLINK-2623 Project: Flink Issue Type:

[jira] [Created] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-09-04 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-2624: --- Summary: RabbitMQ source / sink should participate in checkpointing Key: FLINK-2624 URL: https://issues.apache.org/jira/browse/FLINK-2624 Project: Flink Issue

[GitHub] flink pull request: Implementation of distributed copying utility ...

2015-09-04 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1090#issuecomment-137757590 Okay, why not add it to the examples then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730854#comment-14730854 ] ASF GitHub Bot commented on FLINK-2493: --- Github user chenliang613 commented on the pull request:

[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730865#comment-14730865 ] ASF GitHub Bot commented on FLINK-2536: --- Github user HuangWHWHW commented on the pull request:

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-09-04 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1030#issuecomment-137747552 @StephanEwen @tillrohrmann Hi, I get the CI to rerun. Any new comment? --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730869#comment-14730869 ] ASF GitHub Bot commented on FLINK-2525: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-2106] [runtime] add Left-, Right- and F...

2015-09-04 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1052#issuecomment-137757977 I just saw that the OuterJoin runtime classes/tests cause a lot of warnings when compiling. Manyly raw types, unchecked casts. Would be good to fix those.

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-09-04 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-137745160 @mxm Ok, I make the CI rerun. Any new comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-09-04 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1046#issuecomment-137748448 The changes suggested above help with a cleaner separation between the application (here storm compatibility) and the core code. --- If your project is set up for

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730857#comment-14730857 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the pull request:

[GitHub] flink pull request: Update FlinkTopology.java

2015-09-04 Thread gcpagano
Github user gcpagano closed the pull request at: https://github.com/apache/flink/pull/1092 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-2619) Some Scala Tests not being executed by Maven

2015-09-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730837#comment-14730837 ] Stephan Ewen commented on FLINK-2619: - +1 for urgent fixing! > Some Scala Tests not being executed by

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-04 Thread chenliang613
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1087#issuecomment-137744893 The CI failure be reported from flink-yarn-tests .but in my local machine, i did many times checking with "mvn clean verify" in flink-yarn-tests, all are

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730863#comment-14730863 ] ASF GitHub Bot commented on FLINK-2480: --- Github user HuangWHWHW commented on the pull request:

[GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...

2015-09-04 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1073#issuecomment-137746778 @mxm Hi, I change the "\r\n" to "\n" since it use println in PrintSinkFunction.invoke(); --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: Implementation of distributed copying utility ...

2015-09-04 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1090#issuecomment-137760319 Yes, I guess it is a better fit for the examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-2583) Add Stream Sink For Rolling HDFS Files

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730947#comment-14730947 ] ASF GitHub Bot commented on FLINK-2583: --- Github user aljoscha commented on the pull request:

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730956#comment-14730956 ] ASF GitHub Bot commented on FLINK-2030: --- Github user sachingoel0101 commented on the pull request:

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137768632 IMO this isn't a good idea. We're adding an additional mapping step, and creating as many objects unnecessarily. Sure, chaining will make the mapping quite fast,

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730955#comment-14730955 ] ASF GitHub Bot commented on FLINK-2030: --- Github user thvasilo commented on the pull request:

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread thvasilo
Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137768373 Re 1: Good change, implicit classes is the way to go here, no need for implicit conversion in the object. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread thvasilo
Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137772917 I think it would be hard to do otherwise. `java.lang.Double`'s are objects but `scala.Double`'s are not from what I understand. In this case duplicating the code might

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730977#comment-14730977 ] ASF GitHub Bot commented on FLINK-2030: --- Github user thvasilo commented on the pull request:

[jira] [Commented] (FLINK-2106) Add outer joins to Runtime

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731021#comment-14731021 ] ASF GitHub Bot commented on FLINK-2106: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-04 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1084#issuecomment-137782086 How hard is it to support the truncate file code path also for regular Unix file systems (rather than only HDFS 2.7+)? The reason is that this way we would

[jira] [Resolved] (FLINK-2161) Flink Scala Shell does not support external jars (e.g. Gelly, FlinkML)

2015-09-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2161. - Resolution: Fixed Fix Version/s: 0.10 Fixed via 3d528442f6993c64600224483ee3048c40763c80

[jira] [Closed] (FLINK-2161) Flink Scala Shell does not support external jars (e.g. Gelly, FlinkML)

2015-09-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2161. --- > Flink Scala Shell does not support external jars (e.g. Gelly, FlinkML) >

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread thvasilo
Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137764885 ```scala def createDiscreteHistogram: DataSet[DiscreteHistogram] = { wrap(jutils.DataSetUtils.createDiscreteHistogram( self.map(x => new

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-04 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1084#issuecomment-137764994 I (almost) completely reworked the sink. It is now called `RollingSink` and the module is called `flink-connector-filesystem` to show that it works with any Hadoop

[jira] [Commented] (FLINK-2583) Add Stream Sink For Rolling HDFS Files

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731024#comment-14731024 ] ASF GitHub Bot commented on FLINK-2583: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-2348) Instable (failing) Test

2015-09-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730918#comment-14730918 ] Stephan Ewen commented on FLINK-2348: - Looks like a temp file thing. Port the test to use

[jira] [Commented] (FLINK-2106) Add outer joins to Runtime

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730907#comment-14730907 ] ASF GitHub Bot commented on FLINK-2106: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730946#comment-14730946 ] ASF GitHub Bot commented on FLINK-2030: --- Github user thvasilo commented on the pull request:

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731002#comment-14731002 ] ASF GitHub Bot commented on FLINK-2030: --- Github user sachingoel0101 commented on the pull request:

[GitHub] flink pull request: [FLINK-2106] [runtime] add Left-, Right- and F...

2015-09-04 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1052#issuecomment-137781257 Yeah, adding warnings fix to this PR is good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-2474) Occasional failures in PartitionedStateCheckpointingITCase

2015-09-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730913#comment-14730913 ] Stephan Ewen commented on FLINK-2474: - Yes, close it. Will be reopened once we observe a failure. >

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137763865 1. @thvasilo , I have changed the scala `DataSetUtils` class to make it a bit more easy to use. Now, it doesn't require an import of

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730941#comment-14730941 ] ASF GitHub Bot commented on FLINK-2030: --- Github user sachingoel0101 commented on the pull request:

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137776491 @thvasilo , I'm not sure I got that right. I hadn't tested the changed `DataSetUtils`. I'm not sure how to handle the implicit types and class tags. Since you

[GitHub] flink pull request: [FLINK-2106] [runtime] add Left-, Right- and F...

2015-09-04 Thread r-pogalz
Github user r-pogalz commented on the pull request: https://github.com/apache/flink/pull/1052#issuecomment-137780075 Thanks for you comment @StephanEwen, good to know that. I tried to minimize the occurrences of warnings where possible by fixing or suppressing it for this issue.

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730920#comment-14730920 ] ASF GitHub Bot commented on FLINK-2030: --- Github user thvasilo commented on the pull request:

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730981#comment-14730981 ] ASF GitHub Bot commented on FLINK-2030: --- Github user thvasilo commented on the pull request:

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread thvasilo
Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137775231 Also @tillrohrmann : Is changing the DataSetUtils structure considered an API breaking change and should we handle it differently? Any code using `import

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730984#comment-14730984 ] ASF GitHub Bot commented on FLINK-2030: --- Github user sachingoel0101 commented on the pull request:

[jira] [Commented] (FLINK-2106) Add outer joins to Runtime

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731017#comment-14731017 ] ASF GitHub Bot commented on FLINK-2106: --- Github user r-pogalz commented on the pull request:

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-04 Thread thvasilo
Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-137759354 @sachingoel0101 That sounds like a good place for the docs, that `zip_elements_guide.mb` is linked from the DataSet Transformations doc, so replacing that link to a

[GitHub] flink pull request: FLINK-2605 Unclosed RandomAccessFile may leak ...

2015-09-04 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/flink/pull/1089#issuecomment-137772269 Your reasoning w.r.t. current scope of try block was the same as mine. I think it is good to make the scope as accurate as possible. Generally speaking, we don't

[jira] [Commented] (FLINK-2605) Unclosed RandomAccessFile may leak resource in StaticFileServerHandler

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730974#comment-14730974 ] ASF GitHub Bot commented on FLINK-2605: --- Github user tedyu commented on the pull request:

[jira] [Commented] (FLINK-1320) Add an off-heap variant of the managed memory

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731294#comment-14731294 ] ASF GitHub Bot commented on FLINK-1320: --- GitHub user StephanEwen opened a pull request:

[GitHub] flink pull request: [FLINK-1320] [core] Add an off-heap variant of...

2015-09-04 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/1093 [FLINK-1320] [core] Add an off-heap variant of the managed memory This pull request extends the Flink managed memory to work transparently on-heap and off-heap. In Flink's core were

[jira] [Commented] (FLINK-2605) Unclosed RandomAccessFile may leak resource in StaticFileServerHandler

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731459#comment-14731459 ] ASF GitHub Bot commented on FLINK-2605: --- Github user hsaputra commented on the pull request:

[GitHub] flink pull request: FLINK-2605 Unclosed RandomAccessFile may leak ...

2015-09-04 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1089#issuecomment-137857005 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-2605) Unclosed RandomAccessFile may leak resource in StaticFileServerHandler

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731322#comment-14731322 ] ASF GitHub Bot commented on FLINK-2605: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-1320] [core] Add an off-heap variant of...

2015-09-04 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1093#issuecomment-137857146 Isn't there another PR sent for this issue by Max? Or was it for something else. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-1320) Add an off-heap variant of the managed memory

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731461#comment-14731461 ] ASF GitHub Bot commented on FLINK-1320: --- Github user hsaputra commented on the pull request:

[GitHub] flink pull request: FLINK-2605 Unclosed RandomAccessFile may leak ...

2015-09-04 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1089#issuecomment-137837300 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-2030) Implement discrete and continuous histograms

2015-09-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731816#comment-14731816 ] ASF GitHub Bot commented on FLINK-2030: --- Github user chiwanpark commented on the pull request:

  1   2   >