[
https://issues.apache.org/jira/browse/FLINK-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724703#comment-15724703
]
Fabian Hueske commented on FLINK-5266:
--
This looks very similar to FLINK-5220 and might be a
[
https://issues.apache.org/jira/browse/FLINK-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724302#comment-15724302
]
shijinkui commented on FLINK-5221:
--
This problem is Java low level API used Scala high level API's class,
[
https://issues.apache.org/jira/browse/FLINK-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724298#comment-15724298
]
Aljoscha Krettek commented on FLINK-5247:
-
I see. Thanks for looking into this!
I actually have a
[
https://issues.apache.org/jira/browse/FLINK-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724281#comment-15724281
]
Aljoscha Krettek commented on FLINK-5221:
-
FLINK-5250 would be the general fix for this.
>
[
https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724190#comment-15724190
]
ASF GitHub Bot commented on FLINK-4469:
---
Github user wuchong commented on the issue:
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Hi @fhueske @twalthr , I have updated the PR, please review it again when
you are available.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/FLINK-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shuai.xu reassigned FLINK-4930:
---
Assignee: shuai.xu
> Implement FLIP-6 YARN client
>
>
>
[
https://issues.apache.org/jira/browse/FLINK-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724057#comment-15724057
]
ASF GitHub Bot commented on FLINK-3848:
---
Github user KurtYoung commented on the issue:
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2810
Hi @tonycox , i want to appologize first for opening another "project
pushdown" issue when this one is still in active. We actually come up with some
whole new idea and designs compare to the
[
https://issues.apache.org/jira/browse/FLINK-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kurt Young updated FLINK-5266:
--
Component/s: Table API & SQL
> Eagerly project unused fields when selecting aggregation fields
>
Kurt Young created FLINK-5266:
-
Summary: Eagerly project unused fields when selecting aggregation
fields
Key: FLINK-5266
URL: https://issues.apache.org/jira/browse/FLINK-5266
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-5002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723962#comment-15723962
]
Ted Yu commented on FLINK-5002:
---
Can a committer review, please ?
> Lack of synchronization in
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/2949
[FLINK-5257] [table] display optimized logical plan when explaining table
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KurtYoung/flink
[
https://issues.apache.org/jira/browse/FLINK-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723954#comment-15723954
]
ASF GitHub Bot commented on FLINK-5257:
---
GitHub user KurtYoung opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723724#comment-15723724
]
ASF GitHub Bot commented on FLINK-5091:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2915
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723552#comment-15723552
]
Rohit Agarwal commented on FLINK-5247:
--
The existing code already had provisions to throw exceptions
[
https://issues.apache.org/jira/browse/FLINK-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723325#comment-15723325
]
ASF GitHub Bot commented on FLINK-5265:
---
Github user StefanRRichter commented on the issue:
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2948
CC @aljoscha @StephanEwen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
[
https://issues.apache.org/jira/browse/FLINK-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723319#comment-15723319
]
Maximilian Michels commented on FLINK-2821:
---
Thanks for testing! The PR assumes that
[
https://issues.apache.org/jira/browse/FLINK-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723269#comment-15723269
]
Philipp von dem Bussche commented on FLINK-2821:
Hi [~mxm], I wanted to give this a try
[
https://issues.apache.org/jira/browse/FLINK-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723255#comment-15723255
]
ASF GitHub Bot commented on FLINK-5265:
---
GitHub user StefanRRichter opened a pull request:
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/2948
[FLINK-5265] Introduce state handle replication mode for
CheckpointCoordinator
Currently, the ``CheckpointCoordinator`` only supports repartitioning of
``OperatorStateHandle``s based on a
[
https://issues.apache.org/jira/browse/FLINK-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Richter reassigned FLINK-5265:
-
Assignee: Stefan Richter
> Introduce state handle replication mode for
[
https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723248#comment-15723248
]
ASF GitHub Bot commented on FLINK-3921:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723246#comment-15723246
]
ASF GitHub Bot commented on FLINK-3921:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723242#comment-15723242
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user mushketyk commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723245#comment-15723245
]
ASF GitHub Bot commented on FLINK-3921:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723247#comment-15723247
]
ASF GitHub Bot commented on FLINK-3921:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2901#discussion_r90944589
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -182,8 +186,37 @@ protected DelimitedInputFormat(Path
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2564
Hi @greghogan , thank you for your review.
I'll try to fix them in the next couple of days.
Best regards,
Ivan.
---
If your project is set up for it, you can reply to this email
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2901#discussion_r90944828
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -182,8 +186,37 @@ protected DelimitedInputFormat(Path
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2901#discussion_r90945295
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/DelimitedInputFormatTest.java
---
@@ -200,6 +200,30 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2901#discussion_r90943695
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -182,8 +186,37 @@ protected DelimitedInputFormat(Path
Stefan Richter created FLINK-5265:
-
Summary: Introduce state handle replication mode for
CheckpointCoordinator
Key: FLINK-5265
URL: https://issues.apache.org/jira/browse/FLINK-5265
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723144#comment-15723144
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723151#comment-15723151
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723153#comment-15723153
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723160#comment-15723160
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723143#comment-15723143
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723155#comment-15723155
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723163#comment-15723163
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723161#comment-15723161
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723149#comment-15723149
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723159#comment-15723159
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723152#comment-15723152
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723154#comment-15723154
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723156#comment-15723156
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723157#comment-15723157
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723146#comment-15723146
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723145#comment-15723145
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90929487
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723158#comment-15723158
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90924411
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90924109
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90923574
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteEdge.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723162#comment-15723162
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90937167
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90921530
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteEdge.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90926220
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90938901
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java
---
@@ -480,7 +480,8 @@ protected static
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90937740
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/BipartiteEdgeTest.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723147#comment-15723147
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723150#comment-15723150
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90926409
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723148#comment-15723148
]
ASF GitHub Bot commented on FLINK-2254:
---
Github user greghogan commented on a diff in the pull
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90921785
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteEdge.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90937555
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/Projection.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90923609
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90931164
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90930301
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90933026
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90935587
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90926642
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90929479
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90922934
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteEdge.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90938279
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/ProjectionTest.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723129#comment-15723129
]
ASF GitHub Bot commented on FLINK-3848:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2810
Hi @tonycox, the plan choice issues might be related to FLINK-5226. I have
a PR pending to fix this issue: #2926. You could try to built your PR on top of
my PR (or for the sake of simplicity simply
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2913
> Why is that necessary? Can we not just assume that if the attempt is not
equal to the current execution attempt, then the status is some form of
"disposed".
It's not necessary. It's perfectly
[
https://issues.apache.org/jira/browse/FLINK-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723031#comment-15723031
]
ASF GitHub Bot commented on FLINK-5114:
---
Github user uce commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723027#comment-15723027
]
ASF GitHub Bot commented on FLINK-5091:
---
Github user mxm commented on the issue:
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2915
Looks really good!. Merging with some minor changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/FLINK-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722920#comment-15722920
]
ASF GitHub Bot commented on FLINK-3848:
---
Github user tonycox commented on the issue:
Github user tonycox commented on the issue:
https://github.com/apache/flink/pull/2810
I see. @fhueske. Set an order of scaning is much better way.
I have problem when plan is choosing. Best expression is not correct. Rules
work, but planner decides to choose `MapFunction` anyway,
[
https://issues.apache.org/jira/browse/FLINK-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722887#comment-15722887
]
ASF GitHub Bot commented on FLINK-5114:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2913
Having a quick look at this: I think this breaks with a fundamental design
in the ExecutionGraph:
The `findExecutionAttemptWithId(...)` method searches the prior execution
attempts.
[
https://issues.apache.org/jira/browse/FLINK-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722871#comment-15722871
]
ASF GitHub Bot commented on FLINK-5258:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2940
Thanks a lot for this pull request!
I think this looks very good - much better than the current state.
Two changes I would make:
- Drop "Projects and Dependencies", it is so
[
https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722864#comment-15722864
]
ASF GitHub Bot commented on FLINK-3921:
---
Github user greghogan commented on the issue:
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2901
@fhueske, please review the additional commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/FLINK-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722849#comment-15722849
]
ASF GitHub Bot commented on FLINK-5122:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722845#comment-15722845
]
ASF GitHub Bot commented on FLINK-5122:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722847#comment-15722847
]
ASF GitHub Bot commented on FLINK-5122:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722850#comment-15722850
]
ASF GitHub Bot commented on FLINK-5122:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722848#comment-15722848
]
ASF GitHub Bot commented on FLINK-5122:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722846#comment-15722846
]
ASF GitHub Bot commented on FLINK-5122:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2861#discussion_r90916177
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2861#discussion_r90916759
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2861#discussion_r90917049
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
1 - 100 of 241 matches
Mail list logo