[jira] [Commented] (FLINK-6097) Guaranteed the order of the extracted field references

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931036#comment-15931036 ] ASF GitHub Bot commented on FLINK-6097: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3560: [FLINK-6097][table] Guaranteed the order of the ex...

2017-03-17 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3560#discussion_r106772134 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala --- @@ -227,18 +227,23 @@ object

[jira] [Created] (FLINK-6106) Blob Server doesn't delete tmp fold when exit in HA mode.

2017-03-17 Thread Syinchwun Leo (JIRA)
Syinchwun Leo created FLINK-6106: Summary: Blob Server doesn't delete tmp fold when exit in HA mode. Key: FLINK-6106 URL: https://issues.apache.org/jira/browse/FLINK-6106 Project: Flink

[jira] [Commented] (FLINK-6020) Blob Server cannot hanlde multiple job sumits(with same content) parallelly

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931016#comment-15931016 ] ASF GitHub Bot commented on FLINK-6020: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3525: [FLINK-6020]add a random integer suffix to blob key to av...

2017-03-17 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3525 Right...I have same thought as you at the beginning and i've tried to make the move atomic but it has serveral side affect, like: 1. if we use this way to handle this, which means two job

[jira] [Commented] (FLINK-6097) Guaranteed the order of the extracted field references

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930960#comment-15930960 ] ASF GitHub Bot commented on FLINK-6097: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #3560: [FLINK-6097][table] Guaranteed the order of the extracted...

2017-03-17 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3560 HI, @KurtYoung Thanks for your attention to this PR. Good question, Here I glad share why I notice this method: When we try to implement OVER window TableAPI, The first version of the

[jira] [Updated] (FLINK-6097) Guaranteed the order of the extracted field references

2017-03-17 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6097: --- Description: When we try to implement `OVER window` TableAPI, The first version of the prototype to

[jira] [Updated] (FLINK-6097) Guaranteed the order of the extracted field references

2017-03-17 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6097: --- Description: When we try to implement `OVER window` TableAPI, The first version of the prototype to

[GitHub] flink issue #3560: [FLINK-6097][table] Guaranteed the order of the extracted...

2017-03-17 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3560 HI, @KurtYoung Thanks for your attention to this PR. Good question, the purpose of this change is just like this JIRA's description: I want `ProjectionTranslator # identifyFieldReferences`

[jira] [Commented] (FLINK-6097) Guaranteed the order of the extracted field references

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930890#comment-15930890 ] ASF GitHub Bot commented on FLINK-6097: --- Github user sunjincheng121 commented on the issue:

[jira] [Commented] (FLINK-6097) Guaranteed the order of the extracted field references

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930874#comment-15930874 ] ASF GitHub Bot commented on FLINK-6097: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #3560: [FLINK-6097][table] Guaranteed the order of the ex...

2017-03-17 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3560#discussion_r106761581 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala --- @@ -227,18 +227,23 @@ object

[jira] [Commented] (FLINK-5808) Missing verification for setParallelism and setMaxParallelism

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930812#comment-15930812 ] ASF GitHub Bot commented on FLINK-5808: --- Github user aljoscha closed the pull request at:

[GitHub] flink pull request #3509: [FLINK-5808] Fix Missing verification for setParal...

2017-03-17 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/3509 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6020) Blob Server cannot hanlde multiple job sumits(with same content) parallelly

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930495#comment-15930495 ] ASF GitHub Bot commented on FLINK-6020: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3525: [FLINK-6020]add a random integer suffix to blob key to av...

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3525 I think we should then fix this in the blob server. The problem that only one should succeed upon collision should be fixable by using `Files.move()` with `ATOMIC_MOVE`. Only when that

[GitHub] flink pull request #3127: [FLINK-5481] Simplify Row creation

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3127#discussion_r106717641 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/Types.scala --- @@ -17,29 +17,51 @@ */ package

[jira] [Commented] (FLINK-5481) Simplify Row creation

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930439#comment-15930439 ] ASF GitHub Bot commented on FLINK-5481: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink issue #3524: [FLINK-6014][checkpoint] Allow the registration of state ...

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3524 One more question: Can the StateRegistry not directly drop states that have no reference any more when states are unregistered? Is there a special reason for first collecting these states in a

[jira] [Commented] (FLINK-6014) Allow the registration of state objects in checkpoints

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930426#comment-15930426 ] ASF GitHub Bot commented on FLINK-6014: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6014) Allow the registration of state objects in checkpoints

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930423#comment-15930423 ] ASF GitHub Bot commented on FLINK-6014: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3524: [FLINK-6014][checkpoint] Allow the registration of state ...

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3524 Thanks for opening this pull request. Adding a `CompositeStateHandle` and a `StateRegistry` is a good idea. Some thoughts: - What do you think about making the `StateRegistry`

[GitHub] flink issue #2029: [FLINK-2814] Fix for DualInputPlanNode cannot be cast to ...

2017-03-17 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2029 I created #3563 which combines this PR and my suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #3550: [FLINK-5654] - Add processing time OVER RANGE BETWEEN x P...

2017-03-17 Thread rtudoran
Github user rtudoran commented on the issue: https://github.com/apache/flink/pull/3550 @fhueske - Thank you very much for your review. It was very useful. I integrated and addressed most of the remarks you made. What remains to be discussed and it is not addressed is: -using

[jira] [Commented] (FLINK-6050) Improve failure reporting when using Future.thenAccept

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930381#comment-15930381 ] ASF GitHub Bot commented on FLINK-6050: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3537: [FLINK-6050] [robustness] Register exception handler on t...

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3537 I think this is good, +1 Do we have a test that validates that completing a `Future` exceptionally also completes all result Futures of `thenApply` (or `thenApplyAsync`) functions with

[jira] [Commented] (FLINK-2814) DeltaIteration: DualInputPlanNode cannot be cast to SingleInputPlanNode

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930377#comment-15930377 ] ASF GitHub Bot commented on FLINK-2814: --- Github user greghogan commented on the issue:

[GitHub] flink issue #3521: [FLINK-6027][checkpoint] Ignore the exception thrown by t...

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3521 Actually, do you think you could add a test for this? Would be good to guard that for the future... --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930372#comment-15930372 ] ASF GitHub Bot commented on FLINK-5654: --- Github user rtudoran commented on the issue:

[jira] [Commented] (FLINK-2814) DeltaIteration: DualInputPlanNode cannot be cast to SingleInputPlanNode

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930371#comment-15930371 ] ASF GitHub Bot commented on FLINK-2814: --- GitHub user greghogan opened a pull request:

[GitHub] flink pull request #3563: [FLINK-2814] [optimizer] DualInputPlanNode cannot ...

2017-03-17 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3563 [FLINK-2814] [optimizer] DualInputPlanNode cannot be cast to SingleInputPlanNode WorksetIterationNode#instantiate loops over all solution and work set candidates. Since the solution set

[GitHub] flink issue #3526: [FLINK-5999] [resMgnr] Move JobLeaderIdService shut down ...

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3526 Looks good to me, +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-5999) MiniClusterITCase.runJobWithMultipleRpcServices fails

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930363#comment-15930363 ] ASF GitHub Bot commented on FLINK-5999: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6027) Ignore the exception thrown by the subsuming of old completed checkpoints

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930360#comment-15930360 ] ASF GitHub Bot commented on FLINK-6027: --- Github user StephanEwen commented on the issue:

[jira] [Updated] (FLINK-5376) Misleading log statements in UnorderedStreamElementQueue

2017-03-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5376: -- Description: The following are two examples where ordered stream element queue is mentioned: {code}

[jira] [Comment Edited] (FLINK-5486) Lack of synchronization in BucketingSink#handleRestoredBucketState()

2017-03-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822346#comment-15822346 ] Ted Yu edited comment on FLINK-5486 at 3/17/17 5:19 PM: Lock on State.bucketStates

[jira] [Assigned] (FLINK-5985) Flink treats every task as stateful (making topology changes impossible)

2017-03-17 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter reassigned FLINK-5985: - Assignee: Stefan Richter > Flink treats every task as stateful (making topology changes

[jira] [Closed] (FLINK-5985) Flink treats every task as stateful (making topology changes impossible)

2017-03-17 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-5985. - Resolution: Fixed Fix Version/s: 1.2.1 1.3.0 fixed in 20fff32. > Flink

[jira] [Commented] (FLINK-5985) Flink treats every task as stateful (making topology changes impossible)

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930324#comment-15930324 ] ASF GitHub Bot commented on FLINK-5985: --- Github user StefanRRichter closed the pull request at:

[GitHub] flink pull request #3523: [FLINK-5985] Report no task states for stateless t...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/3523 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-5985) Flink treats every task as stateful (making topology changes impossible)

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930320#comment-15930320 ] ASF GitHub Bot commented on FLINK-5985: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #3523: [FLINK-5985] Report no task states for stateless tasks on...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3523 Thanks for the review @StephanEwen. I updated the test as suggested. Merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-6020) Blob Server cannot hanlde multiple job sumits(with same content) parallelly

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930311#comment-15930311 ] ASF GitHub Bot commented on FLINK-6020: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3525: [FLINK-6020]add a random integer suffix to blob key to av...

2017-03-17 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3525 The second rename will not fail, but make the file which written by the first corrupted, which will make the first job failed if the task is loading this jar. by the way, the jar

[jira] [Updated] (FLINK-5541) Missing null check for localJar in FlinkSubmitter#submitTopology()

2017-03-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5541: -- Description: {code} if (localJar == null) { try { for (final URL url :

[jira] [Comment Edited] (FLINK-5629) Unclosed RandomAccessFile in StaticFileServerHandler#respondAsLeader()

2017-03-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854366#comment-15854366 ] Ted Yu edited comment on FLINK-5629 at 3/17/17 5:01 PM: RandomAccessFile#length()

[jira] [Updated] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

2017-03-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5855: -- Description: {code} handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-17 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r106685158 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java --- @@ -48,15 +49,25 @@ * output selection).

[GitHub] flink pull request #3512: [FLINK-6008] collection of BlobServer improvements

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3512#discussion_r106674262 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobCache.java --- @@ -180,91 +180,159 @@ public URL getURL(final BlobKey

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930241#comment-15930241 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #3484: [FLINK-4460] Side Outputs in Flink

2017-03-17 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3484 Thanks for reviewing again, @kl0u! I incorporated all your suggestions. I'm now waiting for travis to give the green light and then I'll merge. @chenqin A lot of thanks also to you for

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930235#comment-15930235 ] ASF GitHub Bot commented on FLINK-5654: --- Github user rtudoran commented on a diff in the pull

[GitHub] flink pull request #3550: [FLINK-5654] - Add processing time OVER RANGE BETW...

2017-03-17 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3550#discussion_r106688499 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -191,3 +287,31 @@

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930234#comment-15930234 ] ASF GitHub Bot commented on FLINK-5654: --- Github user rtudoran commented on a diff in the pull

[GitHub] flink pull request #3550: [FLINK-5654] - Add processing time OVER RANGE BETW...

2017-03-17 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3550#discussion_r106688280 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -785,7 +785,7 @@ object

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106673680 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java ---

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106677330 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java ---

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106670661 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerService.java --- @@ -18,43 +18,306 @@

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106670841 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerService.java --- @@ -18,43 +18,306 @@

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106675685 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java ---

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106671203 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerService.java --- @@ -18,43 +18,306 @@

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106674528 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java ---

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106673233 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java ---

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106675210 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java ---

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106680293 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java ---

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106669225 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerService.java --- @@ -18,43 +18,306 @@

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106674160 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java ---

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106674867 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java ---

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106670283 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerService.java --- @@ -18,43 +18,306 @@

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106669974 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerService.java --- @@ -18,43 +18,306 @@

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106677685 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java ---

[GitHub] flink pull request #3512: [FLINK-6008] collection of BlobServer improvements

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3512#discussion_r106677990 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java --- @@ -400,6 +418,47 @@ public void delete(BlobKey key) throws

[GitHub] flink pull request #3512: [FLINK-6008] collection of BlobServer improvements

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3512#discussion_r106674837 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobCache.java --- @@ -180,91 +180,159 @@ public URL getURL(final BlobKey

[GitHub] flink pull request #3512: [FLINK-6008] collection of BlobServer improvements

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3512#discussion_r106675058 --- Diff: docs/setup/config.md --- @@ -494,13 +494,13 @@ Previously this key was named `recovery.mode` and the default value was `standal -

[GitHub] flink pull request #3512: [FLINK-6008] collection of BlobServer improvements

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3512#discussion_r106680476 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -1305,6 +1305,9 @@ class TaskManager(

[GitHub] flink pull request #3512: [FLINK-6008] collection of BlobServer improvements

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3512#discussion_r106677799 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java --- @@ -400,6 +418,47 @@ public void delete(BlobKey key) throws

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930220#comment-15930220 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-6027) Ignore the exception thrown by the subsuming of old completed checkpoints

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930221#comment-15930221 ] ASF GitHub Bot commented on FLINK-6027: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3521: [FLINK-6027][checkpoint] Ignore the exception thrown by t...

2017-03-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3521 +1, merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (FLINK-4364) Implement heartbeat logic between TaskManager and JobManager

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930219#comment-15930219 ] ASF GitHub Bot commented on FLINK-4364: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (FLINK-4364) Implement heartbeat logic between TaskManager and JobManager

2017-03-17 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-4364. -- Resolution: Fixed Added via 0b3d5c27f4ab7b2dffb37160a1f01cb822bb696e > Implement heartbeat

[GitHub] flink pull request #3151: [FLINK-4364] [runtime] [FLIP-6] Implement TaskMana...

2017-03-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930214#comment-15930214 ] ASF GitHub Bot commented on FLINK-4460: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-6008) collection of BlobServer improvements

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930207#comment-15930207 ] ASF GitHub Bot commented on FLINK-6008: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-6008) collection of BlobServer improvements

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930211#comment-15930211 ] ASF GitHub Bot commented on FLINK-6008: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-6008) collection of BlobServer improvements

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930209#comment-15930209 ] ASF GitHub Bot commented on FLINK-6008: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-17 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r106684413 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -567,6 +600,17 @@ protected

[jira] [Commented] (FLINK-6008) collection of BlobServer improvements

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930210#comment-15930210 ] ASF GitHub Bot commented on FLINK-6008: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-6008) collection of BlobServer improvements

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930206#comment-15930206 ] ASF GitHub Bot commented on FLINK-6008: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-6008) collection of BlobServer improvements

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930208#comment-15930208 ] ASF GitHub Bot commented on FLINK-6008: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930204#comment-15930204 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-17 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r106684096 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -567,6 +600,17 @@ protected

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930168#comment-15930168 ] ASF GitHub Bot commented on FLINK-5544: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930169#comment-15930169 ] ASF GitHub Bot commented on FLINK-5544: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r106668768 --- Diff: flink-contrib/flink-timerserivce-rocksdb/pom.xml --- @@ -0,0 +1,80 @@ + --- End diff -- I think we should simply integrate

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930193#comment-15930193 ] ASF GitHub Bot commented on FLINK-5544: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #3359: [FLINK-5544][streaming] Add InternalTimerService implemen...

2017-03-17 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3359 One additional comment, also as reminder for @aljoscha and me: after this PR is rebased, we have access to `InternalKeyContext`, which should be somehow integrated with the already existing

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930179#comment-15930179 ] ASF GitHub Bot commented on FLINK-5544: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2017-03-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930174#comment-15930174 ] ASF GitHub Bot commented on FLINK-5544: --- Github user StefanRRichter commented on a diff in the pull

  1   2   3   4   5   >