[jira] [Commented] (FLINK-4498) Better Cassandra sink documentation

2017-09-15 Thread Michael Fong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168827#comment-16168827 ] Michael Fong commented on FLINK-4498: - I would like to help updating the documents for

[jira] [Commented] (FLINK-7266) Don't attempt to delete parent directory on S3

2017-09-15 Thread Elias Levy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168733#comment-16168733 ] Elias Levy commented on FLINK-7266: --- I am curious what the state of this is. It is stil

[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168489#comment-16168489 ] ASF GitHub Bot commented on FLINK-7402: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7625) typo in docs metrics sections

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168490#comment-16168490 ] ASF GitHub Bot commented on FLINK-7625: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7494) No license headers in ".travis.yml" file

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168491#comment-16168491 ] ASF GitHub Bot commented on FLINK-7494: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4575: [FLINK-7494][travis] Add license headers to '.trav...

2017-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4575 ---

[GitHub] flink pull request #4676: [FLINK-7625] Fix typo in metrics part of documents

2017-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4676 ---

[GitHub] flink pull request #4641: [hotfix][docs] Fix a typo on log name for quick st...

2017-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4641 ---

[jira] [Updated] (FLINK-7402) Ineffective null check in NettyMessage#write()

2017-09-15 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-7402: -- Fix Version/s: 1.4.0 > Ineffective null check in NettyMessage#write() >

[GitHub] flink pull request #4562: [FLINK-7402] Fix ineffective null check in NettyMe...

2017-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4562 ---

[jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168434#comment-16168434 ] ASF GitHub Bot commented on FLINK-7491: --- Github user suez1224 commented on a diff in

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-15 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r139237307 --- Diff: flink-core/pom.xml --- @@ -80,6 +80,13 @@ under the License. + +

[jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168430#comment-16168430 ] ASF GitHub Bot commented on FLINK-7491: --- Github user suez1224 commented on a diff in

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-15 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r139237144 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala --- @@ -211,6 +218,14 @@ class FlinkTypeFactory(

[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168414#comment-16168414 ] ASF GitHub Bot commented on FLINK-7402: --- Github user greghogan commented on the issu

[GitHub] flink issue #4562: [FLINK-7402] Fix ineffective null check in NettyMessage#w...

2017-09-15 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4562 Merging ... ---

[jira] [Commented] (FLINK-7625) typo in docs metrics sections

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168395#comment-16168395 ] ASF GitHub Bot commented on FLINK-7625: --- Github user greghogan commented on the issu

[GitHub] flink issue #4676: [FLINK-7625] Fix typo in metrics part of documents

2017-09-15 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4676 Merging ... ---

[GitHub] flink issue #4575: [FLINK-7494][travis] Add license headers to '.travis.yml'...

2017-09-15 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4575 Merging ... ---

[jira] [Commented] (FLINK-7494) No license headers in ".travis.yml" file

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168337#comment-16168337 ] ASF GitHub Bot commented on FLINK-7494: --- Github user greghogan commented on the issu

[GitHub] flink issue #4641: [hotfix][docs] Fix a typo on log name for quick start gui...

2017-09-15 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4641 Merging ... ---

[jira] [Commented] (FLINK-7606) CEP operator leaks state

2017-09-15 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168158#comment-16168158 ] Kostas Kloudas commented on FLINK-7606: --- Now that I think about it, can you check yo

[jira] [Comment Edited] (FLINK-7606) CEP operator leaks state

2017-09-15 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168099#comment-16168099 ] Kostas Kloudas edited comment on FLINK-7606 at 9/15/17 4:38 PM:

[jira] [Commented] (FLINK-7606) CEP operator leaks state

2017-09-15 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168099#comment-16168099 ] Kostas Kloudas commented on FLINK-7606: --- Also, on another note, I read that you have

[jira] [Commented] (FLINK-7606) CEP operator leaks state

2017-09-15 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168090#comment-16168090 ] Kostas Kloudas commented on FLINK-7606: --- Yes [~i...@paolorendano.it]. This holds for

[jira] [Commented] (FLINK-7410) Use toString method to display operator names for UserDefinedFunction

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168072#comment-16168072 ] ASF GitHub Bot commented on FLINK-7410: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #4624: [FLINK-7410] [table] Use toString method to displa...

2017-09-15 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4624#discussion_r139187009 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala --- @@ -41,7 +41,7 @@ abstract class UserD

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-15 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139186699 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java --- @@ -115,6 +115,13 @@ public Configuration ge

[jira] [Commented] (FLINK-6864) Remove confusing "invalid POJO type" messages from TypeExtractor

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168055#comment-16168055 ] ASF GitHub Bot commented on FLINK-6864: --- Github user greghogan commented on a diff i

[jira] [Commented] (FLINK-6864) Remove confusing "invalid POJO type" messages from TypeExtractor

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168056#comment-16168056 ] ASF GitHub Bot commented on FLINK-6864: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #4574: [FLINK-6864] Fix confusing "invalid POJO type" mes...

2017-09-15 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4574#discussion_r139185112 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -1900,7 +1900,8 @@ private boolean isValidPojoField(Field

[GitHub] flink pull request #4574: [FLINK-6864] Fix confusing "invalid POJO type" mes...

2017-09-15 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4574#discussion_r139184023 --- Diff: docs/dev/types_serialization.md --- @@ -115,6 +115,8 @@ conditions are fulfilled: or have a public getter- and a setter- method that follow

[jira] [Commented] (FLINK-7606) CEP operator leaks state

2017-09-15 Thread Paolo Rendano (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168025#comment-16168025 ] Paolo Rendano commented on FLINK-7606: -- Hi [~kkl0u], from your comment I understand t

[jira] [Closed] (FLINK-7273) Gelly tests with empty graphs

2017-09-15 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-7273. - Resolution: Fixed master: 9437a0ffc04318f6a1a2d19c59f2ae6651b26507 > Gelly tests with empty graphs >

[jira] [Updated] (FLINK-7199) Graph simplification does not set parallelism

2017-09-15 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-7199: -- Fix Version/s: 1.4.0 > Graph simplification does not set parallelism > -

[jira] [Closed] (FLINK-7199) Graph simplification does not set parallelism

2017-09-15 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-7199. - Resolution: Fixed master: 2ac09c084320f1803c623c719dca8b4776c8110f > Graph simplification does not set pa

[jira] [Commented] (FLINK-7447) Hope add more committer information to "Community & Project Info" page.

2017-09-15 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167976#comment-16167976 ] Greg Hogan commented on FLINK-7447: --- The timezone is of little benefit for real-time com

[jira] [Commented] (FLINK-7563) Fix watermark semantics in CEP operators

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167967#comment-16167967 ] ASF GitHub Bot commented on FLINK-7563: --- Github user yestinchen commented on the iss

[GitHub] flink issue #4632: [FLINK-7563] [cep] Fix watermark semantics in cep and rel...

2017-09-15 Thread yestinchen
Github user yestinchen commented on the issue: https://github.com/apache/flink/pull/4632 I added the test case to the `CEP Operator` and addressed the line. Thanks so much. ---

[jira] [Commented] (FLINK-7630) Allow passing a File or an InputStream to ParameterTool.fromPropertiesFile()

2017-09-15 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167955#comment-16167955 ] Wei-Che Wei commented on FLINK-7630: Hi [~aljoscha] FYI. If there is any feedback, ple

[jira] [Commented] (FLINK-7606) CEP operator leaks state

2017-09-15 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167954#comment-16167954 ] Kostas Kloudas commented on FLINK-7606: --- It should be cleared. In event time, we d

[jira] [Created] (FLINK-7630) Allow passing a File or an InputStream to ParameterTool.fromPropertiesFile()

2017-09-15 Thread Wei-Che Wei (JIRA)
Wei-Che Wei created FLINK-7630: -- Summary: Allow passing a File or an InputStream to ParameterTool.fromPropertiesFile() Key: FLINK-7630 URL: https://issues.apache.org/jira/browse/FLINK-7630 Project: Flink

[GitHub] flink pull request #4346: [FLINK-7199] [gelly] Graph simplification does not...

2017-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4346 ---

[jira] [Commented] (FLINK-7199) Graph simplification does not set parallelism

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167895#comment-16167895 ] ASF GitHub Bot commented on FLINK-7199: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4405: [FLINK-7273] [gelly] Gelly tests with empty graphs

2017-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4405 ---

[jira] [Commented] (FLINK-7273) Gelly tests with empty graphs

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167896#comment-16167896 ] ASF GitHub Bot commented on FLINK-7273: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139111867 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167875#comment-16167875 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167873#comment-16167873 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167878#comment-16167878 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167877#comment-16167877 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167871#comment-16167871 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r138918828 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167870#comment-16167870 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167872#comment-16167872 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139149693 --- Diff: flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/wordcount/WordCount.scala --- @@ -49,6 +51,8 @@ object WordCoun

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r138919667 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167880#comment-16167880 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167876#comment-16167876 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167881#comment-16167881 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139113529 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139109060 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r138919099 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139112514 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139150623 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/Types.scala --- @@ -0,0 +1,363 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167866#comment-16167866 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167868#comment-16167868 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139150559 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/Types.scala --- @@ -0,0 +1,363 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139148230 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r138921417 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167867#comment-16167867 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139112027 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139150367 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/Types.scala --- @@ -20,60 +20,123 @@ package org.apache.flink.table.api

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167869#comment-16167869 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139113352 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167874#comment-16167874 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167879#comment-16167879 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-09-15 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r139109685 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[GitHub] flink issue #4673: [hotfix] [cep] Fix afterMatchStrategy parameter missing i...

2017-09-15 Thread yestinchen
Github user yestinchen commented on the issue: https://github.com/apache/flink/pull/4673 Hi @dawidwys , Thanks for the tip, that's what I tried to add. Sorry for the missing times(). ---

[jira] [Commented] (FLINK-7567) DataStream#iterate() on env.fromElements() / env.fromCollection() does not work

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167804#comment-16167804 ] ASF GitHub Bot commented on FLINK-7567: --- Github user aljoscha commented on the issue

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-15 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4655 Thanks! This doesn't help us with our situation, though. ---

[jira] [Commented] (FLINK-7567) DataStream#iterate() on env.fromElements() / env.fromCollection() does not work

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167800#comment-16167800 ] ASF GitHub Bot commented on FLINK-7567: --- Github user mlipkovich commented on the iss

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-15 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 Thansk, Aljoscha Probably I've forgotten to run `clean`. The method `iterate$default$3` is a method which automatically created by Scala for calculation of default value for parameter `ke

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167791#comment-16167791 ] ASF GitHub Bot commented on FLINK-7378: --- Github user zhijiangW commented on the issu

[GitHub] flink issue #4485: [FLINK-7378][core]Create a fix size (non rebalancing) buf...

2017-09-15 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4485 @NicoK , I have submitted the updates. ---

[jira] [Assigned] (FLINK-4498) Better Cassandra sink documentation

2017-09-15 Thread Michael Fong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Fong reassigned FLINK-4498: --- Assignee: Michael Fong > Better Cassandra sink documentation > --

[GitHub] flink issue #4665: [Flink-7611]add metrics to measure the num of data droppe...

2017-09-15 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/4665 @aljoscha yes, i review the code this day, it will jude each window whether late , so the previous method i use will counts more lost data than the actual situation , i have fix the error and re-push

[jira] [Created] (FLINK-7629) Scala stream aggregations should support nested field expressions

2017-09-15 Thread Gabor Gevay (JIRA)
Gabor Gevay created FLINK-7629: -- Summary: Scala stream aggregations should support nested field expressions Key: FLINK-7629 URL: https://issues.apache.org/jira/browse/FLINK-7629 Project: Flink

[jira] [Commented] (FLINK-7567) DataStream#iterate() on env.fromElements() / env.fromCollection() does not work

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167685#comment-16167685 ] ASF GitHub Bot commented on FLINK-7567: --- Github user aljoscha commented on the issue

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-15 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4655 A local build of `mvn clean verify` fails for me because the japicmp plugin is complaining. The relevant section of the diff output from japicmp is ``` ***! MODIFIED CLASS: PUBLIC org.apache.

[jira] [Closed] (FLINK-4796) Add new Sink interface with access to more meta data

2017-09-15 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-4796. --- Resolution: Won't Fix Introducing a new SinkInterface will make the workaround of the hybrid p

[jira] [Reopened] (FLINK-4796) Add new Sink interface with access to more meta data

2017-09-15 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reopened FLINK-4796: - > Add new Sink interface with access to more meta data > -

[jira] [Commented] (FLINK-7563) Fix watermark semantics in CEP operators

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167644#comment-16167644 ] ASF GitHub Bot commented on FLINK-7563: --- Github user dawidwys commented on the issue

[jira] [Commented] (FLINK-7589) org.apache.http.ConnectionClosedException: Premature end of Content-Length delimited message body (expected: 159764230; received: 64638536)

2017-09-15 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167643#comment-16167643 ] Aljoscha Krettek commented on FLINK-7589: - I don't think we want to do that, no. H

[GitHub] flink issue #4632: [FLINK-7563] [cep] Fix watermark semantics in cep and rel...

2017-09-15 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4632 Hi @yestinchen, Thanks for working on this issue. Unfortunately your changes do not fix the semantics. Have a look at this failing test: @Test public void testCEPWatermarkSem

[jira] [Commented] (FLINK-4814) Remove extra storage location for externalized checkpoint metadata

2017-09-15 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167638#comment-16167638 ] Aljoscha Krettek commented on FLINK-4814: - Yes, those are things I'm aware of and

[jira] [Commented] (FLINK-7606) CEP operator leaks state

2017-09-15 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167635#comment-16167635 ] Aljoscha Krettek commented on FLINK-7606: - How do you mean? They could get the tim

[GitHub] flink issue #4673: [hotfix] [cep] Fix afterMatchStrategy parameter missing i...

2017-09-15 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4673 Hi @yestinchen , thanks for spotting the mistake. Good catch. However the test you provided does not prove the fix. It passes with and without the fix. Please correct it. You can e.g. extend the

[GitHub] flink issue #4665: [Flink-7611]add metrics to measure the num of data droppe...

2017-09-15 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4665 @Aitozi I meant that the place where you're currently counting dropped elements will not yield a correct count because one element might be in several windows. The place were we side-output late dat

[jira] [Commented] (FLINK-7394) Implement basic InputChannel for credit-based logic

2017-09-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167593#comment-16167593 ] ASF GitHub Bot commented on FLINK-7394: --- Github user NicoK commented on a diff in th

  1   2   >