JingsongLi commented on issue #8066: [FLINK-12041][table-runtime-blink]
Introduce ResettableExternalBuffer to blink batch
URL: https://github.com/apache/flink/pull/8066#issuecomment-478444601
Hi @KurtYoung , I redesigned the API of `ResettableExternalBuffer`, which
now forces users to
carp84 commented on issue #8076: [FLINK-12064] [core, State Backends]
RocksDBKeyedStateBackend snapshot uses incorrect key serializer if reconfigure
happens during restore
URL: https://github.com/apache/flink/pull/8076#issuecomment-478444696
Thanks for the review! @tzulitai
sunjincheng121 commented on issue #8057: [FLINK-12028][table] Add
`addColumns`,`renameColumns`, `dropColumns` …
URL: https://github.com/apache/flink/pull/8057#issuecomment-478434229
Hi, @dawidwys thanks for your valuable comments. I have updated the PR with
the following changes:
tzulitai commented on issue #8078: [FLINK-12066] [State Backends] Remove
StateSerializerProvider field in keyed state backends
URL: https://github.com/apache/flink/pull/8078#issuecomment-478433308
FLINK-12066 has been merged. Can you do a rebase @carp84?
godfreyhe commented on a change in pull request #8088:
[FLINK-12073][table-planner-blink] Support appropriate precision and scale
processing of Decimal
URL: https://github.com/apache/flink/pull/8088#discussion_r270713865
##
File path:
[
https://issues.apache.org/jira/browse/FLINK-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai closed FLINK-12064.
---
Resolution: Fixed
Thanks for the fix [~carp84].
Merged with the following commits:
KurtYoung commented on a change in pull request #8051: [FLINK-12018]
[table-planner-blink] Add support for generating optimized logical plan for
Sort and Rank
URL: https://github.com/apache/flink/pull/8051#discussion_r270713589
##
File path:
asfgit closed pull request #8076: [FLINK-12064] [core, State Backends]
RocksDBKeyedStateBackend snapshot uses incorrect key serializer if reconfigure
happens during restore
URL: https://github.com/apache/flink/pull/8076
tzulitai commented on issue #8076: [FLINK-12064] [core, State Backends]
RocksDBKeyedStateBackend snapshot uses incorrect key serializer if reconfigure
happens during restore
URL: https://github.com/apache/flink/pull/8076#issuecomment-478430244
Thanks for the fix @carp84.
I've
tzulitai edited a comment on issue #8076: [FLINK-12064] [core, State Backends]
RocksDBKeyedStateBackend snapshot uses incorrect key serializer if reconfigure
happens during restore
URL: https://github.com/apache/flink/pull/8076#issuecomment-478430244
Thanks for the fix @carp84.
flinkbot edited a comment on issue #8076: [FLINK-12064] [core, State Backends]
RocksDBKeyedStateBackend snapshot uses incorrect key serializer if reconfigure
happens during restore
URL: https://github.com/apache/flink/pull/8076#issuecomment-477950902
Thanks a lot for your contribution to
tzulitai commented on issue #8076: [FLINK-12064] [core, State Backends]
RocksDBKeyedStateBackend snapshot uses incorrect key serializer if reconfigure
happens during restore
URL: https://github.com/apache/flink/pull/8076#issuecomment-478430324
@flinkbot approve all
bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add
ReadableCatalog, ReadableWritableCatalog, and other …
URL: https://github.com/apache/flink/pull/8007#discussion_r270710243
##
File path:
bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add
ReadableCatalog, ReadableWritableCatalog, and other …
URL: https://github.com/apache/flink/pull/8007#discussion_r270710433
##
File path:
bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add
ReadableCatalog, ReadableWritableCatalog, and other …
URL: https://github.com/apache/flink/pull/8007#discussion_r270711602
##
File path:
godfreyhe commented on a change in pull request #8051: [FLINK-12018]
[table-planner-blink] Add support for generating optimized logical plan for
Sort and Rank
URL: https://github.com/apache/flink/pull/8051#discussion_r270710882
##
File path:
flinkbot commented on issue #8089: [FLINK-11985][DOC] Remove ignored command
line parameter from yarn_setup.md
URL: https://github.com/apache/flink/pull/8089#issuecomment-478423734
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
guoweiM opened a new pull request #8089: [FLINK-11985][DOC] Remove ignored
command line parameter from yarn_setup.md
URL: https://github.com/apache/flink/pull/8089
1. remove ignored "-n" parameter from yarn_setup.md documentation.
2. fix command line arguments of WordCount example in
[
https://issues.apache.org/jira/browse/FLINK-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-11985:
---
Labels: pull-request-available (was: )
> Remove ignored command line parameter from
[
https://issues.apache.org/jira/browse/FLINK-12074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sunjincheng closed FLINK-12074.
---
Resolution: Fixed
Already hotfix by aafc881.
> Fix typo in `flinkDev/building.md`
>
JingsongLi commented on a change in pull request #8088:
[FLINK-12073][table-planner-blink] Support appropriate precision and scale
processing of Decimal
URL: https://github.com/apache/flink/pull/8088#discussion_r270706008
##
File path:
godfreyhe commented on issue #8051: [FLINK-12018] [table-planner-blink] Add
support for generating optimized logical plan for Sort and Rank
URL: https://github.com/apache/flink/pull/8051#issuecomment-478419996
> > > > > Thanks for the refactoring and simplification. But it seems the
name
sunjincheng created FLINK-12074:
---
Summary: Fix typo in `flinkDev/building.md`
Key: FLINK-12074
URL: https://issues.apache.org/jira/browse/FLINK-12074
Project: Flink
Issue Type: Bug
godfreyhe commented on a change in pull request #8051: [FLINK-12018]
[table-planner-blink] Add support for generating optimized logical plan for
Sort and Rank
URL: https://github.com/apache/flink/pull/8051#discussion_r270705603
##
File path:
godfreyhe commented on a change in pull request #8051: [FLINK-12018]
[table-planner-blink] Add support for generating optimized logical plan for
Sort and Rank
URL: https://github.com/apache/flink/pull/8051#discussion_r270703894
##
File path:
KurtYoung commented on issue #8051: [FLINK-12018] [table-planner-blink] Add
support for generating optimized logical plan for Sort and Rank
URL: https://github.com/apache/flink/pull/8051#issuecomment-478418966
> > > > Thanks for the refactoring and simplification. But it seems the name
KurtYoung commented on a change in pull request #8088:
[FLINK-12073][table-planner-blink] Support appropriate precision and scale
processing of Decimal
URL: https://github.com/apache/flink/pull/8088#discussion_r270705006
##
File path:
godfreyhe commented on issue #8051: [FLINK-12018] [table-planner-blink] Add
support for generating optimized logical plan for Sort and Rank
URL: https://github.com/apache/flink/pull/8051#issuecomment-478418449
> > > Thanks for the refactoring and simplification. But it seems the name
KurtYoung commented on issue #8051: [FLINK-12018] [table-planner-blink] Add
support for generating optimized logical plan for Sort and Rank
URL: https://github.com/apache/flink/pull/8051#issuecomment-478417912
> > Thanks for the refactoring and simplification. But it seems the name
godfreyhe commented on a change in pull request #8051: [FLINK-12018]
[table-planner-blink] Add support for generating optimized logical plan for
Sort and Rank
URL: https://github.com/apache/flink/pull/8051#discussion_r270703894
##
File path:
godfreyhe commented on issue #8051: [FLINK-12018] [table-planner-blink] Add
support for generating optimized logical plan for Sort and Rank
URL: https://github.com/apache/flink/pull/8051#issuecomment-478416766
> Thanks for the refactoring and simplification. But it seems the name
flinkbot edited a comment on issue #7819: [FLINK-11313][checkpoint] Introduce
LZ4 compression for keyed state in full checkpoints and savepoints
URL: https://github.com/apache/flink/pull/7819#issuecomment-466941584
Thanks a lot for your contribution to the Apache Flink project. I'm the
Myasuka commented on issue #7819: [FLINK-11313][checkpoint] Introduce LZ4
compression for keyed state in full checkpoints and savepoints
URL: https://github.com/apache/flink/pull/7819#issuecomment-478413470
Since Yu has completed refactoring the builder of state backend, I have to
rebase
godfreyhe commented on a change in pull request #8051: [FLINK-12018]
[table-planner-blink] Add support for generating optimized logical plan for
Sort and Rank
URL: https://github.com/apache/flink/pull/8051#discussion_r270701308
##
File path:
[
https://issues.apache.org/jira/browse/FLINK-12073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-12073:
---
Labels: pull-request-available (was: )
> Support appropriate precision and scale
JingsongLi opened a new pull request #8088: [FLINK-12073][table-planner-blink]
Support appropriate precision and scale processing of Decimal
URL: https://github.com/apache/flink/pull/8088
## What is the purpose of the change
1.Make Decimal's output more precise than random.
2.Let
flinkbot commented on issue #8088: [FLINK-12073][table-planner-blink] Support
appropriate precision and scale processing of Decimal
URL: https://github.com/apache/flink/pull/8088#issuecomment-478412391
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I
Jingsong Lee created FLINK-12073:
Summary: Support appropriate precision and scale processing of
Decimal in Blink SQL
Key: FLINK-12073
URL: https://issues.apache.org/jira/browse/FLINK-12073
Project:
godfreyhe commented on a change in pull request #8051: [FLINK-12018]
[table-planner-blink] Add support for generating optimized logical plan for
Sort and Rank
URL: https://github.com/apache/flink/pull/8051#discussion_r270699783
##
File path:
JingsongLi commented on issue #8066: [FLINK-12041][table-runtime-blink]
Introduce ResettableExternalBuffer to blink batch
URL: https://github.com/apache/flink/pull/8066#issuecomment-478409524
> Looks like we have found some design bugs, will continue this after we
solve them.
I
godfreyhe commented on a change in pull request #8051: [FLINK-12018]
[table-planner-blink] Add support for generating optimized logical plan for
Sort and Rank
URL: https://github.com/apache/flink/pull/8051#discussion_r270699044
##
File path:
sravankorumilli edited a comment on issue #8085: [FLINK-12072] Change asyncio
operator name without whitespaces to help capture the metrics properly
URL: https://github.com/apache/flink/pull/8085#issuecomment-478355981
Thanks Myasuka for helping me to take a deeper look, I looked into the
sravankorumilli edited a comment on issue #8085: [FLINK-12072] Change asyncio
operator name without whitespaces to help capture the metrics properly
URL: https://github.com/apache/flink/pull/8085#issuecomment-478355981
Thanks Myasuka for helping me to take a deeper look, I looked into the
sravankorumilli edited a comment on issue #8085: [FLINK-12072] Change asyncio
operator name without whitespaces to help capture the metrics properly
URL: https://github.com/apache/flink/pull/8085#issuecomment-478355981
Thanks Myasuka for helping me to take a deeper look, I looked into the
sravankorumilli commented on issue #8085: [FLINK-12072] Change asyncio operator
name without whitespaces to help capture the metrics properly
URL: https://github.com/apache/flink/pull/8085#issuecomment-478355981
Thanks Myasuka for helping me to take a deeper look, I have looked into the
flinkbot commented on issue #8087: [FLINK-12029][table] Add column operations
for TableApi
URL: https://github.com/apache/flink/pull/8087#issuecomment-478332056
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull
[
https://issues.apache.org/jira/browse/FLINK-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-12029:
---
Labels: pull-request-available (was: )
> Add Column selections
> -
>
>
hequn8128 opened a new pull request #8087: [FLINK-12029][table] Add column
operations for TableApi
URL: https://github.com/apache/flink/pull/8087
## What is the purpose of the change
This pull request adds column operations for TableApi. Column oprations can
be used to select
[
https://issues.apache.org/jira/browse/FLINK-10819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806094#comment-16806094
]
Yu Li commented on FLINK-10819:
---
Two questions about issue here:
1. Why are we using scala
carp84 edited a comment on issue #8078: [FLINK-12066] [State Backends] Remove
StateSerializerProvider field in keyed state backends
URL: https://github.com/apache/flink/pull/8078#issuecomment-478324944
Checked travis build and confirmed the failure is a known issue
[
https://issues.apache.org/jira/browse/FLINK-10819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806091#comment-16806091
]
Yu Li commented on FLINK-10819:
---
Another instance: https://api.travis-ci.org/v3/job/513408208/log.txt
flinkbot commented on issue #8086: [FLINK-12062][table-runtime-blink] Introduce
bundle operator to streaming table runtime
URL: https://github.com/apache/flink/pull/8086#issuecomment-478325236
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the
KurtYoung opened a new pull request #8086: [FLINK-12062][table-runtime-blink]
Introduce bundle operator to streaming table runtime
URL: https://github.com/apache/flink/pull/8086
## What is the purpose of the change
Introducing bundle operator to streaming table runtime,
[
https://issues.apache.org/jira/browse/FLINK-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-12062:
---
Labels: pull-request-available (was: )
> Introduce bundle operator to streaming table
carp84 commented on issue #8078: [FLINK-12066] [State Backends] Remove
StateSerializerProvider field in keyed state backends
URL: https://github.com/apache/flink/pull/8078#issuecomment-478324944
Checked travis build and confirmed the failure is irrelative to change here.
Also verified the
flinkbot commented on issue #8085: [FLINK-12072] Change asyncio operator name
without whitespaces to help capture the metrics properly
URL: https://github.com/apache/flink/pull/8085#issuecomment-478322112
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I
sravankorumilli opened a new pull request #8085: [FLINK-12072] Change asyncio
operator name without whitespaces to help capture the metrics properly
URL: https://github.com/apache/flink/pull/8085
## What is the purpose of the change
*(For example: This pull request
[
https://issues.apache.org/jira/browse/FLINK-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-12072:
---
Labels: pull-request-available (was: )
> Unable to Capture Metrics of AsyncIO
>
[
https://issues.apache.org/jira/browse/FLINK-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sravan.korumilli updated FLINK-12072:
-
Description:
Failing to capture the metrics for AsyncIO - ordered or unorderd wait
[
https://issues.apache.org/jira/browse/FLINK-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sravan.korumilli updated FLINK-12072:
-
Description:
Failing to capture the metrics for AsyncIO - ordered or unorderd wait
[
https://issues.apache.org/jira/browse/FLINK-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-12020:
---
Labels: pull-request-available (was: )
> Add documentation for mesos-appmaster-job.sh
>
flinkbot commented on issue #8084: [FLINK-12020] [docs] Add documentation for
mesos-appmaster-job.sh
URL: https://github.com/apache/flink/pull/8084#issuecomment-478319913
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review
yinchuanwang opened a new pull request #8084: [FLINK-12020] [docs] Add
documentation for mesos-appmaster-job.sh
URL: https://github.com/apache/flink/pull/8084
1. Rename the section title from `standalone` to `Flink session cluster on
Mesos`.
2. Add one new section `Flink job cluster on
[
https://issues.apache.org/jira/browse/FLINK-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sravan.korumilli updated FLINK-12072:
-
Description:
Failing to capture the metrics for AsyncIO - ordered or unorderd wait
[
https://issues.apache.org/jira/browse/FLINK-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806068#comment-16806068
]
sravan.korumilli edited comment on FLINK-12072 at 3/31/19 6:59 AM:
---
[
https://issues.apache.org/jira/browse/FLINK-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806068#comment-16806068
]
sravan.korumilli edited comment on FLINK-12072 at 3/31/19 6:59 AM:
---
[
https://issues.apache.org/jira/browse/FLINK-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806068#comment-16806068
]
sravan.korumilli commented on FLINK-12072:
--
Using an operator name without spaces
sravan.korumilli created FLINK-12072:
Summary: Unable to Capture Metrics of AsyncIO
Key: FLINK-12072
URL: https://issues.apache.org/jira/browse/FLINK-12072
Project: Flink
Issue Type: Bug
68 matches
Mail list logo
