[jira] [Commented] (FLINK-12836) Allow retained checkpoints to be persisted on success

2019-06-13 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863755#comment-16863755 ] vinoyang commented on FLINK-12836: -- Let's listen to [~till.rohrmann]'s opinion? > Allo

[GitHub] [flink] leesf commented on issue #8716: [FLINK-12800] Harden Tests when availableProcessors is 1

2019-06-13 Thread GitBox
leesf commented on issue #8716: [FLINK-12800] Harden Tests when availableProcessors is 1 URL: https://github.com/apache/flink/pull/8716#issuecomment-501991501 @tillrohrmann Sorry for causing you trouble with my mistake, the last force push just aimed to re-trigger the travis, I will pay at

[GitHub] [flink] tillrohrmann closed pull request #8716: [FLINK-12800] Harden Tests when availableProcessors is 1

2019-06-13 Thread GitBox
tillrohrmann closed pull request #8716: [FLINK-12800] Harden Tests when availableProcessors is 1 URL: https://github.com/apache/flink/pull/8716 This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Resolved] (FLINK-12800) Harden Tests when availableProcessors is 1

2019-06-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-12800. --- Resolution: Fixed Fixed via 3fa062a8ad9cfbbef23adbfb3ad1406a68afb3eb > Harden Tests when av

[GitHub] [flink] tillrohrmann commented on issue #8716: [FLINK-12800] Harden Tests when availableProcessors is 1

2019-06-13 Thread GitBox
tillrohrmann commented on issue #8716: [FLINK-12800] Harden Tests when availableProcessors is 1 URL: https://github.com/apache/flink/pull/8716#issuecomment-501989831 Test failure is unrelated. Merging. Small side note, please don't force push after I've said that I merge this PR. T

[jira] [Commented] (FLINK-12071) HadoopRecoverableWriterTest fails on Travis

2019-06-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863744#comment-16863744 ] Till Rohrmann commented on FLINK-12071: --- Another instance of {{HadoopRecoverableWr

[jira] [Updated] (FLINK-12071) HadoopRecoverableWriterTest fails on Travis

2019-06-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12071: -- Labels: test-stability (was: ) > HadoopRecoverableWriterTest fails on Travis > --

[jira] [Updated] (FLINK-12071) HadoopRecoverableWriterTest fails on Travis

2019-06-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12071: -- Priority: Critical (was: Major) > HadoopRecoverableWriterTest fails on Travis > -

[GitHub] [flink] docete commented on issue #8722: [FLINK-9854][sql-client] Allow passing multi-line input to SQL Client…

2019-06-13 Thread GitBox
docete commented on issue #8722: [FLINK-9854][sql-client] Allow passing multi-line input to SQL Client… URL: https://github.com/apache/flink/pull/8722#issuecomment-501988642 This PR associates wrong JIRA issue by mistake. Thi

[GitHub] [flink] docete closed pull request #8722: [FLINK-9854][sql-client] Allow passing multi-line input to SQL Client…

2019-06-13 Thread GitBox
docete closed pull request #8722: [FLINK-9854][sql-client] Allow passing multi-line input to SQL Client… URL: https://github.com/apache/flink/pull/8722 This is an automated message from the Apache Git Service. To respond to

[jira] [Closed] (FLINK-12313) SynchronousCheckpointITCase.taskCachedThreadPoolAllowsForSynchronousCheckpoints is unstable

2019-06-13 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-12313. -- Resolution: Fixed Fix Version/s: 1.9.0 merged commit c539333 into apache:master > Sync

[GitHub] [flink] pnowojski commented on issue #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test

2019-06-13 Thread GitBox
pnowojski commented on issue #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test URL: https://github.com/apache/flink/pull/8602#issuecomment-501987043 Travis is green, merging. This

[GitHub] [flink] pnowojski merged pull request #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test

2019-06-13 Thread GitBox
pnowojski merged pull request #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test URL: https://github.com/apache/flink/pull/8602 This is an automated message from the Apache Git Se

[jira] [Created] (FLINK-12845) Execute multiple statements in command line or sql script file

2019-06-13 Thread Zhenghua Gao (JIRA)
Zhenghua Gao created FLINK-12845: Summary: Execute multiple statements in command line or sql script file Key: FLINK-12845 URL: https://issues.apache.org/jira/browse/FLINK-12845 Project: Flink

[jira] [Assigned] (FLINK-12818) Improve stability of twoInputMapSink benchmark

2019-06-13 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-12818: -- Assignee: (was: Piotr Nowojski) My attempt to fix the issue has failed. Benchmark

[jira] [Commented] (FLINK-12071) HadoopRecoverableWriterTest fails on Travis

2019-06-13 Thread leesf (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863733#comment-16863733 ] leesf commented on FLINK-12071: --- [https://api.travis-ci.org/v3/job/545533041/log.txt] {cod

[GitHub] [flink] lirui-apache commented on issue #8694: [FLINK-12705][hive] Allow user to specify the Hive version in use

2019-06-13 Thread GitBox
lirui-apache commented on issue #8694: [FLINK-12705][hive] Allow user to specify the Hive version in use URL: https://github.com/apache/flink/pull/8694#issuecomment-501982228 @bowenli86 thanks for your comments. Please take another look.

[jira] [Created] (FLINK-12844) Use default conversion class LocalDate/LocalTime/LocalDateTime for DateType/TimeType/TimestampType in blink

2019-06-13 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12844: Summary: Use default conversion class LocalDate/LocalTime/LocalDateTime for DateType/TimeType/TimestampType in blink Key: FLINK-12844 URL: https://issues.apache.org/jira/browse/FL

[GitHub] [flink] liyafan82 commented on issue #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
liyafan82 commented on issue #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#issuecomment-501976712 > > Can you please provide the benchmark that produces the 10x performance imp

[GitHub] [flink] sunjincheng121 edited a comment on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots

2019-06-13 Thread GitBox
sunjincheng121 edited a comment on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots URL: https://github.com/apache/flink/pull/7227#issuecomment-501973070 ![image](https://user-images.githubusercontent.com/22488084/59485314-e2f68480-8ea7-11e9-9376-a48720a2

[GitHub] [flink] JingsongLi commented on issue #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
JingsongLi commented on issue #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#issuecomment-501973780 > Can you please provide the benchmark that produces the 10x performance impr

[GitHub] [flink] sunjincheng121 edited a comment on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots

2019-06-13 Thread GitBox
sunjincheng121 edited a comment on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots URL: https://github.com/apache/flink/pull/7227#issuecomment-501973070 ![image](https://user-images.githubusercontent.com/22488084/59485314-e2f68480-8ea7-11e9-9376-a48720a2

[GitHub] [flink] sunjincheng121 commented on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots

2019-06-13 Thread GitBox
sunjincheng121 commented on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots URL: https://github.com/apache/flink/pull/7227#issuecomment-501973070 ![image](https://user-images.githubusercontent.com/22488084/59485314-e2f68480-8ea7-11e9-9376-a48720a27a22.pn

[GitHub] [flink] docete commented on issue #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner

2019-06-13 Thread GitBox
docete commented on issue #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner URL: https://github.com/apache/flink/pull/8707#issuecomment-501971743 +1 LGTM, leave a comment about CatalogView expanding.

[GitHub] [flink] docete commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner

2019-06-13 Thread GitBox
docete commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner URL: https://github.com/apache/flink/pull/8707#discussion_r293660477 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/

[GitHub] [flink] zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions

2019-06-13 Thread GitBox
zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions URL: https://github.com/apache/flink/pull/8654#discussion_r293656023 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/

[jira] [Created] (FLINK-12843) Refactor the pin logic in ResultPartition

2019-06-13 Thread zhijiang (JIRA)
zhijiang created FLINK-12843: Summary: Refactor the pin logic in ResultPartition Key: FLINK-12843 URL: https://issues.apache.org/jira/browse/FLINK-12843 Project: Flink Issue Type: Sub-task

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8732: [FLINK-12720][python] Add the Python Table API Sphinx docs

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8732: [FLINK-12720][python] Add the Python Table API Sphinx docs URL: https://github.com/apache/flink/pull/8732#discussion_r293653787 ## File path: flink-python/docs/conf.py ## @@ -0,0 +1,208 @@ +###

[jira] [Created] (FLINK-12842) Fix invalid check released state during ResultPartition#createSubpartitionView

2019-06-13 Thread zhijiang (JIRA)
zhijiang created FLINK-12842: Summary: Fix invalid check released state during ResultPartition#createSubpartitionView Key: FLINK-12842 URL: https://issues.apache.org/jira/browse/FLINK-12842 Project: Flink

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r293653903 ## File path: flink-table/flink-table-runtime-blin

[GitHub] [flink] dianfu commented on a change in pull request #8732: [FLINK-12720][python] Add the Python Table API Sphinx docs

2019-06-13 Thread GitBox
dianfu commented on a change in pull request #8732: [FLINK-12720][python] Add the Python Table API Sphinx docs URL: https://github.com/apache/flink/pull/8732#discussion_r293650042 ## File path: flink-python/docs/pyflink.rst ## @@ -0,0 +1,33 @@ +..

[GitHub] [flink] dianfu commented on a change in pull request #8732: [FLINK-12720][python] Add the Python Table API Sphinx docs

2019-06-13 Thread GitBox
dianfu commented on a change in pull request #8732: [FLINK-12720][python] Add the Python Table API Sphinx docs URL: https://github.com/apache/flink/pull/8732#discussion_r293646408 ## File path: flink-python/docs/index.rst ## @@ -0,0 +1,39 @@ +.. ##

[GitHub] [flink] dianfu commented on a change in pull request #8732: [FLINK-12720][python] Add the Python Table API Sphinx docs

2019-06-13 Thread GitBox
dianfu commented on a change in pull request #8732: [FLINK-12720][python] Add the Python Table API Sphinx docs URL: https://github.com/apache/flink/pull/8732#discussion_r293652965 ## File path: flink-python/docs/pyflink.table.rst ## @@ -0,0 +1,29 @@ +.. ##

[GitHub] [flink] liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r293652318 ## File path: flink-table/flink-table-runtime-blink

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8688: [FLINK-12760] [runtime] Implement ExecutionGraph to InputsLocationsRetriever Adapter

2019-06-13 Thread GitBox
eaglewatcherwb commented on a change in pull request #8688: [FLINK-12760] [runtime] Implement ExecutionGraph to InputsLocationsRetriever Adapter URL: https://github.com/apache/flink/pull/8688#discussion_r293652038 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/s

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8688: [FLINK-12760] [runtime] Implement ExecutionGraph to InputsLocationsRetriever Adapter

2019-06-13 Thread GitBox
eaglewatcherwb commented on a change in pull request #8688: [FLINK-12760] [runtime] Implement ExecutionGraph to InputsLocationsRetriever Adapter URL: https://github.com/apache/flink/pull/8688#discussion_r293651290 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/s

[GitHub] [flink] zjuwangg commented on issue #8636: [FLINK-12237][hive]Support Hive table stats related operations in HiveCatalog

2019-06-13 Thread GitBox
zjuwangg commented on issue #8636: [FLINK-12237][hive]Support Hive table stats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8636#issuecomment-501958031 ccc @xuefuz again to review. This is an au

[GitHub] [flink] zhijiangW commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-13 Thread GitBox
zhijiangW commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r293651140 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/partit

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions

2019-06-13 Thread GitBox
gaoyunhaii commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions URL: https://github.com/apache/flink/pull/8654#discussion_r293650869 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r293650003 ## File path: flink-table/flink-table-runtime-blin

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r293649615 ## File path: flink-table/flink-table-runtime-blin

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions

2019-06-13 Thread GitBox
gaoyunhaii commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions URL: https://github.com/apache/flink/pull/8654#discussion_r293649558 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime

[GitHub] [flink] liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r293648291 ## File path: flink-table/flink-table-runtime-blink

[GitHub] [flink] stevenzwu opened a new pull request #8665: [FLINK-12781] [Runtime/REST] include the whole stack trace in response payload

2019-06-13 Thread GitBox
stevenzwu opened a new pull request #8665: [FLINK-12781] [Runtime/REST] include the whole stack trace in response payload URL: https://github.com/apache/flink/pull/8665 This is an automated message from the Apache Gi

[GitHub] [flink] stevenzwu closed pull request #8665: [FLINK-12781] [Runtime/REST] include the whole stack trace in response payload

2019-06-13 Thread GitBox
stevenzwu closed pull request #8665: [FLINK-12781] [Runtime/REST] include the whole stack trace in response payload URL: https://github.com/apache/flink/pull/8665 This is an automated message from the Apache Git Service. To

[GitHub] [flink] liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r293648012 ## File path: flink-table/flink-table-runtime-blink

[GitHub] [flink] yanghua commented on issue #7435: [FLINK-11226] Lack of getKeySelector in Scala KeyedStream API unlike Java KeyedStream

2019-06-13 Thread GitBox
yanghua commented on issue #7435: [FLINK-11226] Lack of getKeySelector in Scala KeyedStream API unlike Java KeyedStream URL: https://github.com/apache/flink/pull/7435#issuecomment-501953286 @sunjincheng121 I have a small PR holds a long time, can you have a look? --

[jira] [Commented] (FLINK-12836) Allow retained checkpoints to be persisted on success

2019-06-13 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863647#comment-16863647 ] vinoyang commented on FLINK-12836: -- Hi [~klion26] I think {{CHECKPOINT_RETAINED_ON_CANC

[GitHub] [flink] zjuwangg commented on a change in pull request #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog

2019-06-13 Thread GitBox
zjuwangg commented on a change in pull request #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8703#discussion_r293647266 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apac

[GitHub] [flink] zhijiangW commented on issue #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions

2019-06-13 Thread GitBox
zhijiangW commented on issue #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions URL: https://github.com/apache/flink/pull/8654#issuecomment-501951296 Thanks for the updates @zentol and the reviews @tillrohrmann . I like the current way and i

[GitHub] [flink] zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions

2019-06-13 Thread GitBox
zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions URL: https://github.com/apache/flink/pull/8654#discussion_r293644729 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/

[GitHub] [flink] zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions

2019-06-13 Thread GitBox
zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions URL: https://github.com/apache/flink/pull/8654#discussion_r293645376 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/

[jira] [Reopened] (FLINK-12541) Add deploy a Python Flink job and session cluster on Kubernetes support.

2019-06-13 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng reopened FLINK-12541: - Hi [~till.rohrmann] Thanks for helping review and merge the #8609, And #8609 is relating the FLINK-

[GitHub] [flink] zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions

2019-06-13 Thread GitBox
zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions URL: https://github.com/apache/flink/pull/8654#discussion_r293644729 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/

[jira] [Closed] (FLINK-12788) Add support to run a Python job-specific cluster on Kubernetes

2019-06-13 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12788. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master: 00d90a4fe3ff93d19ff6be3ed7b9cf9d0f5b0

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r293644286 ## File path: flink-table/flink-table-runtime-blin

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293640776 ## File path: flink-python/src/main/java/org/apache/flink/python/client/PythonShellPa

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293642907 ## File path: docs/ops/python_shell.zh.md ## @@ -0,0 +1,179 @@ +--- +title:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293638255 ## File path: docs/ops/python_shell.md ## @@ -0,0 +1,185 @@ +--- +title: "Py

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293642567 ## File path: docs/ops/python_shell.zh.md ## @@ -0,0 +1,179 @@ +--- +title:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293643657 ## File path: flink-python/pyflink/shell.py ## @@ -0,0 +1,128 @@ +##

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293638505 ## File path: docs/ops/python_shell.md ## @@ -0,0 +1,185 @@ +--- +title: "Py

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293643067 ## File path: docs/ops/python_shell.zh.md ## @@ -0,0 +1,179 @@ +--- +title:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293642713 ## File path: docs/ops/python_shell.zh.md ## @@ -0,0 +1,179 @@ +--- +title:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293641314 ## File path: docs/ops/python_shell.md ## @@ -0,0 +1,185 @@ +--- +title: "Py

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293642161 ## File path: docs/ops/python_shell.md ## @@ -0,0 +1,185 @@ +--- +title: "Py

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293642781 ## File path: docs/ops/python_shell.zh.md ## @@ -0,0 +1,179 @@ +--- +title:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293642820 ## File path: docs/ops/python_shell.zh.md ## @@ -0,0 +1,179 @@ +--- +title:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293262036 ## File path: docs/ops/python_shell.zh.md ## @@ -0,0 +1,179 @@ +--- +title:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293643766 ## File path: flink-python/pyflink/shell.py ## @@ -0,0 +1,128 @@ +##

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293634615 ## File path: docs/ops/python_shell.md ## @@ -0,0 +1,185 @@ +--- +title: "Py

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-13 Thread GitBox
sunjincheng121 commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293634271 ## File path: flink-dist/src/main/flink-bin/bin/pyflink-shell.sh ## @@ -0,0

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r293643294 ## File path: flink-table/flink-table-runtime-blin

[GitHub] [flink] shuai-xu commented on issue #8688: [FLINK-12760] [runtime] Implement ExecutionGraph to InputsLocationsRetriever Adapter

2019-06-13 Thread GitBox
shuai-xu commented on issue #8688: [FLINK-12760] [runtime] Implement ExecutionGraph to InputsLocationsRetriever Adapter URL: https://github.com/apache/flink/pull/8688#issuecomment-501947360 @GJL Of course, I have rebased it.

[jira] [Updated] (FLINK-11879) Add JobGraph validators for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput

2019-06-13 Thread Haibo Sun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haibo Sun updated FLINK-11879: -- Description: - Rejects the jobs containing operators which were implemented `InputSelectable` in case

[jira] [Updated] (FLINK-11879) Add JobGraph validators for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput

2019-06-13 Thread Haibo Sun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haibo Sun updated FLINK-11879: -- Description: - Rejects the jobs containing operators which were implemented `TwoInputSelectable` in c

[GitHub] [flink] shuai-xu commented on a change in pull request #8688: [FLINK-12760] [runtime] Implement ExecutionGraph to InputsLocationsRetriever Adapter

2019-06-13 Thread GitBox
shuai-xu commented on a change in pull request #8688: [FLINK-12760] [runtime] Implement ExecutionGraph to InputsLocationsRetriever Adapter URL: https://github.com/apache/flink/pull/8688#discussion_r293643179 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/schedul

[GitHub] [flink] lirui-apache commented on a change in pull request #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and Overwrit

2019-06-13 Thread GitBox
lirui-apache commented on a change in pull request #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink URL: https://github.com/apache/flink/pull/8695#discussion_r293642748 ## File path: f

[jira] [Commented] (FLINK-9854) Allow passing multi-line input to SQL Client CLI

2019-06-13 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863636#comment-16863636 ] vinoyang commented on FLINK-9854: - [~docete] yes, you are right. Please feel free to open

[GitHub] [flink] shuai-xu commented on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots

2019-06-13 Thread GitBox
shuai-xu commented on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots URL: https://github.com/apache/flink/pull/7227#issuecomment-501946385 Thank you, @tillrohrmann This is an automated me

[jira] [Closed] (FLINK-12229) Implement Lazy Scheduling Strategy

2019-06-13 Thread BoWang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BoWang closed FLINK-12229. -- > Implement Lazy Scheduling Strategy > -- > > Key: FLINK-12229 >

[GitHub] [flink] JingsongLi commented on issue #8718: [FLINK-12824][table-planner-blink] Set parallelism for stream SQL

2019-06-13 Thread GitBox
JingsongLi commented on issue #8718: [FLINK-12824][table-planner-blink] Set parallelism for stream SQL URL: https://github.com/apache/flink/pull/8718#issuecomment-501946257 This calculation method basically completely reuses batch code. LGTM +1 --

[GitHub] [flink] zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions

2019-06-13 Thread GitBox
zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions URL: https://github.com/apache/flink/pull/8654#discussion_r293642164 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/

[GitHub] [flink] zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions

2019-06-13 Thread GitBox
zhijiangW commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions URL: https://github.com/apache/flink/pull/8654#discussion_r293641912 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/

[GitHub] [flink] wuchong commented on a change in pull request #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableT

2019-06-13 Thread GitBox
wuchong commented on a change in pull request #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink URL: https://github.com/apache/flink/pull/8695#discussion_r293641738 ## File path: flink-

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r293641180 ## File path: flink-table/flink-table-runtime-blin

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-13 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r293640912 ## File path: flink-table/flink-table-runtime-blin

[GitHub] [flink] lirui-apache commented on a change in pull request #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and Overwrit

2019-06-13 Thread GitBox
lirui-apache commented on a change in pull request #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink URL: https://github.com/apache/flink/pull/8695#discussion_r293640156 ## File path: f

[GitHub] [flink] docete commented on a change in pull request #8729: [FLINK-12831][table-planner][table-api-java] Split FunctionCatalog into Flink & Calcite specific parts

2019-06-13 Thread GitBox
docete commented on a change in pull request #8729: [FLINK-12831][table-planner][table-api-java] Split FunctionCatalog into Flink & Calcite specific parts URL: https://github.com/apache/flink/pull/8729#discussion_r293638486 ## File path: flink-table/flink-table-planner/src/main/ja

[GitHub] [flink] zjuwangg commented on a change in pull request #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog

2019-06-13 Thread GitBox
zjuwangg commented on a change in pull request #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8703#discussion_r293639722 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apac

[jira] [Commented] (FLINK-12829) jobmaster log taskmanger address when task transition state to failed with error

2019-06-13 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863623#comment-16863623 ] Congxian Qiu(klion26) commented on FLINK-12829: --- Hi, do you think FLINK-11

[GitHub] [flink] sunjincheng121 commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function

2019-06-13 Thread GitBox
sunjincheng121 commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function URL: https://github.com/apache/flink/pull/8280#issuecomment-501940453 The CI failed, I restarted the CI due to It looks the EVN problem. :) ---

[jira] [Commented] (FLINK-12841) Unify catalog meta-objects implementations and remove their interfaces

2019-06-13 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863617#comment-16863617 ] Jark Wu commented on FLINK-12841: - +1 to the change > Unify catalog meta-objects implem

[jira] [Commented] (FLINK-12836) Allow retained checkpoints to be persisted on success

2019-06-13 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863613#comment-16863613 ] Congxian Qiu(klion26) commented on FLINK-12836: --- Hi [~andreweduffy], Could

[jira] [Commented] (FLINK-12355) KafkaITCase.testTimestamps is unstable

2019-06-13 Thread leesf (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863590#comment-16863590 ] leesf commented on FLINK-12355: --- Another instance:[https://api.travis-ci.org/v3/job/545241

[GitHub] [flink] sunjincheng121 edited a comment on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots

2019-06-13 Thread GitBox
sunjincheng121 edited a comment on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots URL: https://github.com/apache/flink/pull/7227#issuecomment-501931581 The CI failed, and I restarted the connector CI stage due to I think it's maybe the ENV problem.

[GitHub] [flink] sunjincheng121 commented on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots

2019-06-13 Thread GitBox
sunjincheng121 commented on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots URL: https://github.com/apache/flink/pull/7227#issuecomment-501931581 The CI failed, and I restarted the connector CI state due to I think it's maybe the ENV problem. --

[GitHub] [flink] yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-06-13 Thread GitBox
yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#discussion_r293623628 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/j

[GitHub] [flink] yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-06-13 Thread GitBox
yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#discussion_r293628893 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/c

[GitHub] [flink] yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-06-13 Thread GitBox
yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#discussion_r293627636 ## File path: flink-tests/src/test/java/org/apache/flink/test/stream

  1   2   3   4   5   6   >