[jira] [Commented] (FLINK-13279) not able to query table registered in catalogs in SQL CLI

2019-07-30 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896825#comment-16896825 ] Dawid Wysakowicz commented on FLINK-13279: -- As discussed in the ml thread: htt

[GitHub] [flink] dawidwys commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
dawidwys commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r309063130 ## File path: flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests

[jira] [Commented] (FLINK-13478) Decouple two different release strategies in BoundedBlockingSubpartition

2019-07-30 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896824#comment-16896824 ] Andrey Zagrebin commented on FLINK-13478: - As I understood, the idea was to rely

[jira] [Commented] (FLINK-13504) NoSuchFieldError when executing DDL via tEnv.sqlUpdate in application project

2019-07-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896823#comment-16896823 ] Jark Wu commented on FLINK-13504: - cc [~danny831] [~godfreyhe] [~twalthr] > NoSuchField

[jira] [Created] (FLINK-13504) NoSuchFieldError when executing DDL via tEnv.sqlUpdate in application project

2019-07-30 Thread Jark Wu (JIRA)
Jark Wu created FLINK-13504: --- Summary: NoSuchFieldError when executing DDL via tEnv.sqlUpdate in application project Key: FLINK-13504 URL: https://issues.apache.org/jira/browse/FLINK-13504 Project: Flink

[GitHub] [flink] flinkbot edited a comment on issue #9232: [FLINK-13424][hive] HiveCatalog should add hive version in conf

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9232: [FLINK-13424][hive] HiveCatalog should add hive version in conf URL: https://github.com/apache/flink/pull/9232#issuecomment-515295549 ## CI report: * 199e67fb426db2cf4389112ba914089e5dee3f35 : FAILURE [Build](https://travis-ci.com/flink-ci/f

[GitHub] [flink] flinkbot edited a comment on issue #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect…

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect… URL: https://github.com/apache/flink/pull/9221#issuecomment-514645431 ## CI report: * 05fe281c79ab4bd2646ec949dcbbf0c2af9fec6e : SUCCESS [Build](https://travis-ci.com/fli

[GitHub] [flink] flinkbot edited a comment on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength URL: https://github.com/apache/flink/pull/8559#issuecomment-511466573 ## CI report: * b2e38d5e9dabd95409899c56a3064e75378fdba3 : SUCCESS [Build]

[GitHub] [flink] flinkbot edited a comment on issue #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job URL: https://github.com/apache/flink/pull/9277#issuecomment-516388088 ## CI report: * 7bebdd65247ac172a23f9b0a91873b01b554cd71 : FAILURE [Build](https://travis-ci.com/fl

[jira] [Assigned] (FLINK-13503) Add contract in `LookupableTableSource` to specify the behavior when lookupKeys contains null

2019-07-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13503: --- Assignee: Jing Zhang > Add contract in `LookupableTableSource` to specify the behavior when > look

[GitHub] [flink] flinkbot edited a comment on issue #9254: [FLINK-13427][hive] HiveCatalog's createFunction fails when function …

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9254: [FLINK-13427][hive] HiveCatalog's createFunction fails when function … URL: https://github.com/apache/flink/pull/9254#issuecomment-515852651 ## CI report: * 9ab2841490d5dd93cfb4fec046240dcb43df19bc : FAILURE [Build](https://travis-ci.com/fli

[jira] [Updated] (FLINK-13503) Add contract in `LookupableTableSource` to specify the behavior when lookupKeys contains null

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13503: --- Description: I think we should add contract in `LookupableTableSource` to specify expected behavior

[jira] [Updated] (FLINK-13503) Add contract in `LookupableTableSource` to specify the behavior when lookupKeys contains null

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13503: --- Component/s: Table SQL / API > Add contract in `LookupableTableSource` to specify the behavior when

[jira] [Updated] (FLINK-13503) Add contract in `LookupableTableSource` to specify the behavior when lookupKeys contains null

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13503: --- Description: I think we should add contract in `LookupableTableSource` to specify expected behavior

[jira] [Updated] (FLINK-13503) Add contract in `LookupableTableSource` to specify the behavior when lookupKeys contains null

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13503: --- Description: I think we should add contract in `LookupableTableSource` to specify expected behavior

[jira] [Updated] (FLINK-13503) Add contract in `LookupableTableSource` to specify the behavior when lookupKeys contains null

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13503: --- Description: I think we should add contract in `LookupableTableSource` to specify expected behavior

[GitHub] [flink] wuchong commented on issue #9279: [FLINK-13423][hive] Unable to find function in hive 1

2019-07-30 Thread GitBox
wuchong commented on issue #9279: [FLINK-13423][hive] Unable to find function in hive 1 URL: https://github.com/apache/flink/pull/9279#issuecomment-516715332 Hi @xuefuz , do you have other comments? This is an automated messa

[GitHub] [flink] flinkbot commented on issue #9286: [hotfix] Fix the master build failure

2019-07-30 Thread GitBox
flinkbot commented on issue #9286: [hotfix] Fix the master build failure URL: https://github.com/apache/flink/pull/9286#issuecomment-516714524 ## CI report: * d1a8787e58bcc69588f30d1d2e83a79254d43af1 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/121360314) --

[jira] [Updated] (FLINK-13503) Add contract in `LookupableTableSource` to specify the behavior when lookupKeys contains null

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13503: --- Summary: Add contract in `LookupableTableSource` to specify the behavior when lookupKeys contains nu

[jira] [Updated] (FLINK-13503) Add contract in the behavior of `JDBCLookupFunction` when input data has null

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13503: --- Summary: Add contract in the behavior of `JDBCLookupFunction` when input data has null (was: Corr

[jira] [Commented] (FLINK-13279) not able to query table registered in catalogs in SQL CLI

2019-07-30 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896809#comment-16896809 ] Rui Li commented on FLINK-13279: Hi [~dawidwys], I was trying something like the followi

[jira] [Updated] (FLINK-13503) Correct the behavior of `JDBCLookupFunction` when input data has null

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13503: --- Description: The query template in `JdbcLookUpFunction` like: SELECT c, d, e, f from T where a = ? a

[GitHub] [flink] wuchong commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
wuchong commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r309053823 ## File path: flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/

[GitHub] [flink] flinkbot edited a comment on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#issuecomment-516382130 ## CI report: * 60432f857803273b0e8779f0948b318e764d86f0 : FAILURE [Build](https://travis-ci.com/flink-ci/flink

[GitHub] [flink] flinkbot commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value.

2019-07-30 Thread GitBox
flinkbot commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#issuecomment-516712727 ## CI report: * bb70e45a98e76de7f9

[GitHub] [flink] flinkbot commented on issue #9286: [hotfix] Fix the master build failure

2019-07-30 Thread GitBox
flinkbot commented on issue #9286: [hotfix] Fix the master build failure URL: https://github.com/apache/flink/pull/9286#issuecomment-516712767 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use

[jira] [Commented] (FLINK-13503) Correct the behavior of `JDBCLookupFunction` when input data has null

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896807#comment-16896807 ] Jing Zhang commented on FLINK-13503: cc [~jark][~lzljs3620320] > Correct the behavi

[GitHub] [flink] dianfu opened a new pull request #9286: [hotfix] Fix the master build failure

2019-07-30 Thread GitBox
dianfu opened a new pull request #9286: [hotfix] Fix the master build failure URL: https://github.com/apache/flink/pull/9286 ## What is the purpose of the change * The [travis](https://travis-ci.org/apache/flink/builds/565619561?utm_source=github_status&utm_medium=notification)

[jira] [Updated] (FLINK-13503) Correct the behavior of `JDBCLookupFunction` when input data has null

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13503: --- Summary: Correct the behavior of `JDBCLookupFunction` when input data has null (was: Correct the b

[jira] [Created] (FLINK-13503) Correct the behavior of `JDBCLookupFunction`

2019-07-30 Thread Jing Zhang (JIRA)
Jing Zhang created FLINK-13503: -- Summary: Correct the behavior of `JDBCLookupFunction` Key: FLINK-13503 URL: https://issues.apache.org/jira/browse/FLINK-13503 Project: Flink Issue Type: Task

[GitHub] [flink] beyond1920 commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value.

2019-07-30 Thread GitBox
beyond1920 commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#issuecomment-516711394 cc @wuchong @lincoln-lil

[GitHub] [flink] flinkbot commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value.

2019-07-30 Thread GitBox
flinkbot commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#issuecomment-516710386 Thanks a lot for your contribution to the

[jira] [Updated] (FLINK-13433) Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value

2019-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13433: --- Labels: pull-request-available (was: ) > Do not fetch data from LookupableTableSource if th

[GitHub] [flink] beyond1920 opened a new pull request #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null val

2019-07-30 Thread GitBox
beyond1920 opened a new pull request #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285 ## What is the purpose of the change For LookupJ

[jira] [Updated] (FLINK-13433) Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13433: --- Description: For LookupJoin, if joinKey in left side of a LeftOuterJoin/InnerJoin contains null val

[GitHub] [flink] flinkbot edited a comment on issue #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job URL: https://github.com/apache/flink/pull/9277#issuecomment-516388088 ## CI report: * 7bebdd65247ac172a23f9b0a91873b01b554cd71 : FAILURE [Build](https://travis-ci.com/fl

[jira] [Updated] (FLINK-13433) Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-13433: --- Attachment: LookupJoinITCase.scala > Do not fetch data from LookupableTableSource if the JoinKey in

[GitHub] [flink] flinkbot edited a comment on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink URL: https://github.com/apache/flink/pull/9217#issuecomment-514589043 ## CI report: * 516e655f7f0853d6585ae5de2fbecc438d57e474 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/b

[GitHub] [flink] eamontaaffe commented on a change in pull request #9178: Typo in `scala_api_quickstart.md`

2019-07-30 Thread GitBox
eamontaaffe commented on a change in pull request #9178: Typo in `scala_api_quickstart.md` URL: https://github.com/apache/flink/pull/9178#discussion_r309045044 ## File path: docs/dev/projectsetup/scala_api_quickstart.md ## @@ -217,7 +217,7 @@ take a look at the [Stream Pro

[GitHub] [flink] eamontaaffe commented on a change in pull request #9178: Typo in `scala_api_quickstart.md`

2019-07-30 Thread GitBox
eamontaaffe commented on a change in pull request #9178: Typo in `scala_api_quickstart.md` URL: https://github.com/apache/flink/pull/9178#discussion_r309045044 ## File path: docs/dev/projectsetup/scala_api_quickstart.md ## @@ -217,7 +217,7 @@ take a look at the [Stream Pro

[GitHub] [flink] flinkbot edited a comment on issue #9279: [FLINK-13423][hive] Unable to find function in hive 1

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9279: [FLINK-13423][hive] Unable to find function in hive 1 URL: https://github.com/apache/flink/pull/9279#issuecomment-516401194 ## CI report: * ce30c4da05c4c788bbeb86a812e26f6d89ca35a2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/build

[jira] [Commented] (FLINK-13497) Checkpoints can complete after CheckpointFailureManager fails job

2019-07-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896773#comment-16896773 ] vinoyang commented on FLINK-13497: -- [~yunta] I have no objection to stopping the checkp

[GitHub] [flink] hongtao12310 commented on a change in pull request #9237: [FLINK-13431][hive] NameNode HA configuration was not loaded when running HiveConnector on Yarn

2019-07-30 Thread GitBox
hongtao12310 commented on a change in pull request #9237: [FLINK-13431][hive] NameNode HA configuration was not loaded when running HiveConnector on Yarn URL: https://github.com/apache/flink/pull/9237#discussion_r309035257 ## File path: flink-connectors/flink-connector-hive/src/tes

[jira] [Commented] (FLINK-13497) Checkpoints can complete after CheckpointFailureManager fails job

2019-07-30 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896767#comment-16896767 ] Yun Tang commented on FLINK-13497: -- [~yanghua], there still exists a gap between fail a

[GitHub] [flink] flinkbot edited a comment on issue #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect…

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect… URL: https://github.com/apache/flink/pull/9221#issuecomment-514645431 ## CI report: * 05fe281c79ab4bd2646ec949dcbbf0c2af9fec6e : SUCCESS [Build](https://travis-ci.com/fli

[GitHub] [flink] flinkbot edited a comment on issue #9237: [FLINK-13431][hive] NameNode HA configuration was not loaded when running HiveConnector on Yarn

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9237: [FLINK-13431][hive] NameNode HA configuration was not loaded when running HiveConnector on Yarn URL: https://github.com/apache/flink/pull/9237#issuecomment-515414321 ## CI report: * 2c59c8b33bcbc200978ed7b5ad27311ada599aab : FAILURE [Build](

[GitHub] [flink] hongtao12310 commented on a change in pull request #9237: [FLINK-13431][hive] NameNode HA configuration was not loaded when running HiveConnector on Yarn

2019-07-30 Thread GitBox
hongtao12310 commented on a change in pull request #9237: [FLINK-13431][hive] NameNode HA configuration was not loaded when running HiveConnector on Yarn URL: https://github.com/apache/flink/pull/9237#discussion_r309028331 ## File path: flink-connectors/flink-connector-hive/src/tes

[jira] [Commented] (FLINK-13497) Checkpoints can complete after CheckpointFailureManager fails job

2019-07-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896752#comment-16896752 ] vinoyang commented on FLINK-13497: -- Currently, the {{CheckpointFailureManager}} choose

[GitHub] [flink] flinkbot edited a comment on issue #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37 URL: https://github.com/apache/flink/pull/9239#issuecomment-515435805 ## CI report: * bb0663ddbb6eeda06b756c4ffc7094e64dbdb5b9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/buil

[GitHub] [flink] flinkbot edited a comment on issue #9284: [Flink 13502] move CatalogTableStatisticsConverter & TreeNode to correct package

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9284: [Flink 13502] move CatalogTableStatisticsConverter & TreeNode to correct package URL: https://github.com/apache/flink/pull/9284#issuecomment-516662768 ## CI report: * fff36fd941c13764ad55fc85e4604ab64689aa21 : FAILURE [Build](https://travis-

[jira] [Commented] (FLINK-13485) Translate "Table API Example Walkthrough" page into Chinese

2019-07-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896736#comment-16896736 ] Jark Wu commented on FLINK-13485: - It is a placeholder which will be generated as a tabl

[GitHub] [flink] flinkbot edited a comment on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength URL: https://github.com/apache/flink/pull/8559#issuecomment-511466573 ## CI report: * b2e38d5e9dabd95409899c56a3064e75378fdba3 : SUCCESS [Build]

[jira] [Commented] (FLINK-13433) Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value

2019-07-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896737#comment-16896737 ] Jark Wu commented on FLINK-13433: - Yes. I think so [~jinyu.zj] > Do not fetch data fro

[GitHub] [flink] flinkbot edited a comment on issue #9232: [FLINK-13424][hive] HiveCatalog should add hive version in conf

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9232: [FLINK-13424][hive] HiveCatalog should add hive version in conf URL: https://github.com/apache/flink/pull/9232#issuecomment-515295549 ## CI report: * 199e67fb426db2cf4389112ba914089e5dee3f35 : FAILURE [Build](https://travis-ci.com/flink-ci/f

[GitHub] [flink] Aitozi commented on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength

2019-07-30 Thread GitBox
Aitozi commented on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength URL: https://github.com/apache/flink/pull/8559#issuecomment-516677279 Sorry for late response, I have addressed your comments, please take a look again @zhijian

[jira] [Commented] (FLINK-13485) Translate "Table API Example Walkthrough" page into Chinese

2019-07-30 Thread AT-Fieldless (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896729#comment-16896729 ] AT-Fieldless commented on FLINK-13485: -- Hello, I am confused with "This will be rep

[GitHub] [flink] flinkbot edited a comment on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#issuecomment-516382130 ## CI report: * 60432f857803273b0e8779f0948b318e764d86f0 : FAILURE [Build](https://travis-ci.com/flink-ci/flink

[GitHub] [flink] lirui-apache commented on issue #9232: [FLINK-13424][hive] HiveCatalog should add hive version in conf

2019-07-30 Thread GitBox
lirui-apache commented on issue #9232: [FLINK-13424][hive] HiveCatalog should add hive version in conf URL: https://github.com/apache/flink/pull/9232#issuecomment-516675990 @bowenli86 Thanks for pointing out! Just rebased and fixed this test. ---

[jira] [Commented] (FLINK-13433) Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value

2019-07-30 Thread Jing Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896728#comment-16896728 ] Jing Zhang commented on FLINK-13433: [~jark] Thanks for reminder me. However when l

[GitHub] [flink] docete removed a comment on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete removed a comment on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#issuecomment-516674994 Thanks for your feedbacks @dawidwys. I updated the PR. Please take another look. -

[GitHub] [flink] docete commented on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete commented on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#issuecomment-516674994 Thanks for your feedbacks @dawidwys. I updated the PR. Please take another look. -

[GitHub] [flink] docete commented on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete commented on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#issuecomment-516674981 Thanks for your feedbacks @dawidwys. I updated the PR. Please take another look. -

[GitHub] [flink] lirui-apache commented on a change in pull request #9279: [FLINK-13423][hive] Unable to find function in hive 1

2019-07-30 Thread GitBox
lirui-apache commented on a change in pull request #9279: [FLINK-13423][hive] Unable to find function in hive 1 URL: https://github.com/apache/flink/pull/9279#discussion_r309021648 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive

[GitHub] [flink] flinkbot edited a comment on issue #9283: [FLINK-13487][tests] Fix unstable partition lifecycle tests by ensuring TM has registered to JM before submitting task

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9283: [FLINK-13487][tests] Fix unstable partition lifecycle tests by ensuring TM has registered to JM before submitting task URL: https://github.com/apache/flink/pull/9283#issuecomment-516656866 ## CI report: * afd7ba4663e2298776c0e02a4fe56cc1d3cf

[GitHub] [flink] flinkbot edited a comment on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink URL: https://github.com/apache/flink/pull/9217#issuecomment-514589043 ## CI report: * 516e655f7f0853d6585ae5de2fbecc438d57e474 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/b

[GitHub] [flink] flinkbot edited a comment on issue #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect…

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect… URL: https://github.com/apache/flink/pull/9221#issuecomment-514645431 ## CI report: * 05fe281c79ab4bd2646ec949dcbbf0c2af9fec6e : SUCCESS [Build](https://travis-ci.com/fli

[GitHub] [flink] flinkbot edited a comment on issue #9279: [FLINK-13423][hive] Unable to find function in hive 1

2019-07-30 Thread GitBox
flinkbot edited a comment on issue #9279: [FLINK-13423][hive] Unable to find function in hive 1 URL: https://github.com/apache/flink/pull/9279#issuecomment-516401194 ## CI report: * ce30c4da05c4c788bbeb86a812e26f6d89ca35a2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/build

[GitHub] [flink] xuefuz commented on a change in pull request #9279: [FLINK-13423][hive] Unable to find function in hive 1

2019-07-30 Thread GitBox
xuefuz commented on a change in pull request #9279: [FLINK-13423][hive] Unable to find function in hive 1 URL: https://github.com/apache/flink/pull/9279#discussion_r309019671 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/clien

[jira] [Commented] (FLINK-13501) Fixes a few issues in documentation for Hive integration

2019-07-30 Thread Terry Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896711#comment-16896711 ] Terry Wang commented on FLINK-13501: Hi [~xuefuz] and [~tiwalter]. I'd like to fix t

[GitHub] [flink] lirui-apache commented on issue #9279: [FLINK-13423][hive] Unable to find function in hive 1

2019-07-30 Thread GitBox
lirui-apache commented on issue #9279: [FLINK-13423][hive] Unable to find function in hive 1 URL: https://github.com/apache/flink/pull/9279#issuecomment-516670776 @xuefuz PR updated to address your comment This is an automate

[GitHub] [flink] bowenli86 commented on issue #9232: [FLINK-13424][hive] HiveCatalog should add hive version in conf

2019-07-30 Thread GitBox
bowenli86 commented on issue #9232: [FLINK-13424][hive] HiveCatalog should add hive version in conf URL: https://github.com/apache/flink/pull/9232#issuecomment-516668599 ran tests locally and found the test is failing ``` [ERROR] Errors: [ERROR] TableEnvHiveConnectorTest.setu

[GitHub] [flink] lirui-apache commented on a change in pull request #9264: [FLINK-13192][hive] Add tests for different Hive table formats

2019-07-30 Thread GitBox
lirui-apache commented on a change in pull request #9264: [FLINK-13192][hive] Add tests for different Hive table formats URL: https://github.com/apache/flink/pull/9264#discussion_r309016831 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/con

[GitHub] [flink] lirui-apache commented on a change in pull request #9264: [FLINK-13192][hive] Add tests for different Hive table formats

2019-07-30 Thread GitBox
lirui-apache commented on a change in pull request #9264: [FLINK-13192][hive] Add tests for different Hive table formats URL: https://github.com/apache/flink/pull/9264#discussion_r309016668 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/cat

[GitHub] [flink] bowenli86 commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37

2019-07-30 Thread GitBox
bowenli86 commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37 URL: https://github.com/apache/flink/pull/9239#discussion_r309015509 ## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/H

[GitHub] [flink] bowenli86 commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37

2019-07-30 Thread GitBox
bowenli86 commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37 URL: https://github.com/apache/flink/pull/9239#discussion_r309015597 ## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/H

[GitHub] [flink] lirui-apache commented on a change in pull request #9237: [FLINK-13431][hive] NameNode HA configuration was not loaded when running HiveConnector on Yarn

2019-07-30 Thread GitBox
lirui-apache commented on a change in pull request #9237: [FLINK-13431][hive] NameNode HA configuration was not loaded when running HiveConnector on Yarn URL: https://github.com/apache/flink/pull/9237#discussion_r309015087 ## File path: flink-connectors/flink-connector-hive/src/tes

[jira] [Commented] (FLINK-13344) Translate "How to Contribute" page into Chinese.

2019-07-30 Thread WangHengWei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896702#comment-16896702 ] WangHengWei commented on FLINK-13344: - OK, I'm glad to do. > Translate "How to Cont

[GitHub] [flink] flinkbot commented on issue #9284: [Flink 13502] move CatalogTableStatisticsConverter & TreeNode to correct package

2019-07-30 Thread GitBox
flinkbot commented on issue #9284: [Flink 13502] move CatalogTableStatisticsConverter & TreeNode to correct package URL: https://github.com/apache/flink/pull/9284#issuecomment-516662768 ## CI report: * fff36fd941c13764ad55fc85e4604ab64689aa21 : PENDING [Build](https://travis-ci.com/

[GitHub] [flink] ifndef-SleePy commented on issue #9269: [FLINK-9900][tests] Fix unstable ZooKeeperHighAvailabilityITCase

2019-07-30 Thread GitBox
ifndef-SleePy commented on issue #9269: [FLINK-9900][tests] Fix unstable ZooKeeperHighAvailabilityITCase URL: https://github.com/apache/flink/pull/9269#issuecomment-516661890 Hi @tillrohrmann , I think we could merge this PR. Actually this `blockSnapshotLatch` only works when the race cond

[jira] [Commented] (FLINK-13502) CatalogTableStatisticsConverter & TreeNode should be in correct package

2019-07-30 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896690#comment-16896690 ] godfrey he commented on FLINK-13502: yes, it's just a code cleanup > CatalogTableSt

[GitHub] [flink] docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r309011200 ## File path: tools/travis/splits/split_misc.sh ## @@ -49,7 +49,8 @@ run_test "Queryable sta

[GitHub] [flink] flinkbot commented on issue #9284: [Flink 13502] move CatalogTableStatisticsConverter & TreeNode to correct package

2019-07-30 Thread GitBox
flinkbot commented on issue #9284: [Flink 13502] move CatalogTableStatisticsConverter & TreeNode to correct package URL: https://github.com/apache/flink/pull/9284#issuecomment-516661359 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Updated] (FLINK-13502) CatalogTableStatisticsConverter & TreeNode should be in correct package

2019-07-30 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-13502: --- Description: currently, {{CatalogTableStatisticsConverter}} is in {{org.apache.flink.table.util}}, {

[jira] [Updated] (FLINK-13446) Row count sliding window outputs incorrectly in blink planner

2019-07-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-13446: Priority: Critical (was: Blocker) > Row count sliding window outputs incorrectly in blink planner > -

[GitHub] [flink] docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r309010785 ## File path: flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/S

[GitHub] [flink] docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r309010871 ## File path: flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/S

[GitHub] [flink] godfreyhe opened a new pull request #9284: [Flink 13502] move CatalogTableStatisticsConverter & TreeNode to correct package

2019-07-30 Thread GitBox
godfreyhe opened a new pull request #9284: [Flink 13502] move CatalogTableStatisticsConverter & TreeNode to correct package URL: https://github.com/apache/flink/pull/9284 ## What is the purpose of the change *move CatalogTableStatisticsConverter & TreeNode to correct package*

[GitHub] [flink] docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r309010810 ## File path: flink-end-to-end-tests/test-scripts/test_streaming_sql.sh ## @@ -21,15 +21,14

[GitHub] [flink] docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r309010785 ## File path: flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/S

[jira] [Commented] (FLINK-13502) CatalogTableStatisticsConverter & TreeNode should be in correct package

2019-07-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896686#comment-16896686 ] Jark Wu commented on FLINK-13502: - Currently, TreeNode is in {{org.apache.flink.table.pl

[GitHub] [flink] docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r309010871 ## File path: flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/S

[jira] [Commented] (FLINK-13502) CatalogTableStatisticsConverter & TreeNode should be in correct package

2019-07-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896687#comment-16896687 ] Jark Wu commented on FLINK-13502: - There are no class conflicts for these classes. I did

[GitHub] [flink] docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r309010505 ## File path: flink-end-to-end-tests/run-pre-commit-tests.sh ## @@ -60,6 +60,7 @@ run_test "

[jira] [Assigned] (FLINK-13502) CatalogTableStatisticsConverter & TreeNode should be in correct package

2019-07-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13502: --- Assignee: godfrey he > CatalogTableStatisticsConverter & TreeNode should be in correct package > --

[jira] [Updated] (FLINK-13502) CatalogTableStatisticsConverter & TreeNode should be in correct package

2019-07-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-13502: Priority: Critical (was: Major) > CatalogTableStatisticsConverter & TreeNode should be in correct package

[GitHub] [flink] docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r309010313 ## File path: flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/S

[jira] [Commented] (FLINK-13344) Translate "How to Contribute" page into Chinese.

2019-07-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896683#comment-16896683 ] Jark Wu commented on FLINK-13344: - [~WangHW] Btw, you can help to review other translati

[GitHub] [flink] docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-07-30 Thread GitBox
docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r309009507 ## File path: flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/S

[jira] [Commented] (FLINK-13502) CatalogTableStatisticsConverter & TreeNode should be in correct package

2019-07-30 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896679#comment-16896679 ] godfrey he commented on FLINK-13502: i will fix this > CatalogTableStatisticsConver

[jira] [Updated] (FLINK-13502) CatalogTableStatisticsConverter & TreeNode should be in correct package

2019-07-30 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-13502: --- Description: currently, {{CatalogTableStatisticsConverter}} is in {{org.apache.flink.table.util}}, {

  1   2   3   4   5   6   >