[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12507: URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577 ## CI report: * 90d421fc94e29c0af0fa563661b9dd8f2a388b1b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12256: URL: https://github.com/apache/flink/pull/12256#issuecomment-631025695 ## CI report: * ca05fc241f6fd0550a39612b4ddef86b63a304a6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12303: [FLINK-17625] [table] Fix ArrayIndexOutOfBoundsException in AppendOnlyTopNFunction

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12303: URL: https://github.com/apache/flink/pull/12303#issuecomment-633242378 ## CI report: * 1c92b48de9d7b9068a646053e7dc9b4d076625ab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12508: URL: https://github.com/apache/flink/pull/12508#issuecomment-639985108 ## CI report: * 8953e51d845b3a61608d6e08f9caf462e43775bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12256: URL: https://github.com/apache/flink/pull/12256#issuecomment-631025695 ## CI report: * ca05fc241f6fd0550a39612b4ddef86b63a304a6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] zhuzhurk commented on a change in pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12256: URL: https://github.com/apache/flink/pull/12256#discussion_r436239625 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/OneSlotPerExecutionSlotAllocator.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [flink] zhuzhurk commented on a change in pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12256: URL: https://github.com/apache/flink/pull/12256#discussion_r436239133 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultExecutionSlotAllocatorTest.java ## @@ -200,14 +203,16 @@ private Slo

[GitHub] [flink] zhuzhurk commented on a change in pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12256: URL: https://github.com/apache/flink/pull/12256#discussion_r436239010 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultExecutionSlotAllocatorTest.java ## @@ -189,7 +192,7 @@ private Defau

[GitHub] [flink] zhuzhurk commented on a change in pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12256: URL: https://github.com/apache/flink/pull/12256#discussion_r436238944 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultExecutionSlotAllocatorTest.java ## @@ -216,13 +221,37 @@ private Slo

[GitHub] [flink] zhuzhurk commented on a change in pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12256: URL: https://github.com/apache/flink/pull/12256#discussion_r436238809 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/OneSlotPerExecutionSlotAllocator.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [flink] zhuzhurk commented on a change in pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12256: URL: https://github.com/apache/flink/pull/12256#discussion_r436238884 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/OneSlotPerExecutionSlotAllocator.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [flink] flinkbot commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…

2020-06-05 Thread GitBox
flinkbot commented on pull request #12508: URL: https://github.com/apache/flink/pull/12508#issuecomment-639985108 ## CI report: * 8953e51d845b3a61608d6e08f9caf462e43775bc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] zhuzhurk commented on a change in pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12256: URL: https://github.com/apache/flink/pull/12256#discussion_r436238809 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/OneSlotPerExecutionSlotAllocator.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [flink] zhuzhurk commented on a change in pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12256: URL: https://github.com/apache/flink/pull/12256#discussion_r436237778 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/OneSlotPerExecutionSlotAllocator.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [flink] Tartarus0zm commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…

2020-06-05 Thread GitBox
Tartarus0zm commented on pull request #12508: URL: https://github.com/apache/flink/pull/12508#issuecomment-639981987 @zentol can you review this for me if you have time, thanks ~ This is an automated message from the Apache G

[GitHub] [flink] wuchong commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…

2020-06-05 Thread GitBox
wuchong commented on pull request #12508: URL: https://github.com/apache/flink/pull/12508#issuecomment-639979473 cc @carp84 who is more familiar with state module. This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…

2020-06-05 Thread GitBox
flinkbot commented on pull request #12508: URL: https://github.com/apache/flink/pull/12508#issuecomment-639978998 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] Tartarus0zm commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…

2020-06-05 Thread GitBox
Tartarus0zm commented on pull request #12508: URL: https://github.com/apache/flink/pull/12508#issuecomment-639978848 @wuchong can you review this for me if you have time, thanks ~ This is an automated message from the Apache

[GitHub] [flink] Tartarus0zm opened a new pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…

2020-06-05 Thread GitBox
Tartarus0zm opened a new pull request #12508: URL: https://github.com/apache/flink/pull/12508 ## What is the purpose of the change Add error message to precondition in KeyGroupPartitionedPriorityQueue. Avoid unclear exception information like ``` java.lang.ArrayIndexOutOfBoun

[GitHub] [flink] flinkbot edited a comment on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12507: URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577 ## CI report: * 90d421fc94e29c0af0fa563661b9dd8f2a388b1b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent

2020-06-05 Thread GitBox
flinkbot commented on pull request #12507: URL: https://github.com/apache/flink/pull/12507#issuecomment-639959577 ## CI report: * 90d421fc94e29c0af0fa563661b9dd8f2a388b1b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #12303: [FLINK-17625] [table] Fix ArrayIndexOutOfBoundsException in AppendOnlyTopNFunction

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12303: URL: https://github.com/apache/flink/pull/12303#issuecomment-633242378 ## CI report: * 3f6b52073802835bc193796a41d095c5670f5d59 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] becketqin commented on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent

2020-06-05 Thread GitBox
becketqin commented on pull request #12507: URL: https://github.com/apache/flink/pull/12507#issuecomment-639958697 @StephanEwen Could you help take a look? Thanks! This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot commented on pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent

2020-06-05 Thread GitBox
flinkbot commented on pull request #12507: URL: https://github.com/apache/flink/pull/12507#issuecomment-639957918 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] becketqin opened a new pull request #12507: [FLINK-18162][connector/common] Serialize the splits in the AddSplitsEvent

2020-06-05 Thread GitBox
becketqin opened a new pull request #12507: URL: https://github.com/apache/flink/pull/12507 ## What is the purpose of the change The `AddSplitsEvent` contains a list of `SourceSplit` to be sent from the source coordinator to the source reader. Currently the `AddSplitsEvent` is a serial

[GitHub] [flink] flinkbot edited a comment on pull request #12303: [FLINK-17625] [table] Fix ArrayIndexOutOfBoundsException in AppendOnlyTopNFunction

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12303: URL: https://github.com/apache/flink/pull/12303#issuecomment-633242378 ## CI report: * 3f6b52073802835bc193796a41d095c5670f5d59 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] lsyldliu commented on pull request #12303: [FLINK-17625] [table] Fix ArrayIndexOutOfBoundsException in AppendOnlyTopNFunction

2020-06-05 Thread GitBox
lsyldliu commented on pull request #12303: URL: https://github.com/apache/flink/pull/12303#issuecomment-639951595 @wuchong Thanks for your review and I've addressed your comments. This is an automated message from the Apache

[GitHub] [flink] TengHu commented on pull request #12297: [FLINK-12855] [streaming-java][window-assigners] Add functionality that staggers panes on partitions to distribute workload.

2020-06-05 Thread GitBox
TengHu commented on pull request #12297: URL: https://github.com/apache/flink/pull/12297#issuecomment-639894888 @aljoscha Gentle ping on this. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [flink] flinkbot edited a comment on pull request #12506: [FLINK-18139][checkpointing] Fixing unaligned checkpoints checks wrong channels for inflight data.

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12506: URL: https://github.com/apache/flink/pull/12506#issuecomment-639676996 ## CI report: * a6e3fc1886259cb1b7efede2596c9b581df06099 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12484: [FLINK-18127][tests] Streamline manual execution of Java E2E tests

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12484: URL: https://github.com/apache/flink/pull/12484#issuecomment-638836075 ## CI report: * 48ca964fb1f2350c6335ab4726553f38a4a4c1c0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12423: [FLINK-18034][runtime] Introduce PreferredLocationsRetriever

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12423: URL: https://github.com/apache/flink/pull/12423#issuecomment-636712044 ## CI report: * 979c16df9319f87d4b96ff32d7e55823d8e41551 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12375: [FLINK-17017][runtime] Implements bulk allocation for physical slots

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12375: URL: https://github.com/apache/flink/pull/12375#issuecomment-635184560 ## CI report: * cd3fc98c034fdc61235d9109c05b4f55d7423746 UNKNOWN * a8902557952ea70746d27e88a392c74724784605 Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #12460: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12460: URL: https://github.com/apache/flink/pull/12460#issuecomment-638102290 ## CI report: * 1d838c03d2b9f9744cae6fc03a919db72cc0efd9 UNKNOWN * 5729182fd15a074bebba7f878113781c2b119fd3 Azure: [CANCELED](https://dev.azure.com/apache-f

[GitHub] [flink] flinkbot edited a comment on pull request #12505: [FLINK-17765] Simplify Flink stack traces

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12505: URL: https://github.com/apache/flink/pull/12505#issuecomment-639597366 ## CI report: * 9e1468b9780de1ceecae32707a836f05561a14b1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12423: [FLINK-18034][runtime] Introduce PreferredLocationsRetriever

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12423: URL: https://github.com/apache/flink/pull/12423#issuecomment-636712044 ## CI report: * 7a2dfb63f296d835193c2ded3ec2f1f868eaf92a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12504: [FLINK-16350] Support Zookeeper 3.5 in test_ha_per_job_cluster_datastream.sh

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12504: URL: https://github.com/apache/flink/pull/12504#issuecomment-639551716 ## CI report: * 9e7ffdf88b132d86eba7dd516c9b16d1b705758a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12503: [FLINK-18151][python] Resolve CWE22 problems in pyflink_gateway_server.py

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12503: URL: https://github.com/apache/flink/pull/12503#issuecomment-639444578 ## CI report: * ce4f8beceb4672b8daa260f1b484a5790b0ad719 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12446: [FLINK-16225] Implement user class loading exception handler

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12446: URL: https://github.com/apache/flink/pull/12446#issuecomment-637647665 ## CI report: * 426791910cdcdc50824687d842a182f4036dbfc1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #11586: [FLINK-5552][runtime] make JMXServer static per JVM

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #11586: URL: https://github.com/apache/flink/pull/11586#issuecomment-606958289 ## CI report: * 0c0af972ac3f8477eba6c65cfe990a6af0105707 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12484: [FLINK-18127][tests] Streamline manual execution of Java E2E tests

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12484: URL: https://github.com/apache/flink/pull/12484#issuecomment-638836075 ## CI report: * 683c24369ba03611b096aad5c7e9d634c131549b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12506: [FLINK-18139][checkpointing] Fixing unaligned checkpoints checks wrong channels for inflight data.

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12506: URL: https://github.com/apache/flink/pull/12506#issuecomment-639676996 ## CI report: * a6e3fc1886259cb1b7efede2596c9b581df06099 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Reopened] (FLINK-17260) StreamingKafkaITCase failure on Azure

2020-06-05 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reopened FLINK-17260: failed again on master (including your commit): https://dev.azure.com/apache-flink/apache-fli

[GitHub] [flink] flinkbot edited a comment on pull request #12484: [FLINK-18127][tests] Streamline manual execution of Java E2E tests

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12484: URL: https://github.com/apache/flink/pull/12484#issuecomment-638836075 ## CI report: * 683c24369ba03611b096aad5c7e9d634c131549b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12423: [FLINK-18034][runtime] Introduce PreferredLocationsRetriever

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12423: URL: https://github.com/apache/flink/pull/12423#issuecomment-636712044 ## CI report: * 362a6480b17c1133aae420e09518b08482edf7e7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12473: [FLINK-18061] [table] TableResult#collect method should return a closeable iterator to avoid resource leak

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12473: URL: https://github.com/apache/flink/pull/12473#issuecomment-638574481 ## CI report: * 6ffb0ddcf8041c9e064e05fab3a9e1747c41820f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #12506: [FLINK-18139][checkpointing] Fixing unaligned checkpoints checks wrong channels for inflight data.

2020-06-05 Thread GitBox
flinkbot commented on pull request #12506: URL: https://github.com/apache/flink/pull/12506#issuecomment-639676996 ## CI report: * a6e3fc1886259cb1b7efede2596c9b581df06099 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #12375: [FLINK-17017][runtime] Implements bulk allocation for physical slots

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12375: URL: https://github.com/apache/flink/pull/12375#issuecomment-635184560 ## CI report: * cd3fc98c034fdc61235d9109c05b4f55d7423746 UNKNOWN * ff97aeedb303fe540ebb3728ed280de414606978 Azure: [FAILURE](https://dev.azure.com/apache-fl

[jira] [Commented] (FLINK-16795) End to end tests timeout on Azure

2020-06-05 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126980#comment-17126980 ] Robert Metzger commented on FLINK-16795: https://dev.azure.com/apache-flink/apac

[GitHub] [flink] flinkbot edited a comment on pull request #12453: [FLINK-18061] [table] TableResult#collect method should return a closeable iterator to avoid resource leak

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12453: URL: https://github.com/apache/flink/pull/12453#issuecomment-637941328 ## CI report: * ae99323647e5a2febfd0696738b53b540b72f3a2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #12506: [FLINK-18139][checkpointing] Fixing unaligned checkpoints checks wrong channels for inflight data.

2020-06-05 Thread GitBox
flinkbot commented on pull request #12506: URL: https://github.com/apache/flink/pull/12506#issuecomment-639664025 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] kl0u commented on a change in pull request #12501: [FLINK-18149][k8s] Do not add DeploymentOptionsInternal#CONF_DIR to config map

2020-06-05 Thread GitBox
kl0u commented on a change in pull request #12501: URL: https://github.com/apache/flink/pull/12501#discussion_r436070973 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/FlinkConfMountDecorator.java ## @@ -148,6 +149,7 @@ private P

[GitHub] [flink] AHeise opened a new pull request #12506: [FLINK-18139][checkpointing] Fixing unaligned checkpoints checks wrong channels for inflight data.

2020-06-05 Thread GitBox
AHeise opened a new pull request #12506: URL: https://github.com/apache/flink/pull/12506 [unchanged 1.11 backport of https://github.com/apache/flink/pull/12493] ## What is the purpose of the change `CheckpointBarrierUnaligner#hasInflightData` was not called with inp

[GitHub] [flink] zentol commented on a change in pull request #12484: [FLINK-18127][tests] Streamline manual execution of Java E2E tests

2020-06-05 Thread GitBox
zentol commented on a change in pull request #12484: URL: https://github.com/apache/flink/pull/12484#discussion_r436067756 ## File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/LocalStandaloneFlinkResourceFactory.java ##

[GitHub] [flink] zentol commented on a change in pull request #12484: [FLINK-18127][tests] Streamline manual execution of Java E2E tests

2020-06-05 Thread GitBox
zentol commented on a change in pull request #12484: URL: https://github.com/apache/flink/pull/12484#discussion_r436067636 ## File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/LocalStandaloneFlinkResourceFactory.java ##

[GitHub] [flink] zhuzhurk commented on a change in pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12256: URL: https://github.com/apache/flink/pull/12256#discussion_r436060993 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/OneSlotPerExecutionSlotAllocator.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [flink] flinkbot edited a comment on pull request #12460: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12460: URL: https://github.com/apache/flink/pull/12460#issuecomment-638102290 ## CI report: * 1d838c03d2b9f9744cae6fc03a919db72cc0efd9 UNKNOWN * 31da2083df6221fd36c6ed5674927eed1cc68088 Azure: [CANCELED](https://dev.azure.com/apache-f

[GitHub] [flink] zhijiangW commented on a change in pull request #12460: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner

2020-06-05 Thread GitBox
zhijiangW commented on a change in pull request #12460: URL: https://github.com/apache/flink/pull/12460#discussion_r436055041 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnalignerTest.java ## @@ -512,6 +512,123 @@ pub

[GitHub] [flink] zhijiangW commented on a change in pull request #12460: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner

2020-06-05 Thread GitBox
zhijiangW commented on a change in pull request #12460: URL: https://github.com/apache/flink/pull/12460#discussion_r436055041 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnalignerTest.java ## @@ -512,6 +512,123 @@ pub

[GitHub] [flink] zhijiangW merged pull request #12493: [FLINK-18139][checkpointing] Fixing unaligned checkpoints checks wrong channels for inflight data.

2020-06-05 Thread GitBox
zhijiangW merged pull request #12493: URL: https://github.com/apache/flink/pull/12493 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [flink] flinkbot edited a comment on pull request #12503: [FLINK-18151][python] Resolve CWE22 problems in pyflink_gateway_server.py

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12503: URL: https://github.com/apache/flink/pull/12503#issuecomment-639444578 ## CI report: * da2d996d1c4170fa70772715ca027cdc7d65407a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12423: [FLINK-18034][runtime] Introduce PreferredLocationsRetriever

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12423: URL: https://github.com/apache/flink/pull/12423#issuecomment-636712044 ## CI report: * 362a6480b17c1133aae420e09518b08482edf7e7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12460: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12460: URL: https://github.com/apache/flink/pull/12460#issuecomment-638102290 ## CI report: * 1d838c03d2b9f9744cae6fc03a919db72cc0efd9 UNKNOWN * b2c4d6aaf78612e7214cc49d22e2b90fe29b93b6 Azure: [CANCELED](https://dev.azure.com/apache-f

[GitHub] [flink] flinkbot edited a comment on pull request #12493: [FLINK-18139][checkpointing] Fixing unaligned checkpoints checks wrong channels for inflight data.

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12493: URL: https://github.com/apache/flink/pull/12493#issuecomment-639156189 ## CI report: * 1973dc85708e04da3b66b511eb89c84478087dd5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12375: [FLINK-17017][runtime] Implements bulk allocation for physical slots

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12375: URL: https://github.com/apache/flink/pull/12375#issuecomment-635184560 ## CI report: * cd3fc98c034fdc61235d9109c05b4f55d7423746 UNKNOWN * ff97aeedb303fe540ebb3728ed280de414606978 Azure: [FAILURE](https://dev.azure.com/apache-fl

[jira] [Created] (FLINK-18164) null <> 'str' should be true

2020-06-05 Thread Benchao Li (Jira)
Benchao Li created FLINK-18164: -- Summary: null <> 'str' should be true Key: FLINK-18164 URL: https://issues.apache.org/jira/browse/FLINK-18164 Project: Flink Issue Type: Bug Components

[jira] [Commented] (FLINK-17560) No Slots available exception in Apache Flink Job Manager while Scheduling

2020-06-05 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126933#comment-17126933 ] Chesnay Schepler commented on FLINK-17560: -- There's a ConcurrentModificationExc

[GitHub] [flink] flinkbot edited a comment on pull request #12505: [FLINK-17765] Simplify Flink stack traces

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12505: URL: https://github.com/apache/flink/pull/12505#issuecomment-639597366 ## CI report: * 9e1468b9780de1ceecae32707a836f05561a14b1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12471: [FLINK-18073][FLINK-18029][avro] Fix AvroRowDataSerializationSchema is not serializable and add IT cases

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12471: URL: https://github.com/apache/flink/pull/12471#issuecomment-638362836 ## CI report: * 4bcc31b01d257710de3d5828167f97e0cd00ff03 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12423: [FLINK-18034][runtime] Introduce PreferredLocationsRetriever

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12423: URL: https://github.com/apache/flink/pull/12423#issuecomment-636712044 ## CI report: * 362a6480b17c1133aae420e09518b08482edf7e7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] zhuzhurk commented on a change in pull request #12423: [FLINK-18034][runtime] Introduce PreferredLocationsRetriever

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12423: URL: https://github.com/apache/flink/pull/12423#discussion_r436028808 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/AbstractExecutionSlotAllocator.java ## @@ -0,0 +1,134 @@ +/* + * Licensed t

[GitHub] [flink] zhuzhurk commented on a change in pull request #12423: [FLINK-18034][runtime] Introduce PreferredLocationsRetriever

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12423: URL: https://github.com/apache/flink/pull/12423#discussion_r436024342 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/AbstractExecutionSlotAllocator.java ## @@ -0,0 +1,134 @@ +/* + * Licensed t

[jira] [Assigned] (FLINK-17973) Test memory configuration of Flink cluster

2020-06-05 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-17973: Assignee: Chesnay Schepler > Test memory configuration of Flink cluster > ---

[jira] [Created] (FLINK-18163) Should be volatile: network.api.writer.RecordWriter.flusherException

2020-06-05 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-18163: - Summary: Should be volatile: network.api.writer.RecordWriter.flusherException Key: FLINK-18163 URL: https://issues.apache.org/jira/browse/FLINK-18163 Proje

[GitHub] [flink] zhuzhurk commented on a change in pull request #12423: [FLINK-18034][runtime] Introduce PreferredLocationsRetriever

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12423: URL: https://github.com/apache/flink/pull/12423#discussion_r436018689 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java ## @@ -0,0 +1,137 @@ +/* + * Licens

[GitHub] [flink] zhuzhurk commented on a change in pull request #12423: [FLINK-18034][runtime] Introduce PreferredLocationsRetriever

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12423: URL: https://github.com/apache/flink/pull/12423#discussion_r436018529 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java ## @@ -0,0 +1,137 @@ +/* + * Licens

[GitHub] [flink] tillrohrmann commented on a change in pull request #12484: [FLINK-18127][tests] Streamline manual execution of Java E2E tests

2020-06-05 Thread GitBox
tillrohrmann commented on a change in pull request #12484: URL: https://github.com/apache/flink/pull/12484#discussion_r436017785 ## File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/LocalStandaloneFlinkResourceFactory.java

[GitHub] [flink] zhuzhurk commented on a change in pull request #12423: [FLINK-18034][runtime] Introduce PreferredLocationsRetriever

2020-06-05 Thread GitBox
zhuzhurk commented on a change in pull request #12423: URL: https://github.com/apache/flink/pull/12423#discussion_r436018318 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionVertexSchedulingRequirements.java ## @@ -169,8 +161,7 @@ public Ex

[GitHub] [flink] flinkbot commented on pull request #12505: [FLINK-17765] Simplify Flink stack traces

2020-06-05 Thread GitBox
flinkbot commented on pull request #12505: URL: https://github.com/apache/flink/pull/12505#issuecomment-639597366 ## CI report: * 9e1468b9780de1ceecae32707a836f05561a14b1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #12446: [FLINK-16225] Implement user class loading exception handler

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12446: URL: https://github.com/apache/flink/pull/12446#issuecomment-637647665 ## CI report: * 7af38d20bc7c7e484cd63b36ec2d603f14a99dfc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12460: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12460: URL: https://github.com/apache/flink/pull/12460#issuecomment-638102290 ## CI report: * 1d838c03d2b9f9744cae6fc03a919db72cc0efd9 UNKNOWN * b2c4d6aaf78612e7214cc49d22e2b90fe29b93b6 Azure: [CANCELED](https://dev.azure.com/apache-f

[jira] [Assigned] (FLINK-17765) Verbose client error messages

2020-06-05 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-17765: - Assignee: Till Rohrmann (was: Chesnay Schepler) > Verbose client error messages >

[GitHub] [flink] flinkbot commented on pull request #12505: [FLINK-17765] Simplify Flink stack traces

2020-06-05 Thread GitBox
flinkbot commented on pull request #12505: URL: https://github.com/apache/flink/pull/12505#issuecomment-639582390 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] wuchong commented on a change in pull request #12335: [FLINK-17753] [table-planner-blink] Fix watermark defined in ddl does not work in Table api

2020-06-05 Thread GitBox
wuchong commented on a change in pull request #12335: URL: https://github.com/apache/flink/pull/12335#discussion_r436004322 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java ## @@ -490,8 +490,11 @@ privat

[GitHub] [flink] wuchong commented on a change in pull request #12335: [FLINK-17753] [table-planner-blink] Fix watermark defined in ddl does not work in Table api

2020-06-05 Thread GitBox
wuchong commented on a change in pull request #12335: URL: https://github.com/apache/flink/pull/12335#discussion_r436004322 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java ## @@ -490,8 +490,11 @@ privat

[jira] [Updated] (FLINK-17380) Kafka09ITCase.runAllDeletesTest: "Memory records is not writable"

2020-06-05 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-17380: - Summary: Kafka09ITCase.runAllDeletesTest: "Memory records is not writable" (was: runAll

[GitHub] [flink] tillrohrmann commented on a change in pull request #12446: [FLINK-16225] Implement user class loading exception handler

2020-06-05 Thread GitBox
tillrohrmann commented on a change in pull request #12446: URL: https://github.com/apache/flink/pull/12446#discussion_r435997739 ## File path: flink-core/src/main/java/org/apache/flink/util/FlinkUserCodeClassLoader.java ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Softwa

[jira] [Updated] (FLINK-16768) HadoopS3RecoverableWriterITCase.testRecoverWithStateWithMultiPart hangs

2020-06-05 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-16768: - Issue Type: Bug (was: Task) > HadoopS3RecoverableWriterITCase.testRecoverWithStateWithM

[jira] [Commented] (FLINK-18161) Changing parallelism is not possible in sql-client.sh

2020-06-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126882#comment-17126882 ] Jark Wu commented on FLINK-18161: - Could we just allow SQL CLI to set Flink configuratio

[jira] [Commented] (FLINK-18096) Generated avro formats should support user specified name and namespace

2020-06-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126877#comment-17126877 ] Jark Wu commented on FLINK-18096: - This sounds like you will need an additional util to

[GitHub] [flink] flinkbot edited a comment on pull request #12476: [FLINK-17902][python] Support the new interfaces about temporary functions in PyFlink

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12476: URL: https://github.com/apache/flink/pull/12476#issuecomment-638622433 ## CI report: * 049d7d45991db1164ff983ec3fd6c0b23ad6f07f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12504: [FLINK-16350] Support Zookeeper 3.5 in test_ha_per_job_cluster_datastream.sh

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #12504: URL: https://github.com/apache/flink/pull/12504#issuecomment-639551716 ## CI report: * 9e7ffdf88b132d86eba7dd516c9b16d1b705758a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Comment Edited] (FLINK-18161) Changing parallelism is not possible in sql-client.sh

2020-06-05 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126875#comment-17126875 ] Dawid Wysakowicz edited comment on FLINK-18161 at 6/5/20, 3:25 PM: ---

[jira] [Commented] (FLINK-18161) Changing parallelism is not possible in sql-client.sh

2020-06-05 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126875#comment-17126875 ] Dawid Wysakowicz commented on FLINK-18161: -- The simplest fix would be to set th

[jira] [Commented] (FLINK-18161) Changing parallelism is not possible in sql-client.sh

2020-06-05 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126873#comment-17126873 ] Dawid Wysakowicz commented on FLINK-18161: -- {{parallelism.default}} works from

[GitHub] [flink] flinkbot edited a comment on pull request #11586: [FLINK-5552][runtime] make JMXServer static per JVM

2020-06-05 Thread GitBox
flinkbot edited a comment on pull request #11586: URL: https://github.com/apache/flink/pull/11586#issuecomment-606958289 ## CI report: * 613a5fd798911229926144246b94635cde46c6ed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-18096) Generated avro formats should support user specified name and namespace

2020-06-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126874#comment-17126874 ] Jark Wu commented on FLINK-18096: - I see. Thanks for the explanation [~sjwiesman]. > Ge

[jira] [Updated] (FLINK-18161) Changing parallelism is not possible in sql-client.sh

2020-06-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-18161: Fix Version/s: 1.11.0 > Changing parallelism is not possible in sql-client.sh > --

[jira] [Commented] (FLINK-18161) Changing parallelism is not possible in sql-client.sh

2020-06-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126872#comment-17126872 ] Jark Wu commented on FLINK-18161: - Does {{parallelism.default}} works? > Changing para

[jira] [Comment Edited] (FLINK-18096) Generated avro formats should support user specified name and namespace

2020-06-05 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126868#comment-17126868 ] Seth Wiesman edited comment on FLINK-18096 at 6/5/20, 3:19 PM: ---

[jira] [Commented] (FLINK-18096) Generated avro formats should support user specified name and namespace

2020-06-05 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126868#comment-17126868 ] Seth Wiesman commented on FLINK-18096: -- I certainly want to see registry support in

  1   2   3   4   5   >