[GitHub] [flink] lindong28 commented on a change in pull request #15161: [FLINK-20114][connector/kafka,common] Fix a few KafkaSource-related bugs

2021-03-23 Thread GitBox
lindong28 commented on a change in pull request #15161: URL: https://github.com/apache/flink/pull/15161#discussion_r600194416 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContextTest.java ## @@ -182,6 +191,44 @@ public

[GitHub] [flink] fsk119 commented on pull request #15332: [FLINK-21701][sql-client] Extend the "RESET" syntax in the SQL Client

2021-03-23 Thread GitBox
fsk119 commented on pull request #15332: URL: https://github.com/apache/flink/pull/15332#issuecomment-805523390 It looks good to me. CC @wuchong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] fsk119 commented on a change in pull request #15332: [FLINK-21701][sql-client] Extend the "RESET" syntax in the SQL Client

2021-03-23 Thread GitBox
fsk119 commented on a change in pull request #15332: URL: https://github.com/apache/flink/pull/15332#discussion_r600193100 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java ## @@ -424,8 +424,14 @@ private void

[GitHub] [flink] xintongsong commented on a change in pull request #15273: [FLINK-21800][core] Guard MemorySegment against concurrent frees.

2021-03-23 Thread GitBox
xintongsong commented on a change in pull request #15273: URL: https://github.com/apache/flink/pull/15273#discussion_r600192987 ## File path: flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java ## @@ -217,10 +222,14 @@ public int size() { /** *

[GitHub] [flink] xintongsong commented on a change in pull request #15273: [FLINK-21800][core] Guard MemorySegment against concurrent frees.

2021-03-23 Thread GitBox
xintongsong commented on a change in pull request #15273: URL: https://github.com/apache/flink/pull/15273#discussion_r600192987 ## File path: flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java ## @@ -217,10 +222,14 @@ public int size() { /** *

[GitHub] [flink] flinkbot commented on pull request #15353: [FLINK-21940][table] Rowtime/proctime should be obtained from getTimestamp instead of getLong

2021-03-23 Thread GitBox
flinkbot commented on pull request #15353: URL: https://github.com/apache/flink/pull/15353#issuecomment-805519624 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-21940) Rowtime/proctime should be obtained from getTimestamp instead of getLong

2021-03-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21940: --- Labels: pull-request-available (was: ) > Rowtime/proctime should be obtained from

[GitHub] [flink] JingsongLi opened a new pull request #15353: [FLINK-21940][table] Rowtime/proctime should be obtained from getTimestamp instead of getLong

2021-03-23 Thread GitBox
JingsongLi opened a new pull request #15353: URL: https://github.com/apache/flink/pull/15353 ## What is the purpose of the change Rowtime/proctime should be obtained from getTimestamp instead of getLong. Because the input row is BinaryRowData, so legacy `getLong` can work.

[GitHub] [flink] curcur edited a comment on pull request #15323: [FLINK-21857] StackOverflow for large parallelism jobs when processing EndOfChannelStateEvent

2021-03-23 Thread GitBox
curcur edited a comment on pull request #15323: URL: https://github.com/apache/flink/pull/15323#issuecomment-805515175 I think the amended approach is a more natural way to handle an "end of recovery" event. **One suggestion** is to add one more test for

[GitHub] [flink] curcur commented on pull request #15323: [FLINK-21857] StackOverflow for large parallelism jobs when processing EndOfChannelStateEvent

2021-03-23 Thread GitBox
curcur commented on pull request #15323: URL: https://github.com/apache/flink/pull/15323#issuecomment-805515175 I think the amended approach is a more natural way to handle an "end of recovery" event. One suggestion is to add one more test for "InputStatus.END_OF_RECOVERY".

[GitHub] [flink] kezhuw commented on pull request #15344: [FLINK-21564][tests] Don't call condition or throw exception after condition met for CommonTestUtils.waitUntil

2021-03-23 Thread GitBox
kezhuw commented on pull request #15344: URL: https://github.com/apache/flink/pull/15344#issuecomment-805511312 @flinkbot attention @StephanEwen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] kezhuw commented on pull request #15344: [FLINK-21564][tests] Don't call condition or throw exception after condition met for CommonTestUtils.waitUntil

2021-03-23 Thread GitBox
kezhuw commented on pull request #15344: URL: https://github.com/apache/flink/pull/15344#issuecomment-805510806 Failure is unrelated and reported to FLINK-20329 (Elasticsearch7DynamicSinkITCase hangs). -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] curcur commented on a change in pull request #15323: [FLINK-21857] StackOverflow for large parallelism jobs when processing EndOfChannelStateEvent

2021-03-23 Thread GitBox
curcur commented on a change in pull request #15323: URL: https://github.com/apache/flink/pull/15323#discussion_r600150920 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/CheckpointedInputGate.java ## @@ -198,9 +197,6 @@

[jira] [Commented] (FLINK-20329) Elasticsearch7DynamicSinkITCase hangs

2021-03-23 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307580#comment-17307580 ] Kezhu Wang commented on FLINK-20329: Another case: 

[GitHub] [flink] flinkbot edited a comment on pull request #15352: [FLINK-21581][core] Remove @PublicEvolving from RuntimeContext.getJobID

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15352: URL: https://github.com/apache/flink/pull/15352#issuecomment-805496444 ## CI report: * 8fa482cb4e2822a46447266e626b96d0a966d7b2 Azure:

[GitHub] [flink] kezhuw commented on pull request #15331: [FLINK-21626][core] Make RuntimeContext.jobID non-optional

2021-03-23 Thread GitBox
kezhuw commented on pull request #15331: URL: https://github.com/apache/flink/pull/15331#issuecomment-805506049 @rkhachatryan @dawidwys Hi all, I have done my round. Could you take another look for this @dawidwys ? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] rkhachatryan commented on pull request #15173: [FLINK-21367][Connectors / JDBC] Support objectReuse in JDBC sink

2021-03-23 Thread GitBox
rkhachatryan commented on pull request #15173: URL: https://github.com/apache/flink/pull/15173#issuecomment-805505956 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] kezhuw commented on a change in pull request #15273: [FLINK-21800][core] Guard MemorySegment against concurrent frees.

2021-03-23 Thread GitBox
kezhuw commented on a change in pull request #15273: URL: https://github.com/apache/flink/pull/15273#discussion_r600180203 ## File path: flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java ## @@ -217,10 +222,14 @@ public int size() { /** *

[GitHub] [flink] rkhachatryan commented on a change in pull request #15119: [FLINK-21736][state] Introduce state scope latency tracking metrics

2021-03-23 Thread GitBox
rkhachatryan commented on a change in pull request #15119: URL: https://github.com/apache/flink/pull/15119#discussion_r600179518 ## File path: flink-runtime/pom.xml ## @@ -56,6 +56,12 @@ under the License. ${project.version} +

[GitHub] [flink] rkhachatryan commented on a change in pull request #15119: [FLINK-21736][state] Introduce state scope latency tracking metrics

2021-03-23 Thread GitBox
rkhachatryan commented on a change in pull request #15119: URL: https://github.com/apache/flink/pull/15119#discussion_r600176709 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/metrics/LatencyTrackingStateConfig.java ## @@ -0,0 +1,117 @@ +/* + *

[GitHub] [flink] flinkbot commented on pull request #15352: [FLINK-21581][core] Remove @PublicEvolving from RuntimeContext.getJobID

2021-03-23 Thread GitBox
flinkbot commented on pull request #15352: URL: https://github.com/apache/flink/pull/15352#issuecomment-805496444 ## CI report: * 8fa482cb4e2822a46447266e626b96d0a966d7b2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #15351: Only for debug some tests and trigger ci running

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15351: URL: https://github.com/apache/flink/pull/15351#issuecomment-805475704 ## CI report: * f1ebcc9ca219b38a038cc25f6e0a426c8609e9d9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15331: [FLINK-21626][core] Make RuntimeContext.jobID non-optional

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15331: URL: https://github.com/apache/flink/pull/15331#issuecomment-804297575 ## CI report: * cbf4ab0e0683981a078a1b16e94d0406dc5ac8e9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15323: [FLINK-21857] StackOverflow for large parallelism jobs when processing EndOfChannelStateEvent

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15323: URL: https://github.com/apache/flink/pull/15323#issuecomment-804037491 ## CI report: * 501c55365989bb81e7713a4fb8f07029ddecdf2f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15148: [FLINK-21731] Add benchmarks for DefaultScheduler's creation, scheduling and deploying

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15148: URL: https://github.com/apache/flink/pull/15148#issuecomment-796572621 ## CI report: * 25e912512943d29b15c8fa5a22adc5cf0e2294a1 Azure:

[GitHub] [flink] rkhachatryan commented on a change in pull request #15119: [FLINK-21736][state] Introduce state scope latency tracking metrics

2021-03-23 Thread GitBox
rkhachatryan commented on a change in pull request #15119: URL: https://github.com/apache/flink/pull/15119#discussion_r600171838 ## File path: flink-core/src/main/java/org/apache/flink/configuration/StateBackendOptions.java ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[GitHub] [flink] wuchong commented on a change in pull request #15265: [FLINK-21836][table-api] Introduce ParseStrategyParser

2021-03-23 Thread GitBox
wuchong commented on a change in pull request #15265: URL: https://github.com/apache/flink/pull/15265#discussion_r600144592 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/parse/ParseStrategyParser.java ## @@ -0,0 +1,114 @@ +/*

[GitHub] [flink] flinkbot commented on pull request #15352: [FLINK-21581][core] Remove @PublicEvolving from RuntimeContext.getJobID

2021-03-23 Thread GitBox
flinkbot commented on pull request #15352: URL: https://github.com/apache/flink/pull/15352#issuecomment-805486235 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #15351: Only for debug some tests and trigger ci running

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15351: URL: https://github.com/apache/flink/pull/15351#issuecomment-805475704 ## CI report: * f1ebcc9ca219b38a038cc25f6e0a426c8609e9d9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15331: [FLINK-21626][core] Make RuntimeContext.jobID non-optional

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15331: URL: https://github.com/apache/flink/pull/15331#issuecomment-804297575 ## CI report: * cbf4ab0e0683981a078a1b16e94d0406dc5ac8e9 Azure:

[GitHub] [flink] rkhachatryan opened a new pull request #15352: [FLINK-21581][core] Remove @PublicEvolving from RuntimeContext.getJobID

2021-03-23 Thread GitBox
rkhachatryan opened a new pull request #15352: URL: https://github.com/apache/flink/pull/15352 ## What is the purpose of the change Remove @PublicEvolving from RuntimeContext.getJobID to make the API more consistent. The method is added to japicmp ignore list. ##

[GitHub] [flink] flinkbot edited a comment on pull request #15148: [FLINK-21731] Add benchmarks for DefaultScheduler's creation, scheduling and deploying

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15148: URL: https://github.com/apache/flink/pull/15148#issuecomment-796572621 ## CI report: * 25e912512943d29b15c8fa5a22adc5cf0e2294a1 Azure:

[jira] [Commented] (FLINK-21935) Remove "state.backend.async" option.

2021-03-23 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307562#comment-17307562 ] Yu Li commented on FLINK-21935: --- +1 to remove the option and synchronous snapshot support for heap

[jira] [Commented] (FLINK-21570) Add Job ID to RuntimeContext

2021-03-23 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307561#comment-17307561 ] Roman Khachatryan commented on FLINK-21570: --- Thanks for raising these concerns. I've reopened 

[jira] [Reopened] (FLINK-21581) Add PublicEvolving to RuntimeContext.jobId

2021-03-23 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan reopened FLINK-21581: --- Reopening to address concerns raised in

[GitHub] [flink] rkhachatryan commented on a change in pull request #15331: [FLINK-21626][core] Make RuntimeContext.jobID non-optional

2021-03-23 Thread GitBox
rkhachatryan commented on a change in pull request #15331: URL: https://github.com/apache/flink/pull/15331#discussion_r600153326 ## File path: flink-core/src/main/java/org/apache/flink/api/common/operators/CollectionExecutor.java ## @@ -110,7 +111,7 @@ public

[GitHub] [flink] flinkbot commented on pull request #15351: Only for debug some tests and trigger ci running

2021-03-23 Thread GitBox
flinkbot commented on pull request #15351: URL: https://github.com/apache/flink/pull/15351#issuecomment-805475704 ## CI report: * f1ebcc9ca219b38a038cc25f6e0a426c8609e9d9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #15332: [FLINK-21701][sql-client] Extend the "RESET" syntax in the SQL Client

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15332: URL: https://github.com/apache/flink/pull/15332#issuecomment-804297721 ## CI report: * 618f95c70e6f8e6fffac1171ff97856c8c6d38fb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15273: [FLINK-21800][core] Guard MemorySegment against concurrent frees.

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15273: URL: https://github.com/apache/flink/pull/15273#issuecomment-802508808 ## CI report: * d25b8d14546059db78a2ae8d391043604b729be8 Azure:

[jira] [Updated] (FLINK-21940) Rowtime/proctime should be obtained from getTimestamp instead of getLong

2021-03-23 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-21940: Component/s: Table SQL / Planner > Rowtime/proctime should be obtained from getTimestamp instead of

[jira] [Commented] (FLINK-21940) Rowtime/proctime should be obtained from getTimestamp instead of getLong

2021-03-23 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307549#comment-17307549 ] Jark Wu commented on FLINK-21940: - +1 > Rowtime/proctime should be obtained from getTimestamp instead

[jira] [Commented] (FLINK-21898) JobRetrievalITCase crash

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307548#comment-17307548 ] Guowei Ma commented on FLINK-21898: ---

[jira] [Commented] (FLINK-21745) JobMasterTest.testReconnectionAfterDisconnect hangs on azure

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307547#comment-17307547 ] Guowei Ma commented on FLINK-21745: ---

[jira] [Commented] (FLINK-21745) JobMasterTest.testReconnectionAfterDisconnect hangs on azure

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307546#comment-17307546 ] Guowei Ma commented on FLINK-21745: ---

[jira] [Commented] (FLINK-21895) IncrementalAggregateJsonPlanTest.testIncrementalAggregate fail

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307545#comment-17307545 ] Guowei Ma commented on FLINK-21895: ---

[jira] [Commented] (FLINK-21896) GroupAggregateJsonPlanTest.testDistinctAggCalls fail

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307544#comment-17307544 ] Guowei Ma commented on FLINK-21896: ---

[jira] [Commented] (FLINK-21416) FileBufferReaderITCase.testSequentialReading fails on azure

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307543#comment-17307543 ] Guowei Ma commented on FLINK-21416: ---

[jira] [Comment Edited] (FLINK-21103) E2e tests time out on azure

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307539#comment-17307539 ] Guowei Ma edited comment on FLINK-21103 at 3/24/21, 4:00 AM: - on branch 1.12

[jira] [Comment Edited] (FLINK-21103) E2e tests time out on azure

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305801#comment-17305801 ] Guowei Ma edited comment on FLINK-21103 at 3/24/21, 3:59 AM: - on branch 1.11

[jira] [Comment Edited] (FLINK-21103) E2e tests time out on azure

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305912#comment-17305912 ] Guowei Ma edited comment on FLINK-21103 at 3/24/21, 3:59 AM: - on branch 1.12

[jira] [Commented] (FLINK-21103) E2e tests time out on azure

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307542#comment-17307542 ] Guowei Ma commented on FLINK-21103: --- on branch 1.13

[jira] [Updated] (FLINK-21942) KubernetesLeaderRetrievalDriver not closed after terminated which lead to connection leak

2021-03-23 Thread Yi Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Tang updated FLINK-21942: Description: Looks like KubernetesLeaderRetrievalDriver is not closed even if the

[jira] [Created] (FLINK-21942) KubernetesLeaderRetrievalDriver not closed after terminated which lead to connection leak

2021-03-23 Thread Yi Tang (Jira)
Yi Tang created FLINK-21942: --- Summary: KubernetesLeaderRetrievalDriver not closed after terminated which lead to connection leak Key: FLINK-21942 URL: https://issues.apache.org/jira/browse/FLINK-21942

[jira] [Created] (FLINK-21941) testSavepointRescalingOutPartitionedOperatorStateList fail

2021-03-23 Thread Guowei Ma (Jira)
Guowei Ma created FLINK-21941: - Summary: testSavepointRescalingOutPartitionedOperatorStateList fail Key: FLINK-21941 URL: https://issues.apache.org/jira/browse/FLINK-21941 Project: Flink Issue

[jira] [Comment Edited] (FLINK-21103) E2e tests time out on azure

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307539#comment-17307539 ] Guowei Ma edited comment on FLINK-21103 at 3/24/21, 3:54 AM: - on brach 1.12

[jira] [Commented] (FLINK-21103) E2e tests time out on azure

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307539#comment-17307539 ] Guowei Ma commented on FLINK-21103: --- on brach 1.11

[jira] [Commented] (FLINK-21235) leaderChange_withBlockingJobManagerTermination_doesNotAffectNewLeader hang

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307533#comment-17307533 ] Guowei Ma commented on FLINK-21235: ---

[jira] [Created] (FLINK-21940) Rowtime/proctime should be obtained from getTimestamp instead of getLong

2021-03-23 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-21940: Summary: Rowtime/proctime should be obtained from getTimestamp instead of getLong Key: FLINK-21940 URL: https://issues.apache.org/jira/browse/FLINK-21940 Project:

[GitHub] [flink] flinkbot commented on pull request #15351: Only for debug some tests and trigger ci running

2021-03-23 Thread GitBox
flinkbot commented on pull request #15351: URL: https://github.com/apache/flink/pull/15351#issuecomment-805463642 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-20461) YARNFileReplicationITCase.testPerJobModeWithDefaultFileReplication

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guowei Ma updated FLINK-20461: -- Affects Version/s: 1.13.0 > YARNFileReplicationITCase.testPerJobModeWithDefaultFileReplication >

[GitHub] [flink] flinkbot edited a comment on pull request #15332: [FLINK-21701][sql-client] Extend the "RESET" syntax in the SQL Client

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15332: URL: https://github.com/apache/flink/pull/15332#issuecomment-804297721 ## CI report: * 618f95c70e6f8e6fffac1171ff97856c8c6d38fb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15273: [FLINK-21800][core] Guard MemorySegment against concurrent frees.

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15273: URL: https://github.com/apache/flink/pull/15273#issuecomment-802508808 ## CI report: * d25b8d14546059db78a2ae8d391043604b729be8 Azure:

[jira] [Commented] (FLINK-20461) YARNFileReplicationITCase.testPerJobModeWithDefaultFileReplication

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307532#comment-17307532 ] Guowei Ma commented on FLINK-20461: ---

[GitHub] [flink] flinkbot edited a comment on pull request #15119: [FLINK-21736][state] Introduce state scope latency tracking metrics

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15119: URL: https://github.com/apache/flink/pull/15119#issuecomment-792934307 ## CI report: * f2de7e07c66e6dda2b4caef75e2f1dfde9f0e5c3 Azure:

[GitHub] [flink] Thesharing commented on a change in pull request #15310: [FLINK-21330] Optimize the performance of PipelinedRegionSchedulingStrategy

2021-03-23 Thread GitBox
Thesharing commented on a change in pull request #15310: URL: https://github.com/apache/flink/pull/15310#discussion_r600139542 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategy.java ## @@ -49,12 +51,12 @@

[GitHub] [flink] gaoyunhaii opened a new pull request #15351: Only for debug some tests and trigger ci running

2021-03-23 Thread GitBox
gaoyunhaii opened a new pull request #15351: URL: https://github.com/apache/flink/pull/15351 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring

[GitHub] [flink] wsry commented on a change in pull request #15199: [FLINK-20740][network] Introduce a separated buffer pool and a separated thread pool for sort-merge blocking shuffle

2021-03-23 Thread GitBox
wsry commented on a change in pull request #15199: URL: https://github.com/apache/flink/pull/15199#discussion_r600139401 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/BatchShuffleReadBufferPool.java ## @@ -0,0 +1,353 @@ +/* + * Licensed to the

[GitHub] [flink] Thesharing commented on a change in pull request #15310: [FLINK-21330] Optimize the performance of PipelinedRegionSchedulingStrategy

2021-03-23 Thread GitBox
Thesharing commented on a change in pull request #15310: URL: https://github.com/apache/flink/pull/15310#discussion_r600139119 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultSchedulingPipelinedRegion.java ## @@ -62,21 +85,34 @@

[GitHub] [flink] wsry commented on a change in pull request #15199: [FLINK-20740][network] Introduce a separated buffer pool and a separated thread pool for sort-merge blocking shuffle

2021-03-23 Thread GitBox
wsry commented on a change in pull request #15199: URL: https://github.com/apache/flink/pull/15199#discussion_r600138798 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/BatchShuffleReadBufferPool.java ## @@ -0,0 +1,265 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-21603) SQLClientKafkaITCase failed due to unexpected end of file

2021-03-23 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307530#comment-17307530 ] Guowei Ma commented on FLINK-21603: ---

[GitHub] [flink] SteNicholas commented on pull request #15349: [FLINK-21937][python] Support batch mode in Python DataStream API for basic operations

2021-03-23 Thread GitBox
SteNicholas commented on pull request #15349: URL: https://github.com/apache/flink/pull/15349#issuecomment-805460793 @dianfu Thanks for your pull request. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Closed] (FLINK-21698) Disable problematic cast conversion between NUMERIC type and TIMESTAMP type

2021-03-23 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-21698. --- Fix Version/s: 1.13.0 Resolution: Fixed Fixed in master: c8b0da5aaa71fa0f1f797f30fc2414e45f7cd78f >

[GitHub] [flink] wuchong closed pull request #15132: [FLINK-21698][table-planner] Disable problematic cast conversion between NUMERIC type and TIMESTAMP type

2021-03-23 Thread GitBox
wuchong closed pull request #15132: URL: https://github.com/apache/flink/pull/15132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] flinkbot edited a comment on pull request #15350: [FLINK-21629][python] Support Python UDAF in Sliding Window

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15350: URL: https://github.com/apache/flink/pull/15350#issuecomment-805441787 ## CI report: * 18d5d7a39ec309bd76ea95c67db75fc612a5f9d3 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15349: [FLINK-21937][python] Support batch mode in Python DataStream API for basic operations

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15349: URL: https://github.com/apache/flink/pull/15349#issuecomment-805441726 ## CI report: * 0210004ca94697eb0d1e88436f18c347ead32694 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15149: [FLINK-21294][python] Support state access API for the map/flat_map operation of Python ConnectedStreams

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15149: URL: https://github.com/apache/flink/pull/15149#issuecomment-796635889 ## CI report: * 44b79b3ce008d71fda142e56288d30ac19e2ad40 UNKNOWN * ec90293567a79dca2d23941aca6019f5f4c7d36e UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #15119: [FLINK-21736][state] Introduce state scope latency tracking metrics

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15119: URL: https://github.com/apache/flink/pull/15119#issuecomment-792934307 ## CI report: * f2de7e07c66e6dda2b4caef75e2f1dfde9f0e5c3 Azure:

[GitHub] [flink] xintongsong commented on a change in pull request #15273: [FLINK-21800][core] Guard MemorySegment against concurrent frees.

2021-03-23 Thread GitBox
xintongsong commented on a change in pull request #15273: URL: https://github.com/apache/flink/pull/15273#discussion_r600131068 ## File path: flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java ## @@ -217,10 +222,14 @@ public int size() { /** *

[jira] [Updated] (FLINK-21731) Add benchmarks for DefaultScheduler's creation, scheduling and deploying

2021-03-23 Thread Zhilong Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhilong Hong updated FLINK-21731: - Description: We notice that {{DefaultScheduler#allocateSlotsAndDeploy}} is not covered in the

[jira] [Created] (FLINK-21939) Support batch mode in Python DataStream API for process operation

2021-03-23 Thread Dian Fu (Jira)
Dian Fu created FLINK-21939: --- Summary: Support batch mode in Python DataStream API for process operation Key: FLINK-21939 URL: https://issues.apache.org/jira/browse/FLINK-21939 Project: Flink

[GitHub] [flink] xiangtao commented on a change in pull request #15332: [FLINK-21701][sql-client] Extend the "RESET" syntax in the SQL Client

2021-03-23 Thread GitBox
xiangtao commented on a change in pull request #15332: URL: https://github.com/apache/flink/pull/15332#discussion_r600125968 ## File path: flink-table/flink-sql-client/src/test/resources/sql/set.q ## @@ -104,3 +104,70 @@ Was expecting one of: "," ... !error + +# test

[GitHub] [flink] Myasuka commented on pull request #15119: [FLINK-21736][state] Introduce state scope latency tracking metrics

2021-03-23 Thread GitBox
Myasuka commented on pull request #15119: URL: https://github.com/apache/flink/pull/15119#issuecomment-805447550 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-21938) Add documentation about how to test Python UDFs

2021-03-23 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307521#comment-17307521 ] Dian Fu commented on FLINK-21938: - [~Yik San Chan] Great! Thanks a lot! I have assigned the ticket to

[jira] [Commented] (FLINK-21688) we use setIncreaseParallelism function, can cause slow flush in restore

2021-03-23 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307520#comment-17307520 ] xiaogang zhou commented on FLINK-21688: --- [~yunta] Hello, Can you please help understand why using

[jira] [Assigned] (FLINK-21938) Add documentation about how to test Python UDFs

2021-03-23 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-21938: --- Assignee: Yik San Chan > Add documentation about how to test Python UDFs >

[GitHub] [flink] flinkbot commented on pull request #15350: [FLINK-21629][python] Support Python UDAF in Sliding Window

2021-03-23 Thread GitBox
flinkbot commented on pull request #15350: URL: https://github.com/apache/flink/pull/15350#issuecomment-805441787 ## CI report: * 18d5d7a39ec309bd76ea95c67db75fc612a5f9d3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #15349: [FLINK-21937][python] Support batch mode in Python DataStream API for basic operations

2021-03-23 Thread GitBox
flinkbot commented on pull request #15349: URL: https://github.com/apache/flink/pull/15349#issuecomment-805441726 ## CI report: * 0210004ca94697eb0d1e88436f18c347ead32694 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #15117: [FLINK-21655] [table-planner-blink] Fix incorrect simplification for coalesce call on a groupingsets' result

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15117: URL: https://github.com/apache/flink/pull/15117#issuecomment-792736135 ## CI report: * 79d036eb98a74f28c87ada0e2be3b6947f94a965 Azure:

[GitHub] [flink] flinkbot commented on pull request #15350: [FLINK-21629][python] Support Python UDAF in Sliding Window

2021-03-23 Thread GitBox
flinkbot commented on pull request #15350: URL: https://github.com/apache/flink/pull/15350#issuecomment-805438428 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Commented] (FLINK-21938) Add documentation about how to test Python UDFs

2021-03-23 Thread Yik San Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307518#comment-17307518 ] Yik San Chan commented on FLINK-21938: -- Do you mind if I work on the issue, given I raise the

[jira] [Updated] (FLINK-21629) Support Python UDAF in Sliding Window

2021-03-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21629: --- Labels: pull-request-available (was: ) > Support Python UDAF in Sliding Window >

[GitHub] [flink] HuangXingBo opened a new pull request #15350: [FLINK-21629][python] Support Python UDAF in Sliding Window

2021-03-23 Thread GitBox
HuangXingBo opened a new pull request #15350: URL: https://github.com/apache/flink/pull/15350 ## What is the purpose of the change *This pull request will support Python UDAF in Sliding Window* ## Brief change log - *Add `PanedWindowAssigner`,

[jira] [Created] (FLINK-21938) Add documentation about how to test Python UDFs

2021-03-23 Thread Dian Fu (Jira)
Dian Fu created FLINK-21938: --- Summary: Add documentation about how to test Python UDFs Key: FLINK-21938 URL: https://issues.apache.org/jira/browse/FLINK-21938 Project: Flink Issue Type:

[GitHub] [flink] flinkbot edited a comment on pull request #15149: [FLINK-21294][python] Support state access API for the map/flat_map operation of Python ConnectedStreams

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15149: URL: https://github.com/apache/flink/pull/15149#issuecomment-796635889 ## CI report: * 44b79b3ce008d71fda142e56288d30ac19e2ad40 UNKNOWN * ec90293567a79dca2d23941aca6019f5f4c7d36e UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #15117: [FLINK-21655] [table-planner-blink] Fix incorrect simplification for coalesce call on a groupingsets' result

2021-03-23 Thread GitBox
flinkbot edited a comment on pull request #15117: URL: https://github.com/apache/flink/pull/15117#issuecomment-792736135 ## CI report: * 79d036eb98a74f28c87ada0e2be3b6947f94a965 Azure:

[GitHub] [flink] flinkbot commented on pull request #15349: [FLINK-21937][python] Support batch mode in Python DataStream API for basic operations

2021-03-23 Thread GitBox
flinkbot commented on pull request #15349: URL: https://github.com/apache/flink/pull/15349#issuecomment-805429839 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Closed] (FLINK-21794) Support retrieving slot details via rest api

2021-03-23 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-21794. Fix Version/s: 1.13.0 Resolution: Done Merged via: * master (1.13):

[GitHub] [flink] xintongsong closed pull request #15249: [FLINK-21794][metrics] Support retrieving slot details via rest api

2021-03-23 Thread GitBox
xintongsong closed pull request #15249: URL: https://github.com/apache/flink/pull/15249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Updated] (FLINK-21937) Support batch mode in Python DataStream API for basic operations

2021-03-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21937: --- Labels: pull-request-available (was: ) > Support batch mode in Python DataStream API for

[GitHub] [flink] lindong28 commented on a change in pull request #15161: [FLINK-20114][connector/kafka,common] Fix a few KafkaSource-related bugs

2021-03-23 Thread GitBox
lindong28 commented on a change in pull request #15161: URL: https://github.com/apache/flink/pull/15161#discussion_r600110083 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java ## @@ -103,18 +106,22 @@ public

  1   2   3   4   5   6   >