[GitHub] [flink] lirui-apache commented on pull request #15555: [FLINK-21891][table-runtime-blink] Use FileSystem instance to delete the temporary directory '.staging_xxx'

2021-04-11 Thread GitBox
lirui-apache commented on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-817507684 > > The issue only happens for non-local FS. So if we want to add a test case, I think we should use `MiniDFSCluster` for it. > > Yes, and write a hive test case in

[jira] [Comment Edited] (FLINK-22205) Does it support gpu coding in flink?

2021-04-11 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319038#comment-17319038 ] Yangze Guo edited comment on FLINK-22205 at 4/12/21, 5:58 AM: -- I have a

[jira] [Updated] (FLINK-22204) Does it support rate-limiting in flink 1.12?

2021-04-11 Thread ying zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ying zhang updated FLINK-22204: --- Component/s: (was: API / DataSet) Table SQL / API Description: When I run

[jira] [Commented] (FLINK-22205) Does it support gpu coding in flink?

2021-04-11 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319038#comment-17319038 ] Yangze Guo commented on FLINK-22205: I have a [demo|https://github.com/KarmaGYZ/flink-mnist] which

[jira] [Commented] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319037#comment-17319037 ] Jamie Brandon commented on FLINK-22201: --- Ok, thanks. Should I open a separate issue for the

[jira] [Comment Edited] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319034#comment-17319034 ] Jark Wu edited comment on FLINK-22201 at 4/12/21, 5:50 AM: --- I think this

[jira] [Commented] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319034#comment-17319034 ] Jark Wu commented on FLINK-22201: - I think this behavior is expected, because the total transaction

[GitHub] [flink] flinkbot commented on pull request #15560: [FLINK-22191][python] Fix the thread safe problem in PythonSharedResources

2021-04-11 Thread GitBox
flinkbot commented on pull request #15560: URL: https://github.com/apache/flink/pull/15560#issuecomment-817499683 ## CI report: * b8e5218522d3eef11b638020d6f138b6e49fb889 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #15561: [FLINK-20695][ha] Clean up ha data for job if globally terminated

2021-04-11 Thread GitBox
flinkbot commented on pull request #15561: URL: https://github.com/apache/flink/pull/15561#issuecomment-817497743 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] lirui-apache commented on a change in pull request #15555: [FLINK-21891][table-runtime-blink] Use FileSystem instance to delete the temporary directory '.staging_xxx'

2021-04-11 Thread GitBox
lirui-apache commented on a change in pull request #1: URL: https://github.com/apache/flink/pull/1#discussion_r611337995 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemOutputFormat.java ## @@ -85,15 +85,26

[jira] [Updated] (FLINK-20695) Zookeeper node under leader and leaderlatch is not deleted after job finished

2021-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-20695: --- Labels: pull-request-available (was: ) > Zookeeper node under leader and leaderlatch is

[GitHub] [flink] itinycheng edited a comment on pull request #15555: [FLINK-21891][table-runtime-blink] Use FileSystem instance to delete the temporary directory '.staging_xxx'

2021-04-11 Thread GitBox
itinycheng edited a comment on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-817489231 > The issue only happens for non-local FS. So if we want to add a test case, I think we should use `MiniDFSCluster` for it. Yes, and write a hive test case in

[GitHub] [flink] yittg opened a new pull request #15561: [FLINK-20695][ha] Clean up ha data for job if globally terminated

2021-04-11 Thread GitBox
yittg opened a new pull request #15561: URL: https://github.com/apache/flink/pull/15561 ## What is the purpose of the change At the moment Flink only cleans up the ha data (e.g. K8s ConfigMaps, or Zookeeper nodes) when shutting down the cluster. This is not enough for a

[jira] [Commented] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319030#comment-17319030 ] Jamie Brandon commented on FLINK-22201: --- In the branch where I believed I was running in batch

[jira] [Comment Edited] (FLINK-21850) Improve document and config description of sort-merge blocking shuffle

2021-04-11 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319029#comment-17319029 ] Guowei Ma edited comment on FLINK-21850 at 4/12/21, 5:27 AM: - Fixed in

[jira] [Updated] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jamie Brandon updated FLINK-22201: -- Attachment: config.toml > Incorrect output for simple sql query >

[jira] [Updated] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jamie Brandon updated FLINK-22201: -- Attachment: flink-total-timeseries.png > Incorrect output for simple sql query >

[GitHub] [flink] itinycheng edited a comment on pull request #15555: [FLINK-21891][table-runtime-blink] Use FileSystem instance to delete the temporary directory '.staging_xxx'

2021-04-11 Thread GitBox
itinycheng edited a comment on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-817489231 > The issue only happens for non-local FS. So if we want to add a test case, I think we should use `MiniDFSCluster` for it. Yes, and write a hive test case in

[GitHub] [flink] itinycheng commented on pull request #15555: [FLINK-21891][table-runtime-blink] Use FileSystem instance to delete the temporary directory '.staging_xxx'

2021-04-11 Thread GitBox
itinycheng commented on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-817489231 > The issue only happens for non-local FS. So if we want to add a test case, I think we should use `MiniDFSCluster` for it. Yes, and write a hive test case in

[GitHub] [flink] flinkbot commented on pull request #15560: [FLINK-22191][python] Fix the thread safe problem in PythonSharedResources

2021-04-11 Thread GitBox
flinkbot commented on pull request #15560: URL: https://github.com/apache/flink/pull/15560#issuecomment-817487482 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #15559: [FLINK-21627][table-planner-blink] The digest of TableScan & Sink should consider table hints

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15559: URL: https://github.com/apache/flink/pull/15559#issuecomment-817479787 ## CI report: * 6a1b2440d31eb63629599700ddcf32cd40595fc9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15558: [FLINK-22064][sql-client] Support ADD JAR command in sql client

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15558: URL: https://github.com/apache/flink/pull/15558#issuecomment-817479735 ## CI report: * e97df4a4d121657397cf6a7abba8e386883a73cb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15548: [FLINK-22082][planner] Nested projection push down doesn't work for d…

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15548: URL: https://github.com/apache/flink/pull/15548#issuecomment-816538966 ## CI report: * 5563d82537bdc6255d50a25408837658b9a6a8b7 Azure:

[jira] [Updated] (FLINK-22191) PyFlinkStreamUserDefinedFunctionTests.test_udf_in_join_condition_2 fail due to NPE

2021-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-22191: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] HuangXingBo opened a new pull request #15560: [FLINK-22191][python] Fix the thread safe problem in PythonSharedResources

2021-04-11 Thread GitBox
HuangXingBo opened a new pull request #15560: URL: https://github.com/apache/flink/pull/15560 ## What is the purpose of the change *This pull request will fix the thread safe problem in `PythonSharedResources`* ## Brief change log - *Set the method

[GitHub] [flink] itinycheng removed a comment on pull request #15555: [FLINK-21891][table-runtime-blink] Use FileSystem instance to delete the temporary directory '.staging_xxx'

2021-04-11 Thread GitBox
itinycheng removed a comment on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-817482175 > The issue only happens for non-local FS. So if we want to add a test case, I think we should use `MiniDFSCluster` for it. Agree. -- This is an automated

[jira] [Comment Edited] (FLINK-22191) PyFlinkStreamUserDefinedFunctionTests.test_udf_in_join_condition_2 fail due to NPE

2021-04-11 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319004#comment-17319004 ] Guowei Ma edited comment on FLINK-22191 at 4/12/21, 5:08 AM: -

[GitHub] [flink] itinycheng commented on pull request #15555: [FLINK-21891][table-runtime-blink] Use FileSystem instance to delete the temporary directory '.staging_xxx'

2021-04-11 Thread GitBox
itinycheng commented on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-817482175 > The issue only happens for non-local FS. So if we want to add a test case, I think we should use `MiniDFSCluster` for it. Agree. -- This is an automated message

[jira] [Created] (FLINK-22205) Does it support gpu coding in flink?

2021-04-11 Thread ying zhang (Jira)
ying zhang created FLINK-22205: -- Summary: Does it support gpu coding in flink? Key: FLINK-22205 URL: https://issues.apache.org/jira/browse/FLINK-22205 Project: Flink Issue Type: Task

[jira] [Closed] (FLINK-21850) Improve document and config description of sort-merge blocking shuffle

2021-04-11 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guowei Ma closed FLINK-21850. - Resolution: Fixed This is merged to master 725d82310a398d14da307f91e0cea6c8767d4e28. > Improve

[GitHub] [flink] itinycheng commented on a change in pull request #15555: [FLINK-21891][table-runtime-blink] Use FileSystem instance to delete the temporary directory '.staging_xxx'

2021-04-11 Thread GitBox
itinycheng commented on a change in pull request #1: URL: https://github.com/apache/flink/pull/1#discussion_r611327835 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemOutputFormat.java ## @@ -85,15 +85,26

[GitHub] [flink] flinkbot commented on pull request #15558: [FLINK-22064][sql-client] Support ADD JAR command in sql client

2021-04-11 Thread GitBox
flinkbot commented on pull request #15558: URL: https://github.com/apache/flink/pull/15558#issuecomment-817479735 ## CI report: * e97df4a4d121657397cf6a7abba8e386883a73cb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #15559: [FLINK-21627][table-planner-blink] The digest of TableScan & Sink should consider table hints

2021-04-11 Thread GitBox
flinkbot commented on pull request #15559: URL: https://github.com/apache/flink/pull/15559#issuecomment-817479787 ## CI report: * 6a1b2440d31eb63629599700ddcf32cd40595fc9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #15557: [FLINK-21996][coordination] - Part one: Tests and adjusted threading model

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15557: URL: https://github.com/apache/flink/pull/15557#issuecomment-817412419 ## CI report: * eea2bacf39812a5d3ec6f6635a30207b6f2a486a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15548: [FLINK-22082][planner] Nested projection push down doesn't work for d…

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15548: URL: https://github.com/apache/flink/pull/15548#issuecomment-816538966 ## CI report: * a327bfd95662ad081f6a586518e9236c1bd65c86 Azure:

[jira] [Commented] (FLINK-21627) When you insert multiple inserts with statementSet, you modify multiple inserts with OPTIONS('table-name '=' XXX '), but only the first one takes effect

2021-04-11 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319027#comment-17319027 ] godfrey he commented on FLINK-21627: [~apach...@163.com] thanks for reporting this, The reason is

[GitHub] [flink] godfreyhe commented on pull request #15559: [FLINK-21627][table-planner-blink] The digest of TableScan & Sink should consider table hints

2021-04-11 Thread GitBox
godfreyhe commented on pull request #15559: URL: https://github.com/apache/flink/pull/15559#issuecomment-817476987 cc @wuchong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #15559: [FLINK-21627][table-planner-blink] The digest of TableScan & Sink should consider table hints

2021-04-11 Thread GitBox
flinkbot commented on pull request #15559: URL: https://github.com/apache/flink/pull/15559#issuecomment-817475240 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-21627) When you insert multiple inserts with statementSet, you modify multiple inserts with OPTIONS('table-name '=' XXX '), but only the first one takes effect

2021-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21627: --- Labels: pull-request-available (was: ) > When you insert multiple inserts with

[GitHub] [flink] godfreyhe opened a new pull request #15559: [FLINK-21627][table-planner-blink] The digest of TableScan & Sink should consider table hints

2021-04-11 Thread GitBox
godfreyhe opened a new pull request #15559: URL: https://github.com/apache/flink/pull/15559 ## What is the purpose of the change *Currently, The digest of TableScan does not consider table hints, this can lead to one table used in different place with different table hints (such as

[jira] [Commented] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319023#comment-17319023 ] Kurt Young commented on FLINK-22201: Yes, for streaming mode, we are expecting the final result

[GitHub] [flink] flinkbot edited a comment on pull request #15493: [FLINK-22082][table planner] Fix nested projection push down doesn't …

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15493: URL: https://github.com/apache/flink/pull/15493#issuecomment-814016686 ## CI report: * 427db2f7e872b26886a351a6f565c74c2511b221 Azure:

[jira] [Commented] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319021#comment-17319021 ] Jamie Brandon commented on FLINK-22201: --- Ah, I misunderstood the documentation there. I will try

[jira] [Commented] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319020#comment-17319020 ] Kurt Young commented on FLINK-22201: [~jamii] You didn't really enabled batch execution mode because

[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client

2021-04-11 Thread xiangtao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319019#comment-17319019 ] xiangtao commented on FLINK-21464: -- [~fsk119] PR submitted : https://github.com/apache/flink/pull/15558

[GitHub] [flink] guoweiM closed pull request #15490: [FLINK-21850][docs] Improve config descriptions of sort-merge blocking shuffle and remove outdated document

2021-04-11 Thread GitBox
guoweiM closed pull request #15490: URL: https://github.com/apache/flink/pull/15490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319016#comment-17319016 ] Jamie Brandon commented on FLINK-22201: --- You can see the jar is run in batch mode

[GitHub] [flink] hehuiyuan commented on pull request #15250: [FLINK-20318][Connector/kafka]Fix cast question for properies() method in kafka ConnectorDescriptor

2021-04-11 Thread GitBox
hehuiyuan commented on pull request #15250: URL: https://github.com/apache/flink/pull/15250#issuecomment-817466334 Hi @JingsongLi , who can help look at this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] hehuiyuan removed a comment on pull request #15250: [FLINK-20318][Connector/kafka]Fix cast question for properies() method in kafka ConnectorDescriptor

2021-04-11 Thread GitBox
hehuiyuan removed a comment on pull request #15250: URL: https://github.com/apache/flink/pull/15250#issuecomment-817466142 HI @LingangJiang , who can help look at this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] hehuiyuan commented on pull request #15250: [FLINK-20318][Connector/kafka]Fix cast question for properies() method in kafka ConnectorDescriptor

2021-04-11 Thread GitBox
hehuiyuan commented on pull request #15250: URL: https://github.com/apache/flink/pull/15250#issuecomment-817466142 HI @LingangJiang , who can help look at this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] hehuiyuan removed a comment on pull request #15250: [FLINK-20318][Connector/kafka]Fix cast question for properies() method in kafka ConnectorDescriptor

2021-04-11 Thread GitBox
hehuiyuan removed a comment on pull request #15250: URL: https://github.com/apache/flink/pull/15250#issuecomment-802457256 hi @rmetzger , who can help look at this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] hehuiyuan removed a comment on pull request #15250: [FLINK-20318][Connector/kafka]Fix cast question for properies() method in kafka ConnectorDescriptor

2021-04-11 Thread GitBox
hehuiyuan removed a comment on pull request #15250: URL: https://github.com/apache/flink/pull/15250#issuecomment-809357467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #15558: [FLINK-22064][sql-client] Support ADD JAR command in sql client

2021-04-11 Thread GitBox
flinkbot commented on pull request #15558: URL: https://github.com/apache/flink/pull/15558#issuecomment-817465098 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] xiangtao opened a new pull request #15558: [FLINK-22064][sql-client] Support ADD JAR command in sql client

2021-04-11 Thread GitBox
xiangtao opened a new pull request #15558: URL: https://github.com/apache/flink/pull/15558 ## What is the purpose of the change *this change is to support "ADD JAR" statement in the SQL Client* ## Brief change log - *Add a method addJars in Executor* - *Add a

[GitHub] [flink] KurtYoung commented on a change in pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

2021-04-11 Thread GitBox
KurtYoung commented on a change in pull request #15155: URL: https://github.com/apache/flink/pull/15155#discussion_r611315623 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveDatabaseUtil.java ## @@ -44,7 +43,9 @@

[GitHub] [flink] guoweiM commented on pull request #15490: [FLINK-21850][docs] Improve config descriptions of sort-merge blocking shuffle and remove outdated document

2021-04-11 Thread GitBox
guoweiM commented on pull request #15490: URL: https://github.com/apache/flink/pull/15490#issuecomment-817463605 Thanks @wsry LGTM. I would do it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] flinkbot edited a comment on pull request #15547: [FLINK-22015][table-planner-blink] Exclude IS NULL from SEARCH operators

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15547: URL: https://github.com/apache/flink/pull/15547#issuecomment-816538871 ## CI report: * 14808493846d0a096cf51484c030fd564f3e3da0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15493: [FLINK-22082][table planner] Fix nested projection push down doesn't …

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15493: URL: https://github.com/apache/flink/pull/15493#issuecomment-814016686 ## CI report: * 427db2f7e872b26886a351a6f565c74c2511b221 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15155: URL: https://github.com/apache/flink/pull/15155#issuecomment-79675 ## CI report: * 3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7 Azure:

[GitHub] [flink] lirui-apache commented on pull request #15555: [FLINK-21891][table-runtime-blink] Use FileSystem instance to delete the temporary directory '.staging_xxx'

2021-04-11 Thread GitBox
lirui-apache commented on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-817461044 The issue only happens for non-local FS. So if we want to add a test case, I think we should use `MiniDFSCluster` for it. -- This is an automated message from the Apache

[jira] [Created] (FLINK-22204) Does it support rate-limiting in flink 1.12?

2021-04-11 Thread ying zhang (Jira)
ying zhang created FLINK-22204: -- Summary: Does it support rate-limiting in flink 1.12? Key: FLINK-22204 URL: https://issues.apache.org/jira/browse/FLINK-22204 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319009#comment-17319009 ] Jark Wu commented on FLINK-22201: - Hi [~jamii], according to your description: in streaming mode, the

[jira] [Created] (FLINK-22203) KafkaChangelogTableITCase.testKafkaCanalChangelogSource fail due to ConcurrentModificationException

2021-04-11 Thread Guowei Ma (Jira)
Guowei Ma created FLINK-22203: - Summary: KafkaChangelogTableITCase.testKafkaCanalChangelogSource fail due to ConcurrentModificationException Key: FLINK-22203 URL: https://issues.apache.org/jira/browse/FLINK-22203

[GitHub] [flink] lirui-apache commented on a change in pull request #15555: [FLINK-21891][table-runtime-blink] Use FileSystem instance to delete the temporary directory '.staging_xxx'

2021-04-11 Thread GitBox
lirui-apache commented on a change in pull request #1: URL: https://github.com/apache/flink/pull/1#discussion_r611310039 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemOutputFormat.java ## @@ -85,15 +85,26

[jira] [Updated] (FLINK-22191) PyFlinkStreamUserDefinedFunctionTests.test_udf_in_join_condition_2 fail due to NPE

2021-04-11 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-22191: Priority: Blocker (was: Critical) > PyFlinkStreamUserDefinedFunctionTests.test_udf_in_join_condition_2

[jira] [Updated] (FLINK-22191) PyFlinkStreamUserDefinedFunctionTests.test_udf_in_join_condition_2 fail due to NPE

2021-04-11 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guowei Ma updated FLINK-22191: -- Priority: Critical (was: Major) > PyFlinkStreamUserDefinedFunctionTests.test_udf_in_join_condition_2

[jira] [Commented] (FLINK-22191) PyFlinkStreamUserDefinedFunctionTests.test_udf_in_join_condition_2 fail due to NPE

2021-04-11 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319004#comment-17319004 ] Guowei Ma commented on FLINK-22191: --- test_timestamp_assigner_and_watermark_strategy fial aslo due to

[GitHub] [flink] flinkbot edited a comment on pull request #15547: [FLINK-22015][table-planner-blink] Exclude IS NULL from SEARCH operators

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15547: URL: https://github.com/apache/flink/pull/15547#issuecomment-816538871 ## CI report: * 14808493846d0a096cf51484c030fd564f3e3da0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15155: URL: https://github.com/apache/flink/pull/15155#issuecomment-79675 ## CI report: * 3985c48c6c4c43ea8d7c9fd924ee91d8c1608ae7 Azure:

[jira] [Commented] (FLINK-21659) Running HA per-job cluster (rocks, incremental) end-to-end test fails

2021-04-11 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319000#comment-17319000 ] Guowei Ma commented on FLINK-21659: --- we could find 22 completed checkpoints in the

[jira] [Commented] (FLINK-22100) BatchFileSystemITCaseBase.testPartialDynamicPartition fail because of no output for 900 seconds

2021-04-11 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318998#comment-17318998 ] Kurt Young commented on FLINK-22100:

[jira] [Closed] (FLINK-22193) HiveTableSinkITCase.testNonPartStreamingMrWrite fail

2021-04-11 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-22193. -- Resolution: Duplicate > HiveTableSinkITCase.testNonPartStreamingMrWrite fail >

[jira] [Closed] (FLINK-22192) HiveTableSinkITCase.testDefaultSerPartStreamingWrite fail

2021-04-11 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-22192. -- Resolution: Duplicate > HiveTableSinkITCase.testDefaultSerPartStreamingWrite fail >

[jira] [Commented] (FLINK-17274) Maven: Premature end of Content-Length delimited message body

2021-04-11 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318997#comment-17318997 ] Guowei Ma commented on FLINK-17274: ---

[jira] [Assigned] (FLINK-21247) flink iceberg table map cannot convert to datastream

2021-04-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-21247: Assignee: Shuo Cheng (was: Jingsong Lee) > flink iceberg table map cannot convert to

[jira] [Commented] (FLINK-17510) StreamingKafkaITCase. testKafka timeouts on downloading Kafka

2021-04-11 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318996#comment-17318996 ] Guowei Ma commented on FLINK-17510: ---

[jira] [Closed] (FLINK-15397) Streaming and batch has different value in the case of count function

2021-04-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-15397. Resolution: Duplicate > Streaming and batch has different value in the case of count function >

[jira] [Commented] (FLINK-17510) StreamingKafkaITCase. testKafka timeouts on downloading Kafka

2021-04-11 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318994#comment-17318994 ] Guowei Ma commented on FLINK-17510: ---

[jira] [Commented] (FLINK-17510) StreamingKafkaITCase. testKafka timeouts on downloading Kafka

2021-04-11 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318992#comment-17318992 ] Guowei Ma commented on FLINK-17510: ---

[jira] [Updated] (FLINK-18365) The same sql in a batch env and a streaming env has different value.

2021-04-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-18365: - Fix Version/s: (was: 1.13.0) 1.14.0 > The same sql in a batch env and a

[jira] [Updated] (FLINK-15397) Streaming and batch has different value in the case of count function

2021-04-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-15397: - Fix Version/s: (was: 1.13.0) > Streaming and batch has different value in the case of count

[jira] [Commented] (FLINK-22100) BatchFileSystemITCaseBase.testPartialDynamicPartition fail because of no output for 900 seconds

2021-04-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318990#comment-17318990 ] Jingsong Lee commented on FLINK-22100: -- OrcFileSystemITCase >

[GitHub] [flink] PatrickRen commented on pull request #15531: [FLINK-22147][connector/kafka] Refactor partition discovery logic in Kafka source enumerator

2021-04-11 Thread GitBox
PatrickRen commented on pull request #15531: URL: https://github.com/apache/flink/pull/15531#issuecomment-817450681 Hi @becketqin , could you please have a review on this PR? Thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Assigned] (FLINK-22191) PyFlinkStreamUserDefinedFunctionTests.test_udf_in_join_condition_2 fail due to NPE

2021-04-11 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo reassigned FLINK-22191: Assignee: Huang Xingbo >

[jira] [Commented] (FLINK-22075) Incorrect null outputs in left join

2021-04-11 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318989#comment-17318989 ] lincoln lee commented on FLINK-22075: - [~jamii] thanks for reporting this issue! I spent some

[GitHub] [flink] lirui-apache commented on pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

2021-04-11 Thread GitBox
lirui-apache commented on pull request #15155: URL: https://github.com/apache/flink/pull/15155#issuecomment-817446456 Thanks @KurtYoung for reviewing the PR. I have updated to address your comments. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] lirui-apache commented on a change in pull request #15155: [FLINK-21660][table-api-java][hive] Stop using is_generic to differen…

2021-04-11 Thread GitBox
lirui-apache commented on a change in pull request #15155: URL: https://github.com/apache/flink/pull/15155#discussion_r611298544 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveDatabaseUtil.java ## @@ -44,7 +43,9 @@

[GitHub] [flink] flinkbot edited a comment on pull request #15542: [FLINK-21950][core][test] Fix double-freeing memory segment in DemultiplexingRecordDeserializerTest.

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15542: URL: https://github.com/apache/flink/pull/15542#issuecomment-816526082 ## CI report: * 4df709052fed55aa1bb2def870db785dd62fa806 Azure:

[jira] [Updated] (FLINK-22189) Flink SQL Client Hudi batch write crashes JobManager

2021-04-11 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-22189: --- Priority: Major (was: Blocker) > Flink SQL Client Hudi batch write crashes JobManager >

[jira] [Created] (FLINK-22202) Thread safety in ParquetColumnarRowInputFormat

2021-04-11 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-22202: Summary: Thread safety in ParquetColumnarRowInputFormat Key: FLINK-22202 URL: https://issues.apache.org/jira/browse/FLINK-22202 Project: Flink Issue Type:

[jira] [Commented] (FLINK-22201) Incorrect output for simple sql query

2021-04-11 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318974#comment-17318974 ] Kurt Young commented on FLINK-22201: [~jamii] Thanks for the reporting. Could you provide some

[GitHub] [flink] flinkbot edited a comment on pull request #15542: [FLINK-21950][core][test] Fix double-freeing memory segment in DemultiplexingRecordDeserializerTest.

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15542: URL: https://github.com/apache/flink/pull/15542#issuecomment-816526082 ## CI report: * 4df709052fed55aa1bb2def870db785dd62fa806 Azure:

[jira] [Commented] (FLINK-18071) CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI

2021-04-11 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318962#comment-17318962 ] Kezhu Wang commented on FLINK-18071: Sure, I will take a look at. Thanks for delivery. [~sewen] >

[GitHub] [flink-statefun] flint-stone closed pull request #222: Supporting poll and index in ListState

2021-04-11 Thread GitBox
flint-stone closed pull request #222: URL: https://github.com/apache/flink-statefun/pull/222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [flink-statefun] flint-stone opened a new pull request #222: Supporting poll and index in ListState

2021-04-11 Thread GitBox
flint-stone opened a new pull request #222: URL: https://github.com/apache/flink-statefun/pull/222 as titled -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [flink] flinkbot edited a comment on pull request #15557: [FLINK-21996][coordination] - Part one: Tests and adjusted threading model

2021-04-11 Thread GitBox
flinkbot edited a comment on pull request #15557: URL: https://github.com/apache/flink/pull/15557#issuecomment-817412419 ## CI report: * eea2bacf39812a5d3ec6f6635a30207b6f2a486a Azure:

[jira] [Commented] (FLINK-22085) KafkaSourceLegacyITCase hangs/fails on azure

2021-04-11 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318958#comment-17318958 ] Dong Lin commented on FLINK-22085: -- [~dwysakowicz] Sure, I will take a look. > KafkaSourceLegacyITCase

[GitHub] [flink] flinkbot commented on pull request #15557: [FLINK-21996][coordination] - Part one: Tests and adjusted threading model

2021-04-11 Thread GitBox
flinkbot commented on pull request #15557: URL: https://github.com/apache/flink/pull/15557#issuecomment-817412419 ## CI report: * eea2bacf39812a5d3ec6f6635a30207b6f2a486a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Commented] (FLINK-18071) CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI

2021-04-11 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318955#comment-17318955 ] Stephan Ewen commented on FLINK-18071: -- [~kezhuw] I adopted your ideas into my work on FLINK-21996.

[GitHub] [flink] flinkbot commented on pull request #15557: [FLINK-21996][coordination] - Part one: Tests and adjusted threading model

2021-04-11 Thread GitBox
flinkbot commented on pull request #15557: URL: https://github.com/apache/flink/pull/15557#issuecomment-817406190 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

  1   2   >