KurtYoung commented on a change in pull request #15155:
URL: https://github.com/apache/flink/pull/15155#discussion_r611315623
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveDatabaseUtil.java
##########
@@ -44,7 +43,9 @@ static Database instantiateHiveDatabase(String databaseName,
CatalogDatabase dat
Map<String, String> properties = database.getProperties();
- boolean isGeneric = isGenericForCreate(properties);
+ properties.putIfAbsent(CatalogPropertiesUtil.IS_GENERIC, "true");
Review comment:
This might make sense during the process of `createDatabase` (This
method is only called in HiveCatalog#createDatabase), but it doesn't make sense
in this utility class. If anyone else used such util method in other places, I
don't think they will expect such behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
