[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods

2021-11-10 Thread GitBox
viirya commented on pull request #17582: URL: https://github.com/apache/flink/pull/17582#issuecomment-966070024 Thanks for reviewing, @gyfora. This issue happens when we put the Hadoop configuration in the docker image. In the case, Flink job manager won't create configmap for the

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17556: [FLINK-24627][tests] add some Junit5 extensions to replace the existed Junit4 rules

2021-11-10 Thread GitBox
ruanhang1993 commented on a change in pull request #17556: URL: https://github.com/apache/flink/pull/17556#discussion_r747273961 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterExtension.java ## @@ -0,0 +1,215 @@ +/* + * Licensed to the

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17556: [FLINK-24627][tests] add some Junit5 extensions to replace the existed Junit4 rules

2021-11-10 Thread GitBox
ruanhang1993 commented on a change in pull request #17556: URL: https://github.com/apache/flink/pull/17556#discussion_r747269792 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskCancelAsyncProducerConsumerITCase.java ## @@ -58,7 +60,8 @@

[GitHub] [flink] fapaul commented on a change in pull request #17696: [FLINK-24765][kafka] Bump Kafka version to 2.8

2021-11-10 Thread GitBox
fapaul commented on a change in pull request #17696: URL: https://github.com/apache/flink/pull/17696#discussion_r747269811 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerITCase.java ## @@ -53,7

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17556: [FLINK-24627][tests] add some Junit5 extensions to replace the existed Junit4 rules

2021-11-10 Thread GitBox
ruanhang1993 commented on a change in pull request #17556: URL: https://github.com/apache/flink/pull/17556#discussion_r747269792 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskCancelAsyncProducerConsumerITCase.java ## @@ -58,7 +60,8 @@

[GitHub] [flink] fapaul commented on a change in pull request #17696: [FLINK-24765][kafka] Bump Kafka version to 2.8

2021-11-10 Thread GitBox
fapaul commented on a change in pull request #17696: URL: https://github.com/apache/flink/pull/17696#discussion_r747269536 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerITCase.java ## @@ -53,7

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * 34ba01994ce91f93f6cf224f004e21ba4a1a505a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17653: FLINK SQL checkpoint不生效

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17653: URL: https://github.com/apache/flink/pull/17653#issuecomment-958686553 ## CI report: * 3ef637d1e3861d1de18e54317df91f56439f843c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17699: [FLINK-20370][table] Fix wrong results when sink primary key is not the same with query result's changelog upsert key

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17699: URL: https://github.com/apache/flink/pull/17699#issuecomment-961963701 ## CI report: * a3f2c4fea8e78e65319a33687b35f4934bf0850a Azure:

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17556: [FLINK-24627][tests] add some Junit5 extensions to replace the existed Junit4 rules

2021-11-10 Thread GitBox
ruanhang1993 commented on a change in pull request #17556: URL: https://github.com/apache/flink/pull/17556#discussion_r747261202 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/EachCallbackWrapper.java ## @@ -0,0

[GitHub] [flink] AHeise commented on pull request #17401: [FLINK-24409][connectors] Fix metrics errors with topics names with periods

2021-11-10 Thread GitBox
AHeise commented on pull request #17401: URL: https://github.com/apache/flink/pull/17401#issuecomment-966057682 Does it make sense to re-assign the task to someone else? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] AHeise commented on pull request #17592: [hotfix][flink-yarn] Fix typo in YarnConfigOptions.java

2021-11-10 Thread GitBox
AHeise commented on pull request #17592: URL: https://github.com/apache/flink/pull/17592#issuecomment-966057207 Hey, sorry for not giving more details, I was assuming @MartijnVisser to pick that up. Please refer to

[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the num

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638 ## CI report: * a392282483107bb6b985d9ff724d65d602a86a73 Azure:

[GitHub] [flink] SteNicholas edited a comment on pull request #17691: [FLINK-24586][table] SQL functions should return STRING instead of VARCHAR(2000)

2021-11-10 Thread GitBox
SteNicholas edited a comment on pull request #17691: URL: https://github.com/apache/flink/pull/17691#issuecomment-965890064 @slinkydeveloper @Airblader , the failed tests have nothing to do with this change. Please check this again. -- This is an automated message from the Apache Git

[GitHub] [flink] AHeise commented on a change in pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the

2021-11-10 Thread GitBox
AHeise commented on a change in pull request #17692: URL: https://github.com/apache/flink/pull/17692#discussion_r747261841 ## File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/configuration/CEPCacheOptions.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17698: [FLINK-24689][runtime-web] Add log's last modify time in log list view

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17698: URL: https://github.com/apache/flink/pull/17698#issuecomment-961944542 ## CI report: * ceb159afd8d17cd261ac9065d5cbe9baf745dd39 Azure:

[GitHub] [flink] SteNicholas edited a comment on pull request #17691: [FLINK-24586][table] SQL functions should return STRING instead of VARCHAR(2000)

2021-11-10 Thread GitBox
SteNicholas edited a comment on pull request #17691: URL: https://github.com/apache/flink/pull/17691#issuecomment-965890064 @slinkydeveloper , the failed tests have nothing to do with this change. Please check this again. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17556: [FLINK-24627][tests] add some Junit5 extensions to replace the existed Junit4 rules

2021-11-10 Thread GitBox
ruanhang1993 commented on a change in pull request #17556: URL: https://github.com/apache/flink/pull/17556#discussion_r747261202 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/EachCallbackWrapper.java ## @@ -0,0

[GitHub] [flink] flinkbot edited a comment on pull request #17745: [FLINK-24854][tests] StateHandleSerializationTest unit test error

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17745: URL: https://github.com/apache/flink/pull/17745#issuecomment-964922388 ## CI report: * 070e6a2ee8f928e2c7b7bfbce71d4229a0eca947 Azure:

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17556: [FLINK-24627][tests] add some Junit5 extensions to replace the existed Junit4 rules

2021-11-10 Thread GitBox
ruanhang1993 commented on a change in pull request #17556: URL: https://github.com/apache/flink/pull/17556#discussion_r747258434 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/LogLevelExtension.java ## @@ -0,0 +1,114 @@ +/* +

[GitHub] [flink] AHeise commented on pull request #17548: [FLINK-24383][streaming] Remove the deprecated SlidingTimeWindows, TumblingTimeWindows, BaseAlignedWindowAssigner.

2021-11-10 Thread GitBox
AHeise commented on pull request #17548: URL: https://github.com/apache/flink/pull/17548#issuecomment-966051807 I'll check if I find a good reviewer. Not sure why this PR has not popped up on my radar before. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] flinkbot edited a comment on pull request #17699: [FLINK-20370][table] Fix wrong results when sink primary key is not the same with query result's changelog upsert key

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17699: URL: https://github.com/apache/flink/pull/17699#issuecomment-961963701 ## CI report: * 1550e7e6200bfcac3cf20f3e930d77da1a5874e4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17699: [FLINK-20370][table] Fix wrong results when sink primary key is not the same with query result's changelog upsert key

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17699: URL: https://github.com/apache/flink/pull/17699#issuecomment-961963701 ## CI report: * 1550e7e6200bfcac3cf20f3e930d77da1a5874e4 Azure:

[GitHub] [flink] AHeise commented on a change in pull request #17696: [FLINK-24765][kafka] Bump Kafka version to 2.8

2021-11-10 Thread GitBox
AHeise commented on a change in pull request #17696: URL: https://github.com/apache/flink/pull/17696#discussion_r747256716 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerITCase.java ## @@ -53,7

[GitHub] [flink] AHeise commented on a change in pull request #17696: [FLINK-24765][kafka] Bump Kafka version to 2.8

2021-11-10 Thread GitBox
AHeise commented on a change in pull request #17696: URL: https://github.com/apache/flink/pull/17696#discussion_r747256424 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerITCase.java ## @@ -53,7

[GitHub] [flink] AHeise commented on a change in pull request #17696: [FLINK-24765][kafka] Bump Kafka version to 2.8

2021-11-10 Thread GitBox
AHeise commented on a change in pull request #17696: URL: https://github.com/apache/flink/pull/17696#discussion_r747255907 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/FlinkKafkaInternalProducer.java

[jira] [Resolved] (FLINK-24741) Deprecate FileRecordFormat, use StreamFormat instead

2021-11-10 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise resolved FLINK-24741. - Resolution: Fixed Merged into master as 1dac395967e5870833d67c6bf1103ba874fce601. > Deprecate

[GitHub] [flink] AHeise merged pull request #17656: [FLINK-24741]Deprecate FileRecordFormat

2021-11-10 Thread GitBox
AHeise merged pull request #17656: URL: https://github.com/apache/flink/pull/17656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17556: [FLINK-24627][tests] add some Junit5 extensions to replace the existed Junit4 rules

2021-11-10 Thread GitBox
ruanhang1993 commented on a change in pull request #17556: URL: https://github.com/apache/flink/pull/17556#discussion_r747252860 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/SharedObjectsExtension.java ## @@ -0,0

[GitHub] [flink-ml] yunfengzhou-hub opened a new pull request #21: [FLINK-24817] Add Naive Bayes implementation

2021-11-10 Thread GitBox
yunfengzhou-hub opened a new pull request #21: URL: https://github.com/apache/flink-ml/pull/21 ## What is the purpose of the change This PR adds the implementation of Naive Bayes algorithm to Flink ML. This algorithm is implemented in reference to that implemented in Alibaba Alink and

[jira] [Updated] (FLINK-24817) Support Naive Bayes algorithm in Flink ML

2021-11-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24817: --- Labels: pull-request-available (was: ) > Support Naive Bayes algorithm in Flink ML >

[GitHub] [flink-ml] yunfengzhou-hub closed pull request #21: [FLINK-24817] Add Naive Bayes implementation

2021-11-10 Thread GitBox
yunfengzhou-hub closed pull request #21: URL: https://github.com/apache/flink-ml/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] RocMarshal edited a comment on pull request #17463: [Hotfix] Fix typos.

2021-11-10 Thread GitBox
RocMarshal edited a comment on pull request #17463: URL: https://github.com/apache/flink/pull/17463#issuecomment-944947844 Hi, @klion26 @alpinegizmo @twalthr , here is a minor typo. Would you like to help me to check it ? Thank you very much. -- This is an automated message from the

[GitHub] [flink] RocMarshal edited a comment on pull request #17548: [FLINK-24383][streaming] Remove the deprecated SlidingTimeWindows, TumblingTimeWindows, BaseAlignedWindowAssigner.

2021-11-10 Thread GitBox
RocMarshal edited a comment on pull request #17548: URL: https://github.com/apache/flink/pull/17548#issuecomment-950549753 Hi, @twalthr @xccui @klion26 @AHeise Could you help me to check this pr ?Thank you. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] RocMarshal edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the n

2021-11-10 Thread GitBox
RocMarshal edited a comment on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-963105801 @Airblader @AHeise @klion26 Could you help me to review this pr ? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] (FLINK-24851) KafkaSourceBuilder: auto.offset.reset is ignored

2021-11-10 Thread liwei li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24851 ] liwei li deleted comment on FLINK-24851: -- was (Author: liliwei): Also, what was the background of the artificial overwriting of this value?Or maybe it's just a bug? > KafkaSourceBuilder:

[jira] [Commented] (FLINK-24851) KafkaSourceBuilder: auto.offset.reset is ignored

2021-11-10 Thread liwei li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442107#comment-17442107 ] liwei li commented on FLINK-24851: -- Also, what was the background of the artificial overwriting of this

[jira] (FLINK-24851) KafkaSourceBuilder: auto.offset.reset is ignored

2021-11-10 Thread liwei li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24851 ] liwei li deleted comment on FLINK-24851: -- was (Author: liliwei): Also, can I know the background for doing this?Why override this value artificially?Or maybe it's just a bug? >

[jira] [Commented] (FLINK-24851) KafkaSourceBuilder: auto.offset.reset is ignored

2021-11-10 Thread liwei li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442106#comment-17442106 ] liwei li commented on FLINK-24851: -- Also, can I know the background for doing this?Why override this

[jira] [Updated] (FLINK-24871) Flink SQL hive reports IndexOutOfBoundsException when using trim in where clause

2021-11-10 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-24871: Component/s: Connectors / Hive > Flink SQL hive reports IndexOutOfBoundsException when using trim in

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17556: [FLINK-24627][tests] add some Junit5 extensions to replace the existed Junit4 rules

2021-11-10 Thread GitBox
ruanhang1993 commented on a change in pull request #17556: URL: https://github.com/apache/flink/pull/17556#discussion_r747224765 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/SharedObjectsExtension.java ## @@ -0,0

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17556: [FLINK-24627][tests] add some Junit5 extensions to replace the existed Junit4 rules

2021-11-10 Thread GitBox
ruanhang1993 commented on a change in pull request #17556: URL: https://github.com/apache/flink/pull/17556#discussion_r747224152 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/TestLoggerExtension.java ## @@ -0,0 +1,80 @@ +/* +

[GitHub] [flink-ml] lindong28 commented on a change in pull request #24: Flink 24557

2021-11-10 Thread GitBox
lindong28 commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r747189344 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/algo/batch/knn/KnnTrainBatchOp.java ## @@ -0,0 +1,230 @@ +package

[GitHub] [flink] flinkbot edited a comment on pull request #17674: [FLINK-24755][doc]Add guidance to solve the package sun.misc does not exist

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17674: URL: https://github.com/apache/flink/pull/17674#issuecomment-960623713 ## CI report: * 092e28e32428901c5eab1ff5c82c22ca67378ea4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17674: [FLINK-24755][doc]Add guidance to solve the package sun.misc does not exist

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17674: URL: https://github.com/apache/flink/pull/17674#issuecomment-960623713 ## CI report: * 092e28e32428901c5eab1ff5c82c22ca67378ea4 Azure:

[GitHub] [flink] Aitozi commented on pull request #17674: [FLINK-24755][doc]Add guidance to solve the package sun.misc does not exist

2021-11-10 Thread GitBox
Aitozi commented on pull request #17674: URL: https://github.com/apache/flink/pull/17674#issuecomment-966001781 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot edited a comment on pull request #17229: [FLINK-23381][state] Back-pressure on reaching state change to upload limit

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17229: URL: https://github.com/apache/flink/pull/17229#issuecomment-916519510 ## CI report: * bafd996049bf6f1a6b05c3b3b2828a480ec4b773 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17229: [FLINK-23381][state] Back-pressure on reaching state change to upload limit

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17229: URL: https://github.com/apache/flink/pull/17229#issuecomment-916519510 ## CI report: * bafd996049bf6f1a6b05c3b3b2828a480ec4b773 Azure:

[jira] [Commented] (FLINK-24758) filesystem sink: partition.time-extractor.kind support "yyyyMMdd"

2021-11-10 Thread liwei li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442082#comment-17442082 ] liwei li commented on FLINK-24758: -- That makes sense. I will modify this pr. > filesystem sink:

[GitHub] [flink] hililiwei removed a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: partition.time-extractor.kind support "yyyyMMdd"

2021-11-10 Thread GitBox
hililiwei removed a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965991143 > Actually, I do not think it is a good way to add a 'basicDate', since '-MM-dd HH:mm:ss' is the default. The best way to have another parameters such as

[GitHub] [flink] hililiwei commented on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: partition.time-extractor.kind support "yyyyMMdd"

2021-11-10 Thread GitBox
hililiwei commented on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965991143 > Actually, I do not think it is a good way to add a 'basicDate', since '-MM-dd HH:mm:ss' is the default. The best way to have another parameters such as 'date-pattern',

[GitHub] [flink] hililiwei closed pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: partition.time-extractor.kind support "yyyyMMdd"

2021-11-10 Thread GitBox
hililiwei closed pull request #17749: URL: https://github.com/apache/flink/pull/17749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-24477) Add MongoDB sink

2021-11-10 Thread Lai Dai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442081#comment-17442081 ] Lai Dai commented on FLINK-24477: - Hi, who can tell me when to make a pr for this feature? > Add

[GitHub] [flink] hililiwei commented on pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-10 Thread GitBox
hililiwei commented on pull request #17754: URL: https://github.com/apache/flink/pull/17754#issuecomment-965982508 look good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-24758) filesystem sink: partition.time-extractor.kind support "yyyyMMdd"

2021-11-10 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442077#comment-17442077 ] Jingsong Lee commented on FLINK-24758: -- [~nobleyd]  +1 > filesystem sink:

[GitHub] [flink] RocMarshal commented on a change in pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='

2021-11-10 Thread GitBox
RocMarshal commented on a change in pull request #17613: URL: https://github.com/apache/flink/pull/17613#discussion_r747186368 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/BangEqualITCase.scala ## @@ -0,0 +1,71

[GitHub] [flink] flinkbot edited a comment on pull request #17387: [FLINK-24864][metrics] Release TaskManagerJobMetricGroup with the last slot rather than task

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17387: URL: https://github.com/apache/flink/pull/17387#issuecomment-930245327 ## CI report: * 44c4ce9fcbdd66f25dcb82d52224e98064cea4ad Azure:

[GitHub] [flink-ml] lindong28 commented on a change in pull request #29: [FLINK-24838] Add BaseAlgoImpl class to support link() and linkFrom()

2021-11-10 Thread GitBox
lindong28 commented on a change in pull request #29: URL: https://github.com/apache/flink-ml/pull/29#discussion_r747186614 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/operator/BaseAlgoImpl.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] lindong28 commented on a change in pull request #29: [FLINK-24838] Add BaseAlgoImpl class to support link() and linkFrom()

2021-11-10 Thread GitBox
lindong28 commented on a change in pull request #29: URL: https://github.com/apache/flink-ml/pull/29#discussion_r747186614 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/operator/BaseAlgoImpl.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[jira] [Updated] (FLINK-24855) Source Coordinator Thread already exists. There should never be more than one thread driving the actions of a Source Coordinator.

2021-11-10 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-24855: --- Priority: Critical (was: Blocker) > Source Coordinator Thread already exists. There should never

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17424: [FLINK-24455][tests]FallbackAkkaRpcSystemLoader should check for mave…

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17424: URL: https://github.com/apache/flink/pull/17424#issuecomment-938516882 ## CI report: * 4bec22eb5e57d5b892a24b9253f0531df65bcf07 Azure:

[jira] [Commented] (FLINK-24855) Source Coordinator Thread already exists. There should never be more than one thread driving the actions of a Source Coordinator.

2021-11-10 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442072#comment-17442072 ] Leonard Xu commented on FLINK-24855: Thanks [~chesnay]  for looking into this. The related issue

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[GitHub] [flink] Myasuka commented on a change in pull request #17755: [FLINK-24858][core] Prevent version mismatches in TypeSerializers

2021-11-10 Thread GitBox
Myasuka commented on a change in pull request #17755: URL: https://github.com/apache/flink/pull/17755#discussion_r747181767 ## File path: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java ## @@ -540,14 +540,26 @@ protected int

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17760: [FLINK-24830][examples] Update DataStream WordCount example

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17760: URL: https://github.com/apache/flink/pull/17760#issuecomment-965756145 ## CI report: * 3633f6917d2939616c6ec07fa55c908b54a0e7d0 UNKNOWN * ebc7e2e66dfa470df1780945c625c32876e3dffc Azure:

[jira] [Commented] (FLINK-24586) SQL functions should return STRING instead of VARCHAR(2000)

2021-11-10 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442071#comment-17442071 ] Nicholas Jiang commented on FLINK-24586: [~airblader], could you please assign this ticket to

[GitHub] [flink] flinkbot edited a comment on pull request #17699: [FLINK-20370][table] Fix wrong results when sink primary key is not the same with query result's changelog upsert key

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17699: URL: https://github.com/apache/flink/pull/17699#issuecomment-961963701 ## CI report: * 1550e7e6200bfcac3cf20f3e930d77da1a5874e4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17699: [FLINK-20370][table] Fix wrong results when sink primary key is not the same with query result's changelog upsert key

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17699: URL: https://github.com/apache/flink/pull/17699#issuecomment-961963701 ## CI report: * 1550e7e6200bfcac3cf20f3e930d77da1a5874e4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[jira] [Comment Edited] (FLINK-24802) Improve cast ROW to STRING

2021-11-10 Thread Shen Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440850#comment-17440850 ] Shen Zhu edited comment on FLINK-24802 at 11/11/21, 3:37 AM: - Hey

[jira] [Created] (FLINK-24871) Flink SQL hive reports IndexOutOfBoundsException when using trim in where clause

2021-11-10 Thread Liu (Jira)
Liu created FLINK-24871: --- Summary: Flink SQL hive reports IndexOutOfBoundsException when using trim in where clause Key: FLINK-24871 URL: https://issues.apache.org/jira/browse/FLINK-24871 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17685: URL: https://github.com/apache/flink/pull/17685#issuecomment-961148655 ## CI report: * 7690d30646bfa745d7328d28ade0acd5a1fbdacc Azure:

[jira] [Commented] (FLINK-24870) Cannot cast "java.util.Date" to "java.time.Instant"

2021-11-10 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442056#comment-17442056 ] Jark Wu commented on FLINK-24870: - [~wangbaohua], could you also share the sql/code as well? Otherwise,

[jira] [Created] (FLINK-24870) Cannot cast "java.util.Date" to "java.time.Instant"

2021-11-10 Thread wangbaohua (Jira)
wangbaohua created FLINK-24870: -- Summary: Cannot cast "java.util.Date" to "java.time.Instant" Key: FLINK-24870 URL: https://issues.apache.org/jira/browse/FLINK-24870 Project: Flink Issue Type:

[jira] [Comment Edited] (FLINK-22826) flink sql1.13.1 causes data loss based on change log stream data join

2021-11-10 Thread yaoboxu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442045#comment-17442045 ] yaoboxu edited comment on FLINK-22826 at 11/11/21, 2:57 AM: flink 1.13.3

[GitHub] [flink] flinkbot edited a comment on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 Azure:

[jira] [Commented] (FLINK-24862) The user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread xiangqiao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442054#comment-17442054 ] xiangqiao commented on FLINK-24862: --- Thank you [~jark] ,remove the "temporary" keyword is to create a

[jira] (FLINK-22826) flink sql1.13.1 causes data loss based on change log stream data join

2021-11-10 Thread yaoboxu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22826 ] yaoboxu deleted comment on FLINK-22826: - was (Author: JIRAUSER280018): flink 1.13.3 still appear this question. > flink sql1.13.1 causes data loss based on change log stream data join >

[GitHub] [flink] flinkbot commented on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot commented on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943621 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
flinkbot commented on pull request #17761: URL: https://github.com/apache/flink/pull/17761#issuecomment-965943227 ## CI report: * e0d50b32fe1ca368ceb34d5a21c70125bb8f5213 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Updated] (FLINK-24862) The user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24862: --- Labels: pull-request-available (was: ) > The user-defined hive udaf/udtf cannot be used

[GitHub] [flink] xiangqiao123 opened a new pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

2021-11-10 Thread GitBox
xiangqiao123 opened a new pull request #17761: URL: https://github.com/apache/flink/pull/17761 ## What is the purpose of the change *Fix user-defined hive udaf/udtf cannot be used normally in hive dialect* ## Brief change log -

[jira] [Commented] (FLINK-22541) add json format filter params

2021-11-10 Thread liwei li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442052#comment-17442052 ] liwei li commented on FLINK-22541: -- What is the issuse conclusion?Should we support this feature?  In

[GitHub] [flink] flinkbot edited a comment on pull request #17424: [FLINK-24455][tests]FallbackAkkaRpcSystemLoader should check for mave…

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17424: URL: https://github.com/apache/flink/pull/17424#issuecomment-938516882 ## CI report: * 4bec22eb5e57d5b892a24b9253f0531df65bcf07 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17424: [FLINK-24455][tests]FallbackAkkaRpcSystemLoader should check for mave…

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17424: URL: https://github.com/apache/flink/pull/17424#issuecomment-938516882 ## CI report: * 4bec22eb5e57d5b892a24b9253f0531df65bcf07 Azure:

[GitHub] [flink] Aitozi commented on pull request #17424: [FLINK-24455][tests]FallbackAkkaRpcSystemLoader should check for mave…

2021-11-10 Thread GitBox
Aitozi commented on pull request #17424: URL: https://github.com/apache/flink/pull/17424#issuecomment-965937395 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the num

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638 ## CI report: * 59391b06ac7eb512b298dfcaa49847d20bb32c7e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-10 Thread GitBox
flinkbot edited a comment on pull request #17685: URL: https://github.com/apache/flink/pull/17685#issuecomment-961148655 ## CI report: * 7690d30646bfa745d7328d28ade0acd5a1fbdacc Azure:

[jira] [Commented] (FLINK-22826) flink sql1.13.1 causes data loss based on change log stream data join

2021-11-10 Thread yaoboxu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442047#comment-17442047 ] yaoboxu commented on FLINK-22826: - flink 1.13.3 still appear this question. > flink sql1.13.1 causes

  1   2   3   4   5   6   7   8   >