liyubin117 commented on pull request #18361:
URL: https://github.com/apache/flink/pull/18361#issuecomment-1012879158
@wuchong Hi, Could you please help give a review ? Thanks very much !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/FLINK-25654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17476005#comment-17476005
]
zhangtianyu commented on FLINK-25654:
-
t-1
-- 原始邮件 --
发件人：Yingjie
Yingjie Cao created FLINK-25654:
---
Summary: Remove the redundant lock in SortMergeResultPartition
Key: FLINK-25654
URL: https://issues.apache.org/jira/browse/FLINK-25654
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-25649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475999#comment-17475999
]
Till Rohrmann edited comment on FLINK-25649 at 1/14/22, 7:30 AM:
-
cc
[
https://issues.apache.org/jira/browse/FLINK-25649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475999#comment-17475999
]
Till Rohrmann commented on FLINK-25649:
---
cc [~dmvk]
> Scheduling jobs fails with
>
Yingjie Cao created FLINK-25653:
---
Summary: Move buffer recycle in SortMergeSubpartitionReader out of
lock to avoid deadlock
Key: FLINK-25653
URL: https://issues.apache.org/jira/browse/FLINK-25653
JingsongLi commented on a change in pull request #7:
URL: https://github.com/apache/flink-table-store/pull/7#discussion_r784608572
##
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/predicate/Equal.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to
tsreaper commented on a change in pull request #7:
URL: https://github.com/apache/flink-table-store/pull/7#discussion_r784594032
##
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/predicate/Equal.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to
tsreaper commented on a change in pull request #7:
URL: https://github.com/apache/flink-table-store/pull/7#discussion_r784594032
##
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/predicate/Equal.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to
Airblader edited a comment on pull request #17711:
URL: https://github.com/apache/flink/pull/17711#issuecomment-1012833850
I would prefer bumping this in a separate PR using the JIRA issue
@MartijnVisser pointed to. I'm happy to review and merge that one as well, of
course (no vacation in
Airblader commented on pull request #17711:
URL: https://github.com/apache/flink/pull/17711#issuecomment-1012833850
I would prefer bumping this in a separate PR using the JIRA issue
@MartijnVisser pointed to.
--
This is an automated message from the Apache Git Service.
To respond to the
JingsongLi commented on a change in pull request #8:
URL: https://github.com/apache/flink-table-store/pull/8#discussion_r784581070
##
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/manifest/ManifestEntrySerializer.java
##
@@ -0,0 +1,63 @@
jeff-zou created FLINK-25652:
Summary: Can "duration“ and ”received records" be updated at the
same time in WebUI's task detail ?
Key: FLINK-25652
URL: https://issues.apache.org/jira/browse/FLINK-25652
chenzihao5 commented on pull request #18261:
URL: https://github.com/apache/flink/pull/18261#issuecomment-1012819645
> Thank you for your contribution.
>
> Please update your commit message to follow the Code Style & Quality
Guidelines, which can be found at
tsreaper opened a new pull request #8:
URL: https://github.com/apache/flink-table-store/pull/8
Manifest files are the meta data for sst files. They record the changes
between two snapshots.
* Introduce manifest entry and maniefst file meta
* Add tests for FileStorePathFactory
zjureel closed pull request #18346:
URL: https://github.com/apache/flink/pull/18346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
flinkbot commented on pull request #18361:
URL: https://github.com/apache/flink/pull/18361#issuecomment-1012808315
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
wsry closed pull request #17936:
URL: https://github.com/apache/flink/pull/17936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-25631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-25631:
---
Labels: pull-request-available (was: )
> Support enhanced `show tables` statement
>
liyubin117 opened a new pull request #18361:
URL: https://github.com/apache/flink/pull/18361
## What is the purpose of the change
Support enhanced `show tables` syntax like `show tables from catalog1.db1
like 't%'`
## Brief change log
* SHOW TABLES [ ( FROM | IN )
paul8263 commented on pull request #18334:
URL: https://github.com/apache/flink/pull/18334#issuecomment-1012787097
Hi @zentol ,
Thank you very much for your reply. I have tested Netty ServerBootstrap and
it turns out that if we bind 0 as the port number, the server will finally
[
https://issues.apache.org/jira/browse/FLINK-25483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475943#comment-17475943
]
Martijn Visser commented on FLINK-25483:
[~empcl] I understand that. What I mean is that with
MartijnVisser commented on pull request #15140:
URL: https://github.com/apache/flink/pull/15140#issuecomment-1012787224
@SteNicholas Sounds good. Keep in mind that we might not want to merge in
new connectors in 1.16, depending on how quickly the external connector
discussion is
[
https://issues.apache.org/jira/browse/FLINK-25420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475942#comment-17475942
]
Martijn Visser commented on FLINK-25420:
[~RocMarshal] I'm not sure if a FLIP is needed (in the
flinkbot commented on pull request #18360:
URL: https://github.com/apache/flink/pull/18360#issuecomment-1012784974
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
[
https://issues.apache.org/jira/browse/FLINK-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-25329:
---
Labels: pull-request-available (was: )
> Improvement of execution graph store in flink
zjureel opened a new pull request #18360:
URL: https://github.com/apache/flink/pull/18360
## What is the purpose of the change
This PR aims to support memory execution graph store in session cluster
## Brief change log
- * Improve MemoryExecutionGraphInfoStore to support
[
https://issues.apache.org/jira/browse/FLINK-25584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475937#comment-17475937
]
Martijn Visser commented on FLINK-25584:
+1
> Azure failed on install node and npm for Flink :
MartijnVisser commented on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1012779888
NB: Flinkbot reports as the CI still `PENDING`, but it has completed
successfully.
--
This is an automated message from the Apache Git Service.
To respond to the
MartijnVisser commented on pull request #17711:
URL: https://github.com/apache/flink/pull/17711#issuecomment-1012774822
@yangjunhan I'm not sure if it's better to make it a separate PR (since we
also have https://issues.apache.org/jira/browse/FLINK-24768 open for this) or
if we should do
yangjunhan commented on pull request #17711:
URL: https://github.com/apache/flink/pull/17711#issuecomment-1012727601
> @yangjunhan I apologize for the late response; I was on vacation over the
holidays.
>
> The changes overall look fine to me, except for the open point around the
flinkbot commented on pull request #18359:
URL: https://github.com/apache/flink/pull/18359#issuecomment-1012727099
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
[
https://issues.apache.org/jira/browse/FLINK-25484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-25484:
---
Labels: pull-request-available (was: )
> TableRollingPolicy do not support
lichang-bd opened a new pull request #18359:
URL: https://github.com/apache/flink/pull/18359
Change-Id: Ica8ba43307476198c4f525ac40a54ab862b58ea7
## What is the purpose of the change
Support inactivityInterval config in table api
## Brief change log
- *Add
[
https://issues.apache.org/jira/browse/FLINK-25312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee reassigned FLINK-25312:
Assignee: Jane Chan
> Hive supports managed table
> ---
>
>
[
https://issues.apache.org/jira/browse/FLINK-25312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475921#comment-17475921
]
Jingsong Lee commented on FLINK-25312:
--
[~qingyue] Thanks!
> Hive supports managed table
>
shouzuo meng created FLINK-25651:
Summary: Flink1.14.2 DataStream Connectors Kafka Deserializer
example method uses the wrong parameter
Key: FLINK-25651
URL: https://issues.apache.org/jira/browse/FLINK-25651
flinkbot commented on pull request #18358:
URL: https://github.com/apache/flink/pull/18358#issuecomment-1012712193
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
jelly-1203 opened a new pull request #18358:
URL: https://github.com/apache/flink/pull/18358
Modify KafkaRecordDeserializationSchema. ValueOnly method's parameters
## What is the purpose of the change
*(For example: This pull request makes task deployment go through
[
https://issues.apache.org/jira/browse/FLINK-25634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475910#comment-17475910
]
宇宙先生 commented on FLINK-25634:
--
thanks for review, I can't
> flink-read-onyarn-configuration
>
lichang-bd closed pull request #18357:
URL: https://github.com/apache/flink/pull/18357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
flinkbot commented on pull request #18357:
URL: https://github.com/apache/flink/pull/18357#issuecomment-1012700380
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
lichang-bd opened a new pull request #18357:
URL: https://github.com/apache/flink/pull/18357
Change-Id: Ica8ba43307476198c4f525ac40a54ab862b58ea7
## What is the purpose of the change
Support inactivityInterval config in table api
## Brief change log
- *Add
lichang-bd closed pull request #18344:
URL: https://github.com/apache/flink/pull/18344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shammon updated FLINK-25329:
Description:
Flink session cluster uses files to store info of jobs after they reach
termination with
[
https://issues.apache.org/jira/browse/FLINK-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shammon updated FLINK-25329:
Summary: Improvement of execution graph store in flink session cluster for
jobs (was: Improvement of
liuyongvs commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-1012689676
hi @tillrohrmann @Thesharing ,do you have time ,sorry to @ you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475897#comment-17475897
]
Q Kang commented on FLINK-25614:
Hi [~wenlong.lwl] , I have fixed `SlicingWindowAggOperatorTest`, but
[
https://issues.apache.org/jira/browse/FLINK-25312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475895#comment-17475895
]
Jane Chan commented on FLINK-25312:
---
Hi, [~lzljs3620320], I'm interested in this subtask, and would
xintongsong commented on pull request #15599:
URL: https://github.com/apache/flink/pull/15599#issuecomment-1012679021
@galenwarren,
The commit doesn't need to be too detailed, as more details can be found
with the JIRA id. Something briefly describes the major changes would be good
zjureel commented on pull request #18303:
URL: https://github.com/apache/flink/pull/18303#issuecomment-1012656102
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
JingGe commented on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1012608343
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
JingGe commented on a change in pull request #18330:
URL: https://github.com/apache/flink/pull/18330#discussion_r784393519
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableSummary.java
##
@@ -0,0 +1,87 @@
+/*
+ *
JingGe commented on a change in pull request #18330:
URL: https://github.com/apache/flink/pull/18330#discussion_r784386592
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableMessageTypeInfo.java
##
@@ -0,0 +1,166 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-25646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475778#comment-17475778
]
Mason Chen edited comment on FLINK-25646 at 1/13/22, 10:01 PM:
---
Hi
[
https://issues.apache.org/jira/browse/FLINK-25646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475778#comment-17475778
]
Mason Chen commented on FLINK-25646:
Hi [~akalashnikov], thanks for the documentation! Could you
[
https://issues.apache.org/jira/browse/FLINK-21896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475743#comment-17475743
]
Soumyajit Sahu commented on FLINK-21896:
[~godfreyhe] [~twalthr] This would break upgrade from
rkhachatryan commented on a change in pull request #18324:
URL: https://github.com/apache/flink/pull/18324#discussion_r784314617
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SubtaskStateStats.java
##
@@ -85,6 +88,7 @@
rkhachatryan commented on a change in pull request #18324:
URL: https://github.com/apache/flink/pull/18324#discussion_r784312461
##
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##
rkhachatryan commented on a change in pull request #18324:
URL: https://github.com/apache/flink/pull/18324#discussion_r784309007
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateObject.java
##
@@ -63,4 +63,14 @@
* @return Size of the state
rkhachatryan commented on a change in pull request #18324:
URL: https://github.com/apache/flink/pull/18324#discussion_r784305375
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java
##
@@ -204,6 +203,21 @@ public long
rkhachatryan commented on a change in pull request #18324:
URL: https://github.com/apache/flink/pull/18324#discussion_r784298983
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java
##
@@ -113,6 +124,19 @@ public
rkhachatryan commented on a change in pull request #18324:
URL: https://github.com/apache/flink/pull/18324#discussion_r784301442
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java
##
@@ -50,17 +50,28 @@
[
https://issues.apache.org/jira/browse/FLINK-25505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475724#comment-17475724
]
Robert Metzger commented on FLINK-25505:
For fixing the SystemResourcesCounterTest, we need to
galenwarren commented on pull request #15599:
URL: https://github.com/apache/flink/pull/15599#issuecomment-1012485195
@xintongsong Sounds great! Many thanks for all your work and guidance on
this project. Once we get the CI issues resolved, I'll squash everything so it
will be ready to
galenwarren commented on pull request #15599:
URL: https://github.com/apache/flink/pull/15599#issuecomment-1012456967
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecholeric commented on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012456359
Hey, I quickly looked over it (it's quite late for me already :wink:), but
here are my 2 cents why things probably differ (as you already guessed in the
last comments):
JingGe commented on a change in pull request #18322:
URL: https://github.com/apache/flink/pull/18322#discussion_r784252017
##
File path: docs/content.zh/docs/connectors/datastream/elasticsearch.md
##
@@ -294,131 +210,163 @@ input.addSink(esSinkBuilder.build)
###
rkhachatryan commented on a change in pull request #18297:
URL: https://github.com/apache/flink/pull/18297#discussion_r784256807
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java
##
@@ -83,11 +80,7 @@ public
[
https://issues.apache.org/jira/browse/FLINK-25341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther closed FLINK-25341.
Fix Version/s: 1.15.0
Resolution: Fixed
Fixed in master:
twalthr closed pull request #18182:
URL: https://github.com/apache/flink/pull/18182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
JingGe commented on a change in pull request #18333:
URL: https://github.com/apache/flink/pull/18333#discussion_r784026310
##
File path:
flink-architecture-tests/src/test/java/org/apache/flink/architecture/common/JavaFieldPredicates.java
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed
flinkbot commented on pull request #18356:
URL: https://github.com/apache/flink/pull/18356#issuecomment-1012346346
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
matriv opened a new pull request #18356:
URL: https://github.com/apache/flink/pull/18356
The upcoming version to be released need to exist already in master so that
when the new release branch is created from master the version of the release
is already there.
Follows: #18340
twalthr commented on a change in pull request #18352:
URL: https://github.com/apache/flink/pull/18352#discussion_r784160659
##
File path:
flink-table/flink-table-common/src/test/java/org/apache/flink/table/functions/UserDefinedFunctionHelperTest.java
##
@@ -143,34 +162,27 @@
twalthr commented on a change in pull request #18352:
URL: https://github.com/apache/flink/pull/18352#discussion_r784159595
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunctionHelper.java
##
@@ -243,6 +244,36 @@
twalthr commented on a change in pull request #18352:
URL: https://github.com/apache/flink/pull/18352#discussion_r784159595
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunctionHelper.java
##
@@ -243,6 +244,36 @@
echauchot commented on pull request #18284:
URL: https://github.com/apache/flink/pull/18284#issuecomment-1012320859
> Sorry again but do we expect more changes to come from
https://issues.apache.org/jira/browse/FLINK-21407 if so we should create
subtasks for the different connectors and
gaoyunhaii commented on a change in pull request #18330:
URL: https://github.com/apache/flink/pull/18330#discussion_r784116528
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableMessage.java
##
@@ -0,0 +1,36 @@
+/*
+ *
CrynetLogistics commented on a change in pull request #18165:
URL: https://github.com/apache/flink/pull/18165#discussion_r784138446
##
File path: docs/content/docs/connectors/datastream/kinesis.md
##
@@ -29,9 +29,26 @@ under the License.
The Kinesis connector provides
CrynetLogistics commented on a change in pull request #18165:
URL: https://github.com/apache/flink/pull/18165#discussion_r784136808
##
File path: docs/content/docs/connectors/datastream/kinesis.md
##
@@ -566,124 +583,126 @@ Retry and backoff parameters can be configured using
fapaul commented on pull request #18284:
URL: https://github.com/apache/flink/pull/18284#issuecomment-1012308846
Sorry again but do we expect more changes to come from
https://issues.apache.org/jira/browse/FLINK-21407 if so we should create
subtasks for the different connectors and
fapaul commented on pull request #17937:
URL: https://github.com/apache/flink/pull/17937#issuecomment-1012304383
Looks good please squash and rebase then I'll take care of merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
slinkydeveloper commented on a change in pull request #18352:
URL: https://github.com/apache/flink/pull/18352#discussion_r784104335
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunctionHelper.java
##
@@ -243,6 +244,36
fapaul commented on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1012277251
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
flinkbot commented on pull request #18355:
URL: https://github.com/apache/flink/pull/18355#issuecomment-1012276469
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
leonardBang commented on pull request #17657:
URL: https://github.com/apache/flink/pull/17657#issuecomment-1012275729
> @leonardBang I'm sorry, I've been a bit busy for a while, in fact, I
probably won't be able to fix the bugs for the month. or should I close this PR
for now or set it to
[
https://issues.apache.org/jira/browse/FLINK-25160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-25160:
---
Labels: pull-request-available (was: )
> Make doc clear: tolerable-failed-checkpoints
akalash opened a new pull request #18355:
URL: https://github.com/apache/flink/pull/18355
…rable-failed-checkpoints
## What is the purpose of the change
Clarified that execution.checkpointing.tolerable-failed-checkpoints is for
the consecutive failures.
##
JingGe edited a comment on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012252594
One additional information I found to share (thanks @fapaul): some Flink
modules customized test-jar build logic, which turns out not all test code
could be found in
JingGe commented on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012257162
>
sure, this is the option I mentioned previously to shrink the scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Airblader commented on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012254365
> some Flink modules customized test-jar build logic, which turns out not
all test code could be found in test jars
Yeah, that sounds like it might well be the cause,
JingGe commented on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012252594
One additional information I found to share: some Flink modules customized
test-jar build logic, which turns out not all test code could be found in test
jars. This might also
Airblader commented on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012247801
> It means that maven and IntelliJ are running in different scopes, i.e.
"more violations" will be found by IntelliJ because it use a bigger scope than
maven
Running
JingGe commented on a change in pull request #18333:
URL: https://github.com/apache/flink/pull/18333#discussion_r784063682
##
File path:
flink-architecture-tests/src/test/java/org/apache/flink/architecture/common/Predicates.java
##
@@ -50,5 +83,78 @@
matriv commented on a change in pull request #18342:
URL: https://github.com/apache/flink/pull/18342#discussion_r784059921
##
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RelDataTypeJsonSerdeTest.java
##
@@
JingGe edited a comment on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012232986
> Of course technically it seems like IntelliJ actually finds more correct
violations, so the IntelliJ result is "more correct", but IntelliJ is not our
source of truth.
JingGe edited a comment on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012232986
> Of course technically it seems like IntelliJ actually finds more correct
violations, so the IntelliJ result is "more correct", but IntelliJ is not our
source of truth.
JingGe edited a comment on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012232986
> Of course technically it seems like IntelliJ actually finds more correct
violations, so the IntelliJ result is "more correct", but IntelliJ is not our
source of truth.
JingGe commented on pull request #18333:
URL: https://github.com/apache/flink/pull/18333#issuecomment-1012232986
> Of course technically it seems like IntelliJ actually finds more correct
violations, so the IntelliJ result is "more correct", but IntelliJ is not our
source of truth.
1 - 100 of 457 matches
Mail list logo
