[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

wangyang0918 commented on PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#issuecomment-1120140585 I have done some manual tests. And it works well for recover the missing deployment. I have last one question which need to be discussed more. When

[GitHub] [flink-table-store] openinx commented on a diff in pull request #110: [FLINK-27517] Introduce rolling file writer to write one record each time for append-only table.

openinx commented on code in PR #110: URL: https://github.com/apache/flink-table-store/pull/110#discussion_r867300460 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/RollingFileWriter.java: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19498: [FLINK-26588][docs]Translate the new CAST documentation to Chinese

ChengkaiYang2022 commented on PR #19498: URL: https://github.com/apache/flink/pull/19498#issuecomment-1120129625 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

wangyang0918 commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r867299875 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +259,50 @@

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19498: [FLINK-26588][docs]Translate the new CAST documentation to Chinese

ChengkaiYang2022 commented on PR #19498: URL: https://github.com/apache/flink/pull/19498#issuecomment-1120128815 @flinkbot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

wangyang0918 commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r867299797 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -211,6

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

wangyang0918 commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r867299527 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -211,6

[GitHub] [flink] chucheng92 commented on pull request #19654: [FLINK-27529][connector/common] Replace HybridSourceSplitEnumerator readerSourceIndex to safely Integer check

chucheng92 commented on PR #19654: URL: https://github.com/apache/flink/pull/19654#issuecomment-1120124506 @tweise Hi, tweise can u help me to reviewing this pr ? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] chucheng92 commented on pull request #19654: [FLINK-27529][connector/common] Replace HybridSourceSplitEnumerator readerSourceIndex to safely Integer check

chucheng92 commented on PR #19654: URL: https://github.com/apache/flink/pull/19654#issuecomment-1120124033 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-27529) HybridSourceSplitEnumerator sourceIndex using error Integer check

[ https://issues.apache.org/jira/browse/FLINK-27529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao updated FLINK-27529: Description: Currently HybridSourceSplitEnumerator check readerSourceIndex using Integer type but ==

[GitHub] [flink] baisui1981 commented on pull request #17521: [FLINK-24558][API/DataStream]make parent ClassLoader variable which c…

baisui1981 commented on PR #17521: URL: https://github.com/apache/flink/pull/17521#issuecomment-1120122341 @RocMarshal @zentol @AHeise could you please give me some suggestion ,how to continue processing for this PR? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19498: [FLINK-26588][docs]Translate the new CAST documentation to Chinese

ChengkaiYang2022 commented on PR #19498: URL: https://github.com/apache/flink/pull/19498#issuecomment-1120121765 > The CI test fails. Could you rebase to the latest master and trigger the test again? Okay,I will try to rebase -- This is an automated message from the Apache Git

[jira] [Created] (FLINK-27538) Change flink.version 1.15-SNAPSHOT to 1.15.0 in table store

Jingsong Lee created FLINK-27538: Summary: Change flink.version 1.15-SNAPSHOT to 1.15.0 in table store Key: FLINK-27538 URL: https://issues.apache.org/jira/browse/FLINK-27538 Project: Flink

[GitHub] [flink] fsk119 commented on pull request #19498: [FLINK-26588][docs]Translate the new CAST documentation to Chinese

fsk119 commented on PR #19498: URL: https://github.com/apache/flink/pull/19498#issuecomment-1120116520 The CI test fails. Could you rebase to the latest master and trigger the test again? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #110: [FLINK-27517] Introduce rolling file writer to write one record each time for append-only table.

JingsongLi commented on code in PR #110: URL: https://github.com/apache/flink-table-store/pull/110#discussion_r867288653 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/RollingFileWriter.java: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache

[GitHub] [flink] Myasuka commented on pull request #19600: [FLINK-27433][tests] Relocate RocksDB's log back to its own database dir

Myasuka commented on PR #19600: URL: https://github.com/apache/flink/pull/19600#issuecomment-1120113084 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] lsyldliu commented on pull request #19410: [FLINK-15635][table] Now EnvironmentSettings accepts the user ClassLoader

lsyldliu commented on PR #19410: URL: https://github.com/apache/flink/pull/19410#issuecomment-1120109452 ping @slinkydeveloper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] JackWangCS commented on pull request #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode

JackWangCS commented on PR #19666: URL: https://github.com/apache/flink/pull/19666#issuecomment-1120109399 > @JackWangCS It looks good to me Thank you for the code review, let us wait for the CI report. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] liuyongvs commented on pull request #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode

liuyongvs commented on PR #19666: URL: https://github.com/apache/flink/pull/19666#issuecomment-1120108825 @JackWangCS It looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] JackWangCS commented on pull request #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode

JackWangCS commented on PR #19666: URL: https://github.com/apache/flink/pull/19666#issuecomment-1120108403 Hi @XComp , could you help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] flinkbot commented on pull request #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode

flinkbot commented on PR #19666: URL: https://github.com/apache/flink/pull/19666#issuecomment-1120108334 ## CI report: * eeef4606a89d9137721fe4e43284167a76f911ed UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-25950) Delete retry mechanism from ZooKeeperUtils.deleteZNode

[ https://issues.apache.org/jira/browse/FLINK-25950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25950: --- Labels: pull-request-available (was: ) > Delete retry mechanism from

[GitHub] [flink] JackWangCS opened a new pull request, #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode

JackWangCS opened a new pull request, #19666: URL: https://github.com/apache/flink/pull/19666 ## What is the purpose of the change ZooKeeperUtils.deleteZNode implements a retry loop that is not necessary for curator version 4.0.1+. We can use idempotent delete since we already

[GitHub] [flink-ml] zhipeng93 commented on pull request #93: [FLINK-27091] Add Transformer and Estimator for LinearSVC

zhipeng93 commented on PR #93: URL: https://github.com/apache/flink-ml/pull/93#issuecomment-1120098160 @lindong28 @yunfengzhou-hub Can you help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] RocMarshal commented on pull request #18928: [FLINK-25545][flink-clients][JUnit5 Migration] Module: flink-clients.

RocMarshal commented on PR #18928: URL: https://github.com/apache/flink/pull/18928#issuecomment-1120094338 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] dependabot[bot] commented on pull request #80: Bump checkstyle from 8.14 to 8.29

dependabot[bot] commented on PR #80: URL: https://github.com/apache/flink-ml/pull/80#issuecomment-1120089918 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

[GitHub] [flink-ml] lindong28 commented on pull request #80: Bump checkstyle from 8.14 to 8.29

lindong28 commented on PR #80: URL: https://github.com/apache/flink-ml/pull/80#issuecomment-1120089909 apache/flink-ml should use the same checkstyle as apache/flink, which is still using checkstyle 8.14. We will bump checkstyle version when apache/flink bump checkstyle version in

[GitHub] [flink-ml] lindong28 closed pull request #80: Bump checkstyle from 8.14 to 8.29

lindong28 closed pull request #80: Bump checkstyle from 8.14 to 8.29 URL: https://github.com/apache/flink-ml/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Closed] (FLINK-27496) Add test for rollback during application upgrade

[ https://issues.apache.org/jira/browse/FLINK-27496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-27496. -- Resolution: Won't Do > Add test for rollback during application upgrade >

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r867148302 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -211,6

[GitHub] [flink-playgrounds] fredthomsen opened a new pull request, #28: Build pyflint image with compatible python version

fredthomsen opened a new pull request, #28: URL: https://github.com/apache/flink-playgrounds/pull/28 The underlying base image is now debian bullseye which ships with python3.9 and this version of python is not compatible with pyflink. Thus build and add python3.7 to image.

[GitHub] [flink-docker] afedulov commented on a diff in pull request #116: Publish snapshot images

afedulov commented on code in PR #116: URL: https://github.com/apache/flink-docker/pull/116#discussion_r866998834 ## utils.sh: ## @@ -0,0 +1,59 @@ +#!/bin/bash -e + +IMAGE_REPO=$1 +echo "Image repository: $IMAGE_REPO" + +function image_tag() { +local dockerfile +

[GitHub] [flink-docker] afedulov commented on a diff in pull request #116: Publish snapshot images

afedulov commented on code in PR #116: URL: https://github.com/apache/flink-docker/pull/116#discussion_r866937358 ## .github/workflows/snapshot.yml: ## @@ -0,0 +1,68 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See

[jira] [Updated] (FLINK-27537) Remove requirement for Async Sink's RequestEntryT to be serializable

[ https://issues.apache.org/jira/browse/FLINK-27537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zichen Liu updated FLINK-27537: --- Description: Currently, in AsyncSinkBase and it's dependent classes, e.g. the sink writer, element

[jira] [Created] (FLINK-27537) Remove requirement for Async Sink's RequestEntryT to be serializable

Zichen Liu created FLINK-27537: -- Summary: Remove requirement for Async Sink's RequestEntryT to be serializable Key: FLINK-27537 URL: https://issues.apache.org/jira/browse/FLINK-27537 Project: Flink

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r866974112 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,13 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

gyfora commented on PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#issuecomment-1119777605 @wangyang0918 of course, I really appreciate it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r866974112 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,13 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

wangyang0918 commented on PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#issuecomment-1119769786 If you do not mind, I will do some manual tests tomorrow and share the feedback then. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

wangyang0918 commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866949459 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobStatusObserver.java: ## @@ -57,7 +55,7 @@ public

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

wangyang0918 commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866948431 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -112,30 +132,31 @@ protected

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866948228 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +259,40 @@ public

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

wangyang0918 commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866945827 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +259,40 @@

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866941979 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -211,6

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866941717 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -173,6 +174,16

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866940778 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobStatusObserver.java: ## @@ -57,7 +55,7 @@ public boolean

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

morhidi commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866939928 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -112,30 +132,31 @@ protected

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

morhidi commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866939928 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -112,30 +132,31 @@ protected

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

morhidi commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866938596 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -173,6 +174,16

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

morhidi commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866938313 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -211,6

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866937604 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +259,40 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

gyfora commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866934861 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -112,30 +132,31 @@ protected

[GitHub] [flink-docker] afedulov commented on a diff in pull request #116: Publish snapshot images

afedulov commented on code in PR #116: URL: https://github.com/apache/flink-docker/pull/116#discussion_r866934213 ## .github/workflows/snapshot.yml: ## @@ -0,0 +1,68 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See

[jira] [Commented] (FLINK-27520) Use admission-controller-framework in Webhook

[ https://issues.apache.org/jira/browse/FLINK-27520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17532922#comment-17532922 ] Matyas Orhidi commented on FLINK-27520: --- The released version doesn't appear to be healthy:

[jira] [Commented] (FLINK-27499) Bump base Flink version to 1.15.0

[ https://issues.apache.org/jira/browse/FLINK-27499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17532920#comment-17532920 ] Yang Wang commented on FLINK-27499: --- What I mean is we could improve the e2e tests to cover all the

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

wangyang0918 commented on code in PR #195: URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r866602275 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobStatusObserver.java: ## @@ -57,7 +55,7 @@ public

[GitHub] [flink] TennyZhuang commented on pull request #19665: [hotfix][doc] Fix the mismatch result in Window Join example

TennyZhuang commented on PR #19665: URL: https://github.com/apache/flink/pull/19665#issuecomment-1119711845 > Could you help to update the Chinese documentation which is located in `docs/content.zh/docs/dev/table/sql/queries/window-join.md`? fixed -- This is an automated message

[GitHub] [flink] flinkbot commented on pull request #19665: [hotfix] [doc] Fix the mismatch result in Window Join example

flinkbot commented on PR #19665: URL: https://github.com/apache/flink/pull/19665#issuecomment-1119689445 ## CI report: * 0b519b6fa7ebd3a6fa33e9393ac29355f27cf01e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] TennyZhuang opened a new pull request, #19665: [hotfix] [doc] Fix the mismatch result in Window Join example

TennyZhuang opened a new pull request, #19665: URL: https://github.com/apache/flink/pull/19665 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring

[GitHub] [flink] fapaul commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

fapaul commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r866877842 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,13 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC

[GitHub] [flink-ml] dependabot[bot] commented on pull request #81: Bump log4j-core from 2.17.0 to 2.17.1

dependabot[bot] commented on PR #81: URL: https://github.com/apache/flink-ml/pull/81#issuecomment-1119681778 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

[GitHub] [flink-ml] lindong28 commented on pull request #81: Bump log4j-core from 2.17.0 to 2.17.1

lindong28 commented on PR #81: URL: https://github.com/apache/flink-ml/pull/81#issuecomment-1119681735 The change has been made in https://github.com/apache/flink-ml/pull/81. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-ml] lindong28 closed pull request #81: Bump log4j-core from 2.17.0 to 2.17.1

lindong28 closed pull request #81: Bump log4j-core from 2.17.0 to 2.17.1 URL: https://github.com/apache/flink-ml/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-ml] dependabot[bot] closed pull request #84: Bump hadoop-common from 2.4.1 to 3.2.3 in /flink-ml-iteration

dependabot[bot] closed pull request #84: Bump hadoop-common from 2.4.1 to 3.2.3 in /flink-ml-iteration URL: https://github.com/apache/flink-ml/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink-ml] dependabot[bot] commented on pull request #84: Bump hadoop-common from 2.4.1 to 3.2.3 in /flink-ml-iteration

dependabot[bot] commented on PR #84: URL: https://github.com/apache/flink-ml/pull/84#issuecomment-1119678290 Looks like org.apache.hadoop:hadoop-common is no longer updatable, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink-ml] dependabot[bot] closed pull request #85: Bump hadoop-common from 2.4.1 to 3.2.3 in /flink-ml-core

dependabot[bot] closed pull request #85: Bump hadoop-common from 2.4.1 to 3.2.3 in /flink-ml-core URL: https://github.com/apache/flink-ml/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-ml] dependabot[bot] commented on pull request #85: Bump hadoop-common from 2.4.1 to 3.2.3 in /flink-ml-core

dependabot[bot] commented on PR #85: URL: https://github.com/apache/flink-ml/pull/85#issuecomment-1119678250 Looks like org.apache.hadoop:hadoop-common is no longer updatable, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink-ml] zhipeng93 commented on pull request #94: [hotfix] Bump dependency versions

zhipeng93 commented on PR #94: URL: https://github.com/apache/flink-ml/pull/94#issuecomment-1119673384 Thanks for the PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] zhipeng93 merged pull request #94: [hotfix] Bump dependency versions

zhipeng93 merged PR #94: URL: https://github.com/apache/flink-ml/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #192: [FLINK-27097] Document custom validator implementations

gyfora commented on code in PR #192: URL: https://github.com/apache/flink-kubernetes-operator/pull/192#discussion_r866867020 ## docs/content/docs/operations/validator.md: ## @@ -0,0 +1,85 @@ +--- +title: "Validator" +weight: 5 +type: docs +aliases: +-

[GitHub] [flink] fapaul commented on pull request #19658: [FLINK-27480][kafka] Explain possible metrics InstanceAlreadyExistsException in docs

fapaul commented on PR #19658: URL: https://github.com/apache/flink/pull/19658#issuecomment-1119659178 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Closed] (FLINK-27262) Enrich validator for FlinkSessionJob

[ https://issues.apache.org/jira/browse/FLINK-27262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-27262. -- Resolution: Fixed merged to main: 6ff7cf31c61d50a1459b518cfae86fc65e3c5810 > Enrich validator for

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #184: [FLINK-27262] Enrich validator for FlinkSessionJob

gyfora merged PR #184: URL: https://github.com/apache/flink-kubernetes-operator/pull/184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] RocMarshal commented on a diff in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn

RocMarshal commented on code in PR #18983: URL: https://github.com/apache/flink/pull/18983#discussion_r866856860 ## flink-yarn/src/test/java/org/apache/flink/yarn/TaskExecutorProcessSpecContainerResourcePriorityAdapterTest.java: ## @@ -206,40 +199,49 @@ public void

[GitHub] [flink-web] CrynetLogistics commented on a diff in pull request #517: [FLINK-24370] Addition of blog post describing features and usage of the Async Sink…

CrynetLogistics commented on code in PR #517: URL: https://github.com/apache/flink-web/pull/517#discussion_r866853715 ## _posts/2022-03-16-async-sink-base.md: ## @@ -0,0 +1,169 @@ +--- +layout: post +title: "The Generic Asynchronous Base Sink" +date: 2022-04-30 16:00:00

[jira] [Created] (FLINK-27536) Rename method parameter in AsyncSinkWriter

Zichen Liu created FLINK-27536: -- Summary: Rename method parameter in AsyncSinkWriter Key: FLINK-27536 URL: https://issues.apache.org/jira/browse/FLINK-27536 Project: Flink Issue Type:

[GitHub] [flink] rovboyko commented on pull request #19648: [FLINK-27438][table-planner] Fix the constructing a map array

rovboyko commented on PR #19648: URL: https://github.com/apache/flink/pull/19648#issuecomment-1119639236 > @MartijnVisser Would be great to backport it to 1.15 and I guess 1.14 as well. Yes, we discussed it, I'll do it. -- This is an automated message from the Apache Git Service.

[jira] [Closed] (FLINK-27528) Introduce a new configuration option 'compact.rescale-bucket' for FileStore

[ https://issues.apache.org/jira/browse/FLINK-27528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-27528. Assignee: Jane Chan Resolution: Fixed master: d0576e1bbd7f798d68db398593c8368376743203 >

[GitHub] [flink] fapaul commented on pull request #19649: [FLINK-27487][kafka] Only forward measurable Kafka metrics and ignore others

fapaul commented on PR #19649: URL: https://github.com/apache/flink/pull/19649#issuecomment-1119628108 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-table-store] JingsongLi merged pull request #109: [FLINK-27528] Introduce a new configuration option 'compact.rescale-bucket' for FileStore

JingsongLi merged PR #109: URL: https://github.com/apache/flink-table-store/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] hililiwei commented on pull request #17798: [hotfix] Fix comment typos in AsyncIOExample

hililiwei commented on PR #17798: URL: https://github.com/apache/flink/pull/17798#issuecomment-1119617629 I edited the description and title of PR again. Please take a look. Thank you.  -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] flinkbot commented on pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

flinkbot commented on PR #19664: URL: https://github.com/apache/flink/pull/19664#issuecomment-1119609351 ## CI report: * d7a71c91e7c3ec0799b12a33694715ac8ccedfcb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] JingGe opened a new pull request, #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

JingGe opened a new pull request, #19664: URL: https://github.com/apache/flink/pull/19664 ## What is the purpose of the change This PR will let Flink be aware of changes of metrics e.g. `numRecordsSend`, `numRecordsOutErrors`, etc. ## Brief change log - add the

[GitHub] [flink] alpreu commented on a diff in pull request #19552: [FLINK-27185][connectors][formats] Convert format modules to assertj

alpreu commented on code in PR #19552: URL: https://github.com/apache/flink/pull/19552#discussion_r866808922 ## flink-formats/flink-sequence-file/src/test/java/org/apache/flink/formats/sequencefile/SerializableHadoopConfigurationTest.java: ## @@ -55,8 +57,8 @@ public void

[GitHub] [flink-web] dannycranmer commented on a diff in pull request #517: [FLINK-24370] Addition of blog post describing features and usage of the Async Sink…

dannycranmer commented on code in PR #517: URL: https://github.com/apache/flink-web/pull/517#discussion_r866808673 ## _posts/2022-03-16-async-sink-base.md: ## @@ -0,0 +1,169 @@ +--- +layout: post +title: "The Generic Asynchronous Base Sink" +date: 2022-04-30 16:00:00 +authors:

[GitHub] [flink] onyourhead commented on pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties

onyourhead commented on PR #19628: URL: https://github.com/apache/flink/pull/19628#issuecomment-1119595202 Because there are some commits behind the master branch, the code of the backport is a little different. And `KafkaSinkBuilderTest` only exists in the master branch. -- This is an

[GitHub] [flink] echauchot commented on pull request #19586: [FLINK-26824] [FLINK-27457] Upgrade Flink's supported Cassandra versions to match all Apache Cassandra supported versions and support flush

echauchot commented on PR #19586: URL: https://github.com/apache/flink/pull/19586#issuecomment-1119594598 > Would you mind moving the flushing changes into another PR? I could be in that case the uncovered race condition won't be fixed. So the output formats tests would fail on

[GitHub] [flink] flinkbot commented on pull request #19663: [BP-1.15][FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties

flinkbot commented on PR #19663: URL: https://github.com/apache/flink/pull/19663#issuecomment-1119593719 ## CI report: * 02a7c0597eab389212fe01fc4ece234e26ee9add UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #19662: [BP-1.14][FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties

flinkbot commented on PR #19662: URL: https://github.com/apache/flink/pull/19662#issuecomment-1119593626 ## CI report: * 7284f2cf67175ec15e51bb096c3db9985a4b87b8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] matriv commented on pull request #19648: [FLINK-27438][table-planner] Fix the constructing a map array

matriv commented on PR #19648: URL: https://github.com/apache/flink/pull/19648#issuecomment-1119593074 @MartijnVisser Would be great to backport it to 1.15 and I guess 1.14 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] onyourhead opened a new pull request, #19663: [BP-1.15][FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties

onyourhead opened a new pull request, #19663: URL: https://github.com/apache/flink/pull/19663 This is a backport PR for #19628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] onyourhead opened a new pull request, #19662: [BP-1.14][FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties

onyourhead opened a new pull request, #19662: URL: https://github.com/apache/flink/pull/19662 This is a backport PR for #19628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] HuangZhenQiu commented on pull request #14678: [FLINK-20833][runtime] Add pluggable failure listener in job manager

HuangZhenQiu commented on PR #14678: URL: https://github.com/apache/flink/pull/14678#issuecomment-1119584546 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] rovboyko commented on pull request #19648: [FLINK-27438][table-planner] Fix the constructing a map array

rovboyko commented on PR #19648: URL: https://github.com/apache/flink/pull/19648#issuecomment-1119581469 @matriv Thank you for such thorough review! I've fixed all and resolved all discussions. Could you please take a look once again? -- This is an automated message from the Apache

[jira] [Assigned] (FLINK-27492) Flink table scala example does not including the scala-api jars

[ https://issues.apache.org/jira/browse/FLINK-27492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-27492: Assignee: Timo Walther > Flink table scala example does not including the scala-api jars

[GitHub] [flink] rovboyko commented on a diff in pull request #19648: [FLINK-27438][table-planner] Fix the constructing a map array

rovboyko commented on code in PR #19648: URL: https://github.com/apache/flink/pull/19648#discussion_r866791617 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/CalcTest.scala: ## @@ -187,4 +187,13 @@ class CalcTest extends

[GitHub] [flink-web] zentol merged pull request #517: [FLINK-24370] Addition of blog post describing features and usage of the Async Sink…

zentol merged PR #517: URL: https://github.com/apache/flink-web/pull/517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] rovboyko commented on a diff in pull request #19648: [FLINK-27438][table-planner] Fix the constructing a map array

rovboyko commented on code in PR #19648: URL: https://github.com/apache/flink/pull/19648#discussion_r866791321 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/utils/SqlValidatorUtils.java: ## @@ -76,9 +80,27 @@ private static void

[jira] [Updated] (FLINK-27535) Optimize the unit test execution time

[ https://issues.apache.org/jira/browse/FLINK-27535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-27535: - Affects Version/s: (was: ml-2.1.0) > Optimize the unit test execution time >

[jira] [Updated] (FLINK-27535) Optimize the unit test execution time

[ https://issues.apache.org/jira/browse/FLINK-27535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-27535: - Fix Version/s: ml-2.1.0 > Optimize the unit test execution time > -

  1   2   3   >