[GitHub] [flink] HuangXingBo commented on a diff in pull request #21725: [FLINK-29000][python] Support python UDF in the SQL Gateway

2023-01-18 Thread GitBox
HuangXingBo commented on code in PR #21725: URL: https://github.com/apache/flink/pull/21725#discussion_r1080914005 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/DefaultContext.java: ## @@ -55,15 +58,31 @@ public

[GitHub] [flink] HuangXingBo commented on a diff in pull request #21725: [FLINK-29000][python] Support python UDF in the SQL Gateway

2023-01-18 Thread GitBox
HuangXingBo commented on code in PR #21725: URL: https://github.com/apache/flink/pull/21725#discussion_r1080913833 ## flink-connectors/flink-connector-hive/pom.xml: ## @@ -1097,6 +1097,12 @@ under the License. ${project.version}

[GitHub] [flink] HuangXingBo commented on a diff in pull request #21725: [FLINK-29000][python] Support python UDF in the SQL Gateway

2023-01-18 Thread GitBox
HuangXingBo commented on code in PR #21725: URL: https://github.com/apache/flink/pull/21725#discussion_r1080912316 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/DefaultContext.java: ## @@ -55,15 +58,31 @@ public

[GitHub] [flink] fsk119 commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

2023-01-18 Thread GitBox
fsk119 commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396569697 Sorry for closing the PR. I hit the wrong button... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] snuyanzin opened a new pull request, #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

2023-01-18 Thread GitBox
snuyanzin opened a new pull request, #17830: URL: https://github.com/apache/flink/pull/17830 ## What is the purpose of the change This PR is a part of FLIP-189 about prompt customization. There are left and right prompt which could be customized in the same way. Left prompt

[GitHub] [flink] fsk119 closed pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

2023-01-18 Thread GitBox
fsk119 closed pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization URL: https://github.com/apache/flink/pull/17830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] fsk119 commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

2023-01-18 Thread GitBox
fsk119 commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396566805 Okay. Because #21717 totally changes the architecture of the SQL Client. You may need to rebase again and again... So I just suggest rebasing all refactoring. The design of the

[jira] [Updated] (FLINK-30751) Remove references to disableDataSync in RocksDB documentation

2023-01-18 Thread David Christle (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Christle updated FLINK-30751: --- Description: The EmbeddedRocksDBStateBackend allows configuration using some predefined

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-01-18 Thread GitBox
ruanhang1993 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1080899530 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/splitreader/SplitsDeletion.java: ## @@ -0,0 +1,40 @@ +/* + *

[jira] [Updated] (FLINK-29000) Support python UDF in the SQL Gateway

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29000: --- Labels: pull-request-available (was: ) > Support python UDF in the SQL Gateway >

[GitHub] [flink] fsk119 commented on a diff in pull request #21725: [FLINK-29000][python] Support python UDF in the SQL Gateway

2023-01-18 Thread GitBox
fsk119 commented on code in PR #21725: URL: https://github.com/apache/flink/pull/21725#discussion_r1080884303 ## flink-connectors/flink-connector-hive/pom.xml: ## @@ -1097,6 +1097,12 @@ under the License. ${project.version} test

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-01-18 Thread GitBox
ruanhang1993 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1080899530 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/splitreader/SplitsDeletion.java: ## @@ -0,0 +1,40 @@ +/* + *

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-01-18 Thread GitBox
ruanhang1993 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1080897687 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/splitreader/SplitsDeletion.java: ## @@ -0,0 +1,40 @@ +/* + *

[GitHub] [flink] snuyanzin commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

2023-01-18 Thread GitBox
snuyanzin commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396549855 thanks for the response and reference to https://github.com/apache/flink/pull/21717. I will have a look. I noticed conflicts and try to solve them. For it's sometimes easier to

[GitHub] [flink] flinkbot commented on pull request #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation

2023-01-18 Thread GitBox
flinkbot commented on PR #21729: URL: https://github.com/apache/flink/pull/21729#issuecomment-1396544048 ## CI report: * c3a904a93192be9bf612e76edbfa39465b398404 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27716) Add Python API docs in ML

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27716: --- Labels: pull-request-available (was: ) > Add Python API docs in ML >

[GitHub] [flink] flinkbot commented on pull request #21728: [FLINK-30667] decouple hive connector with planner internal class

2023-01-18 Thread GitBox
flinkbot commented on PR #21728: URL: https://github.com/apache/flink/pull/21728#issuecomment-1396543949 ## CI report: * be0fcfcfa931339826e99a8b09550be8385d6fd5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] jiangxin369 opened a new pull request, #201: [FLINK-27716] Add Python API docs in ML

2023-01-18 Thread GitBox
jiangxin369 opened a new pull request, #201: URL: https://github.com/apache/flink-ml/pull/201 ## What is the purpose of the change Add Python API docs in ML. ## Brief change log - Adds Sphinx config to generate Python API doc automatically. - Sets the

[GitHub] [flink] chenqin commented on pull request #21728: [FLINK-30667] decouple hive connector with planner internal class

2023-01-18 Thread GitBox
chenqin commented on PR #21728: URL: https://github.com/apache/flink/pull/21728#issuecomment-1396541490 @luoyuxia please help take a look, here is a bit rationale - parser should be PublicEvolving interface while both Flink and hive has own internal implementation. so hive connector

[jira] [Comment Edited] (FLINK-30667) remove the planner @internal dependency in flink-connector-hive

2023-01-18 Thread Chen Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678003#comment-17678003 ] Chen Qin edited comment on FLINK-30667 at 1/19/23 7:19 AM: --- parser should be

[jira] [Updated] (FLINK-30751) Remove references to disableDataSync in RocksDB documentation

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30751: --- Labels: pull-request-available (was: ) > Remove references to disableDataSync in RocksDB

[GitHub] [flink] dchristle opened a new pull request, #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation

2023-01-18 Thread GitBox
dchristle opened a new pull request, #21729: URL: https://github.com/apache/flink/pull/21729 ## What is the purpose of the change This PR corrects and improves the readability of the documentation for RocksDB predefined option sets. References to `disableDataSync`, which

[jira] [Updated] (FLINK-30025) table.execute().print() can only use the default max column width

2023-01-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-30025: Description: table.execute().print() can only use the default max column width. When running table API

[jira] [Updated] (FLINK-30025) Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

2023-01-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-30025: Description: FLIP-279

[jira] [Updated] (FLINK-30025) Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

2023-01-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-30025: Summary: Unified the max display column width for SqlClient and Table APi in both Streaming and Batch

[jira] [Comment Edited] (FLINK-30667) remove the planner @internal dependency in flink-connector-hive

2023-01-18 Thread Chen Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678003#comment-17678003 ] Chen Qin edited comment on FLINK-30667 at 1/19/23 7:16 AM: --- Paper should be

[GitHub] [flink] chenqin opened a new pull request, #21728: [FLINK-30667] decouple hive connector with planner internal class

2023-01-18 Thread GitBox
chenqin opened a new pull request, #21728: URL: https://github.com/apache/flink/pull/21728 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] fsk119 commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

2023-01-18 Thread GitBox
fsk119 commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396537732 I think some features may not be easily to support in the gateway mode. We may introduce some REST API to fetch the current catalog and database. WDYT? -- This is an automated message

[GitHub] [flink] fsk119 commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

2023-01-18 Thread GitBox
fsk119 commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396536467 Sorry for the late response. I am refactoring the SQL Client in the #21717 . Do you mind we support this features after the refactor finishes? I can help to rebase this when most codes

[GitHub] [flink] flinkbot commented on pull request #21727: [FLINK-30752][python] Support 'EXPLAIN PLAN_ADVICE' statement in PyFlink

2023-01-18 Thread GitBox
flinkbot commented on PR #21727: URL: https://github.com/apache/flink/pull/21727#issuecomment-1396534110 ## CI report: * 65b5f8395b61ec1ee0040217f02ff202d0ad7c0e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-30677) SqlGatewayServiceStatementITCase.testFlinkSqlStatements fails

2023-01-18 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-30677. - Fix Version/s: 1.17.0 Resolution: Fixed Fixed in the

[jira] [Assigned] (FLINK-30677) SqlGatewayServiceStatementITCase.testFlinkSqlStatements fails

2023-01-18 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-30677: - Assignee: Paul Lin (was: Lin Yan) >

[jira] [Assigned] (FLINK-30677) SqlGatewayServiceStatementITCase.testFlinkSqlStatements fails

2023-01-18 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-30677: - Assignee: Lin Yan > SqlGatewayServiceStatementITCase.testFlinkSqlStatements fails >

[GitHub] [flink] fsk119 closed pull request #21700: [FLINK-30677][Test] Fix unstable SqlGatewayServiceStatementITCase.testFlinkSqlStatements

2023-01-18 Thread GitBox
fsk119 closed pull request #21700: [FLINK-30677][Test] Fix unstable SqlGatewayServiceStatementITCase.testFlinkSqlStatements URL: https://github.com/apache/flink/pull/21700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-30752) Support 'EXPLAIN PLAN_ADVICE' statement in PyFlink

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30752: --- Labels: pull-request-available (was: ) > Support 'EXPLAIN PLAN_ADVICE' statement in

[GitHub] [flink] LadyForest opened a new pull request, #21727: [FLINK-30752][python] Support 'EXPLAIN PLAN_ADVICE' statement in PyFlink

2023-01-18 Thread GitBox
LadyForest opened a new pull request, #21727: URL: https://github.com/apache/flink/pull/21727 ## What is the purpose of the change This PR supports the `EXPLAIN PLAN_ADVICE` statement in PyFlink (need to rebase once FLINK-30672 is merged). ## Brief change log Introduce

[GitHub] [flink] snuyanzin commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

2023-01-18 Thread GitBox
snuyanzin commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396515924 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] 1996fanrui commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-18 Thread GitBox
1996fanrui commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1396507794 > Are you suggesting that we should now couple the caller of DataOutput with the code that constructed it? In fact, the code in the master branch did this a long time ago.

[jira] [Created] (FLINK-30752) Support 'EXPLAIN PLAN_ADVICE' statement in PyFlink

2023-01-18 Thread Jane Chan (Jira)
Jane Chan created FLINK-30752: - Summary: Support 'EXPLAIN PLAN_ADVICE' statement in PyFlink Key: FLINK-30752 URL: https://issues.apache.org/jira/browse/FLINK-30752 Project: Flink Issue Type:

[GitHub] [flink] hehuiyuan commented on a diff in pull request #21668: [FLINK-30679][HIVE]Can not load the data of hive dim table when project-push-down is introduced

2023-01-18 Thread GitBox
hehuiyuan commented on code in PR #21668: URL: https://github.com/apache/flink/pull/21668#discussion_r1080847440 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveLookupJoinITCase.java: ## @@ -378,6 +378,31 @@ public void

[GitHub] [flink] chenqin closed pull request #21710: [FLINK-30667] [Table/Planner] remove hive-connector dep on table-planner internal class

2023-01-18 Thread GitBox
chenqin closed pull request #21710: [FLINK-30667] [Table/Planner] remove hive-connector dep on table-planner internal class URL: https://github.com/apache/flink/pull/21710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2023-01-18 Thread GitBox
mas-chen commented on code in PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1080844703 ## flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientKafkaITCase.java: ## @@

[GitHub] [flink] snuyanzin commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

2023-01-18 Thread GitBox
snuyanzin commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396484993 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] hehuiyuan commented on a diff in pull request #21668: [FLINK-30679][HIVE]Can not load the data of hive dim table when project-push-down is introduced

2023-01-18 Thread GitBox
hehuiyuan commented on code in PR #21668: URL: https://github.com/apache/flink/pull/21668#discussion_r1080838455 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveLookupJoinITCase.java: ## @@ -378,6 +378,31 @@ public void

[jira] [Created] (FLINK-30751) Remove references to disableDataSync in RocksDB documentation

2023-01-18 Thread David Christle (Jira)
David Christle created FLINK-30751: -- Summary: Remove references to disableDataSync in RocksDB documentation Key: FLINK-30751 URL: https://issues.apache.org/jira/browse/FLINK-30751 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #21726: [FLINK-30748][docs]Translate "Overview" page of "Querys" into Chinese

2023-01-18 Thread GitBox
flinkbot commented on PR #21726: URL: https://github.com/apache/flink/pull/21726#issuecomment-1396471685 ## CI report: * 92a18af335774a0f49b3a22f26b8abbd576dd4bd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-30748) Translate "Overview" page of "Querys" into Chinese

2023-01-18 Thread chenhaiyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678294#comment-17678294 ] chenhaiyang edited comment on FLINK-30748 at 1/19/23 5:45 AM: -- Hi [~jark],

[jira] [Commented] (FLINK-30680) Consider using the autoscaler to detect slow taskmanagers

2023-01-18 Thread Shammon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678496#comment-17678496 ] Shammon commented on FLINK-30680: - Thanks [~gyfora] to create this issue. In fact out team in bytedance

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21683: [FLINK-30672][table] Support 'EXPLAIN PLAN_ADVICE' statement

2023-01-18 Thread GitBox
lincoln-lil commented on code in PR #21683: URL: https://github.com/apache/flink/pull/21683#discussion_r1080828555 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelOptUtil.scala: ## @@ -90,6 +90,58 @@ object FlinkRelOptUtil {

[jira] [Updated] (FLINK-30748) Translate "Overview" page of "Querys" into Chinese

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30748: --- Labels: pull-request-available (was: ) > Translate "Overview" page of "Querys" into

[GitHub] [flink] NightRunner opened a new pull request, #21726: [FLINK-30748][docs]Translate "Overview" page of "Querys" into Chinese

2023-01-18 Thread GitBox
NightRunner opened a new pull request, #21726: URL: https://github.com/apache/flink/pull/21726 Translate "Overview" page of "Querys" into Chinese ## What is the purpose of the change Translate /dev/table/sql/queries/overview.md ## Brief change log Translate

[GitHub] [flink] luoyuxia commented on pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

2023-01-18 Thread GitBox
luoyuxia commented on PR #21703: URL: https://github.com/apache/flink/pull/21703#issuecomment-1396453771 @lsyldliu Thanks for reviewing. I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] luoyuxia commented on a diff in pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

2023-01-18 Thread GitBox
luoyuxia commented on code in PR #21703: URL: https://github.com/apache/flink/pull/21703#discussion_r1080818665 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java: ## @@ -351,15 +365,211 @@ private DataStreamSink consume(

[GitHub] [flink] luoyuxia commented on a diff in pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

2023-01-18 Thread GitBox
luoyuxia commented on code in PR #21703: URL: https://github.com/apache/flink/pull/21703#discussion_r1080814492 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveOptions.java: ## @@ -140,6 +140,15 @@ public class HiveOptions {

[GitHub] [flink] luoyuxia commented on a diff in pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

2023-01-18 Thread GitBox
luoyuxia commented on code in PR #21703: URL: https://github.com/apache/flink/pull/21703#discussion_r1080814012 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/BatchSink.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the

[GitHub] [flink] luoyuxia commented on a diff in pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

2023-01-18 Thread GitBox
luoyuxia commented on code in PR #21703: URL: https://github.com/apache/flink/pull/21703#discussion_r1080813573 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java: ## @@ -351,15 +365,211 @@ private DataStreamSink consume(

[jira] [Commented] (FLINK-30745) Check-pointing with Azure Data Lake Storage

2023-01-18 Thread Dheeraj Panangat (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678486#comment-17678486 ] Dheeraj Panangat commented on FLINK-30745: -- Hi [~surendralilhore] , Not specified any value for

[GitHub] [flink] lsyldliu commented on a diff in pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

2023-01-18 Thread GitBox
lsyldliu commented on code in PR #21703: URL: https://github.com/apache/flink/pull/21703#discussion_r1080776842 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/BatchSink.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the

[GitHub] [flink] lindong28 commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-18 Thread GitBox
lindong28 commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1396411041 > For example: MultipleInputStreamTask[1] and OneInputStreamTask[2] have corresponding CheckpointBarrierHandler, if MultipleInputStreamTask calls CheckpointBarrierHandler of

[jira] [Closed] (FLINK-30191) Update py4j from 0.10.9.3 to 0.10.9.7

2023-01-18 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo closed FLINK-30191. Fix Version/s: 1.17.0 Resolution: Done Merged into master via

[GitHub] [flink] HuangXingBo closed pull request #21680: [FLINK-30191][python] Update net.sf.py4j:py4j dependency to 0.10.9.7

2023-01-18 Thread GitBox
HuangXingBo closed pull request #21680: [FLINK-30191][python] Update net.sf.py4j:py4j dependency to 0.10.9.7 URL: https://github.com/apache/flink/pull/21680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] flinkbot commented on pull request #21725: [FLINK-2900][python] Support python UDF in the SQL Gateway

2023-01-18 Thread GitBox
flinkbot commented on PR #21725: URL: https://github.com/apache/flink/pull/21725#issuecomment-1396402673 ## CI report: * 1af7133e05aa5bcd2277b10095fcb95b220b683d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29000) Support python UDF in the SQL Gateway

2023-01-18 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo updated FLINK-29000: - Fix Version/s: 1.17.0 > Support python UDF in the SQL Gateway >

[jira] [Updated] (FLINK-2900) Remove Record-API dependencies from Hadoop Compat module

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-2900: -- Labels: pull-request-available (was: ) > Remove Record-API dependencies from Hadoop Compat

[GitHub] [flink] HuangXingBo opened a new pull request, #21725: [FLINK-2900][python] Support python UDF in the SQL Gateway

2023-01-18 Thread GitBox
HuangXingBo opened a new pull request, #21725: URL: https://github.com/apache/flink/pull/21725 ## What is the purpose of the change *This pull request will support python UDF in the SQL Gateway* ## Brief change log - *Support python UDF in the SQL Gateway*

[jira] [Updated] (FLINK-30750) CompactActionITCase.testBatchCompact in table store is unstable

2023-01-18 Thread Shammon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shammon updated FLINK-30750: Description: https://github.com/apache/flink-table-store/actions/runs/3954989166/jobs/6772877033

[GitHub] [flink] lindong28 commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-18 Thread GitBox
lindong28 commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1396398435 > It's strange that MultiInputStreamTask-D constructed a DataOutput-C, and OneInputStreamTask-B calls the DataOutput- > C::emitRecord constructed for MultiInputStreamTask-D. I think

[jira] [Assigned] (FLINK-29722) Supports hive max function by native implementation

2023-01-18 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He reassigned FLINK-29722: -- Assignee: dalongliu > Supports hive max function by native implementation >

[jira] [Closed] (FLINK-29722) Supports hive max function by native implementation

2023-01-18 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He closed FLINK-29722. -- Resolution: Fixed Fixed in 1.17.0: 74c7188ae9898b492c94a472d9d407bf4f8e0876 > Supports hive max

[jira] [Updated] (FLINK-29722) Supports hive max function by native implementation

2023-01-18 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He updated FLINK-29722: --- Component/s: Connectors / Hive > Supports hive max function by native implementation >

[GitHub] [flink] godfreyhe closed pull request #21605: [FLINK-29722][hive] Supports native hive max function for hive dialect

2023-01-18 Thread GitBox
godfreyhe closed pull request #21605: [FLINK-29722][hive] Supports native hive max function for hive dialect URL: https://github.com/apache/flink/pull/21605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (FLINK-30750) CompactActionITCase.testBatchCompact in table store is unstable

2023-01-18 Thread Shammon (Jira)
Shammon created FLINK-30750: --- Summary: CompactActionITCase.testBatchCompact in table store is unstable Key: FLINK-30750 URL: https://issues.apache.org/jira/browse/FLINK-30750 Project: Flink Issue

[GitHub] [flink] godfreyhe commented on a diff in pull request #21586: [FLINK-30542][table-runtime] Introduce adaptive hash aggregate to adaptively determine whether local hash aggregate is required a

2023-01-18 Thread GitBox
godfreyhe commented on code in PR #21586: URL: https://github.com/apache/flink/pull/21586#discussion_r1073610534 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecHashAggregate.java: ## @@ -58,6 +58,7 @@ public class

[GitHub] [flink-table-store] zjureel opened a new pull request, #489: [FLINK-30038] Fix hive e2e fail

2023-01-18 Thread GitBox
zjureel opened a new pull request, #489: URL: https://github.com/apache/flink-table-store/pull/489 Fix hive e2e fail Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.Starting HiveServer2.' at

[jira] [Updated] (FLINK-30038) HiveE2E test is not stable

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30038: --- Labels: pull-request-available (was: ) > HiveE2E test is not stable >

[GitHub] [flink] lsyldliu commented on a diff in pull request #21724: [FLINK-30727][table-planner] Fix JoinReorderITCaseBase.testBushyTreeJoinReorder failed

2023-01-18 Thread GitBox
lsyldliu commented on code in PR #21724: URL: https://github.com/apache/flink/pull/21724#discussion_r1080764519 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/join/JoinReorderITCase.java: ## @@ -42,6 +45,12 @@ public class

[GitHub] [flink] 1996fanrui commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-18 Thread GitBox
1996fanrui commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1396379268 Hi @lindong28 It's strange that `MultiInputStreamTask-D` constructed a `DataOutput-C`, and `OneInputStreamTask-B` calls the `DataOutput-C::emitRecord` constructed for

[GitHub] [flink] link3280 commented on pull request #21581: [FLINK-30538][SQL gateway/client] Improve error handling of stop job operation

2023-01-18 Thread GitBox
link3280 commented on PR #21581: URL: https://github.com/apache/flink/pull/21581#issuecomment-1396377724 ping @fsk119 . It should be a quick one :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] link3280 commented on pull request #21700: [FLINK-30677][Test] Fix unstable SqlGatewayServiceStatementITCase.testFlinkSqlStatements

2023-01-18 Thread GitBox
link3280 commented on PR #21700: URL: https://github.com/apache/flink/pull/21700#issuecomment-1396376577 Thanks a lot @fsk119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] Myasuka commented on pull request #21714: [FLINK-30724][docs] Update kafka-per-partition watermark to new source

2023-01-18 Thread GitBox
Myasuka commented on PR #21714: URL: https://github.com/apache/flink/pull/21714#issuecomment-1396373604 @MartijnVisser @PatrickRen please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] flinkbot commented on pull request #21724: [FLINK-30727][table-planner] Fix JoinReorderITCaseBase.testBushyTreeJoinReorder failed

2023-01-18 Thread GitBox
flinkbot commented on PR #21724: URL: https://github.com/apache/flink/pull/21724#issuecomment-1396372983 ## CI report: * d7feaaf31b5537c938840f279b507a295afe12e7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30727) JoinReorderITCase.testBushyTreeJoinReorder failed due to IOException

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30727: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] swuferhong opened a new pull request, #21724: [FLINK-30727][table-planner] Fix JoinReorderITCaseBase.testBushyTreeJoinReorder failed

2023-01-18 Thread GitBox
swuferhong opened a new pull request, #21724: URL: https://github.com/apache/flink/pull/21724 ## What is the purpose of the change This pr is aims to fix JoinReorderITCaseBase.testBushyTreeJoinReorder failed while running CI. The failed CI link:

[GitHub] [flink] lsyldliu commented on a diff in pull request #21586: [FLINK-30542][table-runtime] Introduce adaptive hash aggregate to adaptively determine whether local hash aggregate is required at

2023-01-18 Thread GitBox
lsyldliu commented on code in PR #21586: URL: https://github.com/apache/flink/pull/21586#discussion_r1073489490 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/batch/HashAggCodeGenerator.scala: ## @@ -38,32 +42,52 @@ import

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21683: [FLINK-30672][table] Support 'EXPLAIN PLAN_ADVICE' statement

2023-01-18 Thread GitBox
lincoln-lil commented on code in PR #21683: URL: https://github.com/apache/flink/pull/21683#discussion_r1080750180 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelOptUtil.scala: ## @@ -90,6 +90,38 @@ object FlinkRelOptUtil {

[jira] [Commented] (FLINK-30727) JoinReorderITCase.testBushyTreeJoinReorder failed due to IOException

2023-01-18 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678458#comment-17678458 ] Yunhong Zheng commented on FLINK-30727: --- Ok, [~mapohl] , I will look at it right away. >

[jira] [Commented] (FLINK-29884) Flaky test failure in finegrained_resource_management/SortMergeResultPartitionTest.testRelease

2023-01-18 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678444#comment-17678444 ] Yingjie Cao commented on FLINK-29884: - Merged into master via

[jira] [Closed] (FLINK-29884) Flaky test failure in finegrained_resource_management/SortMergeResultPartitionTest.testRelease

2023-01-18 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao closed FLINK-29884. --- Resolution: Fixed > Flaky test failure in >

[GitHub] [flink] wsry merged pull request #21707: [FLINK-29884][test] Fix flaky test SortMergeResultPartitionTest.testRelease

2023-01-18 Thread GitBox
wsry merged PR #21707: URL: https://github.com/apache/flink/pull/21707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wsry commented on pull request #21707: [FLINK-29884][test] Fix flaky test SortMergeResultPartitionTest.testRelease

2023-01-18 Thread GitBox
wsry commented on PR #21707: URL: https://github.com/apache/flink/pull/21707#issuecomment-1396314628 @reswqa Thanks for the fix. LGTM. Failure unrelated, Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (FLINK-30419) Allow tuning of transaction timeout

2023-01-18 Thread Alex Sorokoumov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678429#comment-17678429 ] Alex Sorokoumov commented on FLINK-30419: - > Do you mean we can have a default value for table

[GitHub] [flink] kristoffSC commented on pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-01-18 Thread GitBox
kristoffSC commented on PR #21393: URL: https://github.com/apache/flink/pull/21393#issuecomment-1396174097 Hi @tsreaper Thank you for your valuable feedback, no need to apologize :) Please see my response below. > In BlockStatementSplitter you group all single statements between

[jira] [Commented] (FLINK-13414) Add support for Scala 2.13

2023-01-18 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678400#comment-17678400 ] Martijn Visser commented on FLINK-13414: [~alexey.novakov] Erwan is correct. I would like to

[jira] [Commented] (FLINK-24736) Non vulenerable jar files for Apache Flink 1.14.4

2023-01-18 Thread Leonid Ilyevsky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678399#comment-17678399 ] Leonid Ilyevsky commented on FLINK-24736: - The same problem in the latest version 1.16.0.  I

[jira] [Commented] (FLINK-13414) Add support for Scala 2.13

2023-01-18 Thread Erwan Loisant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678395#comment-17678395 ] Erwan Loisant commented on FLINK-13414: --- [~novakov.alex] The Flink core no longer relies on

[jira] [Commented] (FLINK-13414) Add support for Scala 2.13

2023-01-18 Thread Alexey Novakov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678394#comment-17678394 ] Alexey Novakov commented on FLINK-13414: Hi there. Can somebody from Flink PMC please provide a

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

2023-01-18 Thread GitBox
afedulov commented on PR #20049: URL: https://github.com/apache/flink/pull/20049#issuecomment-1387594960 @Myasuka good idea, thanks for bringing it up. I will resume working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-26088) Add Elasticsearch 8.0 support

2023-01-18 Thread Matheus Felisberto (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678349#comment-17678349 ] Matheus Felisberto commented on FLINK-26088: Hi [~martijnvisser], how are you? I am not

[jira] [Commented] (FLINK-30745) Check-pointing with Azure Data Lake Storage

2023-01-18 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678329#comment-17678329 ] Surendra Singh Lilhore commented on FLINK-30745: Thanks [~dheerajpanangat] for reporting

[GitHub] [flink-connector-gcp-pubsub] MartijnVisser commented on pull request #1: [FLINK-30058][Connector/Google PubSub] Move existing Google Cloud PubSub connector code from Flink repo

2023-01-18 Thread GitBox
MartijnVisser commented on PR #1: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/1#issuecomment-1387391917 > I assume it's intentional to rename the `flink-connector-gcp-pubsub-emulator-tests` to `flink-connector-gcp-pubsub-e2e-tests`? It is, yes :) -- This is an

  1   2   3   4   >