[jira] [Updated] (FLINK-31436) Remove schemaId from constructor of FileStoreCommitImpl and ManifestFile in Table Store

2023-03-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31436: --- Labels: pull-request-available (was: ) > Remove schemaId from constructor of

[jira] [Commented] (FLINK-31437) 'lookup.cache.caching-missing-key' change should be configured as 'lookup.partial-cache.caching-missing-key'

2023-03-13 Thread Zhimin Geng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699962#comment-17699962 ] Zhimin Geng commented on FLINK-31437: - ok > 'lookup.cache.caching-missing-key' change should be

[GitHub] [flink-table-store] tsreaper opened a new pull request, #598: [FLINK-31436] Remove schemaId from constructor of FileStoreCommitImpl and ManifestFile in Table Store

2023-03-13 Thread via GitHub
tsreaper opened a new pull request, #598: URL: https://github.com/apache/flink-table-store/pull/598 As schema may change during a CTAS streaming job, the schema ID of snapshots and manifest files may also change. We should remove `schemaId` from their constructor and calculate the real

[jira] [Commented] (FLINK-31437) 'lookup.cache.caching-missing-key' change should be configured as 'lookup.partial-cache.caching-missing-key'

2023-03-13 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699960#comment-17699960 ] Junrui Li commented on FLINK-31437: --- [~gaara] Thanks for creating this issue, and

[jira] [Updated] (FLINK-31436) Remove schemaId from constructor of FileStoreCommitImpl and ManifestFile in Table Store

2023-03-13 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-31436: Summary: Remove schemaId from constructor of FileStoreCommitImpl and ManifestFile in Table Store

[jira] [Created] (FLINK-31437) 'lookup.cache.caching-missing-key' change should be configured as 'lookup.partial-cache.caching-missing-key'

2023-03-13 Thread Zhimin Geng (Jira)
Zhimin Geng created FLINK-31437: --- Summary: 'lookup.cache.caching-missing-key' change should be configured as 'lookup.partial-cache.caching-missing-key' Key: FLINK-31437 URL:

[GitHub] [flink] liuyongvs commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-13 Thread via GitHub
liuyongvs commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1135000970 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,137 @@ Stream

[GitHub] [flink] liuyongvs commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-13 Thread via GitHub
liuyongvs commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1135001220 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,137 @@ Stream

[jira] [Commented] (FLINK-30863) Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-13 Thread jinghaihang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699956#comment-17699956 ] jinghaihang commented on FLINK-30863: - More to the point, I'm also confused about whether it's

[jira] [Created] (FLINK-31436) Remove schemaId from constructor of Snapshot and ManifestFile in Table Store

2023-03-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-31436: --- Summary: Remove schemaId from constructor of Snapshot and ManifestFile in Table Store Key: FLINK-31436 URL: https://issues.apache.org/jira/browse/FLINK-31436 Project:

[GitHub] [flink] liuyongvs commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-13 Thread via GitHub
liuyongvs commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1134999542 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayRemoveFunction.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to

[jira] [Comment Edited] (FLINK-31144) Slow scheduling on large-scale batch jobs

2023-03-13 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699955#comment-17699955 ] Zhu Zhu edited comment on FLINK-31144 at 3/14/23 5:41 AM: -- IIRC, the

[jira] [Commented] (FLINK-31144) Slow scheduling on large-scale batch jobs

2023-03-13 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699955#comment-17699955 ] Zhu Zhu commented on FLINK-31144: - IIRC, the parallelism of that benchmark job is 4000, which is

[GitHub] [flink] swuferhong commented on a diff in pull request #22049: [FLINK-31273][table-planner] Fix left join with IS_NULL filter be wrongly pushed down and get wrong join results

2023-03-13 Thread via GitHub
swuferhong commented on code in PR #22049: URL: https://github.com/apache/flink/pull/22049#discussion_r1134947973 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java: ## @@ -386,6 +387,21 @@ private void

[jira] [Closed] (FLINK-30748) Translate "Overview" page of "Querys" into Chinese

2023-03-13 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-30748. --- Fix Version/s: 1.18.0 Assignee: chenhaiyang Resolution: Fixed Fixed in master:

[GitHub] [flink] wuchong merged pull request #21726: [FLINK-30748][docs]Translate "Overview" page of "Querys" into Chinese

2023-03-13 Thread via GitHub
wuchong merged PR #21726: URL: https://github.com/apache/flink/pull/21726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-30694) Translate "Windowing TVF" page of "Querys" into Chinese

2023-03-13 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-30694. --- Fix Version/s: 1.18.0 (was: 1.16.2) Resolution: Fixed Fixed in master:

[GitHub] [flink] wuchong merged pull request #21823: [FLINK-30694][docs]Translate "Windowing TVF" page of "Querys" into Ch…

2023-03-13 Thread via GitHub
wuchong merged PR #21823: URL: https://github.com/apache/flink/pull/21823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] WencongLiu commented on pull request #21645: [FLINK-30556] Improve the logic for enumerating splits for Hive source to avoid potential OOM

2023-03-13 Thread via GitHub
WencongLiu commented on PR #21645: URL: https://github.com/apache/flink/pull/21645#issuecomment-1467302863 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-26051) one sql has row_number =1 and the subsequent SQL has "case when" and "where" statement result Exception : The window can only be ordered in ASCENDING mode

2023-03-13 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699929#comment-17699929 ] Jane Chan commented on FLINK-26051: --- [~KristoffSC], Sorry for the late reply. Feel free to go ahead.

[jira] [Commented] (FLINK-31418) SortMergeResultPartitionReadSchedulerTest.testRequestBufferTimeout failed on CI

2023-03-13 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699930#comment-17699930 ] Yuxin Tan commented on FLINK-31418: --- I have created a PR for master and 1.17, could you help take a

[GitHub] [flink] godfreyhe commented on a diff in pull request #22049: [FLINK-31273][table-planner] Fix left join with IS_NULL filter be wrongly pushed down and get wrong join results

2023-03-13 Thread via GitHub
godfreyhe commented on code in PR #22049: URL: https://github.com/apache/flink/pull/22049#discussion_r1134883506 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java: ## @@ -386,6 +387,21 @@ private void

[jira] [Commented] (FLINK-31414) exceptions in the alignment timer are ignored

2023-03-13 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699928#comment-17699928 ] Feifan Wang commented on FLINK-31414: - Thanks for reply [~pnowojski] , sorry for the lack of clarity

[GitHub] [flink-table-store] zhuangchong opened a new pull request, #597: [hotfix] Change the variable name `sekableInputStream` to `seekableInputStream`

2023-03-13 Thread via GitHub
zhuangchong opened a new pull request, #597: URL: https://github.com/apache/flink-table-store/pull/597 Change the variable name `sekableInputStream` to `seekableInputStream` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Assigned] (FLINK-31418) SortMergeResultPartitionReadSchedulerTest.testRequestBufferTimeout failed on CI

2023-03-13 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao reassigned FLINK-31418: --- Assignee: Yuxin Tan > SortMergeResultPartitionReadSchedulerTest.testRequestBufferTimeout

[jira] [Commented] (FLINK-31425) Support submitting a job with streamgraph

2023-03-13 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699925#comment-17699925 ] Junrui Li commented on FLINK-31425: --- [~tophei] Thanks for creating this issue. IIUC, according to the

[GitHub] [flink-table-store] JingsongLi merged pull request #594: [core] Introduce LookupMergeFunction and ForceUpLevel0Compaction

2023-03-13 Thread via GitHub
JingsongLi merged PR #594: URL: https://github.com/apache/flink-table-store/pull/594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-31397) Introduce write-once hash lookup store

2023-03-13 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31397. Resolution: Fixed master: 0f5744a92bc52f52bc0f6644dc063dcb60fe326c > Introduce write-once hash

[jira] [Comment Edited] (FLINK-30863) Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-13 Thread jinghaihang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699920#comment-17699920 ] jinghaihang edited comment on FLINK-30863 at 3/14/23 3:16 AM: -- [~Yanfei

[jira] [Commented] (FLINK-30863) Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-13 Thread jinghaihang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699920#comment-17699920 ] jinghaihang commented on FLINK-30863: - [~Yanfei Lei]  Thanks for your reply. I don't think the

[GitHub] [flink-table-store] JingsongLi merged pull request #593: [FLINK-31397] Introduce write-once hash lookup store

2023-03-13 Thread via GitHub
JingsongLi merged PR #593: URL: https://github.com/apache/flink-table-store/pull/593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-31435) Introduce event parser for MySql Debezium JSON format in Table Store

2023-03-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-31435: --- Summary: Introduce event parser for MySql Debezium JSON format in Table Store Key: FLINK-31435 URL: https://issues.apache.org/jira/browse/FLINK-31435 Project: Flink

[jira] [Created] (FLINK-31434) Introduce CDC sink for Table Store

2023-03-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-31434: --- Summary: Introduce CDC sink for Table Store Key: FLINK-31434 URL: https://issues.apache.org/jira/browse/FLINK-31434 Project: Flink Issue Type: Sub-task

[GitHub] [flink] flinkbot commented on pull request #22173: [FLINK-31418][network][tests] Fix buffer request timeout for sort merge result partition test

2023-03-13 Thread via GitHub
flinkbot commented on PR #22173: URL: https://github.com/apache/flink/pull/22173#issuecomment-1467279898 ## CI report: * 9cff66bb2cf991967633d0b3aa88377224085b9f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-31433) Make SchemaChange serializable

2023-03-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-31433: --- Summary: Make SchemaChange serializable Key: FLINK-31433 URL: https://issues.apache.org/jira/browse/FLINK-31433 Project: Flink Issue Type: Sub-task

[GitHub] [flink-connector-pulsar] syhily commented on pull request #35: [FLINK-31427][Table] Initial Catalog implementation with a new config model and schema conversion.

2023-03-13 Thread via GitHub
syhily commented on PR #35: URL: https://github.com/apache/flink-connector-pulsar/pull/35#issuecomment-1467278411 @reswqa Can you help me review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (FLINK-31432) Introduce a special StoreWriteOperator to deal with schema changes

2023-03-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-31432: --- Summary: Introduce a special StoreWriteOperator to deal with schema changes Key: FLINK-31432 URL: https://issues.apache.org/jira/browse/FLINK-31432 Project: Flink

[GitHub] [flink] TanYuxin-tyx opened a new pull request, #22173: [FLINK-31418][network][tests] Fix buffer request timeout for sort merge result partition test

2023-03-13 Thread via GitHub
TanYuxin-tyx opened a new pull request, #22173: URL: https://github.com/apache/flink/pull/22173 ## What is the purpose of the change *Fix buffer request timeout for sort merge result partition read test* ## Brief change log *(for example:)* - *Fix buffer

[jira] [Assigned] (FLINK-31427) Pulsar Catalog support with Schema translation

2023-03-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31427: -- Assignee: Yufan Sheng > Pulsar Catalog support with Schema translation >

[jira] [Created] (FLINK-31431) Support copying a FileStoreTable with latest schema

2023-03-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-31431: --- Summary: Support copying a FileStoreTable with latest schema Key: FLINK-31431 URL: https://issues.apache.org/jira/browse/FLINK-31431 Project: Flink Issue

[GitHub] [flink] flinkbot commented on pull request #22172: [FLINK-31418][network][tests] Fix buffer request timeout for sort merge result partition read test

2023-03-13 Thread via GitHub
flinkbot commented on PR #22172: URL: https://github.com/apache/flink/pull/22172#issuecomment-1467272865 ## CI report: * 4438179c6b2181fcaec452f16a52a2b9033dc706 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-31430) Support migrating states between different instances of TableWriteImpl and AbstractFileStoreWrite

2023-03-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-31430: --- Summary: Support migrating states between different instances of TableWriteImpl and AbstractFileStoreWrite Key: FLINK-31430 URL: https://issues.apache.org/jira/browse/FLINK-31430

[jira] [Created] (FLINK-31429) Support CTAS(create table as) streaming job with schema changes in table store

2023-03-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-31429: --- Summary: Support CTAS(create table as) streaming job with schema changes in table store Key: FLINK-31429 URL: https://issues.apache.org/jira/browse/FLINK-31429

[jira] [Updated] (FLINK-31418) SortMergeResultPartitionReadSchedulerTest.testRequestBufferTimeout failed on CI

2023-03-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31418: --- Labels: pull-request-available (was: ) >

[GitHub] [flink] TanYuxin-tyx opened a new pull request, #22172: [FLINK-31418][network][tests] Fix buffer request timeout for sort merge result partition read test

2023-03-13 Thread via GitHub
TanYuxin-tyx opened a new pull request, #22172: URL: https://github.com/apache/flink/pull/22172 ## What is the purpose of the change *Fix buffer request timeout for sort merge result partition read test* ## Brief change log *(for example:)* - *Fix buffer

[jira] [Closed] (FLINK-31269) Split hive connector to each module of each version

2023-03-13 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-31269. --- Assignee: Shammon Resolution: Fixed master: dd2d600f6743ca074a023fdbb1a7a2cbcfbf8ff0 > Split

[jira] [Commented] (FLINK-31418) SortMergeResultPartitionReadSchedulerTest.testRequestBufferTimeout failed on CI

2023-03-13 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699913#comment-17699913 ] Yingjie Cao commented on FLINK-31418: - It is a test issue, we will fix it soon. >

[GitHub] [flink-table-store] tsreaper merged pull request #569: [FLINK-31269] Split hive connector to each module of each version

2023-03-13 Thread via GitHub
tsreaper merged PR #569: URL: https://github.com/apache/flink-table-store/pull/569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31418) SortMergeResultPartitionReadSchedulerTest.testRequestBufferTimeout failed on CI

2023-03-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699911#comment-17699911 ] Qingsheng Ren commented on FLINK-31418: --- Thanks for the feedback [~kevin.cyj]. I'll downgrade this

[jira] [Updated] (FLINK-31418) SortMergeResultPartitionReadSchedulerTest.testRequestBufferTimeout failed on CI

2023-03-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren updated FLINK-31418: -- Priority: Critical (was: Blocker) >

[GitHub] [flink] wuchong commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

2023-03-13 Thread via GitHub
wuchong commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134831904 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java: ## @@ -763,7 +783,7 @@ CatalogBaseTable

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

2023-03-13 Thread via GitHub
Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134809157 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java: ## @@ -157,12 +165,12 @@ public static Operation

[jira] [Commented] (FLINK-31428) Add user callbacks to PulsarSource and PulsarSink

2023-03-13 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699901#comment-17699901 ] Yufan Sheng commented on FLINK-31428: - I see, the ser/deser issue matters. You want to intercept

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

2023-03-13 Thread via GitHub
Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1134803012 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java: ## @@ -69,67 +69,75 @@ private

[jira] [Assigned] (FLINK-31413) Remove provided dependency of flink-table-planner from Hive connector

2023-03-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-31413: Assignee: luoyuxia > Remove provided dependency of flink-table-planner from Hive connector >

[jira] [Assigned] (FLINK-30659) drop flink-sql-parser-hive

2023-03-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-30659: Assignee: luoyuxia > drop flink-sql-parser-hive > --- > >

[jira] [Assigned] (FLINK-31409) Hive dialect should use public interfaces in Hive connector

2023-03-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-31409: Assignee: luoyuxia > Hive dialect should use public interfaces in Hive connector >

[jira] [Assigned] (FLINK-17398) Filesystem support flexible path reading

2023-03-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-17398: Assignee: Hang Ruan (was: luoyuxia) > Filesystem support flexible path reading >

[GitHub] [flink] swuferhong commented on a diff in pull request #22049: [FLINK-31273][table-planner] Fix left join with IS_NULL filter be wrongly pushed down and get wrong join results

2023-03-13 Thread via GitHub
swuferhong commented on code in PR #22049: URL: https://github.com/apache/flink/pull/22049#discussion_r1134791918 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java: ## @@ -386,6 +387,21 @@ private void

[jira] [Closed] (FLINK-31415) Support target alias and using ddls to create source

2023-03-13 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31415. Fix Version/s: table-store-0.4.0 Assignee: yuzelin Resolution: Fixed master:

[GitHub] [flink-table-store] JingsongLi merged pull request #596: [FLINK-31415] Support target alias and using ddls to create source

2023-03-13 Thread via GitHub
JingsongLi merged PR #596: URL: https://github.com/apache/flink-table-store/pull/596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31371) Stream failure if the topic doesn't exist

2023-03-13 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699896#comment-17699896 ] Yufan Sheng commented on FLINK-31371: - Can we change this JIRA into a feature request with a new

[GitHub] [flink] herunkang2018 commented on a diff in pull request #22049: [FLINK-31273][table-planner] Fix left join with IS_NULL filter be wrongly pushed down and get wrong join results

2023-03-13 Thread via GitHub
herunkang2018 commented on code in PR #22049: URL: https://github.com/apache/flink/pull/22049#discussion_r1134786876 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java: ## @@ -386,6 +387,21 @@ private void

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #594: [core] Introduce LookupMergeFunction and ForceUpLevel0Compaction

2023-03-13 Thread via GitHub
JingsongLi commented on code in PR #594: URL: https://github.com/apache/flink-table-store/pull/594#discussion_r1134786122 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/aggregate/AggregateMergeFunction.java: ## @@ -172,10 +133,30 @@

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #594: [core] Introduce LookupMergeFunction and ForceUpLevel0Compaction

2023-03-13 Thread via GitHub
JingsongLi commented on code in PR #594: URL: https://github.com/apache/flink-table-store/pull/594#discussion_r1134784531 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/ForceUpLevel0Compaction.java: ## @@ -0,0 +1,59 @@ +/* + *

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

2023-03-13 Thread via GitHub
JingsongLi commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134777880 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/hash/HashLookupStoreWriter.java: ## @@ -0,0 +1,486 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

2023-03-13 Thread via GitHub
JingsongLi commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134777430 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/hash/HashLookupStoreWriter.java: ## @@ -0,0 +1,486 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

2023-03-13 Thread via GitHub
JingsongLi commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134775901 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/hash/HashLookupStoreWriter.java: ## @@ -0,0 +1,486 @@ +/* + * Licensed to the

[GitHub] [flink] liujiawinds commented on pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

2023-03-13 Thread via GitHub
liujiawinds commented on PR #19844: URL: https://github.com/apache/flink/pull/19844#issuecomment-1467197335 @pgaref Feel free to take over this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-ml] lindong28 commented on pull request #224: univariatefeatureselector.md:101:1": failed to extract shortcode: sho…

2023-03-13 Thread via GitHub
lindong28 commented on PR #224: URL: https://github.com/apache/flink-ml/pull/224#issuecomment-1467184153 @alberta0714 Thanks for creating this PR. Could you explain how to reproduce the error "failed to extract shortcode"? We can add a test to catch issues like this in the future if we can

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

2023-03-13 Thread via GitHub
SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134714232 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/utils/SimpleReadBuffer.java: ## @@ -0,0 +1,43 @@ +/* + * Copyright 2015 LinkedIn

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

2023-03-13 Thread via GitHub
SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134713621 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/hash/HashLookupStoreWriter.java: ## @@ -0,0 +1,486 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

2023-03-13 Thread via GitHub
SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134711088 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/hash/HashLookupStoreWriter.java: ## @@ -0,0 +1,486 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

2023-03-13 Thread via GitHub
SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134708812 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/hash/HashLookupStoreWriter.java: ## @@ -0,0 +1,486 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

2023-03-13 Thread via GitHub
SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134702880 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/LookupStoreReader.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #593: [FLINK-31397] Introduce write-once hash lookup store

2023-03-13 Thread via GitHub
SteNicholas commented on code in PR #593: URL: https://github.com/apache/flink-table-store/pull/593#discussion_r1134703041 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/lookup/LookupStoreWriter.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #594: [core] Introduce LookupMergeFunction and ForceUpLevel0Compaction

2023-03-13 Thread via GitHub
SteNicholas commented on code in PR #594: URL: https://github.com/apache/flink-table-store/pull/594#discussion_r1134698287 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/aggregate/AggregateMergeFunction.java: ## @@ -172,10 +133,30 @@

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #594: [core] Introduce LookupMergeFunction and ForceUpLevel0Compaction

2023-03-13 Thread via GitHub
SteNicholas commented on code in PR #594: URL: https://github.com/apache/flink-table-store/pull/594#discussion_r1134693522 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/LookupMergeFunction.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #594: [core] Introduce LookupMergeFunction and ForceUpLevel0Compaction

2023-03-13 Thread via GitHub
SteNicholas commented on code in PR #594: URL: https://github.com/apache/flink-table-store/pull/594#discussion_r1134691216 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/LookupChangelogMergeFunctionWrapper.java: ## @@ -0,0 +1,142 @@

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #594: [core] Introduce LookupMergeFunction and ForceUpLevel0Compaction

2023-03-13 Thread via GitHub
SteNicholas commented on code in PR #594: URL: https://github.com/apache/flink-table-store/pull/594#discussion_r1134689986 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/ForceUpLevel0Compaction.java: ## @@ -0,0 +1,59 @@ +/* + *

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #594: [core] Introduce LookupMergeFunction and ForceUpLevel0Compaction

2023-03-13 Thread via GitHub
SteNicholas commented on code in PR #594: URL: https://github.com/apache/flink-table-store/pull/594#discussion_r1134689986 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/ForceUpLevel0Compaction.java: ## @@ -0,0 +1,59 @@ +/* + *

[jira] [Commented] (FLINK-31369) Harden modifiers for sql-gateway module

2023-03-13 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699863#comment-17699863 ] Sergey Nuyanzin commented on FLINK-31369: - Merged at:

[jira] [Resolved] (FLINK-31369) Harden modifiers for sql-gateway module

2023-03-13 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-31369. - Fix Version/s: 1.18.0 Resolution: Fixed > Harden modifiers for sql-gateway

[GitHub] [flink] snuyanzin merged pull request #22135: [FLINK-31369][sql-gateway] Harden modifiers in tests for sql-gateway module

2023-03-13 Thread via GitHub
snuyanzin merged PR #22135: URL: https://github.com/apache/flink/pull/22135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-31369) Harden modifiers for sql-gateway module

2023-03-13 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-31369: --- Assignee: Sergey Nuyanzin > Harden modifiers for sql-gateway module >

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

2023-03-13 Thread via GitHub
mbalassi commented on code in PR #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548#discussion_r1134642722 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClient.java: ## @@ -57,14

[jira] [Updated] (FLINK-31407) Upgrade Fabric8 version to 6.5.0

2023-03-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31407: --- Labels: pull-request-available (was: ) > Upgrade Fabric8 version to 6.5.0 >

[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request, #548: [FLINK-31407] Bump fabric8 version to 6.5.0

2023-03-13 Thread via GitHub
mbalassi opened a new pull request, #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548 This new version brings critical stability fixes for the informers. I fixed the newly introduced deprecation warnings. -- This is an automated message from the Apache Git Service.

[GitHub] [flink] pgaref commented on pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

2023-03-13 Thread via GitHub
pgaref commented on PR #19844: URL: https://github.com/apache/flink/pull/19844#issuecomment-1466980765 @liujiawinds are you still working on this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-13 Thread via GitHub
snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1134628496 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,137 @@ Stream

[jira] [Updated] (FLINK-31428) Add user callbacks to PulsarSource and PulsarSink

2023-03-13 Thread Alpha Diallo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alpha Diallo updated FLINK-31428: - Description: We'd like to add support for user callbacks in {{PulsarSource}} and

[jira] [Created] (FLINK-31428) Add user callbacks to PulsarSource and PulsarSink

2023-03-13 Thread Alpha Diallo (Jira)
Alpha Diallo created FLINK-31428: Summary: Add user callbacks to PulsarSource and PulsarSink Key: FLINK-31428 URL: https://issues.apache.org/jira/browse/FLINK-31428 Project: Flink Issue

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-13 Thread via GitHub
snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1134622026 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayRemoveFunction.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to

[GitHub] [flink] pgaref commented on a diff in pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

2023-03-13 Thread via GitHub
pgaref commented on code in PR #22153: URL: https://github.com/apache/flink/pull/22153#discussion_r1134608280 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobResourceRequirements.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] pgaref commented on a diff in pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

2023-03-13 Thread via GitHub
pgaref commented on code in PR #22153: URL: https://github.com/apache/flink/pull/22153#discussion_r1134606959 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobResourceRequirements.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] pgaref commented on a diff in pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

2023-03-13 Thread via GitHub
pgaref commented on code in PR #22153: URL: https://github.com/apache/flink/pull/22153#discussion_r1134587834 ## flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java: ## @@ -466,6 +468,7 @@ public static String checkForInstantiationError(Class clazz) {

[jira] [Commented] (FLINK-31371) Stream failure if the topic doesn't exist

2023-03-13 Thread Enzo Dechaene (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699824#comment-17699824 ] Enzo Dechaene commented on FLINK-31371: --- Hi [~syhily], yes, it makes sense to do it that way

[jira] [Updated] (FLINK-31427) Pulsar Catalog support with Schema translation

2023-03-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31427: --- Labels: pull-request-available (was: ) > Pulsar Catalog support with Schema translation >

[GitHub] [flink-connector-pulsar] syhily opened a new pull request, #35: [FLINK-31427][Table] Initial Catalog implementation with a new config model and schema conversion.

2023-03-13 Thread via GitHub
syhily opened a new pull request, #35: URL: https://github.com/apache/flink-connector-pulsar/pull/35 ## Purpose of the change This PR will make the Pulsar serve as the Flink catalog backend. It will expose the Pulsar's namespace as the Flink's database, the Pulsar's topic as the

[jira] [Commented] (FLINK-31414) exceptions in the alignment timer are ignored

2023-03-13 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699776#comment-17699776 ] Piotr Nowojski commented on FLINK-31414: [~Feifan Wang], can you elaborate a bit more what's the

  1   2   3   >