[jira] [Commented] (FLINK-31835) DataTypeHint don't support Row>

2023-04-25 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716538#comment-17716538 ] Aitozi commented on FLINK-31835: [~jark] The PR have passed the CI and I think the current solution will

[GitHub] [flink] Aitozi commented on a diff in pull request #22485: [FLINK-31835][planner] Fix the array type can't be converted from ext…

2023-04-25 Thread via GitHub
Aitozi commented on code in PR #22485: URL: https://github.com/apache/flink/pull/22485#discussion_r1177360955 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/table/ValuesITCase.java: ## @@ -332,7 +332,23 @@ public void

[jira] [Comment Edited] (FLINK-30644) ChangelogCompatibilityITCase.testRestore fails due to CheckpointCoordinator being shutdown

2023-04-25 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716514#comment-17716514 ] Yanfei Lei edited comment on FLINK-30644 at 4/26/23 3:50 AM: -

[jira] [Commented] (FLINK-30644) ChangelogCompatibilityITCase.testRestore fails due to CheckpointCoordinator being shutdown

2023-04-25 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716514#comment-17716514 ] Yanfei Lei commented on FLINK-30644:

[jira] [Commented] (FLINK-31929) HighAvailabilityServicesUtils.getWebMonitorAddress works not properly in k8s with IPv6 stack

2023-04-25 Thread caiyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716511#comment-17716511 ] caiyi commented on FLINK-31929: --- Ok, I'll make a pull request to resolve it. >

[jira] [Commented] (FLINK-31928) flink-kubernetes works not properly in k8s with IPv6 stack

2023-04-25 Thread caiyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716509#comment-17716509 ] caiyi commented on FLINK-31928: --- Ok, I'll upgrade okhttp3 to latest 4.11.0. > flink-kubernetes works not

[GitHub] [flink] fredia commented on pull request #22445: [FLINK-31876][QS] Migrate flink-queryable-state-client tests to JUnit5

2023-04-25 Thread via GitHub
fredia commented on PR #22445: URL: https://github.com/apache/flink/pull/22445#issuecomment-1522731230 @reswqa Thanks for the detailed review, fixed as suggested, please help take a look again. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] reswqa commented on a diff in pull request #22445: [FLINK-31876][QS] Migrate flink-queryable-state-client tests to JUnit5

2023-04-25 Thread via GitHub
reswqa commented on code in PR #22445: URL: https://github.com/apache/flink/pull/22445#discussion_r1177297848 ## flink-queryable-state/flink-queryable-state-client-java/src/test/java/org/apache/flink/queryablestate/client/state/ImmutableListStateTest.java: ## @@ -56,26 +57,23

[jira] (FLINK-27018) timestamp missing end zero when outputing to kafka

2023-04-25 Thread jeff-zou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27018 ] jeff-zou deleted comment on FLINK-27018: -- was (Author: JIRAUSER282259): [~paul8263]  ok, thx, but I don't know how to assigne this issue to you. [~fpaul]  Can you do this? > timestamp missing

[GitHub] [flink] pgaref commented on a diff in pull request #22467: [FLINK-31888] Introduce interfaces and utils for loading and executing enrichers

2023-04-25 Thread via GitHub
pgaref commented on code in PR #22467: URL: https://github.com/apache/flink/pull/22467#discussion_r1177288100 ## flink-tests/src/test/java/org/apache/flink/test/plugin/FailureEnricherPluginTest.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] huwh commented on pull request #22438: [FLINK-31632] Add method setMaxParallelism to DataStreamSink.

2023-04-25 Thread via GitHub
huwh commented on PR #22438: URL: https://github.com/apache/flink/pull/22438#issuecomment-1522698089 Oh, I notice that the jira id in PR title and commit message is wrong, it should be [FLINK-31873](https://issues.apache.org/jira/browse/FLINK-31873) And I think we don't need

[GitHub] [flink] huwh commented on a diff in pull request #22438: [FLINK-31632] Add method setMaxParallelism to DataStreamSink.

2023-04-25 Thread via GitHub
huwh commented on code in PR #22438: URL: https://github.com/apache/flink/pull/22438#discussion_r1177277341 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -283,6 +283,25 @@ public void

[jira] [Commented] (FLINK-31898) Flink k8s autoscaler does not work as expected

2023-04-25 Thread Kyungmin Kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716490#comment-17716490 ] Kyungmin Kim commented on FLINK-31898: -- [~gyfora]  After watching more metrics, I found out that

[jira] [Created] (FLINK-31943) Multiple t_env cause class loading problem

2023-04-25 Thread Xuannan Su (Jira)
Xuannan Su created FLINK-31943: -- Summary: Multiple t_env cause class loading problem Key: FLINK-31943 URL: https://issues.apache.org/jira/browse/FLINK-31943 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-31135) ConfigMap DataSize went > 1 MB and cluster stopped working

2023-04-25 Thread Zhihao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716479#comment-17716479 ] Zhihao Chen commented on FLINK-31135: - Hi [~Swathi Chandrashekar], can I ask do we have any update

[GitHub] [flink] pgaref commented on pull request #22481: [FLINK-27805] bump orc version to 1.7.8

2023-04-25 Thread via GitHub
pgaref commented on PR #22481: URL: https://github.com/apache/flink/pull/22481#issuecomment-1522510048 Aslo cc @pnowojski / @akalash that might be interested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-connector-kafka] mas-chen opened a new pull request, #24: [FLINK-30859] Sync kafka related examples from apache/flink:master

2023-04-25 Thread via GitHub
mas-chen opened a new pull request, #24: URL: https://github.com/apache/flink-connector-kafka/pull/24 There is only one example related to Kafka -- StateMachineExample. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Created] (FLINK-31942) Support Conditional Writes in DynamoDB connector

2023-04-25 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-31942: --- Summary: Support Conditional Writes in DynamoDB connector Key: FLINK-31942 URL: https://issues.apache.org/jira/browse/FLINK-31942 Project: Flink Issue

[GitHub] [flink] flinkbot commented on pull request #22487: [FLINK-31940] DataStreamCsvITCase#CityPojo serialized as POJO

2023-04-25 Thread via GitHub
flinkbot commented on PR #22487: URL: https://github.com/apache/flink/pull/22487#issuecomment-1522417242 ## CI report: * c2135fded05d90ae67526d98903ed25793d6bc57 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31940) DataStreamCsvITCase#CityPojo should be public

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31940: --- Labels: pull-request-available (was: ) > DataStreamCsvITCase#CityPojo should be public >

[GitHub] [flink] zentol opened a new pull request, #22487: [FLINK-31940] DataStreamCsvITCase#CityPojo serialized as POJO

2023-04-25 Thread via GitHub
zentol opened a new pull request, #22487: URL: https://github.com/apache/flink/pull/22487 POJO classes should be public. This currently causes Kryo to be used for the entire pojo, requiring additional --add-opens on Java 17. -- This is an automated message from the Apache Git

[jira] [Created] (FLINK-31941) Not backwards compatible naming for some kubernetes resources

2023-04-25 Thread Eric Xiao (Jira)
Eric Xiao created FLINK-31941: - Summary: Not backwards compatible naming for some kubernetes resources Key: FLINK-31941 URL: https://issues.apache.org/jira/browse/FLINK-31941 Project: Flink

[GitHub] [flink-connector-aws] Samrat002 commented on pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-04-25 Thread via GitHub
Samrat002 commented on PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#issuecomment-1522231643 @dannycranmer please review whenever time  . - Added UT for the change - Created seperate issue for adding e2e test for catalog . - Tried addressing to all review

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-04-25 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1176884725 ## flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/util/GlueOperator.java: ## @@ -0,0 +1,1639 @@ +/* + * Licensed to the Apache

[jira] [Created] (FLINK-31940) DataStreamCsvITCase#CityPojo should be public

2023-04-25 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-31940: Summary: DataStreamCsvITCase#CityPojo should be public Key: FLINK-31940 URL: https://issues.apache.org/jira/browse/FLINK-31940 Project: Flink Issue

[GitHub] [flink] ericxiao251 commented on pull request #22438: [FLINK-31632] Add method setMaxParallelism to DataStreamSink.

2023-04-25 Thread via GitHub
ericxiao251 commented on PR #22438: URL: https://github.com/apache/flink/pull/22438#issuecomment-1522095761 Ah right, done! Thanks for the reminder @MartijnVisser . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] dmvk commented on a diff in pull request #22467: [FLINK-31888] Introduce interfaces and utils for loading and executing enrichers

2023-04-25 Thread via GitHub
dmvk commented on code in PR #22467: URL: https://github.com/apache/flink/pull/22467#discussion_r1176348699 ## flink-tests/src/test/java/org/apache/flink/test/plugin/FailureEnricherPluginTest.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Created] (FLINK-31939) ClassNotFoundException on org.apache.beam.runners.flink.translation.wrappers.SourceInputFormat when running Flink 1.14 and up with Beam 2.46.0

2023-04-25 Thread AmitK (Jira)
AmitK created FLINK-31939: - Summary: ClassNotFoundException on org.apache.beam.runners.flink.translation.wrappers.SourceInputFormat when running Flink 1.14 and up with Beam 2.46.0 Key: FLINK-31939 URL:

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #49: [FLINK-24438] Add Kinesis connector using FLIP-27

2023-04-25 Thread via GitHub
darenwkt commented on code in PR #49: URL: https://github.com/apache/flink-connector-aws/pull/49#discussion_r1176766870 ## flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/examples/SourceFromKinesis.java: ## @@ -0,0 +1,55 @@ +/* + *

[GitHub] [flink] MartijnVisser commented on pull request #22438: Add method setMaxParallelism to DataStreamSink.

2023-04-25 Thread via GitHub
MartijnVisser commented on PR #22438: URL: https://github.com/apache/flink/pull/22438#issuecomment-1522085769 @ericxiao251 Could you change your commit messages to fit with https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/#4-commit-naming-conventions ? That

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #49: [FLINK-24438] Add Kinesis connector using FLIP-27

2023-04-25 Thread via GitHub
darenwkt commented on code in PR #49: URL: https://github.com/apache/flink-connector-aws/pull/49#discussion_r1176764441 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/PollingKinesisShardSplitReader.java: ## Review

[jira] [Assigned] (FLINK-31873) Add setMaxParallelism to the DataStreamSink Class

2023-04-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-31873: -- Assignee: Eric Xiao > Add setMaxParallelism to the DataStreamSink Class >

[GitHub] [flink-kubernetes-operator] chachae commented on pull request #351: [FLINK-28646] Handle scaling operation separately in reconciler/service

2023-04-25 Thread via GitHub
chachae commented on PR #351: URL: https://github.com/apache/flink-kubernetes-operator/pull/351#issuecomment-1522040383 > ## What is the purpose of the change > Enable reactive scaling for standalone deployments by detecting and handling spec changes that do not require full application

[jira] [Resolved] (FLINK-31937) Failing Unit Test: ClientTest.testClientServerIntegration "Connection leak"

2023-04-25 Thread Kurt Ostfeld (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Ostfeld resolved FLINK-31937. -- Resolution: Won't Fix [~martijnvisser] ah, ok, unit tests don't need to run outside of the CI

[jira] [Created] (FLINK-31938) Failing Unit Test: FlinkConnectionTest.testCatalogSchema "Failed to get response for the operation"

2023-04-25 Thread Kurt Ostfeld (Jira)
Kurt Ostfeld created FLINK-31938: Summary: Failing Unit Test: FlinkConnectionTest.testCatalogSchema "Failed to get response for the operation" Key: FLINK-31938 URL:

[jira] [Updated] (FLINK-31912) Upgrade bytebuddy to 14.4.1

2023-04-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-31912: - Summary: Upgrade bytebuddy to 14.4.1 (was: Upgrade bytebuddy) > Upgrade bytebuddy to

[jira] [Closed] (FLINK-31912) Upgrade bytebuddy

2023-04-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-31912. Resolution: Fixed master: 4d50f78cf99ebdf1c57d225ac26904abd8b4bc64 > Upgrade bytebuddy >

[GitHub] [flink] zentol merged pull request #22474: [FLINK-31912][build] Upgrade bytebuddy to 1.14.4

2023-04-25 Thread via GitHub
zentol merged PR #22474: URL: https://github.com/apache/flink/pull/22474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-04-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-31793. -- Fix Version/s: jdbc-3.2.0 Resolution: Fixed Fixed in main:

[GitHub] [flink-connector-jdbc] boring-cyborg[bot] commented on pull request #40: [FLINK-31793] remove dependency on flink-shaded guava for flink-connector-jdbc

2023-04-25 Thread via GitHub
boring-cyborg[bot] commented on PR #40: URL: https://github.com/apache/flink-connector-jdbc/pull/40#issuecomment-1521895137 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-connector-jdbc] MartijnVisser merged pull request #40: [FLINK-31793] remove dependency on flink-shaded guava for flink-connector-jdbc

2023-04-25 Thread via GitHub
MartijnVisser merged PR #40: URL: https://github.com/apache/flink-connector-jdbc/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31937) Failing Unit Test: ClientTest.testClientServerIntegration "Connection leak"

2023-04-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716290#comment-17716290 ] Martijn Visser commented on FLINK-31937: [~kurto] My initial thinking is that this is a local

[jira] [Created] (FLINK-31937) Failing Unit Test: ClientTest.testClientServerIntegration "Connection leak"

2023-04-25 Thread Kurt Ostfeld (Jira)
Kurt Ostfeld created FLINK-31937: Summary: Failing Unit Test: ClientTest.testClientServerIntegration "Connection leak" Key: FLINK-31937 URL: https://issues.apache.org/jira/browse/FLINK-31937 Project:

[GitHub] [flink] zentol commented on pull request #22484: [FLINK-31934][rocksdb][tests] Remove mocking

2023-04-25 Thread via GitHub
zentol commented on PR #22484: URL: https://github.com/apache/flink/pull/22484#issuecomment-1521829398 IIRC those mocks didnt cause issues on Java 17 so to me they are out of scope of this ticket. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Assigned] (FLINK-31936) Support setting scale up max factor

2023-04-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-31936: -- Assignee: Zhanghao Chen > Support setting scale up max factor >

[jira] [Commented] (FLINK-31936) Support setting scale up max factor

2023-04-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716271#comment-17716271 ] Gyula Fora commented on FLINK-31936: Thanks [~Zhanghao Chen] , I assign this to you :)  > Support

[GitHub] [flink] fredia commented on a diff in pull request #22457: [FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5

2023-04-25 Thread via GitHub
fredia commented on code in PR #22457: URL: https://github.com/apache/flink/pull/22457#discussion_r1176516288 ## flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java: ## @@ -257,33 +258,34 @@ public void

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #49: [FLINK-24438] Add Kinesis connector using FLIP-27

2023-04-25 Thread via GitHub
darenwkt commented on code in PR #49: URL: https://github.com/apache/flink-connector-aws/pull/49#discussion_r1176498371 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/config/SourceConfigConstants.java: ## @@ -0,0 +1,369 @@ +/* +

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #49: [FLINK-24438] Add Kinesis connector using FLIP-27

2023-04-25 Thread via GitHub
darenwkt commented on code in PR #49: URL: https://github.com/apache/flink-connector-aws/pull/49#discussion_r1176497702 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/config/SourceConfigConstants.java: ## @@ -0,0 +1,369 @@ +/* +

[GitHub] [flink] masteryhx commented on a diff in pull request #22457: [FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5

2023-04-25 Thread via GitHub
masteryhx commented on code in PR #22457: URL: https://github.com/apache/flink/pull/22457#discussion_r1176184618 ## flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java: ## @@ -128,9 +132,9

[GitHub] [flink] fredia commented on a diff in pull request #22445: [FLINK-31876][QS] Migrate flink-queryable-state-client tests to JUnit5

2023-04-25 Thread via GitHub
fredia commented on code in PR #22445: URL: https://github.com/apache/flink/pull/22445#discussion_r1176412964 ## flink-queryable-state/flink-queryable-state-client-java/src/test/java/org/apache/flink/queryablestate/client/state/ImmutableAggregatingStateTest.java: ## @@ -24,23

[jira] [Commented] (FLINK-31936) Support setting scale up max factor

2023-04-25 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716235#comment-17716235 ] Zhanghao Chen commented on FLINK-31936: --- Hi, [~gyfora], if you think this issue is worthful to do,

[jira] [Updated] (FLINK-31936) Support setting scale up max factor

2023-04-25 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-31936: -- Description: Currently, only scale down max factor is supported to be configured. We should

[jira] [Updated] (FLINK-31936) Support setting scale up max factor

2023-04-25 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-31936: -- Description: Currently, only scale down max factor is supported to be configured. We should

[jira] [Created] (FLINK-31936) Support setting scale up max factor

2023-04-25 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-31936: - Summary: Support setting scale up max factor Key: FLINK-31936 URL: https://issues.apache.org/jira/browse/FLINK-31936 Project: Flink Issue Type:

[jira] [Comment Edited] (FLINK-31560) Savepoint failing to complete with ExternallyInducedSources

2023-04-25 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716075#comment-17716075 ] Yanfei Lei edited comment on FLINK-31560 at 4/25/23 10:42 AM: -- [~fyang86]

[GitHub] [flink] reswqa commented on pull request #22432: [FLINK-18808][runtime] Include side outputs in numRecordsOut metric

2023-04-25 Thread via GitHub
reswqa commented on PR #22432: URL: https://github.com/apache/flink/pull/22432#issuecomment-1521565404 Thanks @pnowojski for the review! I have addressed your second comment this pr in the fix-up commit. As for the first comment, I need to hear your feedback. -- This is an automated

[jira] [Closed] (FLINK-31924) [Flink operator] Flink Autoscale - Limit the max number of scale ups

2023-04-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-31924. -- Resolution: Not A Bug Based on offline discussion the problem seems to be related to the job itself

[jira] [Commented] (FLINK-31835) DataTypeHint don't support Row>

2023-04-25 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716209#comment-17716209 ] Aitozi commented on FLINK-31835: Yes, the reason is shown above. I have pushed a PR to try to solve

[GitHub] [flink] flinkbot commented on pull request #22486: [FLINK-31935] Register handlers for resource requirements endpoints i…

2023-04-25 Thread via GitHub
flinkbot commented on PR #22486: URL: https://github.com/apache/flink/pull/22486#issuecomment-1521537079 ## CI report: * 797d6f45f1f0f1827b59711121ade62ec03d78b8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] dmvk commented on pull request #22486: [FLINK-31935] Register handlers for resource requirements endpoints i…

2023-04-25 Thread via GitHub
dmvk commented on PR #22486: URL: https://github.com/apache/flink/pull/22486#issuecomment-1521530533 cc @zentol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-31935) The new resource requirements REST API is only available for session clusters

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31935: --- Labels: pull-request-available (was: ) > The new resource requirements REST API is only

[GitHub] [flink] dmvk opened a new pull request, #22486: [FLINK-31935] Register handlers for resource requirements endpoints i…

2023-04-25 Thread via GitHub
dmvk opened a new pull request, #22486: URL: https://github.com/apache/flink/pull/22486 https://issues.apache.org/jira/browse/FLINK-31935 Register handlers for resource requirements endpoints in all deployment modes (session, application, per-job). -- This is an automated message

[GitHub] [flink-connector-jdbc] WencongLiu commented on a diff in pull request #40: [FLINK-31793] remove dependency on flink-shaded guava for flink-connector-jdbc

2023-04-25 Thread via GitHub
WencongLiu commented on code in PR #40: URL: https://github.com/apache/flink-connector-jdbc/pull/40#discussion_r1176297094 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcTypeUtil.java: ## @@ -26,7 +26,7 @@ import

[jira] [Commented] (FLINK-31935) The new resource requirements REST API is only available for session clusters

2023-04-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716203#comment-17716203 ] Chesnay Schepler commented on FLINK-31935: -- Whoops; just need to move them up into the

[GitHub] [flink] MartijnVisser commented on pull request #22481: [FLINK-27805] bump orc version to 1.7.8

2023-04-25 Thread via GitHub
MartijnVisser commented on PR #22481: URL: https://github.com/apache/flink/pull/22481#issuecomment-1521507651 @lirui-apache @JingsongLi Does one of you want to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] reswqa commented on a diff in pull request #22445: [FLINK-31876][QS] Migrate flink-queryable-state-client tests to JUnit5

2023-04-25 Thread via GitHub
reswqa commented on code in PR #22445: URL: https://github.com/apache/flink/pull/22445#discussion_r1176281072 ## flink-queryable-state/flink-queryable-state-client-java/src/test/java/org/apache/flink/queryablestate/client/state/ImmutableAggregatingStateTest.java: ## @@ -24,23

[jira] [Commented] (FLINK-31930) MetricQueryService works not properly in k8s with IPv6 stack

2023-04-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716202#comment-17716202 ] Martijn Visser commented on FLINK-31930: [~caiyi] Do you want to open a PR to resolve this? >

[jira] [Commented] (FLINK-31928) flink-kubernetes works not properly in k8s with IPv6 stack

2023-04-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716201#comment-17716201 ] Martijn Visser commented on FLINK-31928: [~caiyi] Do you want to open a PR to update okhttp3?

[jira] [Updated] (FLINK-31928) flink-kubernetes works not properly in k8s with IPv6 stack

2023-04-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31928: --- Component/s: (was: Kubernetes Operator) > flink-kubernetes works not properly in k8s

[GitHub] [flink] zoltar9264 commented on pull request #22458: [FLINK-31743][statebackend/rocksdb] disable rocksdb log relocating wh…

2023-04-25 Thread via GitHub
zoltar9264 commented on PR #22458: URL: https://github.com/apache/flink/pull/22458#issuecomment-1521503517 Thanks @masteryhx for help review the pr, I have updated the code as your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (FLINK-31929) HighAvailabilityServicesUtils.getWebMonitorAddress works not properly in k8s with IPv6 stack

2023-04-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716199#comment-17716199 ] Martijn Visser commented on FLINK-31929: It's probably worthwhile to look if you can use a

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22458: [FLINK-31743][statebackend/rocksdb] disable rocksdb log relocating wh…

2023-04-25 Thread via GitHub
zoltar9264 commented on code in PR #22458: URL: https://github.com/apache/flink/pull/22458#discussion_r1176280348 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBResourceContainer.java: ## @@ -59,6 +59,9 @@

[jira] [Updated] (FLINK-31928) flink-kubernetes works not properly in k8s with IPv6 stack

2023-04-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31928: --- Priority: Major (was: Blocker) > flink-kubernetes works not properly in k8s with IPv6

[jira] [Updated] (FLINK-31929) HighAvailabilityServicesUtils.getWebMonitorAddress works not properly in k8s with IPv6 stack

2023-04-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31929: --- Priority: Major (was: Blocker) > HighAvailabilityServicesUtils.getWebMonitorAddress works

[jira] [Updated] (FLINK-31930) MetricQueryService works not properly in k8s with IPv6 stack

2023-04-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31930: --- Priority: Major (was: Blocker) > MetricQueryService works not properly in k8s with IPv6

[jira] [Updated] (FLINK-31931) Exception history page should not link to a non-existent TM log page.

2023-04-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31931: --- Fix Version/s: (was: 1.18.0) > Exception history page should not link to a non-existent

[GitHub] [flink] flinkbot commented on pull request #22485: [FLINK-31835][planner] Fix the array type can't be converted from ext…

2023-04-25 Thread via GitHub
flinkbot commented on PR #22485: URL: https://github.com/apache/flink/pull/22485#issuecomment-1521496544 ## CI report: * cfa23eca0351e51b98fd315126d9002f72e5e0fc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-31935) The new resource requirements REST API is only available for session clusters

2023-04-25 Thread Jira
David Morávek created FLINK-31935: - Summary: The new resource requirements REST API is only available for session clusters Key: FLINK-31935 URL: https://issues.apache.org/jira/browse/FLINK-31935

[jira] [Assigned] (FLINK-31935) The new resource requirements REST API is only available for session clusters

2023-04-25 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek reassigned FLINK-31935: - Assignee: David Morávek > The new resource requirements REST API is only available for

[jira] [Updated] (FLINK-31835) DataTypeHint don't support Row>

2023-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31835: --- Labels: pull-request-available (was: ) > DataTypeHint don't support Row> >

[GitHub] [flink] Aitozi opened a new pull request, #22485: [FLINK-31835][planner] Fix the array type can't be converted from ext…

2023-04-25 Thread via GitHub
Aitozi opened a new pull request, #22485: URL: https://github.com/apache/flink/pull/22485 …ernal primitive array ## What is the purpose of the change In the below UDF, the return type of the function is CollectionDataType with `Array`, but it's conversion class is

[jira] [Updated] (FLINK-31766) Restoring from a retained checkpoint that was generated with changelog backend enabled might fail due to missing files

2023-04-25 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei updated FLINK-31766: --- Component/s: Runtime / Checkpointing > Restoring from a retained checkpoint that was generated with

[GitHub] [flink] dmvk closed pull request #22467: FLINK-31888: Introduce interfaces and utils for loading and executing enrichers

2023-04-25 Thread via GitHub
dmvk closed pull request #22467: FLINK-31888: Introduce interfaces and utils for loading and executing enrichers URL: https://github.com/apache/flink/pull/22467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] dmvk commented on pull request #22467: FLINK-31888: Introduce interfaces and utils for loading and executing enrichers

2023-04-25 Thread via GitHub
dmvk commented on PR #22467: URL: https://github.com/apache/flink/pull/22467#issuecomment-1521483868 The commit message should follow standard formatting: `[FLINK-XXX][component] ` This means that the current message ``` FLINK-31888: Introduce interfaces and utils

[GitHub] [flink] fredia commented on pull request #22445: [FLINK-31876][QS] Migrate flink-queryable-state-client tests to JUnit5

2023-04-25 Thread via GitHub
fredia commented on PR #22445: URL: https://github.com/apache/flink/pull/22445#issuecomment-1521455180 @jiexray @reswqa Thanks for the review, I updated the PR according to your suggestions, please help take a look again. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (FLINK-31924) [Flink operator] Flink Autoscale - Limit the max number of scale ups

2023-04-25 Thread Sriram Ganesh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716186#comment-17716186 ] Sriram Ganesh commented on FLINK-31924: --- The issue still remains the same. I tried from the main

[jira] [Closed] (FLINK-31897) Failing Unit Test: org.apache.flink.queryablestate.network.ClientTest.testRequestUnavailableHost

2023-04-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-31897. Resolution: Fixed > Failing Unit Test: >

[GitHub] [flink] TanYuxin-tyx commented on pull request #22471: [FLINK-31897] Fix the unstable test ClientTest#testRequestUnavailableHost

2023-04-25 Thread via GitHub
TanYuxin-tyx commented on PR #22471: URL: https://github.com/apache/flink/pull/22471#issuecomment-1521416377 Thanks @zentol and @reswqa for the quick reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-31897) Failing Unit Test: org.apache.flink.queryablestate.network.ClientTest.testRequestUnavailableHost

2023-04-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-31897: - Fix Version/s: 1.16.2 1.18.0 1.17.1 > Failing

[jira] [Updated] (FLINK-31897) Failing Unit Test: org.apache.flink.queryablestate.network.ClientTest.testRequestUnavailableHost

2023-04-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-31897: - Component/s: Runtime / Queryable State (was: API / State Processor)

[jira] [Updated] (FLINK-31897) Failing Unit Test: org.apache.flink.queryablestate.network.ClientTest.testRequestUnavailableHost

2023-04-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-31897: - Issue Type: Technical Debt (was: Bug) > Failing Unit Test: >

[jira] [Comment Edited] (FLINK-31897) Failing Unit Test: org.apache.flink.queryablestate.network.ClientTest.testRequestUnavailableHost

2023-04-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716174#comment-17716174 ] Chesnay Schepler edited comment on FLINK-31897 at 4/25/23 8:50 AM: ---

[jira] [Comment Edited] (FLINK-31897) Failing Unit Test: org.apache.flink.queryablestate.network.ClientTest.testRequestUnavailableHost

2023-04-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716174#comment-17716174 ] Chesnay Schepler edited comment on FLINK-31897 at 4/25/23 8:49 AM: ---

[GitHub] [flink] zentol merged pull request #22480: [FLINK-31897][Backport 1.16] Fix the unstable test ClientTest#testRequestUnavailableHost

2023-04-25 Thread via GitHub
zentol merged PR #22480: URL: https://github.com/apache/flink/pull/22480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zentol merged pull request #22479: [FLINK-31897][Backport 1.17] Fix the unstable test ClientTest#testRequestUnavailableHost

2023-04-25 Thread via GitHub
zentol merged PR #22479: URL: https://github.com/apache/flink/pull/22479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31897) Failing Unit Test: org.apache.flink.queryablestate.network.ClientTest.testRequestUnavailableHost

2023-04-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716174#comment-17716174 ] Chesnay Schepler commented on FLINK-31897: -- master: 918b873c0c0654b029140581c0ed49b44f9c5273 >

[GitHub] [flink] zentol merged pull request #22471: [FLINK-31897] Fix the unstable test ClientTest#testRequestUnavailableHost

2023-04-25 Thread via GitHub
zentol merged PR #22471: URL: https://github.com/apache/flink/pull/22471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] liuyongvs commented on pull request #22483: [FLINK-31118][table] Add ARRAY_UNION function.

2023-04-25 Thread via GitHub
liuyongvs commented on PR #22483: URL: https://github.com/apache/flink/pull/22483#issuecomment-1521402397 hi @snuyanzin i submit a new pr and close this https://github.com/apache/flink/pull/21958. The new implementation considers the issue of type conversion and refers to the spark

[GitHub] [flink] flinkbot commented on pull request #22484: [FLINK-31934][rocksdb][tests] Remove mocking

2023-04-25 Thread via GitHub
flinkbot commented on PR #22484: URL: https://github.com/apache/flink/pull/22484#issuecomment-1521402033 ## CI report: * 54d1e53d06b10a093bcb534820af781f04d8488e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   >